Hi
- Original Message -
> Hi,
>
> On Wed, Aug 09, 2017 at 10:49:51PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > The connect dialog isn't working properly when recent entries are for
> > spice+unix://. We could improve the recent dialog, but spicy isn't
From: Marc-André Lureau
spice_new() should probably be replaced by g_new() in all spice code
that depend on glib.
Signed-off-by: Marc-André Lureau
---
src/channel-display-gst.c | 4 ++--
src/channel-display-mjpeg.c | 4 ++--
src/channel-display.c | 2 +-
3 files changed, 5 insertions(+
>
> From: Marc-André Lureau
>
> spice_new() should probably be replaced by g_new() in all spice code
> that depend on glib.
>
> Signed-off-by: Marc-André Lureau
You have to replace also free with g_free unless you want program
to crash depending on Glib configuration.
> ---
> src/channel-di
Hi
- Original Message -
> Hi,
>
> On Wed, Aug 09, 2017 at 10:48:58PM +0200, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > spicy is only a test UI. A proper end-user UI is provided by
> > virt-viewer, vinagre or Boxes for example.
> >
> > Signed-off-by: Marc-André
Hi
- Original Message -
> >
> > From: Marc-André Lureau
> >
> > spice_new() should probably be replaced by g_new() in all spice code
> > that depend on glib.
> >
> > Signed-off-by: Marc-André Lureau
>
> You have to replace also free with g_free unless you want program
> to crash depe
From: Marc-André Lureau
g_free() should be used in pair with g_malloc/new().
There is only free() calls remaining for usbredir rules now.
Signed-off-by: Marc-André Lureau
---
src/decode-glz.c| 10 +-
src/decode-jpeg.c | 2 +-
src/decode-zlib.c | 4 ++--
src/spice-session.c |
From: Marc-André Lureau
spice_new() should probably be replaced by g_new() in all spice code
that depend on glib.
Signed-off-by: Marc-André Lureau
---
src/channel-display-gst.c | 8
src/channel-display-mjpeg.c | 6 +++---
src/channel-display.c | 4 ++--
3 files changed, 9 inse
Hi,
do you want to keep installing spicy-screenshot and spicy-stats? They are
also tools just for testing.
Pavel
2017-08-10 11:37 GMT+02:00 Marc-André Lureau :
> Hi
>
> - Original Message -
> > Hi,
> >
> > On Wed, Aug 09, 2017 at 10:48:58PM +0200, marcandre.lur...@redhat.com
> wrote:
>
Hi
- Original Message -
> Hi,
>
> do you want to keep installing spicy-screenshot and spicy-stats? They are
> also tools just for testing.
spicy-stats indeed.
spicy-screenshot may be used legitimately in scripts though.
I'll update the patch
>
> Pavel
>
> 2017-08-10 11:37 GMT+02:00
From: Marc-André Lureau
spicy is only a test UI. A proper end-user UI is provided by
virt-viewer, vinagre or Boxes for example.
spicy-stats is meant for simple measurements and tweaking during
development, I never heard of any user. And I can't think of a good
reason a user would want it.
Signe
On Thu, Aug 3, 2017 at 3:19 PM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Hi
>
> - Original Message -
> > On Thu, Aug 03, 2017 at 01:12:10PM +0100, marcandre.lur...@redhat.com
> wrote:
> > > From: Marc-André Lureau
> > >
> > > That HTTP proxy code has been added to glib 2.4
2017-08-10 12:22 GMT+02:00 Marc-André Lureau :
> Hi
>
> - Original Message -
> > Hi,
> >
> > do you want to keep installing spicy-screenshot and spicy-stats? They are
> > also tools just for testing.
>
> spicy-stats indeed.
>
> spicy-screenshot may be used legitimately in scripts though.
>
2017-08-10 12:27 GMT+02:00 :
> From: Marc-André Lureau
>
> spicy is only a test UI. A proper end-user UI is provided by
> virt-viewer, vinagre or Boxes for example.
>
> spicy-stats is meant for simple measurements and tweaking during
> development, I never heard of any user. And I can't think of
Hi,
On Thu, Aug 10, 2017 at 10:31:58AM +, Marc-André Lureau wrote:
> On Thu, Aug 3, 2017 at 3:19 PM Marc-André Lureau <
> marcandre.lur...@redhat.com> wrote:
>
> > Hi
> >
> > - Original Message -
> > > On Thu, Aug 03, 2017 at 01:12:10PM +0100, marcandre.lur...@redhat.com
> > wrote:
>
From: Victor Toso
Those functions are deprecated since 0.6 (2011) by commit:
commit 7198a37b4dcf66411df176a7c7a340262745a921
Author: Marc-André Lureau
Date: Fri Feb 18 19:42:04 2011 +0100
gtk: add multiple selection clipboard sharing
Functions removed:
* spice_main_clipboard_grab()
On Thu, Aug 10, 2017 at 12:05:07PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> g_free() should be used in pair with g_malloc/new().
>
> There is only free() calls remaining for usbredir rules now.
Ok
>
> Signed-off-by: Marc-André Lureau
Acked-by: Victor Toso
> ---
Hi,
On Thu, Aug 10, 2017 at 12:05:29PM +0200, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> spice_new() should probably be replaced by g_new() in all spice code
> that depend on glib.
>
> Signed-off-by: Marc-André Lureau
Acked-by: Victor Toso
> ---
> src/channel-display-gs
Hi
- Original Message -
> From: Victor Toso
>
> Those functions are deprecated since 0.6 (2011) by commit:
>
> commit 7198a37b4dcf66411df176a7c7a340262745a921
> Author: Marc-André Lureau
> Date: Fri Feb 18 19:42:04 2011 +0100
>
> gtk: add multiple selection clipboard sharing
Hi,
On Thu, Aug 10, 2017 at 09:19:28AM -0400, Marc-André Lureau wrote:
> Hi
>
> - Original Message -
> > From: Victor Toso
> >
> > Those functions are deprecated since 0.6 (2011) by commit:
> >
> > commit 7198a37b4dcf66411df176a7c7a340262745a921
> > Author: Marc-André Lureau
> > Dat
Hi
- Original Message -
> Hi,
>
> On Thu, Aug 10, 2017 at 09:19:28AM -0400, Marc-André Lureau wrote:
> > Hi
> >
> > - Original Message -
> > > From: Victor Toso
> > >
> > > Those functions are deprecated since 0.6 (2011) by commit:
> > >
> > > commit 7198a37b4dcf66411df176a7c7
Hi
- Original Message -
> Last break was:
>
> ommit 524277aab259fa07e9cd83288cfd1b9ac838b7e6
> Author: Marc-André Lureau
> Date: Thu May 17 16:09:59 2012 +0200
>
> Running out of reserved space, break ABI
>
>
> Since then, hopefully we bumped version-info when needed.
And I for
On Mon, Jun 12, 2017 at 3:04 PM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Hi
>
> - Original Message -
> > The macro was misused and not doing static check.
> > Spice have other working static check macros to use.
> > The macro is used only by spice-common so removing it
> >
When usbredirhost clears the current device, it resets the device and
attempts to re-attach the kernel driver for the device. The current
device is cleared when the API user explicitly sets a new device with
usbredirhost_set_device(). However, some API users call
usbredirhost_set_device(..., NULL
Allows server to tell codec and start/stop the streaming
---
spice/stream-device.h | 19 +++
1 file changed, 19 insertions(+)
diff --git a/spice/stream-device.h b/spice/stream-device.h
index 2441ac1..e0f4b99 100644
--- a/spice/stream-device.h
+++ b/spice/stream-device.h
@@ -81,6 +
This protocol is intended for guest machines with assigned hardware
devices to send encoded video and other informations that will be
handled as a normal display by Spice.
New GPU devices are capable to capture and encode video in an
efficient way. As the GPU in this case is assigned to the guest
This protocol allows a guest to send a video stream to the server.
Signed-off-by: Frediano Ziglio
---
spice/Makefile.am | 1 +
spice/stream-device.h | 128 ++
2 files changed, 129 insertions(+)
create mode 100644 spice/stream-device.h
diff
This allows to better support client mouse using streaming device
Signed-off-by: Frediano Ziglio
---
spice/stream-device.h | 27 +++
1 file changed, 27 insertions(+)
diff --git a/spice/stream-device.h b/spice/stream-device.h
index 4a16b12..df4f22d 100644
--- a/spice/stre
---
spice/stream-device.h | 20
1 file changed, 20 insertions(+)
diff --git a/spice/stream-device.h b/spice/stream-device.h
index e0f4b99..4a16b12 100644
--- a/spice/stream-device.h
+++ b/spice/stream-device.h
@@ -83,6 +83,8 @@ typedef enum StreamDevType {
STREAM_TYPE_DA
>
> This allows to better support client mouse using streaming device
>
> Signed-off-by: Frediano Ziglio
> ---
> spice/stream-device.h | 27 +++
> 1 file changed, 27 insertions(+)
>
> diff --git a/spice/stream-device.h b/spice/stream-device.h
> index 4a16b12..df4f22d 10
> On Mon, Jun 12, 2017 at 3:04 PM Marc-André Lureau <
> marcandre.lur...@redhat.com > wrote:
> > Hi
>
> > - Original Message -
>
> > > The macro was misused and not doing static check.
>
> > > Spice have other working static check macros to use.
>
> > > The macro is used only by spice
>
> When usbredirhost clears the current device, it resets the device and
> attempts to re-attach the kernel driver for the device. The current
> device is cleared when the API user explicitly sets a new device with
> usbredirhost_set_device(). However, some API users call
> usbredirhost_set_dev
Hi
- Original Message -
> From: Victor Toso
>
> The channel can be reset after disabling the shared-folder. If we had
> pending read, we should cancel it using the GCancellable for the
> demuxing code on vmcstream.c (c->cancellable) and per client operation
> (client->cancellable) which
From: Marc-André Lureau
Not to reproduce /pipe/readclose..
Signed-off-by: Marc-André Lureau
---
tests/pipe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/pipe.c b/tests/pipe.c
index 7a0dafd..a25e79b 100644
--- a/tests/pipe.c
+++ b/tests/pipe.c
@@ -250,7 +250,7
From: Marc-André Lureau
This fixes the following gcc warning:
spice-channel.c: In function ‘spice_channel_constructed’:
spice-channel.c:144:41: error: ‘%s’ directive output may be truncated writing
likely 20 or more bytes into a region of size 16 [-Werror=format-truncation=]
snprintf(c->na
From: Marc-André Lureau
Instead of printing a warning when trying to read from a closed
stream. It can happen that libsoup closes the pipe output stream while
the input stream had no pending operation, in which case the close is
successful and we shouldn't try to read from the stream anymore.
Si
From: Marc-André Lureau
The peer stream may be closed, but may have failed to close self,
because it has pending operations. In this case indicate EOS on IO
rather than returning an error. self will be close eventually on
dispose.
Signed-off-by: Marc-André Lureau
---
src/giopipe.c | 12 +++
From: Marc-André Lureau
Move g_array_set_size() there.
Signed-off-by: Marc-André Lureau
---
src/spice-channel.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index 7cd6251..642e829 100644
--- a/src/spice-channel.c
From: Marc-André Lureau
If ncaps == 0, the array will be NULL after set_size().
Signed-off-by: Marc-André Lureau
---
src/spice-channel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/spice-channel.c b/src/spice-channel.c
index 642e829..b6141cd 100644
--- a/src/spice-channel.c
+++
>
> From: Marc-André Lureau
>
> This fixes the following gcc warning:
>
> spice-channel.c: In function ‘spice_channel_constructed’:
> spice-channel.c:144:41: error: ‘%s’ directive output may be truncated writing
> likely 20 or more bytes into a region of size 16
> [-Werror=format-truncation=]
>
39 matches
Mail list logo
