URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
simo5 commented:
"""
@fidencio fidencio I do not care for unprivileged mode when it makes things way
harder then they ought to be.
sssd can always make up a root account and escalate privileges
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
I've opened https://pagure.io/SSSD/sssd/issue/3638 and let's keep the
discussion there.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
@lslebodn,
I'd like to ask you to have a ticket opened about this and we'll treat it from
there.
Also, @simo5, would you mind giving your opinion here?
"""
See the
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
lslebodn commented:
"""
Unfortunately, it was pushed without careful review.
That would not work when running sssd in non-privileged mode because `seteuid`
will fail.
And it was mentioned in
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
jhrozek commented:
"""
* master:
* f0cbe890adf696d8318373203580d709f3d38d8c
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
Adding the "Accepted" label as per @simo5's review and @olivergs's tests.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/498#issuecomment-365685945
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
olivergs commented:
"""
After testing this patch in a clean environment it worked like a charm.
Thanks!
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
Thanks for the review, @simo5. I'll add the accepted label (per your review) as
soon as I hear back from Oliver (from FleetCommander) that his tests passed as
well.
"""
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
simo5 commented:
"""
I cannot set labels, but ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/498#issuecomment-365428458
___
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
@simo5, updated the patches according to your suggestion and did a local test
here and it works like a charm.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
@simo5, can I have your bless (and ACK) on those?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/498#issuecomment-364437733
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
Patch set has been updated!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/498#issuecomment-363520010
___
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
@simo5, for some reason I couldn't add you as a reviewer, but I'd like to hear
some feedbacks from you here!
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
fidencio commented:
"""
Patch set has been updated and also there's a PR related to the design page of
this feature: https://pagure.io/SSSD/docs/pull-request/62
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/498
Title: #498: DESKPROFILE: Do not require CAP_DAC_OVERRIDE
lslebodn commented:
"""
Would you be so kind and could you firstly update design page.
ATM it is unclear who should have which access to the related directory.
Therefore it is difficult to say
15 matches
Mail list logo
