Re: acpithinkpad: a fix for the x260

2019-03-06 Thread Renato Aguiar
On Wed, Mar 06 2019, joshua stein wrote: sthen found that the HKEY version metric failed on the x260 where it reports version 1 but requires the new ACPI method of changing backlight. This diff tries to do the ACPI method on all machines and falls back to the CMOS method if that fails.

Re: Avoid system(3) in ikectl

2019-03-06 Thread Theo de Raadt
I'm not sure why this matters. Fundamentally system is fork+exec via a shell. So you write it as minimal fork+exec. What is the particular benefit you see here, is it security -- and if so, what is the security benefit? Have you identified a quoting problem? Can you pinpoint the issue and

Avoid system(3) in ikectl

2019-03-06 Thread Matthew Martin
I had sent a similar patch a while back. There seemed to me some interest, but it was never comitted. Updated to apply to -current. Apologies for the attachment; gmail still isn't sending emails sent via mutt, but I suspect the patch in the body will be mangled. - Matthew Martin" diff --git

acpithinkpad: a fix for the x260

2019-03-06 Thread joshua stein
sthen found that the HKEY version metric failed on the x260 where it reports version 1 but requires the new ACPI method of changing backlight. This diff tries to do the ACPI method on all machines and falls back to the CMOS method if that fails. Can all those that tried the previous diff

Re: libcrypto: INTEGER_cmp vs. STRING_cmp

2019-03-06 Thread Holger Mikolon
> Date: Wed, 6 Mar 2019 06:31:17 > From: Theo Buehler (snip) > If you're up for it, it would probably be a good idea to look at the > changes introduced by the commit you mentioned and see what else looks > suspicious and needs fixing. (snip) I went through the files affected by said commit

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-06 Thread Juan Francisco Cantero Hurtado
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with >

Re: relayd websocket

2019-03-06 Thread Rivo Nurges
Hi! On 3/6/19 10:20 PM, Rivo Nurges wrote: > On 3/6/19 6:36 PM, Sebastian Benoit wrote: >>> Does something like this make sense? >> >> i think the seperator list needs to include '\t' >> because https://tools.ietf.org/html/rfc7230#appendix-B includes HTAB. >> >> And i dont think you can mix ","

Re: relayd websocket

2019-03-06 Thread Rivo Nurges
On 3/6/19 6:36 PM, Sebastian Benoit wrote: >> Does something like this make sense? > > i think the seperator list needs to include '\t' > because https://tools.ietf.org/html/rfc7230#appendix-B includes HTAB. > > And i dont think you can mix "," with " \t" seperators, > because otherwise "Foo

Re: relayd websocket

2019-03-06 Thread Sebastian Benoit
Rivo Nurges(rivo.nur...@smit.ee) on 2019.03.05 22:42:13 +: > Hi! > > On 3/5/19 10:36 PM, Claudio Jeker wrote: > > I guess that this would need strcasestr() instead of strcasecmp(), since you > > are looking for the substring "Upgrade" in value. Maybe more is needed if > > we want to be sure

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-06 Thread Stefan Sperling
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > 0. "newer machines" being those with MHKV reporting version 2. If > this diff breaks on older "newer machines", this metric will have to > be changed to something else. Works fine here on x201 and x250.

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-06 Thread Claudio Jeker
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with >