Re: bge(4): enable TCP/UDP checksum offload

2012-11-05 Thread mxb
Hope there'll be some numbers over how fast the stack became. Great work! On 5 nov 2012, at 19:23, Stuart Henderson wrote: >> On 3 nov 2012, at 22:41, Christian Weisgerber wrote: >> >>> Henning's epic rewrite of the checksum handling has fixed > > On 2012/11/05 18:57, mxb wrote: >> Can some

Re: bge(4): enable TCP/UDP checksum offload

2012-11-05 Thread Landry Breuil
On Sun, Nov 04, 2012 at 12:22:31AM +0100, Christian Weisgerber wrote: > Brad Smith: > > > Here is another revision but disabling the UDP checksum offload. > > There is a bug that results in some UDP packets having a 0 checksum. > > Oh, right. I assume you are referencing this FreeBSD commit? > h

Re: bge(4): enable TCP/UDP checksum offload

2012-11-05 Thread Stuart Henderson
> On 3 nov 2012, at 22:41, Christian Weisgerber wrote: > > > Henning's epic rewrite of the checksum handling has fixed On 2012/11/05 18:57, mxb wrote: > Can someone, please, point me to the right cvs URL for those changes. > Thanks. http://anoncvs.estpak.ee/cgi-bin/cgit/openbsd-src/commit/?id=e

Re: bge(4): enable TCP/UDP checksum offload

2012-11-05 Thread mxb
Can someone, please, point me to the right cvs URL for those changes. Thanks. On 3 nov 2012, at 22:41, Christian Weisgerber wrote: > Henning's epic rewrite of the checksum handling has fixed

Re: bge(4): enable TCP/UDP checksum offload

2012-11-04 Thread Brad Smith
On Sat, Nov 03, 2012 at 06:12:23PM -0400, Brad Smith wrote: > On Sat, Nov 03, 2012 at 09:41:08PM +, Christian Weisgerber wrote: > > Previously, we couldn't enable TCP/UDP transmit checksum offload > > on chipsets that require the checksum field to be initialized with > > the pseudo-header check

Re: bge(4): enable TCP/UDP checksum offload

2012-11-03 Thread Christian Weisgerber
Brad Smith: > Here is another revision but disabling the UDP checksum offload. > There is a bug that results in some UDP packets having a 0 checksum. Oh, right. I assume you are referencing this FreeBSD commit? http://svnweb.freebsd.org/base/head/sys/dev/bge/if_bge.c?r1=211595&r2=211596&diff_for

Re: bge(4): enable TCP/UDP checksum offload

2012-11-03 Thread Brad Smith
On Sat, Nov 03, 2012 at 09:41:08PM +, Christian Weisgerber wrote: > Previously, we couldn't enable TCP/UDP transmit checksum offload > on chipsets that require the checksum field to be initialized with > the pseudo-header checksum because this would break rdr-to 127.0.0.1. > > Henning's epic r

Re: bge(4): enable TCP/UDP checksum offload

2012-11-03 Thread Christiano F. Haesbaert
On 03/11/2012, Christian Weisgerber wrote: > Previously, we couldn't enable TCP/UDP transmit checksum offload > on chipsets that require the checksum field to be initialized with > the pseudo-header checksum because this would break rdr-to 127.0.0.1. > > Henning's epic rewrite of the checksum hand