[PATCH v4 00/12] Integrate EFI capsule tasks into u-boot's build flow

2023-07-15 Thread Sughosh Ganu
specifiers. * Add entries for generating capsules with version parameter. * Use blob nodes instead of incbin for including the binaries in FIT image. * Enable generation of capsules with versioning support. Sughosh Ganu (12): binman: bintool: Build a tool from a list of commands nuvoton: npcm845

Re: [PATCH v2 5/8] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-07-15 Thread Sughosh Ganu
On Fri, 14 Jul 2023 at 16:14, Michal Simek wrote: > > > > On 6/24/23 15:41, Sughosh Ganu wrote: > > Add support for specifying the parameters needed for capsule > > generation through a config file, instead of passing them through > > command-line. Parameters for m

Re: [PATCH v3 11/11] sandbox: capsule: Generate capsule related files through binman

2023-07-11 Thread Sughosh Ganu
hi Simon, On Tue, 11 Jul 2023 at 03:09, Simon Glass wrote: > > Hi, > > On Sun, 9 Jul 2023 at 07:34, Sughosh Ganu wrote: > > > > The EFI capsule files can now be generated as part of u-boot > > build. This is done through binman. Add capsule entry nodes in the &

Re: [PATCH v3 10/11] sandbox: capsule: Add a config file for generating capsules

2023-07-11 Thread Sughosh Ganu
hi Simon, On Tue, 11 Jul 2023 at 03:08, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 9 Jul 2023 at 07:34, Sughosh Ganu wrote: > > > > Support has been added to the mkeficapsule tool to generate capsules > > by parsing the capsule parameters through a conf

Re: [PATCH v3 06/11] binman: capsule: Add support for generating capsules

2023-07-11 Thread Sughosh Ganu
hi Simon, On Tue, 11 Jul 2023 at 03:08, Simon Glass wrote: > > Hi Sughosh, > > On Sun, 9 Jul 2023 at 07:34, Sughosh Ganu wrote: > > > > Add support in binman for generating capsules. The capsule parameters > > can be specified either through a config file or throug

Re: [PATCH v3 02/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-10 Thread Sughosh Ganu
hi Heinrich, On Sun, 9 Jul 2023 at 19:22, Heinrich Schuchardt wrote: > > > > Am 9. Juli 2023 15:33:17 MESZ schrieb Sughosh Ganu : > >The EFI capsule authentication logic in u-boot expects the public key > >in the form of an EFI Signature List(ESL) to be provided as part

[PATCH v3 11/11] sandbox: capsule: Generate capsule related files through binman

2023-07-09 Thread Sughosh Ganu
was used for generating this FIT image. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch for generating the capsules and capsule input files through binman. arch/sandbox/dts/u-boot.dtsi | 143 ++ test/py/tests/test_efi_capsule/conftest.py| 62

[PATCH v3 10/11] sandbox: capsule: Add a config file for generating capsules

2023-07-09 Thread Sughosh Ganu
the config file on the sandbox variant. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch to add the capsule generation config file for sandbox. .azure-pipelines.yml | 1 + .gitlab-ci.yml| 1 + configs/sandbox_defconfig

[PATCH v3 09/11] test: capsule: Remove public key embed logic from capsule update test

2023-07-09 Thread Sughosh Ganu
-by: Sughosh Ganu --- Changes since V2: * New patch for removing the capsule key and ESL generation logic from the capsule test config file. configs/sandbox_defconfig| 1 + configs/sandbox_flattree_defconfig | 1 + test/py/tests/test_efi_capsule/conftest.py | 30

[PATCH v3 08/11] test: py: Setup capsule files for testing

2023-07-09 Thread Sughosh Ganu
up in the pytest configuration file for testing the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch for setting up the capsule files in the pytest setup before initiation of u-boot build. test/py/conftest.py | 87 + 1 f

[PATCH v3 07/11] CI: capsule: Setup the files needed for capsule update testing

2023-07-09 Thread Sughosh Ganu
up in the CI configuration files for testing the capsule update feature. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch setting up the capsule files needed for CI run .azure-pipelines.yml | 21 + .gitlab-ci.yml | 19 +++ 2 files changed,

[PATCH v3 06/11] binman: capsule: Add support for generating capsules

2023-07-09 Thread Sughosh Ganu
Add support in binman for generating capsules. The capsule parameters can be specified either through a config file or through the capsule binman entry. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch which generates capsules through binman replacing the earlier make target

[PATCH v3 05/11] doc: Add documentation to describe capsule config file format

2023-07-09 Thread Sughosh Ganu
The UEFI capsule can be generated either through command-line parameters, or, by specifying those in a config file. Add documentation to describe the format of the config file. Signed-off-by: Sughosh Ganu --- Changes since V2: None doc/develop/uefi/uefi.rst | 64

[PATCH v3 04/11] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-07-09 Thread Sughosh Ganu
. This path is to be used for generating capsules through a make target, with the parameters being parsed from the config file. Signed-off-by: Sughosh Ganu --- Changes since V2: * Add a Kconfig boolean symbol CONFIG_EFI_USE_CAPSULE_CFG_FILE which can be used to generate capsules through config file

[PATCH v3 02/11] capsule: authenticate: Add capsule public key in platform's dtb

2023-07-09 Thread Sughosh Ganu
the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V2: * Add the public key ESL file through the u-boot.dtsi. * Add the dtsi files for sandbox and arm architectures. * Add a check in the Makefile that the ESL file path is not empty. arch/arm/dts/u-boot.dtsi | 17

[PATCH v3 03/11] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-07-09 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu --- Changes since V2: * Highlight the need to use the u-boot.dtsi file for embedding the public key ESL into the DTB. doc

[PATCH v3 01/11] nuvoton: npcm845-evb: Add a newline at the end of file

2023-07-09 Thread Sughosh Ganu
Add a newline at the end of the dts, without which the build fails when including the u-boot.dtsi file. Signed-off-by: Sughosh Ganu --- Changes since V2: * New patch arch/arm/dts/nuvoton-npcm845-evb.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/dts/nuvoton

[PATCH v3 00/11] Integrate EFI capsule tasks into u-boot's build flow

2023-07-09 Thread Sughosh Ganu
and ESL generation logic from the capsule test config file. * New patch to add the capsule generation config file for sandbox. * New patch for generating the capsules and capsule input files through binman. Sughosh Ganu (11): nuvoton: npcm845-evb: Add a newline at the end of file capsule

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-28 Thread Sughosh Ganu
hi Simon, On Wed, 28 Jun 2023 at 15:49, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 28 Jun 2023 at 11:00, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Wed, 28 Jun 2023 at 13:12, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-28 Thread Sughosh Ganu
hi Simon, On Wed, 28 Jun 2023 at 13:12, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 27 Jun 2023 at 18:42, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Tue, 27 Jun 2023 at 17:51, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-27 Thread Sughosh Ganu
hi Simon, On Tue, 27 Jun 2023 at 17:51, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 27 Jun 2023 at 13:08, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Tue, 27 Jun 2023 at 16:50, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-27 Thread Sughosh Ganu
hi Simon, On Tue, 27 Jun 2023 at 16:50, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 27 Jun 2023 at 05:57, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Mon, 26 Jun 2023 at 17:43, Sughosh Ganu wrote: > > > > > > hi Simon, > &

Re: [PATCH 1/7] capsule: authenticate: Embed capsule public key in platform's dtb

2023-06-27 Thread Sughosh Ganu
hi Simon, On Tue, 27 Jun 2023 at 15:44, Simon Glass wrote: > > Hi, > > On Tue, 27 Jun 2023 at 10:55, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Mon, 26 Jun 2023 at 14:19, Simon Glass wrote: > > > > > > Hi Ilias, > > > > > > On Mon, 26 Jun 2023 at 10:53, Ilias Apalodimas > > >

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-26 Thread Sughosh Ganu
hi Simon, On Mon, 26 Jun 2023 at 17:43, Sughosh Ganu wrote: > > hi Simon, > > On Mon, 26 Jun 2023 at 14:38, Simon Glass wrote: > > > > Hi Sughosh, > > > > On Wed, 21 Jun 2023 at 05:26, Sughosh Ganu wrote: > > > > > > hi Simon, > &

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-26 Thread Sughosh Ganu
hi Simon, On Mon, 26 Jun 2023 at 14:38, Simon Glass wrote: > > Hi Sughosh, > > On Wed, 21 Jun 2023 at 05:26, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Mon, 19 Jun 2023 at 18:07, Simon Glass wrote: > > > > > > Hi Sughosh,

[PATCH v2 1/8] fdt_add_pubkey: Add support for adding ESL public key under signature node

2023-06-24 Thread Sughosh Ganu
key added for FIT signature verification, the ESL file contents are added as a whole, as a property under the signature node in the DTB. The public key in the ESL form is used by the capsule authentication feature for authenticating the capsules, prior to update. Signed-off-by: Sughosh Ganu

[PATCH v2 3/8] test: py: Change capsule authenticate test flow

2023-06-24 Thread Sughosh Ganu
. The binman node needed for invoking the corresponding entry module for embedding the ESL has been added for sandbox to facilitate testing. Signed-off-by: Sughosh Ganu --- Changes since V1: * Add the logic to generate the keys in the yml files which get used in the CI setup. * Add a fdt-esl-embed

[PATCH v2 6/8] Makefile: Add a target for building capsules

2023-06-24 Thread Sughosh Ganu
Add a target for building EFI capsules. The capsule parameters are specified through a config file, and the path to the config file is specified through CONFIG_EFI_CAPSULE_CFG_FILE. When the config file is not specified, the command only builds tools. Signed-off-by: Sughosh Ganu --- Changes

[PATCH v2 2/8] capsule: authenticate: Embed capsule public key in platform's dtb

2023-06-24 Thread Sughosh Ganu
that are packaged into the FIT image. The path to the ESL file is specified through the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- Changes since V1: * Achieve the embedding of the ESL into the DTB through binman * Add an entry type fdt-esl-embed for embedding the ESL for raw

[PATCH v2 5/8] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-24 Thread Sughosh Ganu
. This path is to be used for generating capsules through a make target, with the parameters being parsed from the config file. Signed-off-by: Sughosh Ganu --- Changes since V1: * Add a cfg-file parameter to pass the config file to the mkeficapsule tool. This results in generation of the same tool

[PATCH v2 7/8] test: efi_capsule: Test capsule generation from config file

2023-06-24 Thread Sughosh Ganu
-by: Sughosh Ganu --- Changes since V1: None configs/sandbox_defconfig | 1 + test/py/tests/test_efi_capsule/conftest.py| 107 +++--- .../test_efi_capsule/sandbox_capsule_cfg.txt | 75 3 files changed, 139 insertions(+), 44 deletions(-) create mode

[PATCH v2 4/8] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-06-24 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu --- Changes since V1: None doc/develop/uefi/uefi.rst | 19 +-- 1 file changed, 5 insertions(+), 14 deletions

[PATCH v2 0/8] Integrate EFI capsule tasks into u-boot's build flow

2023-06-24 Thread Sughosh Ganu
to the mkeficapsule tool. This results in generation of the same tool image irrespective of using command-line parameters or config file. * Call the mkeficapsule utility with the cfg-file parameter when building capsules via the config file. Sughosh Ganu (8): fdt_add_pubkey: Add support for adding

[PATCH v2 8/8] doc: Add documentation to describe capsule config file format

2023-06-24 Thread Sughosh Ganu
The UEFI capsule can be generated either through command-line parameters, or, by specifying those in a config file. Add documentation to describe the format of the config file. Signed-off-by: Sughosh Ganu --- Changes since V1: None doc/develop/uefi/uefi.rst | 64

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-20 Thread Sughosh Ganu
hi Simon, On Mon, 19 Jun 2023 at 18:07, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 15 Jun 2023 at 17:25, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH 1/7] capsule: authenticate: Embed capsule public key in platform's dtb

2023-06-20 Thread Sughosh Ganu
hi Simon, On Mon, 19 Jun 2023 at 18:07, Simon Glass wrote: > > Hi Sughosh, > > On Thu, 15 Jun 2023 at 17:11, Sughosh Ganu wrote: > > > > hi Simon, > > > > On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote: > > > > > > Hi Sughosh,

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-19 Thread Sughosh Ganu
hi Malte, On Fri, 16 Jun 2023 at 18:42, Schmidt, Malte wrote: > > Hi sughosh, > > Am 16.06.2023 um 08:35 schrieb Sughosh Ganu: > > On Fri, 16 Jun 2023 at 10:48, Takahiro Akashi > wrote: > > On Fri, Jun 16, 2023 at 10:37:01AM +0530, Sughosh Ganu wrote: > > hi

Re: [PATCH 2/5] mkeficapsule: add support for multiple payloads inside capsule

2023-06-17 Thread Sughosh Ganu
On Sat, 17 Jun 2023 at 06:26, AKASHI Takahiro wrote: > > On Fri, Jun 16, 2023 at 06:02:52PM +0530, Sughosh Ganu wrote: > > On Fri, 16 Jun 2023 at 17:56, Sughosh Ganu wrote: > > > > > > hi Stefan, > > > > > > On Fri, 16 Jun 2023 at 17:04, Stefan He

Re: [PATCH 2/5] mkeficapsule: add support for multiple payloads inside capsule

2023-06-16 Thread Sughosh Ganu
On Fri, 16 Jun 2023 at 17:56, Sughosh Ganu wrote: > > hi Stefan, > > On Fri, 16 Jun 2023 at 17:04, Stefan Herbrechtsmeier > wrote: > > > > From: Malte Schmidt > > > > The UEFI [1] specification allows multiple payloads inside the capsule > >

Re: [PATCH 2/5] mkeficapsule: add support for multiple payloads inside capsule

2023-06-16 Thread Sughosh Ganu
hi Stefan, On Fri, 16 Jun 2023 at 17:04, Stefan Herbrechtsmeier wrote: > > From: Malte Schmidt > > The UEFI [1] specification allows multiple payloads inside the capsule > body. Add support for this. The command line arguments are kept > backwards-compatible. > > [1]

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-16 Thread Sughosh Ganu
On Fri, 16 Jun 2023 at 10:48, Takahiro Akashi wrote: > > On Fri, Jun 16, 2023 at 10:37:01AM +0530, Sughosh Ganu wrote: > > hi Takahiro, > > > > On Fri, 16 Jun 2023 at 10:16, Takahiro Akashi > > wrote: > > > > > > Hi Sughosh, > > > >

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-15 Thread Sughosh Ganu
hi Takahiro, On Fri, 16 Jun 2023 at 10:16, Takahiro Akashi wrote: > > Hi Sughosh, > > On Fri, Jun 16, 2023 at 09:56:33AM +0530, Sughosh Ganu wrote: > > On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi > > wrote: > > > > > > On Thu, Jun 15, 20

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-15 Thread Sughosh Ganu
On Thu, 15 Jun 2023 at 11:19, Takahiro Akashi wrote: > > On Thu, Jun 15, 2023 at 10:09:06AM +0530, Sughosh Ganu wrote: > > On Wed, 14 Jun 2023 at 11:23, Takahiro Akashi > > wrote: > > > > > > On Wed, Jun 14, 2023 at 10:56:23AM +0530, Sug

Re: [PATCH 5/7] Makefile: Add a target for building capsules

2023-06-15 Thread Sughosh Ganu
hi Simon, On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 13 Jun 2023 at 11:39, Sughosh Ganu wrote: > > > > Add a target for building EFI capsules. The capsule parameters are > > specified through a config file, and the path to th

Re: [PATCH 1/7] capsule: authenticate: Embed capsule public key in platform's dtb

2023-06-15 Thread Sughosh Ganu
hi Simon, On Thu, 15 Jun 2023 at 14:44, Simon Glass wrote: > > Hi Sughosh, > > On Tue, 13 Jun 2023 at 11:41, Sughosh Ganu wrote: > > > > The EFI capsule authentication logic in u-boot expects the public key > > in the form of an EFI Signature Li

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-14 Thread Sughosh Ganu
On Wed, 14 Jun 2023 at 11:23, Takahiro Akashi wrote: > > On Wed, Jun 14, 2023 at 10:56:23AM +0530, Sughosh Ganu wrote: > > hi Takahiro, > > > > On Wed, 14 Jun 2023 at 09:09, Takahiro Akashi > > wrote: > > > > > > Hi Sughosh, > > &g

Re: [PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-13 Thread Sughosh Ganu
hi Takahiro, On Wed, 14 Jun 2023 at 09:09, Takahiro Akashi wrote: > > Hi Sughosh, > > I think this is a good extension to mkeficapsule, but > > On Tue, Jun 13, 2023 at 04:08:03PM +0530, Sughosh Ganu wrote: > > Add support for specifying the parameters needed for capsul

[PATCH 6/7] test: efi_capsule: Test capsule generation from config file

2023-06-13 Thread Sughosh Ganu
-by: Sughosh Ganu --- configs/sandbox_defconfig | 1 + test/py/tests/test_efi_capsule/conftest.py| 106 +++--- .../test_efi_capsule/sandbox_capsule_cfg.txt | 75 + 3 files changed, 139 insertions(+), 43 deletions(-) create mode 100644 test/py/tests

[PATCH 7/7] doc: Add documentation to describe capsule config file format

2023-06-13 Thread Sughosh Ganu
The UEFI capsule can be generated either through command-line parameters, or, by specifying those in a config file. Add documentation to describe the format of the config file. Signed-off-by: Sughosh Ganu --- doc/develop/uefi/uefi.rst | 64 +++ 1 file changed

[PATCH 4/7] tools: mkeficapsule: Add support for parsing capsule params from config file

2023-06-13 Thread Sughosh Ganu
. This path is to be used for generating capsules through a make target, with the parameters being parsed from the config file. Signed-off-by: Sughosh Ganu --- tools/Kconfig | 9 + tools/Makefile | 1 + tools/eficapsule.h | 110 tools/mkeficapsule.c

[PATCH 5/7] Makefile: Add a target for building capsules

2023-06-13 Thread Sughosh Ganu
Add a target for building EFI capsules. The capsule parameters are specified through a config file, and the path to the config file is specified through CONFIG_EFI_CAPSULE_CFG_FILE. When the config file is not specified, the command only builds tools. Signed-off-by: Sughosh Ganu --- Makefile

[PATCH 3/7] doc: capsule: Document the new mechanism to embed ESL file into dtb

2023-06-13 Thread Sughosh Ganu
Update the document to specify how the EFI Signature List(ESL) file can be embedded into the platform's dtb as part of the u-boot build. Signed-off-by: Sughosh Ganu --- doc/develop/uefi/uefi.rst | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/doc/develop

[PATCH 2/7] test: py: Generate capsule keys prior to building u-boot

2023-06-13 Thread Sughosh Ganu
embeds the ESL file into the platform's dtb(s) as part of the u-boot build. This requires generating the keys and the ESL file prior to invoking the u-boot build. Bring about the same sequence of generating these files prior to invoking the u-boot build while testing. Signed-off-by: Sughosh Ganu

[PATCH 1/7] capsule: authenticate: Embed capsule public key in platform's dtb

2023-06-13 Thread Sughosh Ganu
authentication in the platform's dtb, and call this as part of building the dtb(s). This brings the embedding of the ESL in the dtb into the u-boot build flow. The path to the ESL file is specified through the CONFIG_EFI_CAPSULE_ESL_FILE symbol. Signed-off-by: Sughosh Ganu --- lib/efi_loader/Kconfig

[PATCH 0/7] Integrate EFI capsule tasks into u-boot's build flow

2023-06-13 Thread Sughosh Ganu
and sandbox_flattree variants. The capsule generation through config file is enabled for the sandbox variant, with the sandbox_flattree variant generating capsules through the command-line parameters. The document has been updated to reflect the above changes. Sughosh Ganu (7): capsule: authenticate

Re: [PATCH 1/1] fwu: fix config FWU_MULTI_BANK_UPDATE

2023-05-09 Thread Sughosh Ganu
86794052418b ("FWU: Add support for the FWU Multi Bank Update feature") > Fixes: 023d9c93932c ("efi_loader: remove CONFIG_EFI_SETUP_EARLY") > Signed-off-by: Heinrich Schuchardt > --- > lib/fwu_updates/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH] dt/bindings: fwu-mdata-mtd: drop changes outside FWU

2023-05-04 Thread Sughosh Ganu
hi Ilias, On Thu, 4 May 2023 at 16:15, Ilias Apalodimas wrote: > > Hi Rob, > > On Wed, May 03, 2023 at 12:24:39PM -0500, Rob Herring wrote: > > On Wed, May 3, 2023 at 9:37 AM Ilias Apalodimas > > wrote: > > > > > > Hi Krzysztof, > > > > > > On Tue, Apr 11, 2023 at 07:38:11AM +0200, Krzysztof

Re: [PATCH V3 2/2] ARM: dts: rockchip: rk3588s-u-boot: Add rng node

2023-04-17 Thread Sughosh Ganu
On Tue, 18 Apr 2023 at 00:15, Chris Morgan wrote: > > On Mon, Apr 17, 2023 at 06:13:18PM +0530, Sughosh Ganu wrote: > > On Thu, 13 Apr 2023 at 19:43, Chris Morgan wrote: > > > > > > From: Chris Morgan > > > > > > Add a node for the trng

Re: [PATCH V3 2/2] ARM: dts: rockchip: rk3588s-u-boot: Add rng node

2023-04-17 Thread Sughosh Ganu
On Thu, 13 Apr 2023 at 19:43, Chris Morgan wrote: > > From: Chris Morgan > > Add a node for the trng found on RK3588 SoCs. > > Changes in V3: > - Added Reviewed-By tag. > > Changes in V2: > - None > > Signed-off-by: Chris Morgan > Reviewed-by: Kever Yang > --- >

Re: [PATCH V3 2/2] ARM: dts: rockchip: rk3588s-u-boot: Add rng node

2023-04-17 Thread Sughosh Ganu
patch. Other than that Acked-by: Sughosh Ganu -sughosh > > Signed-off-by: Chris Morgan > Reviewed-by: Kever Yang > --- > arch/arm/dts/rk3588s-u-boot.dtsi | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi > b/arch/a

Re: [PATCH V3 1/2] rockchip: rng: add trngv1 for rk3588

2023-04-17 Thread Sughosh Ganu
hi Chris, On Thu, 13 Apr 2023 at 19:43, Chris Morgan wrote: > > From: Chris Morgan > > This adds support for the TRNG found in the RK3588 SoC to the > rockchip_rng driver so that it can be used for things such as > seeding randomness to Linux. > > Changes in V3: > - Moved notes from commit to

Re: [PATCH] qemu: dfu: Correct memset call in set_dfu_alt_info

2023-04-07 Thread Sughosh Ganu
> As we're calling memset with the length set to the size of the pointer > and not the size of the buffer. Correct this with a call of the size of > the buffer itself. > > Signed-off-by: Tom Rini > --- Acked-by: Sughosh Ganu -sughosh > Cc: Tuomas Tynkkynen > Cc: Sugho

Re: [PATCH v6 0/7] fwu: gpt: implement read_mdata and write_mdata callbacks

2023-03-24 Thread Sughosh Ganu
| 105 ++- > drivers/fwu-mdata/fwu-mdata-uclass.c | 151 + > drivers/fwu-mdata/gpt_blk.c | 175 +++ > include/fwu.h | 198 ++-- > lib/fwu_updates/fwu.c | 296 -- > test/dm/fwu_mdata.c | 22 +- > 7 files changed, 299 insertions(+), 665 deletions(-) Tested the changes on the STM32MP1 DK2 board. Tested-by: Sughosh Ganu -sughosh

Re: [PATCH v6 5/7] fwu: meta-data: switch to management by common code

2023-03-16 Thread Sughosh Ganu
On Thu, 16 Mar 2023 at 13:56, Ilias Apalodimas wrote: > > On Mon, Mar 06, 2023 at 05:18:41PM -0600, jassisinghb...@gmail.com wrote: > > From: Jassi Brar > > > > The common code can now read, verify and fix meta-data copies > > while exposing one consistent structure to users. > > Only the

Re: [PATCHv3 2/5] FWU: mtd: Add helper functions for accessing FWU metadata

2023-01-13 Thread Sughosh Ganu
On Mon, 9 Jan 2023 at 06:36, Jassi Brar wrote: > > From: Sughosh Ganu > > Add helper functions needed for accessing the FWU metadata which > contains information on the updatable images. > > Signed-off-by: Sughosh Ganu > Signed-off-by: Jassi Brar > --- This

Re: [PATCHv3 1/5] FWU: Add FWU metadata access driver for MTD storage regions

2023-01-13 Thread Sughosh Ganu
On Mon, 9 Jan 2023 at 06:36, Jassi Brar wrote: > > From: Sughosh Ganu > > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, on a separate > region. Add a driver for reading from and writing to the metadata &g

[PATCH] sandbox: Move the capsule GUID declarations to board file

2022-11-10 Thread Sughosh Ganu
The sandbox config file is to be removed. Move the GUID declarations needed for capsule update functionality to the board file where they are used. Signed-off-by: Sughosh Ganu --- board/sandbox/sandbox.c | 13 + include/configs/sandbox.h | 13 - 2 files changed, 13

[PATCH v5 3/3] rockpi4: capsule: Enable UEFI capsule update on RockPi4 boards

2022-11-10 Thread Sughosh Ganu
Enable the UEFI capsule update functionality on the RockPi4B and RockPi4C boards. Support is being enabled for updating the idbloader and u-boot firmware images residing on GPT partitioned uSD card storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Kever Yang --- Changes since V5: None

[PATCH v5 2/3] rockpi4: board: Add firmware image information for capsule updates

2022-11-10 Thread Sughosh Ganu
Add information that will be needed for enabling the UEFI capsule update feature on the RockPi4 boards. With the feature enabled, it would be possible to update the idbloader and u-boot.itb images on the RockPi4B and RockPi4C variants. Signed-off-by: Sughosh Ganu Reviewed-by: Kever Yang

[PATCH v5 1/3] rockchip: capsule: Add functions for supporting capsule updates

2022-11-10 Thread Sughosh Ganu
Add functions needed to support the UEFI capsule update feature on rockchip boards. Currently, the feature is being enabled on the RockPi4 boards with firmware images residing on GPT partitioned storage media. Signed-off-by: Sughosh Ganu Reviewed-by: Kever Yang --- Changes since V4: * Get

[PATCH v5 0/3] rockpi4: Add capsule update support

2022-11-10 Thread Sughosh Ganu
through struct efi_capsule_update_info * Mark fw_images array as a static variable * Populate num_image_type_guids through ROCKPI4_UPDATABLE_IMAGES Sughosh Ganu (3): rockchip: capsule: Add functions for supporting capsule updates rockpi4: board: Add firmware image information for capsule

Re: [PATCH v4 2/3] rockpi4: board: Add firmware image information for capsule updates

2022-11-08 Thread Sughosh Ganu
On Wed, 9 Nov 2022 at 10:52, AKASHI Takahiro wrote: > > On Tue, Nov 08, 2022 at 12:53:27PM +0530, Sughosh Ganu wrote: > > Add information that will be needed for enabling the UEFI capsule > > update feature on the RockPi4 boards. With the feature enabled, it > > wou

[PATCH v4 3/3] rockpi4: capsule: Enable UEFI capsule update on RockPi4 boards

2022-11-07 Thread Sughosh Ganu
Enable the UEFI capsule update functionality on the RockPi4B and RockPi4C boards. Support is being enabled for updating the idbloader and u-boot firmware images residing on GPT partitioned uSD card storage device. Signed-off-by: Sughosh Ganu Reviewed-by: Kever Yang --- Changes since V3: None

[PATCH v4 2/3] rockpi4: board: Add firmware image information for capsule updates

2022-11-07 Thread Sughosh Ganu
Add information that will be needed for enabling the UEFI capsule update feature on the RockPi4 boards. With the feature enabled, it would be possible to update the idbloader and u-boot.itb images on the RockPi4B and RockPi4C variants. Signed-off-by: Sughosh Ganu Reviewed-by: Kever Yang

[PATCH v4 1/3] rockchip: capsule: Add functions for supporting capsule updates

2022-11-07 Thread Sughosh Ganu
Add functions needed to support the UEFI capsule update feature on rockchip boards. Currently, the feature is being enabled on the RockPi4 boards with firmware images residing on GPT partitioned storage media. Signed-off-by: Sughosh Ganu Reviewed-by: Kever Yang --- Changes since V3: * s

[PATCH v4 0/3] rockpi4: Add capsule update support

2022-11-07 Thread Sughosh Ganu
Changes since V3: * s/blk_get_if_type_name/blk_get_uclass_name as the API was changed in 8149b1500d8 Sughosh Ganu (3): rockchip: capsule: Add functions for supporting capsule updates rockpi4: board: Add firmware image information for capsule updates rockpi4: capsule: Enable UEFI capsule

Re: [PATCH v3 0/3] rockpi4: Add capsule update support

2022-11-06 Thread Sughosh Ganu
hi Kever, On Wed, 2 Nov 2022 at 14:53, Kever Yang wrote: > > > On 2022/11/2 14:21, Sughosh Ganu wrote: > > hi Tom, > > > > On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu wrote: > >> > >> Add capsule update support for the RockPi4B and RockPi4C >

Re: [PATCH v3 0/3] rockpi4: Add capsule update support

2022-11-02 Thread Sughosh Ganu
hi Tom, On Wed, 2 Nov 2022 at 18:52, Tom Rini wrote: > > On Wed, Nov 02, 2022 at 05:23:48PM +0800, Kever Yang wrote: > > > > On 2022/11/2 14:21, Sughosh Ganu wrote: > > > hi Tom, > > > > > > On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu > >

Re: [PATCH v3 0/3] rockpi4: Add capsule update support

2022-11-02 Thread Sughosh Ganu
hi Tom, On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu wrote: > > > Add capsule update support for the RockPi4B and RockPi4C > boards. Support is being added for updating the idbloader.img and > u-boot.itb firmware images on configurations with the firmware images > stored on G

Re: [PATCH v15 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-10-21 Thread Sughosh Ganu
hi Ilias, On Fri, 21 Oct 2022 at 20:38, Ilias Apalodimas wrote: > > Hi Sughosh, > > > > > #include > > #include > > @@ -44,6 +53,96 @@ static int fwu_get_dev_mdata(struct udevice **dev, > > struct fwu_mdata *mdata) > > return ret; > > } > > > > +static int trial_counter_update(u16

Re: [PATCH v15 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-10-21 Thread Sughosh Ganu
hi Ilias, On Fri, 21 Oct 2022 at 20:33, Ilias Apalodimas wrote: > > Hi Sughosh > > > +{ > > + int ret; > > + u32 len, blk_start, blkcnt; > > + struct disk_partition info; > > + > > + ALLOC_CACHE_ALIGN_BUFFER_PAD(struct fwu_mdata, mdata_aligned, 1, > > +

[PATCH v15 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-21 Thread Sughosh Ganu
Add documentation for the FWU Multi Bank Update feature. The document describes the steps needed for setting up the platform for the feature, as well as steps for enabling the feature on the platform. Signed-off-by: Sughosh Ganu Acked-by: Etienne Carriere --- Changes since V14: * s/updation

[PATCH v15 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-21 Thread Sughosh Ganu
-by: Sughosh Ganu Reviewed-by: Ilias Apalodimas Acked-by: Etienne Carriere --- Changes since V14: * Add a range check for the oemflags passed as suggested by Etienne doc/mkeficapsule.1 | 4 tools/mkeficapsule.c | 22 +++--- 2 files changed, 23 insertions(+), 3 deletions(-) diff

[PATCH v15 11/15] FWU: cmd: Add a command to read FWU metadata

2022-10-21 Thread Sughosh Ganu
Add a command to read the metadata as specified in the FWU specification and print the fields of the metadata. Signed-off-by: Sughosh Ganu Reviewed-by: Ilias Apalodimas Reviewed-by: Etienne Carriere --- Changes since V14: None cmd/Kconfig | 6 +++ cmd/Makefile

[PATCH v15 13/15] mkeficapsule: Add support for generating empty capsules

2022-10-21 Thread Sughosh Ganu
://git.codelinaro.org/linaro/dependable-boot/mbfw/uploads/6f7ddfe3be24e18d4319e108a758d02e/mbfw.pdf Signed-off-by: Sughosh Ganu Acked-by: Ilias Apalodimas Acked-by: Etienne Carriere --- Changes since V14: None doc/mkeficapsule.1 | 29 + tools/eficapsule.h | 8 tools/mkeficapsule.c

[PATCH v15 10/15] FWU: Add support for the FWU Multi Bank Update feature

2022-10-21 Thread Sughosh Ganu
the updated bank as active bank to subsequently boot from. Signed-off-by: Sughosh Ganu --- Changes since V14: * Initialise the return value to EFI_INVALID_PARAMETER in fwu_empty_capsule_process() and get rid of the else part as suggested by Ilias * Remove the superfluous assignment

[PATCH v15 12/15] test: dm: Add test cases for FWU Metadata uclass

2022-10-21 Thread Sughosh Ganu
-- the FIT capsule test will be run on the sandbox_flattree variant. Signed-off-by: Sughosh Ganu Suggested-by: Heinrich Schuchardt Acked-by: Ilias Apalodimas --- Changes since V14: None arch/sandbox/Kconfig | 6 + arch/sandbox/dts/test.dts | 7

[PATCH v15 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-10-21 Thread Sughosh Ganu
. If the system boots in the Trial State for more than a specified number of boot counts, change the Active Bank to be booting the platform from. Call these checks through the main loop event at the time of platform boot. Signed-off-by: Sughosh Ganu Reviewed-by: Etienne Carriere --- Changes since V14

[PATCH v15 08/15] event: Add an event for main_loop

2022-10-21 Thread Sughosh Ganu
Add an event type EVT_MAIN_LOOP that can be used for registering events that need to be run after the platform has been initialised and before the main_loop function is called. Signed-off-by: Sughosh Ganu Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Acked-by: Etienne Carriere

[PATCH v15 07/15] FWU: STM32MP1: Add support to read boot index from backup register

2022-10-21 Thread Sughosh Ganu
, this value is passed through one of the SoC's backup register. Add a function to read the boot index value from the backup register. Signed-off-by: Sughosh Ganu Reviewed-by: Patrick Delaunay Acked-by: Ilias Apalodimas Acked-by: Etienne Carriere --- Changes since V14: None arch/arm/mach-stm32mp/include

[PATCH v15 05/15] stm32mp1: Add image information for capsule updates

2022-10-21 Thread Sughosh Ganu
Enabling capsule update functionality on the platform requires populating information on the images that are to be updated using the functionality. Do so for the DK2 board. Signed-off-by: Sughosh Ganu Reviewed-by: Patrick Delaunay Reviewed-by: Ilias Apalodimas Reviewed-by: Etienne Carriere

[PATCH v15 06/15] FWU: Add helper functions for accessing FWU metadata

2022-10-21 Thread Sughosh Ganu
. The function to get the dfu alternate number has been added for platforms with GPT partitioned storage devices. Platforms with other storage partition scheme need to implement their own function. Signed-off-by: Sughosh Ganu Reviewed-by: Patrick Delaunay Acked-by: Etienne Carriere Reviewed

[PATCH v15 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-10-21 Thread Sughosh Ganu
, and implementations can be added based on parameters like how the metadata partition is accessed and what type of storage device houses the metadata. Signed-off-by: Sughosh Ganu Reviewed-by: Patrick Delaunay --- Changes since V14: * Copy the primary metadata copy to the secondary metadata partition when

[PATCH v15 04/15] stm32mp1: Add a node for the FWU metadata device

2022-10-21 Thread Sughosh Ganu
The FWU metadata structure is accessed through the driver model interface. On the stm32mp157c dk2 and ev1 boards, the FWU metadata is stored on the uSD card. Add the fwu-mdata node on the u-boot specifc dtsi file for accessing the metadata structure. Signed-off-by: Sughosh Ganu Reviewed

[PATCH v15 03/15] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-10-21 Thread Sughosh Ganu
based partition scheme. Signed-off-by: Sughosh Ganu Reviewed-by: Patrick Delaunay --- Changes since V14: * Remove the check for nparts while iterating over the partitions as suggested by Ilias * Drop the superfluous braces in gpt_get_mdata_disk_part() * Add a NULL check for mdata

[PATCH v15 01/15] dt/bindings: Add bindings for GPT based FWU Metadata storage device

2022-10-21 Thread Sughosh Ganu
devices. Signed-off-by: Sughosh Ganu Reviewed-by: Heinrich Schuchardt Acked-by: Etienne Carriere Reviewed-by: Ilias Apalodimas --- Changes since V14: None .../firmware/fwu-mdata-gpt.yaml | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 doc/device-tree

[PATCH v15 00/15] FWU: Add FWU Multi Bank Update feature support

2022-10-21 Thread Sughosh Ganu
application of empty capsules only in trial state * Add a range check for the oemflags passed as suggested by Etienne * s/updation/update/ as suggested by Etienne Sughosh Ganu (15): dt/bindings: Add bindings for GPT based FWU Metadata storage device FWU: Add FWU metadata structure and driver

Re: [PATCH v14 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-20 Thread Sughosh Ganu
On Thu, 20 Oct 2022 at 19:25, Etienne Carriere wrote: > > On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > > > Add support for setting OEM flags in the capsule header. As per the > > UEFI specification, bits 0-15 of the flags member of the capsule > > header c

Re: [PATCH v14 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-10-19 Thread Sughosh Ganu
hi Ilias, On Thu, 20 Oct 2022 at 01:26, Ilias Apalodimas wrote: > > Hi Sughosh > > > [...] > > > + * > > + * Read both the metadata copies from the storage media, verify their > > checksum, > > + * and ascertain that both copies match. If one of the copies has gone bad, > > + * restore it from

Re: [PATCH v14 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-10-19 Thread Sughosh Ganu
hi Ilias, On Thu, 20 Oct 2022 at 01:31, Ilias Apalodimas wrote: > > Hi Sughosh, > > On Tue, Oct 18, 2022 at 05:13:31PM +0530, Sughosh Ganu wrote: > > The FWU Multi Bank Update specification requires the Update Agent to > > carry out certain checks at the time of p

<    1   2   3   4   5   6   7   8   9   10   >