Re: [U-Boot] [PATCH 3/4] sunxi: Add default partition scheme

2017-11-17 Thread Maxime Ripard
Hi, On Thu, Nov 16, 2017 at 11:41:57AM +, Andre Przywara wrote: > >> If I understand this correctly, these are default settings for > >> U-Boot's "mtdparts default" command, which honestly I didn't even > >> know existed so far. > > > > No, this has nothing to do with MTD. It's a default GPT

Re: [U-Boot] [PATCH 3/4] sunxi: Add default partition scheme

2017-11-17 Thread Maxime Ripard
On Thu, Nov 16, 2017 at 12:30:04PM -0500, Tom Rini wrote: > On Thu, Nov 16, 2017 at 11:41:57AM +, Andre Przywara wrote: > > Hi, > > > > On 16/11/17 11:21, Maxime Ripard wrote: > > > On Thu, Nov 16, 2017 at 10:30:38AM +, Andre Przywara wrote: > > >> Hi, > > >> > > >> On 15/11/17 21:03, Alex

Re: [U-Boot] [PATCH 3/4] sunxi: Add default partition scheme

2017-11-17 Thread Maxime Ripard
On Thu, Nov 16, 2017 at 08:42:48PM +0100, Karsten Merker wrote: > > And then on the "we" side of things, the problem here that everyone > > needs to care about it how do we setup a partition table so that we can > > have SPL where it's required by firmware to be. How is this particular > > hurdle

[U-Boot] [PATCH] disk: efi: correct the allocation size for mbr header in stack

2017-11-17 Thread Patrick Delaunay
use ALLOC_CACHE_ALIGN_BUFFER_PAD for mbr header allocation in stack to fix alloc issue in is_gpt_valid() this patch fix also issue for GPT partition handling with blocksize != 512 in set_protective_mbr() Signed-off-by: Patrick Delaunay --- in is_gpt_valid(), the line before the patch: ALLOC_CA

Re: [U-Boot] [RFC PATCH 01/10] cmd: nvedit: Get rid of the env lookup

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:22 +0100 Maxime Ripard wrote: > The nvedit command is the only user of env_driver_lookup_default > outside of the environment code itself, and it uses it only to print > the environment it's about to save to during env save. > > As we're about to rework the environment

Re: [U-Boot] [RFC PATCH 02/10] env: Make env_driver_lookup_default private

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:23 +0100 Maxime Ripard wrote: > No that there's no users of env_driver_lookup_default outside of > env/env.c, we can mark that function static and remove it from the > environment header. > > Signed-off-by: Maxime Ripard > --- > env/env.c | 2 +- > include

Re: [U-Boot] [RFC PATCH 03/10] env: Rename env_driver_lookup_default and env_get_default_location

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:24 +0100 Maxime Ripard wrote: > The env_driver_lookup_default and env_get_default_location functions > are about to get refactored to support loading from multiple > environment. > > The name is therefore not really well suited anymore. Drop the default > part to be a b

Re: [U-Boot] [RFC PATCH 04/10] env: Pass additional parameters to the env lookup function

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:25 +0100 Maxime Ripard wrote: > In preparation for the multiple environment support, let's introduce > two new parameters to the environment driver lookup function: the > priority and operation. > > The operation parameter is meant to identify, obviously, the > operatio

Re: [U-Boot] [RFC PATCH 05/10] env: Make the env save message a bit more explicit

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:26 +0100 Maxime Ripard wrote: > Since we'll soon have support for multiple environments, the > environment saving message might end up being printed multiple times > if the higher priority environment cannot be used. > > That might confuse the user, so let's make it exp

Re: [U-Boot] [RFC PATCH 06/10] env: Support multiple environments

2017-11-17 Thread Lukasz Majewski
Hi Maxime, > Now that we have everything in place to support multiple environment, > let's make sure the current code can use it. > > The priority used between the various environment is the same one > that was used in the code previously. > > At read / init times, the highest priority environme

Re: [U-Boot] [RFC PATCH 07/10] env: Allow to build multiple environments in Kconfig

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:28 +0100 Maxime Ripard wrote: > Now that we have everything in place in the code, let's allow to build > multiple environments backend through Kconfig. > > Signed-off-by: Maxime Ripard > --- > env/Kconfig | 65 > ++--

Re: [U-Boot] [RFC PATCH 08/10] env: Mark env_get_location as weak

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:29 +0100 Maxime Ripard wrote: > Allow boards and architectures to override the default environment > lookup code by overriding env_get_location. > > Signed-off-by: Maxime Ripard > --- > env/env.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [U-Boot] [RFC PATCH 09/10] sunxi: Transition from the MMC to a FAT-based environment

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:30 +0100 Maxime Ripard wrote: > The current environment has been hardcoded to an offset that starts > to be an issue given the current size of our main U-Boot binary. > > By implementing a custom environment location routine, we can always > favor the FAT-based environm

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

2017-11-17 Thread Bin Meng
Hi Philipp, On Tue, Nov 7, 2017 at 6:04 AM, Philipp Tomsich wrote: > When the FEAT_POWER flag is set/cleared for a port, power to this port > should be enabled/disabled. As many embedded xHCI controllers do not > expose a signal to control this, extra effort may be required. > > In order to link

Re: [U-Boot] [RFC PATCH 10/10] env: sunxi: Enable FAT-based environment support by default

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 10:22:31 +0100 Maxime Ripard wrote: > Now that we have everything in place to implement the transition > scheme, let's enable it by default. > > Signed-off-by: Maxime Ripard > --- > env/Kconfig | 4 > 1 file changed, 4 insertions(+) > > diff --git a/env/Kconfig b/env/

Re: [U-Boot] [PATCH v2 1/6] pico-imx6ul: Move dfu_alt_info to CONFIG_DFU_ENV_SETTINGS variable

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 09:59:44 -0200 Otavio Salvador wrote: > From: Fabio Berton > > Create CONFIG_DFU_ENV_SETTINGS to set dfu environment settings to > improve human readable code. > > Signed-off-by: Fabio Berton > Signed-off-by: Otavio Salvador > --- > > Changes in v2: None > > include/co

Re: [U-Boot] mmc1 not working on Samsung snow chromebook

2017-11-17 Thread Lukasz Majewski
On Thu, 16 Nov 2017 13:29:56 +0100 Guillaume Gardet wrote: > I found a workaround. If I disable MMC_MODE_HS_52MHz, then it is > working fine. > > I guess there is a better way to implement the following patch ? > > ** > diff --

Re: [U-Boot] mmc1 not working on Samsung snow chromebook

2017-11-17 Thread Guillaume Gardet
Le 17/11/2017 à 10:36, Lukasz Majewski a écrit : On Thu, 16 Nov 2017 13:29:56 +0100 Guillaume Gardet wrote: I found a workaround. If I disable MMC_MODE_HS_52MHz, then it is working fine. I guess there is a better way to implement the following patch ? **

[U-Boot] [PATCH v5 2/2] arm64: sun50i-h5.dtsi : update to kernel 4.14

2017-11-17 Thread Antony Antony
last Kernel commit of sun50i-h5.dtsi d86e63e1f0b7 Signed-off-by: Antony Antony --- Changes v3->v4 removed compatible from mmc0 add h5 & a64 compaitable to sun50i-h5.dtsi Changes v4->v5 update sun50i-h5.dtsi to kernel 4.14 --- arch/arm/dts/sun50i-h5.dtsi | 32

[U-Boot] [PATCH v5 1/2] sun50i: h5: Add NanoPi Neo Plus2 DT initial support

2017-11-17 Thread Antony Antony
Add initial DT for NanoPi NEO Plus2 by FriendlyARM - Allwinner quad core H5 Cortex A53 with an ARM Mali-450MP GPU - 1 GB DDR3 RAM - 8GB eMMC flash (Samsung KLM8G1WEPD-B031) - micro SD card slot - Gigabit Ethernet (external RTL8211E-VB-CG chip) - 802.11 b/g/n WiFi, Bluetooth 4.0 (Ampak AP6212A modul

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

2017-11-17 Thread Dr. Philipp Tomsich
Bin, > On 17 Nov 2017, at 10:27, Bin Meng wrote: > > Hi Philipp, > > On Tue, Nov 7, 2017 at 6:04 AM, Philipp Tomsich > > wrote: >> When the FEAT_POWER flag is set/cleared for a port, power to this port >> should be enabled/disabled. As many embedd

Re: [U-Boot] mmc1 not working on Samsung snow chromebook

2017-11-17 Thread Jaehoon Chung
Hi, On 2017년 11월 16일 21:29, Guillaume Gardet wrote: > I found a workaround. If I disable MMC_MODE_HS_52MHz, then it is working fine. > > I guess there is a better way to implement the following patch ? > > ** > diff --git a/driv

Re: [U-Boot] [PATCH v3] net: phy: marvell: Add functions to read PHY's extended registers

2017-11-17 Thread Lukasz Majewski
Hi Joe, > On 10/30/2017 02:58 PM, Lukasz Majewski wrote: > > This commit allows extended Marvell registers to be read with: > > > > foo > mdio rx FEC 3.10 > > Reading from bus FEC > > PHY at address 0: > > 3.16 - 0x1063 > > foo > mdio wx FEC 3.10 0x1011 > > > > The above code changes the way ETH

Re: [U-Boot] [PATCH v3 0/3] Most rockchip platform based boards use a key to instruct

2017-11-17 Thread Andy Yan
Hi Philipp:     Please remember to take this series if they are looks ok for you. And if you have questions about them, please let me know. On 2017年10月11日 14:59, Andy Yan wrote: the board enter download firmware mode, some boards use a adc to detect the key status, and some use a gpio. This

Re: [U-Boot] [PATCH v3 0/3] Most rockchip platform based boards use a key to instruct

2017-11-17 Thread Dr. Philipp Tomsich
Andy, Thanks for the reminder. I had this on my list as one of the next ones to be merged. Cheers, Philipp. > On 17 Nov 2017, at 11:09, Andy Yan wrote: > > Hi Philipp: > > Please remember to take this series if they are looks ok for you. And if > you have questions about them, please let

Re: [U-Boot] [PATCH v2] Revert "spi: cadence_qspi_apb: Use 32 bit indirect read transaction when possible"

2017-11-17 Thread Vignesh R
On Friday 17 November 2017 12:24 PM, Goldschmidt Simon wrote: > This reverts commit b63b46313ed29e9b0c36b3d6b9407f6eade40c8f. > > This commit changed cadence_qspi_apb to use bouncebuf.c, which invalidates > the data cache after reading. This is meant for dma transfers only and > breaks the caden

Re: [U-Boot] [PATCH] envtools: make sure version/timestamp header file are available

2017-11-17 Thread Peter Robinson
On Tue, Nov 14, 2017 at 2:47 PM, Stefan Agner wrote: > From: Stefan Agner > > With commit 84d46e7e8948 ("tools: env: allow to print U-Boot version") > the fw_env utilities need the version.h header file. Building only > the envtools in a pristine build directory will fail due to missing > header

Re: [U-Boot] [PATCH 3/4] sunxi: Add default partition scheme

2017-11-17 Thread Andre Przywara
Hi, On 17/11/17 08:27, Maxime Ripard wrote: > > I guess I also have a side question here. How do the installers deal > with the ESP partition? Would they create a new filesystem on it no > matter what, or are they a bit smarter than that? I would expect any installer to not mess with the ESP. Af

[U-Boot] [PATCH] arc: bootm: Move slave cores kick-starting under !fake

2017-11-17 Thread Alexey Brodkin
Currently slave cores will be kick-started even if we want to dry run bootm which is not what we really want. Signed-off-by: Alexey Brodkin Cc: Eugeniy Paltsev --- arch/arc/lib/bootm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arc/lib/bootm.c b/arch/arc/li

Re: [U-Boot] [PATCH 3/4] sunxi: Add default partition scheme

2017-11-17 Thread Maxime Ripard
On Fri, Nov 17, 2017 at 12:21:49PM +, Andre Przywara wrote: > Hi, > > On 17/11/17 08:27, Maxime Ripard wrote: > > > > I guess I also have a side question here. How do the installers deal > > with the ESP partition? Would they create a new filesystem on it no > > matter what, or are they a bit

[U-Boot] [PATCH] arc: cache: Add required NOPs after invalidation of instruction cache

2017-11-17 Thread Alexey Brodkin
As per ARC HS databook (see chapter 5.3.3.2) it is required to add 3 NOPs after each write to IC_IVIC which we do from now on. Signed-off-by: Alexey Brodkin Cc: Eugeniy Paltsev --- arch/arc/lib/cache.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arc/lib/cache.c b/arch/arc/li

Re: [U-Boot] [PATCH v5 1/2] sun50i: h5: Add NanoPi Neo Plus2 DT initial support

2017-11-17 Thread Maxime Ripard
On Fri, Nov 17, 2017 at 10:39:53AM +0100, Antony Antony wrote: > Add initial DT for NanoPi NEO Plus2 by FriendlyARM > - Allwinner quad core H5 Cortex A53 with an ARM Mali-450MP GPU > - 1 GB DDR3 RAM > - 8GB eMMC flash (Samsung KLM8G1WEPD-B031) > - micro SD card slot > - Gigabit Ethernet (external R

Re: [U-Boot] [PATCH v5 2/2] arm64: sun50i-h5.dtsi : update to kernel 4.14

2017-11-17 Thread Maxime Ripard
On Fri, Nov 17, 2017 at 10:39:54AM +0100, Antony Antony wrote: > last Kernel commit of sun50i-h5.dtsi d86e63e1f0b7 > > Signed-off-by: Antony Antony Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

2017-11-17 Thread Bin Meng
Hi Philipp, On Fri, Nov 17, 2017 at 5:43 PM, Dr. Philipp Tomsich wrote: > Bin, > > On 17 Nov 2017, at 10:27, Bin Meng wrote: > > Hi Philipp, > > On Tue, Nov 7, 2017 at 6:04 AM, Philipp Tomsich > wrote: > > When the FEAT_POWER flag is set/cleared for a port, power to this port > should be enable

[U-Boot] [PATCH] usb: ehci: Fix accessors for big-endian platforms and descriptors

2017-11-17 Thread Alexey Brodkin
Commit 9000eddbae0d ("drivers/usb/ehci: Use platform-specific accessors") broke USB 2.0 on big-endian platforms because for them writel/readl() does automatic conversion of BE data to LE. Proper implementation requires to use "raw" variant of these accessors which read/write data without messing w

Re: [U-Boot] [RFC PATCH 06/10] env: Support multiple environments

2017-11-17 Thread Tom Rini
On Fri, Nov 17, 2017 at 10:24:37AM +0100, Lukasz Majewski wrote: > Hi Maxime, > > > Now that we have everything in place to support multiple environment, > > let's make sure the current code can use it. > > > > The priority used between the various environment is the same one > > that was used in

Re: [U-Boot] [PATCH 1/2] usb: xhci: implement FEAT_POWER hook for switching regulators for ports

2017-11-17 Thread Dr. Philipp Tomsich
> On 17 Nov 2017, at 14:19, Bin Meng wrote: > > Hi Philipp, > > On Fri, Nov 17, 2017 at 5:43 PM, Dr. Philipp Tomsich > wrote: >> Bin, >> >> On 17 Nov 2017, at 10:27, Bin Meng wrote: >> >> Hi Philipp, >> >> On Tue, Nov 7, 2017 at 6:04 AM, Philipp Tomsich >> wrote: >> >> When the FEAT_POWE

Re: [U-Boot] [RFC PATCH 06/10] env: Support multiple environments

2017-11-17 Thread Lukasz Majewski
On Fri, 17 Nov 2017 08:41:05 -0500 Tom Rini wrote: > On Fri, Nov 17, 2017 at 10:24:37AM +0100, Lukasz Majewski wrote: > > Hi Maxime, > > > > > Now that we have everything in place to support multiple > > > environment, let's make sure the current code can use it. > > > > > > The priority used

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Rob Clark
On Sun, Nov 12, 2017 at 9:02 AM, Heinrich Schuchardt wrote: > Assignments should not be made in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > Call efi_dp_str in debug mode only. > --- > lib/efi_loader/efi_bootmgr.c | 6 -- > 1 file changed, 4 insertions(+

Re: [U-Boot] [PATCH v2 1/5] SPL: fix printing of image name

2017-11-17 Thread Simon Glass
Hi Andre, On 1 November 2017 at 03:09, André Draszik wrote: > > Hi, > > > On Tue, 2017-10-03 at 16:55 +0100, André Draszik wrote: > > From: André Draszik > > > > The maximum length of the name of the image is > > obviously not sizeof(), which is just the > > length of a pointer, but IH_NMLEN. >

Re: [U-Boot] [PATCH v2 2/5] tpm: fix reading of permanent flags

2017-11-17 Thread Simon Glass
On 3 October 2017 at 09:55, André Draszik wrote: > From: André Draszik > > The offset of the permanent flags structure is in a different > place in the response compared to what the code is doing, > which gives us a completely useless result. > > Fix by replacing hand-crafted code with generic pa

Re: [U-Boot] [PATCH v2 3/5] tpm: add tpm_get_random()

2017-11-17 Thread Simon Glass
On 3 October 2017 at 09:55, André Draszik wrote: Please add a commit message. Also where is this used? Is it dead code? Acked-by: Simon Glass > From: André Draszik > > Signed-off-by: André Draszik > --- > include/tpm.h | 12 > lib/tpm.c | 43

Re: [U-Boot] [PATCH v2 01/18] efi_loader: efi_bootmgr: do not make hidden assignments

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Assignments should not be made in the middle of nowhere. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > Call efi_dp_str in debug mode only. > --- > lib/efi_loader/efi_bootmgr.c | 6 -- > 1 file changed, 4 insertions(+),

Re: [U-Boot] [PATCH v2 09/18] efi_loader: efi_gop: use efi_add_protocol

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Use efi_add_protocol to add protocol. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_gop.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Simon Gla

Re: [U-Boot] [PATCH v2 05/18] efi_loader: reimplement LocateDevicePath

2017-11-17 Thread Simon Glass
Hi Heinrich, On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > The current implementation of efi_locate_device_path does not match > the UEFI specification. It completely ignores the protocol > parameters. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > li

Re: [U-Boot] [PATCH v2 10/18] efi_loader: simplify efi_open_protocol

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Use function efi_search_protocol. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_boottime.c | 36 ++-- > 1 file changed, 6 insertions(+), 30 deletions(-)

Re: [U-Boot] [PATCH v2 5/5] tpm: add more missing va_end()

2017-11-17 Thread Simon Glass
On 3 October 2017 at 09:55, André Draszik wrote: > From: André Draszik > > While commit 36d35345b1f6 ("tpm: add missing va_end") added > some missing calls to va_end(), it missed a few places. > > Signed-off-by: André Draszik > --- > lib/tpm.c | 5 - > 1 file changed, 4 insertions(+), 1 del

Re: [U-Boot] [PATCH v2 03/18] efi_loader: efi_dp_str should print path not node

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > efi_dp_str is meant to print a device path and not a device > node. > > The old coding only worked because efi_convert_device_node_to_text > was screwed up to expect paths instead of nodes. > > Signed-off-by: Heinrich Schuchardt > --- > v

Re: [U-Boot] [PATCH v2 04/18] efi_loader: fix efi_convert_device_node_to_text

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > We need to implement to different functions for the > EFI_DEVICE_PATH_TO_TEXT_PROTOCOL: > ConvertDeviceNodeToText > ConvertDevicePathToText > > A recent patch screwed up efi_convert_device_node_to_text > to expect a device path and not a n

Re: [U-Boot] [PATCH v2 2/9] efi_selftest: test protocol management

2017-11-17 Thread Simon Glass
On 6 November 2017 at 13:17, Heinrich Schuchardt wrote: > This unit test checks the following protocol services: > InstallProtocolInterface, UninstallProtocolInterface, > InstallMultipleProtocolsInterfaces, > UninstallMultipleProtocolsInterfaces, > HandleProtocol, ProtocolsPerHandle, > LocateHandl

Re: [U-Boot] [PATCH v2 18/18] efi_loader: helper function to add EFI object to list

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > To avoid duplicate coding provide a helper function that > initializes an EFI object and adds it to the EFI object > list. > > efi_exit() is the only place where we dereference a handle de-reference? > to obtain a protocol interface. Add

Re: [U-Boot] [PATCH 1/1] x86: don't compare pointers to 0

2017-11-17 Thread Simon Glass
On 10 November 2017 at 13:06, Heinrich Schuchardt wrote: > x86_vendor_name is defined as > > static const char *const x86_vendor_name[] > > So its elements should not be compared to 0. > > Remove superfluous paranthesis. > > Problem identified with Coccinelle. > > Signed-off-by: Heinrich Schuchard

Re: [U-Boot] [PATCH v2 7/9] efi_loader: consistently use efi_uintn_t in boot services

2017-11-17 Thread Simon Glass
On 6 November 2017 at 13:17, Heinrich Schuchardt wrote: > Consistenly use efi_uintn_t wherever the UEFI spec uses > UINTN in boot services interfaces. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_api.h | 29 ++

Re: [U-Boot] [PATCH v2 07/18] efi_loader: efi_disk: use efi_add_protocol

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Use efi_add_protocol to install protocols. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_disk.c | 39 +++ > 1 file changed, 23 insertions(+), 16 delet

Re: [U-Boot] [PATCH v2 02/18] efi_loader: size of media device path node represenation

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > In the format specifier we want to specify the maximum width > in case an ending \0 is missing. > > So slen must be used as precision and not as field width. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > l

Re: [U-Boot] [PATCH v2 06/18] efi_selftest: test EFI_DEVICE_PATH_TO_TEXT_PROTOCOL

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Provide a test for the EFI_DEVICE_PATH_TO_TEXT_PROTOCOL protocol. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_selftest/Makefile | 3 + > lib/efi_selftest/efi_selftest_devicepat

Re: [U-Boot] [PATCH v2 11/18] efi_loader: simplify find_obj

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Use function efi_search_protocol. Use efi_search_protocol(). > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_device_path.c | 43 > ++-- > 1 file chan

Re: [U-Boot] [PATCH v2 08/18] efi_loader: efi_net: use efi_add_protocol

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Use efi_add_protocol to add protocols. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi_loader/efi_net.c | 34 -- > 1 file changed, 20 insertions(+), 14 deletions(-) R

Re: [U-Boot] [PATCH 4/5] tpm: add more useful NV storage permission flags

2017-11-17 Thread Simon Glass
On 3 October 2017 at 09:52, André Draszik wrote: > From: André Draszik > > TPM_NV_PER_PPREAD: physical presence needed for reading > TPM_NV_PER_WRITEDEFINE: persistent write lock by writing size 0 > TPM_NV_PER_WRITEALL: write in one go > > Signed-off-by: André Draszik > --- > include/tpm.h | 3

Re: [U-Boot] [PATCH 1/1] Makefile: add coccicheck target

2017-11-17 Thread Simon Glass
On 10 November 2017 at 11:54, Heinrich Schuchardt wrote: > Coccinelle is a program for static code analysis. > For details on Coccinelle see > > http://coccinelle.lip6.fr/ > > Add scripts/coccicheck and Documentation/dev-tools/coccinelle.rst > copied from Linux kernel v4.14-rc8. > > The co

Re: [U-Boot] [PATCH v2 12/18] efi_loader: manage protocols in a linked list

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > include/efi_loader.h | 6 ++- > lib/efi_loader/efi_boottime.c | 107 > -- > lib/efi_loader/efi_disk.c | 1

Re: [U-Boot] [PATCH v2 14/18] efi_selftest: add missing line feed

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Add a missing line feed for an error message. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > new patch > --- > lib/efi_selftest/efi_selftest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [U-Boot] [PATCH v4 12/18] efi_selftest: correctly cleanup after selftest

2017-11-17 Thread Simon Glass
On 18 October 2017 at 10:13, Heinrich Schuchardt wrote: > After executing bootefi selftest > * restore GD > * unlink the load image handle > * return 0 or 1 and not a truncated efi_status_t. > > Signed-off-by: Heinrich Schuchardt > --- > v4 > no change > v3 > new patch split off >

Re: [U-Boot] [PATCH v2 15/18] efi_loader: output load options in helloworld

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > We need to test if we pass a valid image handle when loading > and EFI application. This cannot be done in efi_selftest as > it is not loaded as an image. > > So let's enhance helloworld to write the load options to the > console. > > Sign

Re: [U-Boot] [PATCH v2 13/18] efi_selftest: compile without special compiler flags

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > As the selftest is not compiled as an EFI binary we do not > need special compiler flags. > > This avoids the checkarmreloc error on vexpress_ca15_tc2. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > no change > --- > lib/efi

Re: [U-Boot] [RFC PATCH 06/10] env: Support multiple environments

2017-11-17 Thread Maxime Ripard
Hi Lukasz, Tom, On Fri, Nov 17, 2017 at 03:00:15PM +0100, Lukasz Majewski wrote: > On Fri, 17 Nov 2017 08:41:05 -0500 > Tom Rini wrote: > > > On Fri, Nov 17, 2017 at 10:24:37AM +0100, Lukasz Majewski wrote: > > > Hi Maxime, > > > > > > > Now that we have everything in place to support multipl

Re: [U-Boot] [PATCH v2 16/18] test/py: check return code of helloworld

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > Check that helloworld.efi returns EFI_SUCCESS. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > new patch > --- > test/py/tests/test_efi_loader.py | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass __

Re: [U-Boot] [PATCH v2 17/18] efi_loader: pass handle of loaded image

2017-11-17 Thread Simon Glass
On 12 November 2017 at 07:02, Heinrich Schuchardt wrote: > The handle of a loaded image is the value of the handle > member of the loaded image info object and not the > address of the loaded image info. > > Signed-off-by: Heinrich Schuchardt > --- > v2 > new patch > --- > cmd/bootefi.c

Re: [U-Boot] [PATCH v4 12/18] efi_selftest: allow to select a single test for exexution

2017-11-17 Thread Simon Glass
On 18 October 2017 at 10:13, Heinrich Schuchardt wrote: > Environment variable efi_selftest is passed as load options > to the selftest application. It is used to select a single > test to be executed. > > The load options are an UTF8 string. Yet I decided to keep > the name propertiy of the tests

Re: [U-Boot] [PATCH 3/4] sunxi: Add default partition scheme

2017-11-17 Thread Alexander Graf
On 17.11.17 14:04, Maxime Ripard wrote: > On Fri, Nov 17, 2017 at 12:21:49PM +, Andre Przywara wrote: >> Hi, >> >> On 17/11/17 08:27, Maxime Ripard wrote: >>> >>> I guess I also have a side question here. How do the installers deal >>> with the ESP partition? Would they create a new filesyste

[U-Boot] [RFC PATCH] usb: ehci: do not invalidate a NULL buffer

2017-11-17 Thread Dirk Behme
Its a valid use case to call ehci_submit_async() with a NULL buffer with length 0. E.g. from usb_set_configuration(). As invalidate_dcache_range() isn't able to judge if the address NULL is valid or not (depending on the SoC hardware configuration it might be valid) do the check in ehci_submit_asy

Re: [U-Boot] [RFC PATCH 06/10] env: Support multiple environments

2017-11-17 Thread Lukasz Majewski
Hi Maxime, > Hi Lukasz, Tom, > > On Fri, Nov 17, 2017 at 03:00:15PM +0100, Lukasz Majewski wrote: > > On Fri, 17 Nov 2017 08:41:05 -0500 > > Tom Rini wrote: > > > > > On Fri, Nov 17, 2017 at 10:24:37AM +0100, Lukasz Majewski wrote: > > > > Hi Maxime, > > > > > > > > > Now that we have

Re: [U-Boot] [RFC PATCH] usb: ehci: do not invalidate a NULL buffer

2017-11-17 Thread Marek Vasut
On 11/17/2017 03:28 PM, Dirk Behme wrote: > Its a valid use case to call ehci_submit_async() with a NULL buffer > with length 0. E.g. from usb_set_configuration(). > > As invalidate_dcache_range() isn't able to judge if the address > NULL is valid or not (depending on the SoC hardware configuratio

Re: [U-Boot] [PATCH 4/5] tpm: add more useful NV storage permission flags

2017-11-17 Thread sjg
On 3 October 2017 at 09:52, André Draszik wrote: > From: André Draszik > > TPM_NV_PER_PPREAD: physical presence needed for reading > TPM_NV_PER_WRITEDEFINE: persistent write lock by writing size 0 > TPM_NV_PER_WRITEALL: write in one go > > Signed-off-by: André Draszik > --- > include/tpm.h | 3

Re: [U-Boot] [PATCH] dm: core: fix member name in ofnode_union documentation

2017-11-17 Thread sjg
On 9 November 2017 at 04:44, Baruch Siach wrote: > Fixes: 4984de2baaa ("dm: core: Add ofnode to represent device tree nodes") > Cc: Simon Glass > Signed-off-by: Baruch Siach > --- > include/dm/ofnode.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass Applied t

Re: [U-Boot] [PATCH v2 3/5] tpm: add tpm_get_random()

2017-11-17 Thread sjg
On 3 October 2017 at 09:55, André Draszik wrote: Please add a commit message. Also where is this used? Is it dead code? Acked-by: Simon Glass > From: André Draszik > > Signed-off-by: André Draszik > --- > include/tpm.h | 12 > lib/tpm.c | 43

Re: [U-Boot] [PATCH v2 5/5] tpm: add more missing va_end()

2017-11-17 Thread sjg
On 3 October 2017 at 09:55, André Draszik wrote: > From: André Draszik > > While commit 36d35345b1f6 ("tpm: add missing va_end") added > some missing calls to va_end(), it missed a few places. > > Signed-off-by: André Draszik > --- > lib/tpm.c | 5 - > 1 file changed, 4 insertions(+), 1 del

Re: [U-Boot] [PATCH] dm: core: Correct address cast in dev_read_addr_ptr()

2017-11-17 Thread sjg
On Sun, Oct 01, 2017 at 12:31:21AM +0200, Dr. Philipp Tomsich wrote: > > > On 30 Sep 2017, at 22:32, Tom Rini wrote: > > > > On Sat, Sep 30, 2017 at 06:08:02PM +0200, Dr. Philipp Tomsich wrote: > >> Simon, > >> > >>> On 28 Sep 2017, at 18:14, Dr. Philipp Tomsich > >>> wrote: > >>> > >>> > O

Re: [U-Boot] [PATCH] cmd/fdt.c align data buffer to avoid unaligned word access

2017-11-17 Thread sjg
On 28 September 2017 at 03:29, Bernhard Messerklinger wrote: > Since the compiler is free to place a char array to any address in > memory (in this case the stack), also to a non word aligned address the > function "fdt_prop_parse" runs into troubles upon it wants to write some > (fdt32_t *) to su

Re: [U-Boot] arm64: support running at addr other than linked to

2017-11-17 Thread Tom Rini
On Thu, Nov 02, 2017 at 06:11:27PM -0600, Stephen Warren wrote: > From: Stephen Warren > > This is required in the case where U-Boot is typically loaded and run at > a particular address, but for some reason the RAM at that location is not > available, e.g. due to memory fragmentation loading ot

Re: [U-Boot] am33xx: Add a function to query MPU voltage in uV

2017-11-17 Thread Tom Rini
On Wed, Oct 11, 2017 at 06:42:23PM +0200, Felix Brack wrote: > For the DM TPS65910 driver I'm working on, querying the MPU voltage > should return a value in uV. This value can then be used by the > regulator's standard function set_value to set the MPU voltage. > > Signed-off-by: Felix Brack >

Re: [U-Boot] [U-Boot,4/5] linux/types.h: add typedef of uintptr_t

2017-11-17 Thread Tom Rini
On Tue, Oct 17, 2017 at 10:30:19PM +0900, Masahiro Yamada wrote: > Add this typedef in the same place as in Linux. This is necessary > to refactor libfdt inclusion. > > U-Boot also defines it in include/compiler.h. Of course it should > not do that, but I do not want to open a can of worms. >

Re: [U-Boot] omap3: omap3_logic: Move pinmuxing to header file

2017-11-17 Thread Tom Rini
On Mon, Nov 06, 2017 at 07:57:30PM -0600, Adam Ford wrote: > To keep the board file smaller and clean, let's move the pinmux to the header > file. > > Signed-off-by: Adam Ford > > diff --git a/board/logicpd/omap3som/omap3logic.c > b/board/logicpd/omap3som/omap3logic.c > index 40783c8..1da9e38

Re: [U-Boot] [PATCH v2 1/5] SPL: fix printing of image name

2017-11-17 Thread sjg
Hi Andre, On 1 November 2017 at 03:09, André Draszik wrote: > > Hi, > > > On Tue, 2017-10-03 at 16:55 +0100, André Draszik wrote: > > From: André Draszik > > > > The maximum length of the name of the image is > > obviously not sizeof(), which is just the > > length of a pointer, but IH_NMLEN. >

Re: [U-Boot] [PATCH v2 2/5] tpm: fix reading of permanent flags

2017-11-17 Thread sjg
On 3 October 2017 at 09:55, André Draszik wrote: > From: André Draszik > > The offset of the permanent flags structure is in a different > place in the response compared to what the code is doing, > which gives us a completely useless result. > > Fix by replacing hand-crafted code with generic pa

Re: [U-Boot] [U-Boot, u-boot, 3/3] arm: amlogic: p212: Add support for Ethernet with Internal PHY

2017-11-17 Thread Tom Rini
On Wed, Oct 18, 2017 at 10:02:12AM +0200, Neil Armstrong wrote: > This patch adds support for the Internal RMII Ethernet PHY on the > Amlogic P212 Reference Board. > > Signed-off-by: Neil Armstrong Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature ___

Re: [U-Boot] [U-Boot, v2, 1/5] mmc: arm_pl180_mmci: update arm_pl180_mmci_init() prototype

2017-11-17 Thread Tom Rini
On Mon, Oct 23, 2017 at 10:57:30AM +0200, patrice.chot...@st.com wrote: > From: Patrice Chotard > > Update arm_pl180_mmci_init() prototype by adding struct mmc** > param. This is needed before converting this driver to driver model > in order to use arm_pl180_mmci_init() in driver model and in n

Re: [U-Boot] [U-Boot, v2, 3/5] mmc: arm_pl180_mmci: add bus_width DT property support

2017-11-17 Thread Tom Rini
On Mon, Oct 23, 2017 at 10:57:32AM +0200, patrice.chot...@st.com wrote: > From: Patrice Chotard > > Allow to get "bus-width" property from device tree > > Signed-off-by: Patrice Chotard Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature _

Re: [U-Boot] [U-Boot, u-boot, 3/3] arm: add initial support for Amlogic P212 based on Meson GXL family

2017-11-17 Thread Tom Rini
On Thu, Oct 12, 2017 at 03:50:32PM +0200, Neil Armstrong wrote: > This adds platform code for the Amlogic P212 reference board based on a > Meson GXL (S905X) SoC with the Meson GXL configuration. > > This initial submission only supports UART and MMC/SDCard, support for the > internal Ethernet PH

Re: [U-Boot] [PATCH] sandbox: Add clrbits/setbits macros

2017-11-17 Thread sjg
We borrow the macros for these functions from ARM and remove references to '__raw_'. Signed-off-by: Tom Rini --- arch/sandbox/include/asm/io.h | 57 +++ 1 file changed, 57 insertions(+) Applied to u-boot-dm thanks!

Re: [U-Boot] [U-Boot, v2, 2/4] scripts/dtc: Update to upstream version v1.4.5-3-gb1a60033c110

2017-11-17 Thread Tom Rini
On Tue, Oct 17, 2017 at 01:42:42PM +0900, Masahiro Yamada wrote: > This adds the following commits from upstream: > > b1a6003 tests: Add a test for overlays syntactic sugar > 737b2df overlay: Add syntactic sugar version of overlays > 497432f checks: Use proper format modifier for size_t > 22a65c5

Re: [U-Boot] [U-Boot, 1/2] env: Save environment at the end of an MMC partition

2017-11-17 Thread Tom Rini
On Mon, Nov 06, 2017 at 02:16:37PM +0100, Jorge Ramirez-Ortiz wrote: > Allow the platform to define a partition by name at the end of which > the environment data will be located. > > Signed-off-by: Jorge Ramirez-Ortiz Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [U-Boot] [U-Boot, 1/5] libfdt: change fdt.h to a wrapper of scripts/dtc/libfdt/*

2017-11-17 Thread Tom Rini
On Tue, Oct 17, 2017 at 10:30:16PM +0900, Masahiro Yamada wrote: > Fortunately, U-Boot did not modify fdt.h locally. > > Change it to a wrapper of scripts/dtc/libfdt/fdt.h, which will be > periodically synced with the upstream DTC (or kernel). > > Signed-off-by: Masahiro Yamada Applied to u-bo

Re: [U-Boot] [U-Boot, v2, 4/4] pylibfdt: compile pylibfdt only when dtoc/binman is necessary

2017-11-17 Thread Tom Rini
On Tue, Oct 17, 2017 at 01:42:44PM +0900, Masahiro Yamada wrote: > Currently, pylibfdt is always compiled if swig is installed on your > machine. It is really annoying because most of targets (excepts > x86, sunxi, rockchip) do not use dtoc or binman. > > "checkbinman" and "checkdtoc" are wrong.

Re: [U-Boot] serial: nulldev: Implement "pending" function to fix tstc return "true"

2017-11-17 Thread Tom Rini
On Thu, Nov 02, 2017 at 11:39:51PM -0700, Wilson Lee wrote: > In U-boot, serial_tstc was use to determine is there have a character in > serial console that pending for read. If there is no "pending" function > implemented in serial driver, the serial-uclass will return "true(1)" > to indicate the

Re: [U-Boot] [PATCH v2 3/5] tpm: add tpm_get_random()

2017-11-17 Thread Simon Glass
Hi. On 17 November 2017 at 08:41, wrote: > > On 3 October 2017 at 09:55, André Draszik wrote: > > Please add a commit message. Also where is this used? Is it dead code? > > Acked-by: Simon Glass > I applied this with changes: - added a commit message - added a cast to fix a build warning on (e

Re: [U-Boot] [U-Boot,u-boot,2/3] pinctrl: meson: Add GXL Support

2017-11-17 Thread Tom Rini
On Thu, Oct 12, 2017 at 03:50:31PM +0200, Neil Armstrong wrote: > Add the Amlogic Meson GXL pinctrl support based on the GXBB driver and > the synchronized DTS from Linux 4.13.5 > > Signed-off-by: Neil Armstrong > Reviewed-by: Beniamino Galvani Applied to u-boot/master, thanks! -- Tom sign

Re: [U-Boot] [U-Boot, u-boot, 1/3] net: phy: Add Amlogic Meson GXL Internal PHY support

2017-11-17 Thread Tom Rini
On Wed, Oct 18, 2017 at 10:02:10AM +0200, Neil Armstrong wrote: > The Amlogic Meson GXL/GXM families embeds an internal RMII Ethernet PHY. > > The PHY acts as a generic PHY but needs a slight configuration right > before it's configuration. > > Signed-off-by: Neil Armstrong Applied to u-boot/m

Re: [U-Boot] [U-Boot, v2, 1/4] scripts/dtc: add fdt_overlay.c and fdt_addresses.c to sync script

2017-11-17 Thread Tom Rini
On Tue, Oct 17, 2017 at 01:42:41PM +0900, Masahiro Yamada wrote: > From: Rob Herring > > libfdt has gained some new files. We need to include them in the > kernel's copy. > > Reported-by: Kyle Yan > Signed-off-by: Rob Herring > Signed-off-by: Masahiro Yamada > > [ Linux commit: 4322323058f0

Re: [U-Boot] [U-Boot, v2, 2/5] mmc: arm_pl180_mmci: adapt driver to DM usage

2017-11-17 Thread Tom Rini
On Mon, Oct 23, 2017 at 10:57:31AM +0200, patrice.chot...@st.com wrote: > From: Patrice Chotard > > Convert this driver to driver model. > This driver is also used by VEXPRESS platforms which doesn't > use driver model. > > Tested on STM32F746 and STM32F769 platforms. > > Signed-off-by: Christ

  1   2   >