Complete series is
Reviewed-by: Wolfgang Wallner
From: Bernhard Messerklinger
Sent: Thursday, August 25, 2022 8:53
To: u-boot@lists.denx.de
Cc: Wolfgang Wallner ; Bernhard
Messerklinger ; Andre Przywara
; Christian Hewitt ; Hannes
Schmelzer ; Marcel Ziswiler
; Marek Vasut ; Pali Rohár
delete mode 100644 arch/arm/dts/am335x-brppt1-spi.dts
> delete mode 100644 configs/brppt1_nand_defconfig
> delete mode 100644 configs/brppt1_spi_defconfig
Reviewed-by: Wolfgang Wallner
m/dts/am335x-brppt1-mmc-u-boot.dtsi | 80 ++
> configs/brppt1_mmc_defconfig | 2 +-
> 2 files changed, 81 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/dts/am335x-brppt1-mmc-u-boot.dtsi
Reviewed-by: Wolfgang Wallner
; Signed-off-by: Bernhard Messerklinger
>
> ---
>
> arch/arm/dts/am335x-brppt1-mmc-u-boot.dtsi | 32
> arch/arm/dts/am335x-brppt1-mmc.dts | 201 -
> 2 files changed, 32 insertions(+), 201 deletions(-)
Reviewed-by: Wolfgang Wallner
ude/configs/brppt1.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Wolfgang Wallner
igned-off-by: Bernhard Messerklinger
>
> ---
>
> configs/brppt1_mmc_defconfig | 4 +++-
> include/configs/brppt1.h | 18 --
> 2 files changed, 15 insertions(+), 7 deletions(-)
Reviewed-by: Wolfgang Wallner
;
> Change the 's' string variable to const while we are here.
> Signed-off-by: Simon Glass
> ---
>
> Changes in v2:
> - Fix comment about argv[0] in do_zboot_parent()
>
> arch/x86/lib/zimage.c | 64 +++----
> 1 file changed, 58 insertions(+), 6 deletions(-)
Reviewed-by: Wolfgang Wallner
Hi Simon, Bin,
-"Simon Glass" schrieb: -
> Betreff: [PATCH v2 08/57] x86: acpi: Support external GNVS tables
>
> At present U-Boot puts a magic number in the ASL for the GNVS table and
> searches for it later.
>
> Add a Kconfig option to use a different approach, where the ASL files
> d
> ...
>
> Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
> Cc: Wolfgang Wallner
> Signed-off-by: Andy Shevchenko
> ---
> cmd/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Wolfgang Wallner
Tested-by: Wolfgang Wallner
Tested on
Hi Andy,
-"Andy Shevchenko" schrieb: -
> Betreff: Re: [PATCH v1] cmd: acpi: Print revisions in hex format
>
> On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
> wrote:
> > -"Andy Shevchenko" schrieb: -
> > > Betreff: [PAT
Hi Andy,
-"Andy Shevchenko" schrieb: -
> Betreff: Re: [PATCH v1] cmd: acpi: Print revisions in hex format
>
> On Tue, Sep 08, 2020 at 05:32:08PM +0200, Wolfgang Wallner wrote:
> > -"Andy Shevchenko" schrieb: -
> > > On Tue, Sep 8, 2
Add a missing memset to acpi_create_spcr().
The other acpi_create_() functions perform a memset on their
structures, acpi_create_spcr() does not and as a result the contents of
this table are partly uninitialized (and thus random after every reset).
Signed-off-by: Wolfgang Wallner
()
* Calculate DSDT length
* acpi_align()
Signed-off-by: Wolfgang Wallner
---
arch/x86/lib/acpi_table.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
index 3a93fedfc3..6b827bfa3f 100644
--- a/arch/x86/lib/acpi_table.c
+++ b
Hi Simon,
-"Simon Glass" schrieb: -
> Betreff: Re: [PATCH] acpi: device: Fix check for sequence number
>
> Hi Wolfgang,
>
> On Thu, 13 Aug 2020 at 01:23, Wolfgang Wallner
> wrote:
> >
> > Hi Simon,
> >
> > -"Simon Glass"
Hi Simon,
chromebook_coral.dts contains multiple entries of fsps,pcie-root-port-en
and fsps,pcie-rp-hot-plug.
I don't think this is intentional, as the code parsing the FSP-S settings will
only use one of those settings.
regards, Wolfgang
-- 8< -
sed a lot within U-Boot,
while "e-mmc" is only used in the FSP bindings.
Signed-off-by: Wolfgang Wallner
---
arch/x86/cpu/apollolake/fsp_bindings.c | 6 +++---
doc/device-tree-bindings/fsp/fsp2/apollolake/fsp-m.txt | 2 +-
doc/device-tree-bindings/fsp/fsp2/apollol
the option ROMs.
>
> Reported-by: Heinrich Schuchardt
> Signed-off-by: Simon Glass
> ---
>
> drivers/bios_emulator/x86emu/sys.c | 4
> 1 file changed, 4 insertions(+)
Tested-by: Wolfgang Wallner
Tested by building chromebook_coral_defconfig on an Arch Linux with GCC 10.1.0
regards, Wolfgang
An entry is missing in the FSP-S devicetree bindings, and as a result
the description for the next few following entries is off by one line.
Signed-off-by: Wolfgang Wallner
---
.../fsp/fsp2/apollolake/fsp-s.txt | 19 ++-
1 file changed, 10 insertions(+), 9
Fix copy/paste errors in the descriptions of mtrr_close () and mtrr_set().
Signed-off-by: Wolfgang Wallner
---
arch/x86/include/asm/mtrr.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h
index 3a98aacdef
CPI_OPS_PTR
>
> drivers/core/root.c | 13 +
> 1 file changed, 13 insertions(+)
Reviewed-by: Wolfgang Wallner
| 95
>--
> 5 files changed, 212 insertions(+), 13 deletions(-)
> create mode 100644 include/acpi/acpi_device.h
> create mode 100644 lib/acpi/acpi_device.c
Reviewed-by: Wolfgang Wallner
Hi Bin,
-"Bin Meng" schrieb: -
> Betreff: Re: [PATCH v2 00/35] dm: Add programmatic generation of ACPI tables
> (part B)
>
> Hi Wolfgang, Andy,
>
> On Mon, May 11, 2020 at 4:34 AM Simon Glass wrote:
> >
> > NOTE: I have resent this as v1 to avoid confusion
> >
> > This is split from t
Hi Simon,
-"Simon Glass" schrieb: -
>Betreff: [PATCH v2] test: Use ut_asserteq_mem() where possible
>
>Quite a few tests still use ut_assertok(memcmp(...)) and variants.
>Modify
>them to use the macro designed for this purpose.
>
>Suggested-by: Wolfgang W
device status.
>
>Signed-off-by: Simon Glass
>---
>
>Changes in v2: None
>Changes in v1: None
>
> include/acpi/acpi_device.h | 28
> lib/acpi/acpi_device.c | 5 +
> test/dm/acpi.c | 12 ++++
> 3 files changed, 45 insertions(+)
Reviewed-by: Wolfgang Wallner
Hi Simon,
-"Simon Glass" schrieb: -
>Betreff: [PATCH v2 04/35] irq: Add a method to convert an interrupt
>to ACPI
>
>When generating ACPI tables we need to convert IRQs in U-Boot to the
>ACPI
>structures required by ACPI. This is a SoC-specific conversion and
>cannot
>be handled by generi
Hi Simon,
-"Simon Glass" schrieb: -
> Betreff: [PATCH v2 05/35] acpi: Support generation of ACPI code
>
> Add a new file to handle generating ACPI code programatically. This is
> used when information must be dynamically added to the tables, e.g. the
> SSDT.
>
> Initial support is just
Hi Simon,
"Simon Glass" schrieb am 09.03.2020 04:44:56:
> Von: "Simon Glass"
> An: "U-Boot Mailing List" ,
> Kopie: "Bin Meng" , "Wolfgang Wallner"
> , "Andy Shevchenko"
> , "Simon Glass"
> Datum: 0
Hi Simon,
I'm resending this mail, as my email client has broken the formating
in the first attempt, sorry.
"Simon Glass" schrieb am 09.03.2020 04:44:56:
> Von: "Simon Glass"
> An: "U-Boot Mailing List" ,
> Kopie: "Bin Meng" , "
property
*/
> + ut_asserteq('c', buf[2]);
> + ut_asserteq('d', buf[3]);
> +
> + ut_asserteq('z', buf[4]);
> +
> + return 0;
> +}
> +DM_TEST(dm_test_acpi_fill_ssdt, DM_TESTF_SCAN_PDATA |
DM_TESTF_SCAN_FDT);
> --
> 2.25.1.481.gfbce0eb801-goog
>
Reviewed-by: Wolfgang Wallner
Hi Simon,
during the review of a later patch I spotted a typo in this patch
that I missed initially, see below.
"Simon Glass" schrieb am 09.03.2020 04:44:57:
> Betreff: [PATCH v2 33/39] acpi: Add support for SSDT generation
>
> Some devices need to generate code for the Secondary System Descri
Hi Simon,
-"Simon Glass" schrieb: -
>An: u-boot@lists.denx.de
>Von: "Simon Glass"
>Datum: 31.03.2020 01:14
>Kopie: "Andy Shevchenko" ,
>"Wolfgang Wallner" , "Leif
>Lindholm" , "Simon Glass" , "Bin
&g
+++
> include/dm/device.h | 5 +++
> include/log.h | 2 ++
> 6 files changed, 123 insertions(+)
> create mode 100644 drivers/core/acpi.c
> create mode 100644 include/dm/acpi.h
>
Reviewed-by: Wolfgang Wallner
Hi Simon,
-"Simon Glass" schrieb: -
>An: u-boot@lists.denx.de
>Von: "Simon Glass"
>Datum: 31.03.2020 01:14
>Kopie: "Andy Shevchenko" ,
>"Wolfgang Wallner" , "Leif
>Lindholm" , "Simon Glass"
>Be
PL_ should alwys be empty
anyway. At least that is how I understood the assigment to SPL_ in Makefile.spl.
> obj-$(CONFIG_EFI) += efi/
> obj-$(CONFIG_EFI_LOADER) += efi_driver/
> obj-$(CONFIG_EFI_LOADER) += efi_loader/
[snip]
Reviewed-by: Wolfgang Wallner
sary __packed
>- Move __packed to after struct
>
> include/acpi/acpi_table.h | 57
>+++
> lib/acpi/acpi_table.c | 28 +++
> test/dm/acpi.c| 13 +
> 3 files changed, 98 insertions(+)
Reviewed-by: Wolfgang Wallner
Hi Simon,
-"U-Boot" schrieb: -
[snip]
>> + - acpi,ddn : Contains the string to use as the _DDN (DOS (Disk
>Operating
>> +System) Device Name)
>> + - acpi,hid : Contains the string to use as the HID (Hardware ID)
>> +identifier _HID
>> + - acpi,probed : Tells U-Boot to add 'linux
Hi Andy,
> On Wed, Apr 1, 2020 at 2:54 PM Andy Shevchenko
> wrote:
> >
> > On Tue, Mar 31, 2020 at 2:31 AM Tom Rini wrote:
> > >
> > > Hey all,
> > >
> > > So, I've gotten out of the habit of tagging rcs on cycle. This month I
> > > have been taking in changes sparingly and I'm not concerned th
Hi Andy, Bin,
> -"Andy Shevchenko" schrieb: -
> On Thu, Apr 2, 2020 at 7:55 AM Bin Meng wrote:
> > On Thu, Apr 2, 2020 at 1:55 AM Simon Glass wrote:
> > > On Wed, 1 Apr 2020 at 11:39, Andy Shevchenko
> > > wrote:
> > > > On Wed, Apr 01, 2020 at 10:56:26AM -0600, Simon Glass wrote:
>
bcbd35612675c.
Note, it doesn't affect SoCFPGA case.
Cc: Wolfgang Wallner
Signed-off-by: Andy Shevchenko
---
v3: drop wrong patch, better explanation in the commit message
drivers/serial/ns16550.c | 40
1 file changed, 12 insertions(+), 28
Hi Bin,
Thanks for taking care of this!
-"Bin Meng" schrieb: -
>An: "Simon Glass" , "Tom Rini"
>, "Andy Shevchenko"
>, "Wolfgang Wallner"
>, "Chee Hong Ang"
>, "U-Boot Mailing List"
>
>Von: &quo
Move PCI access from
>ofdata_to_platdata() to probe()")
>Reported-by: Andy Shevchenko
>Signed-off-by: Bin Meng
>Tested-by: Andy Shevchenko
>Reviewed-by: Wolfgang Wallner
>Tested-by: Wolfgang Wallner
>
>---
>
>Changes in v2:
>- not to break Fixes, etc
based ns16550 wrapper
>> > driver tries to access plat->base before calling probe(), it is
>> > still subject to break.
>> >
>> > Fixes: 720f9e1fdb0c9 ("serial: ns16550: Move PCI access from
>ofdata_to_platdata() to probe()")
>> > Reported-by
unit test header
>
>Changes in v2: None
>
> include/test/ut.h | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Wolfgang Wallner
In Intel's documentation the term P2SB stands for "Primary to Sideband
Bridge".
Signed-off-by: Wolfgang Wallner
---
drivers/misc/Kconfig | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 6bb5bc77e9..b6
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.
While at it, correct the meaning of P2SB (according to Intel's
documentation P2SB stands for "Primary to Sideband Bridge").
Wolfgang Wallner (2):
drivers: p2sb: replace Primary-t
Currently it is possible to select the P2SB driver without selecting the
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.
Signed-off-by: Wolfgang Wallner
---
arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/Kconfig b/a
quot;).
Remark: I have resent this series as V2 as I had messed up the cover
letter in V1.
Changes in v2:
- Fixed cover letter
Wolfgang Wallner (2):
drivers: p2sb: replace Primary-to-Sideband Bus with Primary to
Sideband Bridge
x86: p2sb: make P2SB driver depend on P2SB uclass
arch/x86/K
In Intel's documentation the term P2SB stands for "Primary to Sideband
Bridge".
Signed-off-by: Wolfgang Wallner
---
(no changes since v1)
drivers/misc/Kconfig | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/mis
Currently it is possible to select the P2SB driver without selecting the
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.
Signed-off-by: Wolfgang Wallner
---
Changes in v2:
- Fixed cover letter
arch/x86/Kconfig | 1 +
1 file changed, 1 insertion(+
Hi Bin,
-"Bin Meng" schrieb: -
> Betreff: Re: [PATCH v2 0/2] x86: p2sb: P2SB fixes
>
> Hi Wolfgang,
>
> On Wed, Jul 1, 2020 at 5:06 PM Wolfgang Wallner
> wrote:
> >
> > Currently it is possible to select the P2SB driver without selecting the
>
Currently it is possible to select the P2SB driver without selecting the
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.
Signed-off-by: Wolfgang Wallner
---
(no changes since v2)
Changes in v2:
- Fixed cover letter
arch/x86/Kconfig | 1 +
1
In Intel's documentation the term P2SB stands for "Primary to Sideband
Bridge".
Signed-off-by: Wolfgang Wallner
---
Changes in v3:
- Replaced the term in two more places
drivers/misc/Kconfig | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drive
In Intel's documentation the term P2SB stands for "Primary to Sideband
Bridge".
Signed-off-by: Wolfgang Wallner
---
Changes in v3:
- Replaced the term in two more places
drivers/misc/Kconfig | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drive
Currently it is possible to select the P2SB driver without selecting the
P2SB uclass, which can't work. Fix this by adding a "depends on" in
Kconfig.
Signed-off-by: Wolfgang Wallner
---
(no changes since v2)
Changes in v2:
- Fixed cover letter
arch/x86/Kconfig | 1 +
1
TYPE_SHARED (1 << 4)
> +#define X86_IRQ_TYPE_WAKE (1 << 5)
Nit: BIT(4) and BIT(4) ?
> +
> +#endif
> --
> 2.27.0.290.gba653c62da-goog
Reviewed-by: Wolfgang Wallner
dd a central location for table version number")
has introduced defines for the different MADT revision numbers in
include/acpi/acpi_table.h, e.g. ACPI_MADT_REV_ACPI_3_0 for the value 2.
Could you use this instead of the hardcoded value 2?
>
> madt->lapic_addr = LAPIC_DEFAULT_B
Hi Simon,
-"Simon Glass" schrieb: -
> Betreff: [PATCH v1 37/43] x86: Store the coreboot table address in global_data
>
> At present this information is used to locate and parse the tables but is
> not stored. Store it so that we can display it to the user, e.g. with the
> 'bdinfo' comman
quot;).
Remark: I have resent this series as V2 as I had messed up the cover
letter in V1.
Changes in v3:
- Replaced the term in two more places
Changes in v2:
- Fixed cover letter
Wolfgang Wallner (2):
drivers: p2sb: replace Primary-to-Sideband Bus with Primary to
Sideband Bridge
x86: p2
quot;).
Remark: I have resent this series as V2 as I had messed up the cover
letter in V1.
Changes in v3:
- Replaced the term in two more places
Changes in v2:
- Fixed cover letter
Wolfgang Wallner (2):
drivers: p2sb: replace Primary-to-Sideband Bus with Primary to
Sideband Bridge
x86: p2
anges in v1:
> - Add new patch to add error checking for csrt table generation
>
> arch/x86/lib/acpi_table.c | 19 +--
> 1 file changed, 13 insertions(+), 6 deletions(-)
Reviewed-by: Wolfgang Wallner
Hi Simon,
I dont know NHLT well enough to actually review the code, but I did compare
the files in this patch to the version in coreboot. Most of the changes are
obvious (coding style, spelling, ...), but some things are not, see the remarks
below.
-"Simon Glass" schrieb: -
> Betreff: [P
t; + if (IS_ENABLED(CONFIG_INTEL_PINCTRL_MULTI_ACPI_DEVICES))
> + return offset;
> group = pinctrl_group_index(comm, offset);
>
> /* If pad base is not set then use GPIO number as ACPI pin number */
> --
> 2.27.0.290.gba653c62da-goog
Reviewed-by: Wolfgang Wallner
n the pin number relative to the pinctrl device.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Bin Meng
> Reviewed-by: Wolfgang Wallner
> ---
>
> Changes in v2:
> - Add help for CONFIG_INTEL_PINCTRL_MULTI_ACPI_DEVICES
Thanks for adding the help text. There is a typ
Hi Simon,
-"Simon Glass" schrieb: -
> Betreff: Re: [PATCH v1 22/43] x86: Add support for building up an NHLT
> structure
>
> Hi Wolfgang,
>
> On Thu, 2 Jul 2020 at 02:11, Wolfgang Wallner
> wrote:
> >
> > Hi Simon,
> >
> > I dont
Hi Simon, Bin,
-"Simon Glass" schrieb: -
> Betreff: Re: [PATCH v1 25/43] x86: gpio: Add support for obtaining ACPI info
> for a GPIO
>
> Hi Bin,
>
> On Tue, 30 Jun 2020 at 01:47, Bin Meng wrote:
> >
> > Hi Simon,
> >
> > On Mon, Jun 15, 2020 at 11:58 AM Simon Glass wrote:
> > >
> > >
t; (no changes since v1)
>
> drivers/pinctrl/intel/pinctrl.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Wolfgang Wallner
ommon/itss.c | 25 +++--
> arch/x86/include/asm/global_data.h | 1 +
> arch/x86/include/asm/itss.h| 2 +-
> drivers/misc/irq-uclass.c | 2 +-
> 6 files changed, 44 insertions(+), 10 deletions(-)
Reviewed-by: Wolfgang Wallner
; + return log_msg_ret("read", -E2BIG);
> +
> + speed = dev_read_u32_default(dev, "clock-frequency", 10);
> + acpigen_write_scope(ctx, path);
> + ret = dw_i2c_gen_speed_config(dev, speed, &config);
> + if (ret)
> + return log_msg_ret("config", ret);
> + dw_i2c_acpi_write_speed_config(ctx, &config);
> + acpigen_pop_len(ctx);
> +
> + return 0;
> +}
> +
> +struct acpi_ops dw_i2c_acpi_ops = {
> + .fill_ssdt = dw_i2c_acpi_fill_ssdt,
> +};
> +
> static const struct udevice_id designware_i2c_pci_ids[] = {
> { .compatible = "snps,designware-i2c-pci" },
> { .compatible = "intel,apl-i2c", .data = INTEL_APL },
> @@ -124,6 +217,7 @@ U_BOOT_DRIVER(i2c_designware_pci) = {
> .remove = designware_i2c_remove,
> .flags = DM_FLAG_OS_PREPARE,
> .ops= &designware_i2c_ops,
> + ACPI_OPS_PTR(&dw_i2c_acpi_ops)
> };
>
> static struct pci_device_id designware_pci_supported[] = {
> --
> 2.27.0.383.g050319c2ae-goog
Reviewed-by: Wolfgang Wallner
dif
> void *itss_priv; /* Private ITSS data pointer */
> ulong acpi_start; /* Start address of ACPI tables */
> + ulong coreboot_table; /* Address of coreboot table */
> };
>
> #endif
> --
> 2.27.0.383.g050319c2ae-goog
Reviewed-by: Wolfgang Wallner
Hello Bin, Simon,
-"Bin Meng" schrieb: -
> +Wolfgang Wallner
>
> On Mon, Jan 27, 2020 at 1:08 PM Simon Glass wrote:
> >
> > With P2SB the initial BAR (base-address register) is set up by TPL and
> > this is used unchanged right through U-Boot.
&
Hi Bin, Simon,
-"Bin Meng" schrieb: -
> Hi Wolfgang,
>
> On Wed, Feb 12, 2020 at 1:14 AM Simon Glass wrote:
> >
> > +Bin
> >
> > Hi Wolfgang,
> >
> > On Tue, 11 Feb 2020 at 06:59, Wolfgang Wallner
> > wrote:
> > &g
it has not yet been probed. To fix this,
move that access to the probe() method of @dev instead."
Signed-off-by: Wolfgang Wallner
Fixes: 82de42fa1468 ("dm: core: Allocate parent data separate from
probing parent")
---
The discussion leading to this patch is located at
https://lists.
intel_common folder.
Signed-off-by: Wolfgang Wallner
---
This patch follows a similar rational for P2SB as commit 03fe85a27b23
("x86: itss: Remove apl-prefix") for the ITSS.
arch/x86/cpu/intel_common/p2sb.c | 30 +--
arch/x86/dts/chromebook_coral.dts
The value for "Top of CAR region" should be fefc, not
fefc000. This matches the Kconfig default values, as
SYS_CAR_ADDR and SYS_CAR_SIZE are 0xfef0 and 0xc
respectively.
Signed-off-by: Wolfgang Wallner
---
doc/board/google/chromebook_coral.rst | 2 +-
1 file changed, 1
The function cpu_x86_get_count() is also useful for other modules.
Make it non-static and add a prototype + description.
Signed-off-by: Wolfgang Wallner
---
arch/x86/cpu/cpu_x86.c | 2 +-
arch/x86/include/asm/cpu_x86.h | 12
2 files changed, 13 insertions(+), 1 deletion
() non-static
- drops the Apollo Lake specific get_count implementation and
uses cpu_x86_get_count() instead
With the changes in this series also Apollo Lake variants with
a different number of cores boot correctly.
Wolfgang Wallner (2):
x86: cpu_x86: Make cpu_x86_get_count() non-static
.
Signed-off-by: Wolfgang Wallner
---
arch/x86/cpu/apollolake/cpu.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/x86/cpu/apollolake/cpu.c b/arch/x86/cpu/apollolake/cpu.c
index 3d05c82a5c..aa7a3dbd63 100644
--- a/arch/x86/cpu/apollolake/cpu.c
+++ b/arch/x86/cpu
Hi Bin,
-"Bin Meng" schrieb: -
> Hi Wolfgang,
>
> [snip]
>
> Unfortunately this patch breaks several ARM board:
>
> +drivers/built-in.o: In function `ofnode_get_parent':
> +drivers/core/ofnode.c:235: undefined reference to `fdt_parent_offset'
> +drivers/built-in.o: In function `ofnode_
I bus in that
method is not allowed, since it has not yet been probed. To fix this,
move that access to the probe() method of @dev instead."
Signed-off-by: Wolfgang Wallner
Fixes: 82de42fa1468 ("dm: core: Allocate parent data separate from
probing parent")
---
The discussion leading
Hi Andy,
-"U-Boot" schrieb: -
>
> [snip]
>
> > > > > P.S. Briefly looking at the last ~30 patches I can say that the idea
> > > > > looks good, implementation needs more work. For example, there is
> > > > > 'linux,name' property. Shouldn't be referred at all. Linux names and
> > > > > o
initions with DM_SPI
>
> include/spi.h | 33 +
> 1 file changed, 33 insertions(+)
Reviewed-by: Wolfgang Wallner
ion to avoid masking in this case.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Bin Meng
> ---
>
> Changes in v2: None
>
> drivers/pci/pci-uclass.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
Reviewed-by: Wolfgang Wallner
v2: None
>
> arch/x86/cpu/coreboot/timestamp.c | 4 ++--
> arch/x86/include/asm/arch-coreboot/timestamp.h | 4 ++--
> arch/x86/include/asm/intel_pinctrl_defs.h | 2 --
> 3 files changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Wolfgang Wallner
Hi Simon,
> -"Simon Glass" schrieb: -
>
> Add the C version of this header. It includes a few Chrome OS bits which
> are disabled for a normal build.
>
> Signed-off-by: Simon Glass
> ---
>
> Changes in v2:
> - Drop the Chrome OS pieces
> - Rename the 'coreboot' console to 'U-Boot'
>
Hi Simon,
-"Simon Glass" schrieb: -
>
> ACPI (Advanced Configuration and Power Interface) is an Intel standard
> for specifying information about a platform. It is a little like device
> tree but considerably more complicated and with more backslashes. A
> primary difference is that it s
Hi Simon,
-"Simon Glass" schrieb: -
>
> Devices need to report various identifiers in the ACPI tables. Rather than
> hard-coding these in drivers it is typically better to put them in the
> device tree.
>
> Add a binding file to describe this.
>
> Signed-off-by: Simon Glass
> ---
>
>
2 +-
> arch/x86/lib/zimage.c | 2 +-
> include/acpi_table.h | 394 ++
> lib/efi_loader/efi_acpi.c | 2 +-
> 12 files changed, 404 insertions(+), 386 deletions(-)
Reviewed-by: Wolfgang Wallner
file.lib | 4 ++--
> 3 files changed, 10 insertions(+), 2 deletions(-)
Reviewed-by: Wolfgang Wallner
Hi Simon,
-"Simon Glass" schrieb: -
>
> Each ACPI table has its own version number. Add the version numbers in a
> single function so we can keep them consistent and easily see what
> versions are supported.
>
> Start a new acpi_table file in a generic directory to house this function.
Hi Simon,
-"Simon Glass" schrieb: -
>
> The DMA Remapping Reporting (DMAR) table contains information about DMA
> remapping.
>
> Add a version simple version of this table with only the minimum fields
> filled out. i.e. no entries.
>
> Reviewed-by: Bin Meng
> Signed-off-by: Simon Glas
t; ---
>
> Changes in v2: None
>
> arch/x86/lib/acpi_table.c | 9 -
> include/acpi_table.h | 10 ++
> lib/acpi/acpi_table.c | 10 ++
> test/dm/acpi.c| 28
> 4 files changed, 48 insertions(+), 9 d
patch
>
> arch/sandbox/dts/test.dts | 4 ++
> arch/sandbox/include/asm/acpi_table.h | 9 +
> include/dm/uclass-id.h| 1 +
> test/dm/Makefile | 1 +
> test/dm/acpi.c| 55 +++
> 5 files changed, 70 insertions(+)
Reviewed-by: Wolfgang Wallner
Hi Simon,
looking at this patch some more I have another question, see below.
-"Simon Glass" schrieb: -
>
> This function needs to be used by sandbox for tests. Move it into the
> generic directory.
>
> Signed-off-by: Simon Glass
> Reviewed-by: Bin Meng
> ---
[snip]
> @@ -81,3 +82
0 +++
> test/dm/acpi.c| 43 +++
> 4 files changed, 138 insertions(+)
Reviewed-by: Wolfgang Wallner
g start_addr)
> acpi_inc_align(ctx, spcr->header.length);
> acpi_add_table(rsdp, spcr);
>
> + acpi_write_dev_tables(ctx);
> +
> addr = map_to_sysmem(ctx->current);
> debug("current = %lx\n", addr);
>
> --
> 2.25.1.481.gfbce0eb801-goog
Reviewed-by: Wolfgang Wallner
gn(struct acpi_ctx *ctx, uint amount)
> +{
> + ctx->current += amount;
> + acpi_align(ctx);
> +}
> diff --git a/test/dm/acpi.c b/test/dm/acpi.c
> index b87fbd16b0..0bd7e51ac9 100644
> --- a/test/dm/acpi.c
> +++ b/test/dm/acpi.c
> @@ -152,3 +152,31 @@ static int dm_test_acpi_write_tables(struct
> unit_test_state *uts)
> return 0;
> }
> DM_TEST(dm_test_acpi_write_tables, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> +
> +/* Test basic ACPI functions */
> +static int dm_test_acpi_basic(struct unit_test_state *uts)
> +{
> + struct acpi_ctx ctx;
> +
> + /* Check align works */
> + ctx.current = (void *)5;
> + acpi_align(&ctx);
> + ut_asserteq_ptr((void *)16, ctx.current);
> +
> + /* Check that align does nothing if already aligned */
> + acpi_align(&ctx);
> + ut_asserteq_ptr((void *)16, ctx.current);
> + acpi_align_large(&ctx);
> + ut_asserteq_ptr((void *)64, ctx.current);
> + acpi_align_large(&ctx);
> + ut_asserteq_ptr((void *)64, ctx.current);
> +
> + /* Check incrementing */
> + acpi_inc(&ctx, 3);
> + ut_asserteq_ptr((void *)67, ctx.current);
> + acpi_inc_align(&ctx, 3);
> + ut_asserteq_ptr((void *)80, ctx.current);
> +
> + return 0;
> +}
> +DM_TEST(dm_test_acpi_basic, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> --
> 2.25.1.481.gfbce0eb801-goog
Apart from the nits above:
Reviewed-by: Wolfgang Wallner
xsdt->entry[i] = map_to_sysmem(table);
> +
> + /* Fix XSDT length */
> + xsdt->header.length = sizeof(struct acpi_table_header) +
> + (sizeof(u64) * (i + 1));
> +
> + /* Re-calculate checksum */
> + xsdt->header.checksum = 0;
> + xsdt->header.checksum =
> + table_compute_checksum((u8 *)xsdt, xsdt->header.length);
> + }
> +
> + return 0;
> +}
> diff --git a/test/dm/acpi.c b/test/dm/acpi.c
> index 0bd7e51ac9..a2a57a29a6 100644
> --- a/test/dm/acpi.c
> +++ b/test/dm/acpi.c
> @@ -21,10 +21,14 @@ static int testacpi_write_tables(const struct udevice
> *dev,
>struct acpi_ctx *ctx)
> {
> struct acpi_dmar *dmar;
> + int ret;
>
> dmar = (struct acpi_dmar *)ctx->current;
> acpi_create_dmar(dmar, DMAR_INTR_REMAP);
> ctx->current += sizeof(struct acpi_dmar);
> + ret = acpi_add_table(ctx, dmar);
> + if (ret)
> + return log_msg_ret("add", ret);
>
> return 0;
> }
> --
> 2.25.1.481.gfbce0eb801-goog
Reviewed-by: Wolfgang Wallner
Hi Simon,
-"Simon Glass" schrieb: -
>
> We always write three basic tables to ACPI at the start. Move this into
> its own function, along with acpi_fill_header(), so we can write a test
> for this code.
>
> Signed-off-by: Simon Glass
> ---
>
> Changes in v2: None
>
> arch/x86/lib/ac
; 1 file changed, 2 insertions(+), 13 deletions(-)
Reviewed-by: Wolfgang Wallner
---
> test/dm/acpi.c| 5 +
> 3 files changed, 23 insertions(+), 22 deletions(-)
Reviewed-by: Wolfgang Wallner
1 - 100 of 266 matches
Mail list logo
