Re: [uml-devel] [PATCH] UML utrace support, step 1

2007-02-21 Thread Roland McGrath
> Below is the first step in your Fix-Your-Broken-Arch-HOWTO for UML. Great! Thanks for tackling this. > Do you want incremental patches as I go along, or replacement ones? The way I've organized my patch series is with the arch support split up along with the separate infrastructure patches in

[uml-devel] x86_64: PTRACE_[GS]ET_THREAD_AREA should be accepted

2007-02-21 Thread Paolo 'Blaisorblade' Giarrusso
This patch backports from 2.6.19 a fix to a 2.6.18 regression. Like for PTRACE_OLDSETOPTIONS, we should fix PTRACE_[GS]ET_THREAD_AREA. This had been done already for 2.6.19, so this is for 2.6.18-stable only. This was tested with UML/32bit as API consumer, both before and after this patch. Cc: An

Re: [uml-devel] [PATCH] UML utrace support, step 1

2007-02-21 Thread Jeff Dike
On Wed, Feb 21, 2007 at 03:12:28AM -0800, Roland McGrath wrote: > The way I've organized my patch series is with the arch support split up > along with the separate infrastructure patches in the series. That is, > just asm/tracehook.h with no utrace_regset stuff in the first patch so that > the ke

[uml-devel] [PATCH 3/4] UML - host_info tidying

2007-02-21 Thread Jeff Dike
Move the host_info string from util.c to um_arch.c, where it is actually initialized and used. Also document its lack of locking. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/include/os.h|2 +- arch/um/include/user_util.h |2 -- arch/um/kernel/um_arch.c|6 +

[uml-devel] [PATCH 4/4] UML - lock host ldt retrieval

2007-02-21 Thread Jeff Dike
Add some locking to host_ldt_entries to prevent racing when reading LDT information from the host. Also fixed some style violations. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/sys-i386/ldt.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) Ind

[uml-devel] [PATCH 1/4] UML - delete unused code

2007-02-21 Thread Jeff Dike
Get rid of a bunch of unused stuff - cpu_feature had no users linux_prog is little-used, so its declaration is moved to the user for easy deletion when the whole file goes away a long-unused debugging aid in helper.c is gone Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --

[uml-devel] [PATCH 0/4] UML - more cleanups

2007-02-21 Thread Jeff Dike
These are 2.6.21 material, nothing urgent. Jeff - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on I

[uml-devel] [PATCH 2/4] UML - formatting fixes

2007-02-21 Thread Jeff Dike
Formatting fixes - style violations whitespace breakage emacs formatting comment removal Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> -- arch/um/kernel/um_arch.c | 51 +-- arch/um/os-Linux/main.c | 11 + arch/um/sys-i3

Re: [uml-devel] [PATCH 4/4] UML - lock host ldt retrieval

2007-02-21 Thread Blaisorblade
On Wednesday 21 February 2007 21:25, Jeff Dike wrote: > Add some locking to host_ldt_entries to prevent racing when reading > LDT information from the host. Please remove GFP_KERNEL allocation under spin_lock - simplest way is using a mutex unless this can be important for performance. > @@ -386

[uml-devel] When opening /tmp/uml.ctl fails, what do we get?

2007-02-21 Thread Blaisorblade
I started uml_daemon as root by mistake, so /tmp/uml.ctl even if /dev/net/tun was world-readable. Ok, I did it. This is the result (after trying many times to do 'ifconfig eth0 up' inside UML): [42949710.29] Choosing a random ethernet address for device eth0 [42949710.29] Netdevice 0 (3a

Re: [uml-devel] [PATCH 2/3] UML - x86_64 thread fixes

2007-02-21 Thread Blaisorblade
On Thursday 08 February 2007 22:57, Jeff Dike wrote: > x86_64 needs some TLS fixes. What was missing was remembering the > child thread id during clone and stuffing it into the child during > each context switch. > > The %fs value is stored separately in the thread structure since the > host contr

Re: [uml-devel] [PATCH] UML - Fix 2.6.20 hang

2007-02-21 Thread Blaisorblade
On Thursday 15 February 2007 18:07, Jeff Dike wrote: > Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> [...] > @@ -331,10 +334,9 @@ void maybe_sigio_broken(int fd, int read > > sigio_lock(); > err = need_poll(&all_sigio_fds, all_sigio_fds.used + 1); > - if(err){ > - printk(