[uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread WANG Cong
This patch fixes this building error: ... drivers/char/mem.c: In function ‘read_mem’: drivers/char/mem.c:136: error: implicit declaration of function ‘unxlate_dev_mem_ptr’ ... Cc: Jeff Dike <[EMAIL PROTECTED]> Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- Index: linux/include/asm-um/io.h ==

[uml-devel] [-mm Patch] UML: fix a building error

2008-01-17 Thread WANG Cong
On Thu, Jan 17, 2008 at 02:35:14AM -0800, Andrew Morton wrote: > >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc8/2.6.24-rc8-mm1/ > Hi, Andrew! Building uml failed in current -mm tree. ;( The below patch fixes this building error: ... include/asm/arch/system.h:8:22: erro

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 09:56:41PM +0800, WANG Cong wrote: > > This patch fixes this building error: > ... > drivers/char/mem.c: In function ‘read_mem’: > drivers/char/mem.c:136: error: implicit declaration of function > ‘unxlate_dev_mem_ptr’ > ... > > Cc: Jeff Dike <[EMAIL PROTECTED]> > Signed-

Re: [uml-devel] [-mm Patch] UML: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 09:21:08PM +0800, WANG Cong wrote: > Building uml failed in current -mm tree. ;( > > The below patch fixes this building error: > ... > include/asm/arch/system.h:8:22: error: asm/nops.h: No such file or directory > ... > > Cc: Jeff Dike <[EMAIL PROTECTED]> > Signed-off-by:

Re: [uml-devel] IA32_EMULATION support

2008-01-17 Thread Jeff Dike
On Tue, Jan 15, 2008 at 08:45:37AM -0800, Ryan Finnie wrote: > At the moment there is no 32-bit object > support in x86_64 UML kernels, and of course knowing my luck, the day > we introduce an x86_64 UML guest at work is the day it needs some > 32-bit blob or something. I believe you mentioned on

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 07:11:13PM +0100, Mariusz Kozlowski wrote: > I see this on sparc64 as well: > > CC drivers/char/mem.o > drivers/char/mem.c: In function 'read_mem': > drivers/char/mem.c:136: error: implicit declaration of function > 'unxlate_dev_mem_ptr' > make[2]: *** [drivers/char

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Andrew Morton
On Thu, 17 Jan 2008 19:11:13 +0100 Mariusz Kozlowski <[EMAIL PROTECTED]> wrote: > Hello, > > > This patch fixes this building error: > > ... > > drivers/char/mem.c: In function ‘read_mem’: > > drivers/char/mem.c:136: error: implicit declaration of function > > ‘unxlate_dev_mem_ptr’ > > ... > >

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Mariusz Kozlowski
Hello, > This patch fixes this building error: > ... > drivers/char/mem.c: In function ‘read_mem’: > drivers/char/mem.c:136: error: implicit declaration of function > ‘unxlate_dev_mem_ptr’ > ... I see this on sparc64 as well: CC drivers/char/mem.o drivers/char/mem.c: In function 'read_me

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Pallipadi, Venkatesh
>-Original Message- >From: Andrew Morton [mailto:[EMAIL PROTECTED] >Sent: Thursday, January 17, 2008 10:56 AM >To: Mariusz Kozlowski >Cc: WANG Cong; [EMAIL PROTECTED]; Jeff Dike; >user-mode-linux-devel@lists.sourceforge.net; David Miller; >[EMAIL PROTECTED]; Ingo Molnar; Thomas Gleixn

[uml-devel] [PATCH 0/20] UML - Lots of patches for 2.6.25

2008-01-17 Thread Jeff Dike
This is a lot of cleanup. There are style fixes, printk fixes, spelling fixes, mutex conversions, and small bug fixes. This is all obviously for 2.6.25. Jeff -- Work email - jdike at linux dot intel dot com --

[uml-devel] [PATCH 2/20] UML - Style fixes in arch/um/os-LInux

2008-01-17 Thread Jeff Dike
Style changes under arch/um/os-Linux: include trimming CodingStyle fixes some printks needed severity indicators make_tempfile turns out not to be used outside of mem.c, so it is now static. Its declaration in tempfile.h is no longer needed, and tempfile.h itself is no lo

[uml-devel] [PATCH 7/20] UML - Add back CONFIG_HZ

2008-01-17 Thread Jeff Dike
avoid-overflows-in-kernel-timec.patch makes CONFIG_HZ necessary for a successful build. UML lacks a definition, so this patch adds one. It also changes the hard-wired definition of HZ to CONFIG_HZ. Note: this patch is a good idea even in the absence of hpa's time fixes. Cc: "H. Peter Anvin" <[E

[uml-devel] [PATCH 4/20] UML - Implement O_APPEND

2008-01-17 Thread Jeff Dike
The .a flags in openflags never had an implementation. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/os-Linux/file.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.22/arch/um/os-Linux/file.c === --- linux-2.6

[uml-devel] [PATCH 6/20] UML - DEBUG_SHIRQ fixes

2008-01-17 Thread Jeff Dike
A couple more DEBUG_SHIRQ fixes. The previous mconsole blocking fix exposed the lack of O_NONBLOCK on the mconsole socket. Also, winch_interrupt started crashing because it is called at irq free time and it tries to dereference tty->driver_data, which has already been set to NULL. I added some e

[uml-devel] [PATCH 8/20] UML - Style fixes in arch/um/sys-x86_64

2008-01-17 Thread Jeff Dike
Style fixes in arch/um/sys-x86_64: updated copyrights CodingStyle fixes added severities to printks which needed them A bunch of functions in sys-*/ptrace_user.c turn out to be unused, so they and their declarations are gone. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --

[uml-devel] [PATCH 5/20] UML - Remove fakehd

2008-01-17 Thread Jeff Dike
The fakehd switch lost its implementation at some point. Since no one is screaming for it, we might as well remove it. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/ubd_kern.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) Index: linux-2.6.22/ar

[uml-devel] [PATCH 3/20] UML - SMP locking commentary

2008-01-17 Thread Jeff Dike
Add some more commentary about various pieces of global data not needing locking. Also got rid of unmap_physmem since that is no longer used. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/net_kern.c |7 ++- arch/um/include/mem_user.h |1 - arch/um/kernel/mem.c

[uml-devel] [PATCH 1/20] UML - Runtime detection of host VMSPLIT on i386

2008-01-17 Thread Jeff Dike
Calculate TASK_SIZE at run-time by figuring out the host's VMSPLIT - this is needed on i386 if UML is to run on hosts with varying VMSPLITs without recompilation. TASK_SIZE is now defined in terms of a variable, task_size. This gets rid of an include of pgtable.h from processor.h, which can cause

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Andrew Morton
On Thu, 17 Jan 2008 11:38:53 -0800 "Pallipadi, Venkatesh" <[EMAIL PROTECTED]> wrote: > > > >-Original Message- > >From: Andrew Morton [mailto:[EMAIL PROTECTED] > >Sent: Thursday, January 17, 2008 10:56 AM > >To: Mariusz Kozlowski > >Cc: WANG Cong; [EMAIL PROTECTED]; Jeff Dike; > >use

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Mariusz Kozlowski
Hello, > >> > This patch fixes this building error: > >> > ... > >> > drivers/char/mem.c: In function 'read_mem': > >> > drivers/char/mem.c:136: error: implicit declaration of > >function 'unxlate_dev_mem_ptr' > >> > ... > >> > >> I see this on sparc64 as well: > >> > >> CC drivers/char/

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 11:38:53AM -0800, Pallipadi, Venkatesh wrote: > Apart from unxlate, there is also ioremap_wc which is defined in the > same way. And while we're on the subject, what's the deal with these, in include/asm-x86/io.h? #define ioremap_wc ioremap_wc #define unxlate_dev_mem_ptr u

[uml-devel] [PATCH 14/20] UML - Remove map_cb

2008-01-17 Thread Jeff Dike
John Reiser noticed that a physical memory region was being mapped twice. This patch fixes that, and it inlines the responsible function, as that had only one caller. Cc: John Reiser <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/kernel/mem.c |8 +--- 1 file

[uml-devel] [PATCH 16/20] UML - Use of a public MAC is a warning, not an error

2008-01-17 Thread Jeff Dike
Downgrade one of the MAC validity checks. If it's one that could be possibly assigned to a physical NIC, then nothing will break. So, emit a warning in this case, but keep the requested MAC. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/drivers/net_kern.c |9 - 1 file cha

[uml-devel] [PATCH 19/20] UML - port mutex conversion

2008-01-17 Thread Jeff Dike
From: Daniel Walker <[EMAIL PROTECTED]> The port_sem is already used as a mutex since it's using DECLARE_MUTEX(), but the underlying construct is still a semaphore .. This patch switches it over to a struct mutex. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL P

[uml-devel] [PATCH 10/20] UML - Move register initialization

2008-01-17 Thread Jeff Dike
Calling init_registers inside the skas3 checking causes mysterious crashes if it doesn't happen because the skas3 checking is bypassed. This patch moves it to os_early_checks. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/os-Linux/start_up.c | 10 +++--- 1 file changed, 7 inserti

[uml-devel] [PATCH 9/20] UML - Add newlines to printks

2008-01-17 Thread Jeff Dike
Some printks were missing newlines. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/os-Linux/skas/process.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6.22/arch/um/os-Linux/skas/process.c ==

[uml-devel] [PATCH 15/20] UML - Fix infinite mconsole loop

2008-01-17 Thread Jeff Dike
From: Karol Swietlicki <[EMAIL PROTECTED]> This patch takes care of a problem with the stopping code. The function inside the while condition returns 0 to signify a problem. A problem could be for example a bad command or a bad version of the mconsole client. A bad command would terminate the sto

[uml-devel] [PATCH 18/20] UML - mconsole mutex conversion

2008-01-17 Thread Jeff Dike
From: Daniel Walker <[EMAIL PROTECTED]> The plug_mem_mutex is already used as a mutex since it's using DECLARE_MUTEX(), but the underlying construct is still a semaphore .. This patch switches it over to a struct mutex. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[E

[uml-devel] [PATCH 12/20] UML - Remove TOPDIR

2008-01-17 Thread Jeff Dike
From: WANG Cong <[EMAIL PROTECTED]> TOPDIR is obsolete, use srctree instead. This patch removes TOPDIR from all UML Makefiles. Cc: Sam Ravnborg <[EMAIL PROTECTED]> Signed-off-by: WANG Cong <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/Makefile |4 ++--

[uml-devel] [PATCH 20/20] UML - defconfig tweaks

2008-01-17 Thread Jeff Dike
Tweak the UML defconfig - we probably don't need 256 old-style ptys - this slows down udev noticably enable hostfs disable slab debugging - another noticable performance hit Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/defconfig |6 +++--- 1 file changed, 3 inser

[uml-devel] [PATCH 13/20] UML - Spelling fix

2008-01-17 Thread Jeff Dike
From: Joe Perches <[EMAIL PROTECTED]> Spelling fix Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/sys-x86_64/signal.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6-git/arch/um/sys-x86_64/signal.c ==

[uml-devel] [PATCH 17/20] UML - LDT mutex conversion

2008-01-17 Thread Jeff Dike
From: Daniel Walker <[EMAIL PROTECTED]> The ldt.semaphore conforms to the new struct mutex requirments, so I converted it to use the new API and changed the name. Signed-off-by: Daniel Walker <[EMAIL PROTECTED]> Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/sys-i386/ldt.c | 14 +

[uml-devel] [PATCH 11/20] UML - Remove unused fields from mm_context

2008-01-17 Thread Jeff Dike
The 3-level page table fixes forgot to remove a couple now-unused fields from struct mm_context. Signed-off-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/include/um_mmu.h |4 1 file changed, 4 deletions(-) Index: linux-2.6.22/arch/um/include/um_mmu.h

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 01:41:50PM -0800, Venki Pallipadi wrote: > > And while we're on the subject, what's the deal with these, in > > include/asm-x86/io.h? > > > > #define ioremap_wc ioremap_wc > > #define unxlate_dev_mem_ptr unxlate_dev_mem_ptr > > > > If archs want to override the defaults f

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Venki Pallipadi
On Thu, Jan 17, 2008 at 04:14:37PM -0500, Jeff Dike wrote: > On Thu, Jan 17, 2008 at 11:38:53AM -0800, Pallipadi, Venkatesh wrote: > > Apart from unxlate, there is also ioremap_wc which is defined in the > > same way. > > And while we're on the subject, what's the deal with these, in > include/asm

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Pallipadi, Venkatesh
>-Original Message- >From: Jeff Dike [mailto:[EMAIL PROTECTED] >Sent: Thursday, January 17, 2008 3:08 PM >To: Pallipadi, Venkatesh >Cc: Andrew Morton; Mariusz Kozlowski; WANG Cong; >[EMAIL PROTECTED]; >user-mode-linux-devel@lists.sourceforge.net; David Miller; >[EMAIL PROTECTED]; Ing

Re: [uml-devel] [-mm Patch] uml: fix a building error

2008-01-17 Thread Jeff Dike
On Thu, Jan 17, 2008 at 03:17:38PM -0800, Pallipadi, Venkatesh wrote: > >#define X X > > > >is a no-op, yes? > > > > Later there is code in generic.h which is doing > #ifndef ioremap_wc > #define ioremap_wc ioremap_nocache > #endif Ah, that makes a bit more sense. It'd be nice if there was less