Change in vdsm[master]: spec: Require newer qemu version for el7

2015-11-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: Require newer qemu version for el7 .. spec: Require newer qemu version for el7 Prior to QEMU 2.3.0-13, it cannot yield while dumping a dirty map,

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 2: * #1271173::Update tracker: OK * Set MODIFIED::bug 1271173#1271173OK -- To view, visit https://

Change in vdsm[master]: net: remove delNetwork old API

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove delNetwork old API .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48911 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: VolumeMetadata: Metadata read utils

2015-11-25 Thread derez
Daniel Erez has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41846 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: VolumeMetadata: Metadata read utils

2015-11-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 19: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/41846 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: net: remove editNetwork old API

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48910 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: net: remove delNetwork old API

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove delNetwork old API .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/48911/6/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json:

Change in vdsm[master]: net: remove addNetwork old API

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: remove addNetwork old API .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48909/6/tests/functional/networkTests.py File tests/funct

Change in vdsm[master]: net: split netinfo module

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: net: Flatten KernelConfig logic

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Flatten KernelConfig logic .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-

Change in vdsm[master]: net: break netinfo-netconfpersistence dependency

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: break netinfo-netconfpersistence dependency .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: net: removing the bonding modes constant duplication.

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: removing the bonding modes constant duplication. .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: net: remove editNetwork old API

2015-11-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove editNetwork old API .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48910 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-11-25 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Verified+1 [root@venus-vdsa ~]# rpm -qa | grep qemu qemu-img-rhev-2.3.0-31.el7.x86_64 qemu-kvm-rhev-2.3

Change in vdsm[master]: tests: Adding coverage check for unit tests

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: -Code-Review -- To view, visit https://gerrit.ovirt.org/49060 To unsubscribe, visit https://g

Change in vdsm[master]: net: remove addNetwork old API

2015-11-25 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: remove addNetwork old API .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/48909 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: init: configure multipath on upgrade from ovirt-3.3 and 3.4

2015-11-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4 .. init: configure multipath on upgrade from ovirt-3.3 and 3.4 multipath configurator was a

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hooks: hostusb: make sudoers rule more specific .. Patch Set 2: * update_tracker: OK * Set MODIFIED::bug 1234304#1234304IGNORE, not oVirt classification b

Change in vdsm[master]: init: configure multipath on upgrade from ovirt-3.3 and 3.4

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4 .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

2015-11-25 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: hostusb: make sudoers rule more specific .. hooks: hostusb: make sudoers rule more specific Change-Id: Iaccc4fffd8ab055a0cd773df68b0431537901021

Change in vdsm[master]: tests: Adding coverage check for unit tests

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

2015-11-25 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File vdsm/

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread sabose
Sahina Bose has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerrit.ovirt.org/se

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line 1279:

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 12: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line 1279:

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread mmirecki
Marcin Mirecki has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (4 comments) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line 1261:

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 11: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 5: (8 comments) https://gerrit.ovirt.org/#/c/48880/5/tests/vmTests.py File tests/vmTests.py: Line 1261:

Change in vdsm[master]: net: split netinfo module

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: split netinfo module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: spec: Require newer multipath version

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer multipath version .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/49113/3//COMMIT_MSG Commit Message: Line 7: spec: Require newer mu

Change in vdsm[master]: hooks: hostusb: make sudoers rule more specific

2015-11-25 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: hooks: hostusb: make sudoers rule more specific .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48963 To unsubscribe, visit https://

Change in vdsm[master]: init: configure multipath on upgrade from ovirt-3.3 and 3.4

2015-11-25 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: init: configure multipath on upgrade from ovirt-3.3 and 3.4 .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48106 To unsubscribe, vi

Change in vdsm[master]: tests: Adding coverage check for unit tests

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: tests: Adding coverage check for unit tests .. Patch Set 4: It does not seem that ANY test has been running: 16:18:11 Complete! 16:18:11 + coverage html 16:

Change in vdsm[master]: adding compatibility for ovirt-engine 4.0 support

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: adding compatibility for ovirt-engine 4.0 support .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/49060/1/vdsm/dsaversion.py.in File vd

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-25 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh File con

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: > Uploaded patch set 9. Fixed identation -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit h

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerrit.ovirt.org/set

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49009 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: spec: Require newer qemu version for el7

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: spec: Require newer qemu version for el7 .. Patch Set 1: Fred, can you test this? -- To view, visit https://gerrit.ovirt.org/49009 To unsubscribe, visit https://g

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks

2015-11-25 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46692 To unsubscribe, visi

Change in vdsm[master]: hooks: ovs: skip non-vNic device's XML

2015-11-25 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: skip non-vNic device's XML .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/49183/2/vdsm_hooks/ovs/ovs_before_device_create.p

Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple

2015-11-25 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: Code-Review+1 okay -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https:

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: Sahina, your ack is welcome. -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerr

Change in vdsm[master]: build: contrib script to build for rhev with the required flags

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: build: contrib script to build for rhev with the required flags .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/49001/5/contrib/rhev_build.sh File contrib

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: Piotr, please approve the infra change. -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit h

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: Code-Review+2 Thanks Ala! -- To view, visit https://gerrit.ovirt.org/49023 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread ahino
Ala Hino has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1260: Line 1261:

Change in vdsm[master]: startup: Change system default encoding to utf8

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: startup: Change system default encoding to utf8 .. Patch Set 5: Please review latest change. -- To view, visit https://gerrit.ovirt.org/48661 To unsubscribe, visi

Change in vdsm[master]: mkimage: check image attributes after creation

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mkimage: check image attributes after creation .. Patch Set 5: Code-Review+1 (1 comment) Looks good, one minor comment. https://gerrit.ovirt.org/#/c/48540/5/vdsm/

Change in vdsm[master]: mkimage: setup right permissions before mkisofs

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs .. Patch Set 5: Code-Review+1 (1 comment) Looks good, one minor comment. https://gerrit.ovirt.org/#/c/48538/5/vdsm

Change in vdsm[master]: gluster: Remove duplicate servers

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: gluster: Remove duplicate servers .. Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/49023/7/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1260: Line 126

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 3: Code-Review+1 Nice! Waiting for Francesco and Ido. -- To view, visit https://gerrit.ovirt.org/49104 To unsubscrib

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 10: Code-Review-1 This should be squashed with https://gerrit.ovirt.org/49038 -- To view, visit https

Change in vdsm[master]: vm: renaming device unplug related function

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: renaming device unplug related function .. Patch Set 5: Code-Review-1 This rename belongs to https://gerrit.ovirt.org/48473 -- To view, visit https://gerrit.o

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: (1 comment) Nice, see the comment about breaking long lines. https://gerrit.ovirt.org/#/c/48881/7/

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 10: Code-Review+1 Waiting for Francesco approval. -- To view, visit https://gerrit.ovirt.org/48473 To

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newVolumeLease .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: volume share utilities

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: volume share utilities .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: VolumeMetadata: move refreshVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move refreshVolume .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: virt: Make BIOS messages available on vmconsole

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: virt: Make BIOS messages available on vmconsole .. Patch Set 8: Code-Review+1 (2 comments) Very nice, waiting for Francesco approval. https://gerrit.ovirt.org/#/c

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: VolumeMetadata: Move getParentVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getParentVolume .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getImageVolumes .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: VolumeMetadata: move newMetadata

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newMetadata .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/48473/9/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 2691:

Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 6: Nice work! See the comments. -- To view, visit https://gerrit.ovirt.org/48880 To unsubscribe, visit htt

Change in vdsm[master]: vm: add test for nic unplug wait

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: vm: move device attached check to device itself

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: devices: drop support for ancient Engines

2015-11-25 Thread smelamud
Shmuel Leib Melamud has posted comments on this change. Change subject: vm: devices: drop support for ancient Engines .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49173 To unsubscribe, visit https:/

Change in vdsm[master]: net: Remove reporting of bond custom options from RunningConfig

2015-11-25 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: net: Remove reporting of bond custom options from RunningConfig .. Patch Set 2: Code-Review+1 Well done! -- To view, visit https://gerrit.ovirt.org/49081 To u

Change in vdsm[master]: vm: check operation result for vm nic hotunplug

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 10: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: vm: renaming device unplug related function

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: renaming device unplug related function .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: VolumeMetadata: Move isLeaf, setLeaf and dependencies

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: VolumeMetadata: Move getImageVolumes

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getImageVolumes .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: metadata write utils

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: metadata write utils .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: move newMetadata

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newMetadata .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: VolumeMetadata: Move getParentVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getParentVolume .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: volume share utilities

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: volume share utilities .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: VolumeMetadata: move refreshVolume

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move refreshVolume .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: VolumeMetadata: move validateDelete

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move validateDelete .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: move getVolumeSize

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move getVolumeSize .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: VolumeMetadata: Move simple metadata getters and setters

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move simple metadata getters and setters .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: VolumeMetadata: Metadata read utils

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Metadata read utils .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: VolumeMetadata: Move the getParent API

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move the getParent API .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: VolumeMetadata: Move recheckIfLeaf into *Metadata class

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: VolumeMetadata: Move getInfo and getVolumeParams

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move getInfo and getVolumeParams .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: StorageDomain: Add get_manifest

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: StorageDomain: Add get_manifest .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-

Change in vdsm[master]: VolumeMetadata: move newVolumeLease

2015-11-25 Thread automation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: move newVolumeLease .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: code coverage: change approach how to enable it

2015-11-25 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: code coverage: change approach how to enable it .. Patch Set 2: (2 comments) Thanks Petr! Looks good, please see the comments. https://gerrit.ovirt.org/#/c/49168

  1   2   3   >