Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

2015-11-11 Thread Cole Robinson
On 11/11/2015 04:01 PM, Pavel Hrdina wrote: > On Wed, Nov 11, 2015 at 03:50:30PM -0500, Cole Robinson wrote: >> On 11/11/2015 03:32 PM, Pavel Hrdina wrote: >>> Function get_devices() always returns a list, if there is no requested >>> device the list is empty. >>> >>> Signed-off-by: Pavel Hrdina >

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

2015-11-11 Thread Cole Robinson
On 11/11/2015 03:32 PM, Pavel Hrdina wrote: > Function get_devices() always returns a list, if there is no requested > device the list is empty. > > Signed-off-by: Pavel Hrdina > --- > > Pushed as trivial. > > virt-install | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

2015-11-11 Thread Pavel Hrdina
On Wed, Nov 11, 2015 at 04:03:17PM -0500, Cole Robinson wrote: > On 11/11/2015 04:01 PM, Pavel Hrdina wrote: > > On Wed, Nov 11, 2015 at 03:50:30PM -0500, Cole Robinson wrote: > >> On 11/11/2015 03:32 PM, Pavel Hrdina wrote: > >>> Function get_devices() always returns a list, if there is no request

Re: [virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

2015-11-11 Thread Pavel Hrdina
On Wed, Nov 11, 2015 at 03:50:30PM -0500, Cole Robinson wrote: > On 11/11/2015 03:32 PM, Pavel Hrdina wrote: > > Function get_devices() always returns a list, if there is no requested > > device the list is empty. > > > > Signed-off-by: Pavel Hrdina > > --- > > > > Pushed as trivial. > > > > v

Re: [virt-tools-list] [virt-manager PATCH 1/2] virt-install: warn user about missing console while installing on arm

2015-11-11 Thread Cole Robinson
On 11/11/2015 03:32 PM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > > Pushed as trivial. > > virt-install | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/virt-install b/virt-install > index 3656835..e465c46 100755 > --- a/virt-install > +++ b/virt

[virt-tools-list] [virt-manager PATCH 2/2] virt-install: fix condition that detect if console is present

2015-11-11 Thread Pavel Hrdina
Function get_devices() always returns a list, if there is no requested device the list is empty. Signed-off-by: Pavel Hrdina --- Pushed as trivial. virt-install | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt-install b/virt-install index e465c46..c5c6e57 100755 --- a/v

[virt-tools-list] [virt-manager PATCH 1/2] virt-install: warn user about missing console while installing on arm

2015-11-11 Thread Pavel Hrdina
Signed-off-by: Pavel Hrdina --- Pushed as trivial. virt-install | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/virt-install b/virt-install index 3656835..e465c46 100755 --- a/virt-install +++ b/virt-install @@ -488,10 +488,6 @@ def _show_nographics_warnings(options,

[virt-tools-list] [virt-manager PATCH 0/2] some minor virt-install fixes

2015-11-11 Thread Pavel Hrdina
Pavel Hrdina (2): virt-install: warn user about missing console while installing on arm virt-install: fix condition that detect if console is present virt-install | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.6.3 ___ virt-

Re: [virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

2015-11-11 Thread Pavel Hrdina
On Wed, Nov 11, 2015 at 02:58:16PM -0500, Cole Robinson wrote: > On 11/11/2015 08:17 AM, Pavel Hrdina wrote: > > On Tue, Nov 10, 2015 at 04:20:51PM -0500, Cole Robinson wrote: > >> On 11/09/2015 02:02 PM, Pavel Hrdina wrote: > >>> Kernel for ppc64 automatically enables serial console, there is no n

Re: [virt-tools-list] Questions about cdrom installation in virt-manager

2015-11-11 Thread Cole Robinson
On 11/11/2015 12:45 AM, Kevin Zhao wrote: > Hi Cole & all, > There is a question just confusing me. > When I use virt-install , set the --location parameter like this : > --location /tmp/**.iso, virt-install can search the iso and get the tree.info > , kernel.img and initrd.img. But w

Re: [virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

2015-11-11 Thread Cole Robinson
On 11/11/2015 08:17 AM, Pavel Hrdina wrote: > On Tue, Nov 10, 2015 at 04:20:51PM -0500, Cole Robinson wrote: >> On 11/09/2015 02:02 PM, Pavel Hrdina wrote: >>> Kernel for ppc64 automatically enables serial console, there is no need >>> to report any warning. >>> >>> Resolves: https://bugzilla.redha

Re: [virt-tools-list] [virt-manager v2] details: show Channel label by device type

2015-11-11 Thread Cole Robinson
On 11/11/2015 07:26 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > Currently we show channel label by its name. > If we use name com.redhat.spice.0 but set it > as unix socket, the label in details keep unchanged. > > This patch will set label according to device type > if we failed matching t

[virt-tools-list] [virt-manager v2] details: show Channel label by device type

2015-11-11 Thread Chen Hanxiao
From: Chen Hanxiao Currently we show channel label by its name. If we use name com.redhat.spice.0 but set it as unix socket, the label in details keep unchanged. This patch will set label according to device type if we failed matching target_name Signed-off-by: Chen Hanxiao --- v2: use device

Re: [virt-tools-list] [virt-manager PATCH] virt-install: don't report missing console in extra-args for ppc64

2015-11-11 Thread Pavel Hrdina
On Tue, Nov 10, 2015 at 04:20:51PM -0500, Cole Robinson wrote: > On 11/09/2015 02:02 PM, Pavel Hrdina wrote: > > Kernel for ppc64 automatically enables serial console, there is no need > > to report any warning. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1247434 > > > > Signed-

Re: [virt-tools-list] [virt-manager PATCH] virt-install: refresh storage pool after disk is created

2015-11-11 Thread Pavel Hrdina
On Tue, Nov 10, 2015 at 04:51:25PM -0500, Cole Robinson wrote: > On 11/10/2015 08:19 AM, Pavel Hrdina wrote: > > This fixes an issue where you need to manually refresh storage pool or > > restart virt-manager in order to be able delete guest that is currently > > installed. This affect remote conn

Re: [virt-tools-list] [virt-manager PATCH] ui: improve pause/resume tooltip

2015-11-11 Thread Pavel Hrdina
On Tue, Nov 10, 2015 at 04:23:35PM -0500, Cole Robinson wrote: > On 11/09/2015 02:06 PM, Pavel Hrdina wrote: > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1238618 > > > > Signed-off-by: Pavel Hrdina > > --- > > ui/details.ui | 2 +- > > ui/manager.ui | 2 +- > > 2 files changed, 2 in

Re: [virt-tools-list] [PATCH 2/2] Fix spice includes

2015-11-11 Thread Eduardo Lima (Etrunko)
On 11/11/2015 05:11 AM, Pavel Grunt wrote: > Hi Eduardo, > > these warnings were introduced after spice-gtk v0.30 release, virt-viewer > currently depends on spice-gtk v0.29.35. You can make the code conditional or > wait for the spice-gtk v0.31 release. > Alright, I guess it is better to wait t

Re: [virt-tools-list] [PATCH 1/2] Remove unused 'window-removed' signal

2015-11-11 Thread Pavel Grunt
Ok, ack. Pavel On Tue, 2015-11-10 at 18:39 -0200, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- >  src/virt-viewer-app.c | 14 -- >  src/virt-viewer-app.h |  1 - >  2 files changed, 15 deletions(-) > > diff --git a/src/virt-viewer-app.c b/src/virt-viewer-