Re: [virtio-dev] Re: [virtio] Re: [PATCH v9 14/16] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-03-09 Thread Cornelia Huck
On Thu, 8 Mar 2018 18:19:39 +0200 "Michael S. Tsirkin" wrote: > On Thu, Mar 08, 2018 at 02:03:31PM +0100, Halil Pasic wrote: > > One stray idea was something like > > > > be32 (A:16;B:15;C:1); > > > > With > > * A occupying bits 0-15 > > * B occupying bits 16-30 > > * C occupying bit 30 > > >

[virtio-dev] Re: [PATCH v4] virtio-blk: add discard and write zeroes features to specification

2018-03-09 Thread Stefan Hajnoczi
On Fri, Mar 09, 2018 at 10:44:23AM +0800, Changpeng Liu wrote: > Existing virtio-blk protocol doesn't have DISCARD/WRITE ZEROES support, > this will impact the performance when using SSD backend over file systems. > > Here is the proposal to extend existing virtio-blk protocol to support > DISCARD

Re: [virtio-dev] Re: [virtio] Re: [PATCH v9 14/16] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-03-09 Thread Halil Pasic
On 03/08/2018 05:19 PM, Michael S. Tsirkin wrote: > On Thu, Mar 08, 2018 at 02:03:31PM +0100, Halil Pasic wrote: >> One stray idea was something like >> >> be32 (A:16;B:15;C:1); >> >> With >> * A occupying bits 0-15 >> * B occupying bits 16-30 >> * C occupying bit 30 >> >> And bit n of B (n \in

Re: [virtio-dev] Re: [virtio] Re: [PATCH v9 14/16] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-03-09 Thread Michael S. Tsirkin
On Fri, Mar 09, 2018 at 01:25:11PM +0100, Halil Pasic wrote: > > > On 03/08/2018 05:19 PM, Michael S. Tsirkin wrote: > > On Thu, Mar 08, 2018 at 02:03:31PM +0100, Halil Pasic wrote: > >> One stray idea was something like > >> > >> be32 (A:16;B:15;C:1); > >> > >> With > >> * A occupying bits 0-15

[virtio-dev] Re: [PATCH v9 00/16] packed ring layout spec

2018-03-09 Thread Michael S. Tsirkin
On Thu, Mar 01, 2018 at 01:31:18AM +0200, Michael S. Tsirkin wrote: > This addresses comments on v8. > > Thanks a lot to all reviewers of v8 - I hope we are > finally there or almost there. FYI the last round of comments was mostly about formatting, so I plan to post v10 and start voting immediat

[virtio-dev] [PATCH v10 06/13] content: generalize transport ring part naming

2018-03-09 Thread Michael S. Tsirkin
Replace descriptor table/available ring/used ring with descriptor area/driver area/device area in all transports. Document what's in which area. Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- content.tex| 61 ++ spli

[virtio-dev] [PATCH v10 10/13] packed virtqueues: more efficient virtqueue layout

2018-03-09 Thread Michael S. Tsirkin
Performance analysis of this is in my kvm forum 2016 presentation. The idea is to have a r/w descriptor in a ring structure, replacing the used and available ring, index and descriptor buffer. This is also easier for devices to implement than the 1.0 layout. Several more enhancements will be nece

[virtio-dev] [PATCH v10 09/13] split-ring: typo: aligment

2018-03-09 Thread Michael S. Tsirkin
--- split-ring.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/split-ring.tex b/split-ring.tex index a594d41..87ecee2 100644 --- a/split-ring.tex +++ b/split-ring.tex @@ -23,7 +23,7 @@ Each virtqueue consists of three parts: where each part is physically-contiguous in gues

[virtio-dev] [PATCH v10 01/13] introduction: document bitfield notation

2018-03-09 Thread Michael S. Tsirkin
Bitfields are a useful and familiar way to specify sub-byte structure layout. The only issue is that bitfield order isn't portable across architectures. Document that we list bitfields from least to most significant one, and warn about portability issues. Signed-off-by: Michael S. Tsirkin --- i

[virtio-dev] [PATCH v10 05/13] content: len -> used length, used ring -> vq

2018-03-09 Thread Michael S. Tsirkin
Document buffer used len and use that terminology everywhere in the generic section. Further, drop the 'used ring' terminology and just say virtqueue. Reviewed-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin --- content.tex | 39 --- 1 file changed, 20 i

[virtio-dev] [PATCH v10 04/13] content: move virtqueue operation description

2018-03-09 Thread Michael S. Tsirkin
virtqueue operation description is specific to the virtqueue format. Move it out to split-ring.tex and update all references. Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- conformance.tex | 4 +- content.tex | 171 +++- sp

[virtio-dev] [PATCH v10 03/13] content: move ring text out to a separate file

2018-03-09 Thread Michael S. Tsirkin
Will be easier to manage this way. Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- content.tex| 499 + split-ring.tex | 498 2 files changed, 499 insertions(+),

[virtio-dev] [PATCH v10 12/13] packed-ring: add in order support

2018-03-09 Thread Michael S. Tsirkin
Support in-order requests for packed rings. This allows selective write-out of used descriptors. Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- packed-ring.tex | 24 1 file changed, 24 insertions(+) diff --git a/packed-ri

[virtio-dev] [PATCH v10 08/13] split-ring: generalize text

2018-03-09 Thread Michael S. Tsirkin
Update generic text to talk about available/used buffers, not rings. Move some split-ring specific text to the correct section. Update conformance section with link to the new conformance clause. Signed-off-by: Michael S. Tsirkin --- conformance.tex | 1 + content.tex | 10 -- spli

[virtio-dev] [PATCH v10 07/13] content: generalize rest of text

2018-03-09 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- content.tex | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/content.tex b/content.tex index 9fc9673..5634c7d 100644 --- a/content.tex +++ b/content.tex @@ -1467,8 +1467,7 @@ All register values ar

[virtio-dev] [PATCH v10 13/13] split-ring: in order feature

2018-03-09 Thread Michael S. Tsirkin
For a split ring, require that drivers use descriptors in order too. This allows devices to skip reading the available ring. Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- split-ring.tex | 18 ++ 1 file changed, 18 insertions(+) d

[virtio-dev] [PATCH v10 02/13] content: move 1.0 queue format out to a separate section

2018-03-09 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- content.tex | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/content.tex b/content.tex index c7ef7fd..4483a4b 100644 --- a/content.tex +++ b/content.tex @@ -230,7 +230,30 @@ result. The

[virtio-dev] [PATCH v10 00/13] packed ring layout spec

2018-03-09 Thread Michael S. Tsirkin
This is a proposal to implement an alternative ring layout. The idea is to have a r/w descriptor in a ring structure, replacing the used and available ring, index and descriptor buffer. This is more efficient and easier for devices to implement than the 1.0 layout. Additionally, a new feature fl

[virtio-dev] [PATCH v10 11/13] content: in-order buffer use

2018-03-09 Thread Michael S. Tsirkin
Using descriptors in-order is sometimes beneficial. Add an option for that - per-format detail allowing more optimizations will be added by follow-up patches. Signed-off-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck Reviewed-by: Stefan Hajnoczi --- content.tex | 15 +++ 1 file

Re: [virtio-dev] [PATCH v4] virtio-blk: add discard and write zeroes features to specification

2018-03-09 Thread Michael S. Tsirkin
On Fri, Mar 09, 2018 at 10:44:23AM +0800, Changpeng Liu wrote: > Existing virtio-blk protocol doesn't have DISCARD/WRITE ZEROES support, > this will impact the performance when using SSD backend over file systems. > > Here is the proposal to extend existing virtio-blk protocol to support > DISCARD

[virtio-dev] Re: [PATCH v2 1/3] scripts/update-linux-headers: add ethtool.h and update to 4.16.0-rc4

2018-03-09 Thread Michael S. Tsirkin
On Wed, Mar 07, 2018 at 10:25:39PM -0500, Jason Baron wrote: > A subsequent patch to add support for setting linkspeed/duplex in > virtio-net, requires a few definitions from ethtool.h, which ends up > pulling in kernel.h and sysinfo.h as well. > > Signed-off-by: Jason Baron > Cc: "Michael S. Tsi

[virtio-dev] Re: [PATCH v2] content: document balloon memory statistics

2018-03-09 Thread Michael S. Tsirkin
On Thu, Feb 22, 2018 at 01:50:52PM +0100, Tomáš Golembiovský wrote: > Linux kernel provides some balloon memory statistics that were not > included in the specs. Include them to avoid any ID clashes in the > future. > > Signed-off-by: Tomáš Golembiovský No comments on this so far. When you feel

[virtio-dev] Re: [PATCH v9 08/16] split-ring: generalize text

2018-03-09 Thread Michael S. Tsirkin
On Wed, Mar 07, 2018 at 12:00:48PM +0100, Cornelia Huck wrote: > On Thu, 1 Mar 2018 01:31:33 +0200 > "Michael S. Tsirkin" wrote: > > > Update generic text to talk about available/used buffers, not rings. > > Move some split-ring specific text to the correct section. > > > > Update conformance se