Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Jason Wang
On Wed, Nov 24, 2021 at 3:22 PM Michael S. Tsirkin wrote: > > On Wed, Nov 24, 2021 at 10:33:28AM +0800, Jason Wang wrote: > > On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote: > > > > > > On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman > > > wrote: > > > > > > > > "Michael S. Tsirkin" writes

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Michael S. Tsirkin
On Wed, Nov 24, 2021 at 10:33:28AM +0800, Jason Wang wrote: > On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote: > > > > On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman > > wrote: > > > > > > "Michael S. Tsirkin" writes: > > > > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: > > >

Re: [PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 03:01:24PM -0800, Darrick J. Wong wrote: > On Tue, Nov 09, 2021 at 09:33:03AM +0100, Christoph Hellwig wrote: > > Use the explicit DAX flag instead of checking the inode flag in the > > iomap code. > > > > Signed-off-by: Christoph Hellwig > > Any particular reason to pass

Re: [PATCH 22/29] iomap: add a IOMAP_DAX flag

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 06:47:10PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Add a flag so that the file system can easily detect DAX operations. > > Looks ok, but I would have preferred a quick note about the rationale > here before needing to

Re: [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 06:56:29PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Prepare from removing the block_device from the DAX I/O path by returning > > s/from removing/for the removal of/ Fixed. > > td->dm_dev.bdev = bdev; > > -

Re: [PATCH 21/29] xfs: move dax device handling into xfs_{alloc,free}_buftarg

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 06:40:47PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Hide the DAX device lookup from the xfs_super.c code. > > > > Reviewed-by: Christoph Hellwig > > That's an interesting spelling of "Signed-off-by", but patch looks > g

Re: [PATCH 20/29] ext4: cleanup the dax handling in ext4_fill_super

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 02:54:30PM -0800, Darrick J. Wong wrote: > Nit: no space before the paren ^ here. Fixed. ___ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization

Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 02:53:15PM -0800, Darrick J. Wong wrote: > > -s64 dax_iomap_zero(loff_t pos, u64 length, struct iomap *iomap) > > +static loff_t dax_zero_iter(struct iomap_iter *iter, bool *did_zero) > > Shouldn't this return value remain s64 to match iomap_iter.processed? I'll switch it

Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 01:46:35PM -0800, Dan Williams wrote: > > + const struct iomap_ops *ops) > > +{ > > + unsigned int blocksize = i_blocksize(inode); > > + unsigned int off = pos & (blocksize - 1); > > + > > + /* Block boundary? Nothing to do */ > > + if (

Re: [PATCH 17/29] fsdax: factor out a dax_memzero helper

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 01:22:13PM -0800, Dan Williams wrote: > On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > > > Factor out a helper for the "manual" zeroing of a DAX range to clean > > up dax_iomap_zero a lot. > > > > Small / optional fixup below: Incorporated. _

Re: [PATCH 14/29] fsdax: simplify the pgoff calculation

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 02:36:42PM -0800, Darrick J. Wong wrote: > > - phys_addr_t phys_off = (start_sect + sector) * 512; > > - > > - if (pgoff) > > - *pgoff = PHYS_PFN(phys_off); > > - if (phys_off % PAGE_SIZE || size % PAGE_SIZE) > > AFAICT, we're relying on fs_dax_get_by_bdev t

Re: [PATCH 08/29] dax: remove dax_capable

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 02:31:23PM -0800, Darrick J. Wong wrote: > > - struct super_block *sb = mp->m_super; > > - > > - if (!xfs_buftarg_is_dax(sb, mp->m_ddev_targp) && > > - (!mp->m_rtdev_targp || !xfs_buftarg_is_dax(sb, mp->m_rtdev_targp))) { > > + if (!mp->m_ddev_targp->bt_daxde

Re: [PATCH 06/29] dax: move the partition alignment check into fs_dax_get_by_bdev

2021-11-23 Thread Christoph Hellwig
On Tue, Nov 23, 2021 at 02:25:55PM -0800, Darrick J. Wong wrote: > > + if ((get_start_sect(bdev) * SECTOR_SIZE) % PAGE_SIZE || > > + (bdev_nr_sectors(bdev) * SECTOR_SIZE) % PAGE_SIZE) { > > Do we have to be careful about 64-bit division here, or do we not > support DAX on 32-bit? I can't

Re: [PATCH 29/29] fsdax: don't require CONFIG_BLOCK

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > The file system DAX code now does not require the block code. So allow > building a kernel with fuse DAX but not block layer. Looks good to me. Reviewed-by: Dan Williams ___ Virtualization

Re: [PATCH 28/29] iomap: build the block based code conditionally

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Only build the block based iomap code if CONFIG_BLOCK is set. Currently > that is always the case, but it will change soon. Looks good. Reviewed-by: Dan Williams ___ Virtualization mailing

Re: [PATCH 27/29] dax: fix up some of the block device related ifdefs

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > The DAX device <-> block device association is only enabled if > CONFIG_BLOCK is enabled. Update dax.h to account for that and use > the right conditions for the fs_put_dax stub as well. Looks good to me. Reviewed-by: Dan Williams >

Re: [PATCH 26/29] fsdax: shift partition offset handling into the file systems

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Remove the last user of ->bdev in dax.c by requiring the file system to > pass in an address that already includes the DAX offset. As part of the > only set ->bdev or ->daxdev when actually required in the ->iomap_begin > methods. Chan

Re: [PATCH 25/29] dax: return the partition offset from fs_dax_get_by_bdev

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Prepare from removing the block_device from the DAX I/O path by returning s/from removing/for the removal of/ > the partition offset from fs_dax_get_by_bdev so that the file systems > have it at hand for use during I/O. > > Signed-off-

Re: [PATCH 24/29] xfs: use xfs_direct_write_iomap_ops for DAX zeroing

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > While the buffered write iomap ops do work due to the fact that zeroing > never allocates blocks, the DAX zeroing should use the direct ops just > like actual DAX I/O. > I always wondered about this, change looks good to me. Reviewed-b

Re: [PATCH 23/29] xfs: use IOMAP_DAX to check for DAX mappings

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Use the explicit DAX flag instead of checking the inode flag in the > iomap code. It's not immediately clear to me why this is a net benefit, are you anticipating inode-less operations? With reflink and multi-inode operations a single i

Re: [PATCH 22/29] iomap: add a IOMAP_DAX flag

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Add a flag so that the file system can easily detect DAX operations. Looks ok, but I would have preferred a quick note about the rationale here before needing to read other patches to figure that out. If you add that you can add: Revi

Re: [PATCH 21/29] xfs: move dax device handling into xfs_{alloc, free}_buftarg

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Hide the DAX device lookup from the xfs_super.c code. > > Reviewed-by: Christoph Hellwig That's an interesting spelling of "Signed-off-by", but patch looks good to me too. I would have expected a robot to complain about missing sign-of

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Jason Wang
On Wed, Nov 24, 2021 at 10:26 AM Jason Wang wrote: > > On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman wrote: > > > > "Michael S. Tsirkin" writes: > > > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: > > >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote: > > >> > > > >> > On Mo

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Jason Wang
On Wed, Nov 24, 2021 at 9:30 AM Michael Ellerman wrote: > > "Michael S. Tsirkin" writes: > > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: > >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote: > >> > > >> > On Mon, 22 Nov 2021 14:25:26 +0800 > >> > Jason Wang wrote: > >> > > >>

Re: update_balloon_size_func blocked for more than 120 seconds

2021-11-23 Thread Michael Ellerman
David Hildenbrand writes: > On Thu, Nov 11, 2021 at 11:49 PM Luis Chamberlain wrote: >> >> I get the following splats with a kvm guest in idle, after a few seconds >> it starts: >> >> [ 242.412806] INFO: task kworker/6:2:271 blockedfor more than 120 seconds. >> [ 242.415790] Tainted: G

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Michael Ellerman
"Michael S. Tsirkin" writes: > On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: >> On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote: >> > >> > On Mon, 22 Nov 2021 14:25:26 +0800 >> > Jason Wang wrote: >> > >> > > I think the fixes are: >> > > >> > > 1) fixing the vhost vsock >> > > 2

Re: [PATCH v2 net-next 21/26] ice: add XDP and XSK generic per-channel statistics

2021-11-23 Thread Daniel Borkmann
Hi Alexander, On 11/23/21 5:39 PM, Alexander Lobakin wrote: [...] Just commenting on ice here as one example (similar applies to other drivers): diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c index 1dd7e84f41f8..7dc287bc3a1a 100644 -

Re: [PATCH 20/29] ext4: cleanup the dax handling in ext4_fill_super

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Only call fs_dax_get_by_bdev once the sbi has been allocated and remove > the need for the dax_dev local variable. Looks good. Reviewed-by: Dan Williams ___ Virtualization mailing list Virtu

Re: [PATCH 19/29] ext2: cleanup the dax handling in ext2_fill_super

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Only call fs_dax_get_by_bdev once the sbi has been allocated and remove > the need for the dax_dev local variable. Looks good. Reviewed-by: Dan Williams ___ Virtualization mailing list Virtu

Re: [PATCH 18/29] fsdax: decouple zeroing from the iomap buffered I/O code

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > Unshare the DAX and iomap buffered I/O page zeroing code. This code > previously did a IS_DAX check deep inside the iomap code, which in > fact was the only DAX check in the code. Instead move these checks > into the callers. Most cal

Re: [PATCH 17/29] fsdax: factor out a dax_memzero helper

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > Factor out a helper for the "manual" zeroing of a DAX range to clean > up dax_iomap_zero a lot. > Small / optional fixup below: Reviewed-by: Dan Williams > Signed-off-by: Christoph Hellwig > --- > fs/dax.c | 36 +++-

Re: [PATCH 16/29] fsdax: simplify the offset check in dax_iomap_zero

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > The file relative offset must have the same alignment as the storage > offset, so use that and get rid of the call to iomap_sector. Agree. Reviewed-by: Dan Williams ___ Virtualization mailin

Re: [PATCH 15/29] xfs: add xfs_zero_range and xfs_truncate_page helpers

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig wrote: > > From: Shiyang Ruan > > Add helpers to prepare for using different DAX operations. > > Signed-off-by: Shiyang Ruan > [hch: split from a larger patch + slight cleanups] > Signed-off-by: Christoph Hellwig Looks good to me. Reviewed-by:

Re: [PATCH 14/29] fsdax: simplify the pgoff calculation

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > Replace the two steps of dax_iomap_sector and bdev_dax_pgoff with a > single dax_iomap_pgoff helper that avoids lots of cumbersome sector > conversions. Looks good, Reviewed-by: Dan Williams > > Signed-off-by: Christoph Hellwig > --

Re: [PATCH 13/29] fsdax: use a saner calling convention for copy_cow_page_dax

2021-11-23 Thread Dan Williams
On Tue, Nov 9, 2021 at 12:33 AM Christoph Hellwig wrote: > > Just pass the vm_fault and iomap_iter structures, and figure out the rest > locally. Note that this requires moving dax_iomap_sector up in the file. Looks good, Reviewed-by: Dan Williams > > Signed-off-by: Christoph Hellwig > --- >

Re: [PATCH 04/29] dax: simplify the dax_device <-> gendisk association

2021-11-23 Thread Dan Williams
On Mon, Nov 22, 2021 at 9:58 PM Christoph Hellwig wrote: > > On Mon, Nov 22, 2021 at 07:33:06PM -0800, Dan Williams wrote: > > Is it time to add a "DAX" symbol namespace? > > What would be the benefit? Just the small benefit of identifying DAX core users with a common grep line, and to indicate t

Re: [PATCH v2] drm/virtio: Fix an NULL vs IS_ERR() bug in virtio_gpu_object_shmem_init()

2021-11-23 Thread Chia-I Wu
On Thu, Nov 18, 2021 at 3:16 AM Dan Carpenter wrote: > > The drm_gem_shmem_get_sg_table() function never returns NULL. It returns > error pointers on error. > > Fixes: c66df701e783 ("drm/virtio: switch from ttm to gem shmem helpers") > Signed-off-by: Dan Carpenter > --- > v2: I originally sent t

Re: [PATCH 02/17] Use memberof(T, m) instead of explicit NULL dereference

2021-11-23 Thread Rafael J. Wysocki
On Fri, Nov 19, 2021 at 12:37 PM Alejandro Colomar wrote: > > Signed-off-by: Alejandro Colomar > Cc: Ajit Khaparde > Cc: Andrew Morton > Cc: Andy Shevchenko > Cc: Arnd Bergmann > Cc: Bjorn Andersson > Cc: Borislav Petkov > Cc: Corey Minyard > Cc: Chris Mason > Cc: Christian Brauner > Cc:

Re: [RFC PATCH 0/3] Use pageblock_order for cma and alloc_contig_range alignment.

2021-11-23 Thread Vlastimil Babka
On 11/23/21 17:35, Zi Yan wrote: > On 19 Nov 2021, at 10:15, Zi Yan wrote: From what my understanding, cma required alignment of max(MAX_ORDER - 1, pageblock_order), because when MIGRATE_CMA was introduced, __free_one_page() does not prevent merging two different pageblocks, wh

Re: [RFC PATCH 0/3] Use pageblock_order for cma and alloc_contig_range alignment.

2021-11-23 Thread David Hildenbrand
On 17.11.21 04:04, Zi Yan wrote: > On 16 Nov 2021, at 3:58, David Hildenbrand wrote: > >> On 15.11.21 20:37, Zi Yan wrote: >>> From: Zi Yan >>> >>> Hi David, >> >> Hi, >> >> thanks for looking into this. >> Hi, sorry for the delay, I wasn't "actually working" last week, so now I'm back from hol

[PATCH v2 5/5] iommu/virtio: Support identity-mapped domains

2021-11-23 Thread Jean-Philippe Brucker
Support identity domains for devices that do not offer the VIRTIO_IOMMU_F_BYPASS_CONFIG feature, by creating 1:1 mappings between the virtual and physical address space. Identity domains created this way still perform noticeably better than DMA domains, because they don't have the overhead of setti

[PATCH v2 3/5] iommu/virtio: Sort reserved regions

2021-11-23 Thread Jean-Philippe Brucker
To ease identity mapping support, keep the list of reserved regions sorted. Reviewed-by: Kevin Tian Signed-off-by: Jean-Philippe Brucker --- drivers/iommu/virtio-iommu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/vir

[PATCH v2 4/5] iommu/virtio: Pass end address to viommu_add_mapping()

2021-11-23 Thread Jean-Philippe Brucker
To support identity mappings, the virtio-iommu driver must be able to represent full 64-bit ranges internally. Pass (start, end) instead of (start, size) to viommu_add/del_mapping(). Clean comments. The one about the returned size was never true: when sweeping the whole address space the returned

[PATCH v2 2/5] iommu/virtio: Support bypass domains

2021-11-23 Thread Jean-Philippe Brucker
The VIRTIO_IOMMU_F_BYPASS_CONFIG feature adds a new flag to the ATTACH request, that creates a bypass domain. Use it to enable identity domains. When VIRTIO_IOMMU_F_BYPASS_CONFIG is not supported by the device, we currently fail attaching to an identity domain. Future patches will instead create i

[PATCH v2 1/5] iommu/virtio: Add definitions for VIRTIO_IOMMU_F_BYPASS_CONFIG

2021-11-23 Thread Jean-Philippe Brucker
Add definitions for the VIRTIO_IOMMU_F_BYPASS_CONFIG, which supersedes VIRTIO_IOMMU_F_BYPASS. Reviewed-by: Kevin Tian Signed-off-by: Jean-Philippe Brucker --- include/uapi/linux/virtio_iommu.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_i

[PATCH v2 0/5] iommu/virtio: Add identity domains

2021-11-23 Thread Jean-Philippe Brucker
Support identity domains, allowing to only enable IOMMU protection for a subset of endpoints (those assigned to userspace, for example). Users may enable identity domains at compile time (CONFIG_IOMMU_DEFAULT_PASSTHROUGH), boot time (iommu.passthrough=1) or runtime (/sys/kernel/iommu_groups/*/type

Re: [PATCH 1/2] vhost/vsock: fix incorrect used length reported to the guest

2021-11-23 Thread Halil Pasic
On Mon, 22 Nov 2021 17:35:24 +0100 Stefano Garzarella wrote: > The "used length" reported by calling vhost_add_used() must be the > number of bytes written by the device (using "in" buffers). > > In vhost_vsock_handle_tx_kick() the device only reads the guest > buffers (they are all "out" buffer

Re: [PATCH 0/2] vhost/vsock: fix used length and cleanup in vhost_vsock_handle_tx_kick()

2021-11-23 Thread Stefan Hajnoczi
On Mon, Nov 22, 2021 at 05:35:23PM +0100, Stefano Garzarella wrote: > This is a follow-up to Micheal's patch [1] and the discussion with Halil and > Jason [2]. > > I made two patches, one to fix the problem and one for cleanup. This should > simplify the backport of the fix because we've had the p

Re: [PATCH] vsock/virtio: suppress used length validation

2021-11-23 Thread Stefan Hajnoczi
On Mon, Nov 22, 2021 at 04:32:01AM -0500, Michael S. Tsirkin wrote: > It turns out that vhost vsock violates the virtio spec > by supplying the out buffer length in the used length > (should just be the in length). > As a result, attempts to validate the used length fail with: > vmw_vsock_virtio_tr

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Halil Pasic
On Tue, 23 Nov 2021 07:17:05 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 22, 2021 at 02:50:03PM +0100, Halil Pasic wrote: > > On Mon, 22 Nov 2021 14:25:26 +0800 > > Jason Wang wrote: > > > > > On Mon, Nov 22, 2021 at 1:49 PM Halil Pasic wrote: > > > > > > > > On Mon, 22 Nov 2021 06:35:

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Michael S. Tsirkin
On Mon, Nov 22, 2021 at 02:50:03PM +0100, Halil Pasic wrote: > On Mon, 22 Nov 2021 14:25:26 +0800 > Jason Wang wrote: > > > On Mon, Nov 22, 2021 at 1:49 PM Halil Pasic wrote: > > > > > > On Mon, 22 Nov 2021 06:35:18 +0100 > > > Halil Pasic wrote: > > > > > > > > I think it should be a common

Re: [PATCH V5 1/4] virtio_ring: validate used buffer length

2021-11-23 Thread Michael S. Tsirkin
On Tue, Nov 23, 2021 at 10:25:20AM +0800, Jason Wang wrote: > On Tue, Nov 23, 2021 at 4:24 AM Halil Pasic wrote: > > > > On Mon, 22 Nov 2021 14:25:26 +0800 > > Jason Wang wrote: > > > > > I think the fixes are: > > > > > > 1) fixing the vhost vsock > > > 2) use suppress_used_validation=true to le

Re: [PATCH v2 1/2] i2c: virtio: disable timeout handling

2021-11-23 Thread Viresh Kumar
On 23-11-21, 10:52, Wolfram Sang wrote: > On Thu, Nov 11, 2021 at 05:04:11PM +0100, Vincent Whitchurch wrote: > > If a timeout is hit, it can result is incorrect data on the I2C bus > > and/or memory corruptions in the guest since the device can still be > > operating on the buffers it was given wh

Re: [PATCH] x86/paravirt: use %rip-relative addressing in hook calls

2021-11-23 Thread Juergen Gross via Virtualization
On 23.11.21 10:29, Jan Beulich wrote: On 05.10.2021 09:43, Juergen Gross wrote: On 30.09.21 14:40, Jan Beulich via Virtualization wrote: While using a plain (constant) address works, its use needlessly invokes a SIB addressing mode, making every call site one byte larger than necessary. Instead

Re: [PATCH] x86/paravirt: use %rip-relative addressing in hook calls

2021-11-23 Thread Jan Beulich via Virtualization
On 05.10.2021 09:43, Juergen Gross wrote: > On 30.09.21 14:40, Jan Beulich via Virtualization wrote: >> While using a plain (constant) address works, its use needlessly invokes >> a SIB addressing mode, making every call site one byte larger than >> necessary. Instead of using an "i" constraint wit

Re: [PATCH 1/2] vdpa: Add support for querying statistics

2021-11-23 Thread Jason Wang
On Tue, Nov 23, 2021 at 2:42 PM Eli Cohen wrote: > > On Tue, Nov 23, 2021 at 10:28:04AM +0800, Jason Wang wrote: > > On Mon, Nov 22, 2021 at 11:56 PM Parav Pandit wrote: > > > > > > > > > > > > > From: Eli Cohen > > > > Sent: Monday, November 22, 2021 8:37 PM > > > > > > > > On Mon, Nov 22, 2021

Re: Kvm virtual machine uses virtio graphics card, the rotating screen is stuck

2021-11-23 Thread Gerd Hoffmann
On Tue, Nov 23, 2021 at 03:49:28PM +0800, Jason Wang wrote: > On Tue, Nov 23, 2021 at 3:00 PM 苟浩 wrote: > > > > Hello, > > > > I use `xrandr -o left` to rotate the screen in the kvm virtual machine. > > When configured as a Virtio graphics card, the screen will freeze after > > rotating the scree

Re: [PATCH] vdpa_sim: avoid putting an uninitialized iova_domain

2021-11-23 Thread Stefano Garzarella
On Mon, Nov 22, 2021 at 08:22:21PM +0800, Longpeng(Mike) wrote: From: Longpeng The system will crash if we put an uninitialized iova_domain, this could happen when an error occurs before initializing the iova_domain in vdpasim_create(). BUG: kernel NULL pointer dereference, address: 00