Re: [PATCH V2] wayland.xml: add "enum", "bitfield" and "is_bitfield" attributes

nd makes sense. Any attempt to define what an "enum" or "bitfield" is will change the current semantics and introduce a lot of complexity. There may exist a way to make it work perfectly (and I'm okay with it if it really exists), but I doubt whether the effort worth it since it doesn't do any good to C or C++ wayland programmers, who are the main targeted audience of wayland. Regards, Boyan Ding ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH wayland-web] extras: list three Wayland protocol dumping tools

ven't worked on it for a while, but it is quite usable now and I hope I'll take some time to further improve it in the future. So, Acked-by: Boyan Ding Thanks, Boyan Ding > > > Thanks, > pq > ___ > wayla

Re: [PATCH] update protocol specification to match wire protocol

more (I have to iterate again that if you change how it works now, the world will break before you). The tool you mentioned seems implement an older version of the specification and if you want to use that tool, you should change the code generation to the way wayland-scanner works now. Regards,

Re: Wayland specification doesn't match code generation

On Wed, 2014-09-03 at 21:04 -0700, Jasper St. Pierre wrote: > The fact that we have an undocumented hack like that in our scanner > clearly isn't great. We need to document it. I totally agree. This can really confuse every beginner. ___ wayland-devel

Re: Wayland specification doesn't match code generation

created" section in [1] to see the details. Regards, Boyan Ding [1] http://ppaalanen.blogspot.fi/2014/07/wayland-protocol-design-object-lifespan.html On Wed, 2014-09-03 at 22:32 -0500, Paul Sbarra wrote: > I tried to start some discussion on this topic previously, but it > apparentl

[PATCH weston] xwm: Check whether the seat is NULL when needed in weston_wm_handle_button

://bugs.freedesktop.org/show_bug.cgi?id=82827 Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index a216b76..f633324 100644 --- a/xwayland/window-manager.c +++ b/xwayland/window

Re: [PATCH weston] xwm: Check whether the seat is NULL sometimes in weston_wm_handle_button

On Mon, 2014-09-01 at 12:14 +0300, Pekka Paalanen wrote: > On Fri, 29 Aug 2014 22:10:32 +0800 > Boyan Ding wrote: > > > Under some certain circumstances, pointer button may have been released > > when frame is still being resized/moved. When this happens, the picked > &g

Re: [PATCH weston] xwm: Check whether the seat is NULL sometimes in weston_wm_handle_button

On Mon, 2014-09-01 at 12:14 +0300, Pekka Paalanen wrote: > On Fri, 29 Aug 2014 22:10:32 +0800 > Boyan Ding wrote: > > > Under some certain circumstances, pointer button may have been released > > when frame is still being resized/moved. When this happens, the picked > &g

Re: Xwayland/glamor broken after glamor-next merge

really > simple xlib apps such as xterm. I've biscected it down the the above > merge commit by running glxgears on each checkout. > > Am I the only one seeing this? No. You aren't. See https://bugs.freedesktop.org/show_bug.cgi?id=81800 But I wonde

[PATCH weston] xwm: Do not activate override redirect windows

We shouldn't do WM-y things on an O-R window, including setting input focus to it. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=81273 Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xwayland/window-manager.c b/xwayland/w

[PATCH weston] xwm: Check whether the seat is NULL sometimes in weston_wm_handle_button

://bugs.freedesktop.org/show_bug.cgi?id=82827 Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index a216b76..f633324 100644 --- a/xwayland/window-manager.c +++ b/xwayland

Re: Gtk: cannot open display error

[1], git version not recommended because xwayland now is affected by an outstanding bug [2]). I can launch chrome successfully on my machine but I have to warn that there are still some bugs and the user experience may not be smooth. Regards, Boyan Ding [1] http://wayland.freedesktop.org/xserver

Re: [PATCH weston] desktop-shell: Get rid of the racy shell client's destroy listener

I forgot to go through my mails before sending, completely the same with http://lists.freedesktop.org/archives/wayland-devel/2014-August/016816.html . Ignore mine. Sorry Boyan Ding On Sat, 2014-08-23 at 15:02 +0800, Boyan Ding wrote: > The only thing that desktop_shell_client_destroy() do

[PATCH weston] desktop-shell: Get rid of the racy shell client's destroy listener

g.cgi?id=82957 Signed-off-by: Boyan Ding --- desktop-shell/shell.c | 16 desktop-shell/shell.h | 1 - 2 files changed, 17 deletions(-) diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c index 99f3343..07700cf 100644 --- a/desktop-shell/shell.c +++ b/desktop-shell

Re: [PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

7;s your idea? > Btw. it seems that rotated windows already have issues with move > constraints. Try to open a window fairly big, rotate it 180 degrees, > grab the window's bottom (which is now facing up), and resize the > window to very short. Then, try to move the windo

Re: [PATCH v2 weston 1/2] xwm: Use cursor theme and size in weston.ini

looks ridiculously large, the cursor size on my machine is 24 elsewhere. I don't think it is right behavior but I wonder how to correct it. Thanks, Boyan Ding ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH weston 3/3] shell: constrain resize grabs so titlebars don't go under the panel

is really annoying. Cheers, Boyan Ding On Wed, 2014-08-20 at 10:37 +0200, Jonny Lamb wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=80228 > --- > desktop-shell/shell.c | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/desktop-shell/she

Re: [PATCH weston 2/2] build: do not run xwayland test for distcheck

These two patches are Reviewed-by: Boyan Ding On Wed, 2014-08-20 at 12:21 +0300, Pekka Paalanen wrote: > From: Pekka Paalanen > > The Xwayland test has been broken ever since the migration to the > stand-alone Xwayland server binary. > > Disable the test, so 'make dist

[PATCH v2 weston 1/2] xwm: Use cursor theme and size in weston.ini

to make it consistent with native wayland apps v2: use the config in weston_compositor instead of reparsing weston.ini Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/xwayland/window-manager.c b

Re: [PATCH weston 2/2] xwm: check whether the picked seat can be NULL

shed to see this [1], though I can't reproduce it myself. It said that the picked seat can be NULL even in weston_wm_handle_button! I guess somewhere might be wrong in X (just a wild guess). Cheers, Boyan Ding [1] https://bugs.archlinux.org/task/41456 __

Re: The road to Wayland/Weston 1.6 and 1.5.1

te important: http://lists.freedesktop.org/archives/wayland-devel/2014-August/016307.html It should follow c4902124 and 9c5aedff in master (and also in 1.5 branch) but I left that out then. Thanks for all the efforts. Regards, Boyan Ding > > > Thanks, &g

Re: How to take screenshots under weston?

Hi, Screenshot works okay under x11-backend on my weston (the git version). Please note that the screenshot seems to be in the directory where you launch weston (not always $HOME). BTW, I was wrong about screenshot binding. It's always Super + S, not Mod + S. Regards, Boyan Ding On Fri,

Re: How to take screenshots under weston?

Hi, Mod key is defined by weston configure, the default of which is Super (win key). You can also specify that in weston.ini. Refer to manpage of weston.ini(5) for details. Cheers, Boyan Ding On Thu, 2014-08-14 at 17:21 -0400, Hongze Zhao wrote: > > > I am new to wayland and westo

[PATCH weston] simple-egl: Clean up unused frame_listener

Unused since commit 1e65840b6103197a684a551925a58fb1ae6c40e3 Signed-off-by: Boyan Ding --- clients/simple-egl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/clients/simple-egl.c b/clients/simple-egl.c index 2097b4c..f23fb8c 100644 --- a/clients/simple-egl.c +++ b/clients/simple

[PATCH weston] cairo-util: Draw solid titlebar for frames with only buttons

Previously geometry was changed to leave space for titlebar if a frame has only buttons but no title. This patch fixes theme_render_frame to avoid transparent titlebar. Signed-off-by: Boyan Ding --- shared/cairo-util.c | 8 +--- shared/cairo-util.h | 5 - shared/frame.c | 2 +- 3

An status update of wayland-tracer - a wayland protocol dumper

dable format similar to WAYLAND_DEBUG, making the tool practical to use. People who are interested can visit the repository on github: https://github.com/dboyan/wayland-tracer and feedbacks are welcomed. Regards, Boyan Ding ___ wayland-devel mailing

Re: [RFC wayland v2 0/2] Wayland protocol dumper

. I'll keep my code as clean as possible. My point is to keep code simple and not to make reusing code a burden. Regards, Boyan Ding [1] https://github.com/dboyan/wayland-tracer On Fri, 2014-07-25 at 15:53 +0300, Pekka Paalanen wrote: > On Wed, 23 Jul 2014 16:21:19 +0800 > Boyan

Re: [RFC wayland v2 0/2] Wayland protocol dumper

/wayland-tracer -- ~/Wayland/weston/weston-flower > 0: <= Data dumped: 12 bytes: > 01 00 00 00 01 00 0c 00 02 00 00 00 You also got to have a running compositor. But this reminds me to check whether the connection is successful. Cheers, Boyan Ding _

[RFC wayland v2 1/2] connection: Move definitions

wayland-tracer will use them. Signed-off-by: Boyan Ding --- src/connection.c | 18 +++--- src/wayland-private.h | 18 +- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/connection.c b/src/connection.c index f292853..79197c9 100644 --- a/src

[RFC wayland v2 0/2] Wayland protocol dumper

alled "single mode"), run shell> wayland-tracer -- program arguments ... Also, EPOLLHUP is handled correctly in this version. The next step will be adding xml protocol parsing and wire data analysing according to protocol files. This will be much tougher but I hope I can f

[RFC wayland v2 2/2] Add a wayland protocol dumper wayland-tracer

Signed-off-by: Boyan Ding --- .gitignore | 1 + Makefile.am | 10 + configure.ac | 7 + src/tracer.c | 689 +++ 4 files changed, 707 insertions(+) create mode 100644 src/tracer.c diff --git a/.gitignore b/.gitignore index c146bac

Re: [PATCH weston] xwayland: set surface_id to 0 when client resource is found

Only when reading through mails today did I find I had duplicated efforts [1], sorry. This patch is Reviewed-by: Boyan Ding [1] http://lists.freedesktop.org/archives/wayland-devel/2014-July/015943.html On Wed, 2014-07-02 at 15:00 -0700, Tyler Veness wrote: > When Xwayland requests tha

[RFC wayland 1/2] connection: Move some definitions

wayland-tracer will need them Signed-off-by: Boyan Ding --- src/connection.c | 18 +++--- src/wayland-private.h | 18 +- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/connection.c b/src/connection.c index f292853..79197c9 100644 --- a/src

[RFC wayland 0/2] Wayland protocol dumper

I'm not very sure about details. Comments and suggestions are welcomed. Feel free to say something about whether it useful, where it is wrong, how it can improve, etc. Regards, Boyan Ding [1] http://lists.freedesktop.org/archives/wayland-devel/2014-April/014121.html Boyan Ding (2): connecti

[RFC wayland 2/2] Add a wayland protocol dumper wayland-tracer

Signed-off-by: Boyan Ding --- .gitignore | 1 + Makefile.am | 10 ++ configure.ac | 7 ++ src/tracer.c | 351 +++ 4 files changed, 369 insertions(+) create mode 100644 src/tracer.c diff --git a/.gitignore b/.gitignore index

Re: wcap-snapshot

want a screenshot, you can use Mod+S in weston. Cheers, Boyan Ding ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH weston] xwm: set surface_id of a window to 0 if paired immediately

surface_id back to zero in this case, causing crash when trying to remove the window from unpaired list which it is not in. This bug affects version 1.5 and master with the new Xwayland DDX. Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

Re: [PATCH] gitignore: add ./message-test

Yeah, this is necessary, but please insert this line according to alphabetical order (i.e. after map-test). Cheers, Boyan Ding On Sun, 2014-07-06 at 22:10 +0800, Guangyu Zhang wrote: > ./message-test is generated by libtool and should be ignored by git. > --- > .gitignore | 1 +

[PATCH weston 1/2] xwm: Use cursor theme and size in weston.ini

to make it consistent with native wayland apps Signed-off-by: Boyan Ding --- xwayland/window-manager.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c index 2fb65b1..f64ef94 100644 --- a/xwayland

[PATCH weston 2/2] xwm: check whether the picked seat can be NULL

The seat picked in weston_wm_window_handle_moveresize can sometimes be NULL when it is (somehow) triggered with all buttons released. This patch checks whether the seat is NULL to avoid NULL dereference. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=80837 Signed-off-by: Boyan Ding

[PATCH 2/2] cairo-util: Set geometry_dirty in frame_set_title

Title can decide the geometry of a frame because it may affect the existence of titlebar, so setting geometry_dirty in frame_set_title for potential change. Signed-off-by: Boyan Ding --- shared/frame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/shared/frame.c b/shared/frame.c index

[PATCH 1/2] cairo-util: Fix geometry for frames with buttons but without title

e the condition, making it titlebar is needed if a frame has title or has button(s), which makes more sense. Signed-off-by: Boyan Ding --- shared/frame.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/shared/frame.c b/shared/frame.c index 35e6b65..aacca60 100644 --- a/s

Re: [PATCH weston] desktop-shell: Don't resize into the panel

-devel/2014-June/015528.html. > > Regards, > > Vivek Ellur > > > > --- Original Message --- > > Sender : Boyan Ding > > Date : Jun 26, 2014 09:21 (GMT+05:30) > > Title : [PATCH weston] desktop-shell: Don't resize into the panel > &

[PATCH weston] desktop-shell: Don't resize into the panel

Previously we can resize windows into panel in weston. This patch puts a constraint in position when resizing just like what was done in moving to avoid resizing window into the panel. https://bugs.freedesktop.org/show_bug.cgi?id=80228 Signed-off-by: Boyan Ding --- desktop-shell/shell.c | 35

[PATCH weston v2] shell: fix segfault in fullscreen binding

Commit 9aa8ce69 forgot to set shsurf->fullscreen_output in fullscreen_binding(), causing segfault when fullscreening using key bindings. This patch fixes that. https://bugs.freedesktop.org/show_bug.cgi?id=79828 Signed-off-by: Boyan Ding --- desktop-shell/shell.c | 1 + 1 file changed

Re: [PATCH weston] shell: fix segfault in fullscreen binding

On Tue, 2014-06-24 at 21:40 -0700, Jason Ekstrand wrote: > Yes we should fix this. I have one question below. Actually I'm not very sure about that either, maybe we should ask @Jasper for suggestion. > > On Sat, Jun 7, 2014 at 2:40 AM, Boyan Ding wrote: > Commit 9aa8c

Re: How to develop an application based on opengles

Hi, I think you can refer to this example code [1] in weston for ideas about how to initialize EGL in wayland, which I think is quite easy to understand. Regards, Boyan Ding [1] http://cgit.freedesktop.org/wayland/weston/tree/clients/simple-egl.c#n318 On Mon, 2014-06-23 at 11:13 +0800, Jacky

[PATCH] xdg-shell: Fix a typo in description

Signed-off-by: Boyan Ding --- protocol/xdg-shell.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index 28add40..0327f40 100644 --- a/protocol/xdg-shell.xml +++ b/protocol/xdg-shell.xml @@ -304,7 +304,7

Re: Suggestions on implementing Wayland Protocol Dumper.

implementation is that it not only help weston but may also help the development of other projects (e.g. you may even use it under Gnome on Wayland). This is my advice. Regards, Boyan Ding On Mon, 2014-06-09 at 11:17 +0530, Srivardhan wrote: > Hi, > > The following are the ways in which a Protoc

[PATCH weston] shell: fix segfault in fullscreen binding

Commit 9aa8ce69 'shell: Don't use the helper methods in xdg_shell implementations' forgot to set shsurf->fullscreen_optput in fullscreen_binding(), causing weston to segfault when fullscreen with the mod + shift + f binding. This patch fixed that issue. --- desktop-shell/shell.c | 6 ++ 1 file

Maximizing window after fullscreening it in weston desktop shell

, so feel free to point out my misunderstandings. Thanks, Boyan Ding ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH] connection: remove unreached code

--- src/connection.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/connection.c b/src/connection.c index 47ee556..f292853 100644 --- a/src/connection.c +++ b/src/connection.c @@ -379,8 +379,6 @@ wl_connection_queue(struct wl_connection *connection, } return wl_buffer_p

Re: Weston multitouch support?

the quick answer. > It happens if I run Weston as X client (weston command) or using > weston-launch. > > I'm not sure how can I check the backend... > > El 01/06/2014 02:50, "Boyan Ding" escribió: > Which backend are you running on? > &g

Re: Weston multitouch support?

Which backend are you running on? On Sun, 2014-06-01 at 02:03 +0100, José Expósito wrote: > Hi all, > > > I'm running a very simple QML multitouch example using > MultiPointTouchArea, that works (more or less) on X11, here is the > code: > > > Rectangle { > width: 400; height: 400

Re: [PATCH 1/2] cairo-util: Add frame_touch_motion support

t scan the list of touches and take appropriate actions (cancel button, destroy touch) will do. I wonder whether my ideas are appropriate. Regards, Boyan Ding ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

[PATCH] doc: Remove obsolete doxygen tags

--- doc/doxygen/wayland.doxygen.in | 28 1 file changed, 28 deletions(-) diff --git a/doc/doxygen/wayland.doxygen.in b/doc/doxygen/wayland.doxygen.in index dd98594..e64512f 100644 --- a/doc/doxygen/wayland.doxygen.in +++ b/doc/doxygen/wayland.doxygen.in @@ -310,22 +31

Re: [PATCH 2/2] compositor-wayland: Add touch support

x27;t have touch hardware either. However I found a interesting project [1] on github, though I'm still figuring out how to use it. On Tue, May 6, 2014 at 9:46 PM, Boyan Ding wrote: Adding touch support to weston's nested wayland backend to make testing easier. https://bugs.fr

[PATCH 1/2] cairo-util: Add frame_touch_motion support

--- shared/cairo-util.h | 3 +++ shared/frame.c | 24 2 files changed, 27 insertions(+) diff --git a/shared/cairo-util.h b/shared/cairo-util.h index 4493b0d..7aebb65 100644 --- a/shared/cairo-util.h +++ b/shared/cairo-util.h @@ -211,6 +211,9 @@ void frame_touch_up(

[PATCH 2/2] compositor-wayland: Add touch support

Adding touch support to weston's nested wayland backend to make testing easier. https://bugs.freedesktop.org/show_bug.cgi?id=77769 --- src/compositor-wayland.c | 95 1 file changed, 95 insertions(+) diff --git a/src/compositor-wayland.c b/src/comp

[PATCH 0/2] weston: Add touch support to nested wayland backend

advice is welcomed. Boyan Ding (2): cairo-util: Add frame_touch_motion support compositor-wayland: Add touch support shared/cairo-util.h | 3 ++ shared/frame.c | 24 src/compositor-wayland.c | 95 3 files changed, 122