RE: [Help]Question about graphics architecture for weson/wayland

Hi Pekka Thank you very much for your reply. > If you have a DRM kernel driver supporting KMS, use Weston's drm-backend > but pass --use-pixman on the command line. DRM kernel driver is for display device? Not for GPU? In other words,i can use drm-backend even though i have no GPU device. Andy

Re: [PATCH libinput] evdev: allow weird multitouch device without slots

On Tue, Aug 19, 2014 at 06:29:40AM +0300, Leonid Borisenko wrote: > HID device 'USB HID v1.11 Mouse' provided by Microsoft Wireless Optical > Desktop® 2.20 (connected to USB and identified as vendor 0x45e, product > 0xe3, version 0x111) is reported as supporting EV_ABS event with ABS_MT_SLOT > code

Re: [PATCH wayland] protocol: define the concept of wl_surface role

On Mon, 18 Aug 2014 10:32:28 -0400 "Jasper St. Pierre" wrote: > On Mon, Aug 18, 2014 at 10:14 AM, Pekka Paalanen > wrote: > > > From: Pekka Paalanen > > > > Define what a role is, and what restrictions there are. > > > > A change to existing behaviour is that a role cannot be changed at all >

Re: [Help]Question about graphics architecture for weson/wayland

On Tue, 19 Aug 2014 06:59:22 + Yang Andy said: > Hi Pekka > > Thank you very much for your reply. > > > If you have a DRM kernel driver supporting KMS, use Weston's drm-backend > > but pass --use-pixman on the command line. > > DRM kernel driver is for display device? Not for GPU? > > In

[PATCH wayland v2] protocol: define the concept of wl_surface role

From: Pekka Paalanen Define what a role is, and what restrictions there are. A change to existing behaviour is that a role cannot be changed at all once set. However, this is unlikely to cause problems, as there is no reason to re-use wl_surfaces in clients. v2: give more concrete examples of r

RE: The road to Wayland/Weston 1.6 and 1.5.1

> -Original Message- > From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] > On Behalf Of Pekka Paalanen > Sent: Monday, August 18, 2014 8:36 PM > To: wayland-devel@lists.freedesktop.org; k...@bitplanet.net > Cc: Jasper St. Pierre; U. Artie Eoff > Subject: The road to W

Re: The road to Wayland/Weston 1.6 and 1.5.1

On Tue, 19 Aug 2014 16:38:42 +0900 "Tanibata, Nobuhiko \(ADITJ/SWG\)" wrote: > > -Original Message- > > From: wayland-devel > [mailto:wayland-devel-boun...@lists.freedesktop.org] > > On Behalf Of Pekka Paalanen > > Sent: Monday, August 18, 2014 8:36 PM > > To: wayland-devel@lists.freedesk

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

On Tue, 19 Aug 2014 10:29:21 +0300 Pekka Paalanen wrote: > From: Pekka Paalanen > > Define what a role is, and what restrictions there are. > > A change to existing behaviour is that a role cannot be changed at all > once set. However, this is unlikely to cause problems, as there is no > reaso

Re: [PATCH] V2: load_image always prints a message on failure if filename is not empty

On Mon, 11 Aug 2014 14:28:38 -0700 Bill Spitzak wrote: > Small change to remove the trailing whitespace error. > > It was rather inconsistent before. This may help users figure out why > backgrounds and icons don't show up. A better api where the error can > be queried might be nice, but this se

Re: [PATCH 01/12] Fixes to parse_options

On Fri, 8 Aug 2014 12:59:50 -0700 Bill Spitzak wrote: > Fail on malformed numbers, such as --width=100mm Good. > Fail on = after booleans, such as --flag=false Okay. > Multiple single-letter booleans in one switch allowed, ie > -xyz is the same as -x -y -z. For wayland modules they all have

Re: [PATCH] Fixes to parse_options, help info from display

On Fri, 8 Aug 2014 12:59:49 -0700 Bill Spitzak wrote: > These are a series of changes, you can pick and choose from them if you don't > like them all. > > There are fixes to the parser so that "x=5mm" and "bool=false" and other > constucts are errors > rather than doing unintuitive things. >

Re: [PATCH] cliptest: Avoid use of uninitialized memory when regions don't intersect

On Mon, 18 Aug 2014 16:13:41 -0500 Derek Foreman wrote: > Prevent attempting to draw the intersection polygon when it contains no > vertices. > > Signed-off-by: Derek Foreman > --- > clients/cliptest.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/clien

Re: [PATCH weston 00/19] Basic tablet support in Weston

On Wed, 6 Aug 2014 19:07:50 -0400 Stephen Chandler Paul wrote: > Hi! As some of you have been aware, I have been working on implementing tablet > ssupport in libinput, the wayland protocol and weston. This patchset adds > basic > tablet support to weston, along with support in the shell and the

[PATCH weston] configure.ac: use libinput by default

From: Pekka Paalanen Libinput is stabilizing soon, so let's flip the default switch now. The old input code will still be carried as an option for a while. Cc: Peter Hutterer Cc: Jonas Ådahl Signed-off-by: Pekka Paalanen --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 3/3] tests: add one more test for event-loop signal source

On 18 August 2014 12:23, Marek Chalupa wrote: > Hi, > > thanks for reviewing. > > The failure you got is not introduced by this patch, I reported it some > time ago here: > https://bugs.freedesktop.org/show_bug.cgi?id=80594 > I put a patch for this bug into bugzilla: https://bugs.freedesktop.or

Re: [PATCH wayland] client: add a public function to make a roundtrip on a custom queue

On Wed, 16 Jul 2014 11:13:06 +0300 Giulio Camuffo wrote: > 2014-07-15 20:39 GMT+03:00 Daniel Stone : > > Hi, > > > > > > On Tuesday, July 15, 2014, Giulio Camuffo wrote: > >> > >> 2014-07-14 22:31 GMT+03:00 Jason Ekstrand : > >> > Guilio, > >> > Would it be better to name it wl_event_queue_round

[PATCH] cliptest: Don't underrun the vertex array of empty polygons.

This silences the following warning: clients/cliptest.c:277:22: warning: array subscript is below array bounds [-Warray-bounds] ctx->prev.x = src->x[src->n - 1]; Signed-off-by: Ondřej Majerech --- clients/cliptest.c | 12 1 file changed, 12 insertions(+) diff --git a/clien

Re: [PATCH weston 00/19] Basic tablet support in Weston

On Tue, Aug 19, 2014 at 01:03:52PM +0300, Pekka Paalanen wrote: > On Wed, 6 Aug 2014 19:07:50 -0400 > Stephen Chandler Paul wrote: > > > Hi! As some of you have been aware, I have been working on implementing > > tablet > > ssupport in libinput, the wayland protocol and weston. This patchset ad

Re: [PATCH 3/3] tests: add one more test for event-loop signal source

On Tue, 19 Aug 2014 12:37:53 +0200 Marek Chalupa wrote: > On 18 August 2014 12:23, Marek Chalupa wrote: > > > Hi, > > > > thanks for reviewing. > > > > The failure you got is not introduced by this patch, I reported it some > > time ago here: > > https://bugs.freedesktop.org/show_bug.cgi?id=805

Re: The road to Wayland/Weston 1.6 and 1.5.1

Hi, On 19 August 2014 07:54, Peter Hutterer wrote: > On Mon, Aug 18, 2014 at 02:35:49PM +0300, Pekka Paalanen wrote: > > Should we make libinput the default for 1.6, so that in 1.7 we can > > remove the old input code, or is libinput API still too much in flux? > > I don't think it'll change muc

Re: The road to Wayland/Weston 1.6 and 1.5.1

Hi, On 18 August 2014 13:14, Pekka Paalanen wrote: > On Mon, 18 Aug 2014 14:57:37 +0300 > Giulio Camuffo wrote: > > 2014-08-18 14:35 GMT+03:00 Pekka Paalanen : > > > had these patches which I'd like to see going in: > > > http://lists.freedesktop.org/archives/wayland-devel/2013-December/012589.

Re: [PATCH 3/3] tests: add one more test for event-loop signal source

On 19 August 2014 13:37, Pekka Paalanen wrote: > On Tue, 19 Aug 2014 12:37:53 +0200 > Marek Chalupa wrote: > > > On 18 August 2014 12:23, Marek Chalupa wrote: > > > > > Hi, > > > > > > thanks for reviewing. > > > > > > The failure you got is not introduced by this patch, I reported it some > >

Re: The road to Wayland/Weston 1.6 and 1.5.1

2014-08-19 14:50 GMT+03:00 Daniel Stone : > Hi, > > On 18 August 2014 13:14, Pekka Paalanen wrote: >> >> On Mon, 18 Aug 2014 14:57:37 +0300 >> Giulio Camuffo wrote: >> > 2014-08-18 14:35 GMT+03:00 Pekka Paalanen : >> > > had these patches which I'd like to see going in: >> > >> > http://lists.fre

[PATCH] Added destructor protocol to wl_data_device interface

From: "kabeer.khan" This is a fix to Bug# 81745 Signed-off-by: kabeer --- protocol/wayland.xml |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/protocol/wayland.xml b/protocol/wayland.xml index 2d57f69..c3a9f28 100644 --- a/protocol/wayland.xml +++ b/protocol/way

Re: [PATCH] cliptest: Don't underrun the vertex array of empty polygons.

On Tue, 19 Aug 2014 13:10:55 +0200 Ondřej Majerech wrote: > This silences the following warning: > > clients/cliptest.c:277:22: warning: array subscript is below array > bounds [-Warray-bounds] > ctx->prev.x = src->x[src->n - 1]; Hi, seems like I would need something more recent than g

Re: [PATCH] cliptest: Don't underrun the vertex array of empty polygons.

On 19 August 2014 14:16, Pekka Paalanen wrote: > On Tue, 19 Aug 2014 13:10:55 +0200 > Ondřej Majerech wrote: > >> This silences the following warning: >> >> clients/cliptest.c:277:22: warning: array subscript is below array >> bounds [-Warray-bounds] >> ctx->prev.x = src->x[src->n - 1]; >

Re: [PATCH weston 1/2] xwm: Use cursor theme and size in weston.ini

On Sun, 6 Jul 2014 11:44:57 +0800 Boyan Ding wrote: > to make it consistent with native wayland apps > > Signed-off-by: Boyan Ding > --- > xwayland/window-manager.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/xwayland/window-manager.c b/xwayl

Re: [PATCH weston] cairo-util: Draw solid titlebar for frames with only buttons

On Tue, 5 Aug 2014 15:22:04 +0800 Boyan Ding wrote: > Previously geometry was changed to leave space for titlebar if a frame > has only buttons but no title. This patch fixes theme_render_frame to > avoid transparent titlebar. > > Signed-off-by: Boyan Ding > --- > shared/cairo-util.c | 8

Re: [PATCH weston 2/2] xwm: check whether the picked seat can be NULL

On Sun, 6 Jul 2014 11:44:58 +0800 Boyan Ding wrote: > The seat picked in weston_wm_window_handle_moveresize can sometimes > be NULL when it is (somehow) triggered with all buttons released. > > This patch checks whether the seat is NULL to avoid NULL dereference. > > Fixes: https://bugs.freede

Re: [PATCH weston 00/19] Basic tablet support in Weston

On Tue, 19 Aug 2014 13:21:54 +0200 Jonas Ådahl wrote: > On Tue, Aug 19, 2014 at 01:03:52PM +0300, Pekka Paalanen wrote: > > On Wed, 6 Aug 2014 19:07:50 -0400 > > Stephen Chandler Paul wrote: > > > > > Hi! As some of you have been aware, I have been working on implementing > > > tablet > > > s

Re: The road to Wayland/Weston 1.6 and 1.5.1

On Mon, 18 Aug 2014 20:55:52 +0800 Boyan Ding wrote: > Hi, > > On Mon, 2014-08-18 at 14:35 +0300, Pekka Paalanen wrote: > > Hi all, > > > > in the release announcement of 1.5.0[1] it was said that the alpha > > release towards 1.6 should come out mid-August. That time is now, so > > how about w

[PATCH v2 2/2] Don't underrun the vertex array of empty polygons

This silences the following warning: src/vertex-clipping.c:196:22: warning: array subscript is below array bounds [-Warray-bounds] ctx->prev.x = src->x[src->n - 1]; Signed-off-by: Ondřej Majerech --- src/vertex-clipping.c | 12 1 file changed, 12 insertions(+) diff --git a/

[PATCH v2 1/2] Remove duplicated code from cliptest.c

Signed-off-by: Ondřej Majerech --- Makefile.am| 2 +- clients/cliptest.c | 293 + 2 files changed, 4 insertions(+), 291 deletions(-) diff --git a/Makefile.am b/Makefile.am index 191dcc9..8a27d44 100644 --- a/Makefile.am +++ b/Makefile

Re: [PATCH weston 2/2] xwm: check whether the picked seat can be NULL

On Tue, 2014-08-19 at 16:53 +0300, Pekka Paalanen wrote: > I was not able to reproduce the crash without the patch, and using > gnome-terminal, either. Actually I'm also curious about how is the problem triggered, and I reproduced it on my machine just now. And I'm even more astonished to see this

Re: [PATCH libinput] evdev: allow weird multitouch device without slots

2014-08-19 10:02 GMT+03:00 Peter Hutterer : > On Tue, Aug 19, 2014 at 06:29:40AM +0300, Leonid Borisenko wrote: > > HID device 'USB HID v1.11 Mouse' provided by Microsoft Wireless Optical > > Desktop=C2=AE 2.20 (connected to USB and identified as vendor 0x45e, pr= oduct > > 0xe3, version 0x111) is

RE: The road to Wayland/Weston 1.6 and 1.5.1

> -Original Message- > From: Pekka Paalanen [mailto:ppaala...@gmail.com] > Sent: Monday, August 18, 2014 4:36 AM > To: wayland-devel@lists.freedesktop.org; krh@ > Cc: Eoff, Ullysses A; Peter Hutterer; Jasper St. Pierre > Subject: The road to Wayland/Weston 1.6 and 1.5.1 > > Hi all, > > in

Re: [PATCH wayland] client: add a public function to make a roundtrip on a custom queue

On Tue, Aug 19, 2014 at 3:58 AM, Pekka Paalanen wrote: > On Wed, 16 Jul 2014 11:13:06 +0300 > Giulio Camuffo wrote: > > > 2014-07-15 20:39 GMT+03:00 Daniel Stone : > > > Hi, > > > > > > > > > On Tuesday, July 15, 2014, Giulio Camuffo > wrote: > > >> > > >> 2014-07-14 22:31 GMT+03:00 Jason Ekstr

Re: [PATCH weston] configure.ac: use libinput by default

Reviewed-by: Jason Ekstrand On Tue, Aug 19, 2014 at 3:13 AM, Pekka Paalanen wrote: > From: Pekka Paalanen > > Libinput is stabilizing soon, so let's flip the default switch now. The > old input code will still be carried as an option for a while. > > Cc: Peter Hutterer > Cc: Jonas Ådahl > S

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

Pekka, I have one nitpick below. However, if we can't find a good solution, I'm ok with pushing as-is. Reviewed-by: Jason Ekstrand On Tue, Aug 19, 2014 at 1:41 AM, Pekka Paalanen wrote: > On Tue, 19 Aug 2014 10:29:21 +0300 > Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > Define w

Re: [PATCH weston] configure.ac: use libinput by default

On Tue, Aug 19, 2014 at 09:46:55AM -0700, Jason Ekstrand wrote: > Reviewed-by: Jason Ekstrand > Acked-by: Jonas Ådahl > > On Tue, Aug 19, 2014 at 3:13 AM, Pekka Paalanen wrote: > > > From: Pekka Paalanen > > > > Libinput is stabilizing soon, so let's flip the default switch now. The > > ol

[ANNOUNCE] libxkbcommon 0.4.3

A new release of libxkbcommon, containing mostly bug-fixes. libxkbcommon 0.4.3 - 2014-08-19 == - Fixed a bug which caused xkb_x11_keymap_new_from_device() to misrepresent modifiers for some keymaps. https://github.com/xkbcommon/libxkbcommon/issues/9 - Fixed a bug which cause

[PATCH 2/2] compositor: add a way to change the keyboard leds

This adds a function weston_keyboard_set_leds() which can be used to change the state of the num lock and the caps lock leds. Only the evdev backend supports this, since it doesn't make sense for embedded sessions. --- src/compositor.h | 3 +++ src/input.c | 43 ++

[PATCH 1/2] evdev: turn off all the leds at startup

the internal state in xkbcommon is off for all the three leds, so make them be in sync. --- src/evdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/evdev.c b/src/evdev.c index 888dfbd..a46ed87 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -581,6 +581,7 @@ evdev_configure_device(struct

Re: [PATCH 01/12] Fixes to parse_options

On 08/19/2014 02:18 AM, Pekka Paalanen wrote: Multiple single-letter booleans in one switch allowed, ie -xyz is the same as -x -y -z. For wayland modules they all have to belong to the same module. This was not accepted before, right? It is confusing that one needs to know that they are from

[PATCH weston] weston.ini.man: Add libinput section

Signed-off-by: Jonas Ådahl --- man/weston.ini.man | 14 ++ 1 file changed, 14 insertions(+) diff --git a/man/weston.ini.man b/man/weston.ini.man index fbcec81..4be752b 100644 --- a/man/weston.ini.man +++ b/man/weston.ini.man @@ -70,6 +70,7 @@ The section headers are: .RS 4 .nf .BR

Re: [PATCH wayland v2] protocol: define the concept of wl_surface role

On 08/19/2014 12:29 AM, Pekka Paalanen wrote: + Often, this + request also creates a new protocol object that represents the + role and adds additional functionality to wl_surface. When a + client wants to destroy a wl_surface, they must destroy this 'role + object' befo

[PATCH weston 1/2] Replace deprecated xkbcommon symbols with current names

These symbols (xkb_map_* and others) were replaced in xkbcommon with more consistent names. See the header xkbcommon/xkbcommon-compat.h for how the old names map to the new. The new names have been available since the first stable xkbcommon release (0.2.0). Signed-off-by: Ran Benita --- clients

[PATCH weston 2/2] Don't protect xkb_*_unref from NULL

Since xkbcommon-0.3.0, which is required by weston, a NULL argument doesn't do anything. Signed-off-by: Ran Benita --- src/compositor-wayland.c | 3 +-- src/compositor-x11.c | 3 +-- src/input.c | 9 +++-- src/screen-share.c | 3 +-- 4 files changed, 6 insertions(+), 1

Re: [PATCH libinput] evdev: allow weird multitouch device without slots

On Tue, Aug 19, 2014 at 06:44:25PM +0300, Leonid Borisenko wrote: > 2014-08-19 10:02 GMT+03:00 Peter Hutterer : > > > On Tue, Aug 19, 2014 at 06:29:40AM +0300, Leonid Borisenko wrote: > > > HID device 'USB HID v1.11 Mouse' provided by Microsoft Wireless Optical > > > Desktop=C2=AE 2.20 (connected

[PATCH V2 1/3] parse_options: fail on more malformed options

Fail on trailing text after numbers, such as --width=100mm Fail on any text after booleans, such as --flag=false Also fixed reading of memory after the null terminator of a long option with no = sign in it. --- shared/option-parser.c | 89 +--- 1 fil

[PATCH V2 2/3] load_image: always print a message on failure if filename is not empty

It was rather inconsistent before. This may help users figure out why backgrounds and icons don't show up. A better api where the error can be queried might be nice, but this seems sufficient for current Weston use. --- shared/image-loader.c | 14 -- 1 file changed, 12 insertions(+),

[PATCH V2 3/3] image: don't print redundant error

This error is printed by load_image() now --- clients/image.c |1 - 1 file changed, 1 deletion(-) diff --git a/clients/image.c b/clients/image.c index 573117c..aee8112 100644 --- a/clients/image.c +++ b/clients/image.c @@ -373,7 +373,6 @@ image_create(struct display *display, const char *file

[PATCH V2] fixes to parse_options, help info

This replaces the two unpushed patches from my previous set. Includes changes based on Pekka's comments: Removed merging of 1-letter boolean switches Fixed the error message for image files less than 4 bytes long Style fixes. Split patch for library from patch to demo program. _

[PATCH libinput] test: avoid erroneous devices to be passed into the test suites

The litest features overlap with the litest device specifiers, so it's easy to pass in LITEST_MOUSE where LITEST_POINTER should be passed in, and vice versa. Lacking proper type checking the best we can do here is simply move the devices into the negative range and check for that. Signed-off-by: P

[PATCH libinput 0/8] Add libinput_device_suspend() to disable devices

This patchset adds two new API hooks, libinput_device_suspend() and libinput_device_resume() which do what it says on the box. No special event is sent when suspending or resuming, so this is really the hook to ignore a specific device. The main idea here is two-fold: some devices simply shouldn

[PATCH libinput 2/8] evdev: prevent double-suspending a device

Signed-off-by: Peter Hutterer --- Could be merged with 1/8, but two patches for easier review. src/evdev.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index 8b154a3..d4a4a07 100644 --- a/src/evdev.c +++ b/src/evdev.c @@ -1061,16

[PATCH libinput 1/8] evdev: factor out closing a device into evdev_suspend()

No functional changes, just prep work for an upcoming patch Signed-off-by: Peter Hutterer --- src/evdev.c | 13 +++-- src/evdev.h | 2 ++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/src/evdev.c b/src/evdev.c index b9f635d..8b154a3 100644 --- a/src/evdev.c +++ b/src/e

[PATCH libinput 8/8] test: test for release events on device suspend

Signed-off-by: Peter Hutterer --- test/device.c | 149 ++ 1 file changed, 149 insertions(+) diff --git a/test/device.c b/test/device.c index 25e119e..2367fd6 100644 --- a/test/device.c +++ b/test/device.c @@ -30,6 +30,7 @@ #include #in

[PATCH libinput 5/8] test: add test for device suspend/resume

Signed-off-by: Peter Hutterer --- test/Makefile.am | 7 +- test/device.c| 250 +++ 2 files changed, 256 insertions(+), 1 deletion(-) create mode 100644 test/device.c diff --git a/test/Makefile.am b/test/Makefile.am index 76d4e8c..4602f9f

[PATCH libinput 6/8] evdev: drop the button count when releasing keys on remove

We only called this function before device removal, so failing to update the button state didn't matter. To make this function generic for the upcoming device suspend/resume, we need to keep track of the button/key count properly. Signed-off-by: Peter Hutterer --- src/evdev.c | 8 1 fil

[PATCH libinput 7/8] evdev: ignore excessive releases of a button or key

When we're suspending a touchpad, several events triggered by timers may still be waiting in the background. We still need to release all buttons/keys immediately though so we get an uneven number of release events: one from release_pressed_keys() and one when the timers expire and send the release

[PATCH libinput 3/8] Add libinput_device_suspend() and libinput_device_resume()

Does what it says on the box, preventing events from the device without actually dropping the device from the context. Signed-off-by: Peter Hutterer --- See my notes in the coverletter. For the T440 case I specifically did not mention that _suspend() closes the file descriptors. src/evdev.c

[PATCH libinput 4/8] evdev: don't resume a removed device

A device may disappear and a new device may re-appear with the same device node while the original device is suspended. Prevent a device resume to open the wrong device. In a path context, a changing syspath is the only indicator we get of the device changing. In a udev context, if the device was