Re: [webkit-dev] Patch for compilation error while building with gcc < 4.x compilers on latest nightlies

2008-04-14 Thread Srinivas Rao M Hamse
Thanks Darin & David for inputs. Patches for review should go in bugs.webkit.org, but I think it's worth > mentioning a couple problems I see immediately. > > This incorrectly removes the "protected" for non-GCC compilers and in fact > may not even compile there because __GNUC__ is not defined and

Re: [webkit-dev] Patch for compilation error while building with gcc < 4.x compilers on latest nightlies

2008-04-14 Thread Darin Adler
On Apr 14, 2008, at 7:07 AM, Srinivas Rao M Hamse wrote: --- a/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-12 04:28:00.0 +0530 +++ b/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-14 19:04:26.0 +0530 @@ -207,7 +207,9 @@ // Used to optimize those nodes that d

Re: [webkit-dev] Patch for compilation error while building with gcc < 4.x compilers on latest nightlies

2008-04-14 Thread David Kilzer
Srinivas Rao M Hamse <[EMAIL PROTECTED]> wrote: > For my compilation using arm-linux-gcc (GCC) 3.4.6, while trying to > build WebKit-r31848 on Gtk DirectFB, I am getting the following compilation > error. > > This error gets fixed after commenting out the line containing "protected: " > at *

[webkit-dev] Patch for compilation error while building with gcc < 4.x compilers on latest nightlies

2008-04-14 Thread Srinivas Rao M Hamse
Hi, For my compilation using arm-linux-gcc (GCC) 3.4.6, while trying to build WebKit-r31848 on Gtk DirectFB, I am getting the following compilation error. This error gets fixed after commenting out the line containing "protected: " at *JavaScriptCore/kjs/nodes.h:210*. I have attached this pa