Re: [Xen-devel] [PATCH] migration, xen: Fix block image lock issue on live migration

2017-10-02 Thread Dr. David Alan Gilbert
ret = bdrv_inactivate_all(); > +if (ret) { > +error_setg(errp, "%s: bdrv_inactivate_all() failed (%d)", > + __func__, ret); > +} > +} > } > > the_end: > -- > Anthony PERARD > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-28 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/28/2017 11:09 AM, Dr. David Alan Gilbert wrote: > > >>> At a higher level, using your tags, I'm not sure where a reset triggered > >>> by a fault detected by the hypervisor lives - e.g. an x86 triple fault >

Re: [Xen-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-28 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/28/2017 10:27 AM, Dr. David Alan Gilbert wrote: > > >>>> +# Enumeration of various causes for shutdown. > >>>> +# > >>>> +# @host-qmp: Reaction to a QMP command, such as 'quit'

Re: [Xen-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-28 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/28/2017 03:08 AM, Dr. David Alan Gilbert wrote: > > * Eric Blake (ebl...@redhat.com) wrote: > >> We want to track why a guest was shutdown; in particular, being able > >> to tell the difference between a guest request (suc

Re: [Xen-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-28 Thread Dr. David Alan Gilbert
qemu_system_reset(VMRESET_REPORT); > +request = qemu_reset_requested_get(); > +if (request >= 0) { > +qemu_system_reset(VMRESET_REPORT, request); > destroy_hvm_domain(true); > } > } &

Re: [Xen-devel] Regression: Xen guest with 5G of RAM on 32bit fail to boot

2015-12-02 Thread Dr. David Alan Gilbert
def CONFIG_USER_ONLY > > /* mask must never be zero, except for A20 change call */ > > > > > > Ok, I tested this by adding > > + assert(HOST_PAGE_ALIGN(0x123456700ll) == 0x123457000ll); > + assert(REAL_HOST_PAGE_ALIGN(0x123456700ll) == 0x123457000ll); >

Re: [Xen-devel] Regression: Xen guest with 5G of RAM on 32bit fail to boot

2015-12-02 Thread Dr. David Alan Gilbert
emu_host_page_size; > } > > static void page_init(void) > diff --git a/translate-common.c b/translate-common.c > index 619feb4..171222d 100644 > --- a/translate-common.c > +++ b/translate-common.c > @@ -21,7 +21,7 @@ > #include &

Re: [Xen-devel] Regression: Xen guest with 5G of RAM on 32bit fail to boot

2015-12-01 Thread Dr. David Alan Gilbert
LIGN macro. > > ram_add_t is uint64_t when compiled with --enable-xen. Hmm, that's a fun problem. Would changing qemu_host_page_[size|mask] to ram_addr_t work? Dave > > Regards, > > -- > Anthony PERARD -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, U

Re: [Xen-devel] [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-10 Thread Dr. David Alan Gilbert
gt; -- > |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o-

Re: [Xen-devel] [PATCH for-2.4 0/3] Migration regressions with Xen.

2015-08-03 Thread Dr. David Alan Gilbert
was the RFC tag in the subject line. > > Also, I think Dave had a comment about this but I think that was made > on IRC. Dave, do you see a problem with this series? Most of it is in Xen only code, so mostly no, however, the followign code looks wrong to me: +void global_state_store_ru