Re: [Xen-devel] [PATCH v4 1/2] xen: replace complicated tlbflush check with an inline function

2016-09-15 Thread Jan Beulich
>>> On 15.09.16 at 08:47, wrote: >> > I rewrite the inline function in xen/include/xen/mm.h to: >> > >> > +#include >> > + >> > +static inline bool accumulate_tlbflush(bool need_tlbflush, >> > + const struct page_info *page, >> > +

Re: [Xen-devel] [PATCH] x86: fold code in load_segments()

2016-09-15 Thread Andrew Cooper
On 15/09/2016 07:28, Jan Beulich wrote: On 14.09.16 at 19:12, wrote: >> On 14/09/16 16:24, Jan Beulich wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -1745,22 +1745,22 @@ static void load_segments(struct vcpu *n >>> (unsigned long *)pv->kernel_sp; >

[Xen-devel] [libvirt test] 100962: tolerable FAIL - PUSHED

2016-09-15 Thread osstest service owner
flight 100962 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/100962/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-raw 11 migrate-support-checkfail never pass test-armhf-armhf-libvirt-raw 13 guest-sav

Re: [Xen-devel] [PATCH V1] xen/arm: domain_build: introduce dom0_lowmem bootargs

2016-09-15 Thread Edgar E. Iglesias
On Thu, Sep 15, 2016 at 08:20:33AM +0800, Peng Fan wrote: > Hi Edgar, > On Wed, Sep 14, 2016 at 04:16:58PM +0200, Edgar E. Iglesias wrote: > >On Wed, Sep 14, 2016 at 08:40:09PM +0800, Peng Fan wrote: > >> On Wed, Sep 14, 2016 at 01:34:10PM +0100, Julien Grall wrote: > >> > > >> > > >> >On 14/09/16

Re: [Xen-devel] [PATCH v4 2/2] xen: move TLB-flush filtering out into populate_physmap during vm creation

2016-09-15 Thread Jan Beulich
>>> On 12.09.16 at 10:16, wrote: > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -303,6 +303,8 @@ struct domain *domain_create(domid_t domid, unsigned int > domcr_flags, > if ( !zalloc_cpumask_var(&d->domain_dirty_cpumask) ) > goto fail; > > +d->is_ever_unpaused =

Re: [Xen-devel] [PATCH V1] xen/arm: domain_build: introduce dom0_lowmem bootargs

2016-09-15 Thread Julien Grall
Hi, On 15/09/2016 09:26, Edgar E. Iglesias wrote: On Thu, Sep 15, 2016 at 08:20:33AM +0800, Peng Fan wrote: Hi Edgar, On Wed, Sep 14, 2016 at 04:16:58PM +0200, Edgar E. Iglesias wrote: On Wed, Sep 14, 2016 at 08:40:09PM +0800, Peng Fan wrote: On Wed, Sep 14, 2016 at 01:34:10PM +0100, Julien G

Re: [Xen-devel] [PATCH v5 00/16] Xen ARM DomU ACPI support

2016-09-15 Thread Julien Grall
Hi Boris, On 15/09/2016 03:17, Boris Ostrovsky wrote: - julien.gr...@arm.com wrote: Hi Stefano, On 14/09/2016 21:48, Stefano Stabellini wrote: On Wed, 14 Sep 2016, Julien Grall wrote: On 14/09/2016 02:06, Stefano Stabellini wrote: On Wed, 14 Sep 2016, Shannon Zhao wrote: On 2016/9/13

[Xen-devel] [xen-unstable test] 100960: tolerable FAIL

2016-09-15 Thread osstest service owner
flight 100960 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/100960/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-cubietruck 6 xen-boot fail pass in 100954 test-armhf-armhf-xl-rtds 15

Re: [Xen-devel] [PATCH v7 0/2] qemu-qdisk: Implementation of grant copy operation.

2016-09-15 Thread Wei Liu
On Wed, Sep 14, 2016 at 06:33:00PM -0700, Stefano Stabellini wrote: > Hi Wei, > > I am happy to queue up this for QEMU, but I'll wait for the first patch > to be committed to Xen before sending a pull request. Is that OK? > Yes, that's fine. I will get around to this next week. One of the prereq

Re: [Xen-devel] [RFC] e1000: Don't save writes to ICS/ICR masked by IMS

2016-09-15 Thread Denis V. Lunev
On 09/13/2016 11:59 PM, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 01, 2016 at 10:57:48AM -0700, Ed Swierk wrote: >> Windows 8, 10 and Server 2012 guests hang intermittently while booting >> on Xen 4.5.3 with 1 vCPU and 4 e1000 vNICs, shortly after the Windows >> logo appears and the little dots st

Re: [Xen-devel] [PATCH v7 1/2] libs/gnttab: introduce grant copy interface

2016-09-15 Thread Wei Liu
On Wed, Sep 14, 2016 at 09:10:02PM +0200, Paulina Szubarczyk wrote: > In a linux part an ioctl(gntdev, IOCTL_GNTDEV_GRANT_COPY, ..) > system call is invoked. In mini-os the operation is yet not > implemented. For the OSs that does not implement gnttab the > call of the grant copy operation causes a

Re: [Xen-devel] [PATCH v2 2/3] x86 Test and expose CPUID faulting capabilities in /proc/cpuinfo

2016-09-15 Thread David Vrabel
On 14/09/16 22:01, Kyle Huey wrote: > Xen advertises the underlying support for CPUID faulting but not does pass > through writes to the relevant MSR, nor does it virtualize it, so it does > not actually work. For now mask off the relevant bit on MSR_PLATFORM_INFO. Could you clarify in the commit

Re: [Xen-devel] [PATCH v2 2/3] x86 Test and expose CPUID faulting capabilities in /proc/cpuinfo

2016-09-15 Thread David Vrabel
On 14/09/16 22:35, Dave Hansen wrote: > On 09/14/2016 02:01 PM, Kyle Huey wrote: >> Xen advertises the underlying support for CPUID faulting but not does pass >> through writes to the relevant MSR, nor does it virtualize it, so it does >> not actually work. For now mask off the relevant bit on MSR_

Re: [Xen-devel] [PATCH v3 15/19] libxl/acpi: Add ACPI e820 entry

2016-09-15 Thread Wei Liu
On Wed, Sep 07, 2016 at 02:59:25PM -0400, Boris Ostrovsky wrote: > Add entry for ACPI tables created for PVHv2 guests to e820 map. > > Signed-off-by: Boris Ostrovsky Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.x

Re: [Xen-devel] [PATCH v3 14/19] libxc/libxl: Allow multiple ACPI modules

2016-09-15 Thread Wei Liu
On Wed, Sep 07, 2016 at 02:59:24PM -0400, Boris Ostrovsky wrote: > Provide ability to load multiple ACPI modules. Thie feature is needed > by PVHv2 guests and will be used in subsequent patches. > > We assume that PVHv2 guests do not load their ACPI modules specified > in the configuration file. W

Re: [Xen-devel] [PATCH v3 16/19] libxl/pvhv2: Include APIC page in MMIO hole for PVHv2 guests

2016-09-15 Thread Wei Liu
On Wed, Sep 07, 2016 at 02:59:26PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v3 19/19] libxc/xc_dom_core: Copy ACPI tables to guest space

2016-09-15 Thread Wei Liu
On Wed, Sep 07, 2016 at 02:59:29PM -0400, Boris Ostrovsky wrote: > Load ACPI modules into guest space > > Signed-off-by: Boris Ostrovsky Some coding style issues are found. > --- > Changes in v3: > * Use more macros in first_high_idx intilalization. > * Format adjustments > > tools/libxc/xc_d

Re: [Xen-devel] [PATCH v3 17/19] ilibxl: Initialize domain build info before calling libxl__domain_make

2016-09-15 Thread Wei Liu
On Wed, Sep 07, 2016 at 02:59:27PM -0400, Boris Ostrovsky wrote: > libxl__domain_make() may want to use b_info so we should set defaults > a little earlier. > > Signed-off-by: Boris Ostrovsky Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lis

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Wei Liu
On Wed, Sep 14, 2016 at 11:21:39AM -0400, Boris Ostrovsky wrote: > On 09/07/2016 02:59 PM, Boris Ostrovsky wrote: > > The goal here is to build ACPI tables for PVHv2/HVMlite guests while > > reusing existing > > hvmloader's ACPI builder code. The builder is provided as a library in > > tools/liba

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Julien Grall
Hi Wei, On 15/09/2016 11:18, Wei Liu wrote: On Wed, Sep 14, 2016 at 11:21:39AM -0400, Boris Ostrovsky wrote: On 09/07/2016 02:59 PM, Boris Ostrovsky wrote: The goal here is to build ACPI tables for PVHv2/HVMlite guests while reusing existing hvmloader's ACPI builder code. The builder is provi

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Wei Liu
On Thu, Sep 15, 2016 at 11:20:08AM +0100, Julien Grall wrote: > Hi Wei, > > On 15/09/2016 11:18, Wei Liu wrote: > >On Wed, Sep 14, 2016 at 11:21:39AM -0400, Boris Ostrovsky wrote: > >>On 09/07/2016 02:59 PM, Boris Ostrovsky wrote: > >>>The goal here is to build ACPI tables for PVHv2/HVMlite guests

Re: [Xen-devel] [PATCH v3] libxl: add "xl qemu-monitor-command"

2016-09-15 Thread Wei Liu
On Fri, Sep 09, 2016 at 11:05:19AM +0100, Wei Liu wrote: > On Tue, Sep 06, 2016 at 02:16:30PM +0200, Dario Faggioli wrote: > > On Tue, 2016-09-06 at 12:51 +0200, Juergen Gross wrote: > > > Add a new xl command "qemu-monitor-command" to issue arbitrary > > > commands > > > to a domain's device model

Re: [Xen-devel] [PATCH v2 2/3] x86 Test and expose CPUID faulting capabilities in /proc/cpuinfo

2016-09-15 Thread Jan Beulich
>>> On 15.09.16 at 12:05, wrote: > On 14/09/16 22:01, Kyle Huey wrote: >> Xen advertises the underlying support for CPUID faulting but not does pass >> through writes to the relevant MSR, nor does it virtualize it, so it does >> not actually work. For now mask off the relevant bit on MSR_PLATFORM_

[Xen-devel] [ovmf test] 100963: all pass - PUSHED

2016-09-15 Thread osstest service owner
flight 100963 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/100963/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f8db6527da8678f1480f08ba99b745279e8d104a baseline version: ovmf 062f9fd2cfaad09f6dd0e

Re: [Xen-devel] [PATCH 1/2] vm_event: Sanitize vm_event response handling

2016-09-15 Thread George Dunlap
On 14/09/16 16:11, Tamas K Lengyel wrote: > On Wed, Sep 14, 2016 at 7:38 AM, George Dunlap > wrote: >> On 13/09/16 19:12, Tamas K Lengyel wrote: >>> Setting response flags in vm_event are only ever safe if the vCPUs are >>> paused. >>> To reflect this we move all checks within the if block that

Re: [Xen-devel] [RFC 20/22] xen/arm: p2m: Re-implement p2m_insert_mapping using p2m_set_entry

2016-09-15 Thread Julien Grall
Hi Stefano, On 06/09/2016 19:57, Stefano Stabellini wrote: On Thu, 28 Jul 2016, Julien Grall wrote: The function p2m_insert_mapping can be re-implemented using the generic function p2m_set_entry. Note that the mapping is not reverted anymore if Xen fails to insert a mapping. This was added to

[Xen-devel] [distros-debian-wheezy test] 67716: all pass

2016-09-15 Thread Platform Team regression test user
flight 67716 distros-debian-wheezy real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67716/ Perfect :-) All tests in this flight passed as required baseline version: flight 67673 jobs: build-amd64 pass build-armh

Re: [Xen-devel] [PATCH v5 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-09-15 Thread Wei Liu
On Tue, Sep 13, 2016 at 11:38:35AM +0100, Julien Grall wrote: > Hi Shannon, > > On 13/09/16 08:03, Shannon Zhao wrote: > > > > > >On 2016/9/12 23:18, Julien Grall wrote: > >>Hi Shannon, > >> > >>On 02/09/16 03:55, Shannon Zhao wrote: > >>>From: Shannon Zhao > >>> > >>>Here it adds the ACPI tables

[Xen-devel] [xen-unstable-smoke test] 100964: tolerable all pass - PUSHED

2016-09-15 Thread osstest service owner
flight 100964 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/100964/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH V1] xen/arm: domain_build: introduce dom0_lowmem bootargs

2016-09-15 Thread Peng Fan
Hi Edgar, On Thu, Sep 15, 2016 at 10:26:46AM +0200, Edgar E. Iglesias wrote: >On Thu, Sep 15, 2016 at 08:20:33AM +0800, Peng Fan wrote: >> Hi Edgar, >> On Wed, Sep 14, 2016 at 04:16:58PM +0200, Edgar E. Iglesias wrote: >> >On Wed, Sep 14, 2016 at 08:40:09PM +0800, Peng Fan wrote: >> >> On Wed, Sep

[Xen-devel] [xen-4.6-testing baseline-only test] 67715: regressions - FAIL

2016-09-15 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 67715 xen-4.6-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67715/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 5 kernel-build

[Xen-devel] [for-4.8][PATCH v2 04/23] xen/arm: p2m: Use typesafe gfn in p2m_mem_access_radix_set

2016-09-15 Thread Julien Grall
p2m_mem_access_radix_set is expecting a gfn in a parameter. Rename the parameter 'pfn' to 'gfn' to match its content and use the typesafe gfn to avoid possible misusage. Also rename the parameter to gfn to match its content. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- C

[Xen-devel] [for-4.8][PATCH v2 03/23] xen/arm: p2m: Rename parameter in p2m_{remove, write}_pte...

2016-09-15 Thread Julien Grall
to make clear of the usage. I.e it is used to inform whether Xen needs to clean the entry after writing in the page table. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v2: - Add Stefano's acked-by --- xen/arch/arm/p2m.c | 8 1 file changed, 4 ins

[Xen-devel] [for-4.8][PATCH v2 11/23] xen/arm: p2m: Introduce p2m_get_root_pointer and use it in __p2m_lookup

2016-09-15 Thread Julien Grall
Mapping the root table is always done the same way. To avoid duplicating the code in a later patch, move the code in a separate helper. Signed-off-by: Julien Grall --- Changes in v2: - Use level_orders rather than level_shifts - PAGE_SHIFT - Move the definition of level_order

[Xen-devel] [for-4.8][PATCH v2 12/23] xen/arm: p2m: Introduce p2m_get_entry and use it to implement __p2m_lookup

2016-09-15 Thread Julien Grall
Currently, for a given GFN, the function __p2m_lookup will only return the associated MFN and the p2m type of the mapping. In some case we need the order of the mapping and the memaccess permission. Rather than providing a separate function for this purpose, it is better to implement a generic fun

[Xen-devel] [for-4.8][PATCH v2 17/23] xen/arm: p2m: Introduce p2m_set_entry and __p2m_set_entry

2016-09-15 Thread Julien Grall
The ARM architecture mandates to use of a break-before-make sequence when changing translation entries if the page table is shared between multiple CPUs whenever a valid entry is replaced by another valid entry (see D4.7.1 in ARM DDI 0487A.j for more details). The break-before-make sequence can be

[Xen-devel] [for-4.8][PATCH v2 18/23] xen/arm: p2m: Re-implement relinquish_p2m_mapping using p2m_{get, set}_entry

2016-09-15 Thread Julien Grall
The function relinquish_p2m_mapping can be re-implemented using p2m_{get,set}_entry by iterating over the range mapped and using the mapping order given by the callee. Given that the preemption was chosen arbitrarily, it is now done on every 512 iterations. Meaning that Xen may check more often if

[Xen-devel] [for-4.8][PATCH v2 16/23] xen/arm: p2m: Introduce a helper to check if an entry is a superpage

2016-09-15 Thread Julien Grall
Use the level and the entry to know whether an entry is a superpage. A superpage can only happen below level 3. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Use bool instead of bool_t - Add Stefano's reviewed-by --- xen/arch/arm/p2m.c | 5

[Xen-devel] [for-4.8][PATCH v2 14/23] xen/arm: p2m: Re-implement p2m_cache_flush using p2m_get_entry

2016-09-15 Thread Julien Grall
The function p2m_cache_flush can be re-implemented using the generic function p2m_get_entry by iterating over the range and using the mapping order given by the callee. As the current implementation, no preemption is implemented, although the comment in the current code claimed it. As the function

[Xen-devel] [for-4.8][PATCH v2 21/23] xen/arm: p2m: Re-implement p2m_set_mem_access using p2m_{set, get}_entry

2016-09-15 Thread Julien Grall
The function p2m_set_mem_access can be re-implemented using the generic functions p2m_get_entry and __p2m_set_entry. Also the function apply_p2m_changes is dropped completely as it is not used anymore. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini Cc: Razvan Cojocaru Cc: Tamas K

[Xen-devel] [for-4.8][PATCH v2 15/23] xen/arm: p2m: Make p2m_{valid, table, mapping} helpers inline

2016-09-15 Thread Julien Grall
Those helpers are very small and often used. Let know the compiler they can be inlined. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/p2m.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

[Xen-devel] [for-4.8][PATCH v2 10/23] xen/arm: p2m: Move the lookup helpers at the top of the file

2016-09-15 Thread Julien Grall
This will be used later in functions that will be defined earlier in the file. Signed-off-by: Julien Grall --- xen/arch/arm/p2m.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index b4f75e8..413780b 100644 --- a/xen/a

[Xen-devel] [for-4.8][PATCH v2 23/23] xen/arm: p2m: Export p2m_*_lock helpers

2016-09-15 Thread Julien Grall
Earlier patches exported the p2m interface (p2m_get_entry and p2m_set_entry) to allow splitting xen/arch/arm/p2m.c. Those functions require the callers to lock the p2m, so we need to export p2m_*_lock helpers. All helpers but p2m_write_unlock but p2m_write_unlock are moved in xen/include/asm-arm/p

[Xen-devel] [for-4.8][PATCH v2 00/23] xen/arm: Rework the P2M code to follow break-before-make sequence

2016-09-15 Thread Julien Grall
Hello all, The ARM architecture mandates the use of a break-before-make sequence when changing translation entries if the page table is shared between multiple CPUs whenever a valid entry is replaced by another valid entry (see D4.7.1 in ARM DDI 0487A.j for more details). The current P2M code doe

[Xen-devel] [for-4.8][PATCH v2 13/23] xen/arm: p2m: Replace all usage of __p2m_lookup with p2m_get_entry

2016-09-15 Thread Julien Grall
__p2m_lookup is just a wrapper to p2m_get_entry. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- It might be possible to rework the memaccess code to take advantage of all the parameters. I will defer this to the memaccess folks. Changes in v2: - Add Stefano's

[Xen-devel] [for-4.8][PATCH v2 01/23] xen/arm: do_trap_instr_abort_guest: Move the IPA computation out of the switch

2016-09-15 Thread Julien Grall
A follow-up patch will add more case to the switch that will require the IPA. So move the computation out of the switch. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v2: - Add Stefano's acked-by --- xen/arch/arm/traps.c | 36 ++

[Xen-devel] [for-4.8][PATCH v2 09/23] xen/arm: p2m: Change the type of level_shifts from paddr_t to uint8_t

2016-09-15 Thread Julien Grall
The level shift can be encoded with 8-bit. So it is not necessary to use paddr_t (i.e 64-bit). Signed-off-by: Julien Grall --- Changes in v2: - Use uint8_t rather than unsigned int - Replaced paddr_t by uint8_t in p2m_shatter_page --- xen/arch/arm/p2m.c | 4 ++-- 1 file chan

[Xen-devel] [for-4.8][PATCH v2 08/23] xen/arm: p2m: Invalidate the TLBs when write unlocking the p2m

2016-09-15 Thread Julien Grall
Sometimes the invalidation of the TLBs can be deferred until the p2m is unlocked. This is for instance the case when multiple mappings are removed. In other case, such as shattering a superpage, an immediate flush is required. Keep track whether a flush is needed directly in the p2m_domain structu

[Xen-devel] [for-4.8][PATCH v2 06/23] xen/arm: traps: Move MMIO emulation code in a separate helper

2016-09-15 Thread Julien Grall
Currently, a stage-2 fault translation will likely access an emulated region. All the checks are pre-sanitity check for MMIO emulation. A follow-up patch will handle a new case that could lead to a stage-2 translation. To improve the clarity of the code and the changes, the current implementation

[Xen-devel] [for-4.8][PATCH v2 07/23] xen/arm: traps: Check the P2M before injecting a data/instruction abort

2016-09-15 Thread Julien Grall
A data/instruction abort may have occurred if another CPU was playing with the stage-2 page table when following the break-before-make sequence (see D4.7.1 in ARM DDI 0487A.j). Rather than injecting directly the fault to the guest, we need to check whether the mapping exists. If it exists, return t

[Xen-devel] [for-4.8][PATCH v2 05/23] xen/arm: p2m: Add a back pointer to domain in p2m_domain

2016-09-15 Thread Julien Grall
The back pointer will be usefult later to get the domain when we only have the p2m in hand. Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- xen/arch/arm/p2m.c| 1 + xen/include/asm-arm/p2m.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/xen/arch/ar

[Xen-devel] [for-4.8][PATCH v2 20/23] xen/arm: p2m: Re-implement p2m_insert_mapping using p2m_set_entry

2016-09-15 Thread Julien Grall
The function p2m_insert_mapping can be re-implemented using the generic function p2m_set_entry. Note that the mapping is not reverted anymore if Xen fails to insert a mapping. This was added to ensure the MMIO are not kept half-mapped in case of failure and to follow the x86 counterpart. This was

[Xen-devel] [for-4.8][PATCH v2 19/23] xen/arm: p2m: Re-implement p2m_remove_using using p2m_set_entry

2016-09-15 Thread Julien Grall
The function p2m_insert_mapping can be re-implemented using the generic function p2m_set_entry. Also drop the operation REMOVE in apply_* as nobody is using it anymore. Note that the functions could have been dropped in one go at the end, however I find easier to drop the operations one by one avo

[Xen-devel] [for-4.8][PATCH v2 02/23] xen/arm: p2m: Store in p2m_domain whether we need to clean the entry

2016-09-15 Thread Julien Grall
Each entry in the page table has to be cleaned when the IOMMU does not support coherent walk. Rather than querying every time the page table is updated, it is possible to do it only once when the p2m is initialized. This is because this value can never change, Xen would be in big trouble otherwise

[Xen-devel] [for-4.8][PATCH v2 22/23] xen/arm: p2m: Do not handle shattering in p2m_create_table

2016-09-15 Thread Julien Grall
The helper p2m_create_table is only called to create a brand new table. Signed-off-by: Julien Grall Reviewd-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- xen/arch/arm/p2m.c | 56 ++ 1 file changed, 6 in

Re: [Xen-devel] [for-4.8][PATCH v2 21/23] xen/arm: p2m: Re-implement p2m_set_mem_access using p2m_{set, get}_entry

2016-09-15 Thread Razvan Cojocaru
On 09/15/2016 02:28 PM, Julien Grall wrote: > The function p2m_set_mem_access can be re-implemented using the generic > functions p2m_get_entry and __p2m_set_entry. > > Also the function apply_p2m_changes is dropped completely as it is not > used anymore. > > Signed-off-by: Julien Grall > Review

Re: [Xen-devel] [RFC] e1000: Don't save writes to ICS/ICR masked by IMS

2016-09-15 Thread Ed Swierk
On Thu, Sep 15, 2016 at 2:15 AM, Denis V. Lunev wrote: > On 09/13/2016 11:59 PM, Konrad Rzeszutek Wilk wrote: > > On Thu, Sep 01, 2016 at 10:57:48AM -0700, Ed Swierk wrote: > >> Windows 8, 10 and Server 2012 guests hang intermittently while booting > >> on Xen 4.5.3 with 1 vCPU and 4 e1000 vNICs,

Re: [Xen-devel] [PATCH v5 00/16] Xen ARM DomU ACPI support

2016-09-15 Thread Boris Ostrovsky
On 09/15/2016 04:58 AM, Julien Grall wrote: > Hi Boris, > > On 15/09/2016 03:17, Boris Ostrovsky wrote: >> >> - julien.gr...@arm.com wrote: >> >>> Hi Stefano, >>> >>> On 14/09/2016 21:48, Stefano Stabellini wrote: On Wed, 14 Sep 2016, Julien Grall wrote: > On 14/09/2016 02:06, Stefano

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Boris Ostrovsky
On 09/15/2016 06:22 AM, Wei Liu wrote: > On Thu, Sep 15, 2016 at 11:20:08AM +0100, Julien Grall wrote: >> Hi Wei, >> >> On 15/09/2016 11:18, Wei Liu wrote: >>> On Wed, Sep 14, 2016 at 11:21:39AM -0400, Boris Ostrovsky wrote: On 09/07/2016 02:59 PM, Boris Ostrovsky wrote: > The goal here is

Re: [Xen-devel] [Qemu-devel] [RFC] e1000: Don't save writes to ICS/ICR masked by IMS

2016-09-15 Thread Denis V. Lunev
On 09/15/2016 03:22 PM, Ed Swierk wrote: > On Thu, Sep 15, 2016 at 2:15 AM, Denis V. Lunev wrote: >> On 09/13/2016 11:59 PM, Konrad Rzeszutek Wilk wrote: >>> On Thu, Sep 01, 2016 at 10:57:48AM -0700, Ed Swierk wrote: Windows 8, 10 and Server 2012 guests hang intermittently while booting

[Xen-devel] [xen-unstable-smoke test] 100967: tolerable all pass - PUSHED

2016-09-15 Thread osstest service owner
flight 100967 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/100967/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[Xen-devel] [ovmf baseline-only test] 67717: all pass

2016-09-15 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 67717 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67717/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f8db6527da8678f1480f08ba99b745279e8d104a baseline v

[Xen-devel] [xen-unstable baseline-only test] 67714: tolerable FAIL

2016-09-15 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 67714 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67714/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-i386-pvgrub 10 guest-start

Re: [Xen-devel] [PATCH V4] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-15 Thread Razvan Cojocaru
On 09/07/2016 07:01 PM, Jan Beulich wrote: On 07.09.16 at 11:12, wrote: >> Currently it is only possible to set mem_access restrictions only for >> a contiguous range of GFNs (or, as a particular case, for a single GFN). >> This patch introduces a new libxc function taking an array of GFNs. >

Re: [Xen-devel] [PATCH v5 00/16] Xen ARM DomU ACPI support

2016-09-15 Thread Julien Grall
On 15/09/2016 13:35, Boris Ostrovsky wrote: On 09/15/2016 04:58 AM, Julien Grall wrote: I think Jan mentioned at some point that certain versions of Windows require an early revision although IIRC it was 2.0. So perhaps at some point we could drop support for pre-2.0 versions, but this was neve

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Julien Grall
Hi Boris, On 15/09/2016 13:39, Boris Ostrovsky wrote: On 09/15/2016 06:22 AM, Wei Liu wrote: On Thu, Sep 15, 2016 at 11:20:08AM +0100, Julien Grall wrote: Hi Wei, On 15/09/2016 11:18, Wei Liu wrote: On Wed, Sep 14, 2016 at 11:21:39AM -0400, Boris Ostrovsky wrote: On 09/07/2016 02:59 PM, Bor

Re: [Xen-devel] [PATCH V4] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-15 Thread Wei Liu
On Thu, Sep 15, 2016 at 04:39:47PM +0300, Razvan Cojocaru wrote: > On 09/07/2016 07:01 PM, Jan Beulich wrote: > On 07.09.16 at 11:12, wrote: > >> Currently it is only possible to set mem_access restrictions only for > >> a contiguous range of GFNs (or, as a particular case, for a single GFN).

Re: [Xen-devel] [for-4.8][PATCH v2 22/23] xen/arm: p2m: Do not handle shattering in p2m_create_table

2016-09-15 Thread Julien Grall
Hi, On 15/09/2016 12:28, Julien Grall wrote: The helper p2m_create_table is only called to create a brand new table. Signed-off-by: Julien Grall Reviewd-by: Stefano Stabellini I made 2 typoes here. It should be: Reviewed-by: Stefano Stabellini Regards, -- Julien Grall _

Re: [Xen-devel] [PATCH V4] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-15 Thread Razvan Cojocaru
On 09/15/2016 04:49 PM, Wei Liu wrote: > On Thu, Sep 15, 2016 at 04:39:47PM +0300, Razvan Cojocaru wrote: >> On 09/07/2016 07:01 PM, Jan Beulich wrote: >> On 07.09.16 at 11:12, wrote: Currently it is only possible to set mem_access restrictions only for a contiguous range of GFNs (or

Re: [Xen-devel] [PATCH V4] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-15 Thread Wei Liu
On Thu, Sep 15, 2016 at 04:52:32PM +0300, Razvan Cojocaru wrote: > On 09/15/2016 04:49 PM, Wei Liu wrote: > > On Thu, Sep 15, 2016 at 04:39:47PM +0300, Razvan Cojocaru wrote: > >> On 09/07/2016 07:01 PM, Jan Beulich wrote: > >> On 07.09.16 at 11:12, wrote: > Currently it is only possible

Re: [Xen-devel] [PATCH V4] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-15 Thread Razvan Cojocaru
On 09/15/2016 04:55 PM, Wei Liu wrote: > On Thu, Sep 15, 2016 at 04:52:32PM +0300, Razvan Cojocaru wrote: >> On 09/15/2016 04:49 PM, Wei Liu wrote: >>> On Thu, Sep 15, 2016 at 04:39:47PM +0300, Razvan Cojocaru wrote: On 09/07/2016 07:01 PM, Jan Beulich wrote: On 07.09.16 at 11:12, wr

Re: [Xen-devel] [RFC PATCH] xen-netback: fix error handling on netback_probe()

2016-09-15 Thread Filipe Manco
On 14-09-2016 12:10, Wei Liu wrote: CC xen-devel as well. On Tue, Sep 13, 2016 at 02:11:27PM +0200, Filipe Manco wrote: In case of error during netback_probe() (e.g. an entry missing on the xenstore) netback_remove() is called on the new device, which will set the device backend state to Xenbus

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Boris Ostrovsky
On 09/15/2016 09:48 AM, Julien Grall wrote: > Hi Boris, > > On 15/09/2016 13:39, Boris Ostrovsky wrote: >> On 09/15/2016 06:22 AM, Wei Liu wrote: >>> On Thu, Sep 15, 2016 at 11:20:08AM +0100, Julien Grall wrote: Hi Wei, On 15/09/2016 11:18, Wei Liu wrote: > On Wed, Sep 14, 2016 a

Re: [Xen-devel] [RFC PATCH] xen-netback: fix error handling on netback_probe()

2016-09-15 Thread Wei Liu
On Thu, Sep 15, 2016 at 04:05:17PM +0200, Filipe Manco wrote: > On 14-09-2016 12:10, Wei Liu wrote: > >CC xen-devel as well. > > > >On Tue, Sep 13, 2016 at 02:11:27PM +0200, Filipe Manco wrote: > >>In case of error during netback_probe() (e.g. an entry missing on the > >>xenstore) netback_remove()

Re: [Xen-devel] [PATCH] Xen/timer: Disable watchdog during dumping timer queues

2016-09-15 Thread Lan, Tianyu
On 9/13/2016 11:25 PM, Jan Beulich wrote: Wait - what is do_invalid_op() doing on the stack? I don't think it belongs there, and hence I wonder whether the keypress happened after some already fatal event (in which case all bets are off anyway). Not clear why do_invalid_op() on the stack. There

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Jan Beulich
>>> On 15.09.16 at 16:07, wrote: > On 09/15/2016 09:48 AM, Julien Grall wrote: >> On 15/09/2016 13:39, Boris Ostrovsky wrote: >>> One option could be to provide a 'gpl_all' (or some such) target in >>> libacpi in addition to 'all' and that target will be careful about not >>> including these small

Re: [Xen-devel] Xen virtual IOMMU high level design doc

2016-09-15 Thread Lan, Tianyu
Hi Andrew: Sorry to bother you. To make sure we are on the right direction, it's better to get feedback from you before we go further step. Could you have a look? Thanks. On 8/17/2016 8:05 PM, Lan, Tianyu wrote: Hi All: The following is our Xen vIOMMU high level design for detail discussion

Re: [Xen-devel] [PATCH 5/6] libxl: add HVM usb passthrough support

2016-09-15 Thread Wei Liu
On Fri, Sep 09, 2016 at 12:13:46PM +0200, Juergen Gross wrote: > On 09/09/16 12:00, Wei Liu wrote: > > On Thu, Sep 08, 2016 at 09:20:25AM +0200, Juergen Gross wrote: > >> Add HVM usb passthrough support to libxl by using qemu's capability > >> to emulate standard USB controllers. > >> > >> A USB co

Re: [Xen-devel] [PATCH] Xen/timer: Disable watchdog during dumping timer queues

2016-09-15 Thread Jan Beulich
>>> On 15.09.16 at 16:16, wrote: > On 9/13/2016 11:25 PM, Jan Beulich wrote: >> Wait - what is do_invalid_op() doing on the stack? I don't think it >> belongs there, and hence I wonder whether the keypress >> happened after some already fatal event (in which case all bets >> are off anyway). > >

Re: [Xen-devel] per-domain logging

2016-09-15 Thread Wei Liu
CC Ian who might have some ideas on this. On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote: > Hi all, > > I wanted to get libvirt's libxl driver have per-domain logs like all other > drivers. After > looking at the libxl and XenToolLogger it seems I'll need to add the feature >

Re: [Xen-devel] per-domain logging

2016-09-15 Thread Wei Liu
On Thu, Sep 15, 2016 at 03:50:25PM +0100, Wei Liu wrote: > CC Ian who might have some ideas on this. > > On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote: > > Hi all, > > > > I wanted to get libvirt's libxl driver have per-domain logs like all other > > drivers. After > > looking

[Xen-devel] [PATCH v2] xen-netback: fix error handling on netback_probe()

2016-09-15 Thread Filipe Manco
In case of error during netback_probe() (e.g. an entry missing on the xenstore) netback_remove() is called on the new device, which will set the device backend state to XenbusStateClosed by calling set_backend_state(). However, the backend state wasn't initialized by netback_probe() at this point,

Re: [Xen-devel] [PATCH 4/6] libxl: add basic support for devices without backend

2016-09-15 Thread Wei Liu
On Thu, Sep 08, 2016 at 09:20:24AM +0200, Juergen Gross wrote: > With the planned support of HVM USB passthrough via the USB emulation > capabilities of qemu libxl has to support guest devices which have no > back- and frontend. Information about those devices will live in the > libxl part of Xenst

[Xen-devel] [xen-unstable-smoke test] 100968: tolerable all pass - PUSHED

2016-09-15 Thread osstest service owner
flight 100968 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/100968/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Boris Ostrovsky
On 09/15/2016 10:21 AM, Jan Beulich wrote: On 15.09.16 at 16:07, wrote: >> On 09/15/2016 09:48 AM, Julien Grall wrote: >>> On 15/09/2016 13:39, Boris Ostrovsky wrote: One option could be to provide a 'gpl_all' (or some such) target in libacpi in addition to 'all' and that target wil

Re: [Xen-devel] [PATCH 5/6] libxl: add HVM usb passthrough support

2016-09-15 Thread Wei Liu
On Thu, Sep 08, 2016 at 09:20:25AM +0200, Juergen Gross wrote: > Add HVM usb passthrough support to libxl by using qemu's capability > to emulate standard USB controllers. > > A USB controller is added via qmp command to the emulated hardware > when a usbctrl device of type DEVICEMODEL is requeste

Re: [Xen-devel] [PATCH 6/6] docs: add HVM USB passthrough documentation

2016-09-15 Thread Wei Liu
On Thu, Sep 08, 2016 at 09:20:26AM +0200, Juergen Gross wrote: > Update the man page regarding passthrough of USB devices to HVM > domains via qemu USB emulation. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] per-domain logging

2016-09-15 Thread Cedric Bosdonnat
On Thu, 2016-09-15 at 16:11 +0100, Wei Liu wrote: > On Thu, Sep 15, 2016 at 03:50:25PM +0100, Wei Liu wrote: > > > > CC Ian who might have some ideas on this. > > > > On Wed, Sep 14, 2016 at 04:22:24PM +0200, Cedric Bosdonnat wrote: > > > > > > Hi all, > > > > > > I wanted to get libvirt's libx

Re: [Xen-devel] [PATCH 2/2] x86/vm_event: Allow returning i-cache for emulation

2016-09-15 Thread Tamas K Lengyel
On Wed, Sep 14, 2016 at 11:58 PM, Jan Beulich wrote: On 14.09.16 at 18:20, wrote: >> On Wed, Sep 14, 2016 at 9:55 AM, Jan Beulich wrote: >> On 13.09.16 at 20:12, wrote: When emulating instructions the emulator maintains a small i-cache fetched from the guest memory. This patc

[Xen-devel] [xen-unstable test] 100965: tolerable FAIL - PUSHED

2016-09-15 Thread osstest service owner
flight 100965 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/100965/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemut-win7-amd64 16 guest-stop fail like 100960 test-amd64-i386-xl-qemuu-wi

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Jan Beulich
>>> On 15.09.16 at 17:28, wrote: > Something along the lines of this (attached as well to prevent line > wrapping) Looks reasonable with some polishing (GPL=y on the make lines and using C_SRC-$(GPL) and CSRC-y). > Maybe even without changes to mk_dsdt.c But isn't that the critical part? And -

Re: [Xen-devel] [PATCH 2/2] x86/vm_event: Allow returning i-cache for emulation

2016-09-15 Thread Jan Beulich
>>> On 15.09.16 at 17:27, wrote: > On Wed, Sep 14, 2016 at 11:58 PM, Jan Beulich wrote: > On 14.09.16 at 18:20, wrote: >>> On Wed, Sep 14, 2016 at 9:55 AM, Jan Beulich wrote: >>> On 13.09.16 at 20:12, wrote: > When emulating instructions the emulator maintains a small i-cache fetch

Re: [Xen-devel] [PATCH v3 00/19] Make ACPI builder available to components other than hvmloader

2016-09-15 Thread Boris Ostrovsky
On 09/15/2016 12:05 PM, Jan Beulich wrote >> Maybe even without changes to mk_dsdt.c > But isn't that the critical part? Not necessarily since we'd use --gpl option only for dsdt_anycpu_qemu_xen, dsdt_anycpu and dsdt_15cpu and these files are not used by the non-GPL caller, which is libxl (it on

Re: [Xen-devel] [PATCH 2/2] x86/vm_event: Allow returning i-cache for emulation

2016-09-15 Thread Tamas K Lengyel
On Wed, Sep 14, 2016 at 1:58 AM, Razvan Cojocaru wrote: > On 09/13/2016 09:12 PM, Tamas K Lengyel wrote: >> When emulating instructions the emulator maintains a small i-cache fetched >> from the guest memory. This patch extends the vm_event interface to allow >> returning this i-cache via the vm_e

[Xen-devel] [PATCH v2 2/2] x86/vm_event: Allow overwriting Xen's i-cache used for emulation

2016-09-15 Thread Tamas K Lengyel
When emulating instructions Xen's emulator maintains a small i-cache fetched from the guest memory. This patch extends the vm_event interface to allow overwriting this i-cache via a buffer returned in the vm_event response. When responding to a SOFTWARE_BREAKPOINT event (INT3) the monitor subscrib

[Xen-devel] [PATCH v2 1/2] vm_event: Sanitize vm_event response handling

2016-09-15 Thread Tamas K Lengyel
Setting response flags in vm_event are only ever safe if the vCPUs are paused. To reflect this we move all checks within the if block that already checks whether this is the case. Checks that are only supported on one architecture we relocate the bitmask operations to the arch-specific handlers to

[Xen-devel] [qemu-mainline test] 100966: tolerable FAIL - PUSHED

2016-09-15 Thread osstest service owner
flight 100966 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/100966/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemuu-win7-amd64 16 guest-stop fail like 100951 test-amd64-amd64-xl-rtds

[Xen-devel] [ovmf test] 100969: all pass - PUSHED

2016-09-15 Thread osstest service owner
flight 100969 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/100969/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 490acf8908f797982f367bfeb4bdf3ebe0764e42 baseline version: ovmf f8db6527da8678f1480f0

Re: [Xen-devel] [PATCH 2/2] x86/vm_event: Allow returning i-cache for emulation

2016-09-15 Thread Razvan Cojocaru
On 09/15/16 19:36, Tamas K Lengyel wrote: > On Wed, Sep 14, 2016 at 1:58 AM, Razvan Cojocaru > wrote: >> On 09/13/2016 09:12 PM, Tamas K Lengyel wrote: >>> When emulating instructions the emulator maintains a small i-cache fetched >>> from the guest memory. This patch extends the vm_event interfac

Re: [Xen-devel] [for-4.8][PATCH v2 00/23] xen/arm: Rework the P2M code to follow break-before-make sequence

2016-09-15 Thread Tamas K Lengyel
On Thu, Sep 15, 2016 at 5:28 AM, Julien Grall wrote: > Hello all, > > The ARM architecture mandates the use of a break-before-make sequence when > changing translation entries if the page table is shared between multiple > CPUs whenever a valid entry is replaced by another valid entry (see D4.7.1

  1   2   >