[Xen-devel] [PATCH] tools: change the type of '*nr' in 'libxl_psr_cat_get_info'

2017-09-01 Thread Yi Sun
Due to historical reason, type of parameter '*nr' in 'libxl_psr_cat_get_info' is 'int'. But this is not right. It should be 'unsigned int'. This patch fixes this and does related changes. Suggested-by: Roger Pau Monné Signed-off-by: Yi Sun --- - This patch depends on patch 'tools: remove unn

[Xen-devel] [linux-4.9 test] 112989: regressions - trouble: blocked/broken/fail/pass

2017-09-01 Thread osstest service owner
flight 112989 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/112989/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 112863 Tests which are

[Xen-devel] [ovmf test] 112991: all pass - PUSHED

2017-09-01 Thread osstest service owner
flight 112991 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/112991/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 17cbf7359f04a4eb762b2b4bc26c2df635ef2812 baseline version: ovmf f29ca8e8b96adc2539f44

[Xen-devel] [PATCH v8 1/3] tools/libxc: move SUPERPAGE macros to common header

2017-09-01 Thread Olaf Hering
The macros SUPERPAGE_2MB_SHIFT and SUPERPAGE_1GB_SHIFT will be used by other code in libxc. Move the macros to a header file. Signed-off-by: Olaf Hering Acked-by: Wei Liu --- tools/libxc/xc_dom_x86.c | 5 - tools/libxc/xc_private.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-)

[Xen-devel] [PATCH v8 0/3] tools/libxc: use superpages

2017-09-01 Thread Olaf Hering
Using superpages on the receiving dom0 will avoid performance regressions. Olaf v8: remove double check of 1G/2M idx in x86_hvm_populate_pfns v7: cover holes that span multiple superpages v6: handle freeing of partly populated superpages correctly more DPRINTFs v5: send correct version, reba

[Xen-devel] [PATCH v8 2/3] tools/libxc: add API for bitmap access for restore

2017-09-01 Thread Olaf Hering
Extend API for managing bitmaps. Each bitmap is now represented by a generic struct xc_sr_bitmap. Switch the existing populated_pfns to this API. Signed-off-by: Olaf Hering Acked-by: Wei Liu --- tools/libxc/xc_sr_common.c | 41 +++ tools/libxc/xc_sr_common.h | 68 +

[Xen-devel] [PATCH v8 3/3] tools/libxc: use superpages during restore of HVM guest

2017-09-01 Thread Olaf Hering
During creating of a HVM domU meminit_hvm() tries to map superpages. After save/restore or migration this mapping is lost, everything is allocated in single pages. This causes a performance degradition after migration. Add neccessary code to preallocate a superpage for the chunk of pfns that is re

Re: [Xen-devel] [RFC PATCH V2 1/4] xen/hap: Increase hap page pool size for more vcpus support

2017-09-01 Thread Lan Tianyu
On 2017年08月31日 21:56, Andrew Cooper wrote: > On 31/08/17 06:01, Lan Tianyu wrote: >> This patch is to increase hap page pool size to support more vcpus in single >> VM. >> >> Signed-off-by: Lan Tianyu >> --- >> xen/arch/x86/mm/hap/hap.c | 10 +- >> 1 file changed, 9 insertions(+), 1 dele

Re: [Xen-devel] [PATCH v5 1/4] VT-d PI: track the number of vcpus on pi blocking list

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 03:39, wrote: > After thinking it again, I want to define the counter as > a unsigned int variable for the following reasion: > 1. It is definite that the counter is closely related with > list_add() and list_del(). If the list is protected by the > lock, it is straightforward t

[Xen-devel] [xen-unstable baseline-only test] 72048: regressions - trouble: blocked/broken/fail/pass

2017-09-01 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72048 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72048/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-examine 7 reboot

Re: [Xen-devel] [RFC PATCH V2 1/4] xen/hap: Increase hap page pool size for more vcpus support

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 10:19, wrote: > On 2017年08月31日 21:56, Andrew Cooper wrote: >> On 31/08/17 06:01, Lan Tianyu wrote: >>> This patch is to increase hap page pool size to support more vcpus in >>> single > VM. >>> >>> Signed-off-by: Lan Tianyu >>> --- >>> xen/arch/x86/mm/hap/hap.c | 10

Re: [Xen-devel] [PATCH v8 3/3] tools/libxc: use superpages during restore of HVM guest

2017-09-01 Thread Olaf Hering
On Fri, Sep 01, Olaf Hering wrote: > +static int x86_hvm_populate_pfns(struct xc_sr_context *ctx, unsigned count, > +/* > + * If this next pfn is within another 1GB superpage it is > required > + * to scan the entire previous superpage because there might be >

[Xen-devel] [qemu-mainline test] 112990: regressions - trouble: blocked/broken/fail/pass

2017-09-01 Thread osstest service owner
flight 112990 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/112990/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 7 xen-boot fail REGR. vs. 112869 test-amd64-amd64-

[Xen-devel] [distros-debian-jessie test] 72049: regressions - trouble: blocked/broken/fail/pass

2017-09-01 Thread Platform Team regression test user
flight 72049 distros-debian-jessie real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-armhf-jessie-netboot-pygrub 7 xen-boot fail REGR. vs. 72017 Tests w

Re: [Xen-devel] [PATCH] x86/pv: Prohibit attempts to initialise a vcpu with EFLAGS.{NT, VM} set

2017-09-01 Thread Jan Beulich
>>> On 31.08.17 at 19:07, wrote: > Luckily, this isn't a security issue, because the fix for XSA-202 (c/s > 0e47f92b072) took a proactive aproach and clobbered these flags on the > exit-to-guest path. Which makes me wonder whether ... > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c >

Re: [Xen-devel] [xen-unstable test] 112981: tolerable trouble: blocked/broken/fail/pass - PUSHED

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 03:22, wrote: > flight 112981 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/112981/ > > Failures :-/ but no regressions. > [...] > version targeted for testing: > xen dab6a84aadab11f31332030a1e9f0b9282d76156 Now this is sort of

Re: [Xen-devel] [PATCH v5 1/4] VT-d PI: track the number of vcpus on pi blocking list

2017-09-01 Thread Chao Gao
On Fri, Sep 01, 2017 at 02:24:08AM -0600, Jan Beulich wrote: On 01.09.17 at 03:39, wrote: >> After thinking it again, I want to define the counter as >> a unsigned int variable for the following reasion: >> 1. It is definite that the counter is closely related with >> list_add() and list_del(

Re: [Xen-devel] [PATCH] tools: change the type of '*nr' in 'libxl_psr_cat_get_info'

2017-09-01 Thread Roger Pau Monné
On Fri, Sep 01, 2017 at 02:59:23PM +0800, Yi Sun wrote: > @@ -410,8 +410,10 @@ int libxl_psr_cat_get_l3_info(libxl_ctx *ctx, > libxl_psr_cat_info **info, >int *nr) > { > int rc; > +unsigned int num; > > -rc = libxl_psr_cat_get_info(ctx, info, nr, 3);

[Xen-devel] [PATCH] xen: reset creation_finished flag on soft reset

2017-09-01 Thread Vitaly Kuznetsov
C/s e7dabe5 ("x86/hvm: don't unconditionally create a default ioreq server") broke soft reset when QEMU traditional is being used. During soft reset QEMU is relaunched and default ioreq server needs to be re-created upon first HVM_PARAM_*IOREQ_* request. The flag will be set back to 'true' when too

Re: [Xen-devel] [PATCH v5 1/4] VT-d PI: track the number of vcpus on pi blocking list

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 09:55, wrote: > On Fri, Sep 01, 2017 at 02:24:08AM -0600, Jan Beulich wrote: > On 01.09.17 at 03:39, wrote: >>> After thinking it again, I want to define the counter as >>> a unsigned int variable for the following reasion: >>> 1. It is definite that the counter is closely

Re: [Xen-devel] [PATCH] xen: reset creation_finished flag on soft reset

2017-09-01 Thread Andrew Cooper
On 01/09/2017 10:11, Vitaly Kuznetsov wrote: > C/s e7dabe5 ("x86/hvm: don't unconditionally create a default ioreq > server") broke soft reset when QEMU traditional is being used. During > soft reset QEMU is relaunched and default ioreq server needs to be > re-created upon first HVM_PARAM_*IOREQ_*

Re: [Xen-devel] [RFC PATCH V2 1/4] xen/hap: Increase hap page pool size for more vcpus support

2017-09-01 Thread Lan Tianyu
On 2017年09月01日 16:34, Jan Beulich wrote: On 01.09.17 at 10:19, wrote: >> On 2017年08月31日 21:56, Andrew Cooper wrote: >>> On 31/08/17 06:01, Lan Tianyu wrote: This patch is to increase hap page pool size to support more vcpus in single >> VM. Signed-off-by: Lan Tianyu >>>

Re: [Xen-devel] [PATCH v2 1/2] x86/mm: don't wrap x86_emulate_ctxt in ptwr_emulate_ctxt

2017-09-01 Thread Jan Beulich
>>> On 31.08.17 at 13:22, wrote: > @@ -5221,10 +5217,12 @@ int ptwr_do_page_fault(struct vcpu *v, unsigned long > addr, > goto bail; > } > > -ptwr_ctxt.cr2 = addr; > -ptwr_ctxt.pte = pte; > +ptwr_ctxt = (struct ptwr_emulate_ctxt) { > +.cr2 = addr, > +.p

Re: [Xen-devel] [PATCH] xen: reset creation_finished flag on soft reset

2017-09-01 Thread Vitaly Kuznetsov
Andrew Cooper writes: > On 01/09/2017 10:11, Vitaly Kuznetsov wrote: >> C/s e7dabe5 ("x86/hvm: don't unconditionally create a default ioreq >> server") broke soft reset when QEMU traditional is being used. During >> soft reset QEMU is relaunched and default ioreq server needs to be >> re-created

Re: [Xen-devel] [PATCH] xen: reset creation_finished flag on soft reset

2017-09-01 Thread Paul Durrant
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: 01 September 2017 10:27 > To: Andrew Cooper ; Paul Durrant > > Cc: xen-devel@lists.xen.org; George Dunlap ; > Ian Jackson ; Jan Beulich ; > Konrad Rzeszutek Wilk ; Stefano Stabellini > ; Tim (Xen.org) ; Wei

Re: [Xen-devel] [PATCH v5 1/4] VT-d PI: track the number of vcpus on pi blocking list

2017-09-01 Thread Chao Gao
On Fri, Sep 01, 2017 at 03:13:17AM -0600, Jan Beulich wrote: On 01.09.17 at 09:55, wrote: >> On Fri, Sep 01, 2017 at 02:24:08AM -0600, Jan Beulich wrote: >> On 01.09.17 at 03:39, wrote: After thinking it again, I want to define the counter as a unsigned int variable for the fol

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-09-01 Thread Jan Beulich
>>> On 31.08.17 at 13:22, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -5176,91 +5176,6 @@ static const struct x86_emulate_ops ptwr_emulate_ops = > { > .cpuid = pv_emul_cpuid, > }; > > -/* Write page fault handler: check if guest is trying to modify a PTE. */ > -in

Re: [Xen-devel] [PATCH v5 03/10] public: xen.h: add definitions for UUID handling

2017-09-01 Thread Ian Jackson
Volodymyr Babchuk writes ("[PATCH v5 03/10] public: xen.h: add definitions for UUID handling"): > Added type xen_uuid_t. This type represents UUID as an array of 16 > bytes in big endian format. > > Added macro XEN_DEFINE_UUID that constructs UUID in the usual way: > > XEN_DEFINE_UUID(00112233,

Re: [Xen-devel] [RFC PATCH V2 2/4] Tool/ACPI: DSDT extension to support more vcpus

2017-09-01 Thread Roger Pau Monné
On Fri, Sep 01, 2017 at 10:54:02AM +0800, Lan Tianyu wrote: > On 2017年08月31日 23:38, Roger Pau Monné wrote: > > On Thu, Aug 31, 2017 at 01:01:47AM -0400, Lan Tianyu wrote: > >> This patch is to change DSDT table for processor object to support >128 > >> vcpus > >> accroding to ACPI spec 8.4 Declari

Re: [Xen-devel] [PATCH v5 1/4] VT-d PI: track the number of vcpus on pi blocking list

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 10:37, wrote: > it seems add_sized() won't be a LOCKed instruction. > #define build_add_sized(name, size, type, reg) \ > static inline void name(volatile type *addr, type val) \ > { \ >

Re: [Xen-devel] [RFC PATCH V2 3/4] hvmload: Add x2apic entry support in the MADT build

2017-09-01 Thread Roger Pau Monné
On Thu, Aug 31, 2017 at 01:01:48AM -0400, Lan Tianyu wrote: > This patch is to add x2apic entry support for ACPI MADT table > according to ACPI spec 5.2.12.12 Processor Local x2APIC Structure > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu > --- > tools/libacpi/acpi2_0.h | 10 +

Re: [Xen-devel] [PATCH v5 1/4] VT-d PI: track the number of vcpus on pi blocking list

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 11:55, wrote: On 01.09.17 at 10:37, wrote: >> it seems add_sized() won't be a LOCKed instruction. >> #define build_add_sized(name, size, type, reg) \ >> static inline void name(volatile type *addr, type val) \ >> {

Re: [Xen-devel] [RFC PATCH V2 2/4] Tool/ACPI: DSDT extension to support more vcpus

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 11:41, wrote: > I'm not sure why lapic_id needs to be a hook in any case, both it's > callers use the same exact formula (cpu_id * 2). You're aware that this is meant to be improved rather sooner than later. At that point I'm then not sure a suitable LAPIC_ID() macro could be c

[Xen-devel] [OSSTEST PATCH] production-config: Publish per-flight osstest git refs in separate tree

2017-09-01 Thread Ian Jackson
Those refs need to be somewhere public so that the relevant git objects are accessible. I think they probably have to be in refs/tags/ or refs/heads/ of some repo. But it doesn't have to be the main one on xenbits. Most people won't want these refs. Most git commits they are interested in (eg g

[Xen-devel] [ovmf baseline-only test] 72050: all pass

2017-09-01 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72050 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72050/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 17cbf7359f04a4eb762b2b4bc26c2df635ef2812 baseline v

Re: [Xen-devel] [RFC PATCH V2 2/4] Tool/ACPI: DSDT extension to support more vcpus

2017-09-01 Thread Roger Pau Monné
On Fri, Sep 01, 2017 at 04:10:26AM -0600, Jan Beulich wrote: > >>> On 01.09.17 at 11:41, wrote: > > I'm not sure why lapic_id needs to be a hook in any case, both it's > > callers use the same exact formula (cpu_id * 2). > > You're aware that this is meant to be improved rather sooner than > late

Re: [Xen-devel] [PATCH v9 1/2] x86emul: New return code for unimplemented instruction

2017-09-01 Thread Jan Beulich
>>> On 30.08.17 at 20:57, wrote: > --- a/xen/arch/x86/hvm/emulate.c > +++ b/xen/arch/x86/hvm/emulate.c > @@ -2044,6 +2044,7 @@ int hvm_emulate_one_mmio(unsigned long mfn, unsigned > long gla) Way earlier in this file there are consumers of X86EMUL_UNHANDLEABLE in hvmemul_do_io() and hvmemul_do_i

Re: [Xen-devel] [PATCH] xen: reset creation_finished flag on soft reset

2017-09-01 Thread Vitaly Kuznetsov
Paul Durrant writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: 01 September 2017 10:27 >> To: Andrew Cooper ; Paul Durrant >> >> Cc: xen-devel@lists.xen.org; George Dunlap ; >> Ian Jackson ; Jan Beulich ; >> Konrad Rzeszutek Wilk ; Stefano Stab

[Xen-devel] [PATCH v1] x86/hvm: Expose MSR_SHADOW_GS_BASE

2017-09-01 Thread Alexandru Isaila
This patch is adding an new param in the hvm_hw_cpu structure so it can be exposed to user space. Signed-off-by: Alexandru Isaila --- xen/arch/x86/hvm/hvm.c | 4 xen/include/public/arch-x86/hvm/save.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/xen/arch/x86/hvm/hv

[Xen-devel] [PATCH] MAINTAINERS: add arch specific public headers to arch file groups

2017-09-01 Thread Jan Beulich
I've recently got sufficiently annoyed by people not applying enough common sense to get_maintainer.pl output, Cc-ing all REST maintainers on ARM-only public interface changes. Sort ARM's xen/ groups of path specifications at the same time. Signed-off-by: Jan Beulich --- a/MAINTAINERS +++ b/MAI

Re: [Xen-devel] [PATCH] xen: reset creation_finished flag on soft reset

2017-09-01 Thread Paul Durrant
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: 01 September 2017 11:43 > To: Paul Durrant > Cc: Andrew Cooper ; xen- > de...@lists.xen.org; George Dunlap ; Ian > Jackson ; Jan Beulich ; > Konrad Rzeszutek Wilk ; Stefano Stabellini > ; Tim (Xen.org) ; Wei

Re: [Xen-devel] [PATCH v1] x86/hvm: Expose MSR_SHADOW_GS_BASE

2017-09-01 Thread Andrew Cooper
On 01/09/17 11:44, Alexandru Isaila wrote: > diff --git a/xen/include/public/arch-x86/hvm/save.h > b/xen/include/public/arch-x86/hvm/save.h > index fd7bf3f..e6e8e87 100644 > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/arch-x86/hvm/save.h > @@ -134,6 +134,8 @@ struct hvm

Re: [Xen-devel] [PATCH v1] x86/hvm: Expose MSR_SHADOW_GS_BASE

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 12:44, wrote: > This patch is adding an new param in the hvm_hw_cpu structure > so it can be exposed to user space. But you don't say why. > --- a/xen/include/public/arch-x86/hvm/save.h > +++ b/xen/include/public/arch-x86/hvm/save.h > @@ -134,6 +134,8 @@ struct hvm_hw_cpu { >

Re: [Xen-devel] [PATCH] MAINTAINERS: add arch specific public headers to arch file groups

2017-09-01 Thread Andrew Cooper
On 01/09/17 11:45, Jan Beulich wrote: > I've recently got sufficiently annoyed by people not applying enough > common sense to get_maintainer.pl output, Cc-ing all REST maintainers > on ARM-only public interface changes. > > Sort ARM's xen/ groups of path specifications at the same time. > > Signed

Re: [Xen-devel] [PATCH v1] x86/hvm: Expose MSR_SHADOW_GS_BASE

2017-09-01 Thread Razvan Cojocaru
On 01.09.2017 13:55, Andrew Cooper wrote: On 01/09/17 11:44, Alexandru Isaila wrote: diff --git a/xen/include/public/arch-x86/hvm/save.h b/xen/include/public/arch-x86/hvm/save.h index fd7bf3f..e6e8e87 100644 --- a/xen/include/public/arch-x86/hvm/save.h +++ b/xen/include/public/arch-x86/hvm/save

[Xen-devel] [xen-unstable test] 112992: tolerable trouble: blocked/broken/fail/pass - PUSHED

2017-09-01 Thread osstest service owner
flight 112992 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/112992/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-che

[Xen-devel] [xen-unstable-smoke test] 112997: tolerable trouble: broken/pass - PUSHED

2017-09-01 Thread osstest service owner
flight 112997 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/112997/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a build-arm64-pvops 2 hos

[Xen-devel] [PATCH v2] tools: change the type of '*nr' in 'libxl_psr_cat_get_info'

2017-09-01 Thread Yi Sun
Due to historical reason, type of parameter '*nr' in 'libxl_psr_cat_get_info' is 'int'. But this is not right. It should be 'unsigned int'. This patch fixes this and does related changes. Suggested-by: Roger Pau Monné Signed-off-by: Yi Sun --- - This patch depends on patch 'tools: remove unn

[Xen-devel] [libvirt test] 112994: tolerable trouble: blocked/broken/pass - PUSHED

2017-09-01 Thread osstest service owner
flight 112994 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/112994/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1)

[Xen-devel] [PATCH] x86/public: Further correctsion to vcpu context comments

2017-09-01 Thread Andrew Cooper
VCPUOP_initialise and DOMCTL_setvcpucontext are not symetric. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/include/public/arch-x86/xen.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/xen/include/public/arch-x86/xen.h

Re: [Xen-devel] [PATCH] x86/public: Further correctsion to vcpu context comments

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 15:14, wrote: > VCPUOP_initialise and DOMCTL_setvcpucontext are not symetric. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-09-01 Thread Wei Liu
On Fri, Sep 01, 2017 at 03:38:49AM -0600, Jan Beulich wrote: > > /* > > * fault handling for read-only MMIO pages > > */ > > Note how you move the remains of the function above below this > comment, which isn't really correct. I can place the new function where the ol

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-09-01 Thread Wei Liu
On Fri, Sep 01, 2017 at 02:46:27PM +0100, Wei Liu wrote: > On Fri, Sep 01, 2017 at 03:38:49AM -0600, Jan Beulich wrote: > > > /* > > > * fault handling for read-only MMIO pages > > > */ > > > > Note how you move the remains of the function above below this > > comment,

Re: [Xen-devel] [PATCH v2] tools: change the type of '*nr' in 'libxl_psr_cat_get_info'

2017-09-01 Thread Roger Pau Monné
On Fri, Sep 01, 2017 at 08:15:05PM +0800, Yi Sun wrote: > Due to historical reason, type of parameter '*nr' in 'libxl_psr_cat_get_info' > is 'int'. But this is not right. It should be 'unsigned int'. This patch fixes > this and does related changes. > > Suggested-by: Roger Pau Monné > Signed-off-

[Xen-devel] [PATCH v3 1/2] x86/mm: don't wrap x86_emulate_ctxt in ptwr_emulate_ctxt

2017-09-01 Thread Wei Liu
Rewrite the code so that it has the same structure as mmio_ro_emualte_ctxt. x86_emulate_ctxt now points to ptwr_emulate_ctxt via its data pointer. This patch will help unify mmio_ro and ptwr code paths later. Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- v3: drop unnecessary hunk, but k

[Xen-devel] [PATCH v3 0/2] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-09-01 Thread Wei Liu
Can be found at my xenbits/xen.git wip.merge-mmio-ptwr-emul-v3 Wei Liu (2): x86/mm: don't wrap x86_emulate_ctxt in ptwr_emulate_ctxt x86/mm: merge ptwr and mmio_ro page fault handlers xen/arch/x86/mm.c| 222 --- xen/arch/x86/traps.c |

[Xen-devel] [PATCH v3 2/2] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-09-01 Thread Wei Liu
Provide a unified entry to avoid going through pte look-up, decode and emulation cycle more than necessary. The path taken is determined by the faulting address. Note that the order of checks is changed in the new function, but the order of the checks is performed shouldn't matter. The sole calle

Re: [Xen-devel] [PATCH] x86/public: Further correctsion to vcpu context comments

2017-09-01 Thread Roger Pau Monné
There's a typo in the subject line s/correctsion/correction/. On Fri, Sep 01, 2017 at 02:14:41PM +0100, Andrew Cooper wrote: > VCPUOP_initialise and DOMCTL_setvcpucontext are not symetric. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Long term DOMCTL_setvcpucontext should on

[Xen-devel] [linux-linus test] 112993: tolerable trouble: blocked/broken/fail/pass - PUSHED

2017-09-01 Thread osstest service owner
flight 112993 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/112993/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-qemut-win7-amd64 17 guest-stop fail REGR. vs. 112983 Tests which did not succeed,

Re: [Xen-devel] [PATCH 00/13] mmu_notifier kill invalidate_page callback

2017-09-01 Thread Jeff Cook
On Wed, Aug 30, 2017, at 10:57 AM, Adam Borowski wrote: > On Tue, Aug 29, 2017 at 08:56:15PM -0400, Jerome Glisse wrote: > > I will wait for people to test and for result of my own test before > > reposting if need be, otherwise i will post as separate patch. > > > > > But from a _very_ quick read-

[Xen-devel] [PATCH v2 0/1] netif: staging grants for I/O requests

2017-09-01 Thread Joao Martins
Hey, This is v2 taking into consideration all comments received from RFC/v1. The approach has significantly changed and we use control ring messages to the manage the permanent gref mappings - as also presented at XDDS17. The specification is right after the diffstat. I kept the same name "staging

[Xen-devel] [PATCH v2 1/1] public/io/netif.h: add gref mapping control messages

2017-09-01 Thread Joao Martins
Adds 3 messages to allow guest to let backend keep grants mapped, such that 1) guests allowing fast recycling of pages can avoid doing grant ops for those cases, or otherwise 2) preferring copies over grants and 3) always using a fixed set of pages for network I/O. The three control ring messages

Re: [Xen-devel] [PATCH RFC] Add SUPPORT.md\

2017-09-01 Thread Wei Liu
On Thu, Aug 31, 2017 at 11:27:19AM +0100, George Dunlap wrote: > +### Direct-boot kernel image format > + > +Supported, x86: bzImage Do you mean booting a PV guest? If so there are a few more formats. > +Supported, ARM32: zImage > +Supported, ARM64: Image [XXX - Not sure if this is co

[Xen-devel] [OSSTEST PATCH] PERLLIB, @INC: Add . in some places we missed

2017-09-01 Thread Ian Jackson
* cri-getconfig (invoked by many cr* scripts, standalone-reset, etc.) * mgi-common (invoked by many mg*) * Two literal perl -e includes in Tcl code. I think this leaves no scripts which do not set PERLLIB or @INC, either by themselves or by something they source with `.'. Reported-by: George Dunl

[Xen-devel] [OSSTEST PATCH] mg-host: Prepare $checkhostq only if needed

2017-09-01 Thread Ian Jackson
This is helpful because in standalone mode there is no resources table and this fails. But we want people to use `mg-hosts power' in standalone mode, if they can, rather than running ./msu-pdu ad-hoc (or whatever). Reported-by: George Dunlap Signed-off-by: Ian Jackson --- mg-hosts | 8 +---

[Xen-devel] [OSSTEST PATCH] README: document need for libnet-snmp-perl

2017-09-01 Thread Ian Jackson
Signed-off-by: Ian Jackson --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index b45058d..ffe0018 100644 --- a/README +++ b/README @@ -254,6 +254,7 @@ To run osstest in standalone mode: chiark-utils-bin libxml-libxml-perl dctrl-tools + libnet-s

Re: [Xen-devel] [PATCH] libxl: fix incremental parallel build

2017-09-01 Thread Wei Liu
On Wed, Aug 30, 2017 at 01:06:10AM -0600, Jan Beulich wrote: > Short-circuit absolute paths of generated headers to their pathless > equivalents, to avoid two racing invocations of the same rule producing > them. > > Signed-off-by: Jan Beulich > --- > This wants to be backported to 4.9 and 4.8. >

[Xen-devel] [PATCH] x86/shadow: Clarify the safety of guest-linear mapping construction

2017-09-01 Thread Andrew Cooper
sh_install_xen_entries_in_l4() looks unsafe, as it creates a guest-linear mapping with gl4mfn. However, it is correct because of the way monitor tables are constructed for translated domains. Leave a comment and some clarifying assertions. Also, there is no longer support for translate != extern

Re: [Xen-devel] [PATCH v2 2/2] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 15:50, wrote: > On Fri, Sep 01, 2017 at 02:46:27PM +0100, Wei Liu wrote: >> On Fri, Sep 01, 2017 at 03:38:49AM -0600, Jan Beulich wrote: >> > > + struct cpu_user_regs *regs) >> > > +{ >> > > +l1_pgentry_t pte; >> > > +struct domain *d = v->domain; >>

Re: [Xen-devel] [PATCH v4 36/39] altp2m: Document external-only use on ARM

2017-09-01 Thread Wei Liu
On Wed, Aug 30, 2017 at 08:32:55PM +0200, Sergej Proskurin wrote: > From: Tamas K Lengyel > > Currently, the altp2m feature has been used and thus documented for the > x86 architecture. As we aim to introduce altp2m to ARM, in this commit, > we adjust the documentation by pointing out x86 only pa

Re: [Xen-devel] [PATCH] libxl: fix incremental parallel build

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 17:28, wrote: > On Wed, Aug 30, 2017 at 01:06:10AM -0600, Jan Beulich wrote: >> Short-circuit absolute paths of generated headers to their pathless >> equivalents, to avoid two racing invocations of the same rule producing >> them. >> >> Signed-off-by: Jan Beulich >> --- >> Th

Re: [Xen-devel] [PATCH v4 37/39] altp2m: Allow activating altp2m on ARM domains

2017-09-01 Thread Wei Liu
On Wed, Aug 30, 2017 at 08:32:56PM +0200, Sergej Proskurin wrote: > The previous libxl implemention limited the use of altp2m to x86 HVM domains. > This commit extends libxl by introducing the altp2m switch to ARM domains. > > Additionally, we introduce the macro LIBXL_HAVE_ARM_ALTP2M in parallel

Re: [Xen-devel] [PATCH v3 2/2] x86/mm: merge ptwr and mmio_ro page fault handlers

2017-09-01 Thread Jan Beulich
>>> On 01.09.17 at 16:35, wrote: > Provide a unified entry to avoid going through pte look-up, decode and > emulation cycle more than necessary. The path taken is determined by > the faulting address. > > Note that the order of checks is changed in the new function, but the > order of the checks

Re: [Xen-devel] [RFC PATCH V2 4/4] xl/libacpi: extend lapic_id() to uint32_t

2017-09-01 Thread Wei Liu
On Thu, Aug 31, 2017 at 01:01:49AM -0400, Lan Tianyu wrote: > From: Chao Gao > > This patch is to extend lapic_id() to support more vcpus. > > Signed-off-by: Chao Gao > Signed-off-by: Lan Tianyu Acked-by: Wei Liu Please remember to pick up my ack next time around -- I believed I already ack

Re: [Xen-devel] [PATCH 2/2] tools: remove unnecessary PSR macros

2017-09-01 Thread Wei Liu
On Thu, Aug 31, 2017 at 04:08:06PM +0800, Yi Sun wrote: > Per Roger Pau's coment, the libxl interfaces and related functions are not > necessary to be included by 'LIBXL_HAVE_PSR_CMT' and 'LIBXL_HAVE_PSR_CAT'. > So remove them. > > Signed-off-by: Yi Sun Acked-by: Wei Liu (without reading the p

Re: [Xen-devel] [PATCH] tools: change the type of '*nr' in 'libxl_psr_cat_get_info'

2017-09-01 Thread Wei Liu
On Fri, Sep 01, 2017 at 02:59:23PM +0800, Yi Sun wrote: > Due to historical reason, type of parameter '*nr' in 'libxl_psr_cat_get_info' > is 'int'. But this is not right. It should be 'unsigned int'. This patch fixes > this and does related changes. > > Suggested-by: Roger Pau Monné > Signed-off-

[Xen-devel] [OSSTEST PATCH 2/2] PERLLIB, @INC: Use BEGIN { }

2017-09-01 Thread Ian Jackson
unshifting @INC is only effective if done at compile time, so that it affects `use' directives. So "Perl: Put . on @INC" f261b07cbe96844dba5d8594c38149c0b179068a is simply broken This patch was autogenerated using the following rune: git-grep -l 'unshift @INC' | xargs perl -i~ -pe 's#\bunshif

[Xen-devel] [OSSTEST PATCH 1/2] mg-hosts: Fix another couple of prepared statements

2017-09-01 Thread Ian Jackson
Use our $blah_q //= ... since these are used only here. This is a cheap kind of memoisation of a global constant. Reported-by: George Dunlap Signed-off-by: Ian Jackson --- mg-hosts | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mg-hosts b/mg-hosts index b62e430..2

Re: [Xen-devel] [PATCH v2] tools: change the type of '*nr' in 'libxl_psr_cat_get_info'

2017-09-01 Thread Wei Liu
On Fri, Sep 01, 2017 at 08:15:05PM +0800, Yi Sun wrote: > Due to historical reason, type of parameter '*nr' in 'libxl_psr_cat_get_info' > is 'int'. But this is not right. It should be 'unsigned int'. This patch fixes > this and does related changes. > > Suggested-by: Roger Pau Monné > Signed-off-

[Xen-devel] [PATCH v2 4/5] xentrace: enable per-VCPU extratime flag for RTDS

2017-09-01 Thread Meng Xu
Change repl_budget event output for xentrace formats and xenalyze Signed-off-by: Meng Xu --- Changes from v1 Add this changes from v1 --- tools/xentrace/formats| 2 +- tools/xentrace/xenalyze.c | 8 +--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/xentrace/forma

[Xen-devel] [PATCH v2 1/5] xen:rtds: towards work conserving RTDS

2017-09-01 Thread Meng Xu
Make RTDS scheduler work conserving without breaking the real-time guarantees. VCPU model: Each real-time VCPU is extended to have an extratime flag and a priority_level field. When a VCPU's budget is depleted in the current period, if it has extratime flag set, its priority_level will increase by

[Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-01 Thread Meng Xu
Modify libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set functions to support per-VCPU extratime flag Signed-off-by: Meng Xu --- Changes from v1 1) Add LIBXL_HAVE_SCHED_RTDS_VCPU_EXTRA to indicate if extratime flag is supported 2) Change flag name in domctl.h from XEN_DOMCTL_SCHED_RTDS

[Xen-devel] [PATCH v2 0/5] Towards work-conserving RTDS

2017-09-01 Thread Meng Xu
This series of patches make RTDS scheduler work-conserving without breaking real-time guarantees. VCPUs with extratime flag set can get extra time from the unreserved system resource. System administrators can decide which VCPUs have extratime flag set. Example: Set the extratime bit of all VCPUs

[Xen-devel] [PATCH v2 3/5] xl: enable per-VCPU extratime flag for RTDS

2017-09-01 Thread Meng Xu
Change main_sched_rtds and related output functions to support per-VCPU extratime flag. Signed-off-by: Meng Xu --- Changes from v1 No change because we agree on using -e 0/1 option to set if a vcpu will get extra time or not Changes from RFC v1 Changes work_conserving flag to extratime flag ---

[Xen-devel] [PATCH v2 5/5] docs: enable per-VCPU extratime flag for RTDS

2017-09-01 Thread Meng Xu
Revise xl tool use case by adding -e option Remove work-conserving from TODO list Signed-off-by: Meng Xu --- Changes from v1 Revise rtds docs --- docs/features/sched_rtds.pandoc | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/features/sched_rtds.pandoc b/docs/fea

Re: [Xen-devel] [PATCH v2 2/5] libxl: enable per-VCPU extratime flag for RTDS

2017-09-01 Thread Meng Xu
Dario, I didn't include your Reviewed-by tag because I made one small change. On Fri, Sep 1, 2017 at 11:58 AM, Meng Xu wrote: > > Modify libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set > functions to support per-VCPU extratime flag > > Signed-off-by: Meng Xu > > --- > Changes from

Re: [Xen-devel] [PATCH v2 3/6] libxl:xl: add parsing code to parse "libxl_static_sshm" from xl config files

2017-09-01 Thread Wei Liu
On Sun, Aug 27, 2017 at 04:36:12PM +0800, Zhongze Liu wrote: > Add the parsing utils for the newly introduced libxl_static_sshm struct > to the libxl/libxlu_* family. And add realated parsing code in xl to > parse the struct from xl config files. This is for the proposal "Allow > setting up shared

[Xen-devel] [PATCH v9 1/3] tools/libxc: move SUPERPAGE macros to common header

2017-09-01 Thread Olaf Hering
The macros SUPERPAGE_2MB_SHIFT and SUPERPAGE_1GB_SHIFT will be used by other code in libxc. Move the macros to a header file. Signed-off-by: Olaf Hering Acked-by: Wei Liu --- tools/libxc/xc_dom_x86.c | 5 - tools/libxc/xc_private.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-)

[Xen-devel] [PATCH v9 0/3] tools/libxc: use superpages

2017-09-01 Thread Olaf Hering
Using superpages on the receiving dom0 will avoid performance regressions. Olaf v9: update hole checking in x86_hvm_populate_pfns add out of bounds check to xc_sr_test_and_set/clear_bit v8: remove double check of 1G/2M idx in x86_hvm_populate_pfns v7: cover holes that span multiple superpages

[Xen-devel] [PATCH v9 2/3] tools/libxc: add API for bitmap access for restore

2017-09-01 Thread Olaf Hering
Extend API for managing bitmaps. Each bitmap is now represented by a generic struct xc_sr_bitmap. Switch the existing populated_pfns to this API. Signed-off-by: Olaf Hering Acked-by: Wei Liu --- tools/libxc/xc_sr_common.c | 41 ++ tools/libxc/xc_sr_common.h | 72 ++

[Xen-devel] [PATCH v9 3/3] tools/libxc: use superpages during restore of HVM guest

2017-09-01 Thread Olaf Hering
During creating of a HVM domU meminit_hvm() tries to map superpages. After save/restore or migration this mapping is lost, everything is allocated in single pages. This causes a performance degradition after migration. Add neccessary code to preallocate a superpage for the chunk of pfns that is re

Re: [Xen-devel] [PATCH v3] xen: Implement hypercall for tracing of program counters

2017-09-01 Thread Jan Beulich
>>> On 11.08.17 at 17:25, wrote: > This commit makes the changes to the hypervisor, the build system as > well as libxc necessary in order to facilitate tracing of program counters. There are no libxc changes here afaics. > A discussion of the design can be found in the mailing list: > https://l

[Xen-devel] [PATCH RFC] domctl: improve locking during domain destruction

2017-09-01 Thread Jan Beulich
There is no need to hold the global domctl lock while across domain_kill() - the domain lock is fully sufficient here. Signed-off-by: Jan Beulich --- Sadly so far we haven't had any feedback on this change from the people who observed an issue apparently resulting from heavy contention here. Henc

[Xen-devel] [PATCH] domctl/x86: move vMSI related #define-s to public interface

2017-09-01 Thread Jan Beulich
Xen and qemu having identical #define-s (with different names) is a strong hint that these should be part of the public interface, at the same time making obvious that any change to the values in an interface modification (and hence needs suitable care). Signed-off-by: Jan Beulich --- a/xen/arch

Re: [Xen-devel] [PATCH v2 5/6] libxl: support mapping static shared memory areas during domain creation

2017-09-01 Thread Wei Liu
On Sun, Aug 27, 2017 at 04:36:14PM +0800, Zhongze Liu wrote: > Add libxl__sshm_add to map shared pages from one DomU to another, The mapping > process involves the follwing steps: > > * Set defaults and check for further errors in the static_shm configs: > overlapping areas, invalid ranges,

[Xen-devel] [PATCH resend] domctl/x86: move vMSI related #define-s to public interface

2017-09-01 Thread Jan Beulich
Xen and qemu having identical #define-s (with different names) is a strong hint that these should be part of the public interface, at the same time making obvious that any change to the values in an interface modification (and hence needs suitable care). Signed-off-by: Jan Beulich --- I'm sorry f

Re: [Xen-devel] [PATCH v2 3/6] libxl:xl: add parsing code to parse "libxl_static_sshm" from xl config files

2017-09-01 Thread Wei Liu
On Sun, Aug 27, 2017 at 04:36:12PM +0800, Zhongze Liu wrote: > Add the parsing utils for the newly introduced libxl_static_sshm struct > to the libxl/libxlu_* family. And add realated parsing code in xl to > parse the struct from xl config files. This is for the proposal "Allow > setting up shared

[Xen-devel] [PATCH] xen: use vMSI related #define-s from public interface

2017-09-01 Thread Jan Beulich
Xen and qemu having identical #define-s (with different names) is a strong hint that these should have been part of the public interface from the very start. Use them if they're available, falling back to privately defined values only when using older headers. Signed-off-by: Jan Beulich --- a/hw

Re: [Xen-devel] [PATCH RFC] domctl: improve locking during domain destruction

2017-09-01 Thread Andrew Cooper
On 01/09/17 17:18, Jan Beulich wrote: > There is no need to hold the global domctl lock while across > domain_kill() - the domain lock is fully sufficient here. > > Signed-off-by: Jan Beulich > --- > Sadly so far we haven't had any feedback on this change from the people > who observed an issue ap

Re: [Xen-devel] [PATCH resend] domctl/x86: move vMSI related #define-s to public interface

2017-09-01 Thread Andrew Cooper
On 01/09/17 17:24, Jan Beulich wrote: > Xen and qemu having identical #define-s (with different names) is a > strong hint that these should be part of the public interface, at the > same time making obvious that any change to the values in an interface > modification (and hence needs suitable care)

  1   2   >