Re: [Xen-devel] [PATCH net-next 2/4] xen-netback: add control protocol implementation

2016-05-07 Thread David Miller
From: Paul Durrant Date: Thu, 5 May 2016 12:19:28 +0100 > +struct xenvif_hash_cache { > + rwlock_t lock; You really don't want to lock on every SKB hash computation like this, turn this into a spin lock for locking the write side and use RCU locking for lookup and usage. THanks. __

Re: [Xen-devel] [PATCH net-next v2 0/4] xen-netback: support for control ring

2016-05-12 Thread David Miller
From: Paul Durrant Date: Wed, 11 May 2016 16:16:26 +0100 > My recent patch to import an up-to-date include/xen/interface/io/netif.h > from the Xen Project brought in the necessary definitions to support the > new control shared ring and protocol. This patch series updates xen-netback > to support

Re: [Xen-devel] [PATCH net] xen-netback: fix extra_info handling in xenvif_tx_err()

2016-05-12 Thread David Miller
From: Paul Durrant Date: Thu, 12 May 2016 14:43:03 +0100 > Patch 562abd39 "xen-netback: support multiple extra info fragments > passed from frontend" contained a mistake which can result in an in- > correct number of responses being generated when handling errors > encountered when processing pac

Re: [Xen-devel] [PATCH net-next v4 0/4] xen-netback: support for control ring

2016-05-16 Thread David Miller
From: Paul Durrant Date: Fri, 13 May 2016 09:37:25 +0100 > My recent patch to import an up-to-date include/xen/interface/io/netif.h > from the Xen Project brought in the necessary definitions to support the > new control shared ring and protocol. This patch series updates xen-netback > to support

Re: [Xen-devel] [PATCH] xen-netfront: avoid crashing on resume after a failure in talk_to_netback()

2017-05-04 Thread David Miller
From: Vitaly Kuznetsov Date: Thu, 4 May 2017 14:23:04 +0200 > Unavoidable crashes in netfront_resume() and netback_changed() after a > previous fail in talk_to_netback() (e.g. when we fail to read MAC from > xenstore) were discovered. The failure path in talk_to_netback() does > unregister/free

Re: [Xen-devel] [PATCH v2] xen-netfront: avoid crashing on resume after a failure in talk_to_netback()

2017-05-11 Thread David Miller
by: Vitaly Kuznetsov > --- > Changes since v1: instead of cleaning drvdata and checking for it in > netfront_resume() and netback_changed() remove the device completely with > device_unregister() [David Miller] This looks a lot better, applied, thanks! _

Re: [Xen-devel] [PATCH 02/44] ibmveth: properly unwind on init errors

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:27 +0200 > That way the driver doesn't have to rely on DMA_ERROR_CODE, which > is not a public API and going away. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller ___ Xen-devel mai

Re: [Xen-devel] clean up and modularize arch dma_mapping interface

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:25 +0200 > for a while we have a generic implementation of the dma mapping routines > that call into per-arch or per-device operations. But right now there > still are various bits in the interfaces where don't clearly operate > on these ops.

Re: [Xen-devel] [PATCH 27/44] sparc: remove leon_dma_ops

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:52 +0200 > We can just use pci32_dma_ops. > > Btw, given that leon is 32-bit and appears to be PCI based, do even need > the special case for it in get_arch_dma_ops at all? I would need to defer to the LEON developers on that, but they haven'

Re: [Xen-devel] [PATCH 28/44] sparc: remove arch specific dma_supported implementations

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:53 +0200 > Usually dma_supported decisions are done by the dma_map_ops instance. > Switch sparc to that model by providing a ->dma_supported instance for > sbus that always returns false, and implementations tailored to the sun4u > and sun4v ca

Re: [Xen-devel] [PATCH 20/44] sparc: implement ->mapping_error

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:45 +0200 > DMA_ERROR_CODE is going to go away, so don't rely on it. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists

Re: [Xen-devel] [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

2017-10-16 Thread David Miller
From: Boris Ostrovsky Date: Mon, 16 Oct 2017 16:19:07 -0400 > On 10/16/2017 11:05 AM, Wei Liu wrote: >> On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote: >>> RFC791 specifies the minimum MTU to be 68, while xen-net{front|back} >>> drivers use a minimum value of 0. >>> >>> When set M

Re: [Xen-devel] [PATCH net] xen-netback: correctly schedule rate-limited queues

2017-07-27 Thread David Miller
From: Jean-Louis Dupond Date: Thu, 27 Jul 2017 10:21:56 +0200 > Op 2017-06-22 17:16, schreef David Miller: >> From: Wei Liu >> Date: Wed, 21 Jun 2017 10:21:22 +0100 >> >>> Add a flag to indicate if a queue is rate-limited. Test the flag in >>> NAPI poll h

Re: [Xen-devel] [PATCH net] xen-netback: correctly schedule rate-limited queues

2017-06-22 Thread David Miller
From: Wei Liu Date: Wed, 21 Jun 2017 10:21:22 +0100 > Add a flag to indicate if a queue is rate-limited. Test the flag in > NAPI poll handler and avoid rescheduling the queue if true, otherwise > we risk locking up the host. The rescheduling will be done in the > timer callback function. > > Rep

Re: [Xen-devel] [PATCH v2] xen-netback: fix error handling on netback_probe()

2016-09-17 Thread David Miller
From: Filipe Manco Date: Thu, 15 Sep 2016 17:10:46 +0200 > In case of error during netback_probe() (e.g. an entry missing on the > xenstore) netback_remove() is called on the new device, which will set > the device backend state to XenbusStateClosed by calling > set_backend_state(). However, the

Re: [Xen-devel] [PATCH net-next RESEND] xen-netfront: avoid packet loss when ethernet header crosses page boundary

2016-09-18 Thread David Miller
From: Vitaly Kuznetsov Date: Fri, 16 Sep 2016 12:59:14 +0200 > @@ -595,6 +596,19 @@ static int xennet_start_xmit(struct sk_buff *skb, struct > net_device *dev) > offset = offset_in_page(skb->data); > len = skb_headlen(skb); > > + /* The first req should be at least ETH_HLEN siz

Re: [Xen-devel] [PATCH net-next v3] xen-netfront: avoid packet loss when ethernet header crosses page boundary

2016-09-20 Thread David Miller
From: Vitaly Kuznetsov Date: Mon, 19 Sep 2016 12:53:40 +0200 > Small packet loss is reported on complex multi host network configurations > including tunnels, NAT, ... My investigation led me to the following check > in netback which drops packets: > > if (unlikely(txreq.size < ETH_HLEN)

Re: [Xen-devel] [PATCH resend 2] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread David Miller
From: Juergen Gross Date: Thu, 22 Sep 2016 11:06:25 +0200 > Instead of open coding it use the threaded irq mechanism in > xen-netback. > > Signed-off-by: Juergen Gross Applied to net-next, thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org h

Re: [Xen-devel] [PATCH] xen-netfront: Rework the fix for Rx stall during OOM and network stress

2017-02-09 Thread David Miller
From: Vineeth Remanan Pillai Date: Tue, 7 Feb 2017 18:59:01 + > The commit 90c311b0eeea ("xen-netfront: Fix Rx stall during network > stress and OOM") caused the refill timer to be triggerred almost on > all invocations of xennet_alloc_rx_buffers for certain workloads. > This reworks the fix

Re: [Xen-devel] [PATCH v3] xen-netfront: Improve error handling during initialization

2017-02-09 Thread David Miller
From: Ross Lagerwall Date: Wed, 8 Feb 2017 10:57:37 + > This fixes a crash when running out of grant refs when creating many > queues across many netdevs. > > * If creating queues fails (i.e. there are no grant refs available), > call xenbus_dev_fatal() to ensure that the xenbus device is se

Re: [Xen-devel] [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect_backend()

2017-02-10 Thread David Miller
From: Boris Ostrovsky Date: Thu, 9 Feb 2017 08:42:59 -0500 > Are you going to take this to your tree or would you rather it goes > via Xen tree? Ok, I just did. > And the same question for > > https://lists.xenproject.org/archives/html/xen-devel/2017-02/msg00625.html As I stated in the thread

Re: [Xen-devel] [PATCH v3] xen-netback: prefer xenbus_scanf() over xenbus_gather()

2016-11-09 Thread David Miller
From: "Jan Beulich" Date: Tue, 08 Nov 2016 00:45:53 -0700 > For single items being collected this should be preferred as being more > typesafe (as the compiler can check format string and to-be-written-to > variable match) and more efficient (requiring one less parameter to be > passed). > > Sig

Re: [Xen-devel] [Xen PATCH] xen-netback: fix error handling output

2016-11-09 Thread David Miller
From: Arnd Bergmann Date: Tue, 8 Nov 2016 14:34:34 +0100 > The connect function prints an unintialized error code after an > earlier initialization was removed: > > drivers/net/xen-netback/xenbus.c: In function 'connect': > drivers/net/xen-netback/xenbus.c:938:3: error: 'err' may be used > uni

Re: [Xen-devel] [PATCH net-next] xen-netback: create a debugfs node for hash information

2016-08-18 Thread David Miller
From: Paul Durrant Date: Wed, 17 Aug 2016 16:13:29 +0100 > It is useful to be able to see the hash configuration when running tests. > This patch adds a debugfs node for that purpose. > > Signed-off-by: Paul Durrant Applied. ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH -next] xen-netback: using kfree_rcu() to simplify the code

2016-08-23 Thread David Miller
From: Wei Yongjun Date: Mon, 22 Aug 2016 23:01:29 + > From: Wei Yongjun > > The callback function of call_rcu() just calls a kfree(), so we > can use kfree_rcu() instead of call_rcu() + callback function. > > Signed-off-by: Wei Yongjun Applied. __

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-18 Thread David Miller
From: Vineeth Remanan Pillai Date: Wed, 18 Jan 2017 09:02:17 -0800 > > On 01/15/2017 10:24 PM, Juergen Gross wrote: >> On 13/01/17 18:55, Remanan Pillai wrote: >>> From: Vineeth Remanan Pillai >>> >>> During an OOM scenario, request slots could not be created as skb >>> allocation fails. So the

Re: [Xen-devel] [PATCH v2] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-18 Thread David Miller
This v2 never made it into patchwork. I don't know why, so please resend it to netdev with the accumulated reviewed-by etc. tags added. Thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 0/2] xen-netback: fix memory leaks on XenBus disconnect

2017-01-18 Thread David Miller
From: Igor Druzhinin Date: Tue, 17 Jan 2017 20:49:36 + > Just split the initial patch in two as proposed by Wei. > > Since the approach for locking netdev statistics is inconsistent (tends not > to have any locking at all) accross the kernel we'd better to rely on our > internal lock for thi

Re: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread David Miller
From: Sowmini Varadhan Date: Thu, 19 Jan 2017 06:14:26 -0500 > I'll probably work on fixing packet_snd to return -EINVAL > or similar when the len is zero this week. I thought we had code which made sure that at least a minimal link layer header was present in the SKB? Specifically I'm talking

Re: [Xen-devel] xennet_start_xmit assumptions

2017-01-20 Thread David Miller
From: Sowmini Varadhan Date: Thu, 19 Jan 2017 17:41:23 -0500 > On (01/19/17 13:47), Sowmini Varadhan wrote: >> > Specifically I'm talking about the dev_validate_header() check. >> > That is supposed to protect us from these kinds of situations. >> >> ah, but I run my pf_packet application as roo

Re: [Xen-devel] [PATCH] xen-netfront: Improve error handling during initialization

2017-02-04 Thread David Miller
From: Ross Lagerwall Date: Wed, 1 Feb 2017 15:50:22 + > * Delay timer creation so that if initializing a queue fails, the timer > has not been setup yet. setup_timer() doesn't do anything that must be "undone" if an error occurs and we have to cleanup. It just assigns some values to some ti

Re: [Xen-devel] [PATCH] uapi: use wildcards to list files

2017-01-03 Thread David Miller
From: Nicolas Dichtel Date: Tue, 3 Jan 2017 15:35:44 +0100 > Regularly, when a new header is created in include/uapi/, the developer > forgets to add it in the corresponding Kbuild file. This error is usually > detected after the release is out. > > In fact, all headers under include/uapi/ shou

Re: [Xen-devel] [PATCH] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-12 Thread David Miller
From: Vineeth Remanan Pillai Date: Wed, 11 Jan 2017 23:17:17 + > @@ -1054,7 +1059,11 @@ static int xennet_poll(struct napi_struct *napi, int > budget) > napi_complete(napi); > > RING_FINAL_CHECK_FOR_RESPONSES(&queue->rx, more_to_do); > - if (more_to_

Re: [Xen-devel] [PATCH net-next 0/7] xen-netback: guest rx side refactor

2016-10-03 Thread David Miller
From: Paul Durrant Date: Mon, 3 Oct 2016 08:31:05 +0100 > This series refactors the guest rx side of xen-netback: > > - The code is moved into its own source module. > > - The prefix variant of GSO handling is retired (since it is no longer > in common use, and alternatives exist). > > - The

Re: [Xen-devel] [PATCH v2 net-next 0/7] xen-netback: guest rx side refactor

2016-10-06 Thread David Miller
From: Paul Durrant Date: Tue, 4 Oct 2016 10:29:11 +0100 > This series refactors the guest rx side of xen-netback: > > - The code is moved into its own source module. > > - The prefix variant of GSO handling is retired (since it is no longer > in common use, and alternatives exist). > > - The

Re: [Xen-devel] [PATCH net] xen-netback: make sure that hashes are not send to unaware frontends

2016-10-06 Thread David Miller
From: Paul Durrant Date: Thu, 6 Oct 2016 15:47:10 +0100 > In the case when a frontend only negotiates a single queue with xen- > netback it is possible for a skbuff with a s/w hash to result in a > hash extra_info segment being sent to the frontend even when no hash > algorithm has been configure

Re: [Xen-devel] [PATCH net-next] MAINTAINERS: add myself as a maintainer of xen-netback

2016-10-07 Thread David Miller
From: Paul Durrant Date: Fri, 7 Oct 2016 11:33:37 +0100 > Signed-off-by: Paul Durrant Applied. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH net] xen-netback: (re-)create a debugfs node for hash information

2016-10-13 Thread David Miller
From: Paul Durrant Date: Mon, 10 Oct 2016 09:30:53 +0100 > From: Paul Durrant > > It is useful to be able to see the hash configuration when running tests. > This patch adds a debugfs node for that purpose. > > The original version of this patch (commit c0c64c152389) was reverted due > to buil

Re: [Xen-devel] [PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

2016-10-13 Thread David Miller
From: David Vrabel Date: Tue, 11 Oct 2016 16:48:27 +0100 > If a VIF has been ready for rx_stall_timeout (60s by default) and an > Rx ring is drained of all requests an Rx stall will be incorrectly > detected. When this occurs and the guest Rx queue is empty, the Rx > ring's event index will not

Re: [Xen-devel] [PATCH] xen-netback: fix type mismatch warning

2016-10-13 Thread David Miller
From: Arnd Bergmann Date: Wed, 12 Oct 2016 16:54:01 +0200 > Wiht the latest rework of the xen-netback driver, we get a warning > on ARM about the types passed into min(): > > drivers/net/xen-netback/rx.c: In function 'xenvif_rx_next_chunk': > include/linux/kernel.h:739:16: error: comparison of d

Re: [Xen-devel] [PATCH/RFC 0/5] cpu_relax: introduce yield, remove lowlatency

2016-10-21 Thread David Miller
From: Christian Borntraeger Date: Fri, 21 Oct 2016 17:08:54 +0200 > On 10/21/2016 04:57 PM, David Miller wrote: >> From: Christian Borntraeger >> Date: Fri, 21 Oct 2016 13:58:53 +0200 >> >>> For spinning loops people did often use barrier() or cpu_relax(). >&g

Re: [Xen-devel] [PATCH 00/12] xen: add common function for reading optional value

2016-10-31 Thread David Miller
From: Juergen Gross Date: Mon, 31 Oct 2016 17:48:18 +0100 > There are multiple instances of code reading an optional unsigned > parameter from Xenstore via xenbus_scanf(). Instead of repeating the > same code over and over add a service function doing the job and > replace the call of xenbus_scan

Re: [Xen-devel] [PATCH 1/1] xen-netfront: do not cast grant table reference to signed short

2016-10-31 Thread David Miller
From: Dongli Zhang Date: Mon, 31 Oct 2016 13:38:29 +0800 > While grant reference is of type uint32_t, xen-netfront erroneously casts > it to signed short in BUG_ON(). > > This would lead to the xen domU panic during boot-up or migration when it > is attached with lots of paravirtual devices. >

Re: [Xen-devel] [PATCH 1/1] xen-netfront: do not cast grant table reference to signed short

2016-11-01 Thread David Miller
From: Dongli Zhang Date: Mon, 31 Oct 2016 21:46:09 -0700 (PDT) > David, I am very sorry for this error and I will be careful the next time. > Would you please let me know if I should resend a new patch or an incremental > based on previous one at > https://git.kernel.org/cgit/linux/kernel/git/da

Re: [Xen-devel] [PATCH 1/1] xen-netfront: cast grant table reference first to type int

2016-11-02 Thread David Miller
From: Dongli Zhang Date: Wed, 2 Nov 2016 09:04:33 +0800 > IS_ERR_VALUE() in commit 87557efc27f6a50140fb20df06a917f368ce3c66 > ("xen-netfront: do not cast grant table reference to signed short") would > not return true for error code unless we cast ref first to type int. > > Signed-off-by: Dongl

Re: [Xen-devel] [PATCH net] xen-netback: Use GFP_ATOMIC to allocate hash

2017-03-02 Thread David Miller
From: Anoob Soman Date: Thu, 2 Mar 2017 10:50:20 + > Allocation of new_hash, inside xenvif_new_hash(), always happen > in softirq context, so use GFP_ATOMIC instead of GFP_KERNEL for new > hash allocation. > > Signed-off-by: Anoob Soman Applied. ___

Re: [Xen-devel] [PATCH net 0/2] xen-netback: update memory leak fix to avoid BUG

2017-03-03 Thread David Miller
From: Paul Durrant Date: Thu, 2 Mar 2017 12:54:24 + > Commit 9a6cdf52b85e "xen-netback: fix memory leaks on XenBus disconnect" > added missing code to fix a memory leak by calling vfree() in the > appropriate place. > Unfortunately subsequent commit f16f1df65f1c "xen-netback: protect > resour

Re: [Xen-devel] [PATCH net v4] xen-netback: fix race condition on XenBus disconnect

2017-03-12 Thread David Miller
From: Igor Druzhinin Date: Fri, 10 Mar 2017 21:36:22 + > In some cases during XenBus disconnect event handling and subsequent > queue resource release there may be some TX handlers active on > other processors. Use RCU in order to synchronize with them. > > Signed-off-by: Igor Druzhinin Ap

Re: [Xen-devel] [PATCH v2 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-04 Thread David Miller
From: Julien Grall Date: Thu, 4 Jun 2015 13:45:00 +0100 > On 03/06/15 18:06, Joe Perches wrote: >> On Wed, 2015-06-03 at 17:55 +0100, Julien Grall wrote: >>> rx->status is an int16_t, print it using %d rather than %u in order to >>> have a meaningful value when the field is negative. >> [] >>> di

Re: [Xen-devel] [PATCH v3 1/2] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-07 Thread David Miller
From: Julien Grall Date: Thu, 4 Jun 2015 16:35:13 +0100 > rx->status is an int16_t, print it using %d rather than %u in order to > have a meaningful value when the field is negative. > > Also use %d rather than %x for rx->offset. > > Signed-off-by: Julien Grall > Reviewed-by: David Vrabel > C

Re: [Xen-devel] [PATCH v4 2/3] net/xen-netback: Remove unused code in xenvif_rx_action

2015-06-21 Thread David Miller
From: Julien Grall Date: Tue, 16 Jun 2015 20:10:47 +0100 > The variables old_req_cons and ring_slots_used are assigned but never > used since commit 1650d5455bd2dc6b5ee134bd6fc1a3236c266b5b "xen-netback: > always fully coalesce guest Rx packets". > > Signed-off-by: Julien Grall > Acked-by: Wei

Re: [Xen-devel] [PATCH v4 3/3] net/xen-netback: Don't mix hexa and decimal with 0x in the printf format

2015-06-21 Thread David Miller
From: Julien Grall Date: Tue, 16 Jun 2015 20:10:48 +0100 > Append 0x to all %x in order to avoid while reading when there is other > decimal value in the log. > > Also replace some of the hexadecimal print to decimal to uniformize the > format with netfront. > > Signed-off-by: Julien Grall Ap

Re: [Xen-devel] [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses

2015-06-21 Thread David Miller
From: Julien Grall Date: Tue, 16 Jun 2015 20:10:46 +0100 > rx->status is an int16_t, print it using %d rather than %u in order to > have a meaningful value when the field is negative. > > Also use %u rather than %x for rx->offset. > > Signed-off-by: Julien Grall > Reviewed-by: David Vrabel A

Re: [Xen-devel] [PATCH] xen-netback: fix a BUG() during initialization

2015-06-23 Thread David Miller
From: Imre Palik Date: Fri, 19 Jun 2015 14:21:51 +0200 > From: "Palik, Imre" > > Commit edafc132baac ("xen-netback: making the bandwidth limiter runtime > settable") > introduced the capability to change the bandwidth rate limit at runtime. > But it also introduced a possible crashing bug. >

Re: [Xen-devel] [PATCH net-next 0/3] xen-netback: fix multiple extra info handling

2016-03-13 Thread David Miller
From: Paul Durrant Date: Thu, 10 Mar 2016 12:30:25 + > If a frontend passes multiple extra info fragments to netback on the guest > transmit side, because xen-netback does not account for this properly, only > a single ack response will be sent. This will eventually cause processing > of the

Re: [Xen-devel] [PATCH net-next] xen-netback: correct length checks on hash copy_ops

2016-05-20 Thread David Miller
From: Paul Durrant Date: Wed, 18 May 2016 08:53:01 +0100 > The length checks on the grant table copy_ops for setting hash key and > hash mapping are checking the local 'len' value which is correct in > the case of the former but not the latter. This was picked up by > static analysis checks. > >

Re: [Xen-devel] [PATCH net-next] xen-netback: only deinitialized hash if it was initialized

2016-05-20 Thread David Miller
From: Paul Durrant Date: Wed, 18 May 2016 15:55:42 +0100 > A domain with a frontend that does not implement a control ring has been > seen to cause a crash during domain save. This was apparently because > the call to xenvif_deinit_hash() in xenvif_disconnect_ctrl() is made > regardless of whethe

Re: [Xen-devel] [PATCH] xen-netfront: Remove the meaningless code

2015-06-28 Thread David Miller
From: David Vrabel Date: Fri, 26 Jun 2015 16:15:18 +0100 > On 27/06/15 00:17, Liang Li wrote: >> The function netif_set_real_num_tx_queues() will return -EINVAL if >> the second parameter < 1, so call this function with the second >> parameter set to 0 is meaningless. > > Reviewed-by: David Vrab

Re: [Xen-devel] [PATCH] xen-netback: remove duplicated function definition

2015-07-03 Thread David Miller
From: Liang Li Date: Sat, 4 Jul 2015 03:33:00 +0800 > There are two duplicated xenvif_zerocopy_callback() definitions. > Remove one of them. > > Signed-off-by: Liang Li You really need to fix the date on your computer. If your date is in the future, as your's is, then your patch appears out-

Re: [Xen-devel] [RESEND] xen-netback: remove duplicated function definition

2015-07-08 Thread David Miller
From: Liang Li Date: Mon, 6 Jul 2015 08:42:56 +0800 > There are two duplicated xenvif_zerocopy_callback() definitions. > Remove one of them. > > Signed-off-by: Liang Li Applied, thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://list

Re: [Xen-devel] [PATCH] net:xen-netback - Change 1 to true for bool type variable.

2015-05-25 Thread David Miller
From: Shailendra Verma Date: Mon, 25 May 2015 23:19:31 +0530 > The variable separate_tx_rx_irq is bool type so assigning true > instead of 1. > > Signed-off-by: Shailendra Verma Applied. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://list

Re: [Xen-devel] [PATCH net v2] xen/netback: Properly initialize credit_bytes

2015-05-27 Thread David Miller
From: Ross Lagerwall Date: Wed, 27 May 2015 11:44:32 +0100 > Commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue > struct") introduced a regression when moving queue-specific data into > the queue struct by failing to set the credit_bytes field. This > prevented bandwidth lim

Re: [Xen-devel] [PATCHv1] xen-netfront: properly destroy queues when removing device

2015-05-27 Thread David Miller
From: David Vrabel Date: Wed, 27 May 2015 15:46:10 +0100 > xennet_remove() freed the queues before freeing the netdevice which > results in a use-after-free when free_netdev() tries to delete the > napi instances that have already been freed. > > Fix this by fully destroy the queues (which inclu

Re: [Xen-devel] [PATCH] xen: netback: fix error printf format string.

2015-05-31 Thread David Miller
From: Ian Campbell Date: Fri, 29 May 2015 17:22:04 +0100 > drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: > drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects > argument of type ‘long unsigned int’, but argument 5 has type ‘int’ > [-Wformat=] >

Re: [Xen-devel] [PATCH] xen-netfront: Use setup_timer

2015-05-31 Thread David Miller
From: Vaishali Thakkar Date: Mon, 1 Jun 2015 10:28:37 +0530 > Use the timer API function setup_timer instead of structure field > assignments to initialize a timer. > > A simplified version of the Coccinelle semantic patch that performs > this transformation is as follows: > > @change@ > expres

Re: [Xen-devel] [PATCH v2 net] xen: netback: read hotplug script once at start of day.

2015-06-01 Thread David Miller
From: Ian Campbell Date: Mon, 1 Jun 2015 11:30:24 +0100 > When we come to tear things down in netback_remove() and generate the > uevent it is possible that the xenstore directory has already been > removed (details below). > > In such cases netback_uevent() won't be able to read the hotplug > s

Re: [Xen-devel] [PATCH v2] xen: netback: fix printf format string warning

2015-06-01 Thread David Miller
From: Ian Campbell Date: Mon, 1 Jun 2015 11:30:04 +0100 > drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’: > drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects > argument of type ‘long unsigned int’, but argument 5 has type ‘int’ > [-Wformat=] >

Re: [Xen-devel] [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-06-01 Thread David Miller
icitly included > and that tends to hide places where vmalloc() et al are added to files > but the include of vmalloc.h is forgotten. > ... > Suggested-by: David Miller > Signed-off-by: Stephen Rothwell With the follow-on allnoconfig fixes: Acked-by: David S. Miller

Re: [Xen-devel] [PATCH net-next v3] xen-netback: implement dynamic multicast control

2016-02-07 Thread David Miller
From: Paul Durrant Date: Tue, 2 Feb 2016 11:55:05 + > My recent patch to the Xen Project documents a protocol for 'dynamic > multicast control' in netif.h. This extends the previous multicast control > protocol to not require a shared ring reconnection to turn the feature off. > Instead the b

Re: [Xen-devel] [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-12 Thread David Miller
From: Paul Durrant Date: Fri, 12 Feb 2016 10:13:17 + > This patch series adds support for frontend-configurable toeplitz hashing > in xen-netback (on the guest receive side). This support has been testing > against a Windows frontend and has proven to be sufficient to pass the > Microsoft HCK

Re: [Xen-devel] [PATCH net-next v1 0/8] xen-netback: support toeplitz hashing

2016-02-12 Thread David Miller
From: Paul Durrant Date: Fri, 12 Feb 2016 11:07:50 + > Windows *requires* use of Teoplitz so your position completely rules > out being able to support receive side scaling in Windows PV > frontends on Linux kernel backends, not only for Xen but for any > other hypervisor, which I think is to

Re: [Xen-devel] [PATCH] xen-netfront: set real_num_tx_queues to zreo avoid to trigger BUG_ON

2016-02-19 Thread David Miller
From: Gonglei Date: Sat, 20 Feb 2016 09:27:26 +0800 > It's possible for a race condition to exist between xennet_open() and > talk_to_netback(). After invoking netfront_probe() then other > threads or processes invoke xennet_open (such as NetworkManager) > immediately may trigger BUG_ON(). Beside

Re: [Xen-devel] [PATCH] MAINTAINERS: Drop myself as xen netback maintainer

2016-02-21 Thread David Miller
From: Ian Campbell Date: Fri, 19 Feb 2016 11:44:51 + > Wei has been picking this up for quite a while now. > > Signed-off-by: Ian Campbell Applied, thanks Ian. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 24/32] sparc: define __smp_xxx

2015-12-31 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 31 Dec 2015 21:08:53 +0200 > This defines __smp_xxx barriers for sparc, > for use by virtualization. > > smp_xxx barriers are removed as they are > defined correctly by asm-generic/barriers.h > > Signed-off-by: Michael S. Tsirkin > Acked-by: Arnd Bergmann

Re: [Xen-devel] [PATCH v2 07/32] sparc: reuse asm-generic/barrier.h

2015-12-31 Thread David Miller
From: "Michael S. Tsirkin" Date: Thu, 31 Dec 2015 21:06:38 +0200 > On sparc 64 bit dma_rmb, dma_wmb, smp_store_mb, smp_mb, smp_rmb, > smp_wmb, read_barrier_depends and smp_read_barrier_depends match the > asm-generic variants exactly. Drop the local definitions and pull in > asm-generic/barrier.h

Re: [Xen-devel] [PATCHv1 net] xen-netback: use skb to determine number of required guest Rx requests

2016-01-14 Thread David Miller
From: David Vrabel Date: Thu, 14 Jan 2016 15:18:30 + > - needed = xenvif_rx_ring_slots_needed(queue->vif); > + skb = skb_peek(&queue->rx_queue); > + if (!skb) > + return false; > + > + needed = DIV_ROUND_UP(skb->len, XEN_PAGE_SIZE); > + if (skb_is_gso(skb)) > +

Re: [Xen-devel] [PATCHv1 net] xen-netback: use skb to determine number of required guest Rx requests

2016-01-15 Thread David Miller
From: David Vrabel Date: Fri, 15 Jan 2016 10:31:57 + > On 14/01/16 21:54, David Miller wrote: >> From: David Vrabel >> Date: Thu, 14 Jan 2016 15:18:30 + >> >>> - needed = xenvif_rx_ring_slots_needed(queue->vif); >>> + skb = sk

Re: [Xen-devel] [PATCHv1 net] xen-netfront: request Tx response events more often

2016-01-15 Thread David Miller
From: David Vrabel Date: Fri, 15 Jan 2016 11:56:42 + > @@ -364,6 +364,7 @@ static void xennet_tx_buf_gc(struct netfront_queue *queue) > RING_IDX cons, prod; > unsigned short id; > struct sk_buff *skb; > + int more_to_do; I hate to be difficult, but could you please use

Re: [Xen-devel] [PATCHv2 0/3 net] xen-netback: use skb to determine number of required (etc.)

2016-01-15 Thread David Miller
From: David Vrabel Date: Fri, 15 Jan 2016 14:55:33 + > "xen-netback: use skb to determine number of required" plus two other > minor fixes I found down the back of the sofa. Series applied, thanks David. ___ Xen-devel mailing list Xen-devel@lists

Re: [Xen-devel] [PATCH 1/3] xen-netback: fix license ident used in MODULE_LICENSE

2016-01-22 Thread David Miller
From: One Thousand Gnomes Date: Fri, 22 Jan 2016 20:25:21 + >> The fact what include/linux/license.h:license_is_gpl_compatible includes >> "Dual MIT/GPL" as an option seems to suggest that it is enough of a thing >> to be validly used as the contents of a MODULE_LICENSE() thing. > > Yes. The

Re: [Xen-devel] stable backport of 3 xen multiqueue network dev fixes

2016-01-26 Thread David Miller
From: Ian Campbell Date: Thu, 21 Jan 2016 11:58:10 + > Please could you queue these three: > > 32a8440 xen-netfront: respect user provided max_queues > 4c82ac3 xen-netback: respect user provided max_queues > ca88ea1 xen-netfront: update num_queues to real created > > for stable backports to

Re: [Xen-devel] [PATCHv2 net] xen-netfront: request Tx response events more often

2016-01-28 Thread David Miller
From: David Vrabel Date: Tue, 26 Jan 2016 17:12:44 + > From: Malcolm Crossley > > Trying to batch Tx response events results in poor performance because > this delays freeing the transmitted skbs. > > Instead use the standard RING_FINAL_CHECK_FOR_RESPONSES() macro to be > notified once the

Re: [Xen-devel] [PATCHv1 net] xen-netback: notify immediately after pushing Tx response.

2015-03-11 Thread David Miller
From: David Vrabel Date: Wed, 11 Mar 2015 15:27:59 + > This fixes a performance regression introduced by > 7fbb9d8415d4a51cf542e87cf3a717a9f7e6aedc (xen-netback: release pending > index before pushing Tx responses) > > Moving the notify outside of the spin locks means it can be delayed a > l

Re: [Xen-devel] [PATCH v2] xen-netback: making the bandwidth limiter runtime settable

2015-03-20 Thread David Miller
From: Imre Palik Date: Thu, 19 Mar 2015 11:05:42 +0100 > From: "Palik, Imre" > > With the current netback, the bandwidth limiter's parameters are only > settable during vif setup time. This patch register a watch on them, and > thus makes them runtime changeable. > > When the watch fires, the

Re: [Xen-devel] [PATCH v2] xen-netfront: transmit fully GSO-sized packets

2015-04-02 Thread David Miller
From: Jonathan Davies Date: Tue, 31 Mar 2015 11:05:15 +0100 > xen-netfront limits transmitted skbs to be at most 44 segments in size. > However, > GSO permits up to 65536 bytes, which means a maximum of 45 segments of 1448 > bytes each. This slight reduction in the size of packets means a slight

Re: [Xen-devel] [PATCHv1 net] xen-netback: release pending index before pushing Tx responses

2015-02-24 Thread David Miller
From: David Vrabel Date: Tue, 24 Feb 2015 11:17:59 + > If the pending indexes are released /after/ pushing the Tx response > then a stale pending index may be used if a new Tx request is > immediately pushed by the frontend. The may cause various WARNINGs or > BUGs if the stale pending index

Re: [Xen-devel] [PATCH 1/1] xen-netback: remove compilation warning

2015-02-26 Thread David Miller
From: pedro Date: Thu, 26 Feb 2015 09:25:41 +0100 > From: pmarzo > > offset and size are of type uint16_t so the %lu gives a warning > A %u specifier, the same used in size makes gcc happy > Not sure if a %x would be more correct > > Signed-off-by: Pedro Marzo Perez This patch actually adds

Re: [Xen-devel] [PATCHv1 0/2 net] xen-netback: fix ethtool stats and memory

2015-03-03 Thread David Miller
From: David Vrabel Date: Tue, 3 Mar 2015 16:26:09 + > A couple of bug fixes for netback: > - make ethool stats to report the correct values. > - don't leak 1 MiB every time a VIF is destroyed. Please fix up the minor commit message issues in patch #2 and resubmit this series, thanks. __

Re: [Xen-devel] [PATCHv2 0/3 net] xen-netback: fix ethtool stats and memory leak

2015-03-05 Thread David Miller
From: David Vrabel Date: Wed, 4 Mar 2015 11:14:45 + > A couple of bug fixes for netback: > - make ethool stats to report the correct values. > - don't leak 1 MiB every time a VIF is destroyed. > > Changes in v2: > - Split 2nd patch into leak fix and refactor patches Series applied, thanks.

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

2015-09-09 Thread David Miller
From: David Vrabel Date: Tue, 8 Sep 2015 14:25:14 +0100 > Commit f48da8b14d04ca87ffcffe68829afd45f926ec6a (xen-netback: fix > unlimited guest Rx internal queue and carrier flapping) introduced a > regression. > > The PV frontend in IPXE only places 4 requests on the guest Rx ring. > Since netbac

Re: [Xen-devel] [PATCH net v2 0/2] xen-net{front, back}: respect user provided max_queues

2015-09-09 Thread David Miller
From: Wei Liu Date: Wed, 9 Sep 2015 11:23:04 +0100 > Wei Liu (2): > xen-netback: respect user provided max_queues > xen-netfront: respect user provided max_queues Both applied, thanks. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://list

Re: [Xen-devel] [PATCH net v2 0/2] xen-net{front, back}: respect user provided max_queues

2015-09-09 Thread David Miller
From: David Miller Date: Wed, 09 Sep 2015 21:53:22 -0700 (PDT) > From: Wei Liu > Date: Wed, 9 Sep 2015 11:23:04 +0100 > >> Wei Liu (2): >> xen-netback: respect user provided max_queues >> xen-netfront: respect user provided max_queues > > Both applie

Re: [Xen-devel] [PATCH net v3 0/2] xen-net{front, back}: respect user provided max_queues

2015-09-10 Thread David Miller
From: Wei Liu Date: Thu, 10 Sep 2015 11:18:56 +0100 > Wei Liu (2): > xen-netback: respect user provided max_queues > xen-netfront: respect user provided max_queues This looks better, series applied, thanks. ___ Xen-devel mailing list Xen-devel@lis

Re: [Xen-devel] [PATCHv1 net] xen-netback: require fewer guest Rx slots when not using GSO

2015-09-15 Thread David Miller
From: David Vrabel Date: Tue, 15 Sep 2015 11:30:17 +0100 > This is causing regressions with certain frontend drivers. Can you > drop it, please? All patches applied to my tree are part of the permanent record, and this one even made it's way to Linus already I think. So what you need to do is

Re: [Xen-devel] [PATCH net-next v2] xen-netfront: always set num queues if possible

2015-09-20 Thread David Miller
From: "Charles (Chas) Williams" <3ch...@gmail.com> Date: Wed, 16 Sep 2015 16:28:25 -0400 > If netfront connects with two (or more) queues and then reconnects with > only one queue it fails to delete or rewrite the multi-queue-num-queues > key and netback will try to use the wrong number of queues.

Re: [Xen-devel] [PATCH] xen-netback: Allocate fraglist early to avoid complex rollback

2015-08-03 Thread David Miller
From: Ross Lagerwall Date: Mon, 3 Aug 2015 15:38:03 +0100 > Determine if a fraglist is needed in the tx path, and allocate it if > necessary before setting up the copy and map operations. > Otherwise, undoing the copy and map operations is tricky. > > This fixes a use-after-free: if allocating t

Re: [Xen-devel] [PATCH v2] xen/netback: Wake dealloc thread after completing zerocopy work

2015-08-06 Thread David Miller
From: Ross Lagerwall Date: Tue, 4 Aug 2015 15:40:59 +0100 > Waking the dealloc thread before decrementing inflight_packets is racy > because it means the thread may go to sleep before inflight_packets is > decremented. If kthread_stop() has already been called, the dealloc > thread may wait forev

Re: [Xen-devel] [PATCH v2 net-next] xen-netback: add support for multicast control

2015-09-02 Thread David Miller
From: Paul Durrant Date: Wed, 2 Sep 2015 17:58:36 +0100 > Xen's PV network protocol includes messages to add/remove ethernet > multicast addresses to/from a filter list in the backend. This allows > the frontend to request the backend only forward multicast packets > which are of interest thus pr

Re: [Xen-devel] [PATCH] netback: don't store invalid vif pointer

2014-12-09 Thread David Miller
From: "Jan Beulich" Date: Tue, 09 Dec 2014 11:47:04 + > When xenvif_alloc() fails, it returns a non-NULL error indicator. To > avoid eventual races, we shouldn't store that into struct backend_info > as readers of it only check for NULL. > > Signed-off-by: Jan Beulich Applied, thanks. ___

Re: [Xen-devel] [PATCHv1 net] xen-netfront: use correct linear area after linearizing an skb

2014-12-09 Thread David Miller
From: David Vrabel Date: Tue, 9 Dec 2014 18:43:28 + > Commit 97a6d1bb2b658ac85ed88205ccd1ab809899884d (xen-netfront: Fix > handling packets on compound pages with skb_linearize) attempted to > fix a problem where an skb that would have required too many slots > would be dropped causing TCP co

  1   2   >