Re: [xml] [PATCH] Signed vs. unsigned comparison warnings in dict.c

2015-07-21 Thread Peter Kasting
On Tue, Jul 21, 2015 at 11:19 AM, Peter Kasting wrote: > The attached patch is one conservative way to fix this, which should be > correct in all cases on all platforms. > For some reason on the archives the patch downloads as a .bin file instead of a text file. While you can simply rename the

[xml] [PATCH] Signed vs. unsigned comparison warnings in dict.c

2015-07-21 Thread Peter Kasting
When compiled in MSVC, dict.c triggers warning C4018 for comparing signed and unsigned values in two places. In both cases, the code basically does: if (pool->end - pool->free > unsigned int) ... The type of the LHS here is ptrdiff_t, which is signed. When comparing signed to unsigned values, t