[OpenJDK 2D-Dev] [8] request for review: 8024511: Crash during color profile destruction
Hello, could you please review a fix for CR 8024511? Bug: http://bugs.sun.com/view_bug.do?bug_id=8024511 Webrev: http://cr.openjdk.java.net/~bae/8024511/webrev.00/ Starting fix for 7043064, we are using disposer to destroy a native part of a color profile. However an incorrect disposal method is registered in the disposer. It results in occasional crashed during profile destruction. Typically, the crash happens in cmsPipelineFree. Supplied regression test demonstrates the problem. Suggested fix is to register correct disposal method for profiles. Please take a look. Thanks, Andrew.
Re: [OpenJDK 2D-Dev] [8] request for review: 8024511: Crash during color profile destruction
Looks good. On 10.09.2013 14:16, Andrew Brygin wrote: Hello, could you please review a fix for CR 8024511? Bug: http://bugs.sun.com/view_bug.do?bug_id=8024511 Webrev: http://cr.openjdk.java.net/~bae/8024511/webrev.00/ Starting fix for 7043064, we are using disposer to destroy a native part of a color profile. However an incorrect disposal method is registered in the disposer. It results in occasional crashed during profile destruction. Typically, the crash happens in cmsPipelineFree. Supplied regression test demonstrates the problem. Suggested fix is to register correct disposal method for profiles. Please take a look. Thanks, Andrew.
Re: [OpenJDK 2D-Dev] [8] request for review: 8024511: Crash during color profile destruction
Oops. fix looks OK. -phil. On 9/10/2013 3:16 AM, Andrew Brygin wrote: Hello, could you please review a fix for CR 8024511? Bug: http://bugs.sun.com/view_bug.do?bug_id=8024511 Webrev: http://cr.openjdk.java.net/~bae/8024511/webrev.00/ Starting fix for 7043064, we are using disposer to destroy a native part of a color profile. However an incorrect disposal method is registered in the disposer. It results in occasional crashed during profile destruction. Typically, the crash happens in cmsPipelineFree. Supplied regression test demonstrates the problem. Suggested fix is to register correct disposal method for profiles. Please take a look. Thanks, Andrew.
