[OpenJDK 2D-Dev] EA8 build of Project Lanai (Java 2D Metal rendering pipeline for macOS) is now posted
The EA 8 build of Project Lanai [1] was posted today at https://jdk.java.net/lanai/ EA 8 Build 17-lanai+1-2 (2020/12/12) Please do give it a try (-Dsun.java2d.metal=true) and let us know of issues. One particular request : To anyone who has a mac still running 10.12 - we don't expect Metal to run (it requires at least 10.13 and maybe even later by the time it is final) but we would like confirmation that nothing in Metal prevents OpenGL running on older releases. Note there is currently a hotspot build bug unrelated to Lanai that prevents running on 10.10 and maybe 10.11 but 10.12 will be a useful data point. EA 8 contains the following new bug fixes relative to EA 7 8257886: Build issue in macOS 10.14 8256683: Lanai: NetBeans IDE - AA Text rendering appears brighter compared to OpenGL 8242925: J2DDemo - Anti-Aliasing with Metal differs from OGL 8257618: Lanai: GradientPaint interpolates over stops limits 8257566: Lanai: System runs out of application memory while running the Unmanaged_BufferredImage_draw_NearestNeighbor test multiple times 8257441: Lanai: java/awt/image/VolatileImage/DrawHugeImageTest fails 8257442: Lanai: Create RenderPerf tests for SW to HW blits 8257413: Lanai - Use optimum sized temporary buffer while replacing texture region 8238285: Lanai: java/awt/image/DrawImage tests fail 8256576: DrawImage/BlitRotateClippedArea fails -phil.
Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]
On Thu, 10 Dec 2020 23:07:52 GMT, Naoto Sato wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move to share/data, and move jdwp.spec to java.se > > Reviewed changes to `characterdata`, `charsetmapping`, `cldr`, `currency`, > `lsrdata`, `tzdata`, and `unicodedata` with minor comment. Looks good overall. >I also think that the person most qualified to judge about charsetmapping is >@naotoj, which has already accepted this review as it is. Although I am the current RE for the charsets component, I succeeded it from Alan/Sherman, so I would like to hear Alan's opinion on this. - PR: https://git.openjdk.java.net/jdk/pull/1611
Re: [OpenJDK 2D-Dev] RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop [v2]
On Tue, 15 Dec 2020 15:24:03 GMT, Andrey Turbanov wrote: >> There are few places in code where manual `while` loop is used with >> `Iterator` to iterate over `Collection`. >> Instead of manual `while` cycles it's preferred to use _enhanced-for_ cycle >> instead: it's less verbose, makes code easier to read and it's less >> error-prone. >> It doesn't have any performance impact: java compiler generates similar code >> when compiling _enhanced-for_ cycle. >> >> See similar cleanup in C++ code - #1707 > > Andrey Turbanov has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains one commit: > > 8258006: Replace 'while' cycles with iterator with enhanced 'for' in > java.desktop Ok. Approved. - Marked as reviewed by prr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/1574
Re: [OpenJDK 2D-Dev] RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop
On Wed, 16 Dec 2020 14:59:45 GMT, Andrey Turbanov wrote: >> These tests more or less *never* fail so how are you sure it is not your >> changes ? >> And 8 beans tests failed and you made 3 changes in beans code so I'd like to >> see some evidence >> to show these failures are unrelated and an explanation as to why these >> stable tests now fail ? >> I don't think they are problem listed. > > Oops. I also had changes from > https://bugs.openjdk.java.net/browse/JDK-4511638 in my working tree. > After I reverted them only 3 tests failed in `test-tier3`: > == > Test summary > == >TEST TOTAL PASS FAIL ERROR >>> jtreg:test/jdk:tier3 1192 1189 3 0 << >jtreg:test/langtools:tier30 0 0 0 >jtreg:test/jaxp:tier3 0 0 0 0 > == > TEST FAILURE > > JT Harness : Tests that failed > Tests are grouped by their final status message. > Execution failed: `main' threw exception: TestFailedException: TEST > FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: > activation failed; nested exception is: > java.rmi.activation.ActivationException: timeout creating child process > > > java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java: rmid > does not handle group restart for latecomer objects > > Execution failed: `main' threw exception: java.lang.Exception: failures: 1 > > sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies > SwingSet3 ColorChooserDemo by performing simple interaction with all the > controls that are shown in the ColorChooserDialog. > sanity/client/SwingSet/src/SwingSet2DemoTest.java: Verifies check box > menu item, radio button menu item, nested menus and themes using SwingSet2 > main window. > > Report generated on Dec 16, 2020 5:54:22 PM > Using JT Harness 6.0; built on November 30, 2020 at 12:00:00 AM MSK with > java version "1.8.0_172" I tried to run this 3 tests separately - all passed. Looks like inference from other tests in test suite. user@WORK-PC /cygdrive/f/Projects/official_openjdk $ make test TEST="jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java" Building target 'test' in configuration 'windows-x86_64-server-release' Running tests using JTREG control variable 'VM_OPTIONS=-Duser.language=en -Duser.country=US' Test selection 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java', will run: * jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java Running test 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java' Passed: sanity/client/SwingSet/src/SwingSet2DemoTest.java Test results: passed: 1 Report written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java\html\report.html Results written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java Finished running test 'jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java' Test report is stored in build/windows-x86_64-server-release/test-results/jtreg_test_jdk_sanity_client_SwingSet_src_SwingSet2DemoTest_java == Test summary == TEST TOTAL PASS FAIL ERROR jtreg:test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java 1 1 0 0 == TEST SUCCESS Finished building target 'test' in configuration 'windows-x86_64-server-release' user@WORK-PC /cygdrive/f/Projects/official_openjdk $ make test TEST="jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java" Building target 'test' in configuration 'windows-x86_64-server-release' Running tests using JTREG control variable 'VM_OPTIONS=-Duser.language=en -Duser.country=US' Test selection 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java', will run: * jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java Running test 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java' Passed: sanity/client/SwingSet/src/ColorChooserDemoTest.java Test results: passed: 1 Report written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-results\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java\html\report.html Results written to F:\Projects\official_openjdk\build\windows-x86_64-server-release\test-support\jtreg_test_jdk_sanity_client_SwingSet_src_ColorChooserDemoTest_java Finished running test 'jtreg:test/jdk/sanity/client/SwingSet/src/ColorChooserDemoTest.java' Test report is stored in build/win
Re: [OpenJDK 2D-Dev] RFR: 8258006: Replaces while cycles with iterator with enhanced for in java.desktop
On Tue, 15 Dec 2020 21:14:08 GMT, Phil Race wrote: >> I've run `test-tier3`. 15 tests failed. Looks like they are not related to >> my changes: >> >> JT Harness : Tests that failed >> Tests are grouped by their final status message. >> Execution failed: `main' threw exception: TestFailedException: TEST >> FAILED: ; nested exception is: TestFailedException: TEST FAILED: Rmid >> process exited with status 1 after 100ms. >> >> >> java/rmi/activation/ActivationSystem/modifyDescriptor/ModifyDescriptor.java: >> synopsis: need to modify registered ActivationDesc and ActivationGroupDesc >> >> Execution failed: `main' threw exception: TestFailedException: TEST >> FAILED: ; nested exception is: TestFailedException: TEST FAILED: Test1 >> failed: a service would not restart >> >> >> java/rmi/activation/Activatable/forceLogSnapshot/ForceLogSnapshot.java: >> synopsis: Activatable objects cannot be restarted. >> >> Execution failed: `main' threw exception: TestFailedException: TEST >> FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: >> activation failed; nested exception is: >> java.rmi.activation.ActivationException: timeout creating child process >> >> >> java/rmi/activation/Activatable/checkAnnotations/CheckAnnotations.java: rmid >> should annotate child process output >> java/rmi/activation/Activatable/inactiveGroup/InactiveGroup.java: >> synopsis: rmid should not destroy group when it reports inactiveGroup >> >> Execution failed: `main' threw exception: java.lang.Error: text should >> be 1.1 >> >> java/beans/PropertyEditor/TestDoubleClassValue.java: Tests >> PropertyEditor for value of type Double >> java/beans/PropertyEditor/TestDoubleTypeValue.java: Tests >> PropertyEditor for value of type double >> >> Execution failed: `main' threw exception: java.lang.Error: values are >> not equal >> >> java/beans/PropertyEditor/TestDoubleClassJava.java: Tests >> PropertyEditor for value of type Double >> java/beans/PropertyEditor/TestDoubleTypeJava.java: Tests >> PropertyEditor for value of type double >> >> Execution failed: `main' threw exception: java.lang.Exception: failures: >> 1 >> >> sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies >> SwingSet3 ColorChooserDemo by performing simple interaction with all the >> controls that are shown in the ColorChooserDialog. >> >> Execution failed: `main' threw exception: java.lang.StackOverflowError >> >> java/beans/XMLEncoder/Test6531597.java: Tests encoding of arrays of >> primitives >> java/beans/XMLEncoder/Test6989223.java: Tests Rectangle2D.Double >> encoding >> java/beans/XMLEncoder/java_awt_GridBagConstraints.java: Tests >> GridBagConstraints encoding >> java/beans/XMLEncoder/java_awt_LinearGradientPaint.java: Tests >> LinearGradientPaint encoding >> java/beans/XMLEncoder/java_awt_RadialGradientPaint.java: Tests >> RadialGradientPaint encoding >> java/beans/XMLEncoder/java_awt_geom_AffineTransform.java: Tests >> AffineTransform encoding > > These tests more or less *never* fail so how are you sure it is not your > changes ? > And 8 beans tests failed and you made 3 changes in beans code so I'd like to > see some evidence > to show these failures are unrelated and an explanation as to why these > stable tests now fail ? > I don't think they are problem listed. Oops. I also had changes from https://bugs.openjdk.java.net/browse/JDK-4511638 in my working tree. After I reverted them only 3 tests failed in `test-tier3`: JT Harness : Tests that failed Tests are grouped by their final status message. Execution failed: `main' threw exception: TestFailedException: TEST FAILED: ; nested exception is: java.rmi.activation.ActivateFailedException: activation failed; nested exception is: java.rmi.activation.ActivationException: timeout creating child process java/rmi/activation/Activatable/restartLatecomer/RestartLatecomer.java: rmid does not handle group restart for latecomer objects Execution failed: `main' threw exception: java.lang.Exception: failures: 1 sanity/client/SwingSet/src/ColorChooserDemoTest.java: Verifies SwingSet3 ColorChooserDemo by performing simple interaction with all the controls that are shown in the ColorChooserDialog. sanity/client/SwingSet/src/SwingSet2DemoTest.java: Verifies check box menu item, radio button menu item, nested menus and themes using SwingSet2 main window. Report generated on Dec 16, 2020 5:54:22 PM Using JT Harness 6.0; built on November 30, 2020 at 12:00:00 AM MSK with java version "1.8.0_172" - PR: https://git.openjdk.java.net/jdk/pull/1574
Re: [OpenJDK 2D-Dev] RFR: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image [v3]
On Tue, 15 Dec 2020 21:20:16 GMT, Bob Vandette wrote: >> Andrii Rodionov has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native >> Image > > I'm ok with these changes. They are no worse than the other STATIC_BUILD > changes that already exist in the JDK sources. @prrace I agree with you that our intrusion is a large maintenance overhead and that it can lead to potential errors. It is worth mentioning two things that could make you feel less scared: 1) Much of this is code temporary: the code is here until we find a proper way to integrate this information into the JDK itself, without incurring a noticeable maintenance overhead for the JDK maintainers. 2) We test all our code intensively with all the tests provided by the JDK assuring that on every release we pass the same tests that the JDK is passing. - PR: https://git.openjdk.java.net/jdk/pull/562
Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]
On Wed, 16 Dec 2020 10:12:54 GMT, Alan Bateman wrote: >> I think this is almost ready to be pushed, but I'd like to have someone from >> the client team review the changes for java.desktop as well. @prrace Any >> change you can have a look at this? > > I think it will be annoying to have the charset mapping tables and other data > in the src tree, have you looked at other alternatives? @AlanBateman Let me re-iterate: the data files are *not* "make" files. It is just as annoying to have team-specific data files in the make tree! So to keep things as they are is not an option. The fact that they currently reside there is just a continuation of the old view of make as a general dumping ground. I've requested this change since before Project Jigsaw. In fact, I opposed Erik's original Jigsaw patch on this ground, among other things. As a compromise, we agreed that it was to be fixed *after* Jigsaw, since that project had already dragged out in time for so long and was blocking the release. (See https://bugs.openjdk.java.net/browse/JDK-8055193 for details.) So what do you propose for alternative? A new top-level data directory? I mean, sure, we could have like `data/java.base/share/charsetmapping` instead. I personally think that makes less sense. I also think that the person most qualified to judge about charsetmapping is @naotoj, which has already accepted this review as it is. - PR: https://git.openjdk.java.net/jdk/pull/1611
Re: [OpenJDK 2D-Dev] RFR: 8257733: Move module-specific data from make to respective module [v2]
On Tue, 15 Dec 2020 22:52:30 GMT, Magnus Ihse Bursie wrote: >> Reviewed changes to `characterdata`, `charsetmapping`, `cldr`, `currency`, >> `lsrdata`, `tzdata`, and `unicodedata` with minor comment. Looks good >> overall. > > I think this is almost ready to be pushed, but I'd like to have someone from > the client team review the changes for java.desktop as well. @prrace Any > change you can have a look at this? I think it will be annoying to have the charset mapping tables and other data in the src tree, have you looked at other alternatives? - PR: https://git.openjdk.java.net/jdk/pull/1611
