[OpenJDK 2D-Dev] Integrated: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexander Zuev
On Wed, 14 Jul 2021 11:19:53 GMT, Alexander Zuev  wrote:

> Make fallback code for inaccessible file to return multiresolution icon
> Remove test from ProblemList

This pull request has now been integrated.

Changeset: a033866d
Author:Alexander Zuev 
URL:   
https://git.openjdk.java.net/jdk/commit/a033866d786507db69ab75643684e617fd1f4ba2
Stats: 11 lines in 2 files changed: 8 ins; 1 del; 2 mod

8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on 
windows

Reviewed-by: aivanov

-

PR: https://git.openjdk.java.net/jdk/pull/4777


Re: [OpenJDK 2D-Dev] RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexey Ivanov
On Wed, 14 Jul 2021 11:19:53 GMT, Alexander Zuev  wrote:

> Make fallback code for inaccessible file to return multiresolution icon
> Remove test from ProblemList

Marked as reviewed by aivanov (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/4777


Re: [OpenJDK 2D-Dev] RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexander Zuev
On Wed, 14 Jul 2021 11:56:15 GMT, Alexey Ivanov  wrote:

> So, essentially all the icons returned are MultiResolutionIcon even if 
> there's only one icon, right?

It was a multiresolution icon even with one icon inside but only when the 
native and requested icon resolutions do not match. Now it will always be MRI 
even if file is inaccessible and there is a default icon in System32.dll that 
matches the requested resolution.

-

PR: https://git.openjdk.java.net/jdk/pull/4777


Re: [OpenJDK 2D-Dev] RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexey Ivanov
On Wed, 14 Jul 2021 11:19:53 GMT, Alexander Zuev  wrote:

> Make fallback code for inaccessible file to return multiresolution icon
> Remove test from ProblemList

So, essentially all the icons returned are MultiResolutionIcon even if there's 
only one icon, right?

-

PR: https://git.openjdk.java.net/jdk/pull/4777


[OpenJDK 2D-Dev] RFR: 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails on windows

2021-07-14 Thread Alexander Zuev
Make fallback code for inaccessible file to return multiresolution icon
Remove test from ProblemList

-

Commit messages:
 - 8269637: javax/swing/JFileChooser/FileSystemView/SystemIconTest.java fails 
on windows

Changes: https://git.openjdk.java.net/jdk/pull/4777/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=4777=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8269637
  Stats: 11 lines in 2 files changed: 8 ins; 1 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4777.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4777/head:pull/4777

PR: https://git.openjdk.java.net/jdk/pull/4777