Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Looks fine. On 29/11/2018 01:29, Jayathirth D V wrote: Hi Sergey, Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.02/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 27, 2018 1:29 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond On 21/11/2018 23:00, Jayathirth D V wrote: I was following ZLib like content in the table, but as you mentioned we can keep at least text mentioning that we need to look up stuff related to TIFF Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. The text about zlib broke the table as well(looks like it was caused y JDK-8189702), please fix it as well. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Hi Sergey, Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.02/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 27, 2018 1:29 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond On 21/11/2018 23:00, Jayathirth D V wrote: > I was following ZLib like content in the table, but as you mentioned we can > keep at least text mentioning that we need to look up stuff related to TIFF > Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. The text about zlib broke the table as well(looks like it was caused y JDK-8189702), please fix it as well. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
On 21/11/2018 23:00, Jayathirth D V wrote: I was following ZLib like content in the table, but as you mentioned we can keep at least text mentioning that we need to look up stuff related to TIFF Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. The text about zlib broke the table as well(looks like it was caused y JDK-8189702), please fix it as well. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Hi Sergey, Please share your inputs. Thanks, Jay > On 22-Nov-2018, at 12:30 PM, Jayathirth D V wrote: > > Hi Sergey, > > Thanks for the review. > > I was following ZLib like content in the table, but as you mentioned we can > keep at least text mentioning that we need to look up stuff related to TIFF > Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. > > Please find updated webrev for review: > http://cr.openjdk.java.net/~jdv/8212875/webrev.01/ > > Thanks, > Jay > > -Original Message- > From: Sergey Bylokhov > Sent: Thursday, November 22, 2018 6:21 AM > To: Jayathirth D V; 2d-dev > Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for > tiff/TTN2.draft.txt do not respond > > Hi, Jay. > > In a few places you changed the tables which contains 3 columns, and you > actually drop the last column in the row. > > BTW why we cannot preserve some of the text like: > "TIFF Technical Note 2" > > On 16/11/2018 03:31, Jayathirth D V wrote: >> Hello All, >> >> Please review the following fix in JDK12: >> >> Bug : https://bugs.openjdk.java.net/browse/JDK-8212875 >> >> Webrev : http://cr.openjdk.java.net/~jdv/8212875/webrev.00/ >> >> TIFF Technical Note #2 link is broken at many places in our code. I tried >> finding replacement for broken link, unfortunately there are no reliable >> source. So I have removed broken links. >> >> Thanks, >> >> Jay >> > > > -- > Best regards, Sergey.
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Hi Sergey, Thanks for the review. I was following ZLib like content in the table, but as you mentioned we can keep at least text mentioning that we need to look up stuff related to TIFF Technical Note #2. Also I have refined comment in BaselineTIFFTagSet. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, November 22, 2018 6:21 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond Hi, Jay. In a few places you changed the tables which contains 3 columns, and you actually drop the last column in the row. BTW why we cannot preserve some of the text like: "TIFF Technical Note 2" On 16/11/2018 03:31, Jayathirth D V wrote: > Hello All, > > Please review the following fix in JDK12: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8212875 > > Webrev : http://cr.openjdk.java.net/~jdv/8212875/webrev.00/ > > TIFF Technical Note #2 link is broken at many places in our code. I tried > finding replacement for broken link, unfortunately there are no reliable > source. So I have removed broken links. > > Thanks, > > Jay > -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Hi, Jay. In a few places you changed the tables which contains 3 columns, and you actually drop the last column in the row. BTW why we cannot preserve some of the text like: "TIFF Technical Note 2" On 16/11/2018 03:31, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212875 Webrev : http://cr.openjdk.java.net/~jdv/8212875/webrev.00/ TIFF Technical Note #2 link is broken at many places in our code. I tried finding replacement for broken link, unfortunately there are no reliable source. So I have removed broken links. Thanks, Jay -- Best regards, Sergey.
[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond
Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212875 Webrev : http://cr.openjdk.java.net/~jdv/8212875/webrev.00/ TIFF Technical Note #2 link is broken at many places in our code. I tried finding replacement for broken link, unfortunately there are no reliable source. So I have removed broken links. Thanks, Jay
