Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v3]
On Sun, 7 Feb 2021 09:18:04 GMT, Prasanta Sadhukhan
wrote:
>> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
>> NullPointerException when passed a null object reference for a input
>> parameter but it's not specified in the spec.
>> Updated spec to illustrate this.
>
> Prasanta Sadhukhan has updated the pull request incrementally with three
> additional commits since the last revision:
>
> - Address review comments
> - Revert "Address review comments"
>
>This reverts commit 3fff74d7563a6141d67cb18fd7c3dda731a4c752.
> - Address review comments
Marked as reviewed by aivanov (Reviewer).
test/jdk/java/awt/BasicStroke/TestNullShape.java line 42:
> 40: } catch (NullPointerException ne) {
> 41: System.out.println("result (npe): true");
> 42: return;
Return is from catch is redundant now.
Suggestion:
-
PR: https://git.openjdk.java.net/jdk/pull/2377
Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v3]
On Sun, 7 Feb 2021 09:18:04 GMT, Prasanta Sadhukhan wrote: >> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws >> NullPointerException when passed a null object reference for a input >> parameter but it's not specified in the spec. >> Updated spec to illustrate this. > > Prasanta Sadhukhan has updated the pull request incrementally with three > additional commits since the last revision: > > - Address review comments > - Revert "Address review comments" > >This reverts commit 3fff74d7563a6141d67cb18fd7c3dda731a4c752. > - Address review comments Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2377
Re: [OpenJDK 2D-Dev] RFR: 6211257: BasicStroke.createStrokedShape(Shape): NPE is not specified [v3]
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws > NullPointerException when passed a null object reference for a input > parameter but it's not specified in the spec. > Updated spec to illustrate this. Prasanta Sadhukhan has updated the pull request incrementally with three additional commits since the last revision: - Address review comments - Revert "Address review comments" This reverts commit 3fff74d7563a6141d67cb18fd7c3dda731a4c752. - Address review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/2377/files - new: https://git.openjdk.java.net/jdk/pull/2377/files/f7d6e8fe..d65b8e0a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=2377=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2377=01-02 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/2377.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2377/head:pull/2377 PR: https://git.openjdk.java.net/jdk/pull/2377
