Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v6]
On Fri, 14 May 2021 13:30:13 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make getShell32Icon method return multi-resolition image in case of
>> requested icon size and actual icon size mismatch.
>
> src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java
> line 266:
>
>> 264: * {@code ShellFolder} class. Whenever possible, the icon
>> 265: * returned will be a multi-resolution icon image,
>> 266: * which will allow better support for High DPI environments
>
> I'm not sure but probably “…which allows better…” is more grammatical, as
> well as in the line above: “the icon returned is a multi-resolution”.
>
> Phil or Joe could correct this.
Agree.
-
PR: https://git.openjdk.java.net/jdk/pull/2875
Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v6]
On Tue, 11 May 2021 21:41:15 GMT, Alexander Zuev wrote:
>> Fix updated after first round of review.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Make getShell32Icon method return multi-resolition image in case of
> requested icon size and actual icon size mismatch.
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line
266:
> 264: * {@code ShellFolder} class. Whenever possible, the icon
> 265: * returned will be a multi-resolution icon image,
> 266: * which will allow better support for High DPI environments
I'm not sure but probably “…which allows better…” is more grammatical, as well
as in the line above: “the icon returned is a multi-resolution”.
Phil or Joe could correct this.
-
PR: https://git.openjdk.java.net/jdk/pull/2875
Re: [OpenJDK 2D-Dev] RFR: 8182043: Access to Windows Large Icons [v6]
> Fix updated after first round of review. Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision: Make getShell32Icon method return multi-resolition image in case of requested icon size and actual icon size mismatch. - Changes: - all: https://git.openjdk.java.net/jdk/pull/2875/files - new: https://git.openjdk.java.net/jdk/pull/2875/files/a481b29b..10bae9be Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=2875=05 - incr: https://webrevs.openjdk.java.net/?repo=jdk=2875=04-05 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/2875.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/2875/head:pull/2875 PR: https://git.openjdk.java.net/jdk/pull/2875
