Re: [OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-28 Thread Aleksey Shipilev 
On 7/27/20 6:53 PM, Philip Race wrote:
> OK .. although I hope to come back in JDK 16 and eliminate all disabled 
> warnings
> from the now much smaller libfontmanager :
> https://bugs.openjdk.java.net/browse/JDK-8074844

OK, pushed.

-- 
Thanks,
-Aleksey



signature.asc
Description: OpenPGP digital signature

Re: [OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-27 Thread Philip Race 
OK .. although I hope to come back in JDK 16 and eliminate all disabled 
warnings

from the now much smaller libfontmanager :
https://bugs.openjdk.java.net/browse/JDK-8074844

-phil.


On 7/27/20, 5:41 AM, Erik Joelsson wrote:

Looks good to me.

/Erik

On 2020-07-27 00:28, Aleksey Shipilev wrote:

Bug:
   https://bugs.openjdk.java.net/browse/JDK-8250605

I believe this happens because int-to-pointer-cast is now enabled for 
libfontmanager. Below is the
minimal fix, but I wonder if we should reinstate the disabled warning 
for clang (in the same manner)
and msvc (which warning code that one is?). Or we can wait for 
follow-up bug reports there...


Minimal fix:
   https://cr.openjdk.java.net/~shade/8250605/webrev.01/

Testing: Linux {x86_64, x86_32} builds; jdk-submit (running)

Re: [OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-27 Thread Erik Joelsson 

Looks good to me.

/Erik

On 2020-07-27 00:28, Aleksey Shipilev wrote:

Bug:
   https://bugs.openjdk.java.net/browse/JDK-8250605

I believe this happens because int-to-pointer-cast is now enabled for 
libfontmanager. Below is the
minimal fix, but I wonder if we should reinstate the disabled warning for clang 
(in the same manner)
and msvc (which warning code that one is?). Or we can wait for follow-up bug 
reports there...

Minimal fix:
   https://cr.openjdk.java.net/~shade/8250605/webrev.01/

Testing: Linux {x86_64, x86_32} builds; jdk-submit (running)

[OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-27 Thread Aleksey Shipilev 
Bug:
  https://bugs.openjdk.java.net/browse/JDK-8250605

I believe this happens because int-to-pointer-cast is now enabled for 
libfontmanager. Below is the
minimal fix, but I wonder if we should reinstate the disabled warning for clang 
(in the same manner)
and msvc (which warning code that one is?). Or we can wait for follow-up bug 
reports there...

Minimal fix:
  https://cr.openjdk.java.net/~shade/8250605/webrev.01/

Testing: Linux {x86_64, x86_32} builds; jdk-submit (running)

-- 
Thanks,
-Aleksey



signature.asc
Description: OpenPGP digital signature