Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java
+1 Regards Prasanta On 07-Dec-18 2:52 PM, Jayathirth D V wrote: Hi Alexey, Thanks for the review. I will add space before pushing the change. Regards, Jay -Original Message- From: Alexey Ivanov Sent: Thursday, December 06, 2018 12:45 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java Hi Jay, "modified UTF-8" had space before but it doesn't. Otherwise, looks good. Regards, Alexey On 05/12/2018 12:35, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 Webrev : http://cr.openjdk.java.net/~jdv/8214817/webrev.00/ Thanks, Jay
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java
Sure! +1 Regards, Alexey On 07/12/2018 09:22, Jayathirth D V wrote: Hi Alexey, Thanks for the review. I will add space before pushing the change. Regards, Jay -Original Message- From: Alexey Ivanov Sent: Thursday, December 06, 2018 12:45 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java Hi Jay, "modified UTF-8" had space before but it doesn't. Otherwise, looks good. Regards, Alexey On 05/12/2018 12:35, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 Webrev : http://cr.openjdk.java.net/~jdv/8214817/webrev.00/ Thanks, Jay
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java
Hi Alexey, Thanks for the review. I will add space before pushing the change. Regards, Jay -Original Message- From: Alexey Ivanov Sent: Thursday, December 06, 2018 12:45 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java Hi Jay, "modified UTF-8" had space before but it doesn't. Otherwise, looks good. Regards, Alexey On 05/12/2018 12:35, Jayathirth D V wrote: > > Hello All, > > Please review the following fix in JDK12: > > Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 > > Webrev : http://cr.openjdk.java.net/~jdv/8214817/webrev.00/ > > Thanks, > > Jay >
Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java
Hi Jay, “modified UTF-8” had space before but it doesn't. Otherwise, looks good. Regards, Alexey On 05/12/2018 12:35, Jayathirth D V wrote: Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 Webrev : http://cr.openjdk.java.net/~jdv/8214817/webrev.00/ Thanks, Jay