Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

[Phil Race]

Not that strange considering it was just pushed a few hours ago.
I'll have to merge these  before pushing my fix ..

-phil.

On 07/26/2016 08:10 AM, Prasanta Sadhukhan wrote:

Looks good.
But strangely, I do not see this function in this file when Phil sent 
for review for his disable warning fix ;-)


Regards
Prasanta
On 7/26/2016 8:20 PM, Vadim Pakhnushev wrote:

Hi all,

Please review the build failure fix for:
https://bugs.openjdk.java.net/browse/JDK-8162545

diff -r c0cf6ec85273 
src/java.desktop/share/native/libjavajpeg/imageioJPEG.c
--- a/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 
26 15:55:22 2016 +0300
+++ b/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 
26 17:49:12 2016 +0300

@@ -2634,7 +2634,7 @@
 RELEASE_ARRAYS(env, data, NULL);
 }

-static void freeArray(void** arr, jint size) {
+static void freeArray(UINT8** arr, jint size) {
 int i;
 if (arr != NULL) {
 for (i = 0; i < size; i++) {


Thanks,
Vadim

Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

[Vadim Pakhnushev]

I checked that this fix passes JPRT with Phil's fix as well.

Vadim

On 26.07.2016 18:10, Prasanta Sadhukhan wrote:

Looks good.
But strangely, I do not see this function in this file when Phil sent 
for review for his disable warning fix ;-)


Regards
Prasanta
On 7/26/2016 8:20 PM, Vadim Pakhnushev wrote:

Hi all,

Please review the build failure fix for:
https://bugs.openjdk.java.net/browse/JDK-8162545

diff -r c0cf6ec85273 
src/java.desktop/share/native/libjavajpeg/imageioJPEG.c
--- a/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 
26 15:55:22 2016 +0300
+++ b/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 
26 17:49:12 2016 +0300

@@ -2634,7 +2634,7 @@
 RELEASE_ARRAYS(env, data, NULL);
 }

-static void freeArray(void** arr, jint size) {
+static void freeArray(UINT8** arr, jint size) {
 int i;
 if (arr != NULL) {
 for (i = 0; i < size; i++) {


Thanks,
Vadim

Re: [OpenJDK 2D-Dev] RFR: 8162545: Mac build failure

[Prasanta Sadhukhan]

Looks good.
But strangely, I do not see this function in this file when Phil sent 
for review for his disable warning fix ;-)


Regards
Prasanta
On 7/26/2016 8:20 PM, Vadim Pakhnushev wrote:

Hi all,

Please review the build failure fix for:
https://bugs.openjdk.java.net/browse/JDK-8162545

diff -r c0cf6ec85273 
src/java.desktop/share/native/libjavajpeg/imageioJPEG.c
--- a/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 
26 15:55:22 2016 +0300
+++ b/src/java.desktop/share/native/libjavajpeg/imageioJPEG.c Tue Jul 
26 17:49:12 2016 +0300

@@ -2634,7 +2634,7 @@
 RELEASE_ARRAYS(env, data, NULL);
 }

-static void freeArray(void** arr, jint size) {
+static void freeArray(UINT8** arr, jint size) {
 int i;
 if (arr != NULL) {
 for (i = 0; i < size; i++) {


Thanks,
Vadim