Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux [v2]
On Wed, 9 Sep 2020 23:17:21 GMT, Sergey Bylokhov wrote: >> This the only test which was created to check different types of >> interpolation. >> It checks the rendering to the VolatileImage and uses BufferedImage as a >> gold image. >> But it does not take into account that rendering to the VolatileImage might >> be affected >> by the HiDPI support. >> >> Old review request: >> https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/010982.html > > Sergey Bylokhov has updated the pull request incrementally with one > additional commit since the last revision: > > @author tag is removed Marked as reviewed by kcr (no project role). - PR: https://git.openjdk.java.net/jdk/pull/86
Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux [v2]
> This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the VolatileImage might > be affected > by the HiDPI support. > > Old review request: > https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/010982.html Sergey Bylokhov has updated the pull request incrementally with one additional commit since the last revision: @author tag is removed - Changes: - all: https://git.openjdk.java.net/jdk/pull/86/files - new: https://git.openjdk.java.net/jdk/pull/86/files/2e6a0251..99235829 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=86=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=86=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/86.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/86/head:pull/86 PR: https://git.openjdk.java.net/jdk/pull/86
Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the VolatileImage might > be affected > by the HiDPI support. > > Old review request: > https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/010982.html Marked as reviewed by kcr (no project role). - PR: https://git.openjdk.java.net/jdk/pull/86
Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the VolatileImage might > be affected > by the HiDPI support. > > Old review request: > https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/010982.html Looks ok albeit with author change in the test. test/jdk/sun/java2d/pipe/InterpolationQualityTest.java line 31: > 29: * image via rendering hints for default, xrender and opengl pipelines. > 30: * > 31: * @author vadim.pakhnus...@oracle.com I think we are supposed to remove the author, if present historically, if we are making changes to any test. rest looks ok. - Marked as reviewed by psadhukhan (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/86
Re: [OpenJDK 2D-Dev] RFR: 8171303: sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
On Tue, 8 Sep 2020 21:54:43 GMT, Sergey Bylokhov wrote: > This the only test which was created to check different types of > interpolation. > It checks the rendering to the VolatileImage and uses BufferedImage as a gold > image. > But it does not take into account that rendering to the VolatileImage might > be affected > by the HiDPI support. > > Old review request: > https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/010982.html Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/86
Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
> On 02-Sep-2020, at 10:46 AM, Sergey Bylokhov > wrote: > > On 01.09.2020 03:42, Ajit Ghaisas wrote: >>> >>> In the HiDPI mode the VolatileImage internally have twice more pixels than >>> BufferedImage, so when we draw the data to >>> the VolatileImage and then scale it back to the size of the BufferedImage >>> for comparison, the test fails. >> This looks good. I checked with OGL and Metal (project Lanai) on macOS. >> One question is - do we need to support this test in HiDPI mode? > > The difference between HiDPI and non-HiDPI mode is that VolatileImage has > more > pixels and every draw operation use scaled blits. The test in question scales > the graphics ourselves. To eliminate the "sun.java2d.uiScale=1" we will need > to > apply the scale to the BufferedImage size, then we should skip the usage of > "getSnapshot", and then we will need to scale all rendering to the > BufferedImage(simulating the HiDPI in VolatileImage), but in the end, the same > scaled blit will be tested. OK. Thanks for the explanation. Test fix looks good. +1. (not a ‘R’ reviewer) Regards, Ajit > -- > Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
On 01.09.2020 03:42, Ajit Ghaisas wrote: In the HiDPI mode the VolatileImage internally have twice more pixels than BufferedImage, so when we draw the data to the VolatileImage and then scale it back to the size of the BufferedImage for comparison, the test fails. This looks good. I checked with OGL and Metal (project Lanai) on macOS. One question is - do we need to support this test in HiDPI mode? The difference between HiDPI and non-HiDPI mode is that VolatileImage has more pixels and every draw operation use scaled blits. The test in question scales the graphics ourselves. To eliminate the "sun.java2d.uiScale=1" we will need to apply the scale to the BufferedImage size, then we should skip the usage of "getSnapshot", and then we will need to scale all rendering to the BufferedImage(simulating the HiDPI in VolatileImage), but in the end, the same scaled blit will be tested. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
On 25.08.2020 14:59, Philip Race wrote: This is fine but 1) I like to see the bug under which you fixed it in the @bug list. It is not a product bug and the test isn't reworked, so it is not necessary to have this test fix in the list of bugs 2) I am not sure I see how all the various reasons for this test failing can be explained by this. In the HiDPI mode the VolatileImage internally have twice more pixels than BufferedImage, so when we draw the data to the VolatileImage and then scale it back to the size of the BufferedImage for comparison, the test fails. -phil. On 8/25/20, 1:37 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8171303 Fix: http://cr.openjdk.java.net/~serb/8171303/webrev.00 This the only test which was created to check different types of interpolation. It checks the rendering to the VolatileImage and uses BufferedImage as a gold image. But it does not take into account that rendering to the VolatileImage might be affected by the HiDPI support. -- Best regards, Sergey.
Re: [OpenJDK 2D-Dev] RFR: 8171303 sun/java2d/pipe/InterpolationQualityTest.java fails on Windows & Linux
This is fine but 1) I like to see the bug under which you fixed it in the @bug list. 2) I am not sure I see how all the various reasons for this test failing can be explained by this. -phil. On 8/25/20, 1:37 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk/client. Bug: https://bugs.openjdk.java.net/browse/JDK-8171303 Fix: http://cr.openjdk.java.net/~serb/8171303/webrev.00 This the only test which was created to check different types of interpolation. It checks the rendering to the VolatileImage and uses BufferedImage as a gold image. But it does not take into account that rendering to the VolatileImage might be affected by the HiDPI support.
