Re: [389-devel] Running lib389 tests

2014-01-24 Thread thierry bordaz

On 01/24/2014 04:18 PM, Roberto Polli wrote:

On Friday 24 January 2014 15:56:10 thierry bordaz wrote:

Do we really need to get rid of __main__ when using
nose/py.test ?

Obviously you can take it. I would just avoid noise in testing.

Moreover they could leave your environment dirty: eg. if a test fails it
doesn't run the teardown function.


I do not understand how you can test 'list' if you have not
'create' mapping_tree before.

I would have created the list_test requirements in the setup phase.
  (in the link below I created two different backends for two different test
cases)
https://github.com/ioggstream/dsadmin/blob/merge_lib389/tests/replica_test.py#L54


While I started with dependent tests on dsadmin, I spent some time to change
that approach because small changes caused whole testsuites to fail and it was
difficult to find where the error was (in the setup? in the test first code?
in the second test code? in the library code? )


Ok I agree


Peace,
R.



--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Running lib389 tests

2014-01-24 Thread Roberto Polli
On Friday 24 January 2014 15:56:10 thierry bordaz wrote:
> Do we really need to get rid of __main__ when using
> nose/py.test ?
Obviously you can take it. I would just avoid noise in testing.

Moreover they could leave your environment dirty: eg. if a test fails it 
doesn't run the teardown function.

> I do not understand how you can test 'list' if you have not
> 'create' mapping_tree before.
I would have created the list_test requirements in the setup phase.
 (in the link below I created two different backends for two different test 
cases) 
https://github.com/ioggstream/dsadmin/blob/merge_lib389/tests/replica_test.py#L54


While I started with dependent tests on dsadmin, I spent some time to change 
that approach because small changes caused whole testsuites to fail and it was 
difficult to find where the error was (in the setup? in the test first code? 
in the second test code? in the library code? )

Peace,
R.

-- 
Roberto Polli
Community Manager
Babel - a business unit of Par-Tec S.p.A. - http://www.babel.it 
T: +39.06.9826.9651 M: +39.340.652.2736 F: +39.06.9826.9680
P.zza S.Benedetto da Norcia, 33 - 00040 Pomezia (Roma)

CONFIDENZIALE: Questo messaggio ed i suoi allegati sono di carattere 
confidenziale per i destinatari in indirizzo.
E' vietato l'inoltro non autorizzato a destinatari diversi da quelli indicati 
nel messaggio originale.
Se ricevuto per errore, l'uso del contenuto e' proibito; si prega di 
comunicarlo al mittente e cancellarlo immediatamente.
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Running lib389 tests

2014-01-24 Thread thierry bordaz

On 01/24/2014 03:50 PM, Roberto Polli wrote:

Hi T,


On Thursday 23 January 2014 14:19:52 thierry bordaz wrote:

In a day to day work, I prefer to run an individual test under eclipse
so that I can isolate the tests.

I recommend you look at
http://port389.org/wiki/Upstream_test_framework#Deploy_389-ds_under_specific
_directory

done, I sent a mail about how "fixing" some scripts
Yes. My only concern is to keep the ability to run the test directly 
under python. Do we really need to get rid of __main__ when using 
nose/py.test ?

http://port389.org/wiki/Upstream_test_framework#Run_a_specific_test_under_ec
lipse

with some small changes I was able to run the test under both nose and
py.test. Using Eclipse + Nose you could even run single tests with a right-
click on the test name.


Great !



mappingTree_test.py,

the "list_test" depends on "create_test" and can't be executed standalone.
I would implement those tests separately. I would even simplify the tests, as
they are quite long and complex.


Ok, but I do not understand how you can test 'list' if you have not 
'create' mapping_tree before.



You may run dirsrv_test.py, backend_test.py,
replica_test.py and Suffix_test.py.

I'll check them



Currently the tests are run only under eclipse (or directly with python
but require to set PYTHONPATH).

ok

ticket fix have their own tests on top of lib389. Those tests are run
under jenkins/py.test

ok.

See the attached png for the eclipse settings...

Peace,
R.


--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] 389-ds-base: /bin/sh scripts should use "." instead of "source"

2014-01-24 Thread Roberto Polli
On Friday 24 January 2014 07:28:51 Rich Megginson wrote:
> https://fedorahosted.org/389/ticket/47511
sorry for the double posting :(  I just cloned the master repository and it's 
not fixed.

Peace,
R.


-- 
Roberto Polli
Community Manager
Babel - a business unit of Par-Tec S.p.A. - http://www.babel.it 
T: +39.06.9826.9651 M: +39.340.652.2736 F: +39.06.9826.9680
P.zza S.Benedetto da Norcia, 33 - 00040 Pomezia (Roma)

CONFIDENZIALE: Questo messaggio ed i suoi allegati sono di carattere 
confidenziale per i destinatari in indirizzo.
E' vietato l'inoltro non autorizzato a destinatari diversi da quelli indicati 
nel messaggio originale.
Se ricevuto per errore, l'uso del contenuto e' proibito; si prega di 
comunicarlo al mittente e cancellarlo immediatamente.
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] 389-ds-base: /bin/sh scripts should use "." instead of "source"

2014-01-24 Thread Roberto Polli
Hi @all,

iirc /bin/sh scripts should use "." instead of "source" (see 
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#dot
)

To use "source" you should change the interpreter to be "/bin/bash"

lib389@rpolli:~/workspaces/389-ds-base/ds/ldap/admin/src/scripts$ git diff .
diff --git a/ldap/admin/src/scripts/ldif2db.in 
b/ldap/admin/src/scripts/ldif2db.in
index ce15349..fb24863 100755
--- a/ldap/admin/src/scripts/ldif2db.in
+++ b/ldap/admin/src/scripts/ldif2db.in
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-source @datadir@/@package_name@/data/DSSharedLib
+. @datadir@/@package_name@/data/DSSharedLib
 
 libpath_add "@libdir@/@package_name@/"
 libpath_add "@nss_libdir@"

-- 
Roberto Polli
Community Manager
Babel - a business unit of Par-Tec S.p.A. - http://www.babel.it 
T: +39.06.9826.9651 M: +39.340.652.2736 F: +39.06.9826.9680
P.zza S.Benedetto da Norcia, 33 - 00040 Pomezia (Roma)

CONFIDENZIALE: Questo messaggio ed i suoi allegati sono di carattere 
confidenziale per i destinatari in indirizzo.
E' vietato l'inoltro non autorizzato a destinatari diversi da quelli indicati 
nel messaggio originale.
Se ricevuto per errore, l'uso del contenuto e' proibito; si prega di 
comunicarlo al mittente e cancellarlo immediatamente.
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel