[389-devel] Please Review: 50633 Cargo vendor support

2019-10-02 Thread William Brown
https://pagure.io/389-ds-base/pull-request/50633


--
Sincerely,

William
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


[389-devel] Re: Bundle/Vendor process for npm/js

2019-10-02 Thread Simon Pichugin
On Thu, Oct 03, 2019 at 08:21:35AM +1000, William Brown wrote:
> Yep, perfect! So I think that if I add the cargo vendor steps to step 1, and 
> then make the makefile use the "offline" mode for 2 it should be all good 
> then? Similar to npm for offline builds.
Sure, this should work if I understood you correctly.
I never worked with the cargo vendor so I am not sure how the exact
implementation details will look like... So we'll see in the PR :)

Sincerely,
Simon

> 
> Thanks! 
> 
> > 
> > Regards,
> > Simon
> > 
> >> 
> >> Thanks,
> >> 
> >> --
> >> Sincerely,
> >> 
> >> William
> >> ___
> >> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> >> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> >> Fedora Code of Conduct: 
> >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >> List Archives: 
> >> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> > Fedora Code of Conduct: 
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: 
> > https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
> 
> —
> Sincerely,
> 
> William Brown
> 
> Senior Software Engineer, 389 Directory Server
> SUSE Labs
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


[389-devel] Re: Bundle/Vendor process for npm/js

2019-10-02 Thread William Brown


> On 3 Oct 2019, at 07:34, Simon Pichugin  wrote:
> 
> On Wed, Oct 02, 2019 at 01:20:24PM +1000, William Brown wrote:
>> Hey there,
>> 
>> I'm looking at adding the steps for offline builds so that we can start to 
>> use rust. I know that you have some steps for preparing the tar for cockpit 
>> builds with npm/js deps. 
>> 
>> How are you doing this? I was hoping we could share some kind of prepare for 
>> offline or pre-build script or similar that could trigger the cargo 
>> vendoring process
> Hi William,
> so we have two stages here, right.
> 
> 1. To begin with, we install the latest NPM packages, build the cockpit and 
> pack it
> to the tarball. At that stage, you should have the internet for NPM access.
> https://pagure.io/389-ds-base/raw/master/f/rpm.mk
> tarballs or dist-bz2 (it is used for Koji builds)
> 
> 2. Then, we use the tarball to build RPM (or just to create SRPM). It is
> an offline part. Basically, we freeze the NPM versions and our WebUI
> state and use it for building purposes.
> During the 'make install', it copies the directory to Cockpit
> system dir.
> https://pagure.io/389-ds-base/blob/master/f/Makefile.am#_744
> 
> P.S. probably, you know, but just in case - 
> Fedora release process can be checked here:
> http://www.port389.org/docs/389ds/howto/howto-fedora-release-process.html
> 
> Is it what you want?

Yep, perfect! So I think that if I add the cargo vendor steps to step 1, and 
then make the makefile use the "offline" mode for 2 it should be all good then? 
Similar to npm for offline builds.

Thanks! 

> 
> Regards,
> Simon
> 
>> 
>> Thanks,
>> 
>> --
>> Sincerely,
>> 
>> William
>> ___
>> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
>> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
>> Fedora Code of Conduct: 
>> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives: 
>> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

—
Sincerely,

William Brown

Senior Software Engineer, 389 Directory Server
SUSE Labs
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


[389-devel] Re: Bundle/Vendor process for npm/js

2019-10-02 Thread Simon Pichugin
On Wed, Oct 02, 2019 at 01:20:24PM +1000, William Brown wrote:
> Hey there,
> 
> I'm looking at adding the steps for offline builds so that we can start to 
> use rust. I know that you have some steps for preparing the tar for cockpit 
> builds with npm/js deps. 
> 
> How are you doing this? I was hoping we could share some kind of prepare for 
> offline or pre-build script or similar that could trigger the cargo vendoring 
> process
Hi William,
so we have two stages here, right.

1. To begin with, we install the latest NPM packages, build the cockpit and 
pack it
to the tarball. At that stage, you should have the internet for NPM access.
https://pagure.io/389-ds-base/raw/master/f/rpm.mk
tarballs or dist-bz2 (it is used for Koji builds)

2. Then, we use the tarball to build RPM (or just to create SRPM). It is
an offline part. Basically, we freeze the NPM versions and our WebUI
state and use it for building purposes.
During the 'make install', it copies the directory to Cockpit
system dir.
https://pagure.io/389-ds-base/blob/master/f/Makefile.am#_744

P.S. probably, you know, but just in case - 
Fedora release process can be checked here:
http://www.port389.org/docs/389ds/howto/howto-fedora-release-process.html

Is it what you want?

Regards,
Simon

> 
> Thanks,
> 
> --
> Sincerely,
> 
> William
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org