[389-devel] Please Review: Issue 4623 - RFE - Monitor the current DB locks #4762

[Simon Pichugin]

Hi team,
I've made the requested changes and improved the tests.
The tests heavily depend on the environment's performance so I won't put
them to the PR CI (it's in tier2 now and it requires to run it with
DB_LOCKS_MONITORING_ACK env. variable)

Please, review:
https://github.com/389ds/389-ds-base/pull/4762

And the design doc review can be found here:
https://github.com/mreynolds389/389wiki/pull/56

Sincerely,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[389-devel] Re: failed to build rpms

[Simon Pichugin]

Hi team,
I've updated the contribution docs as I've tried to remove the confusion :)

https://github.com/mreynolds389/389wiki/pull/54/files
https://www.port389.org/docs/389ds/contributing.html
https://www.port389.org/docs/389ds/development/building.html

Hope that helps,
Simon

On Tue, Feb 23, 2021 at 7:42 PM Ludwig Krispenz 
wrote:

> Hi,
>
> since a long time I was trying to build rpms and failed, here are the
> issues I run into:
>
> 1] problem with npm/audit
>
> I followed the suggestions here:
> https://www.port389.org/docs/389ds/contributing.html (pushd/npm
> fix/popd), but this didn't help, only commenting out audit-ci in
> src/cockpit/389-console/node_modules.mk got me over this
>
> 2] rust
>
> 2.1]
>
> rpm build failed with:
>
> error: failed to get `concread` as a dependency of package `librslapd
> v0.1.0
>
> (/home/elkris/DEV/gh/two/389-ds-base/rpmbuild/BUILD/389-ds-base-2.0.3.20210223gitbda2c53d0/src/librslapd)`
>
> Caused by:
>failed to load source for dependency `concread`
>
> Caused by:
>Unable to update registry `
> https://github.com/rust-lang/crates.io-index`
> 
>
> Caused by:
>failed to update replaced source registry
> `https://github.com/rust-lang/crates.io-index`
> 
>
> Caused by:
>failed to read root of directory source:
>
> /home/elkris/DEV/gh/two/389-ds-base/rpmbuild/BUILD/389-ds-base-2.0.3.20210223gitbda2c53d0/vendor
>
> Caused by:
>No such file or directory (os error 2)
> make[1]: *** [Makefile:12715:
> .../rpmbuild/BUILD/389-ds-base-2.0.3.20210223gitbda2c53d0/rs/rslapd/release/librslapd.a]
>
> Error 101
>
>
> ,
>
> It was right that there wasno rs/rslapd/release/librslapd.a file, not
> even the directory rs existed. After configuring --enable-rust the
> directory was created and populated.
>
> Q1: why does it try to pack rust stuff if it is not enabled ?
>
> 2.2] Now the directory was there, but I still did get the same error. A
> closer look showed that it was looking for
> .../rpmbuild/BUILD/389-ds-base-2.0.3.20210223gitbda2c53d0/rs/rslapd/release/librslapd.a
>
> ,but what existed was
> .../rpmbuild/BUILD/389-ds-base-2.0.3.20210223gitbda2c53d0/rs/rslapd/debug/librslapd.a.
>
> Note "debug" -- "release". configure was run with --enable-debug
>
> Q2: Is there somewhere a hardcoded/default assumpion of "release" ? in
> the cargo spec?
>
> Thanks for any suggestions
>
>
> Regards,
>
> Ludwig
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
> Do not reply to spam on the list, report it:
> https://pagure.io/fedora-infrastructure
>
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[389-devel] Please Review: PR 4514 - Issue 4513 - Fix schema test and lib389 task module

[Simon Pichugin]

Hi Mark, team,
please check the PR for finalization:
https://github.com/389ds/389-ds-base/pull/4514

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: PRs #4321 and #4320

[Simon Pichugin]

Hi team,
please, check two PRs about cleaning up after the pagure to github
migration:

https://github.com/389ds/389-ds-base/pull/4321
https://github.com/389ds/389-ds-base/pull/4320

For the second PR, you can check how the README.md will look like here:
https://github.com/389ds/389-ds-base/blob/0a2ebda313d75bbd9f4e2a38c3255dcba5130860/README.md

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] 389-ds-base repository has migrated to GitHub

[Simon Pichugin]

Hi team,
so the migration to GitHub was successfully completed!

389 Directory Server repo is now available on:
https://github.com/389ds/389-ds-base


The issue tracker is here:
https://github.com/389ds/389-ds-base/issues

Pull-requests are accepted here:
https://github.com/389ds/389-ds-base/pulls

The old Pagure repo is now closed and read-only.
All Bugzillas are updated with the new links and Devel Whiteboard numbers.

Commit email notifications still go to:
389-comm...@lists.fedoraproject.org

If you have any questions, please let me know here or on IRC - #dirsec or
PM to spichugi.

I've sent 389ds organization invitations to all active developers.
Please, check your mailboxes.

Sincerely,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: 389-ds Migration to GitHub - [2020-09-12 - 2020-09-13]

[Simon Pichugin]

Hi team,
so everything is an order and ready.

Today at 3 pm EDT we disable Pagure notifications and I start the migration
process.

On Saturday, after I clone all of the issues and PRs and close Pagure
issues, I'll put 389-ds-base issue tracker on 'read-only' mode.
And during Saturday-Sunday I'll update all related Bugzillas with new Devel
Whiteboard issue numbers and links.

And finally, on Sunday, I'll recheck that everything is in order and I'll
open the new repo to the public (and I'll post the update in this mail
thread).

P.S. in case, you'll get some unwanted email notifications (you should
really not), I apologize for all inconvenience.

Sincerely,
Simon

On Wed, Sep 9, 2020 at 1:48 PM Simon Pichugin  wrote:

> Thanks!
>
> So, the final look is ready, please, check:
> https://github.com/droideck/389-ds-base
>
> The migration project that can be used by other teams:
> https://github.com/droideck/patogith
>
> Issues:
> https://github.com/droideck/389-ds-base/issues
>
> Pull requests can be found by filtering labels (I've created them as
> issues so we can store all of the valuable discussions that were held
> there):
> https://github.com/droideck/389-ds-base/issues?q=label%3APR+
>
> The pull requests that were open on the moment of migration (you can
> download the code from the last comment) are here:
> https://github.com/droideck/389-ds-base/issues?q=label%3AOpen+label%3APR
>
> Milestones:
> https://github.com/droideck/389-ds-base/milestones
>
> Tags and releases:
> https://github.com/droideck/389-ds-base/tags
> https://github.com/droideck/389-ds-base/releases
>
> The updated Bugzillas will look like this (I've changed Devel Whiteboard
> and added the link to Links table):
> https://partner-bugzilla.redhat.com/show_bug.cgi?id=1376823
>
> Pagure issues and PRs will be closed and each of them will have the
> message similar to this:
> https://pagure.io/SSSD/sssd/issue/36#comment-645569
> The code:
> https://github.com/droideck/patogith/blob/master/lib/patogith/pagure.py#L42
>
> So. please, check and we can move on this weekend if everything is good.
>
> Sincerely,
> Simon
>
> On Tue, Sep 8, 2020 at 8:21 PM Simon Pichugin  wrote:
>
>> Hi team,
>> for the last couple of weeks, I was working on the migration tool that
>> will allow us to switch 389-ds project to GitHub.
>>
>> It will be done through the weekend 2020-09-12 - 2020-09-13.
>>
>> I was testing it on a custom repo for some time but, please, review the
>> code, if you would like to:
>> https://github.com/droideck/patogith/
>>
>> I will open the example 389-ds-base [migrated] repo tomorrow when my
>> final run will finish.
>>
>> I've managed to disable Github notifications but there are two more
>> things that should be taken into the account:
>>
>> 1. Pagure notifications - as Viktor has suggested, probably, we can ask
>> Pierre-Yves Chibon  to do this for us at Friday.
>>
>> 2. Bugzilla notifications. It may be that it's not possible to disable it
>> for everyone involved. In that case, it will be one time thing that will
>> spam you with 3000 emails. :) But I hope not.
>>
>> Regards,
>> Simon
>>
>>
>>
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: 389-ds Migration to GitHub - [2020-09-12 - 2020-09-13]

[Simon Pichugin]

On Wed, Sep 9, 2020 at 1:39 AM William Brown  wrote:

> > I've managed to disable Github notifications but there are two more
> things that should be taken into the account:
> >
> > 1. Pagure notifications - as Viktor has suggested, probably, we can ask
> Pierre-Yves Chibon  to do this for us at Friday.
> >
> > 2. Bugzilla notifications. It may be that it's not possible to disable
> it for everyone involved. In that case, it will be one time thing that will
> spam you with 3000 emails. :) But I hope not.
>
> I love emails!
> In general though, great work here Simon. This is a really huge task, so
> thanks for undertaking it.

Thanks!

So, the final look is ready, please, check:
https://github.com/droideck/389-ds-base

The migration project that can be used by other teams:
https://github.com/droideck/patogith

Issues:
https://github.com/droideck/389-ds-base/issues

Pull requests can be found by filtering labels (I've created them as issues
so we can store all of the valuable discussions that were held there):
https://github.com/droideck/389-ds-base/issues?q=label%3APR+

The pull requests that were open on the moment of migration (you can
download the code from the last comment) are here:
https://github.com/droideck/389-ds-base/issues?q=label%3AOpen+label%3APR

Milestones:
https://github.com/droideck/389-ds-base/milestones

Tags and releases:
https://github.com/droideck/389-ds-base/tags
https://github.com/droideck/389-ds-base/releases

The updated Bugzillas will look like this (I've changed Devel Whiteboard
and added the link to Links table):
https://partner-bugzilla.redhat.com/show_bug.cgi?id=1376823

Pagure issues and PRs will be closed and each of them will have the message
similar to this:
https://pagure.io/SSSD/sssd/issue/36#comment-645569
The code:
https://github.com/droideck/patogith/blob/master/lib/patogith/pagure.py#L42

So. please, check and we can move on this weekend if everything is good.

Sincerely,
Simon

On Tue, Sep 8, 2020 at 8:21 PM Simon Pichugin  wrote:

> Hi team,
> for the last couple of weeks, I was working on the migration tool that
> will allow us to switch 389-ds project to GitHub.
>
> It will be done through the weekend 2020-09-12 - 2020-09-13.
>
> I was testing it on a custom repo for some time but, please, review the
> code, if you would like to:
> https://github.com/droideck/patogith/
>
> I will open the example 389-ds-base [migrated] repo tomorrow when my final
> run will finish.
>
> I've managed to disable Github notifications but there are two more things
> that should be taken into the account:
>
> 1. Pagure notifications - as Viktor has suggested, probably, we can ask
> Pierre-Yves Chibon  to do this for us at Friday.
>
> 2. Bugzilla notifications. It may be that it's not possible to disable it
> for everyone involved. In that case, it will be one time thing that will
> spam you with 3000 emails. :) But I hope not.
>
> Regards,
> Simon
>
>
>
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] 389-ds Migration to GitHub - [2020-09-12 - 2020-09-13]

[Simon Pichugin]

Hi team,
for the last couple of weeks, I was working on the migration tool that will
allow us to switch 389-ds project to GitHub.

It will be done through the weekend 2020-09-12 - 2020-09-13.

I was testing it on a custom repo for some time but, please, review the
code, if you would like to:
https://github.com/droideck/patogith/

I will open the example 389-ds-base [migrated] repo tomorrow when my final
run will finish.

I've managed to disable Github notifications but there are two more things
that should be taken into the account:

1. Pagure notifications - as Viktor has suggested, probably, we can ask
Pierre-Yves Chibon  to do this for us at Friday.

2. Bugzilla notifications. It may be that it's not possible to disable it
for everyone involved. In that case, it will be one time thing that will
spam you with 3000 emails. :) But I hope not.

Regards,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: PR #51075 - Issue 50610 - memory leak in dbscan and changelog encryption

[Simon Pichugin]

Hi team,
please, check my memory leaks fix:
https://pagure.io/389-ds-base/pull-request/51075

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: PRs - 50924, 50922, and 50918

[Simon Pichugin]

Hi team,
Please, review two small and one big PRs I have:
https://pagure.io/389-ds-base/pull-request/50924
https://pagure.io/389-ds-base/pull-request/50922
https://pagure.io/389-ds-base/pull-request/50918

Thanks!
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Please review: PR 50843 and PR 50837

[Simon Pichugin]

On Wed, Jan 22, 2020 at 03:46:49PM +0100, Simon Pichugin wrote:
> Hi team,
> please review these PRs:
> 
> https://pagure.io/389-ds-base/pull-request/50837

> https://pagure.io/389-ds-base/pull-request/50842
Wrong PR number.
The right one - https://pagure.io/389-ds-base/pull-request/50843

> 
> Thanks!
> Simon
> 




signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Bundle/Vendor process for npm/js

[Simon Pichugin]

On Thu, Oct 03, 2019 at 08:21:35AM +1000, William Brown wrote:
> Yep, perfect! So I think that if I add the cargo vendor steps to step 1, and 
> then make the makefile use the "offline" mode for 2 it should be all good 
> then? Similar to npm for offline builds.
Sure, this should work if I understood you correctly.
I never worked with the cargo vendor so I am not sure how the exact
implementation details will look like... So we'll see in the PR :)

Sincerely,
Simon

> 
> Thanks! 
> 
> > 
> > Regards,
> > Simon
> > 
> >> 
> >> Thanks,
> >> 
> >> --
> >> Sincerely,
> >> 
> >> William
> >> ___
> >> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> >> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> >> Fedora Code of Conduct: 
> >> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> >> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> >> List Archives: 
> >> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> > Fedora Code of Conduct: 
> > https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives: 
> > https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
> 
> —
> Sincerely,
> 
> William Brown
> 
> Senior Software Engineer, 389 Directory Server
> SUSE Labs
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Bundle/Vendor process for npm/js

[Simon Pichugin]

On Wed, Oct 02, 2019 at 01:20:24PM +1000, William Brown wrote:
> Hey there,
> 
> I'm looking at adding the steps for offline builds so that we can start to 
> use rust. I know that you have some steps for preparing the tar for cockpit 
> builds with npm/js deps. 
> 
> How are you doing this? I was hoping we could share some kind of prepare for 
> offline or pre-build script or similar that could trigger the cargo vendoring 
> process
Hi William,
so we have two stages here, right.

1. To begin with, we install the latest NPM packages, build the cockpit and 
pack it
to the tarball. At that stage, you should have the internet for NPM access.
https://pagure.io/389-ds-base/raw/master/f/rpm.mk
tarballs or dist-bz2 (it is used for Koji builds)

2. Then, we use the tarball to build RPM (or just to create SRPM). It is
an offline part. Basically, we freeze the NPM versions and our WebUI
state and use it for building purposes.
During the 'make install', it copies the directory to Cockpit
system dir.
https://pagure.io/389-ds-base/blob/master/f/Makefile.am#_744

P.S. probably, you know, but just in case - 
Fedora release process can be checked here:
http://www.port389.org/docs/389ds/howto/howto-fedora-release-process.html

Is it what you want?

Regards,
Simon

> 
> Thanks,
> 
> --
> Sincerely,
> 
> William
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: PRs 50551, 50570, 50573, 50579

[Simon Pichugin]

Hi team,
there are few PRs on review from me. Please, check...

https://pagure.io/389-ds-base/pull-request/50551
https://pagure.io/389-ds-base/pull-request/50570
https://pagure.io/389-ds-base/pull-request/50573
https://pagure.io/389-ds-base/pull-request/50579

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Good feedback

[Simon Pichugin]

On Tue, Aug 27, 2019 at 03:21:49PM +1000, William Brown wrote:
> Hi everyone,
> 
> Just thought I'd let you know that I received a few pieces of positive 
> feedback about dsconf recently to my private mail address. Great work to 
> everyone on the team for all your work to make lib389 and the new command 
> line tools a reality. People are really starting to notice, and you have all 
> done wonderful work to help bring this to life.
> 
> Thanks everyone!
Hi William,
It is very nice to hear!

And thanks to you too :)

Regards,
Simon

> 
> --
> Sincerely,
> 
> William
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: PR 50549 and PR 50551

[Simon Pichugin]

Hi team,
both of my PRs are ready for review.
Please, check it.
https://pagure.io/389-ds-base/pull-request/50549
https://pagure.io/389-ds-base/pull-request/50551

Thanks!
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 50206 - Account IDM CLI - WIP

[Simon Pichugin]

On Fri, Aug 16, 2019 at 11:56:43AM +1000, William Brown wrote:
> Sure thing, I'll look soon :) 
Great, thanks!

Forgot to put the link:
https://pagure.io/389-ds-base/pull-request/50549

> 
> > On 16 Aug 2019, at 11:55, Simon Pichugin  wrote:
> > 
> > Hi team,
> > I have a big chunk of work ready for review.
> > The main part is done and I just need to polish it a bit more and add
> > more tests.
> > 
> > In a mean while...
> > 
> > William, could you please take a look?
> > The lib389 part for Accounts is much bigger now and has much more to
> > offer.
> > 
> > Thanks,
> > Simon
> 
> —
> Sincerely,
> 
> William Brown
> 
> Senior Software Engineer, 389 Directory Server
> SUSE Labs
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: 
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: Issue 50206 - Account IDM CLI - WIP

[Simon Pichugin]

Hi team,
I have a big chunk of work ready for review.
The main part is done and I just need to polish it a bit more and add
more tests.

In a mean while...

William, could you please take a look?
The lib389 part for Accounts is much bigger now and has much more to
offer.

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Please review

[Simon Pichugin]

On Mon, Jul 15, 2019 at 05:30:24PM +0530, Anuj Borah wrote:
>[1]@Simon Pichugin
Sure, I'll get to it soon.
I just got back from a long PTO.

But also, I am not the only team member with review rights :)
So I am not sure why you quote me personally...

Thanks,
Simon

> 
>Please review:
>[2]https://pagure.io/389-ds-base/pull-request/50468
>[3]https://pagure.io/389-ds-base/pull-request/50471
>[4]https://pagure.io/389-ds-base/pull-request/50482
>Regards
>AB
>A
> 
>On Tue, May 21, 2019 at 4:17 PM Anuj Borah <[5]abo...@redhat.com>
>wrote:
> 
>[6]@Simon Pichugin
> 
>Please review:
>[7]https://pagure.io/389-ds-base/pull-request/50336
>Regards
>Anuj Borah
> 
>On Wed, May 15, 2019 at 8:50 PM Anuj Borah <[8]abo...@redhat.com>
>wrote:
> 
>[9]@Simon Pichugin
> 
>Please review:
>[10]https://pagure.io/389-ds-base/pull-request/50328
>Regards
>Anuj Borah
> 
>On Thu, May 9, 2019 at 5:27 PM Anuj Borah <[11]abo...@redhat.com>
>wrote:
> 
>[12]@Simon Pichugin
> 
>This one is still pending .
>[13]https://pagure.io/389-ds-base/pull-request/50192
>Regards
>Anuj Borah
> 
>On Tue, Apr 30, 2019 at 4:03 PM Anuj Borah <[14]abo...@redhat.com>
>wrote:
> 
>Hi Simon ,
>Rebsed onto master .
>Regards
>Anuj Borah
> 
>On Tue, Apr 30, 2019 at 3:54 PM Simon Pichugin
><[15]spich...@redhat.com> wrote:
> 
>  On Tue, Apr 30, 2019 at 02:15:55PM +0530, Anuj Borah wrote:
>  >Hi all,
>  Hi Anuj,
>  >Please review these PRs.
>  >Pending from Long Time.
>  >[1][16]https://pagure.io/389-ds-base/pull-request/50180
>  >[2][17]https://pagure.io/389-ds-base/pull-request/50192
>  Could you please rebase them onto master?
>  Thanks,
>  Simon
>  >Regards
>  >Anuj Borah
>  >
>  > References
>  >
>  >1. [18]https://pagure.io/389-ds-base/pull-request/50180
>  >2. [19]https://pagure.io/389-ds-base/pull-request/50192
>  > ___
>  > 389-devel mailing list -- [20]389-devel@lists.fedoraproject.org
>  > To unsubscribe send an email to
>  [21]389-devel-le...@lists.fedoraproject.org
>  > Fedora Code of Conduct:
>  [22]https://getfedora.org/code-of-conduct.html
>  > List Guidelines:
>  [23]https://fedoraproject.org/wiki/Mailing_list_guidelines
>  > List Archives:
>  [24]https://lists.fedoraproject.org/archives/list/389-de...@lists.fe
>  doraproject.org
>  ___
>  389-devel mailing list -- [25]389-devel@lists.fedoraproject.org
>  To unsubscribe send an email to
>  [26]389-devel-le...@lists.fedoraproject.org
>  Fedora Code of Conduct:
>  [27]https://getfedora.org/code-of-conduct.html
>  List Guidelines:
>  [28]https://fedoraproject.org/wiki/Mailing_list_guidelines
>  List Archives:
>  [29]https://lists.fedoraproject.org/archives/list/389-de...@lists.fe
>  doraproject.org
> 
> References
> 
>1. mailto:spich...@redhat.com
>2. https://pagure.io/389-ds-base/pull-request/50468
>3. https://pagure.io/389-ds-base/pull-request/50471
>4. https://pagure.io/389-ds-base/pull-request/50482
>5. mailto:abo...@redhat.com
>6. mailto:spich...@redhat.com
>7. https://pagure.io/389-ds-base/pull-request/50336
>8. mailto:abo...@redhat.com
>9. mailto:spich...@redhat.com
>   10. https://pagure.io/389-ds-base/pull-request/50328
>   11. mailto:abo...@redhat.com
>   12. mailto:spich...@redhat.com
>   13. https://pagure.io/389-ds-base/pull-request/50192
>   14. mailto:abo...@redhat.com
>   15. mailto:spich...@redhat.com
>   16. https://pagure.io/389-ds-base/pull-request/50180
>   17. https://pagure.io/389-ds-base/pull-request/50192
>   18. https://pagure.io/389-ds-base/pull-request/50180
>   19. https://pagure.io/389-ds-base/pull-request/50192
>   20. mailto:389-devel@lists.fedoraproject.org
>   21. mailto:389-devel-le...@lists.fedoraproject.org
>   22. https://getfedora.org/code-of-conduct.html
>   23. https://fedoraproject.org/wiki/Mailing_list_guidelines
>   24. 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
>   25. mailto:389-devel@lists.fedoraproject.org
>   26. mailto:389-devel-le...@lists.fedoraproject.org
>   27. https://getfedora.org/code-of-conduct.html
>   28. https://fedoraproject.org/wiki/Mailing_list_guidelines
>   29. 
> https://lists.fedoraproject

[389-devel] Porting Perl scripts

[Simon Pichugin]

Hi team,
I am working on porting our admin Perl scripts to Python CLI.
Please, check the list and share your opinion:

- cl-dump.pl - dumps and decodes changelog. Is it used often (if at all)?
https://access.redhat.com/documentation/en-us/red_hat_directory_server/10/html-single/configuration_command_and_file_reference/index#cl_dump.pl_Dump_and_decode_changelog

- logconv.pl - parse and analise the access logs. Pretty big one, is it 
priority? How much people use it?
  issue is created - https://pagure.io/389-ds-base/issue/50283
https://access.redhat.com/documentation/en-us/red_hat_directory_server/10/html-single/configuration_command_and_file_reference/index#logconv_pl

- migrate.pl - which migration scenarios do we plan to support?
  Do we depricate old ones? Do we need the script?
https://access.redhat.com/documentation/en-us/red_hat_directory_server/10/html-single/configuration_command_and_file_reference/index#migrate-ds.pl

- ns_accountstatus.pl, ns_inactivate.pl, ns_activate.pl - the issue is
  discussed here - https://pagure.io/389-ds-base/issue/50206
  I think we should extend status at least. Also, William put there some
  of his thoughts. What do you think, guys? Will we refactor
  (kinda depricate) some "account lock" as William proposing?
https://access.redhat.com/documentation/en-us/red_hat_directory_server/10/html-single/configuration_command_and_file_reference/index#ldif2db.pl_Import-ns_accountstatus.pl_Establish_account_status

- syntax-validate.pl - it probably will go to 'healthcheck' tool
  issue is created - https://pagure.io/389-ds-base/issue/50173
https://access.redhat.com/documentation/en-us/red_hat_directory_server/10/html-single/configuration_command_and_file_reference/index#syntax-validate.pl

- repl_monitor.pl - should we make it a part of 'healthcheck' too?
https://access.redhat.com/documentation/en-us/red_hat_directory_server/10/html-single/configuration_command_and_file_reference/index#repl_monitor.pl_Monitor_replication_status

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Issue with building RPMs with ASAN_ON

[Simon Pichugin]

On Wed, Jun 19, 2019 at 09:20:26AM +0200, William Brown wrote:
> 
> 
> > On 18 Jun 2019, at 17:45, Viktor Ashirov  wrote:
> > 
> > 
> > 
> > On Tue, Jun 18, 2019 at 7:54 AM Viktor Ashirov  wrote:
> > On Tue, Jun 18, 2019 at 1:30 AM Simon Pichugin  wrote:
> > >
> > > Hi team,
> > > I'm in the process of creating a Vagrant file which is close to the 
> > > customer's ENV.
> > > It is heavilly based on Viktor's beaker task.
> > > I use it for building and testing my code. And it is pretty important to 
> > > build with ASAN.
> > >
> > > Currently, what I do is:
> > > 1. Set 'ASAN_ON = 1' in rpm.mk
> > > 2. Run `make -f rpm.mk srpms` target
> > > 3. Build the RPM using `mock -q my_generated.srpm`
> > > 4. Install it
> > >
> > > Then I've tried running `dscreate` manually or running tests with py.test.
> > > Every time I have the same error here: 
> > > /run/dirsrv/ns-slapd-standalone1.asan.X
> > >
> > > ==22487==LeakSanitizer has encountered a fatal error.
> > > ==22487==HINT: For debugging, try setting environment variable 
> > > LSAN_OPTIONS=verbosity=1:log_threads=1
> > > ==22487==HINT: LeakSanitizer does not work under ptrace (strace, gdb, 
> > > etc)
> > Ludwig also recently had this issue. Looks like you're hitting this
> > bug: https://github.com/google/sanitizers/issues/723
> > We're using posix_memalign() in a few places and LeakSanitizier can't 
> > handle it.
> > So, the issue Simon was seeing is not related to the issue above. 
> > Turns out, it's just SELinux :)
Thanks, Viktor, once again!

> > 
> > 
> > 
> >  
> > time->Tue Jun 18 11:27:24 2019  
> > 
> >  
> > type=AVC msg=audit(1560871644.883:596): avc:  denied  { ptrace } for  
> > pid=3632 comm="ns-slapd" scontext=system_u:system_r:dirsrv_t:s0 
> > tcontext=system_u:system_r:dirsrv_t:s0 
> > tclass=process permissive=0 
> >   
> > [root@server ds]# ausearch -m AVC  | audit2allow
> > 
> >  
> > 
> > 
> >  
> > 
> > 
> >  
> > #= dirsrv_t ==  
> > 
> >  
> > allow dirsrv_t self:process ptrace;
> 
> Heh, selinux strikes again!
> 
> Were you running as a user, not as root? 
> 
Nope. I was running as root.

Regards,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Issue with building RPMs with ASAN_ON

[Simon Pichugin]

Hi team,
I'm in the process of creating a Vagrant file which is close to the customer's 
ENV.
It is heavilly based on Viktor's beaker task.
I use it for building and testing my code. And it is pretty important to build 
with ASAN.

Currently, what I do is:
1. Set 'ASAN_ON = 1' in rpm.mk
2. Run `make -f rpm.mk srpms` target
3. Build the RPM using `mock -q my_generated.srpm`
4. Install it

Then I've tried running `dscreate` manually or running tests with py.test.
Every time I have the same error here: 
/run/dirsrv/ns-slapd-standalone1.asan.X

==22487==LeakSanitizer has encountered a fatal error.
==22487==HINT: For debugging, try setting environment variable 
LSAN_OPTIONS=verbosity=1:log_threads=1
==22487==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc)

I've tried setting `export LSAN_OPTIONS=verbosity=1:log_threads=1` and run once 
again.
Same issue.

Did anybody encountered the issue? Maybe, Viktor or William, could you please 
check?
I'm putting the Vagrantfile to the attachments so you can reproduce.
Just run: `ASAN=on vagrant up` from the directory with Vagrantfile.

William, I think, libvirt is present on SUSE so you should have no issues with 
this too...

Thanks,
Simon
# -*- mode: ruby -*-
# vi: set ft=ruby :

$script = 

[389-devel] Please review: PR 50440 - Truncate the message when buffer capacity is exceeded

[Simon Pichugin]

Hi team,
please, review my recent PR:
https://pagure.io/389-ds-base/pull-request/50440

I've added CI test and I've done stress testing to see if performans is
affected (the details are inside)

Thanks,
Simon



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: On the command line tools ....

[Simon Pichugin]

On Fri, May 24, 2019 at 09:50:48AM -0400, Mark Reynolds wrote:
> On 5/22/19 9:02 PM, William Brown wrote:
> > Hi all,
Hi William,

> > I would propose to change this - but I feel we are now wedged on change by 
> > two things:
> > 
> > * Red Hat have documented these tools, and it's a big ask to get them to 
> > re-document everything.
> > * The cockpit console uses these tools in a special --json mode ( I would 
> > have created a dscockpit command that just handled the --json mode, rather 
> > than trying to make a tool do two jobs well.). This means rewriting cockpit 
> > integration 
> There was a brief talk about this actually while you were gone.  But Admins
> could use the json output for these same tasks so we left it in dsconf.  I
> would not be opposed to doing this though.  It would not be a major change
> for the UI, but it would be a lot of work to write the tool (alot of
> redundancy with dsconf).  We also talked about doing bulk data loading, so
> we could do something like call "ds-cockpit load replication", or
> load-everything, instead of calling "dsconf get" 20 times
Ideally, it should be a JSON API, in my opinion.
It will give us possibility to imporove CLI as we want (in the future).

> > * Time - heaps of time has already gone into these tools now, can we really 
> > justify undoing all that effort for this?
Yeah, it will require a lot of time to rewrite tools and docs at this point.
And I am not even talking about the confusion that it will produce for customers
(if we replace the tools too often without very good reason).

> > 
> > 
> > Which is a bit why I'm writing this
> > - Should I stop my task-oriented-vision and complaining that I have been 
> > doing, and accept what we have today?
> > - Do we want to try and pivot to change based on the ideas I have?
> > - Do I build something in parallel to satisfy my selfish desires, and to 
> > supplement what we have?
> 
> I really think you should write a new CLI tool that only does your
> recipe-style tasks for certain things.   Like I said that approach will not
> cover everything, but it could be used for other tasks.   Let the existing
> dsconf handle the fine grained configuration (although it's not as bad as
> you make it sound), then have a tool like "dstask", "dsrecipe" or something,
> that handles larger replication deployments, or whatever else you wanted to
> generalize.
> 
> To be honest I would like to hear from you which exact configurations you
> want to change.  Give some good detailed examples.  You keep saying how we
> should use a different style, but I think when you look closely at these
> areas of configuration you will find it's not possible to generalize them
> and to hide the horrid attributes underneath.  IMHO I feel most of the CLI
> commands are already doing what you kind of want except for a few of them
> which require fine grained control.  We can also add new arguments to the
> existing commands, but it's a bit late to rewrite/replace all of the usage.
> 
> So I am all for extending/improving the current CLI (it's certainly not
> perfect), or even you adding another tool for doing recipe tasks, but
> rewriting all of it doesn't sit well with me.
> 
> These are just my (biased) opinions, it would be nice if others from the 389
> team (or anyone) would speak up and voice their opinions and perspectives...
> 
> Mark

So, the discussion is back :)
Last time I remember it has happend here - 
https://pagure.io/389-ds-base/pull-request/50218

First of all, I think we can improve the existing tool.
The ideal picture I have in my head is:

- Optional arguments used only when they are really optional.
  A good example - `oc` OpenShift CLI. Just check its help and functionality...
  Sometime it has 3-5 positional arguments but the `--help` is 
  so nice and verbose that it is pleasure to use it
  (and if we add a bash-complition - it will be even better)
- Everything should be consistent. If we use one approach, we should stick
  to it accross the whole tool (we have small issues with that already but
  they are not big, fortunatly)
- It will be very nice to have an option for interactive session
  where users can do commands using the same connection.
  But it is really optional 'nice to have' feature (and it will be nice to
  have feedbeck from users/customers if they need it at all)
- We should move all JSON interactions to the REST API or something like this.

And you can find my plan below.
(I posted it in the issue above and you said it sounds reasonable to you)
I'd like to mention that it is veeery long term plan, we can't rush things 
here...
I'll leave some additional comments too:

1. Document the whole idea with all tools included and commands described
   (a design doc);

   Done by you. It is very nice and it can be imporoved even more.
   Ideally, it should contain the full help descriptions for all tools.
   This way we can review exact datails of you vision.
   Also, if you want and I can do 

[389-devel] Re: Use of rust for new logging backend

[Simon Pichugin]

On Tue, May 14, 2019 at 01:21:28PM +1000, William Brown wrote:
> Hi all,
> 
> So it's been a while since I pushed this, but again, I think I want to bring 
> this up. I'd like to write the new logging backend in Rust.
> 
> I'll start with a summary:
> 
> Pros:
> * Faster development time due to stricter code correctness guarantees
> * Modern and safe language to lower number of bugs in implementation
> * Much better libraries for interacting with things like json and thread 
> safety
> 
> Cons:
> * Another language in the codebase ...
> * We need to learn it to work on it
> * Vendors need to be ready to build with the toolchain
> 
> I've talked through some of these thoughts with Mark a bit, and I really 
> think it's time we did this - or gave up on pursuing it. I have been running 
> the rust enabled version of ds for a few years now with no issues. SUSE is 
> also in a position where they are able to and ready to build DS with Rust 
> (I'm assuming RH could easily also be brought to parity here).
> 
> So the main barrier becomes us: the most common argument is we don't know 
> enough or have enough experience. However I think this argument is flawed, in 
> the fact that there are many parts of the code where we already only have 1 
> or 2 experts in that area - often when we look into a bug or a feature, we 
> always have to learn new things, we have to read the code, understand even 
> the unique styles of how that was written for the time, and then do work. 
> This would be no different. I think we are all capable of learning and 
> working with these tools.
> 
> By this point, Gnome is looking into Rust as a mainline part of the desktop, 
> Samba has started to look into it, Firefox is already shipping Rust 
> components. I think that Rust is here to stay, and is not some passing trend.
> 
> 
> So what do we think? I think if there are no major objections I would like to 
> do this in Rust. I'll also commit to providing C-Rust FFI documentation for 
> the team, resources to help understand what's going on, and like always, I 
> will be sure to comment all my code thoroughly as part of this improvement. 
Hi William,
I am more than interested!

I'd like to learn it one day anyway.
So if there will be no objections and we'll go forward now,
I think, it is important to agree on some points of decreasing a bus factor:

- As you said, it should have very detailed comments on all of the
  language features and technics you'll use.
- I think it will be nice to have an additional documentation which will
  describe the basic setup for the development you use. All the toold you
  need to develop, compile, test and debug.
- Also, some nice links for the basic tutorials on Rust types, concepts, etc.
- I think, we should have detailed unit tests. It will help to
  understand the code better and we will have less bugs (hopefully).

And the final and big point I wanted to mention:

- We should be prepared for a slow review process because we have quite limited
  recources in the team and a lot of work should be done (WebUI still has to be 
refactored to React,
  and it is only a small piece of the workload).
  Also, I think, it makes sense to have the smallest Rust PRs that can be put 
together as an independent unit.

But everything is just my opinion and I don't know what others think and
if everyone is prepared to join it. I am feeling excited though :)

Thanks,
Simon

P.S. check the contribution guide please. Espesially a part about
'rebase-force-push'. I think it is nice not to force push during
the review process (and rebase-squash only after you got an ACK).


> 
> 
> —
> Sincerely,
> 
> William Brown
> 
> Senior Software Engineer, 389 Directory Server
> SUSE Labs
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Re: Please review

[Simon Pichugin]

On Tue, Apr 30, 2019 at 02:15:55PM +0530, Anuj Borah wrote:
>Hi all,
Hi Anuj,

>Please review these PRs.
>Pending from Long Time.
>[1]https://pagure.io/389-ds-base/pull-request/50180
>[2]https://pagure.io/389-ds-base/pull-request/50192
Could you please rebase them onto master?

Thanks,
Simon

>Regards
>Anuj Borah
> 
> References
> 
>1. https://pagure.io/389-ds-base/pull-request/50180
>2. https://pagure.io/389-ds-base/pull-request/50192

> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives: 
> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: Issue 49928 - Fix various small WebUI schema issues

[Simon Pichugin]

Hi team,
please, review the WebUI schema change.
Also, I wait for this to be merged
https://github.com/python-ldap/python-ldap/pull/247
but my PR will work as intended without it, I put a small workaround
which we will remove later.

https://pagure.io/389-ds-base/pull-request/49966
https://pagure.io/389-ds-base/issue/49928

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: Issue 49928 - WebUI schema functionality and improve CLI part

[Simon Pichugin]

Hi team,
please, review WebUI schema PR:

https://pagure.io/389-ds-base/issue/49928
https://pagure.io/389-ds-base/pull-request/49957

Thanks!
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

[389-devel] Please review: Issue 49761 - Fix replication test suite issues

[Simon Pichugin]

Hi team,

https://pagure.io/389-ds-base/pull-request/49846
https://pagure.io/389-ds-base/issue/49761

Thanks!
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/QGU63QPPIDTDWXLQAN6BFCZE3HQBR4PU/

[389-devel] Please review: Issue 49640 - Cleanup plugin bootstrap logging

[Simon Pichugin]

Hi team,

https://pagure.io/389-ds-base/issue/49640
https://pagure.io/389-ds-base/pull-request/49822

Thanks!
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/WGTNWGYVUB6RG6SHZNRCO57QMIFF5IPE/

[389-devel] Please review: Issue 49761 - Fix more CI test issues

[Simon Pichugin]

Hi team,

https://pagure.io/389-ds-base/issue/49761
https://pagure.io/389-ds-base/pull-request/49787

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/J5AZ3A3XRI27XDDQNGW7TVAHAY6LRL26/

[389-devel] Please review: Issue 49640 - Errors about PBKDF2 password storage plugin at server startup

[Simon Pichugin]

Hi team,

https://pagure.io/389-ds-base/issue/49640
https://pagure.io/389-ds-base/pull-request/49771

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/U6MIWQ7EG6VLSFQ7LT5WG24KS4GXV3JF/

[389-devel] Please review: Issue 49761 - Fix CI test suite issues

[Simon Pichugin]

Hi team,

https://pagure.io/389-ds-base/issue/49761
https://pagure.io/389-ds-base/pull-request/49762

Thanks,
Simon



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/U2ZGXF22ZATUS2TMP7OI5Z5Y5VL3DYGD/

[389-devel] Please review: Issue 49646 - Improve TLS cert processing in lib389 CLI

[Simon Pichugin]

Hi team,

https://pagure.io/389-ds-base/issue/49646
https://pagure.io/389-ds-base/pull-request/49709

And the issues were fixed:
https://pagure.io/389-ds-base/issue/49381
https://pagure.io/389-ds-base/pull-request/49708

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/B366FAQGMO3QDYCITB372XMXWSF6RNIH/

[389-devel] Please review: Issue 49381 - Add docstrings to plugin test suites - Part 1

[Simon Pichugin]

Hi team,
please, review a docstrings commit.

https://pagure.io/389-ds-base/issue/49381

https://pagure.io/389-ds-base/pull-request/49708

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/ACWS3JIDGNDHKEBFCYSX45VFJXQGEH47/

[389-devel] Re: Please review: Issue 49581 - Fix dynamic plugins test suite

[Simon Pichugin]

Fixed the issues Viktor has reported. Please, review.

On Mon, Apr 16, 2018 at 12:25:35PM +0200, Simon Pichugin wrote:
> On Thu, Apr 12, 2018 at 12:17:06PM +0200, Simon Pichugin wrote:
> > Hi team,
> > please review a PR for dynamic plugins test suite fix.
> > 
> > https://pagure.io/389-ds-base/issue/49581
> > https://pagure.io/389-ds-base/pull-request/49626
> > I devided it in two parts for easy review.
> > 
> > https://pagure.io/fork/spichugi/389-ds-base/c/9c7a76e27adfff02c40abdd4d49acfa187b97a14
> > First part adds a new Plugin functionality and fixes test suite.
> > 
> > https://pagure.io/fork/spichugi/389-ds-base/c/6da4cd78e117e0f3f75165561ca856fcd9dec2c4
> > And the second one moves the plugins_test.py to plugins/acceptance_test.py
> > and adopts it for working with fixtures.
> Small update acording to William's comments.
> 
> > 
> > Later it will be rebased in one commit.
> > 
> > Thanks,
> > Simon
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49657 - Fix cascading replication scenario in lib389 API

[Simon Pichugin]

The issues mentioned by Mark were fixed.

On Thu, May 03, 2018 at 02:32:22PM +0200, Simon Pichugin wrote:
> Hi team,
> please, review:
> 
> https://pagure.io/389-ds-base/pull-request/49659
> https://pagure.io/389-ds-base/issue/49657
> 
> Thanks!
> Simon
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: lib389 usage cheatsheet

[Simon Pichugin]

Hi Thierry,
I agree with you, it was exactly my proposition :)

Keeping main python-ldap elements is important because we don't want
to implement or mask/wrap this basic functionality (like working with controls, 
etc)
we just want to redirect them.

Ideally, we should make our admin library very intuitive for the people
who already knows python-ldap and just LDAP concepts.

I will continue adding more information to the docs regarding DSLdapObject
and I'll try to make it a bit closer to LDAP concepts (at least in
wording), I already have something in mind.

Thanks,
Simon


On Wed, May 09, 2018 at 06:12:33PM +0200, thierry bordaz wrote:
>Hi Simon,
> 
>  Thanks Simon starting this thread :)
>  Currently lib389 is mostly used by ldap devel/QE and seems realistic
>  to become the admin library (for example used by freeipa or others)
>  and component of 389 administrative tools. LDAP knowledge is a
>  requirement for all of them. In that sense, lib389 should continue
>  to follow/offer basic LDAP elements (connections, naming_ctx,
>  req/resp, synchronous/asynchronous, extop, control...).
>  I agree that those elements are a bit frustrating for people wanting
>  to use LDAP as a simple repository. The DSLdapObject abrstaction
>  looks very promising. It can be oriented to simple use case: create
>  users and groups, manage memberships, authentication/rights,
>  automatic deployement on several replicated instances. Then extended
>  on demand.
>  In short, IMHO I would prefer to keep the most of the LDAP elements
>  (option 1) and propose/extend easy POC interface (option 2). I am
>  not sure the work DSLdapObject is my favorite, we could name it
>  according to the use case we want to propose.
>  For me option 3 will be the worse option. I remember an abstraction
>  layer that had a so high level that I constantly looked at the
>  access/error log, to be sure that the program was doing what I was
>  thinking it should.
>  best regards
>  thierry
> 
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] lib389 usage cheatsheet

[Simon Pichugin]

Hi team,
recently, we had a discussion on a scrum meeting about lib389 and its new API. 

If I understood right there was an opinion that lib389 DSLdapObjects API
is not very intuitive and it is much easier stick to python-ldap style
because it uses ldapmodify/ldapadd wording (or close enough to it).
And I partially agree with it (and I already have some thoughts how we can
improve it).

Many patches on the review show that the people don't change their code
to the new way.
I've given some thought to it and this is what I came up with:

1. I think it is okay to use instance.add_s and instance.modify_s
   for simple operations.
2. If you'd like to make your life easier, you can use DSLdapObjects API
   (and I'll help you with that)
3. We should stop using old lib389 API because we don't support it anymore
   and it will be depricated in the future. We should use DSLdapObject
   instead and we should improve it if we don't like something about it.

We have a lot of docstrings written in lib389 code and the code itself
is pretty readable, in my opinion. But I'd like to make the life easier
and I've started to write 'lib389 cheatsheet'. It has old way/new way
comparison blocks and I base it on the real-life code from your patches
adding some commentairies.

For now, it is here:
https://fedorapeople.org/~spichugi/html/cheatsheet.html

Thanks!
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49657 - Fix cascading replication scenario in lib389 API

[Simon Pichugin]

Hi team,
please, review:

https://pagure.io/389-ds-base/pull-request/49659
https://pagure.io/389-ds-base/issue/49657

Thanks!
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Ticket 49650 - lib389 enable_tls doesn't work on F28

[Simon Pichugin]

Hi team,
please review:

https://pagure.io/389-ds-base/issue/49650
https://pagure.io/389-ds-base/pull-request/49653

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49538 - replace cacertdir_rehash with openssl rehash

[Simon Pichugin]

I've changed it to c_rehash tool and added a small fix 
related t remove_ds_instance.

On Mon, Apr 23, 2018 at 04:06:35PM +0200, Simon Pichugin wrote:
> Hi team,
> please, review:
> 
> https://pagure.io/389-ds-base/issue/49538
> https://pagure.io/389-ds-base/pull-request/49651
> 
> Thanks,
> Simon
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49538 - replace cacertdir_rehash with openssl rehash

[Simon Pichugin]

Hi team,
please, review:

https://pagure.io/389-ds-base/issue/49538
https://pagure.io/389-ds-base/pull-request/49651

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49406 - Port backend_test.py test to DSLdapObject implementation

[Simon Pichugin]

Hi team,
please review a test suite with simple tests for Backends(DSLdapObject)
implementation.

https://pagure.io/389-ds-base/issue/49406
https://pagure.io/389-ds-base/pull-request/49647

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49642 - lib389 should generate a more complex password

[Simon Pichugin]

Hi team,

https://pagure.io/389-ds-base/pull-request/49643
https://pagure.io/389-ds-base/issue/49642

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review - Issue 49612 - lib389 remove_ds_instance() does not remove systemd units

[Simon Pichugin]

Hi team, please, review a lib389 Python installer (remove function) patch.

https://pagure.io/389-ds-base/pull-request/49641
https://pagure.io/389-ds-base/issue/49612

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

[Simon Pichugin]

The LDAP+StartTLS was changed back to StartTLS by Mark suggestions and
I support his commentary.
https://pagure.io/389-ds-base/pull-request/49613#comment-50699

Please, check once again if everything is okay.

Thanks!
Simon

On Thu, Apr 12, 2018 at 11:38:51AM +0200, Simon Pichugin wrote:
> On Wed, Mar 21, 2018 at 11:05:06PM +0100, Simon Pichugin wrote:
> > Hi team,
> > as William and Matus proposed, I've changed nsDS5ReplicaTransportInfo: TLS 
> > to LDAP+StartTLS.
> > Also, I've changed existed TLS test suite so it covers the change.
> I changed the name for DNA_PROT_ as William proposed.
> 
> Also, Mark, could you please take a look and approve the renaming too?
> 
> replication/acceptance_test.py and replication/tls_client_auth_repl_test.py 
> have PASSed.
> 
> Thanks,
> Simon
> 
> > 
> > On Tue, Mar 20, 2018 at 12:45:52AM +0100, Simon Pichugin wrote:
> > > Hi team,
> > > please, review:
> > > 
> > > https://pagure.io/389-ds-base/issue/49109
> > > https://pagure.io/389-ds-base/pull-request/49613
> > > 
> > > Thanks,
> > > Simon
> > > ___
> > > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49511 - memory leak in pwdhash

[Simon Pichugin]

Hi team,
please review a small fix for memory leak issue:

https://pagure.io/389-ds-base/issue/49511
https://pagure.io/389-ds-base/pull-request/49638

Thanks!
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49581 - Fix dynamic plugins test suite

[Simon Pichugin]

On Thu, Apr 12, 2018 at 12:17:06PM +0200, Simon Pichugin wrote:
> Hi team,
> please review a PR for dynamic plugins test suite fix.
> 
> https://pagure.io/389-ds-base/issue/49581
> https://pagure.io/389-ds-base/pull-request/49626
> I devided it in two parts for easy review.
> 
> https://pagure.io/fork/spichugi/389-ds-base/c/9c7a76e27adfff02c40abdd4d49acfa187b97a14
> First part adds a new Plugin functionality and fixes test suite.
> 
> https://pagure.io/fork/spichugi/389-ds-base/c/6da4cd78e117e0f3f75165561ca856fcd9dec2c4
> And the second one moves the plugins_test.py to plugins/acceptance_test.py
> and adopts it for working with fixtures.
Small update acording to William's comments.

> 
> Later it will be rebased in one commit.
> 
> Thanks,
> Simon
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49581 - Fix dynamic plugins test suite

[Simon Pichugin]

Hi team,
please review a PR for dynamic plugins test suite fix.

https://pagure.io/389-ds-base/issue/49581
https://pagure.io/389-ds-base/pull-request/49626
I devided it in two parts for easy review.

https://pagure.io/fork/spichugi/389-ds-base/c/9c7a76e27adfff02c40abdd4d49acfa187b97a14
First part adds a new Plugin functionality and fixes test suite.

https://pagure.io/fork/spichugi/389-ds-base/c/6da4cd78e117e0f3f75165561ca856fcd9dec2c4
And the second one moves the plugins_test.py to plugins/acceptance_test.py
and adopts it for working with fixtures.

Later it will be rebased in one commit.

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

[Simon Pichugin]

Hi team,
as William and Matus proposed, I've changed nsDS5ReplicaTransportInfo: TLS to 
LDAP+StartTLS.
Also, I've changed existed TLS test suite so it covers the change.

On Tue, Mar 20, 2018 at 12:45:52AM +0100, Simon Pichugin wrote:
> Hi team,
> please, review:
> 
> https://pagure.io/389-ds-base/issue/49109
> https://pagure.io/389-ds-base/pull-request/49613
> 
> Thanks,
> Simon
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

[Simon Pichugin]

Hi team,
please, review:

https://pagure.io/389-ds-base/issue/49109
https://pagure.io/389-ds-base/pull-request/49613

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Use of int types in the code base,

[Simon Pichugin]

- Original Message -
> From: "William Brown" <will...@blackhats.net.au>
> To: "389 Directory server developer discussion." 
> <389-devel@lists.fedoraproject.org>
> Sent: Monday, March 12, 2018 12:50:50 AM
> Subject: [389-devel] Re: Use of int types in the code base,
> 
> On Fri, 2018-03-09 at 02:35 -0500, Simon Pichugin wrote:
> > 
> > - Original Message -
> > > From: "William Brown" <will...@blackhats.net.au>
> > > To: "Simon Pichugin" <spich...@redhat.com>
> > > Cc: "389-devel" <389-devel@lists.fedoraproject.org>
> > > Sent: Friday, March 9, 2018 12:30:40 AM
> > > Subject: Re: Use of int types in the code base,
> > > 
> > > On Thu, 2018-03-08 at 17:33 -0500, Simon Pichugin wrote:
> > > > Hi William!
> > > > Thank you for the email. It has clarified the things for me. :)
> > > > I still have one question though.
> > > > 
> > > > Do I understand right that I need also to cast types with these
> > > > types
> > > > from inttypes.h?
> > > > So use it not only in the defenitions.
> > > > - sprintf(buf, "%lu", (long unsigned int)maxsize);
> > > > + sprintf(buf, "%" PRIu64, (uint64_t)maxsize);
> > > 
> > > There is PRIu32 too :)
> > > 
> > > The pattern is:
> > > 
> > > PRI
> > > 
> > > IE
> > > 
> > > PRIu64 - uint64_t
> > > PRId64 - int64_t
> > > PRIu32 - uint32_t
> > > PRId32 - int32_t
> > > 
> > > Check what type maxsize is to be sure you use the correct PRI type.
> > > 
> > > Hope that helps,
> > 
> > Ok. My question was about a bit different thing :)
> > But now, after some investigation I have clarified something but not
> > all:
> > 
> > So we have size_t that will have the size of the platform (it's 64
> > now but later we can have 128 bit platform, etc.).
> 
> It's a bit optimistic to think 128bit computing will arrive anytime
> soon ;)
Yeah...

> 
> > For now, the code will work like this (without any warning)
> > size_t maxsize
> > sprintf(buf, "%" PRIu64, maxsize);
> > And, actually, we already have lines like these in the older code
> > added by you:
> > https://pagure.io/389-ds-base/c/274823860ac98b153e7f0bc84d979861c4ca8
> > 95f
> > 
> > Or we can change size_t as you've proposed in pull request:
> > https://pagure.io/389-ds-base/pull-request/49595
> > "Ahhh I see the issue here. You have maxsize as size_t, but you have
> > PRIu64. Size_t is platform specific width, so you could change
> > maxsize to be a uint64_t instead to avoid this."
> > uint64_t maxsize
> > sprintf(buf, "%" PRIu64, maxsize);
> 
> I would do it this way (uint64_t for maxsize). It's better to be
> "absolute" and explicit in our types. size_t only makes sense for array
> indexing, nothing else.
Great! I agree with you.
So I've uploaded the change couple of days ago assuming you'll say so. :)
And if you're okay with the rest of the code, I'll merge it.
https://pagure.io/389-ds-base/pull-request/49595

> 
> > 
> > So could you please guide me here on what coding style do we have in
> > cases like this?
> > 
> > As I understood from coding style guide you gave, we need to use
> > 64bit types mostly (size_t for arrays indexing and 32bit types for
> > compatibility with some apis only)
> > 
> > Thank you,
> > Simon
> > 
> > > 
> > > 
> > > > 
> > > > Thanks,
> > > > Simon
> > > > 
> > > > - Original Message -
> > > > > From: "William Brown" <will...@blackhats.net.au>
> > > > > To: "389-devel" <389-devel@lists.fedoraproject.org>
> > > > > Sent: Thursday, March 8, 2018 12:42:03 AM
> > > > > Subject: Use of int types in the code base,
> > > > > 
> > > > > Hi there,
> > > > > 
> > > > > http://www.port389.org/docs/389ds/development/coding-style.html
> > > > > #typ
> > > > > es
> > > > > 
> > > > > In a few reviews I still see this sometimes.
> > > > > 
> > > > > It's pretty important that we keep moving our quality standard
> > > > > higher,
> > > > > and having known type sizes is important to this. Types like
> > > >

[389-devel] Re: Use of int types in the code base,

[Simon Pichugin]

- Original Message -
> From: "William Brown" <will...@blackhats.net.au>
> To: "Simon Pichugin" <spich...@redhat.com>
> Cc: "389-devel" <389-devel@lists.fedoraproject.org>
> Sent: Friday, March 9, 2018 12:30:40 AM
> Subject: Re: Use of int types in the code base,
> 
> On Thu, 2018-03-08 at 17:33 -0500, Simon Pichugin wrote:
> > Hi William!
> > Thank you for the email. It has clarified the things for me. :)
> > I still have one question though.
> > 
> > Do I understand right that I need also to cast types with these types
> > from inttypes.h?
> > So use it not only in the defenitions.
> > - sprintf(buf, "%lu", (long unsigned int)maxsize);
> > + sprintf(buf, "%" PRIu64, (uint64_t)maxsize);
> 
> There is PRIu32 too :)
> 
> The pattern is:
> 
> PRI
> 
> IE
> 
> PRIu64 - uint64_t
> PRId64 - int64_t
> PRIu32 - uint32_t
> PRId32 - int32_t
> 
> Check what type maxsize is to be sure you use the correct PRI type.
> 
> Hope that helps,
Ok. My question was about a bit different thing :)
But now, after some investigation I have clarified something but not all:

So we have size_t that will have the size of the platform (it's 64 now but 
later we can have 128 bit platform, etc.).
For now, the code will work like this (without any warning)
size_t maxsize
sprintf(buf, "%" PRIu64, maxsize);
And, actually, we already have lines like these in the older code added by you:
https://pagure.io/389-ds-base/c/274823860ac98b153e7f0bc84d979861c4ca895f

Or we can change size_t as you've proposed in pull request:
https://pagure.io/389-ds-base/pull-request/49595
"Ahhh I see the issue here. You have maxsize as size_t, but you have PRIu64. 
Size_t is platform specific width, so you could change maxsize to be a uint64_t 
instead to avoid this."
uint64_t maxsize
sprintf(buf, "%" PRIu64, maxsize);

So could you please guide me here on what coding style do we have in cases like 
this?

As I understood from coding style guide you gave, we need to use 64bit types 
mostly (size_t for arrays indexing and 32bit types for compatibility with some 
apis only)

Thank you,
Simon

> 
> 
> > 
> > Thanks,
> > Simon
> > 
> > - Original Message -
> > > From: "William Brown" <will...@blackhats.net.au>
> > > To: "389-devel" <389-devel@lists.fedoraproject.org>
> > > Sent: Thursday, March 8, 2018 12:42:03 AM
> > > Subject: Use of int types in the code base,
> > > 
> > > Hi there,
> > > 
> > > http://www.port389.org/docs/389ds/development/coding-style.html#typ
> > > es
> > > 
> > > In a few reviews I still see this sometimes.
> > > 
> > > It's pretty important that we keep moving our quality standard
> > > higher,
> > > and having known type sizes is important to this. Types like int
> > > and
> > > long are unknown sizes until you compile it depending on platform.
> > > 
> > > As a result, it's really important we use the intX_t and uintX_t
> > > types
> > > so we have guarantees of our values. I would encourage the use of
> > > int64_t and uint64_t, because while they are "larger", it's
> > > significantly faster for a modern 64bit system to process these
> > > values
> > > than their 32bit counterparts.
> > > 
> > > Another note is that arrays index by size_t, not 'int', so we
> > > should
> > > always keep this in mind.
> > > 
> > > Finally, because we are using c99 now, this means we should avoid:
> > > 
> > > size_t i = 0;
> > > 
> > > for (i = 0; i < cond; i++) {
> > > ...
> > > }
> > > 
> > > When we really should scope our values. Scoping is good because it
> > > limits possibility of data corruption to flow and other mistakes
> > > such
> > > as re-use of values. This means:
> > > 
> > > for (size_t i = 0; i < cond; i++) {
> > > ...
> > > }
> > > 
> > > Thanks!
> > > 
> > > --
> > > Thanks,
> > > 
> > > William Brown
> > > 
> --
> Thanks,
> 
> William Brown
> 
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49593 - NDN cache stats should be under the global stats

[Simon Pichugin]

Fixed issues with inttypes.

On Wed, Mar 07, 2018 at 08:01:33PM +0100, Simon Pichugin wrote:
> Fixed compile warnings.
> 
> On Wed, Mar 07, 2018 at 06:53:53PM +0100, Simon Pichugin wrote:
> > Hi team,
> > please, review:
> > 
> > https://pagure.io/389-ds-base/pull-request/49595
> > https://pagure.io/389-ds-base/issue/49593
> > 
> > Thanks,
> > Simon
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Use of int types in the code base,

[Simon Pichugin]

Hi William!
Thank you for the email. It has clarified the things for me. :)
I still have one question though.

Do I understand right that I need also to cast types with these types from 
inttypes.h?
So use it not only in the defenitions.
- sprintf(buf, "%lu", (long unsigned int)maxsize);
+ sprintf(buf, "%" PRIu64, (uint64_t)maxsize);

Thanks,
Simon

- Original Message -
> From: "William Brown" 
> To: "389-devel" <389-devel@lists.fedoraproject.org>
> Sent: Thursday, March 8, 2018 12:42:03 AM
> Subject: Use of int types in the code base,
> 
> Hi there,
> 
> http://www.port389.org/docs/389ds/development/coding-style.html#types
> 
> In a few reviews I still see this sometimes.
> 
> It's pretty important that we keep moving our quality standard higher,
> and having known type sizes is important to this. Types like int and
> long are unknown sizes until you compile it depending on platform.
> 
> As a result, it's really important we use the intX_t and uintX_t types
> so we have guarantees of our values. I would encourage the use of
> int64_t and uint64_t, because while they are "larger", it's
> significantly faster for a modern 64bit system to process these values
> than their 32bit counterparts.
> 
> Another note is that arrays index by size_t, not 'int', so we should
> always keep this in mind.
> 
> Finally, because we are using c99 now, this means we should avoid:
> 
> size_t i = 0;
> 
> for (i = 0; i < cond; i++) {
> ...
> }
> 
> When we really should scope our values. Scoping is good because it
> limits possibility of data corruption to flow and other mistakes such
> as re-use of values. This means:
> 
> for (size_t i = 0; i < cond; i++) {
> ...
> }
> 
> Thanks!
> 
> --
> Thanks,
> 
> William Brown
> 
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49593 - NDN cache stats should be under the global stats

[Simon Pichugin]

Fixed compile warnings.

On Wed, Mar 07, 2018 at 06:53:53PM +0100, Simon Pichugin wrote:
> Hi team,
> please, review:
> 
> https://pagure.io/389-ds-base/pull-request/49595
> https://pagure.io/389-ds-base/issue/49593
> 
> Thanks,
> Simon
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49593 - NDN cache stats should be under the global stats

[Simon Pichugin]

Hi team,
please, review:

https://pagure.io/389-ds-base/pull-request/49595
https://pagure.io/389-ds-base/issue/49593

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49572 - ns_job_wait race on condvar

[Simon Pichugin]

Hi team,
please, review a small fix for nunc-stance tests:

https://pagure.io/389-ds-base/issue/49572

https://pagure.io/389-ds-base/pull-request/49592

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49584 - Fix issues with paged_results test suite

[Simon Pichugin]

Hi team,
please, review a small fix:

https://pagure.io/389-ds-base/issue/49584

https://pagure.io/389-ds-base/pull-request/49590

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49560 - Add a test case for extract-pemfiles

[Simon Pichugin]

Hi team,
please, review a new pull request:
https://pagure.io/389-ds-base/pull-request/49578

And a gentle reminder...
https://pagure.io/389-ds-base/pull-request/49567

Thanks,
Simon
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Add a test suite for ds-replcheck tool RFE

[Simon Pichugin]

Please, review the full version of the RFE test suite.

https://pagure.io/389-ds-base/pull-request/49567

- Original Message -
> From: "Simon Pichugin" <spich...@redhat.com>
> To: "389 Directory server developer discussion." 
> <389-devel@lists.fedoraproject.org>
> Sent: Wednesday, February 14, 2018 5:40:29 PM
> Subject: [389-devel] Please review: Add a test suite for ds-replcheck tool RFE
> 
> Hi team,
> please, review a draft of RFE tests
> 
> https://pagure.io/389-ds-base/pull-request/49567
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> 
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Add a test suite for ds-replcheck tool RFE

[Simon Pichugin]

Hi team,
please, review a draft of RFE tests

https://pagure.io/389-ds-base/pull-request/49567
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49043 - Add a test suite

[Simon Pichugin]

Final version. All tests from other tickets were added.
Please, review.

https://pagure.io/389-ds-base/pull-request/49558

- Original Message -
> From: "Simon Pichugin" <spich...@redhat.com>
> To: "389 Directory server developer discussion." 
> <389-devel@lists.fedoraproject.org>
> Sent: Thursday, February 1, 2018 8:54:17 PM
> Subject: [389-devel] Please review: Issue 49043 - Add a test suite
> 
> Hi team,
> I'll be on PTO 02.02, I'll check the comments on Monday
> 
> https://pagure.io/389-ds-base/pull-request/49558
> 
> Practicing pull-requests. Also, the test will fail at the tearDown.
> It will be fixed in https://pagure.io/389-ds-base/issue/49551
> 
> Thanks!
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> 
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 48085 - Add encryption cl5 test suite

[Simon Pichugin]

Hi team, please, review my rework of Sankar's patch.

https://pagure.io/389-ds-base/issue/48085
https://pagure.io/389-ds-base/issue/raw/files/f78334baf6bc2eab6b9566f79aa2321b262ac604ff6b1a32dba7bf806376-0001-Issue-48085-Add-encryption-cl5-test-suite.patch

Thanks!
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49043 - Add a test suite

[Simon Pichugin]

Hi team,
I'll be on PTO 02.02, I'll check the comments on Monday

https://pagure.io/389-ds-base/pull-request/49558

Practicing pull-requests. Also, the test will fail at the tearDown.
It will be fixed in https://pagure.io/389-ds-base/issue/49551

Thanks!
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Ticket 49523 - Refactor CI test

[Simon Pichugin]

https://pagure.io/389-ds-base/issue/49523

https://pagure.io/389-ds-base/issue/raw/files/da1e9819a28050aed3d00828a1b8212f19420411d6fd8e11aabe7a6776f851c3-0001-Ticket-49523-Refactor-CI-test.patch


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: PR's might now be an option!

[Simon Pichugin]

On Thu, Jan 04, 2018 at 10:33:35AM +1000, William Brown wrote:
> Hi all,
> 
> We recently have completed two PR based merges, both went successfully.
> 
> I think it's time we bring up again the option of allowing PR's as a
> main workflow for the project.
> 
> I think we can allow both PR + patch for the time, they do not exclude
> each other.
> 
> What do we think? Are we okay to proceed with this? 
I am okay with it too.

> 
> -- 
> Sincerely,
> 
> William Brown
> Software Engineer
> Red Hat, Australia/Brisbane
> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49374 - Add CI test case

[Simon Pichugin]

Hi team,
please review a small test case:

https://pagure.io/389-ds-base/issue/49374
https://pagure.io/389-ds-base/issue/raw/files/f23c2afa41b204756126c621b8a0c12678179048a725e587f775b0a4cfc19200-0001-Issue-49374-Add-CI-test-case.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 47536 - Add Python 3 support and move test case to suites

[Simon Pichugin]

I've fixed the issues:
https://pagure.io/389-ds-base/issue/raw/files/e023d32821b13103e662b94b1348a0a3016b3ea15fd24b4e2bebfefbdae9e8e6-0001-Issue-47536-Add-Python-3-support-and-move-test-case-.patch

On Thu, Nov 23, 2017 at 03:53:17PM +0100, Simon Pichugin wrote:
> Hi team,
> please, review the Python 3 support patch.
> 
> https://pagure.io/389-ds-base/issue/47536
> https://pagure.io/389-ds-base/issue/raw/files/1cdbed5b2520a0f85c950305ee3f40e605f8d263129ff70996952ba8ac94d895-0001-Issue-47536-Add-Python-3-support-and-move-test-case-.patch
> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 47536 - Add Python 3 support and move test case to suites

[Simon Pichugin]

Hi team,
please, review the Python 3 support patch.

https://pagure.io/389-ds-base/issue/47536
https://pagure.io/389-ds-base/issue/raw/files/1cdbed5b2520a0f85c950305ee3f40e605f8d263129ff70996952ba8ac94d895-0001-Issue-47536-Add-Python-3-support-and-move-test-case-.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49408- Add a test case for nsds5ReplicaId checks

[Simon Pichugin]

Hi team,
please, review a small test case I need to verify BZ:

https://pagure.io/389-ds-base/issue/49408
https://pagure.io/389-ds-base/issue/raw/files/f5457f377c15dd5d35d153baa775a8be15f883c419d929fb41a4203be145a200-0001-Issue-49408-Add-a-test-case-for-nsds5ReplicaId-check.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue #77 - Refactor docstrings in rST format - part 2

[Simon Pichugin]

https://pagure.io/lib389/issue/raw/files/a7f959f31cfd6f5b4f837dd715bf1d0beb96a182e30a0c1b13bfc4d3cdfbc905-0001-Issue-lib389-77-Refactor-docstrings-in-rST-format-pa.patch

On Wed, Nov 15, 2017 at 04:44:07PM +0100, Simon Pichugin wrote:
> A second part:
> 
> https://pagure.io/lib389/issue/77
> https://pagure.io/lib389/issue/raw/files/b050293a47890b3527564aa336937830b0fc298a90037f972e46d49477134a24-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch
> 
> On Wed, Sep 06, 2017 at 07:33:24PM +0200, Simon Pichugin wrote:
> > Hi team, 
> > 
> > please, check out the new docs.
> > 
> > https://fedorapeople.org/~spichugi/html/index.html
> > 
> > https://pagure.io/lib389/issue/77
> > https://pagure.io/lib389/issue/raw/files/2e181d5321f194587899b1cbb37455d86d2754daeacb2d02c6de60aa9830b079-0001-Issue-77-Refactor-docstrings-in-rST-format-part-1.patch
> > 
> > Thanks,
> > Simon
> 
> 
> 
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> 



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue #77 - Refactor docstrings in rST format - part 2

[Simon Pichugin]

A second part:

https://pagure.io/lib389/issue/77
https://pagure.io/lib389/issue/raw/files/b050293a47890b3527564aa336937830b0fc298a90037f972e46d49477134a24-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch

On Wed, Sep 06, 2017 at 07:33:24PM +0200, Simon Pichugin wrote:
> Hi team, 
> 
> please, check out the new docs.
> 
> https://fedorapeople.org/~spichugi/html/index.html
> 
> https://pagure.io/lib389/issue/77
> https://pagure.io/lib389/issue/raw/files/2e181d5321f194587899b1cbb37455d86d2754daeacb2d02c6de60aa9830b079-0001-Issue-77-Refactor-docstrings-in-rST-format-part-1.patch
> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 48393 - Add a test case for nsds5ReplicaId checks

[Simon Pichugin]

https://pagure.io/389-ds-base/issue/48393
https://pagure.io/389-ds-base/issue/raw/files/a900cbac9d8d6ed0bd14a424dd966cca4233a1376fb392c2129d5987d3073f90-0001-Issue-48393-Add-a-test-case-for-nsds5ReplicaId-check.patch


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue lib389 3 - Python 3 support for ACL test suite

[Simon Pichugin]

On Fri, Oct 20, 2017 at 12:14:12PM +0200, Simon Pichugin wrote:
> Hi team,
> please, review the Python 3 support patch for ACL.
> 
> Also, please, check it if you are a developer. Because it contains
> the indended way to use lib389 feature for Python 3 support.
> 
> https://pagure.io/lib389/issue/3
> https://pagure.io/lib389/issue/raw/files/f5707f366a5769c0232aaa0a0270db72372740c449b681c48a567c3e7523d37d-0001-Issue-lib389-3-Python-3-support-for-ACL-test-suite.patch

New version. The failure is fixed.

https://pagure.io/lib389/issue/raw/files/5f7aa59e1519619bab865b1ae537c0f8dc925c44aec391a78fcccb1fc6258c60-0001-Issue-lib389-3-Python-3-support-for-ACL-test-suite.patch

> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue lib389 3 - Python 3 support for ACL test suite

[Simon Pichugin]

Hi team,
please, review the Python 3 support patch for ACL.

Also, please, check it if you are a developer. Because it contains
the indended way to use lib389 feature for Python 3 support.

https://pagure.io/lib389/issue/3
https://pagure.io/lib389/issue/raw/files/f5707f366a5769c0232aaa0a0270db72372740c449b681c48a567c3e7523d37d-0001-Issue-lib389-3-Python-3-support-for-ACL-test-suite.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings - Part 2

[Simon Pichugin]

Fixed the issues:
https://pagure.io/389-ds-base/issue/49381
https://pagure.io/389-ds-base/issue/raw/files/b050293a47890b3527564aa336937830b0fc298a90037f972e46d49477134a24-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch

On Fri, Oct 06, 2017 at 03:27:36PM +0200, Simon Pichugin wrote:
> Hi team,
> please, review my second patch for suite docstrings:
> 
> https://pagure.io/389-ds-base/issue/49381
> https://pagure.io/389-ds-base/issue/raw/files/350ce1073ac05a722674475b679a346142e0b000b244df5c242b877ddd316a86-0001-Issue-49381-Refactor-numerous-suite-docstrings-Part-.patch
> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 99 - Fix typo in create_topology

[Simon Pichugin]

Hi team,
please review two line patch.

https://pagure.io/lib389/issue/99
https://pagure.io/lib389/issue/raw/files/f3e504a5779b08eedf743645be3ab3af601213a5f35e9e44dd7f02254a43f72c-0001-Issue-99-Fix-typo-in-create_topology.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings

[Simon Pichugin]

New version:
https://pagure.io/389-ds-base/issue/49381
https://pagure.io/389-ds-base/issue/raw/files/525619ec2b6d51ca4a78998e6b40c43d344e19d180e97ee67f1e09c82721f86f-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch

On Fri, Sep 15, 2017 at 05:42:20PM +0200, Simon Pichugin wrote:
> Hi team,
> 
> please, review the patch for suite docs.
> 
> https://pagure.io/389-ds-base/issue/49381
> https://pagure.io/389-ds-base/issue/raw/files/5e909fe03f497ebad570a73364de1c2145f5c9b99d88c0543628ff5c0f0b038a-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch
> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 49381 - Refactor numerous suite docstrings

[Simon Pichugin]

New version:
https://pagure.io/389-ds-base/issue/49381
https://pagure.io/389-ds-base/issue/raw/files/afa9b1a73b02e21633279b939d02deff33328cdc100b4c7c80645dd6b532f7ac-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch

On Fri, Sep 15, 2017 at 05:42:20PM +0200, Simon Pichugin wrote:
> Hi team,
> 
> please, review the patch for suite docs.
> 
> https://pagure.io/389-ds-base/issue/49381
> https://pagure.io/389-ds-base/issue/raw/files/5e909fe03f497ebad570a73364de1c2145f5c9b99d88c0543628ff5c0f0b038a-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch
> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49381 - Refactor numerous suite docstrings

[Simon Pichugin]

Hi team,

please, review the patch for suite docs.

https://pagure.io/389-ds-base/issue/49381
https://pagure.io/389-ds-base/issue/raw/files/5e909fe03f497ebad570a73364de1c2145f5c9b99d88c0543628ff5c0f0b038a-0001-Issue-49381-Refactor-numerous-suite-docstrings.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue #77 - Fix changelogdb param issue

[Simon Pichugin]

Hi team,
please, review:

https://pagure.io/lib389/issue/77
https://pagure.io/lib389/issue/raw/files/486d6f41143e829fde00c722747e95d4ad03efafd0680b1e78f1c95ec693c3c0-0001-Issue-77-Fix-changelogdb-param-issue.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue #77 - Refactor docstrings in rST format - part 1

[Simon Pichugin]

Hi team, 

please, check out the new docs.

https://fedorapeople.org/~spichugi/html/index.html

https://pagure.io/lib389/issue/77
https://pagure.io/lib389/issue/raw/files/2e181d5321f194587899b1cbb37455d86d2754daeacb2d02c6de60aa9830b079-0001-Issue-77-Refactor-docstrings-in-rST-format-part-1.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue #77 - Add sphinx documentation

[Simon Pichugin]

Hi team,
Most of the comments were applied. Thanks!

Now the layout is:
- index.rst - welcoming word, Table of Contents and Contact Us.
- guidelines.rst - is included into index.rst and contains basic test
  development workflow, pytest features overview, and basic lib389 and
  python-ldap features.
- replica.rst, agreement.rst, aci.rst, etc. - each contains the
  respective documentation.

Currently I do add docstrings to lib389 and rst files with
references. It will be the next patch.
Now, please, check if you agree with the existing format.

The generated example - https://fedorapeople.org/~spichugi/html/

https://pagure.io/lib389/issue/raw/files/95c83274b06e9b48993af02040a23194f075e48460efe04dbacfeb50cc2eaa51-0001-Issue-77-Add-sphinx-documentation.patch

https://pagure.io/lib389/issue/77

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 85 - Remove legacy replication attribute

[Simon Pichugin]

Hi team,
please, review the patch for lib389.
I've checked, it fixes tickets/ticket48325_test.py.

https://pagure.io/lib389/issue/85
https://pagure.io/lib389/issue/raw/files/d5d0b94c97f8d341f4785e76c94c719d3902b80c3f339f047a9e95316ff28dcd-0001-Issue-85-Remove-legacy-replication-attribute.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 91 - Fix replication m1h1c1 topology

[Simon Pichugin]

Hi team,
https://pagure.io/lib389/issue/91
https://pagure.io/lib389/issue/raw/files/f9874b05dcab8b6e01517163218c9572b14373b8809cf93a1a38827c3db1873f-0001-Issue-91-Fix-replication-m1h1c1-topology.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Issue 83, 79 - lib389 - Fix tests and create_test.py - Replica fix

[Simon Pichugin]

Hi team,
some of the tests in 389-ds-base are broken.
The following patches should fix them:

For 389-ds-base:
https://pagure.io/lib389/issue/83
https://pagure.io/lib389/issue/raw/files/7ce24a6d79ce0242a200354133f65d910af46f1f73da7497d45312cd19280f44-0001-Issue-83-lib389-Fix-tests-and-create_test.py.patch

For lib389:
https://pagure.io/lib389/issue/79
https://pagure.io/lib389/issue/raw/files/f21bb2a58d89e3939a8a2c1d1579157e028e03de5285012a261bf27ec4b2b1aa-0001-Issue-79-Fix-replica.py-and-add-tests.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Issue 83 - lib389 - Replace topology agmt objects

[Simon Pichugin]

Hi team,
please review a patch for 389-ds-base tests:

https://pagure.io/lib389/issue/83
https://pagure.io/lib389/issue/raw/files/9d807e6ff14eb4df440feea988db6f94794eba9d40b3204b8ed8286d9fce3dff-0001-Issue-83-lib389-Replace-topology-agmt-objects.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

[Simon Pichugin]

Add enum34 to pip and python-enum34 to specfile for RHEL7/Fedora.
https://pagure.io/lib389/issue/79
https://pagure.io/lib389/issue/raw/files/f21bb2a58d89e3939a8a2c1d1579157e028e03de5285012a261bf27ec4b2b1aa-0001-Issue-79-Fix-replica.py-and-add-tests.patch

On Wed, Aug 02, 2017 at 03:10:57PM +0200, Simon Pichugin wrote:
> Add enum34 to requirements.txt for py2 compatibility
> 
> https://pagure.io/lib389/issue/79
> https://pagure.io/lib389/issue/raw/files/7be353523a4a7ad8382a9a98ad778819f5e7557ab1812b9d1e595499ef821244-0001-Issue-79-Fix-replica.py-and-add-tests.patch
> 
> On Mon, Jul 31, 2017 at 06:28:05PM +0200, Simon Pichugin wrote:
> > New changes regarding _constants.py module.
> > - replace REPLICAROLE_* with ReplicaRole(Enum) object
> > - change the type of REPLICA_FLAGS_* from str to int
> > - remove not used constants REPLICA_TYPE_* and REPLICA_FLAGS_CON
> > 
> > https://pagure.io/lib389/issue/79
> > https://pagure.io/lib389/issue/raw/files/80825f0aee3bcb098b89d442af4526df8b13e2082496de83669dc4220199002e-0001-Issue-79-Fix-replica.py-and-add-tests.patch
> > 
> > Thanks,
> > Simon
> > 
> > On Thu, Jul 27, 2017 at 03:14:59PM +0200, Simon Pichugin wrote:
> > > Hi team,
> > > please review a patch that fixes Replicas DSLdapObject.
> > > 
> > > https://pagure.io/lib389/issue/79
> > > https://pagure.io/lib389/issue/raw/files/febe12b17a148405c527ed4938a9ef06c1d5046c9c3070ad32a0770526f33ee0-0001-Issue-79-Fix-replica.py-and-add-tests.patch
> > > 
> > > Thanks,
> > > Simon
> > 
> > 
> > 
> > > ___
> > > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> > 
> 
> 
> 
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> 



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: future of lib389 - seperate or merged?

[Simon Pichugin]

On Tue, Aug 01, 2017 at 04:00:23PM +1000, William Brown wrote:
> My vote is to merge them. I came to this decision because I believe that
> this will make development against multiple branches easier with regard
> to testing and backport of patches. For example, we'll know that lib389
> that's inside of 1.3.7 will *always* work with that release, even if we
> have improved in 1.4.x etc. 
> 
> We also are developing new CLI and admin tools, and these are often
> tightly linked to a version of Directory Server. I think that it's
> easier for us as developers to have this specific linking, than trying
> to spend large amounts of time making something generic that works for
> all versions. 
> 
> For example, this would make the CI workflow much simpler as we just get
> "389-ds-base" and it's a self contained test suite and admin system. No
> need to get the "matching pairs" as the separate workflow would require.
> 
I agree. I vote for merging too.
Also, besides all stuff you and Viktor have mentioned, while developing
something for lib389 (some new feature or fixing the old code) I feel
a natural need to fix 389-ds-base according to my changes.

Thank you for bringing up the topic! :) And for all the info you've
structured.

Simon

> 
> Thanks, I look forward to the discussion and various inputs to the this
> topic. 
> 
> -- 
> Sincerely,
> 
> William Brown
> Software Engineer
> Red Hat, Australia/Brisbane
> 



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: issue 77, issue 79, issue 83

[Simon Pichugin]

Hi team,
please, check out the issues. They were updated recently (or just
waiting for the review):

https://pagure.io/lib389/issue/77
https://pagure.io/lib389/issue/raw/files/6047ac156e06192837271afc2770a83f7f3206400669537bb1d8f43ab7b9a434-Guidelines-for-using-pytest-and-lib389_47541162.html

https://pagure.io/lib389/issue/79
https://pagure.io/lib389/issue/raw/files/7be353523a4a7ad8382a9a98ad778819f5e7557ab1812b9d1e595499ef821244-0001-Issue-79-Fix-replica.py-and-add-tests.patch

https://pagure.io/lib389/issue/83
https://pagure.io/lib389/issue/raw/files/57003067766f1a08da96060e1d51e95583cc5a43ef98d73991fb2576a50501ce-0001-Issue-83-Add-an-util-for-generating-instance-paramet.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 83 - Add an util for generating instance parameters

[Simon Pichugin]

Hi team,
please, review a new patch for big topology refactoring.
I'll add a patch for 389-ds-base tests before the pushing it.

https://pagure.io/lib389/issue/83
https://pagure.io/lib389/issue/raw/files/57003067766f1a08da96060e1d51e95583cc5a43ef98d73991fb2576a50501ce-0001-Issue-83-Add-an-util-for-generating-instance-paramet.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Draft of the big lib389 and pytest guide

[Simon Pichugin]

Hi team,
a new version:

https://pagure.io/lib389/issue/77#comment-451622
https://pagure.io/lib389/issue/raw/files/6047ac156e06192837271afc2770a83f7f3206400669537bb1d8f43ab7b9a434-Guidelines-for-using-pytest-and-lib389_47541162.html

Thanks,
Simon

On Wed, Jul 19, 2017 at 04:31:50PM +0200, Simon Pichugin wrote:
> Hi team,
> 
> https://pagure.io/lib389/issue/77#comment-449299
> https://pagure.io/lib389/issue/raw/2aef109dbf0f23a359c15f209c6c523cebda4faf583125ff62e0a228f8c3b321-Guidelines-for-using-pytest-and-lib389_47541162.html
> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

[Simon Pichugin]

Add enum34 to requirements.txt for py2 compatibility

https://pagure.io/lib389/issue/79
https://pagure.io/lib389/issue/raw/files/7be353523a4a7ad8382a9a98ad778819f5e7557ab1812b9d1e595499ef821244-0001-Issue-79-Fix-replica.py-and-add-tests.patch

On Mon, Jul 31, 2017 at 06:28:05PM +0200, Simon Pichugin wrote:
> New changes regarding _constants.py module.
> - replace REPLICAROLE_* with ReplicaRole(Enum) object
> - change the type of REPLICA_FLAGS_* from str to int
> - remove not used constants REPLICA_TYPE_* and REPLICA_FLAGS_CON
> 
> https://pagure.io/lib389/issue/79
> https://pagure.io/lib389/issue/raw/files/80825f0aee3bcb098b89d442af4526df8b13e2082496de83669dc4220199002e-0001-Issue-79-Fix-replica.py-and-add-tests.patch
> 
> Thanks,
> Simon
> 
> On Thu, Jul 27, 2017 at 03:14:59PM +0200, Simon Pichugin wrote:
> > Hi team,
> > please review a patch that fixes Replicas DSLdapObject.
> > 
> > https://pagure.io/lib389/issue/79
> > https://pagure.io/lib389/issue/raw/files/febe12b17a148405c527ed4938a9ef06c1d5046c9c3070ad32a0770526f33ee0-0001-Issue-79-Fix-replica.py-and-add-tests.patch
> > 
> > Thanks,
> > Simon
> 
> 
> 
> > ___
> > 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> > To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org
> 



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Re: Please review: Issue 79 - Fix replica.py and add tests

[Simon Pichugin]

New changes regarding _constants.py module.
- replace REPLICAROLE_* with ReplicaRole(Enum) object
- change the type of REPLICA_FLAGS_* from str to int
- remove not used constants REPLICA_TYPE_* and REPLICA_FLAGS_CON

https://pagure.io/lib389/issue/79
https://pagure.io/lib389/issue/raw/files/80825f0aee3bcb098b89d442af4526df8b13e2082496de83669dc4220199002e-0001-Issue-79-Fix-replica.py-and-add-tests.patch

Thanks,
Simon

On Thu, Jul 27, 2017 at 03:14:59PM +0200, Simon Pichugin wrote:
> Hi team,
> please review a patch that fixes Replicas DSLdapObject.
> 
> https://pagure.io/lib389/issue/79
> https://pagure.io/lib389/issue/raw/files/febe12b17a148405c527ed4938a9ef06c1d5046c9c3070ad32a0770526f33ee0-0001-Issue-79-Fix-replica.py-and-add-tests.patch
> 
> Thanks,
> Simon



> ___
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org



signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 79 - Fix replica.py and add tests

[Simon Pichugin]

Hi team,
please review a patch that fixes Replicas DSLdapObject.

https://pagure.io/lib389/issue/79
https://pagure.io/lib389/issue/raw/files/febe12b17a148405c527ed4938a9ef06c1d5046c9c3070ad32a0770526f33ee0-0001-Issue-79-Fix-replica.py-and-add-tests.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Draft of the big lib389 and pytest guide

[Simon Pichugin]

Hi team,

https://pagure.io/lib389/issue/77#comment-449299
https://pagure.io/lib389/issue/raw/2aef109dbf0f23a359c15f209c6c523cebda4faf583125ff62e0a228f8c3b321-Guidelines-for-using-pytest-and-lib389_47541162.html

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 49301 - Add one logpipe test case

[Simon Pichugin]

Hi team,
please, review the new patch for suites/ds-tools:

https://pagure.io/389-ds-base/issue/49301
https://pagure.io/389-ds-base/issue/raw/704b8814bfbd0b13c6e04f3c696a633d3fb236bc927e41827f32e4a58768ce7e-0001-Issue-49301-Add-one-logpipe-test-case.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org

[389-devel] Please review: Issue 623 - Add test case and refactor the cleanallruv suite

[Simon Pichugin]

Hi team,
please, review a patch:

https://pagure.io/389-ds-base/issue/623
https://pagure.io/389-ds-base/issue/raw/59ae3de25d0f7dccc880c062c640bf7ef2b3fd1c8b737f51e97bfc75bbcaa9a7-0001-Issue-623-Add-test-case-and-refactor-the-cleanallruv.patch

Thanks,
Simon


signature.asc
Description: PGP signature
___
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-le...@lists.fedoraproject.org