Re: [389-devel] portability issue: scripts expecting /bin/sh to be bash

2014-02-26 Thread Timo Aaltonen
On 24.02.2014 18:41, Rich Megginson wrote:
 On 02/24/2014 03:16 AM, Timo Aaltonen wrote:
 Hi

I noticed that some shell scripts have bashisms in them, on Debian and
 it's derivatives /bin/sh is dash. A quick list of scripts shipped by
 389-ds-base having this issue:

 monitor
 ldif2db
 ldif2ldap
 db2bak
 vlvindex
 dn2rdn
 restoreconfig
 saveconfig
 upgradedb
 suffix2instance
 dbverify

 but since I just ran all the scripts without any options, there might be
 others too that fail with unexpected operator errors etc when ran in a
 real environment. So maybe change all of them to use /bin/bash or
 migrate them to be posix compatible (and somehow test new ones for
 compliance)?


 I think they should be changed to be plain old posix bourne shell
 compatible - lowest common denominator.  There's no reason to use bash
 specific features.
 
 https://fedorahosted.org/389/ticket/47511

Oh right, I remember this ticket now :) Will attach a new patch there.


-- 
t
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] portability issue: scripts expecting /bin/sh to be bash

2014-02-24 Thread Timo Aaltonen

Hi

  I noticed that some shell scripts have bashisms in them, on Debian and
it's derivatives /bin/sh is dash. A quick list of scripts shipped by
389-ds-base having this issue:

monitor
ldif2db
ldif2ldap
db2bak
vlvindex
dn2rdn
restoreconfig
saveconfig
upgradedb
suffix2instance
dbverify

but since I just ran all the scripts without any options, there might be
others too that fail with unexpected operator errors etc when ran in a
real environment. So maybe change all of them to use /bin/bash or
migrate them to be posix compatible (and somehow test new ones for
compliance)?


-- 
t
--
389-devel mailing list
389-devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-devel