[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949 Len Brown len.br...@intel.com changed: What|Removed |Added Status|RESOLVED|CLOSED CC||len.br...@intel.com --- Comment #38 from Len Brown len.br...@intel.com 2009-09-24 21:57:59 --- commit 2a84cb9852f52c0cd1c48bca41a8792d44ad06cc Author: Alexey Starikovskiy astarikovs...@suse.de Date: Sun Aug 30 03:06:14 2009 +0400 ACPI: EC: Merge IRQ and POLL modes shipped in linux-2.6.31-git14 closed -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. -- Come build with us! The BlackBerryreg; Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9#45;12, 2009. Register now#33; http://p.sf.net/sfu/devconf ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949 Len Brown len.br...@intel.com changed: What|Removed |Added CC|len.br...@intel.com |acpi-bugzi...@lists.sourcef ||orge.net -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949
--- Comment #3 from Corrado Zoccolo czocc...@gmail.com 2009-03-27 07:24:36
---
Created an attachment (id=20700)
-- (http://bugzilla.kernel.org/attachment.cgi?id=20700)
dmesg after disabling acpi_ec_burst_enable
I changed acpi_ec_burst_enable to printk and inconditionally return 0, but this
didn't solve the issue (see below my changes). See attached dmesg.
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 2fe1506..8e66e88 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -27,7 +27,7 @@
*/
/* Uncomment next line to get verbose printout */
-/* #define DEBUG */
+#define DEBUG
#include linux/kernel.h
#include linux/module.h
@@ -350,6 +350,8 @@ unlock:
*/
static int acpi_ec_burst_enable(struct acpi_ec *ec)
{
+ printk(KERN_INFO acpi_ec_burst_enable ignored);
+ return 0;
u8 d;
struct transaction t = {.command = ACPI_EC_BURST_ENABLE,
.wdata = NULL, .rdata = d,
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
--
___
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949 --- Comment #4 from Alexey Starikovskiy astarikovs...@suse.de 2009-03-27 11:01:38 --- How is you config differ from default? Interrupt is there, but somehow it appears before we write command to EC in printk There is a synchronization spin lock in this place, but it seems to be ignored. Try to insert some msleep(1) at the beginning of acpi_ec_transaction_unlocked()? [0.370660] ACPI: EC: transaction end [0.370660] ACPI: EC: ~~~ interrupt [0.370660] ACPI: EC: --- status = 0x00 [0.370660] ACPI: EC: ~~~ interrupt [0.370660] ACPI: EC: --- status = 0x00 [0.370660] ACPI: EC: --- status = 0x00 [0.370660] acpi_ec_burst_enable ignored7ACPI: EC: --- status = 0x00 [0.370660] ACPI: EC: transaction start [0.370660] ACPI: EC: --- command = 0x81 [0.370660] ACPI: EC: ~~~ interrupt [0.370660] ACPI: EC: --- status = 0x08 [0.370660] ACPI: EC: --- data = 0x60 [0.870015] ACPI: EC: missing confirmations, switch off interrupt mode. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949
--- Comment #5 from Corrado Zoccolo czocc...@gmail.com 2009-03-27 17:02:42
---
Created an attachment (id=20706)
-- (http://bugzilla.kernel.org/attachment.cgi?id=20706)
dmesg after disabling acpi_ec_burst_enable, with some sleep, + printing flags
sleeps were added as follows:
@@ -255,7 +256,8 @@ static int acpi_ec_transaction_unlocked(struct acpi_ec *ec,
{
unsigned long tmp;
int ret = 0;
-pr_debug(PREFIX transaction start\n);
+pr_my_debug(PREFIX transaction start\n);
+msleep(1);
/* disable GPE during transaction if storm is detected */
if (test_bit(EC_FLAGS_GPE_STORM, ec-flags)) {
clear_bit(EC_FLAGS_GPE_MODE, ec-flags);
@@ -263,6 +265,7 @@ static int acpi_ec_transaction_unlocked(struct acpi_ec *ec,
}
if (EC_FLAGS_MSI)
udelay(ACPI_EC_DELAY);
+msleep(1);
/* start transaction */
spin_lock_irqsave(ec-curr_lock, tmp);
/* following two actions should be kept atomic */
@@ -271,15 +274,21 @@ static int acpi_ec_transaction_unlocked(struct acpi_ec
*ec,
if (ec-curr-command == ACPI_EC_COMMAND_QUERY)
clear_bit(EC_FLAGS_QUERY_PENDING, ec-flags);
spin_unlock_irqrestore(ec-curr_lock, tmp);
+
+msleep(1);
/* if we selected poll mode or failed in GPE-mode do a poll loop */
if (force_poll ||
!test_bit(EC_FLAGS_GPE_MODE, ec-flags) ||
acpi_ec_wait(ec))
ret = ec_poll(ec);
-pr_debug(PREFIX transaction end\n);
+pr_my_debug(PREFIX transaction end\n);
+
+msleep(1);
spin_lock_irqsave(ec-curr_lock, tmp);
ec-curr = NULL;
spin_unlock_irqrestore(ec-curr_lock, tmp);
+
+msleep(1);
if (test_bit(EC_FLAGS_GPE_STORM, ec-flags)) {
/* check if we received SCI during transaction */
ec_check_sci(ec, acpi_ec_read_status(ec));
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching the assignee of the bug.
--
___
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949 Alexey Starikovskiy astarikovs...@suse.de changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|acpi...@kernel-bugs.osdl.or |astarikovs...@suse.de |g | --- Comment #6 from Alexey Starikovskiy astarikovs...@suse.de 2009-03-27 18:01:35 --- Created an attachment (id=20707) -- (http://bugzilla.kernel.org/attachment.cgi?id=20707) change mode after transaction Please check if this patch helps. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949 --- Comment #1 from Corrado Zoccolo czocc...@gmail.com 2009-03-26 21:47:08 --- Created an attachment (id=20695) -- (http://bugzilla.kernel.org/attachment.cgi?id=20695) dmesg with full debugging -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
[Bug 12949] ACPI: EC: missing confirmations, switch off interrupt mode on startup on 2.6.29 kernel
http://bugzilla.kernel.org/show_bug.cgi?id=12949 Alexey Starikovskiy astarikovs...@suse.de changed: What|Removed |Added CC||astarikovs...@suse.de --- Comment #2 from Alexey Starikovskiy astarikovs...@suse.de 2009-03-26 22:31:29 --- Thanks for proper dmesg. Could you please try to disable calls to acpi_ec_burst_enable() in the same ec.c and see if it helps? -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching the assignee of the bug. -- ___ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
