[akka-user] Re: 500 ISE for Client Side Error Bug Report

2015-04-16 Thread André
From https://tools.ietf.org/html/rfc7231#section-4.3.1:

 A payload within a GET request message has no defined semantics;
 sending a payload body on a GET request might cause some existing
 implementations to reject the request.

(Some for HEAD/DELETE/CONNECT)

Perhaps we should relax this requirement to just a warning or make it 
configurable. There seems to be just one other place 
https://github.com/akka/akka/blob/release-2.3-dev/akka-http-core/src/main/scala/akka/http/engine/rendering/HttpRequestRendererFactory.scala#L103
 
where isEntityAccepted is checked.

On Wednesday, April 15, 2015 at 10:37:57 PM UTC+2, Jim Hazen wrote:

 I was originally thinking that this would be inconvenient for ES clients. 
  I could work around that.  However for anyone attempting to build a 
 transparent proxy in front of ES (where they can't control client calls), 
 this would be an impossible to fix solution if a GET with body was 
 forbidden.


-- 
  Read the docs: http://akka.io/docs/
  Check the FAQ: 
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
--- 
You received this message because you are subscribed to the Google Groups Akka 
User List group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at http://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.


[akka-user] Re: 500 ISE for Client Side Error Bug Report

2015-04-15 Thread Jim Hazen
I was originally thinking that this would be inconvenient for ES clients. 
 I could work around that.  However for anyone attempting to build a 
transparent proxy in front of ES (where they can't control client calls), 
this would be an impossible to fix solution if a GET with body was 
forbidden.

-- 
  Read the docs: http://akka.io/docs/
  Check the FAQ: 
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
--- 
You received this message because you are subscribed to the Google Groups Akka 
User List group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at http://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.


[akka-user] Re: 500 ISE for Client Side Error Bug Report

2015-04-15 Thread Jim Hazen
Hmm...

Spray currently allows this and products like ElasticSearch promote GET 
bodies.  This will be a breaking change for me as well once I migrate to 
akka-http.

How opinionated are the developers here?  Can this be more of a guideline 
than a rule? :)

-- 
  Read the docs: http://akka.io/docs/
  Check the FAQ: 
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
--- 
You received this message because you are subscribed to the Google Groups Akka 
User List group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at http://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.


[akka-user] Re: 500 ISE for Client Side Error Bug Report

2015-04-15 Thread André
Hi Kevin,

see 
https://github.com/akka/akka/blob/release-2.3-dev/akka-http-core/src/main/scala/akka/http/model/HttpMessage.scala#L133

Cheers,
André

On Wednesday, April 15, 2015 at 4:51:33 AM UTC+2, Kevin Meredith wrote:

 There's a Github issue, titled, 500 ISE for Client Side Error -  
 https://github.com/akka/akka/issues/17187.

 For the below error, I grepped for 

 cc2 [ERROR] [04/13/2015 16:01:07.698] 
 [cloud-controller-akka.actor.default-dispatcher-27] 
 [ActorSystem(cloud-controller)] Internal server error, sending 500 response
 cc2 java.lang.IllegalArgumentException: requirement failed: Requests with 
 this method must have an empty entity
 cc2 at scala.Predef$.require(Predef.scala:219)

 $ cd akka 
 $ grep -r method must have an empty entity * | grep -vi test | grep -vi spec
 $

 Where does this code exist? 

 Thanks



-- 
  Read the docs: http://akka.io/docs/
  Check the FAQ: 
 http://doc.akka.io/docs/akka/current/additional/faq.html
  Search the archives: https://groups.google.com/group/akka-user
--- 
You received this message because you are subscribed to the Google Groups Akka 
User List group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to akka-user+unsubscr...@googlegroups.com.
To post to this group, send email to akka-user@googlegroups.com.
Visit this group at http://groups.google.com/group/akka-user.
For more options, visit https://groups.google.com/d/optout.