Re: Help on Driver touchkit_ps2.c
On 01/09/2013 02:07 PM, Yves DUF wrote: Hello Mister Mattock. I hope this email will not bother you. It's about the eGalax Touchscreen driver you modify more or less recently. I try to use it on a archos 9 tablet PC, with tricks from that link and others: http://forum.archosfans.com/viewtopic.php?f=50&t=27303 But no matter how hard I try, the touchscreen doesn't work on my archos 9 PC tablet. I use the nomux option, the good serio1 on raw_device, the module is present ... But it's impossible to install the eGalaxy driver, I fall on the "no PS2 mouse present". I've tried this on Ubuntu 12.04 (with both vanilla & recompiled kernel to add touchkit.c module), debian 6.06 (kernel 2.6.32) and Bodhi linux (kernel 3.5) and to version of eGalaxy userland driver (the latest, and an old one 3.07) In fact the touch_kit_detect function failed on the first ps2_command (when it tried to send the 0xA 1 0xE. I'm sorry to bother you, but if you got some clue to make the touch screen work, I would be very gratefull. Yves. from what I remember I just fixed some web addresses(no real code changes). best thing for you to do is try to contact the authors/maintainers of the code so that they can fix their code. I added some Cc's cheers, Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Help on Driver touchkit_ps2.c
On 01/09/2013 02:07 PM, Yves DUF wrote: Hello Mister Mattock. I hope this email will not bother you. It's about the eGalax Touchscreen driver you modify more or less recently. I try to use it on a archos 9 tablet PC, with tricks from that link and others: http://forum.archosfans.com/viewtopic.php?f=50&t=27303 But no matter how hard I try, the touchscreen doesn't work on my archos 9 PC tablet. I use the nomux option, the good serio1 on raw_device, the module is present ... But it's impossible to install the eGalaxy driver, I fall on the "no PS2 mouse present". I've tried this on Ubuntu 12.04 (with both vanilla & recompiled kernel to add touchkit.c module), debian 6.06 (kernel 2.6.32) and Bodhi linux (kernel 3.5) and to version of eGalaxy userland driver (the latest, and an old one 3.07) In fact the touch_kit_detect function failed on the first ps2_command (when it tried to send the 0xA 1 0xE. I'm sorry to bother you, but if you got some clue to make the touch screen work, I would be very gratefull. Yves. from what I remember I just fixed some web addresses(no real code changes). best thing for you to do is try to contact the authors/maintainers of the code so that they can fix their code. I added some Cc's cheers, Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: at arch/x86/kernel/apic/ipi.c:109 default_send_IPI_mask_logical+0xaa/0xe0()
not sure what/where this is coming from.. seen this a few times already. [16870.135447] cfg80211: (525 KHz - 533 KHz @ 4 KHz), (300 mBi, 2000 mBm) [16870.135448] cfg80211: (549 KHz - 560 KHz @ 4 KHz), (300 mBi, 2000 mBm) [16870.135449] cfg80211: (565 KHz - 571 KHz @ 4 KHz), (300 mBi, 2000 mBm) [16870.135451] cfg80211: (5735000 KHz - 5835000 KHz @ 4 KHz), (300 mBi, 3000 mBm) [20138.399483] [ cut here ] [20138.399497] WARNING: at arch/x86/kernel/apic/ipi.c:109 default_send_IPI_mask_logical+0xaa/0xe0() [20138.399500] Hardware name: 0914 [20138.399501] empty IPI mask [20138.399503] Modules linked in: fuse af_packet xt_LOG xt_tcpudp xt_limit xt_pkttype xt_conntrack ipt_REJECT iptable_raw iptable_filter nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 ip_tables x_tables cpufreq_conservative cpufreq_userspace cpufreq_powersave arc4 acpi_cpufreq mperf ath9k snd_hda_codec_hdmi mac80211 snd_hda_codec_conexant snd_hda_intel snd_hda_codec snd_hwdep snd_pcm snd_seq ath9k_common snd_timer ath9k_hw snd_seq_device ath cfg80211 snd coretemp ideapad_laptop sparse_keymap crc32c_intel pcspkr sr_mod cdrom battery ac soundcore rfkill mei iTCO_wdt wmi sg intel_ips iTCO_vendor_support i2c_i801 lpc_ich joydev snd_page_alloc mfd_core microcode autofs4 i915 drm_kms_helper thermal drm ahci i2c_algo_bit libahci ehci_hcd i2c_core libata video usbcore usb_common button processor thermal_sys hwmon scsi_dh_alua scsi_dh_rdac scsi_dh_emc scsi_dh_hp_sw scsi_dh [20138.399579] Pid: 5798, comm: Chrome_CacheThr Not tainted 3.6.0-00722-gbd0d104 #4 [20138.399581] Call Trace: [20138.399589] [] warn_slowpath_common+0x6d/0xa0 [20138.399591] [] ? default_send_IPI_mask_logical+0xaa/0xe0 [20138.399593] [] ? default_send_IPI_mask_logical+0xaa/0xe0 [20138.399596] [] warn_slowpath_fmt+0x2e/0x30 [20138.399598] [] default_send_IPI_mask_logical+0xaa/0xe0 [20138.399603] [] native_send_call_func_ipi+0x43/0x70 [20138.399608] [] smp_call_function_many+0x16d/0x200 [20138.399613] [] ? do_flush_tlb_all+0x40/0x40 [20138.399615] [] native_flush_tlb_others+0x26/0x30 [20138.399617] [] flush_tlb_page+0x55/0xc0 [20138.399620] [] ptep_set_access_flags+0x51/0x60 [20138.399624] [] do_wp_page+0x2b7/0x6e0 [20138.399630] [] ? _raw_spin_lock+0x44/0x50 [20138.399632] [] handle_pte_fault+0x42a/0x7b0 [20138.399634] [] ? arch_flush_lazy_mmu_mode+0x3e/0x60 [20138.399637] [] handle_mm_fault+0x146/0x1c0 [20138.399639] [] ? spurious_fault+0xaa/0xaa [20138.399641] [] do_page_fault+0x116/0x460 [20138.399647] [] ? copy_to_user+0x46/0x60 [20138.399649] [] ? spurious_fault+0xaa/0xaa [20138.399652] [] error_code+0x5a/0x60 [20138.399656] [] ? check_tsc_warp+0x88/0x1a4 [20138.399658] [] ? spurious_fault+0xaa/0xaa [20138.399660] ---[ end trace cf34c8b2f45a88bc ]-- probably can bisect this.. but wont be for a while(2 weeks or so) since I am already bisect something else. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/27/2012 06:56 AM, Daniel Vetter wrote: On Fri, Oct 26, 2012 at 10:57 PM, Justin P. Mattock wrote: :~/drm> git clone git://people.freedesktop.org/~danvet/drm Cloning into 'drm'... remote: Counting objects: 2728390, done. remote: Compressing objects: 100% (418606/418606), done. remote: Total 2728390 (delta 2293727), reused 2717443 (delta 2282880) Receiving objects: 100% (2728390/2728390), 637.95 MiB | 599 KiB/s, done. Resolving deltas: 100% (2293727/2293727), done. warning: remote HEAD refers to nonexistent ref, unable to checkout. so now I have to go on a witch hunt for 600MB's in my system. $ git checkout origin/ilk-wa-pile cool thanks..(not so good at git over here). ... and you have the right branch checked out. No need for pitchforks and witch hunts ;-) -Daniel alright.. putting the pitchfork away for now. Justin P. Mattock ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/27/2012 06:56 AM, Daniel Vetter wrote: On Fri, Oct 26, 2012 at 10:57 PM, Justin P. Mattock wrote: :~/drm> git clone git://people.freedesktop.org/~danvet/drm Cloning into 'drm'... remote: Counting objects: 2728390, done. remote: Compressing objects: 100% (418606/418606), done. remote: Total 2728390 (delta 2293727), reused 2717443 (delta 2282880) Receiving objects: 100% (2728390/2728390), 637.95 MiB | 599 KiB/s, done. Resolving deltas: 100% (2293727/2293727), done. warning: remote HEAD refers to nonexistent ref, unable to checkout. so now I have to go on a witch hunt for 600MB's in my system. $ git checkout origin/ilk-wa-pile cool thanks..(not so good at git over here). ... and you have the right branch checked out. No need for pitchforks and witch hunts ;-) -Daniel alright.. putting the pitchfork away for now. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/27/2012 06:56 AM, Daniel Vetter wrote: > On Fri, Oct 26, 2012 at 10:57 PM, Justin P. Mattock > wrote: >> >> :~/drm> git clone git://people.freedesktop.org/~danvet/drm >> Cloning into 'drm'... >> remote: Counting objects: 2728390, done. >> remote: Compressing objects: 100% (418606/418606), done. >> remote: Total 2728390 (delta 2293727), reused 2717443 (delta 2282880) >> Receiving objects: 100% (2728390/2728390), 637.95 MiB | 599 KiB/s, done. >> Resolving deltas: 100% (2293727/2293727), done. >> warning: remote HEAD refers to nonexistent ref, unable to checkout. >> >> >> so now I have to go on a witch hunt for 600MB's in my system. > > $ git checkout origin/ilk-wa-pile cool thanks..(not so good at git over here). > > ... and you have the right branch checked out. No need for pitchforks > and witch hunts ;-) > -Daniel > alright.. putting the pitchfork away for now. Justin P. Mattock
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/26/2012 01:05 AM, Daniel Vetter wrote: On Fri, Oct 26, 2012 at 6:43 AM, Justin P. Mattock wrote: No worries, it is another ILK hang similar to the ones reported earlier - it just seems the ring stops advancing. Hopefully it is a missing w/a from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile -Chris well if this means building libdrm etc.. then thats not a problem, more time consuming if anything. perhaps an *.rpm that I can test to see? It's not libdrm, the above is just a kernel git tree with a bunch of ironlake workarounds. -Daniel nice.. :~/drm> git clone git://people.freedesktop.org/~danvet/drm Cloning into 'drm'... remote: Counting objects: 2728390, done. remote: Compressing objects: 100% (418606/418606), done. remote: Total 2728390 (delta 2293727), reused 2717443 (delta 2282880) Receiving objects: 100% (2728390/2728390), 637.95 MiB | 599 KiB/s, done. Resolving deltas: 100% (2293727/2293727), done. warning: remote HEAD refers to nonexistent ref, unable to checkout. so now I have to go on a witch hunt for 600MB's in my system. Justin P. Mattock ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/26/2012 01:05 AM, Daniel Vetter wrote: On Fri, Oct 26, 2012 at 6:43 AM, Justin P. Mattock wrote: No worries, it is another ILK hang similar to the ones reported earlier - it just seems the ring stops advancing. Hopefully it is a missing w/a from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile -Chris well if this means building libdrm etc.. then thats not a problem, more time consuming if anything. perhaps an *.rpm that I can test to see? It's not libdrm, the above is just a kernel git tree with a bunch of ironlake workarounds. -Daniel nice.. :~/drm> git clone git://people.freedesktop.org/~danvet/drm Cloning into 'drm'... remote: Counting objects: 2728390, done. remote: Compressing objects: 100% (418606/418606), done. remote: Total 2728390 (delta 2293727), reused 2717443 (delta 2282880) Receiving objects: 100% (2728390/2728390), 637.95 MiB | 599 KiB/s, done. Resolving deltas: 100% (2293727/2293727), done. warning: remote HEAD refers to nonexistent ref, unable to checkout. so now I have to go on a witch hunt for 600MB's in my system. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/26/2012 01:05 AM, Daniel Vetter wrote: > On Fri, Oct 26, 2012 at 6:43 AM, Justin P. Mattock > wrote: >>> >>> No worries, it is another ILK hang similar to the ones reported earlier >>> - it just seems the ring stops advancing. Hopefully it is a missing w/a >>> from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile >>> -Chris >>> >> >> well if this means building libdrm etc.. then thats not a problem, more time >> consuming if anything. perhaps an *.rpm that I can test to see? > > It's not libdrm, the above is just a kernel git tree with a bunch of > ironlake workarounds. > -Daniel > nice.. :~/drm> git clone git://people.freedesktop.org/~danvet/drm Cloning into 'drm'... remote: Counting objects: 2728390, done. remote: Compressing objects: 100% (418606/418606), done. remote: Total 2728390 (delta 2293727), reused 2717443 (delta 2282880) Receiving objects: 100% (2728390/2728390), 637.95 MiB | 599 KiB/s, done. Resolving deltas: 100% (2293727/2293727), done. warning: remote HEAD refers to nonexistent ref, unable to checkout. so now I have to go on a witch hunt for 600MB's in my system. Justin P. Mattock
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/26/2012 01:05 AM, Daniel Vetter wrote: On Fri, Oct 26, 2012 at 6:43 AM, Justin P. Mattock wrote: No worries, it is another ILK hang similar to the ones reported earlier - it just seems the ring stops advancing. Hopefully it is a missing w/a from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile -Chris well if this means building libdrm etc.. then thats not a problem, more time consuming if anything. perhaps an *.rpm that I can test to see? It's not libdrm, the above is just a kernel git tree with a bunch of ironlake workarounds. -Daniel hmm.. then in that case maybe I should pull and run that kernel to see if the crash occurs, before bisecting(if anything). will do once I get time to download. Justin P. Mattock ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/26/2012 01:05 AM, Daniel Vetter wrote: On Fri, Oct 26, 2012 at 6:43 AM, Justin P. Mattock wrote: No worries, it is another ILK hang similar to the ones reported earlier - it just seems the ring stops advancing. Hopefully it is a missing w/a from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile -Chris well if this means building libdrm etc.. then thats not a problem, more time consuming if anything. perhaps an *.rpm that I can test to see? It's not libdrm, the above is just a kernel git tree with a bunch of ironlake workarounds. -Daniel hmm.. then in that case maybe I should pull and run that kernel to see if the crash occurs, before bisecting(if anything). will do once I get time to download. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/26/2012 01:05 AM, Daniel Vetter wrote: > On Fri, Oct 26, 2012 at 6:43 AM, Justin P. Mattock > wrote: >>> >>> No worries, it is another ILK hang similar to the ones reported earlier >>> - it just seems the ring stops advancing. Hopefully it is a missing w/a >>> from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile >>> -Chris >>> >> >> well if this means building libdrm etc.. then thats not a problem, more time >> consuming if anything. perhaps an *.rpm that I can test to see? > > It's not libdrm, the above is just a kernel git tree with a bunch of > ironlake workarounds. > -Daniel > hmm.. then in that case maybe I should pull and run that kernel to see if the crash occurs, before bisecting(if anything). will do once I get time to download. Justin P. Mattock
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/25/2012 01:47 AM, Chris Wilson wrote: On Thu, 25 Oct 2012 10:16:08 +0200, Daniel Vetter wrote: On Thu, Oct 25, 2012 at 7:22 AM, Justin P. Mattock wrote: here is a link to the file..: intel_error_decode http://www.filefactory.com/file/22bypyjhs4mx I haven't figured out how to access this thing. Can you please file a bug report on bugs.freedesktop.org and attach it there? Oops.. I filed with the kernel. maybe can just add a cc's https://bugzilla.kernel.org/show_bug.cgi?id=49571 No worries, it is another ILK hang similar to the ones reported earlier - it just seems the ring stops advancing. Hopefully it is a missing w/a from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile -Chris well if this means building libdrm etc.. then thats not a problem, more time consuming if anything. perhaps an *.rpm that I can test to see? Justin P. Mattock ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/25/2012 01:47 AM, Chris Wilson wrote: On Thu, 25 Oct 2012 10:16:08 +0200, Daniel Vetter wrote: On Thu, Oct 25, 2012 at 7:22 AM, Justin P. Mattock wrote: here is a link to the file..: intel_error_decode http://www.filefactory.com/file/22bypyjhs4mx I haven't figured out how to access this thing. Can you please file a bug report on bugs.freedesktop.org and attach it there? Oops.. I filed with the kernel. maybe can just add a cc's https://bugzilla.kernel.org/show_bug.cgi?id=49571 No worries, it is another ILK hang similar to the ones reported earlier - it just seems the ring stops advancing. Hopefully it is a missing w/a from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile -Chris well if this means building libdrm etc.. then thats not a problem, more time consuming if anything. perhaps an *.rpm that I can test to see? Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On 10/25/2012 01:47 AM, Chris Wilson wrote: > On Thu, 25 Oct 2012 10:16:08 +0200, Daniel Vetter wrote: >> On Thu, Oct 25, 2012 at 7:22 AM, Justin P. Mattock >> wrote: >>> >>> here is a link to the file..: intel_error_decode >>> http://www.filefactory.com/file/22bypyjhs4mx >> >> I haven't figured out how to access this thing. Can you please file a >> bug report on bugs.freedesktop.org and attach it there? Oops.. I filed with the kernel. maybe can just add a cc's https://bugzilla.kernel.org/show_bug.cgi?id=49571 > > No worries, it is another ILK hang similar to the ones reported earlier > - it just seems the ring stops advancing. Hopefully it is a missing w/a > from http://cgit.freedesktop.org/~danvet/drm/log/?h=ilk-wa-pile > -Chris > well if this means building libdrm etc.. then thats not a problem, more time consuming if anything. perhaps an *.rpm that I can test to see? Justin P. Mattock
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On Tue, Oct 23, 2012 at 10:06:52AM -0700, Justin P. Mattock wrote: > This is happening both with MAINLINE and NEXT. > > basically system is running fine, then under load system becomes > really sluggish and unresponsive. I was able to get dmesg of the > error..: > > [ 7745.007008] ath9k :05:00.0 wlan0: disabling VHT as WMM/QoS is > not supported by the AP > [ 7745.007736] wlan0: associate with 68:7f:74:b8:05:82 (try 1/3) > [ 7745.011456] wlan0: RX AssocResp from 68:7f:74:b8:05:82 > (capab=0x411 status=0 aid=5) > [ 7745.011529] wlan0: associated > [ 8120.812482] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer > elapsed... GPU hung > [ 8120.812642] [drm] capturing error event; look for more > information in /debug/dri/0/i915_error_state > [ 8122.328682] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer > elapsed... GPU hung > [ 8122.328845] [drm:i915_reset] *ERROR* GPU hanging too fast, > declaring wedged! > [ 8122.328850] [drm:i915_reset] *ERROR* Failed to reset chip. > > full log is here: http://fpaste.org/7xH8/ > > as for good kernels from what I remember 3.6.0-rc1. I can try a > bisect on this once I get the time. or if anybody has a patch I can > test. Can you please rehand your machine, and then grab the i915_error_state from debugfs? That contains the gpu hang dump we need to diagnose things. And the bisect would obviously be awesome. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch took a bit to trigger, but finally fired off. here is a link to the file..: intel_error_decode http://www.filefactory.com/file/22bypyjhs4mx the file was to large to send to the list.. let me know if you need more info with this. also if anybody has any ideas to trigger this would be appreciated so the bisect can be more precise. right now dont even think its worth it, due to not being able to trigger the crash causing the bisect to go astray and pointing to a wrong commit(which has happened in the past) but then again you never know. Justin P. Mattock ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
On Tue, Oct 23, 2012 at 10:06:52AM -0700, Justin P. Mattock wrote: > This is happening both with MAINLINE and NEXT. > > basically system is running fine, then under load system becomes > really sluggish and unresponsive. I was able to get dmesg of the > error..: > > [ 7745.007008] ath9k :05:00.0 wlan0: disabling VHT as WMM/QoS is > not supported by the AP > [ 7745.007736] wlan0: associate with 68:7f:74:b8:05:82 (try 1/3) > [ 7745.011456] wlan0: RX AssocResp from 68:7f:74:b8:05:82 > (capab=0x411 status=0 aid=5) > [ 7745.011529] wlan0: associated > [ 8120.812482] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer > elapsed... GPU hung > [ 8120.812642] [drm] capturing error event; look for more > information in /debug/dri/0/i915_error_state > [ 8122.328682] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer > elapsed... GPU hung > [ 8122.328845] [drm:i915_reset] *ERROR* GPU hanging too fast, > declaring wedged! > [ 8122.328850] [drm:i915_reset] *ERROR* Failed to reset chip. > > full log is here: http://fpaste.org/7xH8/ > > as for good kernels from what I remember 3.6.0-rc1. I can try a > bisect on this once I get the time. or if anybody has a patch I can > test. Can you please rehand your machine, and then grab the i915_error_state from debugfs? That contains the gpu hang dump we need to diagnose things. And the bisect would obviously be awesome. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch took a bit to trigger, but finally fired off. here is a link to the file..: intel_error_decode http://www.filefactory.com/file/22bypyjhs4mx the file was to large to send to the list.. let me know if you need more info with this. also if anybody has any ideas to trigger this would be appreciated so the bisect can be more precise. right now dont even think its worth it, due to not being able to trigger the crash causing the bisect to go astray and pointing to a wrong commit(which has happened in the past) but then again you never know. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
> > > On Tue, Oct 23, 2012 at 10:06:52AM -0700, Justin P. Mattock wrote: > > This is happening both with MAINLINE and NEXT. > > > > basically system is running fine, then under load system becomes > > really sluggish and unresponsive. I was able to get dmesg of the > > error..: > > > > [ 7745.007008] ath9k :05:00.0 wlan0: disabling VHT as WMM/QoS is > > not supported by the AP > > [ 7745.007736] wlan0: associate with 68:7f:74:b8:05:82 (try 1/3) > > [ 7745.011456] wlan0: RX AssocResp from 68:7f:74:b8:05:82 > > (capab=0x411 status=0 aid=5) > > [ 7745.011529] wlan0: associated > > [ 8120.812482] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer > > elapsed... GPU hung > > [ 8120.812642] [drm] capturing error event; look for more > > information in /debug/dri/0/i915_error_state > > [ 8122.328682] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer > > elapsed... GPU hung > > [ 8122.328845] [drm:i915_reset] *ERROR* GPU hanging too fast, > > declaring wedged! > > [ 8122.328850] [drm:i915_reset] *ERROR* Failed to reset chip. > > > > full log is here: http://fpaste.org/7xH8/ > > > > as for good kernels from what I remember 3.6.0-rc1. I can try a > > bisect on this once I get the time. or if anybody has a patch I can > > test. > > Can you please rehand your machine, and then grab the i915_error_state > from debugfs? That contains the gpu hang dump we need to diagnose things. > > And the bisect would obviously be awesome. > > Thanks, Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch took a bit to trigger, but finally fired off. here is a link to the file..: intel_error_decode http://www.filefactory.com/file/22bypyjhs4mx the file was to large to send to the list.. let me know if you need more info with this. also if anybody has any ideas to trigger this would be appreciated so the bisect can be more precise. right now dont even think its worth it, due to not being able to trigger the crash causing the bisect to go astray and pointing to a wrong commit(which has happened in the past) but then again you never know. Justin P. Mattock
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
This is happening both with MAINLINE and NEXT. basically system is running fine, then under load system becomes really sluggish and unresponsive. I was able to get dmesg of the error..: [ 7745.007008] ath9k :05:00.0 wlan0: disabling VHT as WMM/QoS is not supported by the AP [ 7745.007736] wlan0: associate with 68:7f:74:b8:05:82 (try 1/3) [ 7745.011456] wlan0: RX AssocResp from 68:7f:74:b8:05:82 (capab=0x411 status=0 aid=5) [ 7745.011529] wlan0: associated [ 8120.812482] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung [ 8120.812642] [drm] capturing error event; look for more information in /debug/dri/0/i915_error_state [ 8122.328682] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung [ 8122.328845] [drm:i915_reset] *ERROR* GPU hanging too fast, declaring wedged! [ 8122.328850] [drm:i915_reset] *ERROR* Failed to reset chip. full log is here: http://fpaste.org/7xH8/ as for good kernels from what I remember 3.6.0-rc1. I can try a bisect on this once I get the time. or if anybody has a patch I can test. Justin P. Mattock ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
This is happening both with MAINLINE and NEXT. basically system is running fine, then under load system becomes really sluggish and unresponsive. I was able to get dmesg of the error..: [ 7745.007008] ath9k :05:00.0 wlan0: disabling VHT as WMM/QoS is not supported by the AP [ 7745.007736] wlan0: associate with 68:7f:74:b8:05:82 (try 1/3) [ 7745.011456] wlan0: RX AssocResp from 68:7f:74:b8:05:82 (capab=0x411 status=0 aid=5) [ 7745.011529] wlan0: associated [ 8120.812482] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung [ 8120.812642] [drm] capturing error event; look for more information in /debug/dri/0/i915_error_state [ 8122.328682] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung [ 8122.328845] [drm:i915_reset] *ERROR* GPU hanging too fast, declaring wedged! [ 8122.328850] [drm:i915_reset] *ERROR* Failed to reset chip. full log is here: http://fpaste.org/7xH8/ as for good kernels from what I remember 3.6.0-rc1. I can try a bisect on this once I get the time. or if anybody has a patch I can test. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung
This is happening both with MAINLINE and NEXT. basically system is running fine, then under load system becomes really sluggish and unresponsive. I was able to get dmesg of the error..: [ 7745.007008] ath9k :05:00.0 wlan0: disabling VHT as WMM/QoS is not supported by the AP [ 7745.007736] wlan0: associate with 68:7f:74:b8:05:82 (try 1/3) [ 7745.011456] wlan0: RX AssocResp from 68:7f:74:b8:05:82 (capab=0x411 status=0 aid=5) [ 7745.011529] wlan0: associated [ 8120.812482] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung [ 8120.812642] [drm] capturing error event; look for more information in /debug/dri/0/i915_error_state [ 8122.328682] [drm:i915_hangcheck_hung] *ERROR* Hangcheck timer elapsed... GPU hung [ 8122.328845] [drm:i915_reset] *ERROR* GPU hanging too fast, declaring wedged! [ 8122.328850] [drm:i915_reset] *ERROR* Failed to reset chip. full log is here: http://fpaste.org/7xH8/ as for good kernels from what I remember 3.6.0-rc1. I can try a bisect on this once I get the time. or if anybody has a patch I can test. Justin P. Mattock
[PATCH v2]usb: "ehci-w90x900" Fix a typo and add some whitespace.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes a typo in usb: ehci-w90x900.c as well as adding whitespace to the comment. NOTE: this is a resend due to a typo creating a new typo as well as revision to the original. drivers/usb/host/ehci-w90x900.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c index ec59808..fdd7c48 100644 --- a/drivers/usb/host/ehci-w90x900.c +++ b/drivers/usb/host/ehci-w90x900.c @@ -13,7 +13,7 @@ #include -/*ebable phy0 and phy1 for w90p910*/ +/* enable phy0 and phy1 for w90p910 */ #defineENPHY (0x01<<8) #define PHY0_CTR (0xA4) #define PHY1_CTR (0xA8) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2]usb: "ehci-w90x900" Fix a typo and add some whitespace.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes a typo in usb: ehci-w90x900.c as well as adding whitespace to the comment. NOTE: this is a resend due to a typo creating a new typo as well as revision to the original. drivers/usb/host/ehci-w90x900.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c index ec59808..fdd7c48 100644 --- a/drivers/usb/host/ehci-w90x900.c +++ b/drivers/usb/host/ehci-w90x900.c @@ -13,7 +13,7 @@ #include -/*ebable phy0 and phy1 for w90p910*/ +/* enable phy0 and phy1 for w90p910 */ #defineENPHY (0x01<<8) #define PHY0_CTR (0xA4) #define PHY1_CTR (0xA8) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Linux Kernel
On 10/23/2012 04:32 AM, Dwiastika Peppy wrote: Hai Justin. My name is Peppy I wanna ask you about installing Linux Kernel 2.6.27 I'm a newbie in Linux user I got problem when installed Linux Kernel and this is the problem : *scripts/unifdef.c:209: error: conflicting types for ‘getline’ /usr/include/stdio.h:651: note: previous declaration of ‘getline’ was here make[2]: *** [scripts/unifdef] Error 1 make[1]: *** [__headers] Error 2 make: *** [vmlinux] Error 2* what should i do to solve this problem? maybe you can help me.. Thank you before Justin Best Regards, Peppy from what I remember libc made the change then everything else had to be fixed. this commit is the commit which fixes it: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d15bd1067b1fcb2b7250d22bc0c7c7fea0b759f7 but after thinking this over we probably should have done a get_line || getline(); so old and new can always be working for people using older kernels and in the event of bisecting. but then again we might have more of a bloated kernel if we did this approach to _every_ function definition rename in the kernel. anyway hope this helps with your build experience of the kernel. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2]staging: "ehci-w90x900" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes a typo in staging: "ehci-w90x900" drivers/usb/host/ehci-w90x900.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c index ec59808..a9c28a0 100644 --- a/drivers/usb/host/ehci-w90x900.c +++ b/drivers/usb/host/ehci-w90x900.c @@ -13,7 +13,7 @@ #include -/*ebable phy0 and phy1 for w90p910*/ +/*enable phy0 and phy1 for w90p910*/ #defineENPHY (0x01<<8) #define PHY0_CTR (0xA4) #define PHY1_CTR (0xA8) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2]staging: "winbond" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes a typo in staging: "winbond" drivers/staging/winbond/mds.c |2 +- drivers/staging/winbond/wbhal.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c index 1b8b8ac..43990e8 100644 --- a/drivers/staging/winbond/mds.c +++ b/drivers/staging/winbond/mds.c @@ -315,7 +315,7 @@ static void Mds_HeaderCopy(struct wbsoft_priv *adapter, struct wb35_descriptor * pT00->T00_tx_packet_id = pDes->Descriptor_ID; /* Set packet ID */ pT00->T00_header_length = 24; /* Set header length */ - pT01->T01_retry_abort_ebable = 1; /* 921013 931130.5.h */ + pT01->T01_retry_abort_enable = 1; /* 921013 931130.5.h */ /* Key ID setup */ pT01->T01_wep_id = 0; diff --git a/drivers/staging/winbond/wbhal.h b/drivers/staging/winbond/wbhal.h index 39e84a0..289ee54 100644 --- a/drivers/staging/winbond/wbhal.h +++ b/drivers/staging/winbond/wbhal.h @@ -226,11 +226,11 @@ struct T01_descriptor { u32 T01_add_challenge_text:1; u32 T01_inhibit_crc:1; u32 T01_loop_back_wep_mode:1; - u32 T01_retry_abort_ebable:1; + u32 T01_retry_abort_enable:1; }; #else struct { - u32 T01_retry_abort_ebable:1; + u32 T01_retry_abort_enable:1; u32 T01_loop_back_wep_mode:1; u32 T01_inhibit_crc:1; u32 T01_add_challenge_text:1; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/2]staging: "winbond" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes a typo in staging: "winbond" drivers/staging/winbond/mds.c |2 +- drivers/staging/winbond/wbhal.h |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c index 1b8b8ac..43990e8 100644 --- a/drivers/staging/winbond/mds.c +++ b/drivers/staging/winbond/mds.c @@ -315,7 +315,7 @@ static void Mds_HeaderCopy(struct wbsoft_priv *adapter, struct wb35_descriptor * pT00->T00_tx_packet_id = pDes->Descriptor_ID; /* Set packet ID */ pT00->T00_header_length = 24; /* Set header length */ - pT01->T01_retry_abort_ebable = 1; /* 921013 931130.5.h */ + pT01->T01_retry_abort_enable = 1; /* 921013 931130.5.h */ /* Key ID setup */ pT01->T01_wep_id = 0; diff --git a/drivers/staging/winbond/wbhal.h b/drivers/staging/winbond/wbhal.h index 39e84a0..289ee54 100644 --- a/drivers/staging/winbond/wbhal.h +++ b/drivers/staging/winbond/wbhal.h @@ -226,11 +226,11 @@ struct T01_descriptor { u32 T01_add_challenge_text:1; u32 T01_inhibit_crc:1; u32 T01_loop_back_wep_mode:1; - u32 T01_retry_abort_ebable:1; + u32 T01_retry_abort_enable:1; }; #else struct { - u32 T01_retry_abort_ebable:1; + u32 T01_retry_abort_enable:1; u32 T01_loop_back_wep_mode:1; u32 T01_inhibit_crc:1; u32 T01_add_challenge_text:1; -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 1/2]staging: "ehci-w90x900" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes a typo in staging: "ehci-w90x900" drivers/usb/host/ehci-w90x900.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c index ec59808..a9c28a0 100644 --- a/drivers/usb/host/ehci-w90x900.c +++ b/drivers/usb/host/ehci-w90x900.c @@ -13,7 +13,7 @@ #include -/*ebable phy0 and phy1 for w90p910*/ +/*enable phy0 and phy1 for w90p910*/ #defineENPHY (0x01<<8) #define PHY0_CTR (0xA4) #define PHY1_CTR (0xA8) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]staging "xgifb" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The patch below fixes typos while reading through staging "xgifb". drivers/staging/xgifb/TODO |2 +- drivers/staging/xgifb/vb_setmode.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/xgifb/TODO b/drivers/staging/xgifb/TODO index 13d9bc2..392b29d 100644 --- a/drivers/staging/xgifb/TODO +++ b/drivers/staging/xgifb/TODO @@ -1,4 +1,4 @@ -This drivers still need a lot of work. I can list all cleanups to do but it's +This drivers still needs a lot of work. I can list all cleanups to do but it's going to be long. So, I'm writing "cleanups" and not the list. Arnaud diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index e95a165..c8561a0 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -2501,7 +2501,7 @@ static void XGI_GetVBInfo(unsigned short ModeNo, unsigned short ModeIdIndex, } else { temp = 0x017C; } - } else { /* 3nd party chip */ + } else { /* 3rd party chip */ temp = SetCRT2ToLCD; } @@ -4390,7 +4390,7 @@ static void XGI_SetLCDRegs(unsigned short ModeNo, unsigned short ModeIdIndex, xgifb_reg_and_or(pVBInfo->Part2Port, 0x17, 0xFB, 0x00); xgifb_reg_and_or(pVBInfo->Part2Port, 0x18, 0xDF, 0x00); - /* Customized LCDB Des no add */ + /* Customized LCDB Does not add */ tempbx = 5; LCDBDesPtr = XGI_GetLcdPtr(tempbx, ModeNo, ModeIdIndex, RefreshRateTableIndex, pVBInfo); -- 1.7.9.5 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH]staging "xgifb" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The patch below fixes typos while reading through staging "xgifb". drivers/staging/xgifb/TODO |2 +- drivers/staging/xgifb/vb_setmode.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/xgifb/TODO b/drivers/staging/xgifb/TODO index 13d9bc2..392b29d 100644 --- a/drivers/staging/xgifb/TODO +++ b/drivers/staging/xgifb/TODO @@ -1,4 +1,4 @@ -This drivers still need a lot of work. I can list all cleanups to do but it's +This drivers still needs a lot of work. I can list all cleanups to do but it's going to be long. So, I'm writing "cleanups" and not the list. Arnaud diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index e95a165..c8561a0 100644 --- a/drivers/staging/xgifb/vb_setmode.c +++ b/drivers/staging/xgifb/vb_setmode.c @@ -2501,7 +2501,7 @@ static void XGI_GetVBInfo(unsigned short ModeNo, unsigned short ModeIdIndex, } else { temp = 0x017C; } - } else { /* 3nd party chip */ + } else { /* 3rd party chip */ temp = SetCRT2ToLCD; } @@ -4390,7 +4390,7 @@ static void XGI_SetLCDRegs(unsigned short ModeNo, unsigned short ModeIdIndex, xgifb_reg_and_or(pVBInfo->Part2Port, 0x17, 0xFB, 0x00); xgifb_reg_and_or(pVBInfo->Part2Port, 0x18, 0xDF, 0x00); - /* Customized LCDB Des no add */ + /* Customized LCDB Does not add */ tempbx = 5; LCDBDesPtr = XGI_GetLcdPtr(tempbx, ModeNo, ModeIdIndex, RefreshRateTableIndex, pVBInfo); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]staging "wlan-ng" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "wlan-ng" drivers/staging/wlan-ng/cfg80211.c |4 ++-- drivers/staging/wlan-ng/p80211netdev.c |2 +- drivers/staging/wlan-ng/p80211types.h |2 +- drivers/staging/wlan-ng/prism2fw.c |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index 0970127..e1833bd 100644 --- a/drivers/staging/wlan-ng/cfg80211.c +++ b/drivers/staging/wlan-ng/cfg80211.c @@ -1,7 +1,7 @@ /* cfg80211 Interface for prism2_usb module */ -/* Prism2 channell/frequency/bitrate declarations */ +/* Prism2 channel/frequency/bitrate declarations */ static const struct ieee80211_channel prism2_channels[] = { { .center_freq = 2412 }, { .center_freq = 2417 }, @@ -499,7 +499,7 @@ int prism2_connect(struct wiphy *wiphy, struct net_device *dev, goto exit; } - /* Set the authorisation */ + /* Set the authorization */ if ((sme->auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM) || ((sme->auth_type == NL80211_AUTHTYPE_AUTOMATIC) && !is_wep)) msg_join.authtype.data = P80211ENUM_authalg_opensystem; diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c index 8afb193..a5e2d41 100644 --- a/drivers/staging/wlan-ng/p80211netdev.c +++ b/drivers/staging/wlan-ng/p80211netdev.c @@ -461,7 +461,7 @@ failed: /* * p80211knetdev_set_multicast_list * -* Called from higher lavers whenever there's a need to set/clear +* Called from higher layers whenever there's a need to set/clear * promiscuous mode or rewrite the multicast list. * * Arguments: diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h index f043090..8cb4fc6 100644 --- a/drivers/staging/wlan-ng/p80211types.h +++ b/drivers/staging/wlan-ng/p80211types.h @@ -197,7 +197,7 @@ P80211DID_LSB_ACCESS) /**/ -/* The following structure types are used for the represenation */ +/* The following structure types are used for the representation */ /* of ENUMint type metadata. */ typedef struct p80211enumpair { diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index e22784e..0dfd2a4 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -806,7 +806,7 @@ static int read_cardpda(struct pda *pda, wlandevice_t *wlandev) * * Note also that the start address record, originally an S7 record in * the srec file, is expected in the fw file to be like a data record but -* with a certain address to make it identiable. +* with a certain address to make it identifiable. * * Here's the SREC format that the fw should have come from: * S[37]nnddd...dddcc -- 1.7.9.5 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH]staging "wlan-ng" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "wlan-ng" drivers/staging/wlan-ng/cfg80211.c |4 ++-- drivers/staging/wlan-ng/p80211netdev.c |2 +- drivers/staging/wlan-ng/p80211types.h |2 +- drivers/staging/wlan-ng/prism2fw.c |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c index 0970127..e1833bd 100644 --- a/drivers/staging/wlan-ng/cfg80211.c +++ b/drivers/staging/wlan-ng/cfg80211.c @@ -1,7 +1,7 @@ /* cfg80211 Interface for prism2_usb module */ -/* Prism2 channell/frequency/bitrate declarations */ +/* Prism2 channel/frequency/bitrate declarations */ static const struct ieee80211_channel prism2_channels[] = { { .center_freq = 2412 }, { .center_freq = 2417 }, @@ -499,7 +499,7 @@ int prism2_connect(struct wiphy *wiphy, struct net_device *dev, goto exit; } - /* Set the authorisation */ + /* Set the authorization */ if ((sme->auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM) || ((sme->auth_type == NL80211_AUTHTYPE_AUTOMATIC) && !is_wep)) msg_join.authtype.data = P80211ENUM_authalg_opensystem; diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng/p80211netdev.c index 8afb193..a5e2d41 100644 --- a/drivers/staging/wlan-ng/p80211netdev.c +++ b/drivers/staging/wlan-ng/p80211netdev.c @@ -461,7 +461,7 @@ failed: /* * p80211knetdev_set_multicast_list * -* Called from higher lavers whenever there's a need to set/clear +* Called from higher layers whenever there's a need to set/clear * promiscuous mode or rewrite the multicast list. * * Arguments: diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h index f043090..8cb4fc6 100644 --- a/drivers/staging/wlan-ng/p80211types.h +++ b/drivers/staging/wlan-ng/p80211types.h @@ -197,7 +197,7 @@ P80211DID_LSB_ACCESS) /**/ -/* The following structure types are used for the represenation */ +/* The following structure types are used for the representation */ /* of ENUMint type metadata. */ typedef struct p80211enumpair { diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index e22784e..0dfd2a4 100644 --- a/drivers/staging/wlan-ng/prism2fw.c +++ b/drivers/staging/wlan-ng/prism2fw.c @@ -806,7 +806,7 @@ static int read_cardpda(struct pda *pda, wlandevice_t *wlandev) * * Note also that the start address record, originally an S7 record in * the srec file, is expected in the fw file to be like a data record but -* with a certain address to make it identiable. +* with a certain address to make it identifiable. * * Here's the SREC format that the fw should have come from: * S[37]nnddd...dddcc -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]staging: "wlags49_h25" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "wlags49_h25" drivers/staging/wlags49_h25/Kconfig |2 +- drivers/staging/wlags49_h25/TODO|8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlags49_h25/Kconfig b/drivers/staging/wlags49_h25/Kconfig index bf5664a..dd8dc4d 100644 --- a/drivers/staging/wlags49_h25/Kconfig +++ b/drivers/staging/wlags49_h25/Kconfig @@ -8,4 +8,4 @@ config WLAGS49_H25 Driver for wireless cards using Agere's HERMES II.5 chipset which are identified with Manufacture ID: 0156,0004 The software is a modified version of wl_lkm_722_abg.tar.gz - from the Agere Systems website, addapted for Ubuntu 9.04. + from the Agere Systems website, adapted for Ubuntu 9.04. diff --git a/drivers/staging/wlags49_h25/TODO b/drivers/staging/wlags49_h25/TODO index 94032b6..ec71ad3 100644 --- a/drivers/staging/wlags49_h25/TODO +++ b/drivers/staging/wlags49_h25/TODO @@ -1,4 +1,4 @@ -First of all, the best thing would be that this driver becomes obsolte by +First of all, the best thing would be that this driver becomes obsolete by adding support for Hermes II and Hermes II.5 cards to the existing orinoco driver. The orinoco driver currently only supports Hermes I based cards. Since this will not happen by magic and has not happened until now this @@ -10,11 +10,11 @@ list. TODO: - verify against a Hermes II.5 card - - verify with WPA encription (both with H2 and H2.5 cards) + - verify with WPA encryption (both with H2 and H2.5 cards) - sometimes the card does not initialize correctly, retry mechanisms are build in to catch most cases but not all - once the driver runs it is very stable, but I have the impression - some the crittical sections take to long + some the critical sections take to long - the driver is split into a Hermes II and a Hermes II.5 part, it would be nice to handle both with one module instead of two - review by the wireless developer community @@ -25,7 +25,7 @@ TODO: DONE: - verified against a Hermes II card (Thomson Speedtouch 110 PCMCIA card) - - verified with WEP encription + - verified with WEP encryption Please send any patches or complaints about this driver to Greg Kroah-Hartman and Cc: Henk de Groot -- 1.7.9.5 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH]staging: "wlags49_h25" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "wlags49_h25" drivers/staging/wlags49_h25/Kconfig |2 +- drivers/staging/wlags49_h25/TODO|8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlags49_h25/Kconfig b/drivers/staging/wlags49_h25/Kconfig index bf5664a..dd8dc4d 100644 --- a/drivers/staging/wlags49_h25/Kconfig +++ b/drivers/staging/wlags49_h25/Kconfig @@ -8,4 +8,4 @@ config WLAGS49_H25 Driver for wireless cards using Agere's HERMES II.5 chipset which are identified with Manufacture ID: 0156,0004 The software is a modified version of wl_lkm_722_abg.tar.gz - from the Agere Systems website, addapted for Ubuntu 9.04. + from the Agere Systems website, adapted for Ubuntu 9.04. diff --git a/drivers/staging/wlags49_h25/TODO b/drivers/staging/wlags49_h25/TODO index 94032b6..ec71ad3 100644 --- a/drivers/staging/wlags49_h25/TODO +++ b/drivers/staging/wlags49_h25/TODO @@ -1,4 +1,4 @@ -First of all, the best thing would be that this driver becomes obsolte by +First of all, the best thing would be that this driver becomes obsolete by adding support for Hermes II and Hermes II.5 cards to the existing orinoco driver. The orinoco driver currently only supports Hermes I based cards. Since this will not happen by magic and has not happened until now this @@ -10,11 +10,11 @@ list. TODO: - verify against a Hermes II.5 card - - verify with WPA encription (both with H2 and H2.5 cards) + - verify with WPA encryption (both with H2 and H2.5 cards) - sometimes the card does not initialize correctly, retry mechanisms are build in to catch most cases but not all - once the driver runs it is very stable, but I have the impression - some the crittical sections take to long + some the critical sections take to long - the driver is split into a Hermes II and a Hermes II.5 part, it would be nice to handle both with one module instead of two - review by the wireless developer community @@ -25,7 +25,7 @@ TODO: DONE: - verified against a Hermes II card (Thomson Speedtouch 110 PCMCIA card) - - verified with WEP encription + - verified with WEP encryption Please send any patches or complaints about this driver to Greg Kroah-Hartman and Cc: Henk de Groot -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH V2]staging: "wlags49_h2" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- NOTE: Resend because the original created a new typo in the subject line. The below patch fixes typos while reading through staging "wlags49_h2". drivers/staging/wlags49_h2/README.ubuntu | 10 +- drivers/staging/wlags49_h2/TODO | 10 +- drivers/staging/wlags49_h2/hcf.c | 20 ++-- drivers/staging/wlags49_h2/mdd.h |4 ++-- drivers/staging/wlags49_h2/sta_h2.c |2 +- drivers/staging/wlags49_h2/sta_h25.c |2 +- drivers/staging/wlags49_h2/wl_enc.h |2 +- drivers/staging/wlags49_h2/wl_internal.h |2 +- drivers/staging/wlags49_h2/wl_main.c | 14 +++--- drivers/staging/wlags49_h2/wl_netdev.c | 10 +- drivers/staging/wlags49_h2/wl_pci.c |4 ++-- drivers/staging/wlags49_h2/wl_wext.c | 22 +++--- 12 files changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/wlags49_h2/README.ubuntu b/drivers/staging/wlags49_h2/README.ubuntu index f1483c4..bfad7dc 100644 --- a/drivers/staging/wlags49_h2/README.ubuntu +++ b/drivers/staging/wlags49_h2/README.ubuntu @@ -46,12 +46,12 @@ If you have a card using the HERMES II.5 chip you have to make changes to the Makefile and uncomment -DHERMES25. This will build driver wlags49_h25_cs. -Note: You can detemine the type with command "pccardctrl info" +Note: You can determine the type with command "pccardctrl info" MANIFID: 0156,0002 = HERMES - not supported by this driver MANIFID: 0156,0003 = HERMES II (Wireless B) MANIFID: 0156,0004 = HERMES II.5 (Wireless B/G) -After succesfull compile type command +After successful compile type command sudo make install @@ -93,7 +93,7 @@ have to "open" the device first to get a handle and after "close" no changed; the former ioctl functions are now called before "open" and after "close", which was not expected. One of the problems was enable/ disable of interrupts in the HCF. Interrupt handling starts at "open" -so if a former "ioctl" routinge is called before "open" or after "close" +so if a former "ioctl" routine is called before "open" or after "close" then nothing should be done with interrupt switching in the HCF. Once this was solved most HCF_ASSERTS went away. @@ -120,8 +120,8 @@ include the man page. Even though setting parameters on the module does not work anymore but it provides some information about all the settings. -I have not have personal contact with Agere, but others have. Agere -agreed to make their software available under the BSD licence. +I have no personal contact with Agere, but others have. Agere +agreed to make their software available under the BSD license. This driver is based on the 7.22 version. The following was mailed by Agere to Andrey Borzenkov about this: diff --git a/drivers/staging/wlags49_h2/TODO b/drivers/staging/wlags49_h2/TODO index 94032b6..f1a4561 100644 --- a/drivers/staging/wlags49_h2/TODO +++ b/drivers/staging/wlags49_h2/TODO @@ -1,4 +1,4 @@ -First of all, the best thing would be that this driver becomes obsolte by +First of all, the best thing would be that this driver becomes obsolete by adding support for Hermes II and Hermes II.5 cards to the existing orinoco driver. The orinoco driver currently only supports Hermes I based cards. Since this will not happen by magic and has not happened until now this @@ -10,11 +10,11 @@ list. TODO: - verify against a Hermes II.5 card - - verify with WPA encription (both with H2 and H2.5 cards) + - verify with WPA encryption (both with H2 and H2.5 cards) - sometimes the card does not initialize correctly, retry mechanisms - are build in to catch most cases but not all + are built in to catch most cases but not all - once the driver runs it is very stable, but I have the impression - some the crittical sections take to long + that some of the critical sections take some time. - the driver is split into a Hermes II and a Hermes II.5 part, it would be nice to handle both with one module instead of two - review by the wireless developer community @@ -25,7 +25,7 @@ TODO: DONE: - verified against a Hermes II card (Thomson Speedtouch 110 PCMCIA card) - - verified with WEP encription + - verified with WEP encryption Please send any patches or complaints about this driver to Greg Kroah-Hartman and Cc: Henk de Groot diff --git a/drivers/staging/wlags49_h2/hcf.c b/drivers/staging/wlags49_h2/hcf.c index 4235446..4aac26d 100644 --- a/drivers/staging/wlags49_h2/hcf.c +++ b/drivers/staging/wlags49_h2/hcf.c @@ -508,7 +508,7 @@ HCF_STATIC hcf_16* BASED [ ] = { *- HCF_ACT_INT_FORCE_ON enable in
[PATCH V2]staging: "wlags49_h2" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- NOTE: Resend because the original created a new typo in the subject line. The below patch fixes typos while reading through staging "wlags49_h2". drivers/staging/wlags49_h2/README.ubuntu | 10 +- drivers/staging/wlags49_h2/TODO | 10 +- drivers/staging/wlags49_h2/hcf.c | 20 ++-- drivers/staging/wlags49_h2/mdd.h |4 ++-- drivers/staging/wlags49_h2/sta_h2.c |2 +- drivers/staging/wlags49_h2/sta_h25.c |2 +- drivers/staging/wlags49_h2/wl_enc.h |2 +- drivers/staging/wlags49_h2/wl_internal.h |2 +- drivers/staging/wlags49_h2/wl_main.c | 14 +++--- drivers/staging/wlags49_h2/wl_netdev.c | 10 +- drivers/staging/wlags49_h2/wl_pci.c |4 ++-- drivers/staging/wlags49_h2/wl_wext.c | 22 +++--- 12 files changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/wlags49_h2/README.ubuntu b/drivers/staging/wlags49_h2/README.ubuntu index f1483c4..bfad7dc 100644 --- a/drivers/staging/wlags49_h2/README.ubuntu +++ b/drivers/staging/wlags49_h2/README.ubuntu @@ -46,12 +46,12 @@ If you have a card using the HERMES II.5 chip you have to make changes to the Makefile and uncomment -DHERMES25. This will build driver wlags49_h25_cs. -Note: You can detemine the type with command "pccardctrl info" +Note: You can determine the type with command "pccardctrl info" MANIFID: 0156,0002 = HERMES - not supported by this driver MANIFID: 0156,0003 = HERMES II (Wireless B) MANIFID: 0156,0004 = HERMES II.5 (Wireless B/G) -After succesfull compile type command +After successful compile type command sudo make install @@ -93,7 +93,7 @@ have to "open" the device first to get a handle and after "close" no changed; the former ioctl functions are now called before "open" and after "close", which was not expected. One of the problems was enable/ disable of interrupts in the HCF. Interrupt handling starts at "open" -so if a former "ioctl" routinge is called before "open" or after "close" +so if a former "ioctl" routine is called before "open" or after "close" then nothing should be done with interrupt switching in the HCF. Once this was solved most HCF_ASSERTS went away. @@ -120,8 +120,8 @@ include the man page. Even though setting parameters on the module does not work anymore but it provides some information about all the settings. -I have not have personal contact with Agere, but others have. Agere -agreed to make their software available under the BSD licence. +I have no personal contact with Agere, but others have. Agere +agreed to make their software available under the BSD license. This driver is based on the 7.22 version. The following was mailed by Agere to Andrey Borzenkov about this: diff --git a/drivers/staging/wlags49_h2/TODO b/drivers/staging/wlags49_h2/TODO index 94032b6..f1a4561 100644 --- a/drivers/staging/wlags49_h2/TODO +++ b/drivers/staging/wlags49_h2/TODO @@ -1,4 +1,4 @@ -First of all, the best thing would be that this driver becomes obsolte by +First of all, the best thing would be that this driver becomes obsolete by adding support for Hermes II and Hermes II.5 cards to the existing orinoco driver. The orinoco driver currently only supports Hermes I based cards. Since this will not happen by magic and has not happened until now this @@ -10,11 +10,11 @@ list. TODO: - verify against a Hermes II.5 card - - verify with WPA encription (both with H2 and H2.5 cards) + - verify with WPA encryption (both with H2 and H2.5 cards) - sometimes the card does not initialize correctly, retry mechanisms - are build in to catch most cases but not all + are built in to catch most cases but not all - once the driver runs it is very stable, but I have the impression - some the crittical sections take to long + that some of the critical sections take some time. - the driver is split into a Hermes II and a Hermes II.5 part, it would be nice to handle both with one module instead of two - review by the wireless developer community @@ -25,7 +25,7 @@ TODO: DONE: - verified against a Hermes II card (Thomson Speedtouch 110 PCMCIA card) - - verified with WEP encription + - verified with WEP encryption Please send any patches or complaints about this driver to Greg Kroah-Hartman and Cc: Henk de Groot diff --git a/drivers/staging/wlags49_h2/hcf.c b/drivers/staging/wlags49_h2/hcf.c index 4235446..4aac26d 100644 --- a/drivers/staging/wlags49_h2/hcf.c +++ b/drivers/staging/wlags49_h2/hcf.c @@ -508,7 +508,7 @@ HCF_STATIC hcf_16* BASED [ ] = { *- HCF_ACT_INT_FORCE_ON enable in
[PATCH]NEXT:staging "wlags49_h2" Fix ypos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos while reading through staging "wlags49_h2". drivers/staging/wlags49_h2/README.ubuntu | 10 +- drivers/staging/wlags49_h2/TODO | 10 +- drivers/staging/wlags49_h2/hcf.c | 20 ++-- drivers/staging/wlags49_h2/mdd.h |4 ++-- drivers/staging/wlags49_h2/sta_h2.c |2 +- drivers/staging/wlags49_h2/sta_h25.c |2 +- drivers/staging/wlags49_h2/wl_enc.h |2 +- drivers/staging/wlags49_h2/wl_internal.h |2 +- drivers/staging/wlags49_h2/wl_main.c | 14 +++--- drivers/staging/wlags49_h2/wl_netdev.c | 10 +- drivers/staging/wlags49_h2/wl_pci.c |4 ++-- drivers/staging/wlags49_h2/wl_wext.c | 22 +++--- 12 files changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/wlags49_h2/README.ubuntu b/drivers/staging/wlags49_h2/README.ubuntu index f1483c4..bfad7dc 100644 --- a/drivers/staging/wlags49_h2/README.ubuntu +++ b/drivers/staging/wlags49_h2/README.ubuntu @@ -46,12 +46,12 @@ If you have a card using the HERMES II.5 chip you have to make changes to the Makefile and uncomment -DHERMES25. This will build driver wlags49_h25_cs. -Note: You can detemine the type with command "pccardctrl info" +Note: You can determine the type with command "pccardctrl info" MANIFID: 0156,0002 = HERMES - not supported by this driver MANIFID: 0156,0003 = HERMES II (Wireless B) MANIFID: 0156,0004 = HERMES II.5 (Wireless B/G) -After succesfull compile type command +After successful compile type command sudo make install @@ -93,7 +93,7 @@ have to "open" the device first to get a handle and after "close" no changed; the former ioctl functions are now called before "open" and after "close", which was not expected. One of the problems was enable/ disable of interrupts in the HCF. Interrupt handling starts at "open" -so if a former "ioctl" routinge is called before "open" or after "close" +so if a former "ioctl" routine is called before "open" or after "close" then nothing should be done with interrupt switching in the HCF. Once this was solved most HCF_ASSERTS went away. @@ -120,8 +120,8 @@ include the man page. Even though setting parameters on the module does not work anymore but it provides some information about all the settings. -I have not have personal contact with Agere, but others have. Agere -agreed to make their software available under the BSD licence. +I have no personal contact with Agere, but others have. Agere +agreed to make their software available under the BSD license. This driver is based on the 7.22 version. The following was mailed by Agere to Andrey Borzenkov about this: diff --git a/drivers/staging/wlags49_h2/TODO b/drivers/staging/wlags49_h2/TODO index 94032b6..f1a4561 100644 --- a/drivers/staging/wlags49_h2/TODO +++ b/drivers/staging/wlags49_h2/TODO @@ -1,4 +1,4 @@ -First of all, the best thing would be that this driver becomes obsolte by +First of all, the best thing would be that this driver becomes obsolete by adding support for Hermes II and Hermes II.5 cards to the existing orinoco driver. The orinoco driver currently only supports Hermes I based cards. Since this will not happen by magic and has not happened until now this @@ -10,11 +10,11 @@ list. TODO: - verify against a Hermes II.5 card - - verify with WPA encription (both with H2 and H2.5 cards) + - verify with WPA encryption (both with H2 and H2.5 cards) - sometimes the card does not initialize correctly, retry mechanisms - are build in to catch most cases but not all + are built in to catch most cases but not all - once the driver runs it is very stable, but I have the impression - some the crittical sections take to long + that some of the critical sections take some time. - the driver is split into a Hermes II and a Hermes II.5 part, it would be nice to handle both with one module instead of two - review by the wireless developer community @@ -25,7 +25,7 @@ TODO: DONE: - verified against a Hermes II card (Thomson Speedtouch 110 PCMCIA card) - - verified with WEP encription + - verified with WEP encryption Please send any patches or complaints about this driver to Greg Kroah-Hartman and Cc: Henk de Groot diff --git a/drivers/staging/wlags49_h2/hcf.c b/drivers/staging/wlags49_h2/hcf.c index 4235446..4aac26d 100644 --- a/drivers/staging/wlags49_h2/hcf.c +++ b/drivers/staging/wlags49_h2/hcf.c @@ -508,7 +508,7 @@ HCF_STATIC hcf_16* BASED [ ] = { *- HCF_ACT_INT_FORCE_ON enable interrupt generation by WaveLAN NIC *- HCF_ACT_INT_OFF d
[PATCH]NEXT:staging "wlags49_h2" Fix ypos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos while reading through staging "wlags49_h2". drivers/staging/wlags49_h2/README.ubuntu | 10 +- drivers/staging/wlags49_h2/TODO | 10 +- drivers/staging/wlags49_h2/hcf.c | 20 ++-- drivers/staging/wlags49_h2/mdd.h |4 ++-- drivers/staging/wlags49_h2/sta_h2.c |2 +- drivers/staging/wlags49_h2/sta_h25.c |2 +- drivers/staging/wlags49_h2/wl_enc.h |2 +- drivers/staging/wlags49_h2/wl_internal.h |2 +- drivers/staging/wlags49_h2/wl_main.c | 14 +++--- drivers/staging/wlags49_h2/wl_netdev.c | 10 +- drivers/staging/wlags49_h2/wl_pci.c |4 ++-- drivers/staging/wlags49_h2/wl_wext.c | 22 +++--- 12 files changed, 51 insertions(+), 51 deletions(-) diff --git a/drivers/staging/wlags49_h2/README.ubuntu b/drivers/staging/wlags49_h2/README.ubuntu index f1483c4..bfad7dc 100644 --- a/drivers/staging/wlags49_h2/README.ubuntu +++ b/drivers/staging/wlags49_h2/README.ubuntu @@ -46,12 +46,12 @@ If you have a card using the HERMES II.5 chip you have to make changes to the Makefile and uncomment -DHERMES25. This will build driver wlags49_h25_cs. -Note: You can detemine the type with command "pccardctrl info" +Note: You can determine the type with command "pccardctrl info" MANIFID: 0156,0002 = HERMES - not supported by this driver MANIFID: 0156,0003 = HERMES II (Wireless B) MANIFID: 0156,0004 = HERMES II.5 (Wireless B/G) -After succesfull compile type command +After successful compile type command sudo make install @@ -93,7 +93,7 @@ have to "open" the device first to get a handle and after "close" no changed; the former ioctl functions are now called before "open" and after "close", which was not expected. One of the problems was enable/ disable of interrupts in the HCF. Interrupt handling starts at "open" -so if a former "ioctl" routinge is called before "open" or after "close" +so if a former "ioctl" routine is called before "open" or after "close" then nothing should be done with interrupt switching in the HCF. Once this was solved most HCF_ASSERTS went away. @@ -120,8 +120,8 @@ include the man page. Even though setting parameters on the module does not work anymore but it provides some information about all the settings. -I have not have personal contact with Agere, but others have. Agere -agreed to make their software available under the BSD licence. +I have no personal contact with Agere, but others have. Agere +agreed to make their software available under the BSD license. This driver is based on the 7.22 version. The following was mailed by Agere to Andrey Borzenkov about this: diff --git a/drivers/staging/wlags49_h2/TODO b/drivers/staging/wlags49_h2/TODO index 94032b6..f1a4561 100644 --- a/drivers/staging/wlags49_h2/TODO +++ b/drivers/staging/wlags49_h2/TODO @@ -1,4 +1,4 @@ -First of all, the best thing would be that this driver becomes obsolte by +First of all, the best thing would be that this driver becomes obsolete by adding support for Hermes II and Hermes II.5 cards to the existing orinoco driver. The orinoco driver currently only supports Hermes I based cards. Since this will not happen by magic and has not happened until now this @@ -10,11 +10,11 @@ list. TODO: - verify against a Hermes II.5 card - - verify with WPA encription (both with H2 and H2.5 cards) + - verify with WPA encryption (both with H2 and H2.5 cards) - sometimes the card does not initialize correctly, retry mechanisms - are build in to catch most cases but not all + are built in to catch most cases but not all - once the driver runs it is very stable, but I have the impression - some the crittical sections take to long + that some of the critical sections take some time. - the driver is split into a Hermes II and a Hermes II.5 part, it would be nice to handle both with one module instead of two - review by the wireless developer community @@ -25,7 +25,7 @@ TODO: DONE: - verified against a Hermes II card (Thomson Speedtouch 110 PCMCIA card) - - verified with WEP encription + - verified with WEP encryption Please send any patches or complaints about this driver to Greg Kroah-Hartman and Cc: Henk de Groot diff --git a/drivers/staging/wlags49_h2/hcf.c b/drivers/staging/wlags49_h2/hcf.c index 4235446..4aac26d 100644 --- a/drivers/staging/wlags49_h2/hcf.c +++ b/drivers/staging/wlags49_h2/hcf.c @@ -508,7 +508,7 @@ HCF_STATIC hcf_16* BASED [ ] = { *- HCF_ACT_INT_FORCE_ON enable interrupt generation by WaveLAN NIC *- HCF_ACT_INT_OFF d
[PATCH]NEXT:staging "winbond" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "winbond". drivers/staging/winbond/localpara.h |4 ++-- drivers/staging/winbond/mds.c |2 +- drivers/staging/winbond/mto.c |2 +- drivers/staging/winbond/phy_calibration.c | 14 +++--- drivers/staging/winbond/reg.c |2 +- drivers/staging/winbond/sme_api.h |2 +- drivers/staging/winbond/wb35reg.c |4 ++-- drivers/staging/winbond/wb35tx.c |8 drivers/staging/winbond/wb35tx_s.h|2 +- 9 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/winbond/localpara.h b/drivers/staging/winbond/localpara.h index d798057..84effc4 100644 --- a/drivers/staging/winbond/localpara.h +++ b/drivers/staging/winbond/localpara.h @@ -137,7 +137,7 @@ struct wb_local_para { u8 iPowerSaveMode; /* 0 indicates on, 1 indicates off */ u8 ATIMmode; u8 ExcludeUnencrypted; - /* Unit ime count for the decision to enter PS mode */ + /* Unit time count for the decision to enter PS mode */ u16 CheckCountForPS; u8 boHasTxActivity;/* tx activity has occurred */ u8 boMacPsValid; /* Power save mode obtained from H/W is valid or not */ @@ -187,7 +187,7 @@ struct wb_local_para { u8 reserved7[3]; struct chan_info CurrentChan; /* Current channel no. and channel band. It may be changed by scanning. */ - u8 boHandover; /* Roaming, Hnadover to other AP. */ + u8 boHandover; /* Roaming, Handover to other AP. */ u8 boCCAbusy; u16 CWMax; /* It may not be the real value that H/W used */ diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c index c9f0e8f..1b8b8ac 100644 --- a/drivers/staging/winbond/mds.c +++ b/drivers/staging/winbond/mds.c @@ -569,7 +569,7 @@ Mds_SendComplete(struct wbsoft_priv *adapter, struct T02_descriptor *pT02) unsigned char SendOK = true; u8 RetryCount, TxRate; - if (pT02->T02_IgnoreResult) /* Don't care the result */ + if (pT02->T02_IgnoreResult) /* Don't care about the result */ return; if (pT02->T02_IsLastMpdu) { /* TODO: DTO -- get the retry count and fragment count */ diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c index 1b52ebd..560c0ab 100644 --- a/drivers/staging/winbond/mto.c +++ b/drivers/staging/winbond/mto.c @@ -23,7 +23,7 @@ #include "core.h" /* Declare SQ3 to rate and fragmentation threshold table */ -/* Declare fragmentation thresholds table */ +/* Declare fragmentation threshold table */ #define MTO_MAX_FRAG_TH_LEVELS 5 #define MTO_MAX_DATA_RATE_LEVELS 12 diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/staging/winbond/phy_calibration.c index 77a3fff..cabae34 100644 --- a/drivers/staging/winbond/phy_calibration.c +++ b/drivers/staging/winbond/phy_calibration.c @@ -399,7 +399,7 @@ void _rxadc_dc_offset_cancellation_winbond(struct hw_data *phw_data, u32 frequen val |= MASK_ADC_DC_CAL_STR; hw_set_dxx_reg(phw_data, REG_MODE_CTRL, val); - /* e. The result are shown in "adc_dc_cal_i[8:0] and adc_dc_cal_q[8:0]" */ + /* e. The results are shown in "adc_dc_cal_i[8:0] and adc_dc_cal_q[8:0]" */ #ifdef _DEBUG hw_get_dxx_reg(phw_data, REG_OFFSET_READ, &val); PHY_DEBUG(("[CAL]REG_OFFSET_READ = 0x%08X\n", val)); @@ -720,7 +720,7 @@ u8 _tx_iq_calibration_loop_winbond(struct hw_data *phw_data, for (capture_time = 0; capture_time < 10; capture_time++) { /* * a. Set iqcal_mode[1:0] to 0x2 and set "calib_start" to 0x1 to -*enable "IQ alibration Mode II" +*enable "IQ calibration Mode II" */ reg_mode_ctrl &= ~(MASK_IQCAL_TONE_SEL|MASK_IQCAL_MODE); reg_mode_ctrl &= ~MASK_IQCAL_MODE; @@ -750,7 +750,7 @@ u8 _tx_iq_calibration_loop_winbond(struct hw_data *phw_data, /* * d. Set iqcal_mode[1:0] to 0x3 and set "calib_start" to 0x1 to -*enable "IQ alibration Mode II" +*enable "IQ calibration Mode II" */ /* hw_get_dxx_reg(phw_data, REG_MODE_CTRL, &val); */ hw_get_dxx_reg(phw_data, REG_MODE_CTRL, ®_mode_ctrl); @@ -980,7 +980,7 @@ void _tx_iq_calibration_winbond(struct hw_data *phw_data) phy_set_rf_data(phw_
[PATCH]NEXT:staging "winbond" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "winbond". drivers/staging/winbond/localpara.h |4 ++-- drivers/staging/winbond/mds.c |2 +- drivers/staging/winbond/mto.c |2 +- drivers/staging/winbond/phy_calibration.c | 14 +++--- drivers/staging/winbond/reg.c |2 +- drivers/staging/winbond/sme_api.h |2 +- drivers/staging/winbond/wb35reg.c |4 ++-- drivers/staging/winbond/wb35tx.c |8 drivers/staging/winbond/wb35tx_s.h|2 +- 9 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/winbond/localpara.h b/drivers/staging/winbond/localpara.h index d798057..84effc4 100644 --- a/drivers/staging/winbond/localpara.h +++ b/drivers/staging/winbond/localpara.h @@ -137,7 +137,7 @@ struct wb_local_para { u8 iPowerSaveMode; /* 0 indicates on, 1 indicates off */ u8 ATIMmode; u8 ExcludeUnencrypted; - /* Unit ime count for the decision to enter PS mode */ + /* Unit time count for the decision to enter PS mode */ u16 CheckCountForPS; u8 boHasTxActivity;/* tx activity has occurred */ u8 boMacPsValid; /* Power save mode obtained from H/W is valid or not */ @@ -187,7 +187,7 @@ struct wb_local_para { u8 reserved7[3]; struct chan_info CurrentChan; /* Current channel no. and channel band. It may be changed by scanning. */ - u8 boHandover; /* Roaming, Hnadover to other AP. */ + u8 boHandover; /* Roaming, Handover to other AP. */ u8 boCCAbusy; u16 CWMax; /* It may not be the real value that H/W used */ diff --git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c index c9f0e8f..1b8b8ac 100644 --- a/drivers/staging/winbond/mds.c +++ b/drivers/staging/winbond/mds.c @@ -569,7 +569,7 @@ Mds_SendComplete(struct wbsoft_priv *adapter, struct T02_descriptor *pT02) unsigned char SendOK = true; u8 RetryCount, TxRate; - if (pT02->T02_IgnoreResult) /* Don't care the result */ + if (pT02->T02_IgnoreResult) /* Don't care about the result */ return; if (pT02->T02_IsLastMpdu) { /* TODO: DTO -- get the retry count and fragment count */ diff --git a/drivers/staging/winbond/mto.c b/drivers/staging/winbond/mto.c index 1b52ebd..560c0ab 100644 --- a/drivers/staging/winbond/mto.c +++ b/drivers/staging/winbond/mto.c @@ -23,7 +23,7 @@ #include "core.h" /* Declare SQ3 to rate and fragmentation threshold table */ -/* Declare fragmentation thresholds table */ +/* Declare fragmentation threshold table */ #define MTO_MAX_FRAG_TH_LEVELS 5 #define MTO_MAX_DATA_RATE_LEVELS 12 diff --git a/drivers/staging/winbond/phy_calibration.c b/drivers/staging/winbond/phy_calibration.c index 77a3fff..cabae34 100644 --- a/drivers/staging/winbond/phy_calibration.c +++ b/drivers/staging/winbond/phy_calibration.c @@ -399,7 +399,7 @@ void _rxadc_dc_offset_cancellation_winbond(struct hw_data *phw_data, u32 frequen val |= MASK_ADC_DC_CAL_STR; hw_set_dxx_reg(phw_data, REG_MODE_CTRL, val); - /* e. The result are shown in "adc_dc_cal_i[8:0] and adc_dc_cal_q[8:0]" */ + /* e. The results are shown in "adc_dc_cal_i[8:0] and adc_dc_cal_q[8:0]" */ #ifdef _DEBUG hw_get_dxx_reg(phw_data, REG_OFFSET_READ, &val); PHY_DEBUG(("[CAL]REG_OFFSET_READ = 0x%08X\n", val)); @@ -720,7 +720,7 @@ u8 _tx_iq_calibration_loop_winbond(struct hw_data *phw_data, for (capture_time = 0; capture_time < 10; capture_time++) { /* * a. Set iqcal_mode[1:0] to 0x2 and set "calib_start" to 0x1 to -*enable "IQ alibration Mode II" +*enable "IQ calibration Mode II" */ reg_mode_ctrl &= ~(MASK_IQCAL_TONE_SEL|MASK_IQCAL_MODE); reg_mode_ctrl &= ~MASK_IQCAL_MODE; @@ -750,7 +750,7 @@ u8 _tx_iq_calibration_loop_winbond(struct hw_data *phw_data, /* * d. Set iqcal_mode[1:0] to 0x3 and set "calib_start" to 0x1 to -*enable "IQ alibration Mode II" +*enable "IQ calibration Mode II" */ /* hw_get_dxx_reg(phw_data, REG_MODE_CTRL, &val); */ hw_get_dxx_reg(phw_data, REG_MODE_CTRL, ®_mode_ctrl); @@ -980,7 +980,7 @@ void _tx_iq_calibration_winbond(struct hw_data *phw_data) phy_set_rf_data(phw_
[PATCH 3/3]NEXT:staging "vt6656" Typo rename Embeded to Embedded.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch renames Embeded to Embedded. drivers/staging/vt6656/rf.c | 52 +-- drivers/staging/vt6656/rf.h |2 +- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c index 6205e65..593cdc7 100644 --- a/drivers/staging/vt6656/rf.c +++ b/drivers/staging/vt6656/rf.c @@ -26,7 +26,7 @@ * Date: Feb. 19, 2004 * * Functions: - * IFRFbWriteEmbeded - Embedded write RF register via MAC + * IFRFbWriteEmbedded - Embedded write RF register via MAC * * Revision History: * @@ -722,7 +722,7 @@ const BYTE RFaby11aChannelIndex[200] = { * Return Value: TRUE if succeeded; FALSE if failed. * */ -BOOL IFRFbWriteEmbeded (PSDevice pDevice, DWORD dwData) +BOOL IFRFbWriteEmbedded (PSDevice pDevice, DWORD dwData) { BYTEpbyData[4]; @@ -828,23 +828,23 @@ BOOLbResult = TRUE; case RF_AL2230 : if (pDevice->byCurPwr >= AL2230_PWR_IDX_LEN) return FALSE; -bResult &= IFRFbWriteEmbeded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); +bResult &= IFRFbWriteEmbedded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); if (uRATE <= RATE_11M) -bResult &= IFRFbWriteEmbeded(pDevice, 0x0001B400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x0001B400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); else -bResult &= IFRFbWriteEmbeded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); break; case RF_AL2230S : if (pDevice->byCurPwr >= AL2230_PWR_IDX_LEN) return FALSE; -bResult &= IFRFbWriteEmbeded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); +bResult &= IFRFbWriteEmbedded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); if (uRATE <= RATE_11M) { -bResult &= IFRFbWriteEmbeded(pDevice, 0x040C1400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); -bResult &= IFRFbWriteEmbeded(pDevice, 0x00299B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x040C1400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x00299B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); }else { -bResult &= IFRFbWriteEmbeded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); -bResult &= IFRFbWriteEmbeded(pDevice, 0x00099B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x00099B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); } break; @@ -854,10 +854,10 @@ BOOLbResult = TRUE; DWORD dwMax7230Pwr; if (uRATE <= RATE_11M) { //RobertYu:20060426, for better 11b mask -bResult &= IFRFbWriteEmbeded(pDevice, 0x111BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x111BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); } else { -bResult &= IFRFbWriteEmbeded(pDevice, 0x221BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x221BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); } if (pDevice->byCurPwr > AL7230_PWR_IDX_LEN) return FALSE; @@ -866,7 +866,7 @@ BOOLbResult = TRUE; dwMax7230Pwr = 0x080C0B00 | ( (pDevice->byCurPwr) << 12 ) | (BY_AL7230_REG_LEN << 3 ) | IFREGCTL_REGW; -bResult &= IFRFbWriteEmbeded(pDevice, dwMax7230Pwr); +bResult &= IFRFbWriteEmbedded(pDevice, dwMax7230Pwr); break; } break; @@ -879,7 +879,7 @@ BOOLbResult = TRUE; return FALSE; dwVT3226Pwr = ((0x3F-pDevice->byCurPwr) << 20 ) | ( 0x17 << 8 ) /* Reg7 */ | (BY_VT3226_REG_LEN << 3 ) | IFREGCTL_REGW; -bResult &= IFRFbWriteEmbeded(pDevice, dwVT3226Pwr); +bResult &= IFRFbWriteEmbedded(pDevice, dwVT3226Pwr); break; } @@ -894,27 +894,27 @@ BOOLbResult = TRUE; dwVT
[PATCH 2/3]NEXT:staging "vt6656" Typo rename Caculate to Calculate.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patches renames Caculate to Calculate. drivers/staging/vt6656/baseband.c |4 ++-- drivers/staging/vt6656/baseband.h |2 +- drivers/staging/vt6656/card.c | 28 +-- drivers/staging/vt6656/rxtx.c | 38 ++--- 4 files changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c index b24605a..3855015 100644 --- a/drivers/staging/vt6656/baseband.c +++ b/drivers/staging/vt6656/baseband.c @@ -27,7 +27,7 @@ * * Functions: * BBuGetFrameTime- Calculate data frame transmitting time - * BBvCaculateParameter - Calculate PhyLength, PhyService and Phy Signal parameter for baseband Tx + * BBvCalculateParameter - Calculate PhyLength, PhyService and Phy Signal parameter for baseband Tx * BBbVT3184Init - VIA VT3184 baseband chip init code * BBvLoopbackOn - Turn on BaseBand Loopback mode * BBvLoopbackOff - Turn off BaseBand Loopback mode @@ -757,7 +757,7 @@ BBuGetFrameTime ( * */ void -BBvCaculateParameter ( +BBvCalculateParameter ( PSDevice pDevice, unsigned int cbFrameLength, WORD wRate, diff --git a/drivers/staging/vt6656/baseband.h b/drivers/staging/vt6656/baseband.h index 8db8cd0..844d5a8 100644 --- a/drivers/staging/vt6656/baseband.h +++ b/drivers/staging/vt6656/baseband.h @@ -104,7 +104,7 @@ BBuGetFrameTime( WORD wRate ); -void BBvCaculateParameter(PSDevice pDevice, +void BBvCalculateParameter(PSDevice pDevice, unsigned int cbFrameLength, WORD wRate, BYTE byPacketType, diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index 694e648..826520b 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c @@ -214,7 +214,7 @@ static WORD swGetOFDMControlRate(void *pDeviceHandler, WORD wRateIdx) * */ void -CARDvCaculateOFDMRParameter ( +CARDvCalculateOFDMRParameter ( WORD wRate, BYTE byBBType, PBYTE pbyTxRate, @@ -337,7 +337,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) int i; //RSPINF_b_1 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_1M), PK_TYPE_11B, @@ -347,7 +347,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); ///RSPINF_b_2 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_2M), PK_TYPE_11B, @@ -357,7 +357,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); //RSPINF_b_5 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_5M), PK_TYPE_11B, @@ -367,7 +367,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); //RSPINF_b_11 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_11M), PK_TYPE_11B, @@ -377,55 +377,55 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); //RSPINF_a_6 -CARDvCaculateOFDMRParameter (RATE_6M, +CARDvCalculateOFDMRParameter (RATE_6M, byBBType, &abyTxRate[0], &abyRsvTime[0]); //RSPINF_a_9 -CARDvCaculateOFDMRParameter (RATE_9M, +CARDvCalculateOFDMRParameter (RATE_9M, byBBType, &abyTxRate[1], &abyRsvTime[1]); //RSPINF_a_12 -CARDvCaculateOFDMRParameter (RATE_12M, +CARDvCalculateOFDMRParameter (RATE_12M, byBBType, &abyTxRate[2], &abyRsvTime[2]); //RSPINF_a_18 -CARDvCaculateOFDMRParameter (RATE_18M, +CARDvCalculateOFDMRParameter (RATE_18M, byBBType, &abyTxRate[3], &abyRsvTime[3]); //RSPINF_a_24 -CARDvCaculateOFDMRParameter (RATE_24M, +CARDvCalculateOFDMRParameter (RATE_24M, byBBType, &abyTxRate[4], &abyRsvTime[4]); //RSPINF_a_36 -CARDvCaculateOFDMRParameter (swGetOFDMControlRate(pDevice, RATE_36M), +CARDvCalculateOFDM
[PATCH 3/3]NEXT:staging "vt6656" Typo rename Embeded to Embedded.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch renames Embeded to Embedded. drivers/staging/vt6656/rf.c | 52 +-- drivers/staging/vt6656/rf.h |2 +- 2 files changed, 27 insertions(+), 27 deletions(-) diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c index 6205e65..593cdc7 100644 --- a/drivers/staging/vt6656/rf.c +++ b/drivers/staging/vt6656/rf.c @@ -26,7 +26,7 @@ * Date: Feb. 19, 2004 * * Functions: - * IFRFbWriteEmbeded - Embedded write RF register via MAC + * IFRFbWriteEmbedded - Embedded write RF register via MAC * * Revision History: * @@ -722,7 +722,7 @@ const BYTE RFaby11aChannelIndex[200] = { * Return Value: TRUE if succeeded; FALSE if failed. * */ -BOOL IFRFbWriteEmbeded (PSDevice pDevice, DWORD dwData) +BOOL IFRFbWriteEmbedded (PSDevice pDevice, DWORD dwData) { BYTEpbyData[4]; @@ -828,23 +828,23 @@ BOOLbResult = TRUE; case RF_AL2230 : if (pDevice->byCurPwr >= AL2230_PWR_IDX_LEN) return FALSE; -bResult &= IFRFbWriteEmbeded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); +bResult &= IFRFbWriteEmbedded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); if (uRATE <= RATE_11M) -bResult &= IFRFbWriteEmbeded(pDevice, 0x0001B400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x0001B400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); else -bResult &= IFRFbWriteEmbeded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); break; case RF_AL2230S : if (pDevice->byCurPwr >= AL2230_PWR_IDX_LEN) return FALSE; -bResult &= IFRFbWriteEmbeded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); +bResult &= IFRFbWriteEmbedded(pDevice, dwAL2230PowerTable[pDevice->byCurPwr]); if (uRATE <= RATE_11M) { -bResult &= IFRFbWriteEmbeded(pDevice, 0x040C1400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); -bResult &= IFRFbWriteEmbeded(pDevice, 0x00299B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x040C1400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x00299B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); }else { -bResult &= IFRFbWriteEmbeded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); -bResult &= IFRFbWriteEmbeded(pDevice, 0x00099B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x0005A400+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x00099B00+(BY_AL2230_REG_LEN<<3)+IFREGCTL_REGW); } break; @@ -854,10 +854,10 @@ BOOLbResult = TRUE; DWORD dwMax7230Pwr; if (uRATE <= RATE_11M) { //RobertYu:20060426, for better 11b mask -bResult &= IFRFbWriteEmbeded(pDevice, 0x111BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x111BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); } else { -bResult &= IFRFbWriteEmbeded(pDevice, 0x221BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); +bResult &= IFRFbWriteEmbedded(pDevice, 0x221BB900+(BY_AL7230_REG_LEN<<3)+IFREGCTL_REGW); } if (pDevice->byCurPwr > AL7230_PWR_IDX_LEN) return FALSE; @@ -866,7 +866,7 @@ BOOLbResult = TRUE; dwMax7230Pwr = 0x080C0B00 | ( (pDevice->byCurPwr) << 12 ) | (BY_AL7230_REG_LEN << 3 ) | IFREGCTL_REGW; -bResult &= IFRFbWriteEmbeded(pDevice, dwMax7230Pwr); +bResult &= IFRFbWriteEmbedded(pDevice, dwMax7230Pwr); break; } break; @@ -879,7 +879,7 @@ BOOLbResult = TRUE; return FALSE; dwVT3226Pwr = ((0x3F-pDevice->byCurPwr) << 20 ) | ( 0x17 << 8 ) /* Reg7 */ | (BY_VT3226_REG_LEN << 3 ) | IFREGCTL_REGW; -bResult &= IFRFbWriteEmbeded(pDevice, dwVT3226Pwr); +bResult &= IFRFbWriteEmbedded(pDevice, dwVT3226Pwr); break; } @@ -894,27 +894,27 @@ BOOLbResult = TRUE; dwVT
[PATCH 1/3]NEXT:staging "vt6656" Fix typos in comments, and in a printk message.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- Note: the following three patches need to be applied in order for the correct alignment of the patche(s). The below patch fixes typos found while reading through staging "vt6656". these are only typos in comments and in a couple of printk messages. patches 2 and 3 are actual code typos. if you choose to take them. drivers/staging/vt6656/80211mgr.h |4 ++-- drivers/staging/vt6656/baseband.c |4 ++-- drivers/staging/vt6656/bssdb.c| 18 +- drivers/staging/vt6656/card.c | 10 +- drivers/staging/vt6656/device.h |2 +- drivers/staging/vt6656/dpc.c |2 +- drivers/staging/vt6656/hostap.c | 10 +- drivers/staging/vt6656/int.c |2 +- drivers/staging/vt6656/ioctl.c|4 ++-- drivers/staging/vt6656/iwctl.c|2 +- drivers/staging/vt6656/key.c |4 ++-- drivers/staging/vt6656/main_usb.c | 20 ++-- drivers/staging/vt6656/power.c|2 +- drivers/staging/vt6656/rf.c |4 ++-- drivers/staging/vt6656/rxtx.c | 10 +- drivers/staging/vt6656/tcrc.c |2 +- drivers/staging/vt6656/tcrc.h |2 +- drivers/staging/vt6656/tether.c |4 ++-- drivers/staging/vt6656/tkip.c |2 +- drivers/staging/vt6656/wcmd.c |6 +++--- drivers/staging/vt6656/wctl.c |2 +- drivers/staging/vt6656/wmgr.c | 20 ++-- drivers/staging/vt6656/wpa.c |2 +- drivers/staging/vt6656/wpa2.c |6 +++--- drivers/staging/vt6656/wpactl.c |6 +++--- 25 files changed, 75 insertions(+), 75 deletions(-) diff --git a/drivers/staging/vt6656/80211mgr.h b/drivers/staging/vt6656/80211mgr.h index 515b9c1..e5db73b 100644 --- a/drivers/staging/vt6656/80211mgr.h +++ b/drivers/staging/vt6656/80211mgr.h @@ -191,7 +191,7 @@ // -// Cipher Suite Selectors defiened in 802.11i +// Cipher Suite Selectors defined in 802.11i // #define WLAN_11i_CSS_USE_GROUP 0 #define WLAN_11i_CSS_WEP40 1 @@ -720,7 +720,7 @@ typedef struct tagWLAN_FR_AUTHEN { } WLAN_FR_AUTHEN, *PWLAN_FR_AUTHEN; -// Deauthenication +// Deauthentication typedef struct tagWLAN_FR_DEAUTHEN { unsigned intuType; diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c index 06f27f6..b24605a 100644 --- a/drivers/staging/vt6656/baseband.c +++ b/drivers/staging/vt6656/baseband.c @@ -27,7 +27,7 @@ * * Functions: * BBuGetFrameTime- Calculate data frame transmitting time - * BBvCaculateParameter - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx + * BBvCaculateParameter - Calculate PhyLength, PhyService and Phy Signal parameter for baseband Tx * BBbVT3184Init - VIA VT3184 baseband chip init code * BBvLoopbackOn - Turn on BaseBand Loopback mode * BBvLoopbackOff - Turn off BaseBand Loopback mode @@ -741,7 +741,7 @@ BBuGetFrameTime ( } /* - * Description: Caculate Length, Service, and Signal fields of Phy for Tx + * Description: Calculate Length, Service, and Signal fields of Phy for Tx * * Parameters: * In: diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index 0999367..2ac066d 100644 --- a/drivers/staging/vt6656/bssdb.c +++ b/drivers/staging/vt6656/bssdb.c @@ -226,7 +226,7 @@ PKnownBSS BSSpSearchBSSList(void *hDeviceContext, if (pSelect == NULL) { pSelect = pCurrBSS; } else { -// compare RSSI, select signal strong one +// compare RSSI, select the strongest signal if (pCurrBSS->uRSSI < pSelect->uRSSI) { pSelect = pCurrBSS; } @@ -274,9 +274,9 @@ void BSSvClearBSSList(void *hDeviceContext, BOOL bKeepCurrBSSID) if (pMgmt->sBSSList[ii].bActive && !compare_ether_addr(pMgmt->sBSSList[ii].abyBSSID, pMgmt->abyCurrBSSID)) { - //mike mark: there are two same BSSID in list if that AP is in hidden ssid mode,one 's SSID is null, - // but other's is obvious, so if it acssociate with your STA exactly,you must keep two - // of them! + //mike mark: there are two BSSID's in list. If that AP is in hidden ssid mode, one SSID is null, + // but other's might not be obvious, so if it associate's with your STA, + // you must keep the two of them!! // bKeepCurrBSSID = FALSE; continue; } @@ -489,7 +489,7 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext, } if (pDevice->bUpdateBBVGA) { -// Moniter if RSSI is too strong. +// Monitor if RSSI is too strong. pBSSList-
[PATCH 1/3]NEXT:staging "vt6656" Fix typos in comments, and in a printk message.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- Note: the following three patches need to be applied in order for the correct alignment of the patche(s). The below patch fixes typos found while reading through staging "vt6656". these are only typos in comments and in a couple of printk messages. patches 2 and 3 are actual code typos. if you choose to take them. drivers/staging/vt6656/80211mgr.h |4 ++-- drivers/staging/vt6656/baseband.c |4 ++-- drivers/staging/vt6656/bssdb.c| 18 +- drivers/staging/vt6656/card.c | 10 +- drivers/staging/vt6656/device.h |2 +- drivers/staging/vt6656/dpc.c |2 +- drivers/staging/vt6656/hostap.c | 10 +- drivers/staging/vt6656/int.c |2 +- drivers/staging/vt6656/ioctl.c|4 ++-- drivers/staging/vt6656/iwctl.c|2 +- drivers/staging/vt6656/key.c |4 ++-- drivers/staging/vt6656/main_usb.c | 20 ++-- drivers/staging/vt6656/power.c|2 +- drivers/staging/vt6656/rf.c |4 ++-- drivers/staging/vt6656/rxtx.c | 10 +- drivers/staging/vt6656/tcrc.c |2 +- drivers/staging/vt6656/tcrc.h |2 +- drivers/staging/vt6656/tether.c |4 ++-- drivers/staging/vt6656/tkip.c |2 +- drivers/staging/vt6656/wcmd.c |6 +++--- drivers/staging/vt6656/wctl.c |2 +- drivers/staging/vt6656/wmgr.c | 20 ++-- drivers/staging/vt6656/wpa.c |2 +- drivers/staging/vt6656/wpa2.c |6 +++--- drivers/staging/vt6656/wpactl.c |6 +++--- 25 files changed, 75 insertions(+), 75 deletions(-) diff --git a/drivers/staging/vt6656/80211mgr.h b/drivers/staging/vt6656/80211mgr.h index 515b9c1..e5db73b 100644 --- a/drivers/staging/vt6656/80211mgr.h +++ b/drivers/staging/vt6656/80211mgr.h @@ -191,7 +191,7 @@ // -// Cipher Suite Selectors defiened in 802.11i +// Cipher Suite Selectors defined in 802.11i // #define WLAN_11i_CSS_USE_GROUP 0 #define WLAN_11i_CSS_WEP40 1 @@ -720,7 +720,7 @@ typedef struct tagWLAN_FR_AUTHEN { } WLAN_FR_AUTHEN, *PWLAN_FR_AUTHEN; -// Deauthenication +// Deauthentication typedef struct tagWLAN_FR_DEAUTHEN { unsigned intuType; diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c index 06f27f6..b24605a 100644 --- a/drivers/staging/vt6656/baseband.c +++ b/drivers/staging/vt6656/baseband.c @@ -27,7 +27,7 @@ * * Functions: * BBuGetFrameTime- Calculate data frame transmitting time - * BBvCaculateParameter - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx + * BBvCaculateParameter - Calculate PhyLength, PhyService and Phy Signal parameter for baseband Tx * BBbVT3184Init - VIA VT3184 baseband chip init code * BBvLoopbackOn - Turn on BaseBand Loopback mode * BBvLoopbackOff - Turn off BaseBand Loopback mode @@ -741,7 +741,7 @@ BBuGetFrameTime ( } /* - * Description: Caculate Length, Service, and Signal fields of Phy for Tx + * Description: Calculate Length, Service, and Signal fields of Phy for Tx * * Parameters: * In: diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c index 0999367..2ac066d 100644 --- a/drivers/staging/vt6656/bssdb.c +++ b/drivers/staging/vt6656/bssdb.c @@ -226,7 +226,7 @@ PKnownBSS BSSpSearchBSSList(void *hDeviceContext, if (pSelect == NULL) { pSelect = pCurrBSS; } else { -// compare RSSI, select signal strong one +// compare RSSI, select the strongest signal if (pCurrBSS->uRSSI < pSelect->uRSSI) { pSelect = pCurrBSS; } @@ -274,9 +274,9 @@ void BSSvClearBSSList(void *hDeviceContext, BOOL bKeepCurrBSSID) if (pMgmt->sBSSList[ii].bActive && !compare_ether_addr(pMgmt->sBSSList[ii].abyBSSID, pMgmt->abyCurrBSSID)) { - //mike mark: there are two same BSSID in list if that AP is in hidden ssid mode,one 's SSID is null, - // but other's is obvious, so if it acssociate with your STA exactly,you must keep two - // of them! + //mike mark: there are two BSSID's in list. If that AP is in hidden ssid mode, one SSID is null, + // but other's might not be obvious, so if it associate's with your STA, + // you must keep the two of them!! // bKeepCurrBSSID = FALSE; continue; } @@ -489,7 +489,7 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext, } if (pDevice->bUpdateBBVGA) { -// Moniter if RSSI is too strong. +// Monitor if RSSI is too strong. pBSSList-
[PATCH 2/3]NEXT:staging "vt6656" Typo rename Caculate to Calculate.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patches renames Caculate to Calculate. drivers/staging/vt6656/baseband.c |4 ++-- drivers/staging/vt6656/baseband.h |2 +- drivers/staging/vt6656/card.c | 28 +-- drivers/staging/vt6656/rxtx.c | 38 ++--- 4 files changed, 36 insertions(+), 36 deletions(-) diff --git a/drivers/staging/vt6656/baseband.c b/drivers/staging/vt6656/baseband.c index b24605a..3855015 100644 --- a/drivers/staging/vt6656/baseband.c +++ b/drivers/staging/vt6656/baseband.c @@ -27,7 +27,7 @@ * * Functions: * BBuGetFrameTime- Calculate data frame transmitting time - * BBvCaculateParameter - Calculate PhyLength, PhyService and Phy Signal parameter for baseband Tx + * BBvCalculateParameter - Calculate PhyLength, PhyService and Phy Signal parameter for baseband Tx * BBbVT3184Init - VIA VT3184 baseband chip init code * BBvLoopbackOn - Turn on BaseBand Loopback mode * BBvLoopbackOff - Turn off BaseBand Loopback mode @@ -757,7 +757,7 @@ BBuGetFrameTime ( * */ void -BBvCaculateParameter ( +BBvCalculateParameter ( PSDevice pDevice, unsigned int cbFrameLength, WORD wRate, diff --git a/drivers/staging/vt6656/baseband.h b/drivers/staging/vt6656/baseband.h index 8db8cd0..844d5a8 100644 --- a/drivers/staging/vt6656/baseband.h +++ b/drivers/staging/vt6656/baseband.h @@ -104,7 +104,7 @@ BBuGetFrameTime( WORD wRate ); -void BBvCaculateParameter(PSDevice pDevice, +void BBvCalculateParameter(PSDevice pDevice, unsigned int cbFrameLength, WORD wRate, BYTE byPacketType, diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c index 694e648..826520b 100644 --- a/drivers/staging/vt6656/card.c +++ b/drivers/staging/vt6656/card.c @@ -214,7 +214,7 @@ static WORD swGetOFDMControlRate(void *pDeviceHandler, WORD wRateIdx) * */ void -CARDvCaculateOFDMRParameter ( +CARDvCalculateOFDMRParameter ( WORD wRate, BYTE byBBType, PBYTE pbyTxRate, @@ -337,7 +337,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) int i; //RSPINF_b_1 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_1M), PK_TYPE_11B, @@ -347,7 +347,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); ///RSPINF_b_2 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_2M), PK_TYPE_11B, @@ -357,7 +357,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); //RSPINF_b_5 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_5M), PK_TYPE_11B, @@ -367,7 +367,7 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); //RSPINF_b_11 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, swGetCCKControlRate(pDevice, RATE_11M), PK_TYPE_11B, @@ -377,55 +377,55 @@ void CARDvSetRSPINF(void *pDeviceHandler, BYTE byBBType) ); //RSPINF_a_6 -CARDvCaculateOFDMRParameter (RATE_6M, +CARDvCalculateOFDMRParameter (RATE_6M, byBBType, &abyTxRate[0], &abyRsvTime[0]); //RSPINF_a_9 -CARDvCaculateOFDMRParameter (RATE_9M, +CARDvCalculateOFDMRParameter (RATE_9M, byBBType, &abyTxRate[1], &abyRsvTime[1]); //RSPINF_a_12 -CARDvCaculateOFDMRParameter (RATE_12M, +CARDvCalculateOFDMRParameter (RATE_12M, byBBType, &abyTxRate[2], &abyRsvTime[2]); //RSPINF_a_18 -CARDvCaculateOFDMRParameter (RATE_18M, +CARDvCalculateOFDMRParameter (RATE_18M, byBBType, &abyTxRate[3], &abyRsvTime[3]); //RSPINF_a_24 -CARDvCaculateOFDMRParameter (RATE_24M, +CARDvCalculateOFDMRParameter (RATE_24M, byBBType, &abyTxRate[4], &abyRsvTime[4]); //RSPINF_a_36 -CARDvCaculateOFDMRParameter (swGetOFDMControlRate(pDevice, RATE_36M), +CARDvCalculateOFDM
[PATCH 1/3]NEXT:staging: "vt6655" Fix typos in comments.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- Note: the patches must be applied in order. The patch below is 1 out of 3 that I will be sending out for fixing typos in staging vt6655. This patch mainly focuses on comments; patch 2 and 3 focus on actual code change. drivers/staging/vt6655/80211mgr.h|2 +- drivers/staging/vt6655/baseband.c|8 ++--- drivers/staging/vt6655/bssdb.c |4 +-- drivers/staging/vt6655/card.c|3 +- drivers/staging/vt6655/datarate.c|2 +- drivers/staging/vt6655/device.h |4 +-- drivers/staging/vt6655/device_main.c |6 ++-- drivers/staging/vt6655/dpc.c |2 +- drivers/staging/vt6655/ioctl.c |2 +- drivers/staging/vt6655/iwctl.c |6 ++-- drivers/staging/vt6655/key.c |2 +- drivers/staging/vt6655/mac.c | 12 drivers/staging/vt6655/mac.h |2 +- drivers/staging/vt6655/mib.c |2 +- drivers/staging/vt6655/power.c |2 +- drivers/staging/vt6655/rf.c | 10 +++--- drivers/staging/vt6655/rxtx.c|6 ++-- drivers/staging/vt6655/tcrc.c|2 +- drivers/staging/vt6655/tcrc.h|2 +- drivers/staging/vt6655/vntwifi.c |2 +- drivers/staging/vt6655/wcmd.c|6 ++-- drivers/staging/vt6655/wmgr.c| 56 +- drivers/staging/vt6655/wmgr.h|4 +-- drivers/staging/vt6655/wpa.c |2 +- drivers/staging/vt6655/wpa2.c|8 ++--- drivers/staging/vt6655/wpactl.c |6 ++-- drivers/staging/vt6655/wroute.c |2 +- 27 files changed, 83 insertions(+), 82 deletions(-) diff --git a/drivers/staging/vt6655/80211mgr.h b/drivers/staging/vt6655/80211mgr.h index 3bdab3f..65780f2 100644 --- a/drivers/staging/vt6655/80211mgr.h +++ b/drivers/staging/vt6655/80211mgr.h @@ -186,7 +186,7 @@ // -// Cipher Suite Selectors defiened in 802.11i +// Cipher Suite Selectors defined in 802.11i // #define WLAN_11i_CSS_USE_GROUP 0 #define WLAN_11i_CSS_WEP40 1 diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index e7b93a2..6a06f64 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -28,8 +28,8 @@ * Functions: * BBuGetFrameTime- Calculate data frame transmitting time * BBvCaculateParameter - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx - * BBbReadEmbeded - Embeded read baseband register via MAC - * BBbWriteEmbeded- Embeded write baseband register via MAC + * BBbReadEmbeded - Embedded read baseband register via MAC + * BBbWriteEmbeded- Embedded write baseband register via MAC * BBbIsRegBitsOn - Test if baseband register bits on * BBbIsRegBitsOff- Test if baseband register bits off * BBbVT3253Init - VIA VT3253 baseband chip init code @@ -2001,7 +2001,7 @@ BBvCaculateParameter ( } /* - * Description: Read a byte from BASEBAND, by embeded programming + * Description: Read a byte from BASEBAND, by embedded programming * * Parameters: * In: @@ -2043,7 +2043,7 @@ bool BBbReadEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned ch /* - * Description: Write a Byte to BASEBAND, by embeded programming + * Description: Write a Byte to BASEBAND, by embedded programming * * Parameters: * In: diff --git a/drivers/staging/vt6655/bssdb.c b/drivers/staging/vt6655/bssdb.c index fcffa4f..fe57fb8 100644 --- a/drivers/staging/vt6655/bssdb.c +++ b/drivers/staging/vt6655/bssdb.c @@ -784,8 +784,8 @@ BSSDBbIsSTAInNodeDB(void *pMgmtObject, unsigned char *abyDstAddr, /*+ * * Routine Description: - *Find an empty node and allocated; if no empty found, - *instand used of most inactive one. + *Find an empty node and allocat it; if there is no empty node, + *then use the most inactive one. * * Return Value: *None diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 2721e07..e2785c3 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -1354,7 +1354,8 @@ CARDbSetQuiet ( /* * * Description: - *Do Quiet, It will called by either ISR (after start) or VNTWIFI (before start) so do not need SPINLOCK + *Do Quiet, It will be called by either ISR(after start) + *or VNTWIFI(before start) so we do not need a SPINLOCK * * Parameters: * In: diff --git a/drivers/staging/vt6655/datarate.c b/drivers/staging/vt6655/datarate.c index efbb8f4..b86ec1b 100644 --- a/drivers/staging/vt6655/datarate.c +++ b/drivers/staging/vt6655/datarate.c @@ -126,7 +126,7 @@ DATARATEbyGetRateIdx ( /*+ * * Routine Description: - * Rate fallback Algorithm Implementaion + * Rate fallback Algorithm Implementation * * Parameters: * In: diff --git a/drivers/stag
[PATCH 2/3]NEXT:staging: "vt6655" Typo change *Embeded to *Embedded.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch changes *Embeded to *Embedded in comments and code. Note: I am grepping but grepping is being difficult, if I missed any let me know and I will resubmit. drivers/staging/vt6655/baseband.c| 162 +- drivers/staging/vt6655/baseband.h|8 +- drivers/staging/vt6655/card.c| 36 drivers/staging/vt6655/device_main.c |2 +- drivers/staging/vt6655/rf.c | 80 - drivers/staging/vt6655/rf.h |2 +- 6 files changed, 145 insertions(+), 145 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 6a06f64..9a039ea 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -28,8 +28,8 @@ * Functions: * BBuGetFrameTime- Calculate data frame transmitting time * BBvCaculateParameter - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx - * BBbReadEmbeded - Embedded read baseband register via MAC - * BBbWriteEmbeded- Embedded write baseband register via MAC + * BBbReadEmbedded - Embedded read baseband register via MAC + * BBbWriteEmbedded- Embedded write baseband register via MAC * BBbIsRegBitsOn - Test if baseband register bits on * BBbIsRegBitsOff- Test if baseband register bits off * BBbVT3253Init - VIA VT3253 baseband chip init code @@ -2013,7 +2013,7 @@ BBvCaculateParameter ( * Return Value: true if succeeded; false if failed. * */ -bool BBbReadEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char *pbyData) +bool BBbReadEmbedded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char *pbyData) { unsigned short ww; unsigned char byValue; @@ -2056,7 +2056,7 @@ bool BBbReadEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned ch * Return Value: true if succeeded; false if failed. * */ -bool BBbWriteEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char byData) +bool BBbWriteEmbedded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char byData) { unsigned short ww; unsigned char byValue; @@ -2102,7 +2102,7 @@ bool BBbIsRegBitsOn (unsigned long dwIoBase, unsigned char byBBAddr, unsigned ch { unsigned char byOrgData; -BBbReadEmbeded(dwIoBase, byBBAddr, &byOrgData); +BBbReadEmbedded(dwIoBase, byBBAddr, &byOrgData); return (byOrgData & byTestBits) == byTestBits; } @@ -2125,7 +2125,7 @@ bool BBbIsRegBitsOff (unsigned long dwIoBase, unsigned char byBBAddr, unsigned c { unsigned char byOrgData; -BBbReadEmbeded(dwIoBase, byBBAddr, &byOrgData); +BBbReadEmbedded(dwIoBase, byBBAddr, &byOrgData); return (byOrgData & byTestBits) == 0; } @@ -2155,14 +2155,14 @@ bool BBbVT3253Init (PSDevice pDevice) if (byRFType == RF_RFMD2959) { if (byLocalID <= REV_ID_VT3253_A1) { for (ii = 0; ii < CB_VT3253_INIT_FOR_RFMD; ii++) { -bResult &= BBbWriteEmbeded(dwIoBase,byVT3253InitTab_RFMD[ii][0],byVT3253InitTab_RFMD[ii][1]); +bResult &= BBbWriteEmbedded(dwIoBase,byVT3253InitTab_RFMD[ii][0],byVT3253InitTab_RFMD[ii][1]); } } else { for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++) { -bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_RFMD[ii][0],byVT3253B0_RFMD[ii][1]); +bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_RFMD[ii][0],byVT3253B0_RFMD[ii][1]); } for (ii = 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++) { - bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_AGC4_RFMD2959[ii][0],byVT3253B0_AGC4_RFMD2959[ii][1]); + bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_AGC4_RFMD2959[ii][0],byVT3253B0_AGC4_RFMD2959[ii][1]); } VNSvOutPortD(dwIoBase + MAC_REG_ITRTMSET, 0x23); MACvRegBitsOn(dwIoBase, MAC_REG_PAPEDELAY, BIT0); @@ -2177,10 +2177,10 @@ bool BBbVT3253Init (PSDevice pDevice) pDevice->ldBmThreshold[3] = 0; } else if ((byRFType == RF_AIROHA) || (byRFType == RF_AL2230S) ) { for (ii = 0; ii < CB_VT3253B0_INIT_FOR_AIROHA2230; ii++) { - bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_AIROHA2230[ii][0],byVT3253B0_AIROHA2230[ii][1]); + bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_AIROHA2230[ii][0],byVT3253B0_AIROHA2230[ii][1]); } for (ii = 0; ii < CB_VT3253B0_AGC; ii++) { - bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_AGC[ii][0],byVT3253B0_AGC[ii][1]); + bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_AGC[ii][0],byVT3253B0_AGC[ii][1]); } pDevice->abyBBVGA[0] = 0x1C; pDevice-&
[PATCH 3/3]NEXT:staging: "vt6655" Typo change *Caculate to *Calculate.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch changes *Caculate to *Calculate in comments and code. drivers/staging/vt6655/baseband.c |6 ++-- drivers/staging/vt6655/baseband.h |2 +- drivers/staging/vt6655/card.c | 62 ++--- drivers/staging/vt6655/rxtx.c | 36 ++--- drivers/staging/vt6655/tether.c |4 +-- drivers/staging/vt6655/tkip.c |2 +- 6 files changed, 56 insertions(+), 56 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 9a039ea..8d2c6a7 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -40,7 +40,7 @@ * Revision History: * 06-10-2003 Bryan YC Fan: Re-write codes to support VT3253 spec. * 08-07-2003 Bryan YC Fan: Add MAXIM2827/2825 and RFMD2959 support. - * 08-26-2003 Kyle Hsu: Modify BBuGetFrameTime() and BBvCaculateParameter(). + * 08-26-2003 Kyle Hsu: Modify BBuGetFrameTime() and BBvCalculateParameter(). *cancel the setting of MAC_REG_SOFTPWRCTL on BBbVT3253Init(). *Add the comments. * 09-01-2003 Bryan YC Fan: RF & BB tables updated. @@ -1826,7 +1826,7 @@ BBuGetFrameTime ( } /* - * Description: Caculate Length, Service, and Signal fields of Phy for Tx + * Description: Calculate Length, Service, and Signal fields of Phy for Tx * * Parameters: * In: @@ -1842,7 +1842,7 @@ BBuGetFrameTime ( * */ void -BBvCaculateParameter ( +BBvCalculateParameter ( PSDevice pDevice, unsigned int cbFrameLength, unsigned short wRate, diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h index c6909fa..9b5bc9c 100644 --- a/drivers/staging/vt6655/baseband.h +++ b/drivers/staging/vt6655/baseband.h @@ -97,7 +97,7 @@ BBuGetFrameTime( ); void -BBvCaculateParameter ( +BBvCalculateParameter ( PSDevice pDevice, unsigned int cbFrameLength, unsigned short wRate, diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index b740cf2..319ca48 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -28,9 +28,9 @@ * CARDbIsOFDMinBasicRate - Check if any OFDM rate is in BasicRateSet * CARDvSetLoopbackMode - Set Loopback mode * CARDbSoftwareReset - Sortware reset NIC - * CARDqGetTSFOffset - Caculate TSFOffset + * CARDqGetTSFOffset - Calculate TSFOffset * CARDbGetCurrentTSF - Read Current NIC TSF counter - * CARDqGetNextTBTT - Caculate Next Beacon TSF counter + * CARDqGetNextTBTT - Calculate Next Beacon TSF counter * CARDvSetFirstNextTBTT - Set NIC Beacon time * CARDvUpdateNextTBTT - Sync. NIC Beacon time * CARDbRadioPowerOff - Turn Off NIC Radio Power @@ -100,7 +100,7 @@ const unsigned short cwRXBCNTSFOff[MAX_RATE] = static void -s_vCaculateOFDMRParameter( +s_vCalculateOFDMRParameter( unsigned char byRate, CARD_PHY_TYPE ePHYType, unsigned char *pbyTxRate, @@ -111,7 +111,7 @@ s_vCaculateOFDMRParameter( /*- Export Functions --*/ /* - * Description: Caculate TxRate and RsvTime fields for RSPINF in OFDM mode. + * Description: Calculate TxRate and RsvTime fields for RSPINF in OFDM mode. * * Parameters: * In: @@ -126,7 +126,7 @@ s_vCaculateOFDMRParameter( */ static void -s_vCaculateOFDMRParameter ( +s_vCalculateOFDMRParameter ( unsigned char byRate, CARD_PHY_TYPE ePHYType, unsigned char *pbyTxRate, @@ -251,7 +251,7 @@ s_vSetRSPINF (PSDevice pDevice, CARD_PHY_TYPE ePHYType, void *pvSupportRateIEs, MACvSelectPage1(pDevice->PortOffset); //RSPINF_b_1 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, VNTWIFIbyGetACKTxRate(RATE_1M, pvSupportRateIEs, pvExtSupportRateIEs), PK_TYPE_11B, @@ -262,7 +262,7 @@ s_vSetRSPINF (PSDevice pDevice, CARD_PHY_TYPE ePHYType, void *pvSupportRateIEs, VNSvOutPortD(pDevice->PortOffset + MAC_REG_RSPINF_B_1, MAKEDWORD(wLen,MAKEWORD(bySignal,byServ))); ///RSPINF_b_2 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, VNTWIFIbyGetACKTxRate(RATE_2M, pvSupportRateIEs, pvExtSupportRateIEs), PK_TYPE_11B, @@ -273,7 +273,7 @@ s_vSetRSPINF (PSDevice pDevice, CARD_PHY_TYPE ePHYType, void *pvSupportRateIEs, VNSvOutPortD(pDevice->PortOffset + MAC_REG_RSPINF_B_2, MAKEDWORD(wLen,MAKEWORD(bySignal,byServ))); //RSPINF_b_5 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, VNTWIFIbyGetACKTxRate(RATE_5M, pvSupportRateIEs, pvExtSupportRateIEs), PK_TYP
[PATCH 3/3]NEXT:staging: "vt6655" Typo change *Caculate to *Calculate.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch changes *Caculate to *Calculate in comments and code. drivers/staging/vt6655/baseband.c |6 ++-- drivers/staging/vt6655/baseband.h |2 +- drivers/staging/vt6655/card.c | 62 ++--- drivers/staging/vt6655/rxtx.c | 36 ++--- drivers/staging/vt6655/tether.c |4 +-- drivers/staging/vt6655/tkip.c |2 +- 6 files changed, 56 insertions(+), 56 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 9a039ea..8d2c6a7 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -40,7 +40,7 @@ * Revision History: * 06-10-2003 Bryan YC Fan: Re-write codes to support VT3253 spec. * 08-07-2003 Bryan YC Fan: Add MAXIM2827/2825 and RFMD2959 support. - * 08-26-2003 Kyle Hsu: Modify BBuGetFrameTime() and BBvCaculateParameter(). + * 08-26-2003 Kyle Hsu: Modify BBuGetFrameTime() and BBvCalculateParameter(). *cancel the setting of MAC_REG_SOFTPWRCTL on BBbVT3253Init(). *Add the comments. * 09-01-2003 Bryan YC Fan: RF & BB tables updated. @@ -1826,7 +1826,7 @@ BBuGetFrameTime ( } /* - * Description: Caculate Length, Service, and Signal fields of Phy for Tx + * Description: Calculate Length, Service, and Signal fields of Phy for Tx * * Parameters: * In: @@ -1842,7 +1842,7 @@ BBuGetFrameTime ( * */ void -BBvCaculateParameter ( +BBvCalculateParameter ( PSDevice pDevice, unsigned int cbFrameLength, unsigned short wRate, diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h index c6909fa..9b5bc9c 100644 --- a/drivers/staging/vt6655/baseband.h +++ b/drivers/staging/vt6655/baseband.h @@ -97,7 +97,7 @@ BBuGetFrameTime( ); void -BBvCaculateParameter ( +BBvCalculateParameter ( PSDevice pDevice, unsigned int cbFrameLength, unsigned short wRate, diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index b740cf2..319ca48 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -28,9 +28,9 @@ * CARDbIsOFDMinBasicRate - Check if any OFDM rate is in BasicRateSet * CARDvSetLoopbackMode - Set Loopback mode * CARDbSoftwareReset - Sortware reset NIC - * CARDqGetTSFOffset - Caculate TSFOffset + * CARDqGetTSFOffset - Calculate TSFOffset * CARDbGetCurrentTSF - Read Current NIC TSF counter - * CARDqGetNextTBTT - Caculate Next Beacon TSF counter + * CARDqGetNextTBTT - Calculate Next Beacon TSF counter * CARDvSetFirstNextTBTT - Set NIC Beacon time * CARDvUpdateNextTBTT - Sync. NIC Beacon time * CARDbRadioPowerOff - Turn Off NIC Radio Power @@ -100,7 +100,7 @@ const unsigned short cwRXBCNTSFOff[MAX_RATE] = static void -s_vCaculateOFDMRParameter( +s_vCalculateOFDMRParameter( unsigned char byRate, CARD_PHY_TYPE ePHYType, unsigned char *pbyTxRate, @@ -111,7 +111,7 @@ s_vCaculateOFDMRParameter( /*- Export Functions --*/ /* - * Description: Caculate TxRate and RsvTime fields for RSPINF in OFDM mode. + * Description: Calculate TxRate and RsvTime fields for RSPINF in OFDM mode. * * Parameters: * In: @@ -126,7 +126,7 @@ s_vCaculateOFDMRParameter( */ static void -s_vCaculateOFDMRParameter ( +s_vCalculateOFDMRParameter ( unsigned char byRate, CARD_PHY_TYPE ePHYType, unsigned char *pbyTxRate, @@ -251,7 +251,7 @@ s_vSetRSPINF (PSDevice pDevice, CARD_PHY_TYPE ePHYType, void *pvSupportRateIEs, MACvSelectPage1(pDevice->PortOffset); //RSPINF_b_1 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, VNTWIFIbyGetACKTxRate(RATE_1M, pvSupportRateIEs, pvExtSupportRateIEs), PK_TYPE_11B, @@ -262,7 +262,7 @@ s_vSetRSPINF (PSDevice pDevice, CARD_PHY_TYPE ePHYType, void *pvSupportRateIEs, VNSvOutPortD(pDevice->PortOffset + MAC_REG_RSPINF_B_1, MAKEDWORD(wLen,MAKEWORD(bySignal,byServ))); ///RSPINF_b_2 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, VNTWIFIbyGetACKTxRate(RATE_2M, pvSupportRateIEs, pvExtSupportRateIEs), PK_TYPE_11B, @@ -273,7 +273,7 @@ s_vSetRSPINF (PSDevice pDevice, CARD_PHY_TYPE ePHYType, void *pvSupportRateIEs, VNSvOutPortD(pDevice->PortOffset + MAC_REG_RSPINF_B_2, MAKEDWORD(wLen,MAKEWORD(bySignal,byServ))); //RSPINF_b_5 -BBvCaculateParameter(pDevice, +BBvCalculateParameter(pDevice, 14, VNTWIFIbyGetACKTxRate(RATE_5M, pvSupportRateIEs, pvExtSupportRateIEs), PK_TYP
[PATCH 2/3]NEXT:staging: "vt6655" Typo change *Embeded to *Embedded.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch changes *Embeded to *Embedded in comments and code. Note: I am grepping but grepping is being difficult, if I missed any let me know and I will resubmit. drivers/staging/vt6655/baseband.c| 162 +- drivers/staging/vt6655/baseband.h|8 +- drivers/staging/vt6655/card.c| 36 drivers/staging/vt6655/device_main.c |2 +- drivers/staging/vt6655/rf.c | 80 - drivers/staging/vt6655/rf.h |2 +- 6 files changed, 145 insertions(+), 145 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 6a06f64..9a039ea 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -28,8 +28,8 @@ * Functions: * BBuGetFrameTime- Calculate data frame transmitting time * BBvCaculateParameter - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx - * BBbReadEmbeded - Embedded read baseband register via MAC - * BBbWriteEmbeded- Embedded write baseband register via MAC + * BBbReadEmbedded - Embedded read baseband register via MAC + * BBbWriteEmbedded- Embedded write baseband register via MAC * BBbIsRegBitsOn - Test if baseband register bits on * BBbIsRegBitsOff- Test if baseband register bits off * BBbVT3253Init - VIA VT3253 baseband chip init code @@ -2013,7 +2013,7 @@ BBvCaculateParameter ( * Return Value: true if succeeded; false if failed. * */ -bool BBbReadEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char *pbyData) +bool BBbReadEmbedded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char *pbyData) { unsigned short ww; unsigned char byValue; @@ -2056,7 +2056,7 @@ bool BBbReadEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned ch * Return Value: true if succeeded; false if failed. * */ -bool BBbWriteEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char byData) +bool BBbWriteEmbedded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned char byData) { unsigned short ww; unsigned char byValue; @@ -2102,7 +2102,7 @@ bool BBbIsRegBitsOn (unsigned long dwIoBase, unsigned char byBBAddr, unsigned ch { unsigned char byOrgData; -BBbReadEmbeded(dwIoBase, byBBAddr, &byOrgData); +BBbReadEmbedded(dwIoBase, byBBAddr, &byOrgData); return (byOrgData & byTestBits) == byTestBits; } @@ -2125,7 +2125,7 @@ bool BBbIsRegBitsOff (unsigned long dwIoBase, unsigned char byBBAddr, unsigned c { unsigned char byOrgData; -BBbReadEmbeded(dwIoBase, byBBAddr, &byOrgData); +BBbReadEmbedded(dwIoBase, byBBAddr, &byOrgData); return (byOrgData & byTestBits) == 0; } @@ -2155,14 +2155,14 @@ bool BBbVT3253Init (PSDevice pDevice) if (byRFType == RF_RFMD2959) { if (byLocalID <= REV_ID_VT3253_A1) { for (ii = 0; ii < CB_VT3253_INIT_FOR_RFMD; ii++) { -bResult &= BBbWriteEmbeded(dwIoBase,byVT3253InitTab_RFMD[ii][0],byVT3253InitTab_RFMD[ii][1]); +bResult &= BBbWriteEmbedded(dwIoBase,byVT3253InitTab_RFMD[ii][0],byVT3253InitTab_RFMD[ii][1]); } } else { for (ii = 0; ii < CB_VT3253B0_INIT_FOR_RFMD; ii++) { -bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_RFMD[ii][0],byVT3253B0_RFMD[ii][1]); +bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_RFMD[ii][0],byVT3253B0_RFMD[ii][1]); } for (ii = 0; ii < CB_VT3253B0_AGC_FOR_RFMD2959; ii++) { - bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_AGC4_RFMD2959[ii][0],byVT3253B0_AGC4_RFMD2959[ii][1]); + bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_AGC4_RFMD2959[ii][0],byVT3253B0_AGC4_RFMD2959[ii][1]); } VNSvOutPortD(dwIoBase + MAC_REG_ITRTMSET, 0x23); MACvRegBitsOn(dwIoBase, MAC_REG_PAPEDELAY, BIT0); @@ -2177,10 +2177,10 @@ bool BBbVT3253Init (PSDevice pDevice) pDevice->ldBmThreshold[3] = 0; } else if ((byRFType == RF_AIROHA) || (byRFType == RF_AL2230S) ) { for (ii = 0; ii < CB_VT3253B0_INIT_FOR_AIROHA2230; ii++) { - bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_AIROHA2230[ii][0],byVT3253B0_AIROHA2230[ii][1]); + bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_AIROHA2230[ii][0],byVT3253B0_AIROHA2230[ii][1]); } for (ii = 0; ii < CB_VT3253B0_AGC; ii++) { - bResult &= BBbWriteEmbeded(dwIoBase,byVT3253B0_AGC[ii][0],byVT3253B0_AGC[ii][1]); + bResult &= BBbWriteEmbedded(dwIoBase,byVT3253B0_AGC[ii][0],byVT3253B0_AGC[ii][1]); } pDevice->abyBBVGA[0] = 0x1C; pDevice-&
[PATCH 1/3]NEXT:staging: "vt6655" Fix typos in comments.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- Note: the patches must be applied in order. The patch below is 1 out of 3 that I will be sending out for fixing typos in staging vt6655. This patch mainly focuses on comments; patch 2 and 3 focus on actual code change. drivers/staging/vt6655/80211mgr.h|2 +- drivers/staging/vt6655/baseband.c|8 ++--- drivers/staging/vt6655/bssdb.c |4 +-- drivers/staging/vt6655/card.c|3 +- drivers/staging/vt6655/datarate.c|2 +- drivers/staging/vt6655/device.h |4 +-- drivers/staging/vt6655/device_main.c |6 ++-- drivers/staging/vt6655/dpc.c |2 +- drivers/staging/vt6655/ioctl.c |2 +- drivers/staging/vt6655/iwctl.c |6 ++-- drivers/staging/vt6655/key.c |2 +- drivers/staging/vt6655/mac.c | 12 drivers/staging/vt6655/mac.h |2 +- drivers/staging/vt6655/mib.c |2 +- drivers/staging/vt6655/power.c |2 +- drivers/staging/vt6655/rf.c | 10 +++--- drivers/staging/vt6655/rxtx.c|6 ++-- drivers/staging/vt6655/tcrc.c|2 +- drivers/staging/vt6655/tcrc.h|2 +- drivers/staging/vt6655/vntwifi.c |2 +- drivers/staging/vt6655/wcmd.c|6 ++-- drivers/staging/vt6655/wmgr.c| 56 +- drivers/staging/vt6655/wmgr.h|4 +-- drivers/staging/vt6655/wpa.c |2 +- drivers/staging/vt6655/wpa2.c|8 ++--- drivers/staging/vt6655/wpactl.c |6 ++-- drivers/staging/vt6655/wroute.c |2 +- 27 files changed, 83 insertions(+), 82 deletions(-) diff --git a/drivers/staging/vt6655/80211mgr.h b/drivers/staging/vt6655/80211mgr.h index 3bdab3f..65780f2 100644 --- a/drivers/staging/vt6655/80211mgr.h +++ b/drivers/staging/vt6655/80211mgr.h @@ -186,7 +186,7 @@ // -// Cipher Suite Selectors defiened in 802.11i +// Cipher Suite Selectors defined in 802.11i // #define WLAN_11i_CSS_USE_GROUP 0 #define WLAN_11i_CSS_WEP40 1 diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index e7b93a2..6a06f64 100644 --- a/drivers/staging/vt6655/baseband.c +++ b/drivers/staging/vt6655/baseband.c @@ -28,8 +28,8 @@ * Functions: * BBuGetFrameTime- Calculate data frame transmitting time * BBvCaculateParameter - Caculate PhyLength, PhyService and Phy Signal parameter for baseband Tx - * BBbReadEmbeded - Embeded read baseband register via MAC - * BBbWriteEmbeded- Embeded write baseband register via MAC + * BBbReadEmbeded - Embedded read baseband register via MAC + * BBbWriteEmbeded- Embedded write baseband register via MAC * BBbIsRegBitsOn - Test if baseband register bits on * BBbIsRegBitsOff- Test if baseband register bits off * BBbVT3253Init - VIA VT3253 baseband chip init code @@ -2001,7 +2001,7 @@ BBvCaculateParameter ( } /* - * Description: Read a byte from BASEBAND, by embeded programming + * Description: Read a byte from BASEBAND, by embedded programming * * Parameters: * In: @@ -2043,7 +2043,7 @@ bool BBbReadEmbeded (unsigned long dwIoBase, unsigned char byBBAddr, unsigned ch /* - * Description: Write a Byte to BASEBAND, by embeded programming + * Description: Write a Byte to BASEBAND, by embedded programming * * Parameters: * In: diff --git a/drivers/staging/vt6655/bssdb.c b/drivers/staging/vt6655/bssdb.c index fcffa4f..fe57fb8 100644 --- a/drivers/staging/vt6655/bssdb.c +++ b/drivers/staging/vt6655/bssdb.c @@ -784,8 +784,8 @@ BSSDBbIsSTAInNodeDB(void *pMgmtObject, unsigned char *abyDstAddr, /*+ * * Routine Description: - *Find an empty node and allocated; if no empty found, - *instand used of most inactive one. + *Find an empty node and allocat it; if there is no empty node, + *then use the most inactive one. * * Return Value: *None diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c index 2721e07..e2785c3 100644 --- a/drivers/staging/vt6655/card.c +++ b/drivers/staging/vt6655/card.c @@ -1354,7 +1354,8 @@ CARDbSetQuiet ( /* * * Description: - *Do Quiet, It will called by either ISR (after start) or VNTWIFI (before start) so do not need SPINLOCK + *Do Quiet, It will be called by either ISR(after start) + *or VNTWIFI(before start) so we do not need a SPINLOCK * * Parameters: * In: diff --git a/drivers/staging/vt6655/datarate.c b/drivers/staging/vt6655/datarate.c index efbb8f4..b86ec1b 100644 --- a/drivers/staging/vt6655/datarate.c +++ b/drivers/staging/vt6655/datarate.c @@ -126,7 +126,7 @@ DATARATEbyGetRateIdx ( /*+ * * Routine Description: - * Rate fallback Algorithm Implementaion + * Rate fallback Algorithm Implementation * * Parameters: * In: diff --git a/drivers/stag
[PATCH v2]staging "vme" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- Note:resend with minor adjustments. The below patch fixes typos found while reading through staging "vme" drivers/staging/vme/devices/vme_user.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e25645e..0170788 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -64,13 +64,13 @@ static unsigned int bus_num; * * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't * even support the tsi148 chipset (which has 8 master and 8 slave windows). - * We'll run with this or now as far as possible, however it probably makes + * We'll run with this for now as far as possible, however it probably makes * sense to get rid of the old mappings and just do everything dynamically. * * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as * defined above and try to support at least some of the interface from - * http://www.vmelinux.org/ as an alternative drive can be written providing a - * saner interface later. + * http://www.vmelinux.org/ as an alternative the driver can be written + * providing a saner interface later. * * The vmelinux.org driver never supported slave images, the devices reserved * for slaves were repurposed to support all 8 master images on the UniverseII! @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count, } /* - * We are going ot alloc a page during init per window for small transfers. + * We are going to alloc a page during init per window for small transfers. * Small transfers will go user space -> buffer -> VME. Larger (more than a * page) transfers will lock the user space buffer into memory and then * transfer the data directly from the user space buffers out to VME. -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH v2]staging "vme" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- Note:resend with minor adjustments. The below patch fixes typos found while reading through staging "vme" drivers/staging/vme/devices/vme_user.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e25645e..0170788 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -64,13 +64,13 @@ static unsigned int bus_num; * * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't * even support the tsi148 chipset (which has 8 master and 8 slave windows). - * We'll run with this or now as far as possible, however it probably makes + * We'll run with this for now as far as possible, however it probably makes * sense to get rid of the old mappings and just do everything dynamically. * * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as * defined above and try to support at least some of the interface from - * http://www.vmelinux.org/ as an alternative drive can be written providing a - * saner interface later. + * http://www.vmelinux.org/ as an alternative the driver can be written + * providing a saner interface later. * * The vmelinux.org driver never supported slave images, the devices reserved * for slaves were repurposed to support all 8 master images on the UniverseII! @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count, } /* - * We are going ot alloc a page during init per window for small transfers. + * We are going to alloc a page during init per window for small transfers. * Small transfers will go user space -> buffer -> VME. Larger (more than a * page) transfers will lock the user space buffer into memory and then * transfer the data directly from the user space buffers out to VME. -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]staging "vme" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "vme" drivers/staging/vme/devices/Kconfig|2 +- drivers/staging/vme/devices/vme_user.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig index d0cab17..5504ab4 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -5,7 +5,7 @@ config VME_USER depends on STAGING help If you say Y here you want to be able to access a limited number of - VME windows in a manner at least semi-compatible with the interface + VME windows in a manner atleast semi-compatible with the interface provided with the original driver at http://vmelinux.org/. config VME_PIO2 diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e25645e..46f60d6 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -64,12 +64,12 @@ static unsigned int bus_num; * * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't * even support the tsi148 chipset (which has 8 master and 8 slave windows). - * We'll run with this or now as far as possible, however it probably makes + * We'll run with this for now as far as possible, however it probably makes * sense to get rid of the old mappings and just do everything dynamically. * * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as * defined above and try to support at least some of the interface from - * http://www.vmelinux.org/ as an alternative drive can be written providing a + * http://www.vmelinux.org/ as an alternative the driver can be written providing a * saner interface later. * * The vmelinux.org driver never supported slave images, the devices reserved @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count, } /* - * We are going ot alloc a page during init per window for small transfers. + * We are going to alloc a page during init per window for small transfers. * Small transfers will go user space -> buffer -> VME. Larger (more than a * page) transfers will lock the user space buffer into memory and then * transfer the data directly from the user space buffers out to VME. -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH]staging "vme" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "vme" drivers/staging/vme/devices/Kconfig|2 +- drivers/staging/vme/devices/vme_user.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vme/devices/Kconfig b/drivers/staging/vme/devices/Kconfig index d0cab17..5504ab4 100644 --- a/drivers/staging/vme/devices/Kconfig +++ b/drivers/staging/vme/devices/Kconfig @@ -5,7 +5,7 @@ config VME_USER depends on STAGING help If you say Y here you want to be able to access a limited number of - VME windows in a manner at least semi-compatible with the interface + VME windows in a manner atleast semi-compatible with the interface provided with the original driver at http://vmelinux.org/. config VME_PIO2 diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c index e25645e..46f60d6 100644 --- a/drivers/staging/vme/devices/vme_user.c +++ b/drivers/staging/vme/devices/vme_user.c @@ -64,12 +64,12 @@ static unsigned int bus_num; * * However the VME driver at http://www.vmelinux.org/ is rather old and doesn't * even support the tsi148 chipset (which has 8 master and 8 slave windows). - * We'll run with this or now as far as possible, however it probably makes + * We'll run with this for now as far as possible, however it probably makes * sense to get rid of the old mappings and just do everything dynamically. * * So for now, we'll restrict the driver to providing 4 masters and 4 slaves as * defined above and try to support at least some of the interface from - * http://www.vmelinux.org/ as an alternative drive can be written providing a + * http://www.vmelinux.org/ as an alternative the driver can be written providing a * saner interface later. * * The vmelinux.org driver never supported slave images, the devices reserved @@ -242,7 +242,7 @@ static ssize_t resource_to_user(int minor, char __user *buf, size_t count, } /* - * We are going ot alloc a page during init per window for small transfers. + * We are going to alloc a page during init per window for small transfers. * Small transfers will go user space -> buffer -> VME. Larger (more than a * page) transfers will lock the user space buffer into memory and then * transfer the data directly from the user space buffers out to VME. -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: using dd to prepare a file to be written to memory blocks(remove padding)
On 08/09/2012 04:46 AM, Jann Horn wrote: Uh, you basically want to restore a partition image into a bigger partition? In that case, just write the image to the partition and leave the rest as it is. In order to extend the filesystem to the whole partition, you need to alter fs metadata, so dd is the wrong tool for that - you might want to have a look at resize2fs or so. Sorry in case I got you totally wrong. everybody thanks for the help and info with this.. as for the issue I will try the suggestions above to see where it takes me. altering the fs metadata is what needs to happen because once the file is uploaded to the block of memory the target wont work unless the file is prepared properly(whitespace at the end of the file breaks the target when it reads that block of memory with the info). cheers!
[PATCH v2]staging "usbip" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- NOTE:I see *rc1 in the git web log, so hopefully its ok to send out. The below patch fixes typos found while reading through staging usbip. drivers/staging/usbip/stub_rx.c |2 +- drivers/staging/usbip/vhci_hcd.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c index 1d5b3fc..694cfd7 100644 --- a/drivers/staging/usbip/stub_rx.c +++ b/drivers/staging/usbip/stub_rx.c @@ -155,7 +155,7 @@ static int tweak_set_configuration_cmd(struct urb *urb) * eventually reassigned to the device as far as driver matching * condition is kept. * -* Unfortunatelly, an existing usbip connection will be dropped +* Unfortunately, an existing usbip connection will be dropped * due to this driver unbinding. So, skip here. * A user may need to set a special configuration value before * exporting the device. diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 12a9a5f..a5b028d 100644 --- a/drivers/staging/usbip/vhci_hcd.c +++ b/drivers/staging/usbip/vhci_hcd.c @@ -828,11 +828,11 @@ static void vhci_shutdown_connection(struct usbip_device *ud) * disable endpoints. pending urbs are unlinked(dequeued). * * NOTE: After calling rh_port_disconnect(), the USB device drivers of a -* deteched device should release used urbs in a cleanup function(i.e. +* detached device should release used urbs in a cleanup function (i.e. * xxx_disconnect()). Therefore, vhci_hcd does not need to release * pushed urbs and their private data in this function. * -* NOTE: vhci_dequeue() must be considered carefully. When shutdowning +* NOTE: vhci_dequeue() must be considered carefully. When shutting down * a connection, vhci_shutdown_connection() expects vhci_dequeue() * gives back pushed urbs and frees their private data by request of * the cleanup function of a USB driver. When unlinking a urb with an -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2]staging "usbip" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- NOTE:I see *rc1 in the git web log, so hopefully its ok to send out. The below patch fixes typos found while reading through staging usbip. drivers/staging/usbip/stub_rx.c |2 +- drivers/staging/usbip/vhci_hcd.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c index 1d5b3fc..694cfd7 100644 --- a/drivers/staging/usbip/stub_rx.c +++ b/drivers/staging/usbip/stub_rx.c @@ -155,7 +155,7 @@ static int tweak_set_configuration_cmd(struct urb *urb) * eventually reassigned to the device as far as driver matching * condition is kept. * -* Unfortunatelly, an existing usbip connection will be dropped +* Unfortunately, an existing usbip connection will be dropped * due to this driver unbinding. So, skip here. * A user may need to set a special configuration value before * exporting the device. diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 12a9a5f..a5b028d 100644 --- a/drivers/staging/usbip/vhci_hcd.c +++ b/drivers/staging/usbip/vhci_hcd.c @@ -828,11 +828,11 @@ static void vhci_shutdown_connection(struct usbip_device *ud) * disable endpoints. pending urbs are unlinked(dequeued). * * NOTE: After calling rh_port_disconnect(), the USB device drivers of a -* deteched device should release used urbs in a cleanup function(i.e. +* detached device should release used urbs in a cleanup function (i.e. * xxx_disconnect()). Therefore, vhci_hcd does not need to release * pushed urbs and their private data in this function. * -* NOTE: vhci_dequeue() must be considered carefully. When shutdowning +* NOTE: vhci_dequeue() must be considered carefully. When shutting down * a connection, vhci_shutdown_connection() expects vhci_dequeue() * gives back pushed urbs and frees their private data by request of * the cleanup function of a USB driver. When unlinking a urb with an -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH NEXT v2]staging: tidspbridge: Fix typos.
greg! I know how things can get lost in the sands of time, so when you get a chance is this patch good? or do I need to resend? On 07/23/2012 08:40 PM, Justin P. Mattock wrote: From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging: tidsbridge: .../staging/tidspbridge/Documentation/error-codes |2 +- drivers/staging/tidspbridge/core/_tiomap.h |2 +- drivers/staging/tidspbridge/core/chnl_sm.c |6 +++--- drivers/staging/tidspbridge/core/io_sm.c | 10 +- drivers/staging/tidspbridge/core/sync.c|2 +- drivers/staging/tidspbridge/core/tiomap3430.c |4 ++-- drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +- drivers/staging/tidspbridge/dynload/tramp.c|8 drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++--- .../tidspbridge/include/dspbridge/dspioctl.h |2 +- .../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +- .../staging/tidspbridge/include/dspbridge/node.h |2 +- .../staging/tidspbridge/include/dspbridge/ntfy.h |2 +- .../staging/tidspbridge/include/dspbridge/proc.h |2 +- .../staging/tidspbridge/include/dspbridge/strm.h |2 +- .../staging/tidspbridge/include/dspbridge/sync.h |4 ++-- drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +- drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++-- drivers/staging/tidspbridge/rmgr/mgr.c |4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c|2 +- drivers/staging/tidspbridge/rmgr/node.c|2 +- drivers/staging/tidspbridge/rmgr/proc.c|2 +- 22 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/tidspbridge/Documentation/error-codes b/drivers/staging/tidspbridge/Documentation/error-codes index 12826e2..ad73cba 100644 --- a/drivers/staging/tidspbridge/Documentation/error-codes +++ b/drivers/staging/tidspbridge/Documentation/error-codes @@ -69,7 +69,7 @@ The error codes used by this driver are: Invalid pointer or handler. [EEXIST] -Attempted to create a channel manager when one already exists. +Attempted to create a channel manager when one already exists. [EINVAL] Invalid argument. diff --git a/drivers/staging/tidspbridge/core/_tiomap.h b/drivers/staging/tidspbridge/core/_tiomap.h index 7cb5871..543a127 100644 --- a/drivers/staging/tidspbridge/core/_tiomap.h +++ b/drivers/staging/tidspbridge/core/_tiomap.h @@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[] = { /* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */ #define MBX_CORE2_RESOURCES 1 -/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */ +/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */ #define MBX_PM_MAX_RESOURCES 11 /* Power Management Commands */ diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c index e0c7e4c..f38950e 100644 --- a/drivers/staging/tidspbridge/core/chnl_sm.c +++ b/drivers/staging/tidspbridge/core/chnl_sm.c @@ -20,7 +20,7 @@ * The lower edge functions must be implemented by the Bridge driver * writer, and are declared in chnl_sm.h. * - * Care is taken in this code to prevent simulataneous access to channel + * Care is taken in this code to prevent simultaneous access to channel * queues from * 1. Threads. * 2. io_dpc(), scheduled from the io_isr() as an event. @@ -34,7 +34,7 @@ * Channel Invariant: * There is an important invariant condition which must be maintained per * channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation of - * which may cause timeouts and/or failure offunction sync_wait_on_event. + * which may cause timeouts and/or failure of function sync_wait_on_event. * This invariant condition is: * * list_empty(&pchnl->io_completions) ==> pchnl->sync_event is reset @@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32 timeout, /* Since DSPStream_Reclaim() does not take a timeout * parameter, we pass the stream's timeout value to * bridge_chnl_get_ioc. We cannot determine whether or not -* we have waited in User mode. Since the stream's timeout +* we have waited in user mode. Since the stream's timeout * value may be non-zero, we still have to set the event. * Therefore, this optimization is taken out. * diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 480a384..e322fb7 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mg
Re: [PATCH NEXT v2]staging: tidspbridge: Fix typos.
greg! I know how things can get lost in the sands of time, so when you get a chance is this patch good? or do I need to resend? On 07/23/2012 08:40 PM, Justin P. Mattock wrote: From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging: tidsbridge: .../staging/tidspbridge/Documentation/error-codes |2 +- drivers/staging/tidspbridge/core/_tiomap.h |2 +- drivers/staging/tidspbridge/core/chnl_sm.c |6 +++--- drivers/staging/tidspbridge/core/io_sm.c | 10 +- drivers/staging/tidspbridge/core/sync.c|2 +- drivers/staging/tidspbridge/core/tiomap3430.c |4 ++-- drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +- drivers/staging/tidspbridge/dynload/tramp.c|8 drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++--- .../tidspbridge/include/dspbridge/dspioctl.h |2 +- .../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +- .../staging/tidspbridge/include/dspbridge/node.h |2 +- .../staging/tidspbridge/include/dspbridge/ntfy.h |2 +- .../staging/tidspbridge/include/dspbridge/proc.h |2 +- .../staging/tidspbridge/include/dspbridge/strm.h |2 +- .../staging/tidspbridge/include/dspbridge/sync.h |4 ++-- drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +- drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++-- drivers/staging/tidspbridge/rmgr/mgr.c |4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c|2 +- drivers/staging/tidspbridge/rmgr/node.c|2 +- drivers/staging/tidspbridge/rmgr/proc.c|2 +- 22 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/tidspbridge/Documentation/error-codes b/drivers/staging/tidspbridge/Documentation/error-codes index 12826e2..ad73cba 100644 --- a/drivers/staging/tidspbridge/Documentation/error-codes +++ b/drivers/staging/tidspbridge/Documentation/error-codes @@ -69,7 +69,7 @@ The error codes used by this driver are: Invalid pointer or handler. [EEXIST] -Attempted to create a channel manager when one already exists. +Attempted to create a channel manager when one already exists. [EINVAL] Invalid argument. diff --git a/drivers/staging/tidspbridge/core/_tiomap.h b/drivers/staging/tidspbridge/core/_tiomap.h index 7cb5871..543a127 100644 --- a/drivers/staging/tidspbridge/core/_tiomap.h +++ b/drivers/staging/tidspbridge/core/_tiomap.h @@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[] = { /* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */ #define MBX_CORE2_RESOURCES 1 -/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */ +/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */ #define MBX_PM_MAX_RESOURCES 11 /* Power Management Commands */ diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c index e0c7e4c..f38950e 100644 --- a/drivers/staging/tidspbridge/core/chnl_sm.c +++ b/drivers/staging/tidspbridge/core/chnl_sm.c @@ -20,7 +20,7 @@ * The lower edge functions must be implemented by the Bridge driver * writer, and are declared in chnl_sm.h. * - * Care is taken in this code to prevent simulataneous access to channel + * Care is taken in this code to prevent simultaneous access to channel * queues from * 1. Threads. * 2. io_dpc(), scheduled from the io_isr() as an event. @@ -34,7 +34,7 @@ * Channel Invariant: * There is an important invariant condition which must be maintained per * channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation of - * which may cause timeouts and/or failure offunction sync_wait_on_event. + * which may cause timeouts and/or failure of function sync_wait_on_event. * This invariant condition is: * * list_empty(&pchnl->io_completions) ==> pchnl->sync_event is reset @@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32 timeout, /* Since DSPStream_Reclaim() does not take a timeout * parameter, we pass the stream's timeout value to * bridge_chnl_get_ioc. We cannot determine whether or not -* we have waited in User mode. Since the stream's timeout +* we have waited in user mode. Since the stream's timeout * value may be non-zero, we still have to set the event. * Therefore, this optimization is taken out. * diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 480a384..e322fb7 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mg
[PATCH]staging: usbip: Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging: usbip drivers/staging/usbip/stub_rx.c |2 +- drivers/staging/usbip/vhci_hcd.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c index 1d5b3fc..694cfd7 100644 --- a/drivers/staging/usbip/stub_rx.c +++ b/drivers/staging/usbip/stub_rx.c @@ -155,7 +155,7 @@ static int tweak_set_configuration_cmd(struct urb *urb) * eventually reassigned to the device as far as driver matching * condition is kept. * -* Unfortunatelly, an existing usbip connection will be dropped +* Unfortunately, an existing usbip connection will be dropped * due to this driver unbinding. So, skip here. * A user may need to set a special configuration value before * exporting the device. diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 12a9a5f..dd15dc0 100644 --- a/drivers/staging/usbip/vhci_hcd.c +++ b/drivers/staging/usbip/vhci_hcd.c @@ -828,11 +828,11 @@ static void vhci_shutdown_connection(struct usbip_device *ud) * disable endpoints. pending urbs are unlinked(dequeued). * * NOTE: After calling rh_port_disconnect(), the USB device drivers of a -* deteched device should release used urbs in a cleanup function(i.e. +* detached device should release used urbs in a cleanup function(i.e. * xxx_disconnect()). Therefore, vhci_hcd does not need to release * pushed urbs and their private data in this function. * -* NOTE: vhci_dequeue() must be considered carefully. When shutdowning +* NOTE: vhci_dequeue() must be considered carefully. When shuting down * a connection, vhci_shutdown_connection() expects vhci_dequeue() * gives back pushed urbs and frees their private data by request of * the cleanup function of a USB driver. When unlinking a urb with an -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]staging: usbip: Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging: usbip drivers/staging/usbip/stub_rx.c |2 +- drivers/staging/usbip/vhci_hcd.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/usbip/stub_rx.c b/drivers/staging/usbip/stub_rx.c index 1d5b3fc..694cfd7 100644 --- a/drivers/staging/usbip/stub_rx.c +++ b/drivers/staging/usbip/stub_rx.c @@ -155,7 +155,7 @@ static int tweak_set_configuration_cmd(struct urb *urb) * eventually reassigned to the device as far as driver matching * condition is kept. * -* Unfortunatelly, an existing usbip connection will be dropped +* Unfortunately, an existing usbip connection will be dropped * due to this driver unbinding. So, skip here. * A user may need to set a special configuration value before * exporting the device. diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c index 12a9a5f..dd15dc0 100644 --- a/drivers/staging/usbip/vhci_hcd.c +++ b/drivers/staging/usbip/vhci_hcd.c @@ -828,11 +828,11 @@ static void vhci_shutdown_connection(struct usbip_device *ud) * disable endpoints. pending urbs are unlinked(dequeued). * * NOTE: After calling rh_port_disconnect(), the USB device drivers of a -* deteched device should release used urbs in a cleanup function(i.e. +* detached device should release used urbs in a cleanup function(i.e. * xxx_disconnect()). Therefore, vhci_hcd does not need to release * pushed urbs and their private data in this function. * -* NOTE: vhci_dequeue() must be considered carefully. When shutdowning +* NOTE: vhci_dequeue() must be considered carefully. When shuting down * a connection, vhci_shutdown_connection() expects vhci_dequeue() * gives back pushed urbs and frees their private data by request of * the cleanup function of a USB driver. When unlinking a urb with an -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH NEXT v2]staging: tidspbridge: Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging: tidsbridge: .../staging/tidspbridge/Documentation/error-codes |2 +- drivers/staging/tidspbridge/core/_tiomap.h |2 +- drivers/staging/tidspbridge/core/chnl_sm.c |6 +++--- drivers/staging/tidspbridge/core/io_sm.c | 10 +- drivers/staging/tidspbridge/core/sync.c|2 +- drivers/staging/tidspbridge/core/tiomap3430.c |4 ++-- drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +- drivers/staging/tidspbridge/dynload/tramp.c|8 drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++--- .../tidspbridge/include/dspbridge/dspioctl.h |2 +- .../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +- .../staging/tidspbridge/include/dspbridge/node.h |2 +- .../staging/tidspbridge/include/dspbridge/ntfy.h |2 +- .../staging/tidspbridge/include/dspbridge/proc.h |2 +- .../staging/tidspbridge/include/dspbridge/strm.h |2 +- .../staging/tidspbridge/include/dspbridge/sync.h |4 ++-- drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +- drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++-- drivers/staging/tidspbridge/rmgr/mgr.c |4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c|2 +- drivers/staging/tidspbridge/rmgr/node.c|2 +- drivers/staging/tidspbridge/rmgr/proc.c|2 +- 22 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/tidspbridge/Documentation/error-codes b/drivers/staging/tidspbridge/Documentation/error-codes index 12826e2..ad73cba 100644 --- a/drivers/staging/tidspbridge/Documentation/error-codes +++ b/drivers/staging/tidspbridge/Documentation/error-codes @@ -69,7 +69,7 @@ The error codes used by this driver are: Invalid pointer or handler. [EEXIST] -Attempted to create a channel manager when one already exists. +Attempted to create a channel manager when one already exists. [EINVAL] Invalid argument. diff --git a/drivers/staging/tidspbridge/core/_tiomap.h b/drivers/staging/tidspbridge/core/_tiomap.h index 7cb5871..543a127 100644 --- a/drivers/staging/tidspbridge/core/_tiomap.h +++ b/drivers/staging/tidspbridge/core/_tiomap.h @@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[] = { /* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */ #define MBX_CORE2_RESOURCES 1 -/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */ +/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */ #define MBX_PM_MAX_RESOURCES 11 /* Power Management Commands */ diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c index e0c7e4c..f38950e 100644 --- a/drivers/staging/tidspbridge/core/chnl_sm.c +++ b/drivers/staging/tidspbridge/core/chnl_sm.c @@ -20,7 +20,7 @@ * The lower edge functions must be implemented by the Bridge driver * writer, and are declared in chnl_sm.h. * - * Care is taken in this code to prevent simulataneous access to channel + * Care is taken in this code to prevent simultaneous access to channel * queues from * 1. Threads. * 2. io_dpc(), scheduled from the io_isr() as an event. @@ -34,7 +34,7 @@ * Channel Invariant: * There is an important invariant condition which must be maintained per * channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation of - * which may cause timeouts and/or failure offunction sync_wait_on_event. + * which may cause timeouts and/or failure of function sync_wait_on_event. * This invariant condition is: * * list_empty(&pchnl->io_completions) ==> pchnl->sync_event is reset @@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32 timeout, /* Since DSPStream_Reclaim() does not take a timeout * parameter, we pass the stream's timeout value to * bridge_chnl_get_ioc. We cannot determine whether or not -* we have waited in User mode. Since the stream's timeout +* we have waited in user mode. Since the stream's timeout * value may be non-zero, we still have to set the event. * Therefore, this optimization is taken out. * diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 480a384..e322fb7 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mgr *pio_mgr) /* * io_dpc * Deferred procedure call for shared memory channel driver ISR. Carries - * out the dispatch of I/O as a non-preemptible event.It can only be - * pre-empted
[PATCH NEXT v2]staging: tidspbridge: Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging: tidsbridge: .../staging/tidspbridge/Documentation/error-codes |2 +- drivers/staging/tidspbridge/core/_tiomap.h |2 +- drivers/staging/tidspbridge/core/chnl_sm.c |6 +++--- drivers/staging/tidspbridge/core/io_sm.c | 10 +- drivers/staging/tidspbridge/core/sync.c|2 +- drivers/staging/tidspbridge/core/tiomap3430.c |4 ++-- drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +- drivers/staging/tidspbridge/dynload/tramp.c|8 drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++--- .../tidspbridge/include/dspbridge/dspioctl.h |2 +- .../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +- .../staging/tidspbridge/include/dspbridge/node.h |2 +- .../staging/tidspbridge/include/dspbridge/ntfy.h |2 +- .../staging/tidspbridge/include/dspbridge/proc.h |2 +- .../staging/tidspbridge/include/dspbridge/strm.h |2 +- .../staging/tidspbridge/include/dspbridge/sync.h |4 ++-- drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +- drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++-- drivers/staging/tidspbridge/rmgr/mgr.c |4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c|2 +- drivers/staging/tidspbridge/rmgr/node.c|2 +- drivers/staging/tidspbridge/rmgr/proc.c|2 +- 22 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/tidspbridge/Documentation/error-codes b/drivers/staging/tidspbridge/Documentation/error-codes index 12826e2..ad73cba 100644 --- a/drivers/staging/tidspbridge/Documentation/error-codes +++ b/drivers/staging/tidspbridge/Documentation/error-codes @@ -69,7 +69,7 @@ The error codes used by this driver are: Invalid pointer or handler. [EEXIST] -Attempted to create a channel manager when one already exists. +Attempted to create a channel manager when one already exists. [EINVAL] Invalid argument. diff --git a/drivers/staging/tidspbridge/core/_tiomap.h b/drivers/staging/tidspbridge/core/_tiomap.h index 7cb5871..543a127 100644 --- a/drivers/staging/tidspbridge/core/_tiomap.h +++ b/drivers/staging/tidspbridge/core/_tiomap.h @@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[] = { /* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */ #define MBX_CORE2_RESOURCES 1 -/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */ +/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */ #define MBX_PM_MAX_RESOURCES 11 /* Power Management Commands */ diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c index e0c7e4c..f38950e 100644 --- a/drivers/staging/tidspbridge/core/chnl_sm.c +++ b/drivers/staging/tidspbridge/core/chnl_sm.c @@ -20,7 +20,7 @@ * The lower edge functions must be implemented by the Bridge driver * writer, and are declared in chnl_sm.h. * - * Care is taken in this code to prevent simulataneous access to channel + * Care is taken in this code to prevent simultaneous access to channel * queues from * 1. Threads. * 2. io_dpc(), scheduled from the io_isr() as an event. @@ -34,7 +34,7 @@ * Channel Invariant: * There is an important invariant condition which must be maintained per * channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation of - * which may cause timeouts and/or failure offunction sync_wait_on_event. + * which may cause timeouts and/or failure of function sync_wait_on_event. * This invariant condition is: * * list_empty(&pchnl->io_completions) ==> pchnl->sync_event is reset @@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32 timeout, /* Since DSPStream_Reclaim() does not take a timeout * parameter, we pass the stream's timeout value to * bridge_chnl_get_ioc. We cannot determine whether or not -* we have waited in User mode. Since the stream's timeout +* we have waited in user mode. Since the stream's timeout * value may be non-zero, we still have to set the event. * Therefore, this optimization is taken out. * diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 480a384..e322fb7 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mgr *pio_mgr) /* * io_dpc * Deferred procedure call for shared memory channel driver ISR. Carries - * out the dispatch of I/O as a non-preemptible event.It can only be - * pre-empted
Re: [PATCH NEXT]staging "tidspbridge" Fix typos.
On 07/23/2012 01:44 PM, Ramirez Luna, Omar wrote: Hi Justin, On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock wrote: diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c index f9609ce..2c82d5a 100644 --- a/drivers/staging/tidspbridge/core/tiomap3430.c +++ b/drivers/staging/tidspbridge/core/tiomap3430.c @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt, ul_num_bytes, mem_type); return status; } - /* copy the data from DSP memory, */ + /* copy the data from DSP memory, */ I guess we can get rid of the comma (,) at the end of this sentence. good catch! ... diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h index a82380e..9cd5022 100644 --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id); * Returns: * 0 : Success. * -EFAULT : Invalid processor handle. - * -EPERM : General failure while retireving processor trace + * -EPERM : General failure while retireing processor trace This was meant to be 'retrieving'. And given that this is focused on tidspbridge, could you change the patch subject? To: staging: tidspbridge: fix typos. Cheers, Omar ah.. I see now.. comments can be tough to decipher sometimes with what the writer is saying, helps to know what the code is doing. cheers, resending the revised version, and Thank you for taking the time. Justin P. Mattock ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Re: [PATCH NEXT]staging "tidspbridge" Fix typos.
On 07/23/2012 01:44 PM, Ramirez Luna, Omar wrote: Hi Justin, On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock wrote: diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c index f9609ce..2c82d5a 100644 --- a/drivers/staging/tidspbridge/core/tiomap3430.c +++ b/drivers/staging/tidspbridge/core/tiomap3430.c @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt, ul_num_bytes, mem_type); return status; } - /* copy the data from DSP memory, */ + /* copy the data from DSP memory, */ I guess we can get rid of the comma (,) at the end of this sentence. good catch! ... diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h index a82380e..9cd5022 100644 --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id); * Returns: * 0 : Success. * -EFAULT : Invalid processor handle. - * -EPERM : General failure while retireving processor trace + * -EPERM : General failure while retireing processor trace This was meant to be 'retrieving'. And given that this is focused on tidspbridge, could you change the patch subject? To: staging: tidspbridge: fix typos. Cheers, Omar ah.. I see now.. comments can be tough to decipher sometimes with what the writer is saying, helps to know what the code is doing. cheers, resending the revised version, and Thank you for taking the time. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH NEXT]staging "tidspbridge" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos found while reading through staging "tidspbridge". .../staging/tidspbridge/Documentation/error-codes |2 +- drivers/staging/tidspbridge/core/_tiomap.h |2 +- drivers/staging/tidspbridge/core/chnl_sm.c |6 +++--- drivers/staging/tidspbridge/core/io_sm.c | 10 +- drivers/staging/tidspbridge/core/sync.c|2 +- drivers/staging/tidspbridge/core/tiomap3430.c |4 ++-- drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +- drivers/staging/tidspbridge/dynload/tramp.c|8 drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++--- .../tidspbridge/include/dspbridge/dspioctl.h |2 +- .../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +- .../staging/tidspbridge/include/dspbridge/node.h |2 +- .../staging/tidspbridge/include/dspbridge/ntfy.h |2 +- .../staging/tidspbridge/include/dspbridge/proc.h |2 +- .../staging/tidspbridge/include/dspbridge/strm.h |2 +- .../staging/tidspbridge/include/dspbridge/sync.h |4 ++-- drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +- drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++-- drivers/staging/tidspbridge/rmgr/mgr.c |4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c|2 +- drivers/staging/tidspbridge/rmgr/node.c|2 +- drivers/staging/tidspbridge/rmgr/proc.c|2 +- 22 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/tidspbridge/Documentation/error-codes b/drivers/staging/tidspbridge/Documentation/error-codes index 12826e2..ad73cba 100644 --- a/drivers/staging/tidspbridge/Documentation/error-codes +++ b/drivers/staging/tidspbridge/Documentation/error-codes @@ -69,7 +69,7 @@ The error codes used by this driver are: Invalid pointer or handler. [EEXIST] -Attempted to create a channel manager when one already exists. +Attempted to create a channel manager when one already exists. [EINVAL] Invalid argument. diff --git a/drivers/staging/tidspbridge/core/_tiomap.h b/drivers/staging/tidspbridge/core/_tiomap.h index 7cb5871..543a127 100644 --- a/drivers/staging/tidspbridge/core/_tiomap.h +++ b/drivers/staging/tidspbridge/core/_tiomap.h @@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[] = { /* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */ #define MBX_CORE2_RESOURCES 1 -/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */ +/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */ #define MBX_PM_MAX_RESOURCES 11 /* Power Management Commands */ diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c index e0c7e4c..f38950e 100644 --- a/drivers/staging/tidspbridge/core/chnl_sm.c +++ b/drivers/staging/tidspbridge/core/chnl_sm.c @@ -20,7 +20,7 @@ * The lower edge functions must be implemented by the Bridge driver * writer, and are declared in chnl_sm.h. * - * Care is taken in this code to prevent simulataneous access to channel + * Care is taken in this code to prevent simultaneous access to channel * queues from * 1. Threads. * 2. io_dpc(), scheduled from the io_isr() as an event. @@ -34,7 +34,7 @@ * Channel Invariant: * There is an important invariant condition which must be maintained per * channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation of - * which may cause timeouts and/or failure offunction sync_wait_on_event. + * which may cause timeouts and/or failure of function sync_wait_on_event. * This invariant condition is: * * list_empty(&pchnl->io_completions) ==> pchnl->sync_event is reset @@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32 timeout, /* Since DSPStream_Reclaim() does not take a timeout * parameter, we pass the stream's timeout value to * bridge_chnl_get_ioc. We cannot determine whether or not -* we have waited in User mode. Since the stream's timeout +* we have waited in user mode. Since the stream's timeout * value may be non-zero, we still have to set the event. * Therefore, this optimization is taken out. * diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 480a384..e322fb7 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mgr *pio_mgr) /* * io_dpc * Deferred procedure call for shared memory channel driver ISR. Carries - * out the dispatch of I/O as a non-preemptible event.It can only be - *
[PATCH NEXT]staging "tidspbridge" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos found while reading through staging "tidspbridge". .../staging/tidspbridge/Documentation/error-codes |2 +- drivers/staging/tidspbridge/core/_tiomap.h |2 +- drivers/staging/tidspbridge/core/chnl_sm.c |6 +++--- drivers/staging/tidspbridge/core/io_sm.c | 10 +- drivers/staging/tidspbridge/core/sync.c|2 +- drivers/staging/tidspbridge/core/tiomap3430.c |4 ++-- drivers/staging/tidspbridge/core/tiomap3430_pwr.c |2 +- drivers/staging/tidspbridge/dynload/tramp.c|8 drivers/staging/tidspbridge/hw/hw_mmu.c|6 +++--- .../tidspbridge/include/dspbridge/dspioctl.h |2 +- .../staging/tidspbridge/include/dspbridge/mbx_sh.h |2 +- .../staging/tidspbridge/include/dspbridge/node.h |2 +- .../staging/tidspbridge/include/dspbridge/ntfy.h |2 +- .../staging/tidspbridge/include/dspbridge/proc.h |2 +- .../staging/tidspbridge/include/dspbridge/strm.h |2 +- .../staging/tidspbridge/include/dspbridge/sync.h |4 ++-- drivers/staging/tidspbridge/rmgr/dbdcd.c |2 +- drivers/staging/tidspbridge/rmgr/dspdrv.c |4 ++-- drivers/staging/tidspbridge/rmgr/mgr.c |4 ++-- drivers/staging/tidspbridge/rmgr/nldr.c|2 +- drivers/staging/tidspbridge/rmgr/node.c|2 +- drivers/staging/tidspbridge/rmgr/proc.c|2 +- 22 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/tidspbridge/Documentation/error-codes b/drivers/staging/tidspbridge/Documentation/error-codes index 12826e2..ad73cba 100644 --- a/drivers/staging/tidspbridge/Documentation/error-codes +++ b/drivers/staging/tidspbridge/Documentation/error-codes @@ -69,7 +69,7 @@ The error codes used by this driver are: Invalid pointer or handler. [EEXIST] -Attempted to create a channel manager when one already exists. +Attempted to create a channel manager when one already exists. [EINVAL] Invalid argument. diff --git a/drivers/staging/tidspbridge/core/_tiomap.h b/drivers/staging/tidspbridge/core/_tiomap.h index 7cb5871..543a127 100644 --- a/drivers/staging/tidspbridge/core/_tiomap.h +++ b/drivers/staging/tidspbridge/core/_tiomap.h @@ -219,7 +219,7 @@ static const struct map_l4_peripheral l4_peripheral_table[] = { /* MBX_PM_MAX_RESOURCES: CORE 2 Clock Resources. */ #define MBX_CORE2_RESOURCES 1 -/* MBX_PM_MAX_RESOURCES: TOTAL Clock Reosurces. */ +/* MBX_PM_MAX_RESOURCES: TOTAL Clock Resources. */ #define MBX_PM_MAX_RESOURCES 11 /* Power Management Commands */ diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c index e0c7e4c..f38950e 100644 --- a/drivers/staging/tidspbridge/core/chnl_sm.c +++ b/drivers/staging/tidspbridge/core/chnl_sm.c @@ -20,7 +20,7 @@ * The lower edge functions must be implemented by the Bridge driver * writer, and are declared in chnl_sm.h. * - * Care is taken in this code to prevent simulataneous access to channel + * Care is taken in this code to prevent simultaneous access to channel * queues from * 1. Threads. * 2. io_dpc(), scheduled from the io_isr() as an event. @@ -34,7 +34,7 @@ * Channel Invariant: * There is an important invariant condition which must be maintained per * channel outside of bridge_chnl_get_ioc() and IO_Dispatch(), violation of - * which may cause timeouts and/or failure offunction sync_wait_on_event. + * which may cause timeouts and/or failure of function sync_wait_on_event. * This invariant condition is: * * list_empty(&pchnl->io_completions) ==> pchnl->sync_event is reset @@ -602,7 +602,7 @@ int bridge_chnl_get_ioc(struct chnl_object *chnl_obj, u32 timeout, /* Since DSPStream_Reclaim() does not take a timeout * parameter, we pass the stream's timeout value to * bridge_chnl_get_ioc. We cannot determine whether or not -* we have waited in User mode. Since the stream's timeout +* we have waited in user mode. Since the stream's timeout * value may be non-zero, we still have to set the event. * Therefore, this optimization is taken out. * diff --git a/drivers/staging/tidspbridge/core/io_sm.c b/drivers/staging/tidspbridge/core/io_sm.c index 480a384..e322fb7 100644 --- a/drivers/staging/tidspbridge/core/io_sm.c +++ b/drivers/staging/tidspbridge/core/io_sm.c @@ -837,8 +837,8 @@ static void io_dispatch_pm(struct io_mgr *pio_mgr) /* * io_dpc * Deferred procedure call for shared memory channel driver ISR. Carries - * out the dispatch of I/O as a non-preemptible event.It can only be - *
[PATCH NEXT]staging "ste_rmi4" Fix typos
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "ste_rmi4" drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c index 11728a0..277491a 100644 --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c @@ -655,13 +655,13 @@ static int synpatics_rmi4_touchpad_detect(struct synaptics_rmi4_data *pdata, } /** - * synpatics_rmi4_touchpad_config() - confiures the rmi4 touchpad device + * synaptics_rmi4_touchpad_config() - configures the rmi4 touchpad device * @pdata: pointer to synaptics_rmi4_data structure * @rfi: pointer to synaptics_rmi4_fn structure * - * This function calls to confiures the rmi4 touchpad device + * This function calls to configures the rmi4 touchpad device */ -int synpatics_rmi4_touchpad_config(struct synaptics_rmi4_data *pdata, +int synaptics_rmi4_touchpad_config(struct synaptics_rmi4_data *pdata, struct synaptics_rmi4_fn *rfi) { /* @@ -855,7 +855,7 @@ static int synaptics_rmi4_i2c_query_device(struct synaptics_rmi4_data *pdata) if (rfi->num_of_data_sources) { if (rfi->fn_number == SYNAPTICS_RMI4_TOUCHPAD_FUNC_NUM) { - retval = synpatics_rmi4_touchpad_config + retval = synaptics_rmi4_touchpad_config (pdata, rfi); if (retval < 0) return retval; -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH NEXT]staging "ste_rmi4" Fix typos
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "ste_rmi4" drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c index 11728a0..277491a 100644 --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c @@ -655,13 +655,13 @@ static int synpatics_rmi4_touchpad_detect(struct synaptics_rmi4_data *pdata, } /** - * synpatics_rmi4_touchpad_config() - confiures the rmi4 touchpad device + * synaptics_rmi4_touchpad_config() - configures the rmi4 touchpad device * @pdata: pointer to synaptics_rmi4_data structure * @rfi: pointer to synaptics_rmi4_fn structure * - * This function calls to confiures the rmi4 touchpad device + * This function calls to configures the rmi4 touchpad device */ -int synpatics_rmi4_touchpad_config(struct synaptics_rmi4_data *pdata, +int synaptics_rmi4_touchpad_config(struct synaptics_rmi4_data *pdata, struct synaptics_rmi4_fn *rfi) { /* @@ -855,7 +855,7 @@ static int synaptics_rmi4_i2c_query_device(struct synaptics_rmi4_data *pdata) if (rfi->num_of_data_sources) { if (rfi->fn_number == SYNAPTICS_RMI4_TOUCHPAD_FUNC_NUM) { - retval = synpatics_rmi4_touchpad_config + retval = synaptics_rmi4_touchpad_config (pdata, rfi); if (retval < 0) return retval; -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH NEXT]staging "speakup" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "speakup". drivers/staging/speakup/i18n.c |2 +- drivers/staging/speakup/speakup_acnt.h |2 +- drivers/staging/speakup/speakup_decpc.c |2 +- drivers/staging/speakup/synth.c |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index c211943..ca01734 100644 --- a/drivers/staging/speakup/i18n.c +++ b/drivers/staging/speakup/i18n.c @@ -71,7 +71,7 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = { [MSG_CTL_SHIFT] = "shift", [MSG_CTL_ALTGR] = "altgr", [MSG_CTL_CONTROL] = "control", - [MSG_CTL_ALT] = "ault", + [MSG_CTL_ALT] = "alt", [MSG_CTL_LSHIFT] = "l shift", [MSG_CTL_SPEAKUP] = "speakup", [MSG_CTL_LCONTROL] = "l control", diff --git a/drivers/staging/speakup/speakup_acnt.h b/drivers/staging/speakup/speakup_acnt.h index 2d88365..6376fca 100644 --- a/drivers/staging/speakup/speakup_acnt.h +++ b/drivers/staging/speakup/speakup_acnt.h @@ -12,5 +12,5 @@ to accept a byte of data. */ #define SYNTH_QUIET'S' /* synth is not speaking */ #define SYNTH_FULL 'F' /* synth is full. */ -#define SYNTH_ALMOST_EMPTY 'M' /* synth has les than 2 seconds of text left */ +#define SYNTH_ALMOST_EMPTY 'M' /* synth has less than 2 seconds of text left */ #define SYNTH_SPEAKING 's' /* synth is speaking and has a fare way to go */ diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index de25527..a09a0c9 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -66,7 +66,7 @@ #defineCMD_null0x /* post status */ #defineCMD_control 0x1000 /* hard control command */ #defineCTRL_mask 0x0F00 /* mask off control nibble */ -#defineCTRL_data 0x00FF /* madk to get data byte */ +#defineCTRL_data 0x00FF /* mask to get data byte */ #defineCTRL_null 0x /* null control */ #defineCTRL_vol_up 0x0100 /* increase volume */ #defineCTRL_vol_down 0x0200 /* decrease volume */ diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 331eae7..df95337 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -64,7 +64,7 @@ EXPORT_SYMBOL_GPL(serial_synth_probe); /* Main loop of the progression thread: keep eating from the buffer * and push to the serial port, waiting as needed * - * For devices that have a "full" notification mecanism, the driver can + * For devices that have a "full" notification mechanism, the driver can * adapt the loop the way they prefer. */ void spk_do_catch_up(struct spk_synth *synth) -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH NEXT]staging "speakup" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "speakup". drivers/staging/speakup/i18n.c |2 +- drivers/staging/speakup/speakup_acnt.h |2 +- drivers/staging/speakup/speakup_decpc.c |2 +- drivers/staging/speakup/synth.c |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c index c211943..ca01734 100644 --- a/drivers/staging/speakup/i18n.c +++ b/drivers/staging/speakup/i18n.c @@ -71,7 +71,7 @@ static char *speakup_default_msgs[MSG_LAST_INDEX] = { [MSG_CTL_SHIFT] = "shift", [MSG_CTL_ALTGR] = "altgr", [MSG_CTL_CONTROL] = "control", - [MSG_CTL_ALT] = "ault", + [MSG_CTL_ALT] = "alt", [MSG_CTL_LSHIFT] = "l shift", [MSG_CTL_SPEAKUP] = "speakup", [MSG_CTL_LCONTROL] = "l control", diff --git a/drivers/staging/speakup/speakup_acnt.h b/drivers/staging/speakup/speakup_acnt.h index 2d88365..6376fca 100644 --- a/drivers/staging/speakup/speakup_acnt.h +++ b/drivers/staging/speakup/speakup_acnt.h @@ -12,5 +12,5 @@ to accept a byte of data. */ #define SYNTH_QUIET'S' /* synth is not speaking */ #define SYNTH_FULL 'F' /* synth is full. */ -#define SYNTH_ALMOST_EMPTY 'M' /* synth has les than 2 seconds of text left */ +#define SYNTH_ALMOST_EMPTY 'M' /* synth has less than 2 seconds of text left */ #define SYNTH_SPEAKING 's' /* synth is speaking and has a fare way to go */ diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c index de25527..a09a0c9 100644 --- a/drivers/staging/speakup/speakup_decpc.c +++ b/drivers/staging/speakup/speakup_decpc.c @@ -66,7 +66,7 @@ #defineCMD_null0x /* post status */ #defineCMD_control 0x1000 /* hard control command */ #defineCTRL_mask 0x0F00 /* mask off control nibble */ -#defineCTRL_data 0x00FF /* madk to get data byte */ +#defineCTRL_data 0x00FF /* mask to get data byte */ #defineCTRL_null 0x /* null control */ #defineCTRL_vol_up 0x0100 /* increase volume */ #defineCTRL_vol_down 0x0200 /* decrease volume */ diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index 331eae7..df95337 100644 --- a/drivers/staging/speakup/synth.c +++ b/drivers/staging/speakup/synth.c @@ -64,7 +64,7 @@ EXPORT_SYMBOL_GPL(serial_synth_probe); /* Main loop of the progression thread: keep eating from the buffer * and push to the serial port, waiting as needed * - * For devices that have a "full" notification mecanism, the driver can + * For devices that have a "full" notification mechanism, the driver can * adapt the loop the way they prefer. */ void spk_do_catch_up(struct spk_synth *synth) -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH NEXT]staging "telephony" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "telephony". drivers/staging/telephony/ixj.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/telephony/ixj.c b/drivers/staging/telephony/ixj.c index fd7757a..b303c91 100644 --- a/drivers/staging/telephony/ixj.c +++ b/drivers/staging/telephony/ixj.c @@ -7094,7 +7094,7 @@ static int ixj_selfprobe(IXJ *j) for (cnt = 0; cnt < 35; cnt++) j->ixj_signals[cnt] = SIGIO; - /* Set the excetion signal enable flags */ + /* Set the exception signal enable flags */ j->ex_sig.bits.dtmf_ready = j->ex_sig.bits.hookstate = j->ex_sig.bits.flash = j->ex_sig.bits.pstn_ring = j->ex_sig.bits.caller_id = j->ex_sig.bits.pstn_wink = j->ex_sig.bits.f0 = j->ex_sig.bits.f1 = j->ex_sig.bits.f2 = j->ex_sig.bits.f3 = j->ex_sig.bits.fc0 = j->ex_sig.bits.fc1 = j->ex_sig.bits.fc2 = j->ex_sig.bits.fc3 = 1; @@ -7132,7 +7132,7 @@ IXJ *ixj_pcmcia_probe(unsigned long dsp, unsigned long xilinx) return j; } -EXPORT_SYMBOL(ixj_pcmcia_probe); /* Fpr PCMCIA */ +EXPORT_SYMBOL(ixj_pcmcia_probe); /* For PCMCIA */ static int ixj_get_status_proc(char *buf) { -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH NEXT]staging "sm7xxfb" Fix typos in sm7xxfb
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos found in staging "sm7xxfb" while reading through. drivers/staging/sm7xxfb/sm7xxfb.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index 21dab34..32111a0 100644 --- a/drivers/staging/sm7xxfb/sm7xxfb.c +++ b/drivers/staging/sm7xxfb/sm7xxfb.c @@ -351,7 +351,7 @@ static int smtc_setcolreg(unsigned regno, unsigned red, unsigned green, case FB_VISUAL_DIRECTCOLOR: case FB_VISUAL_TRUECOLOR: /* -* 16/32 bit true-colour, use pseuo-palette for 16 base color +* 16/32 bit true-colour, use pseudo-palette for 16 base color */ if (regno < 16) { if (sfb->fb.var.bits_per_pixel == 16) { @@ -996,7 +996,7 @@ static int smtcfb_pci_suspend(struct device *device) sfb = pci_get_drvdata(pdev); - /* set the hw in sleep mode use externel clock and self memory refresh + /* set the hw in sleep mode use external clock and self memory refresh * so that we can turn off internal PLLs later on */ smtc_seqw(0x20, (smtc_seqr(0x20) | 0xc0)); -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH 2/2]staging "slicoss" Fix a typo.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes a typo found while reading through "staging" "slicoss" drivers/staging/slicoss/slicoss.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 77a0751..d2b82a7 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -47,7 +47,7 @@ * Oasis cards (single and dual port PCI-x Gigabit) copper and fiber * Kalahari cards (dual and quad port PCI-e Gigabit) copper and fiber * - * The driver was acutally tested on Oasis and Kalahari cards. + * The driver was actually tested on Oasis and Kalahari cards. * * * NOTE: This is the standard, non-accelerated version of Alacritech's -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH 1/2]staging "serqt_usb2" Fix some typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos that was found while reading through "staging" "serqt_usb2" drivers/staging/serqt_usb2/serqt_usb2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c index 43045db..26fd038 100644 --- a/drivers/staging/serqt_usb2/serqt_usb2.c +++ b/drivers/staging/serqt_usb2/serqt_usb2.c @@ -609,7 +609,7 @@ static int BoxSetRegister(struct usb_serial *serial, unsigned short Uart_Number, /* * qt_setuart - * issuse a SET_UART vendor-spcific request on the default control pipe + * issues a SET_UART vendor-specific request on the default control pipe * If successful sets baud rate divisor and LCR value */ static int qt_setuart(struct usb_serial *serial, unsigned short Uart_Number, @@ -1388,7 +1388,7 @@ static inline int qt_real_tiocmset(struct tty_struct *tty, return -ESPIPE; /* -* Turn off the RTS and DTR and loopbcck and then only turn on what was +* Turn off the RTS and DTR and loopback and then only turn on what was * asked for */ mcr &= ~(SERIAL_MCR_RTS | SERIAL_MCR_DTR | SERIAL_MCR_LOOP); -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH]staging "sep" Fix typos found while reading.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes typos found while reading through staging "sep" drivers/staging/sep/sep_crypto.c| 18 +++--- drivers/staging/sep/sep_driver_api.h|8 +++--- drivers/staging/sep/sep_driver_config.h |4 +- drivers/staging/sep/sep_main.c | 36 +++--- 4 files changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/staging/sep/sep_crypto.c b/drivers/staging/sep/sep_crypto.c index 1cc790e..302448c 100644 --- a/drivers/staging/sep/sep_crypto.c +++ b/drivers/staging/sep/sep_crypto.c @@ -807,7 +807,7 @@ end_function: * @size: size of parameter to copy (in bytes) * @max_size: size to move up offset; SEP mesg is in word sizes * @msg_offset: pointer to current offset (is updated) - * @byte_array: flag ti indicate wheter endian must be changed + * @byte_array: flag ti indicate whether endian must be changed * Copies data into the message area from caller */ static void sep_write_msg(struct this_task_ctx *ta_ctx, void *in_addr, @@ -855,7 +855,7 @@ static void sep_make_header(struct this_task_ctx *ta_ctx, u32 *msg_offset, * @size: size of parameter to copy (in bytes) * @max_size: size to move up offset; SEP mesg is in word sizes * @msg_offset: pointer to current offset (is updated) - * @byte_array: flag ti indicate wheter endian must be changed + * @byte_array: flag ti indicate whether endian must be changed * Copies data out of the message area to caller */ static void sep_read_msg(struct this_task_ctx *ta_ctx, void *in_addr, @@ -990,7 +990,7 @@ static void sep_clear_out(struct this_task_ctx *ta_ctx) /** * The following unlocks the sep and makes it available * to any other application -* First, null out crypto entries in sep before relesing it +* First, null out crypto entries in sep before releasing it */ ta_ctx->sep_used->current_hash_req = NULL; ta_ctx->sep_used->current_cypher_req = NULL; @@ -1001,7 +1001,7 @@ static void sep_clear_out(struct this_task_ctx *ta_ctx) ta_ctx->call_status.status = 0; - /* Remove anything confidentail */ + /* Remove anything confidential */ memset(ta_ctx->sep_used->shared_addr, 0, SEP_DRIVER_MESSAGE_SHARED_AREA_SIZE_IN_BYTES); @@ -1207,7 +1207,7 @@ static int sep_crypto_block_data(struct ablkcipher_request *req) req->nbytes, ta_ctx->walk.blocksize, &new_sg, 1); if (int_error < 0) { - dev_warn(&ta_ctx->sep_used->pdev->dev, "oddball page eerror\n"); + dev_warn(&ta_ctx->sep_used->pdev->dev, "oddball page error\n"); return -ENOMEM; } else if (int_error == 1) { ta_ctx->src_sg = new_sg; @@ -1870,7 +1870,7 @@ static u32 hash_update_post_op(struct sep_device *sep) sizeof(struct sep_hash_private_context)); /** -* Following is only for finup; if we just completd the +* Following is only for finup; if we just completed the * data portion of finup, we now need to kick off the * finish portion of finup. */ @@ -2011,7 +2011,7 @@ static u32 hash_digest_post_op(struct sep_device *sep) } /** - * The sep_finish function is the function that is schedule (via tasket) + * The sep_finish function is the function that is scheduled (via tasklet) * by the interrupt service routine when the SEP sends and interrupt * This is only called by the interrupt handler as a tasklet. */ @@ -2249,7 +2249,7 @@ static void sep_hash_update(void *data) head_len = (block_size - int_ctx->prev_update_bytes) % block_size; tail_len = (req->nbytes - head_len) % block_size; - /* Make sure all pages are even block */ + /* Make sure all pages are an even block */ int_error = sep_oddball_pages(ta_ctx->sep_used, req->src, req->nbytes, block_size, &new_sg, 1); @@ -2482,7 +2482,7 @@ static void sep_hash_digest(void *data) dev_dbg(&ta_ctx->sep_used->pdev->dev, "block_size is %x\n", block_size); dev_dbg(&ta_ctx->sep_used->pdev->dev, "tail len is %x\n", tail_len); - /* Make sure all pages are even block */ + /* Make sure all pages are an even block */ int_error = sep_oddball_pages(ta_ctx->sep_used, req->src, req->nbytes, block_size, &new_sg, 1); diff --git a/drivers/staging/sep/sep_driver_api.h b/drivers/staging/sep/sep_driver_api.h index 8b797d5..7ee1c3b 100644 --- a/drivers/staging/sep/sep_driver_api.h +++ b/drivers/sta
[PATCH]staging: "sbe-2t3e3" Fix typos in sbe-2t3e3
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos found while reading through sbe-2t3e3. drivers/staging/sbe-2t3e3/dc.c |2 +- drivers/staging/sbe-2t3e3/io.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sbe-2t3e3/dc.c b/drivers/staging/sbe-2t3e3/dc.c index 9dc4ec2..e897a43 100644 --- a/drivers/staging/sbe-2t3e3/dc.c +++ b/drivers/staging/sbe-2t3e3/dc.c @@ -81,7 +81,7 @@ void dc_init(struct channel *sc) SBE_2T3E3_21143_VAL_NUMBER_OF_RECEIVE_PACKETS; dc_write(sc->addr, SBE_2T3E3_21143_REG_GENERAL_PURPOSE_TIMER_AND_INTERRUPT_MITIGATION_CONTROL, val); - /* prepare descriptors and data for receive and transmit procecsses */ + /* prepare descriptors and data for receive and transmit processes */ if (dc_init_descriptor_list(sc) != 0) return; diff --git a/drivers/staging/sbe-2t3e3/io.c b/drivers/staging/sbe-2t3e3/io.c index 9a50bcc..d2391cb 100644 --- a/drivers/staging/sbe-2t3e3/io.c +++ b/drivers/staging/sbe-2t3e3/io.c @@ -17,7 +17,7 @@ /* All access to registers done via the 21143 on port 0 must be * protected via the card->bootrom_lock. */ -/* priviate define to be used here only - must be protected by card->bootrom_lock */ +/* private define to be used here only - must be protected by card->bootrom_lock */ #define cpld_write_nolock(channel, reg, val) \ bootrom_write((channel), CPLD_MAP_REG(reg, channel), val) -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
On 05/21/2012 08:26 AM, Dan Carpenter wrote: On Mon, May 21, 2012 at 07:54:47AM -0700, Justin P. Mattock wrote: On 05/21/2012 07:35 AM, Dan Carpenter wrote: On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote: From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock ^ Your scripts are adding an extra space here.i after git format-patch my signature is in the subject line. pressing enter a few times moves it down. is there a git command for properly aligning this? The first line is the subject and then you need to leave the next line of the commit blank. regards, dan carpenter ahh.. I know what im doing wrong, im not doing all of this while doing git commit -s -a. I add the subject etc.. after committing and formatting the patch. Justin P. Mattock ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH NEXT V2]staging "rts_pstor" fix some typos while reading through rts_pstor
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos while reading through rts_pstor. drivers/staging/rts_pstor/ms.c |2 +- drivers/staging/rts_pstor/sd.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c index 0bf6d95..7cc2b53 100644 --- a/drivers/staging/rts_pstor/ms.c +++ b/drivers/staging/rts_pstor/ms.c @@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip) if (!CHK_MSPRO(ms_card)) { /* Build table for the last segment, -* to check if L2P talbe block exist,erasing it +* to check if L2P table block exists, erasing it */ retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1); if (retval != STATUS_SUCCESS) { diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c index aab6909..b9474a8 100644 --- a/drivers/staging/rts_pstor/sd.c +++ b/drivers/staging/rts_pstor/sd.c @@ -1169,7 +1169,7 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, u8 mode, RTSX_DEBUGP("func_group4_mask = 0x%02x\n", buf[0x07]); } else { /* Maximum current consumption, check whether current is acceptable; -* bit[511:496] = 0x means some error happaned. +* bit[511:496] = 0x means some error happened. */ u16 cc = ((u16)buf[0] << 8) | buf[1]; RTSX_DEBUGP("Maximum current consumption: %dmA\n", cc); -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
Re: [PATCH NEXT]staging: "rts_pstor" Fix typos.
On 05/21/2012 07:35 AM, Dan Carpenter wrote: On Mon, May 21, 2012 at 07:19:15AM -0700, Justin P. Mattock wrote: From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock ^ Your scripts are adding an extra space here.i after git format-patch my signature is in the subject line. pressing enter a few times moves it down. is there a git command for properly aligning this? --- The below patch fixes some typos found while reading through rts_pstor. This could go in the patch description if you wanted. drivers/staging/rts_pstor/ms.c |2 +- drivers/staging/rts_pstor/sd.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c index 0bf6d95..3b75739 100644 --- a/drivers/staging/rts_pstor/ms.c +++ b/drivers/staging/rts_pstor/ms.c @@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip) if (!CHK_MSPRO(ms_card)) { /* Build table for the last segment, -* to check if L2P talbe block exist,erasing it +* to check if L2P table block exist,erasing it I still have no idea what this comment means but "exist" => "exists" and it needs a space after the comma. most of them I have no idea as well.. anyway resending with the fixes.. */ retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1); if (retval != STATUS_SUCCESS) { regards, dan carpenter Justin P. Mattock ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH NEXT]staging: "rts_pstor" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos found while reading through rts_pstor. drivers/staging/rts_pstor/ms.c |2 +- drivers/staging/rts_pstor/sd.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rts_pstor/ms.c b/drivers/staging/rts_pstor/ms.c index 0bf6d95..3b75739 100644 --- a/drivers/staging/rts_pstor/ms.c +++ b/drivers/staging/rts_pstor/ms.c @@ -2488,7 +2488,7 @@ int reset_ms_card(struct rtsx_chip *chip) if (!CHK_MSPRO(ms_card)) { /* Build table for the last segment, -* to check if L2P talbe block exist,erasing it +* to check if L2P table block exist,erasing it */ retval = ms_build_l2p_tbl(chip, ms_card->total_block / 512 - 1); if (retval != STATUS_SUCCESS) { diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c index aab6909..b9474a8 100644 --- a/drivers/staging/rts_pstor/sd.c +++ b/drivers/staging/rts_pstor/sd.c @@ -1169,7 +1169,7 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, u8 mode, RTSX_DEBUGP("func_group4_mask = 0x%02x\n", buf[0x07]); } else { /* Maximum current consumption, check whether current is acceptable; -* bit[511:496] = 0x means some error happaned. +* bit[511:496] = 0x means some error happened. */ u16 cc = ((u16)buf[0] << 8) | buf[1]; RTSX_DEBUGP("Maximum current consumption: %dmA\n", cc); -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH NEXT]staging: "rts5139" Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos found while reading through rts5139. drivers/staging/rts5139/ms.c |2 +- drivers/staging/rts5139/ms_mg.c|2 +- drivers/staging/rts5139/rts51x_chip.h | 10 +- drivers/staging/rts5139/rts51x_transport.c |2 +- drivers/staging/rts5139/sd.c |6 +++--- drivers/staging/rts5139/xd.c |2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rts5139/ms.c b/drivers/staging/rts5139/ms.c index 02aad2d..512f9f9 100644 --- a/drivers/staging/rts5139/ms.c +++ b/drivers/staging/rts5139/ms.c @@ -3149,7 +3149,7 @@ Fail: TRACE_RET(chip, STATUS_FAIL); sec_cnt = chip->rsp_buf[0]; - RTS51X_DEBUGP("%d pages need be trasferred, %d pages remained\n", + RTS51X_DEBUGP("%d pages need be transferred, %d pages remained\n", (int)page_cnt, (int)sec_cnt); page_addr = start_page + (page_cnt - sec_cnt); diff --git a/drivers/staging/rts5139/ms_mg.c b/drivers/staging/rts5139/ms_mg.c index 154b523..fcda587 100644 --- a/drivers/staging/rts5139/ms_mg.c +++ b/drivers/staging/rts5139/ms_mg.c @@ -444,7 +444,7 @@ int mg_rsp(struct scsi_cmnd *srb, struct rts51x_chip *chip) * * Since the extra 4 bytes data is just only a prefix to original data * that read from medium, so that the 4-byte data pushed into Ring buffer - * precedes data tramsinssion from medium to Ring buffer by DMA mechanisim + * precedes data transmission from medium to Ring buffer by DMA mechanism * in order to get maximum performance and minimum code size simultaneously. */ int mg_get_ICV(struct scsi_cmnd *srb, struct rts51x_chip *chip) diff --git a/drivers/staging/rts5139/rts51x_chip.h b/drivers/staging/rts5139/rts51x_chip.h index 13fc2a4..cd56012 100644 --- a/drivers/staging/rts5139/rts51x_chip.h +++ b/drivers/staging/rts5139/rts51x_chip.h @@ -222,7 +222,7 @@ struct trace_msg_t { #define HARDWARE_ERR0x04 /* hardware error */ #define ILGAL_REQ 0x05 /* CDB/parameter/identify msg error */ #define UNIT_ATTENTION 0x06 /* unit attention condition occur */ -#define DAT_PRTCT 0x07 /* read/write is desable*/ +#define DAT_PRTCT 0x07 /* read/write is disable*/ #define BLNC_CHK0x08 /* find blank/DOF in read */ /* write to unblank area*/ #define CPY_ABRT0x0a /* Copy/Compare/Copy&Verify illgal */ @@ -243,7 +243,7 @@ struct trace_msg_t { #define DEF_ERR 0x71 /* specific command error */ /* sense key Infomation */ -#define SNSKEYINFO_LEN 3 /* length of sense key infomation */ +#define SNSKEYINFO_LEN 3 /* length of sense key information */ #define SKSV0x80 #define CDB_ILLEGAL 0x40 @@ -298,11 +298,11 @@ struct sense_data_t { /* bit3-0 : sense key */ unsigned char info[4]; /* infomation */ unsigned char ad_sense_len; /* additional sense data length */ - unsigned char cmd_info[4]; /* command specific infomation */ + unsigned char cmd_info[4]; /* command specific information */ unsigned char asc; /* ASC */ unsigned char ascq; /* ASCQ */ unsigned char rfu; /* FRU */ - unsigned char sns_key_info[3]; /* sense key specific infomation*/ + unsigned char sns_key_info[3]; /* sense key specific information*/ }; /* sd_ctl bit map */ @@ -405,7 +405,7 @@ struct rts51x_option { u8 ddr50_rx_phase; u8 sdr50_tx_phase; u8 sdr50_rx_phase; - /* used to enable select sdr50 tx phase according to proportion. */ + /* used to enable select sdr50 tx phase according to proportion. */ u8 sdr50_phase_sel; u8 ms_errreg_fix; u8 reset_mmc_first; diff --git a/drivers/staging/rts5139/rts51x_transport.c b/drivers/staging/rts5139/rts51x_transport.c index da9c83b..8faae9a 100644 --- a/drivers/staging/rts5139/rts51x_transport.c +++ b/drivers/staging/rts5139/rts51x_transport.c @@ -630,7 +630,7 @@ int rts51x_sg_wait(struct usb_sg_request *io, int timeout) */ spin_unlock_irq(&io->lock); switch (retval) { - /* maybe we retrying will recover */ + /* maybe the retry will recover */ case -ENXIO:/* hc didn't queue this one */ case -EAGAIN: case -ENOMEM: diff --git a/drivers/staging/rts5139/sd.c b/drivers/staging/rts5139
Re: [PATCH] staging: media: go7007: Adlink MPG24 board issues
if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) return -ENODEV; - dec = kmalloc(sizeof(struct wis_tw2804), GFP_KERNEL); + dec = kzalloc(sizeof(struct wis_tw2804), GFP_KERNEL); + if (dec == NULL) return -ENOMEM; - + sd =&dec->sd; + dec->update = 1; dec->channel = -1; dec->norm = V4L2_STD_NTSC; dec->brightness = 128; dec->contrast = 128; dec->saturation = 128; dec->hue = 128; - i2c_set_clientdata(client, dec); + dec->gain = 128; + dec->cr_gain = 128; + dec->b_balance = 122; + dec->r_balance = 122; + v4l2_i2c_subdev_init(sd, client,&tw2804_ops); printk(KERN_DEBUG "wis-tw2804: creating TW2804 at address %d on %s\n", client->addr, adapter->name); @@ -319,9 +534,10 @@ static int wis_tw2804_probe(struct i2c_client *client, static int wis_tw2804_remove(struct i2c_client *client) { - struct wis_tw2804 *dec = i2c_get_clientdata(client); + struct v4l2_subdev *sd = i2c_get_clientdata(client); - kfree(dec); + v4l2_device_unregister_subdev(sd); + kfree(to_state(sd)); return 0; } Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH NEXT]staging: "rtl8192e/r8192u" typo change ContiuneDiffCount.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- As mentioned by jesper juhl, we should probably change ContiuneDiffCount to ContinueDiffCount. Below you will find the changes to do so. I have compile tested this and everything builds with the changes, as for testing on the hardware I am unable to do. drivers/staging/rtl8192e/rtl8192e/rtl_core.h |2 +- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 20 ++-- drivers/staging/rtl8192u/r8192U.h|2 +- drivers/staging/rtl8192u/r8192U_dm.c | 20 ++-- 4 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index cebb748..320d5fc 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -943,7 +943,7 @@ struct r8192_priv { boolbfsync_processing; u32 rate_record; u32 rateCountDiffRecord; - u32 ContiuneDiffCount; + u32 ContinueDiffCount; boolbswitch_fsync; u8 framesync; u32 framesyncC34; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index 2dfb0f0..481b1e4 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -2615,22 +2615,22 @@ void dm_fsync_timer_callback(unsigned long data) rate_count_diff; if (DiffNum >= priv->rtllib->fsync_seconddiff_ratethreshold) - priv->ContiuneDiffCount++; + priv->ContinueDiffCount++; else - priv->ContiuneDiffCount = 0; + priv->ContinueDiffCount = 0; - if (priv->ContiuneDiffCount >= 2) { + if (priv->ContinueDiffCount >= 2) { bSwitchFromCountDiff = true; - priv->ContiuneDiffCount = 0; + priv->ContinueDiffCount = 0; } } else { - priv->ContiuneDiffCount = 0; + priv->ContinueDiffCount = 0; } if (rate_count_diff <= priv->rtllib->fsync_firstdiff_ratethreshold) { bSwitchFromCountDiff = true; - priv->ContiuneDiffCount = 0; + priv->ContinueDiffCount = 0; } priv->rate_record = rate_count; priv->rateCountDiffRecord = rate_count_diff; @@ -2677,10 +2677,10 @@ void dm_fsync_timer_callback(unsigned long data) write_nic_byte(dev, 0xC36, 0x5c); write_nic_byte(dev, 0xC3e, 0x96); } - priv->ContiuneDiffCount = 0; + priv->ContinueDiffCount = 0; write_nic_dword(dev, rOFDM0_RxDetector2, 0x465c52cd); } - RT_TRACE(COMP_HALDM, "ContiuneDiffCount %d\n", priv->ContiuneDiffCount); + RT_TRACE(COMP_HALDM, "ContinueDiffCount %d\n", priv->ContinueDiffCount); RT_TRACE(COMP_HALDM, "rateRecord %d rateCount %d, rateCountdiff %d " "bSwitchFsync %d\n", priv->rate_record, rate_count, rate_count_diff, priv->bswitch_fsync); @@ -2723,7 +2723,7 @@ static void dm_EndSWFsync(struct net_device *dev) write_nic_byte(dev, 0xC3e, 0x96); } - priv->ContiuneDiffCount = 0; + priv->ContinueDiffCount = 0; write_nic_dword(dev, rOFDM0_RxDetector2, 0x465c52cd); } @@ -2735,7 +2735,7 @@ static void dm_StartSWFsync(struct net_device *dev) RT_TRACE(COMP_HALDM, "%s\n", __func__); priv->rate_record = 0; - priv->ContiuneDiffCount = 0; + priv->ContinueDiffCount = 0; priv->rateCountDiffRecord = 0; priv->bswitch_fsync = false; diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h index b4e99f4..57e3383 100644 --- a/drivers/staging/rtl8192u/r8192U.h +++ b/drivers/staging/rtl8192u/r8192U.h @@ -1116,7 +1116,7 @@ typedef struct r8192_priv bool bfsync_processing; // 500ms Fsync timer is active or not u32 rate_record; u32 rateCountDiffRecord; - u32 ContiuneDiffCount; + u32 ContinueDiffCount; bool bswitch_fsync; u8 framesync; diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 996e658..cd8dc85 100644 --- a/drivers/staging/rtl819
Re: [PATCH NEXT]staging: rtl8192u Fix typos.
On 04/30/2012 02:05 PM, Jesper Juhl wrote: On Mon, 30 Apr 2012, Justin P. Mattock wrote: On 04/30/2012 01:41 PM, Jesper Juhl wrote: On Mon, 30 Apr 2012, Justin P. Mattock wrote: From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos that I found while going through staging/rtl8192u I think it needs a little more work - see below. drivers/staging/rtl8192u/r8180_93cx6.c |2 +- drivers/staging/rtl8192u/r8180_93cx6.h |2 +- drivers/staging/rtl8192u/r8192U.h |6 +- drivers/staging/rtl8192u/r8192U_core.c | 56 ++-- drivers/staging/rtl8192u/r8192U_dm.c | 50 drivers/staging/rtl8192u/r8192U_hw.h |2 +- drivers/staging/rtl8192u/r8192U_wx.c |8 ++-- drivers/staging/rtl8192u/r8192U_wx.h |2 +- drivers/staging/rtl8192u/r819xU_HTType.h |2 +- drivers/staging/rtl8192u/r819xU_cmdpkt.c |8 ++-- drivers/staging/rtl8192u/r819xU_firmware.c |4 +- drivers/staging/rtl8192u/r819xU_phy.c | 16 drivers/staging/rtl8192u/r819xU_phyreg.h |2 +- 13 files changed, 80 insertions(+), 80 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c index 8878cfe..0e8ff75 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.c +++ b/drivers/staging/rtl8192u/r8180_93cx6.c @@ -14,7 +14,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - We want to tanks the Authors of those projects and the Ndiswrapper + We want to thanks the Authors of those projects and the Ndiswrapper project Authors. I believe this would be better like this: We want to thank the authors of those projects and the Ndiswrapper project authors. */ diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h b/drivers/staging/rtl8192u/r8180_93cx6.h index fb3ac97..3527d32 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.h +++ b/drivers/staging/rtl8192u/r8180_93cx6.h @@ -7,7 +7,7 @@ Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke& Andres Salomon Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to tanks the Authors of such projects and the Ndiswrapper project Authors. + We want to thanks the Authors of such projects and the Ndiswrapper project Authors. Same comment as above "We want to thank .." rather than "We want to thanks ..". And "authors" rather than "Authors". */ /*This files contains card eeprom (93c46 or 93c56) programming routines*/ diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h index 43d459d..adeb724 100644 --- a/drivers/staging/rtl8192u/r8192U.h +++ b/drivers/staging/rtl8192u/r8192U.h @@ -11,7 +11,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to tanks the Authors of those projects and the Ndiswrapper + We want to thanks the Authors of those projects and the Ndiswrapper project Authors. Same comment as above. */ @@ -98,7 +98,7 @@ do { if(rt_global_debug_component& component) \ #define COMP_INITBIT2// during driver initialization / halt / reset. -#define COMP_RECV BIT3// Reveive part data path. +#define COMP_RECV BIT3// Revive part data path. Are you sure that "Receive data path." is not what was intended here? #define COMP_SENDBIT4// Send part path. #define COMP_IO BIT5// I/O Related. Added by Annie, 2006-03-02. #define COMP_POWER BIT6// 802.11 Power Save mode or System/Device Power state related. @@ -322,7 +322,7 @@ typedef struct _tx_fwinfo_819x_usb { u8 TxSubCarrier:2; // This is used for legacy OFDM rate only. u8 STBC:2; u8 AllowAggregation:1; -u8 RtsHT:1;//Interpre RtsRate field as high throughput data rate +u8 RtsHT:1;//Interprete RtsRate field as high throughput data rate I believe this should be "Interpret RtsRate field as high throughput data rate". u8 RtsShort:1; //Short PLCP for CCK, or short GI for 11n MCS u8 RtsBandwidth:1; // This is used for HT MCS rate only. u8 RtsSubcarrier:2;// This is used for legacy OFDM rate only. diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 9c00865..be86045 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl
[PATCH NEXT]staging:rtl8192u Fix typos and comments
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some comments after being revised by jesper juhl. drivers/staging/rtl8192u/r8192U.h |4 ++-- drivers/staging/rtl8192u/r8192U_core.c | 24 drivers/staging/rtl8192u/r8192U_dm.c | 16 drivers/staging/rtl8192u/r819xU_cmdpkt.c |2 +- drivers/staging/rtl8192u/r819xU_firmware.c |2 +- drivers/staging/rtl8192u/r819xU_phy.c |4 ++-- 6 files changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h index ebcb5b0..b4e99f4 100644 --- a/drivers/staging/rtl8192u/r8192U.h +++ b/drivers/staging/rtl8192u/r8192U.h @@ -98,7 +98,7 @@ do { if(rt_global_debug_component & component) \ #define COMP_INIT BIT2// during driver initialization / halt / reset. -#define COMP_RECV BIT3// Revive part data path. +#define COMP_RECV BIT3// Receive data path. #define COMP_SEND BIT4// Send part path. #define COMP_IOBIT5// I/O Related. Added by Annie, 2006-03-02. #define COMP_POWER BIT6// 802.11 Power Save mode or System/Device Power state related. @@ -322,7 +322,7 @@ typedef struct _tx_fwinfo_819x_usb { u8 TxSubCarrier:2; // This is used for legacy OFDM rate only. u8 STBC:2; u8 AllowAggregation:1; -u8 RtsHT:1;//Interprete RtsRate field as high throughput data rate +u8 RtsHT:1;//Interpret RtsRate field as high throughput data rate u8 RtsShort:1; //Short PLCP for CCK, or short GI for 11n MCS u8 RtsBandwidth:1; // This is used for HT MCS rate only. u8 RtsSubcarrier:2;// This is used for legacy OFDM rate only. diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index be86045..5981d66 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -203,7 +203,7 @@ static void rtl819x_set_channel_map(u8 channel_plan, struct r8192_priv* priv) { Dot11d_Init(ieee); ieee->bGlobalDomain = false; - //actually 8225 & 8256 rf chip only support B,G,24N mode + //actually 8225 & 8256 rf chips only support B,G,24N mode if ((priv->rf_chip == RF_8225) || (priv->rf_chip == RF_8256)) { min_chan = 1; @@ -1476,7 +1476,7 @@ static void rtl8192_tx_isr(struct urb *tx_urb) if(tcb_desc->queue_index != TXCMD_QUEUE) { if(tx_urb->status == 0) { dev->trans_start = jiffies; - // As act as station mode, destination shall be unicast address. + // Act as station mode, destination shall be unicast address. //priv->ieee80211->stats.tx_bytes+=(skb->len - priv->ieee80211->tx_headroom); //priv->ieee80211->stats.tx_packets++; priv->stats.txoktotal++; @@ -1527,8 +1527,8 @@ static void rtl8192_tx_isr(struct urb *tx_urb) *function, it should contain enough tx irq; * 2. check packet type; * 3. initialize sendlist, check whether the to-be send packet no greater than 1 -* 4. aggregates the packets, and fill firmware info and tx desc to it, etc. -* 5. check whether the packet could be sent, otherwise just insert to wait head +* 4. aggregates the packets, and fill firmware info and tx desc into it, etc. +* 5. check whether the packet could be sent, otherwise just insert into wait head * */ skb = skb_dequeue(&priv->ieee80211->skb_drv_aggQ[queue_index]); if(!check_nic_enough_desc(dev, queue_index)) { @@ -2783,7 +2783,7 @@ static void rtl8192_init_priv_variable(struct net_device* dev) (TCR_MXDMA_2048<ShortRetryLimit<LongRetryLimit<bInHctTest) pHalData->ReceiveConfig = pHalData->CSMethod | @@ -3437,7 +3437,7 @@ if(Adapter->ResetProgress == RESET_TYPE_NORESET) { // User disable RF via registry. RT_TRACE((COMP_I
Re: [PATCH NEXT]staging: rtl8192u Fix typos.
On 04/30/2012 01:41 PM, Jesper Juhl wrote: On Mon, 30 Apr 2012, Justin P. Mattock wrote: From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos that I found while going through staging/rtl8192u I think it needs a little more work - see below. drivers/staging/rtl8192u/r8180_93cx6.c |2 +- drivers/staging/rtl8192u/r8180_93cx6.h |2 +- drivers/staging/rtl8192u/r8192U.h |6 +- drivers/staging/rtl8192u/r8192U_core.c | 56 ++-- drivers/staging/rtl8192u/r8192U_dm.c | 50 drivers/staging/rtl8192u/r8192U_hw.h |2 +- drivers/staging/rtl8192u/r8192U_wx.c |8 ++-- drivers/staging/rtl8192u/r8192U_wx.h |2 +- drivers/staging/rtl8192u/r819xU_HTType.h |2 +- drivers/staging/rtl8192u/r819xU_cmdpkt.c |8 ++-- drivers/staging/rtl8192u/r819xU_firmware.c |4 +- drivers/staging/rtl8192u/r819xU_phy.c | 16 drivers/staging/rtl8192u/r819xU_phyreg.h |2 +- 13 files changed, 80 insertions(+), 80 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c index 8878cfe..0e8ff75 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.c +++ b/drivers/staging/rtl8192u/r8180_93cx6.c @@ -14,7 +14,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - We want to tanks the Authors of those projects and the Ndiswrapper + We want to thanks the Authors of those projects and the Ndiswrapper project Authors. I believe this would be better like this: We want to thank the authors of those projects and the Ndiswrapper project authors. */ diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h b/drivers/staging/rtl8192u/r8180_93cx6.h index fb3ac97..3527d32 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.h +++ b/drivers/staging/rtl8192u/r8180_93cx6.h @@ -7,7 +7,7 @@ Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke& Andres Salomon Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to tanks the Authors of such projects and the Ndiswrapper project Authors. + We want to thanks the Authors of such projects and the Ndiswrapper project Authors. Same comment as above "We want to thank .." rather than "We want to thanks ..". And "authors" rather than "Authors". */ /*This files contains card eeprom (93c46 or 93c56) programming routines*/ diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h index 43d459d..adeb724 100644 --- a/drivers/staging/rtl8192u/r8192U.h +++ b/drivers/staging/rtl8192u/r8192U.h @@ -11,7 +11,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to tanks the Authors of those projects and the Ndiswrapper + We want to thanks the Authors of those projects and the Ndiswrapper project Authors. Same comment as above. */ @@ -98,7 +98,7 @@ do { if(rt_global_debug_component& component) \ #define COMP_INIT BIT2// during driver initialization / halt / reset. -#define COMP_RECV BIT3// Reveive part data path. +#define COMP_RECV BIT3// Revive part data path. Are you sure that "Receive data path." is not what was intended here? #define COMP_SEND BIT4// Send part path. #define COMP_IO BIT5// I/O Related. Added by Annie, 2006-03-02. #define COMP_POWERBIT6// 802.11 Power Save mode or System/Device Power state related. @@ -322,7 +322,7 @@ typedef struct _tx_fwinfo_819x_usb { u8TxSubCarrier:2; // This is used for legacy OFDM rate only. u8STBC:2; u8AllowAggregation:1; -u8 RtsHT:1;//Interpre RtsRate field as high throughput data rate +u8 RtsHT:1;//Interprete RtsRate field as high throughput data rate I believe this should be "Interpret RtsRate field as high throughput data rate". u8RtsShort:1; //Short PLCP for CCK, or short GI for 11n MCS u8RtsBandwidth:1; // This is used for HT MCS rate only. u8RtsSubcarrier:2;// This is used for legacy OFDM rate only. diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 9c00865..be86045 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -203,7 +203,7 @@ static void rtl819x_set_channel_map(u8 channel_plan, struct
[PATCH NEXT]staging: rtl8192u Fix a typo.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- NOTE: I had not realized that my previous applied patch had created a typo. Thanks to Larry Finger for pointing this out to me. So either you take this one on top of the original and/or I send you the original with the updated fix. The below patch removes an "s" from "thanks" to make it proper. drivers/staging/rtl8192u/r8180_93cx6.c |2 +- drivers/staging/rtl8192u/r8180_93cx6.h |2 +- drivers/staging/rtl8192u/r8192U.h |2 +- drivers/staging/rtl8192u/r8192U_hw.h |2 +- drivers/staging/rtl8192u/r8192U_wx.c |2 +- drivers/staging/rtl8192u/r8192U_wx.h |2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c index 0e8ff75..3c515b7 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.c +++ b/drivers/staging/rtl8192u/r8180_93cx6.c @@ -14,7 +14,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - We want to thanks the Authors of those projects and the Ndiswrapper + We want to thank the Authors of those projects and the Ndiswrapper project Authors. */ diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h b/drivers/staging/rtl8192u/r8180_93cx6.h index 3527d32..5cea51e 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.h +++ b/drivers/staging/rtl8192u/r8180_93cx6.h @@ -7,7 +7,7 @@ Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke & Andres Salomon Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to thanks the Authors of such projects and the Ndiswrapper project Authors. + We want to thank the Authors of such projects and the Ndiswrapper project Authors. */ /*This files contains card eeprom (93c46 or 93c56) programming routines*/ diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h index adeb724..ebcb5b0 100644 --- a/drivers/staging/rtl8192u/r8192U.h +++ b/drivers/staging/rtl8192u/r8192U.h @@ -11,7 +11,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to thanks the Authors of those projects and the Ndiswrapper + We want to thank the Authors of those projects and the Ndiswrapper project Authors. */ diff --git a/drivers/staging/rtl8192u/r8192U_hw.h b/drivers/staging/rtl8192u/r8192U_hw.h index b0ee4dd..1bfe871 100644 --- a/drivers/staging/rtl8192u/r8192U_hw.h +++ b/drivers/staging/rtl8192u/r8192U_hw.h @@ -10,7 +10,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - We want to thanks the Authors of those projects + We want to thank the Authors of those projects and the Ndiswrapper project Authors. */ diff --git a/drivers/staging/rtl8192u/r8192U_wx.c b/drivers/staging/rtl8192u/r8192U_wx.c index 2ce0fc8..71f2d23 100644 --- a/drivers/staging/rtl8192u/r8192U_wx.c +++ b/drivers/staging/rtl8192u/r8192U_wx.c @@ -13,7 +13,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - We want to thanks the Authors of those projects and the Ndiswrapper + We want to thank the Authors of those projects and the Ndiswrapper project Authors. */ diff --git a/drivers/staging/rtl8192u/r8192U_wx.h b/drivers/staging/rtl8192u/r8192U_wx.h index 1388664..9f6b105 100644 --- a/drivers/staging/rtl8192u/r8192U_wx.h +++ b/drivers/staging/rtl8192u/r8192U_wx.h @@ -7,7 +7,7 @@ Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke & Andres Salomon Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to thanks the Authors of such projects and the Ndiswrapper project Authors. + We want to thank the Authors of such projects and the Ndiswrapper project Authors. */ /* this file (will) contains wireless extension handlers*/ -- 1.7.5.4 ___ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
[PATCH NEXT]staging: rtl8192u Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos that I found while going through staging/rtl8192u drivers/staging/rtl8192u/r8180_93cx6.c |2 +- drivers/staging/rtl8192u/r8180_93cx6.h |2 +- drivers/staging/rtl8192u/r8192U.h |6 +- drivers/staging/rtl8192u/r8192U_core.c | 56 ++-- drivers/staging/rtl8192u/r8192U_dm.c | 50 drivers/staging/rtl8192u/r8192U_hw.h |2 +- drivers/staging/rtl8192u/r8192U_wx.c |8 ++-- drivers/staging/rtl8192u/r8192U_wx.h |2 +- drivers/staging/rtl8192u/r819xU_HTType.h |2 +- drivers/staging/rtl8192u/r819xU_cmdpkt.c |8 ++-- drivers/staging/rtl8192u/r819xU_firmware.c |4 +- drivers/staging/rtl8192u/r819xU_phy.c | 16 drivers/staging/rtl8192u/r819xU_phyreg.h |2 +- 13 files changed, 80 insertions(+), 80 deletions(-) diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c b/drivers/staging/rtl8192u/r8180_93cx6.c index 8878cfe..0e8ff75 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.c +++ b/drivers/staging/rtl8192u/r8180_93cx6.c @@ -14,7 +14,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver. - We want to tanks the Authors of those projects and the Ndiswrapper + We want to thanks the Authors of those projects and the Ndiswrapper project Authors. */ diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h b/drivers/staging/rtl8192u/r8180_93cx6.h index fb3ac97..3527d32 100644 --- a/drivers/staging/rtl8192u/r8180_93cx6.h +++ b/drivers/staging/rtl8192u/r8180_93cx6.h @@ -7,7 +7,7 @@ Parts of this driver are based on the rtl8180 driver skeleton from Patric Schenke & Andres Salomon Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to tanks the Authors of such projects and the Ndiswrapper project Authors. + We want to thanks the Authors of such projects and the Ndiswrapper project Authors. */ /*This files contains card eeprom (93c46 or 93c56) programming routines*/ diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h index 43d459d..adeb724 100644 --- a/drivers/staging/rtl8192u/r8192U.h +++ b/drivers/staging/rtl8192u/r8192U.h @@ -11,7 +11,7 @@ Parts of this driver are based on the Intel Pro Wireless 2100 GPL driver - We want to tanks the Authors of those projects and the Ndiswrapper + We want to thanks the Authors of those projects and the Ndiswrapper project Authors. */ @@ -98,7 +98,7 @@ do { if(rt_global_debug_component & component) \ #define COMP_INIT BIT2// during driver initialization / halt / reset. -#define COMP_RECV BIT3// Reveive part data path. +#define COMP_RECV BIT3// Revive part data path. #define COMP_SEND BIT4// Send part path. #define COMP_IOBIT5// I/O Related. Added by Annie, 2006-03-02. #define COMP_POWER BIT6// 802.11 Power Save mode or System/Device Power state related. @@ -322,7 +322,7 @@ typedef struct _tx_fwinfo_819x_usb { u8 TxSubCarrier:2; // This is used for legacy OFDM rate only. u8 STBC:2; u8 AllowAggregation:1; -u8 RtsHT:1;//Interpre RtsRate field as high throughput data rate +u8 RtsHT:1;//Interprete RtsRate field as high throughput data rate u8 RtsShort:1; //Short PLCP for CCK, or short GI for 11n MCS u8 RtsBandwidth:1; // This is used for HT MCS rate only. u8 RtsSubcarrier:2;// This is used for legacy OFDM rate only. diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c index 9c00865..be86045 100644 --- a/drivers/staging/rtl8192u/r8192U_core.c +++ b/drivers/staging/rtl8192u/r8192U_core.c @@ -203,7 +203,7 @@ static void rtl819x_set_channel_map(u8 channel_plan, struct r8192_priv* priv) { Dot11d_Init(ieee); ieee->bGlobalDomain = false; - //acturally 8225 & 8256 rf chip only support B,G,24N mode + //actually 8225 & 8256 rf chip only support B,G,24N mode if ((priv->rf_chip == RF_8225) || (priv->rf_chip == RF_8256)) { min_chan = 1; @@ -1103,7 +1103,7 @@ inline u16 rtl8192_rate2rate(short rate) } -/* The protype of rx_isr has changed since one verion of Linux Kernel */ +/* The prototype of rx_isr has changed since one vers
[PATCH NEXT]staging: rtl8192e: Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- The below patch fixes some typos that I found while doing a little bit of reading in the staging directory. drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h |4 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.c |2 +- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c|2 +- drivers/staging/rtl8192e/rtllib.h | 18 ++-- drivers/staging/rtl8192e/rtllib_rx.c |4 +- drivers/staging/rtl8192e/rtllib_softmac.c | 32 ++-- drivers/staging/rtl8192e/rtllib_softmac_wx.c |4 +- drivers/staging/rtl8192e/rtllib_tx.c |6 ++-- drivers/staging/rtl8192e/rtllib_wx.c |2 +- 9 files changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h b/drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h index d5de279..970298b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h +++ b/drivers/staging/rtl8192e/rtl8192e/r819xE_phyreg.h @@ -306,7 +306,7 @@ #define bRFStart 0xf000 #define bBBStart 0x00f0 #define bBBCCKStart0x000f -/* Reg)x814 */ +/* Reg x814 */ #define bPAEnd 0xf #define bTREnd 0x0f00 #define bRFEnd 0x000f @@ -844,7 +844,7 @@ #define bRTL8258_RxLPFBW 0xc00 #define bRTL8258_RSSILPFBW0xc0 -/* byte endable for sb_write */ +/* byte enable for sb_write */ #define bByte00x1 #define bByte10x2 #define bByte20x4 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 7c676c2..97a5f49 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1025,7 +1025,7 @@ static int rtl8192_sta_down(struct net_device *dev, bool shutdownrf) break; } RT_TRACE(COMP_DBG, "===>%s():RF is in progress, need to wait " -"until rf chang is done.\n", __func__); +"until rf change is done.\n", __func__); mdelay(1); RFInProgressTimeOut++; spin_lock_irqsave(&priv->rf_ps_lock, flags); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c index f026b71..2dfb0f0 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -493,7 +493,7 @@ static void dm_TXPowerTrackingCallback_TSSI(struct net_device *dev) if (priv->bResetInProgress) { RT_TRACE(COMP_POWER_TRACKING, -"we are in slient reset progress, so return\n"); +"we are in silent reset progress, so return\n"); write_nic_byte(dev, Pw_Track_Flag, 0); write_nic_byte(dev, FW_Busy_Flag, 0); return; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index e26aec8..d7460ae 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -169,7 +169,7 @@ struct cb_desc { u8 nStuckCount; - /* Tx Firmware Relaged flags (10-11)*/ + /* Tx Firmware Related flags (10-11)*/ u8 bCTSEnable:1; u8 bRTSEnable:1; u8 bUseShortGI:1; @@ -1690,7 +1690,7 @@ enum rtllib_state { /* the association procedure is sending AUTH request*/ RTLLIB_ASSOCIATING_AUTHENTICATING, - /* the association procedure has successfully authentcated + /* the association procedure has successfully authenticated * and is sending association request */ RTLLIB_ASSOCIATING_AUTHENTICATED, @@ -2409,7 +2409,7 @@ struct rtllib_device { /* used instead of hard_start_xmit (not softmac_hard_start_xmit) * if the IEEE_SOFTMAC_TX_QUEUE feature is used to TX data -* frames. I the option IEEE_SOFTMAC_SINGLE_QUEUE is also set +* frames. If the option IEEE_SOFTMAC_SINGLE_QUEUE is also set * then also management frames are sent via this callback. * This function can't sleep. */ @@ -2422,12 +2422,12 @@ struct rtllib_device { */ void (*data_hard_stop)(struct net_device *dev); - /* OK this is complementar to data_poll_hard_stop */ + /* OK this is complementing to data_poll_hard_stop */ void (*data_hard_resume)(struct net_device *dev); /* ask to the driver to retune the radio . * This function can
[PATCH v3 NEXT]Staging: rtl8187se: Fix typos.
From: "Justin P. Mattock" Signed-off-by: Justin P. Mattock --- RESEND: This is a resend because I had git config wrong with my email address. The below patch fixes some typos that I found while reading. drivers/staging/rtl8187se/Makefile |2 +- drivers/staging/rtl8187se/ieee80211/dot11d.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211.h| 14 .../rtl8187se/ieee80211/ieee80211_softmac.c| 24 .../rtl8187se/ieee80211/ieee80211_softmac_wx.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c |2 +- drivers/staging/rtl8187se/r8180.h | 10 +++--- drivers/staging/rtl8187se/r8180_core.c | 30 ++-- drivers/staging/rtl8187se/r8180_dm.c | 16 +- drivers/staging/rtl8187se/r8180_rtl8225z2.c|4 +- drivers/staging/rtl8187se/r8180_wx.c |6 ++-- drivers/staging/rtl8187se/r8180_wx.h |2 +- drivers/staging/rtl8187se/r8185b_init.c| 10 +++--- 14 files changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile index 72db504..91d1aa2 100644 --- a/drivers/staging/rtl8187se/Makefile +++ b/drivers/staging/rtl8187se/Makefile @@ -10,7 +10,7 @@ ccflags-y += -DHIGH_POWER ccflags-y += -DSW_DIG ccflags-y += -DRATE_ADAPT -#enable it for legacy power save, disable it for leisure power save +#enable it for legacy power save, disable it for leisure power save ccflags-y += -DENABLE_LPS diff --git a/drivers/staging/rtl8187se/ieee80211/dot11d.c b/drivers/staging/rtl8187se/ieee80211/dot11d.c index 309bb8b..0e93eb0 100644 --- a/drivers/staging/rtl8187se/ieee80211/dot11d.c +++ b/drivers/staging/rtl8187se/ieee80211/dot11d.c @@ -55,7 +55,7 @@ Dot11d_Reset(struct ieee80211_device *ieee) // // Description: -// Update country IE from Beacon or Probe Resopnse +// Update country IE from Beacon or Probe Response // and configure PHY for operation in the regulatory domain. // // TODO: diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211.h b/drivers/staging/rtl8187se/ieee80211/ieee80211.h index 40dd715..b94c48b 100644 --- a/drivers/staging/rtl8187se/ieee80211/ieee80211.h +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211.h @@ -834,7 +834,7 @@ enum ieee80211_state { /* the association procedure is sending AUTH request*/ IEEE80211_ASSOCIATING_AUTHENTICATING, - /* the association procedure has successfully authentcated + /* the association procedure has successfully authenticated * and is sending association request */ IEEE80211_ASSOCIATING_AUTHENTICATED, @@ -934,7 +934,7 @@ struct ieee80211_device { * with RX of broad/multicast frames */ /* Fragmentation structures */ - // each streaming contain a entry + /* each stream contains an entry */ struct ieee80211_frag_entry frag_cache[17][IEEE80211_FRAG_CACHE_LEN]; unsigned int frag_next_idx[17]; u16 fts; /* Fragmentation Threshold */ @@ -972,7 +972,7 @@ struct ieee80211_device { int rate; /* current rate */ int basic_rate; - //FIXME: pleace callback, see if redundant with softmac_features + //FIXME: please callback, see if redundant with softmac_features short active_scan; /* this contains flags for selectively enable softmac support */ @@ -1106,7 +1106,7 @@ struct ieee80211_device { /* used instead of hard_start_xmit (not softmac_hard_start_xmit) * if the IEEE_SOFTMAC_TX_QUEUE feature is used to TX data -* frames. I the option IEEE_SOFTMAC_SINGLE_QUEUE is also set +* frames. If the option IEEE_SOFTMAC_SINGLE_QUEUE is also set * then also management frames are sent via this callback. * This function can't sleep. */ @@ -1124,7 +1124,7 @@ struct ieee80211_device { /* ask to the driver to retune the radio . * This function can sleep. the driver should ensure -* the radio has been swithced before return. +* the radio has been switched before return. */ void (*set_chan)(struct net_device *dev,short ch); @@ -1135,7 +1135,7 @@ struct ieee80211_device { * The syncro version is similar to the start_scan but * does not return until all channels has been scanned. * this is called in user context and should sleep, -* it is called in a work_queue when swithcing to ad-hoc mode +* it is called in a work_queue when switching to ad-hoc mode * or in behalf of iwlist scan when the card is associated * and root user ask for a scan. * the function stop_scan should stop both the syncro and @@ -1196,7 +1196,7 @@ struct i
[PATCH v2]NEXT:drivers:staging:rtl8187se Fix typos in staging:rtl8187se
From: "Justin P. Mattock" RESEND: resending this patch because my email was mangled with gitconfig. The below patch fixes some typos that I found while reading. Signed-off-by: Justin P. Mattock --- drivers/staging/rtl8187se/Makefile |2 +- drivers/staging/rtl8187se/ieee80211/dot11d.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211.h| 14 .../rtl8187se/ieee80211/ieee80211_softmac.c| 24 .../rtl8187se/ieee80211/ieee80211_softmac_wx.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c |2 +- drivers/staging/rtl8187se/r8180.h | 10 +++--- drivers/staging/rtl8187se/r8180_core.c | 30 ++-- drivers/staging/rtl8187se/r8180_dm.c | 16 +- drivers/staging/rtl8187se/r8180_rtl8225z2.c|4 +- drivers/staging/rtl8187se/r8180_wx.c |6 ++-- drivers/staging/rtl8187se/r8180_wx.h |2 +- drivers/staging/rtl8187se/r8185b_init.c| 10 +++--- 14 files changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile index 72db504..91d1aa2 100644 --- a/drivers/staging/rtl8187se/Makefile +++ b/drivers/staging/rtl8187se/Makefile @@ -10,7 +10,7 @@ ccflags-y += -DHIGH_POWER ccflags-y += -DSW_DIG ccflags-y += -DRATE_ADAPT -#enable it for legacy power save, disable it for leisure power save +#enable it for legacy power save, disable it for leisure power save ccflags-y += -DENABLE_LPS diff --git a/drivers/staging/rtl8187se/ieee80211/dot11d.c b/drivers/staging/rtl8187se/ieee80211/dot11d.c index 309bb8b..0e93eb0 100644 --- a/drivers/staging/rtl8187se/ieee80211/dot11d.c +++ b/drivers/staging/rtl8187se/ieee80211/dot11d.c @@ -55,7 +55,7 @@ Dot11d_Reset(struct ieee80211_device *ieee) // // Description: -// Update country IE from Beacon or Probe Resopnse +// Update country IE from Beacon or Probe Response // and configure PHY for operation in the regulatory domain. // // TODO: diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211.h b/drivers/staging/rtl8187se/ieee80211/ieee80211.h index 40dd715..b94c48b 100644 --- a/drivers/staging/rtl8187se/ieee80211/ieee80211.h +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211.h @@ -834,7 +834,7 @@ enum ieee80211_state { /* the association procedure is sending AUTH request*/ IEEE80211_ASSOCIATING_AUTHENTICATING, - /* the association procedure has successfully authentcated + /* the association procedure has successfully authenticated * and is sending association request */ IEEE80211_ASSOCIATING_AUTHENTICATED, @@ -934,7 +934,7 @@ struct ieee80211_device { * with RX of broad/multicast frames */ /* Fragmentation structures */ - // each streaming contain a entry + /* each stream contains an entry */ struct ieee80211_frag_entry frag_cache[17][IEEE80211_FRAG_CACHE_LEN]; unsigned int frag_next_idx[17]; u16 fts; /* Fragmentation Threshold */ @@ -972,7 +972,7 @@ struct ieee80211_device { int rate; /* current rate */ int basic_rate; - //FIXME: pleace callback, see if redundant with softmac_features + //FIXME: please callback, see if redundant with softmac_features short active_scan; /* this contains flags for selectively enable softmac support */ @@ -1106,7 +1106,7 @@ struct ieee80211_device { /* used instead of hard_start_xmit (not softmac_hard_start_xmit) * if the IEEE_SOFTMAC_TX_QUEUE feature is used to TX data -* frames. I the option IEEE_SOFTMAC_SINGLE_QUEUE is also set +* frames. If the option IEEE_SOFTMAC_SINGLE_QUEUE is also set * then also management frames are sent via this callback. * This function can't sleep. */ @@ -1124,7 +1124,7 @@ struct ieee80211_device { /* ask to the driver to retune the radio . * This function can sleep. the driver should ensure -* the radio has been swithced before return. +* the radio has been switched before return. */ void (*set_chan)(struct net_device *dev,short ch); @@ -1135,7 +1135,7 @@ struct ieee80211_device { * The syncro version is similar to the start_scan but * does not return until all channels has been scanned. * this is called in user context and should sleep, -* it is called in a work_queue when swithcing to ad-hoc mode +* it is called in a work_queue when switching to ad-hoc mode * or in behalf of iwlist scan when the card is associated * and root user ask for a scan. * the function stop_scan should stop both the syncro and @@ -1196,7 +1196,7 @@ struct i
[PATCH]NEXT:drivers:staging:rtl8187se Fix typos in staging:rtl8187se
From: "Justin P. Mattock" The below patch fixes some typos that I found while reading. Signed-off-by: Justin P. Mattock --- drivers/staging/rtl8187se/Makefile |2 +- drivers/staging/rtl8187se/ieee80211/dot11d.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211.h| 14 .../rtl8187se/ieee80211/ieee80211_softmac.c| 24 .../rtl8187se/ieee80211/ieee80211_softmac_wx.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c |2 +- drivers/staging/rtl8187se/ieee80211/ieee80211_wx.c |2 +- drivers/staging/rtl8187se/r8180.h | 10 +++--- drivers/staging/rtl8187se/r8180_core.c | 30 ++-- drivers/staging/rtl8187se/r8180_dm.c | 16 +- drivers/staging/rtl8187se/r8180_rtl8225z2.c|4 +- drivers/staging/rtl8187se/r8180_wx.c |6 ++-- drivers/staging/rtl8187se/r8180_wx.h |2 +- drivers/staging/rtl8187se/r8185b_init.c| 10 +++--- 14 files changed, 63 insertions(+), 63 deletions(-) diff --git a/drivers/staging/rtl8187se/Makefile b/drivers/staging/rtl8187se/Makefile index 72db504..91d1aa2 100644 --- a/drivers/staging/rtl8187se/Makefile +++ b/drivers/staging/rtl8187se/Makefile @@ -10,7 +10,7 @@ ccflags-y += -DHIGH_POWER ccflags-y += -DSW_DIG ccflags-y += -DRATE_ADAPT -#enable it for legacy power save, disable it for leisure power save +#enable it for legacy power save, disable it for leisure power save ccflags-y += -DENABLE_LPS diff --git a/drivers/staging/rtl8187se/ieee80211/dot11d.c b/drivers/staging/rtl8187se/ieee80211/dot11d.c index 309bb8b..0e93eb0 100644 --- a/drivers/staging/rtl8187se/ieee80211/dot11d.c +++ b/drivers/staging/rtl8187se/ieee80211/dot11d.c @@ -55,7 +55,7 @@ Dot11d_Reset(struct ieee80211_device *ieee) // // Description: -// Update country IE from Beacon or Probe Resopnse +// Update country IE from Beacon or Probe Response // and configure PHY for operation in the regulatory domain. // // TODO: diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211.h b/drivers/staging/rtl8187se/ieee80211/ieee80211.h index 40dd715..b94c48b 100644 --- a/drivers/staging/rtl8187se/ieee80211/ieee80211.h +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211.h @@ -834,7 +834,7 @@ enum ieee80211_state { /* the association procedure is sending AUTH request*/ IEEE80211_ASSOCIATING_AUTHENTICATING, - /* the association procedure has successfully authentcated + /* the association procedure has successfully authenticated * and is sending association request */ IEEE80211_ASSOCIATING_AUTHENTICATED, @@ -934,7 +934,7 @@ struct ieee80211_device { * with RX of broad/multicast frames */ /* Fragmentation structures */ - // each streaming contain a entry + /* each stream contains an entry */ struct ieee80211_frag_entry frag_cache[17][IEEE80211_FRAG_CACHE_LEN]; unsigned int frag_next_idx[17]; u16 fts; /* Fragmentation Threshold */ @@ -972,7 +972,7 @@ struct ieee80211_device { int rate; /* current rate */ int basic_rate; - //FIXME: pleace callback, see if redundant with softmac_features + //FIXME: please callback, see if redundant with softmac_features short active_scan; /* this contains flags for selectively enable softmac support */ @@ -1106,7 +1106,7 @@ struct ieee80211_device { /* used instead of hard_start_xmit (not softmac_hard_start_xmit) * if the IEEE_SOFTMAC_TX_QUEUE feature is used to TX data -* frames. I the option IEEE_SOFTMAC_SINGLE_QUEUE is also set +* frames. If the option IEEE_SOFTMAC_SINGLE_QUEUE is also set * then also management frames are sent via this callback. * This function can't sleep. */ @@ -1124,7 +1124,7 @@ struct ieee80211_device { /* ask to the driver to retune the radio . * This function can sleep. the driver should ensure -* the radio has been swithced before return. +* the radio has been switched before return. */ void (*set_chan)(struct net_device *dev,short ch); @@ -1135,7 +1135,7 @@ struct ieee80211_device { * The syncro version is similar to the start_scan but * does not return until all channels has been scanned. * this is called in user context and should sleep, -* it is called in a work_queue when swithcing to ad-hoc mode +* it is called in a work_queue when switching to ad-hoc mode * or in behalf of iwlist scan when the card is associated * and root user ask for a scan. * the function stop_scan should stop both the syncro and @@ -1196,7 +1196,7 @@ struct ieee80211_device { /* Generate probe requests */ #define IEEE_SOFTMAC_PROBERQ (1<
Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*
On 03/16/2012 09:06 AM, Justin P. Mattock wrote: On 03/16/2012 08:58 AM, Greg KH wrote: On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote: On Fri, 16 Mar 2012, Justin P. Mattock wrote: before I forget about this patch, what was the status of this one? As previously announced multiple times, I am ignoring patches that go to drivers/staging and letting Greg pick them up if he wants to. Greg, if you want to have this changed, just let me know. No, no objection from me, but patches to drivers/staging/media/ do not go through me, please see the MAINTAINERS file for the owner of those (hint, it's Mauro...) thanks, greg k-h ahh!! I got it now.. your in charge of the staging tree but for each branch there is an owner(I thought to just send to greg KH and thats it) adding Mauro to the Cc's so he can view the patch, then on any other patch I send to staging I will send it to the maintainer then the rest as follows with a cc's. Thanks for the help on this. Justin P. Mattock and of course pressed send without the Maintainer on it.. duh! Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*
On 03/16/2012 08:58 AM, Greg KH wrote: On Fri, Mar 16, 2012 at 04:45:03PM +0100, Jiri Kosina wrote: On Fri, 16 Mar 2012, Justin P. Mattock wrote: before I forget about this patch, what was the status of this one? As previously announced multiple times, I am ignoring patches that go to drivers/staging and letting Greg pick them up if he wants to. Greg, if you want to have this changed, just let me know. No, no objection from me, but patches to drivers/staging/media/ do not go through me, please see the MAINTAINERS file for the owner of those (hint, it's Mauro...) thanks, greg k-h ahh!! I got it now.. your in charge of the staging tree but for each branch there is an owner(I thought to just send to greg KH and thats it) adding Mauro to the Cc's so he can view the patch, then on any other patch I send to staging I will send it to the maintainer then the rest as follows with a cc's. Thanks for the help on this. Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*
On 03/16/2012 08:45 AM, Jiri Kosina wrote: On Fri, 16 Mar 2012, Justin P. Mattock wrote: before I forget about this patch, what was the status of this one? As previously announced multiple times, I am ignoring patches that go to drivers/staging and letting Greg pick them up if he wants to. Greg, if you want to have this changed, just let me know. so any typos in staging are not sent to trivial. I might have not have received that announcement because of not being on any lists. thanks for letting me know! Justin P. Mattock -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*
before I forget about this patch, what was the status of this one? On 03/06/2012 06:55 AM, Justin P. Mattock wrote: From: "Justin P. Mattock" linux-next: I like to spend some time reading code, in doing so I have found some typos in some of the comments. The patch below fixes what I have found. Signed-off-by: Justin P. Mattock --- drivers/staging/media/Kconfig |2 +- drivers/staging/media/as102/as102_drv.c|2 +- drivers/staging/media/as102/as102_fe.c |4 ++-- drivers/staging/media/go7007/go7007-v4l2.c |8 drivers/staging/media/lirc/lirc_serial.c |2 +- drivers/staging/media/solo6x10/Kconfig |2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig index 7e5caa3..4f4b7d6 100644 --- a/drivers/staging/media/Kconfig +++ b/drivers/staging/media/Kconfig @@ -6,7 +6,7 @@ menuconfig STAGING_MEDIA don't have the "normal" Linux kernel quality level. Most of them don't follow properly the V4L, DVB and/or RC API's, so, they won't likely work fine with the existing applications. - That also means that, one fixed, their API's will change to match + That also means that, once fixed, their API's will change to match the existing ones. If you wish to work on these drivers, to help improve them, or diff --git a/drivers/staging/media/as102/as102_drv.c b/drivers/staging/media/as102/as102_drv.c index aae0505..ea4f992 100644 --- a/drivers/staging/media/as102/as102_drv.c +++ b/drivers/staging/media/as102/as102_drv.c @@ -27,7 +27,7 @@ #include #include -/* header file for Usb device driver*/ +/* header file for usb device driver*/ #include "as102_drv.h" #include "as102_fw.h" #include "dvbdev.h" diff --git a/drivers/staging/media/as102/as102_fe.c b/drivers/staging/media/as102/as102_fe.c index bdc5a38..57daa8c 100644 --- a/drivers/staging/media/as102/as102_fe.c +++ b/drivers/staging/media/as102/as102_fe.c @@ -337,7 +337,7 @@ int as102_dvb_register_fe(struct as102_dev_t *as102_dev, strncpy(dvb_fe->ops.info.name, as102_dev->name, sizeof(dvb_fe->ops.info.name)); - /* register dbvb frontend */ + /* register dvb frontend */ errno = dvb_register_frontend(dvb_adap, dvb_fe); if (errno == 0) dvb_fe->tuner_priv = as102_dev; @@ -349,7 +349,7 @@ static void as10x_fe_copy_tps_parameters(struct dtv_frontend_properties *fe_tps, struct as10x_tps *as10x_tps) { - /* extract consteallation */ + /* extract constellation */ switch (as10x_tps->modulation) { case CONST_QPSK: fe_tps->modulation = QPSK; diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c index 2b27d8d..f916586 100644 --- a/drivers/staging/media/go7007/go7007-v4l2.c +++ b/drivers/staging/media/go7007/go7007-v4l2.c @@ -1050,15 +1050,15 @@ static int vidioc_s_parm(struct file *filp, void *priv, return 0; } -/* VIDIOC_ENUMSTD on go7007 were used for enumberating the supported fps and +/* VIDIOC_ENUMSTD on go7007 were used for enumerating the supported fps and its resolution, when the device is not connected to TV. - This were an API abuse, probably used by the lack of specific IOCTL's to - enumberate it, by the time the driver were written. + This is were an API abuse, probably used by the lack of specific IOCTL's to + enumerate it, by the time the driver was written. However, since kernel 2.6.19, two new ioctls (VIDIOC_ENUM_FRAMEINTERVALS and VIDIOC_ENUM_FRAMESIZES) were added for this purpose. - The two functions bellow implements the newer ioctls + The two functions below implement the newer ioctls */ static int vidioc_enum_framesizes(struct file *filp, void *priv, struct v4l2_frmsizeenum *fsize) diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c index 8dd8897..97352cf 100644 --- a/drivers/staging/media/lirc/lirc_serial.c +++ b/drivers/staging/media/lirc/lirc_serial.c @@ -1282,7 +1282,7 @@ MODULE_PARM_DESC(iommap, "physical base for memory mapped I/O" /* * some architectures (e.g. intel xscale) align the 8bit serial registers * on 32bit word boundaries. - * See linux-kernel/serial/8250.c serial_in()/out() + * See linux-kernel/drivers/tty/serial/8250/8250.c serial_in()/out() */ module_param(ioshift, int, S_IRUGO); MODULE_PARM_DESC(ioshift, "shift I/O register offset (0 = no shift)"); diff --git a/drivers/staging/media/solo6x10/Kconfig b/drivers/staging/media/solo6x10/Kconfig index 03dcac4..63352de 100644 --- a/drivers/staging/media/solo6x10/Kconfig +++ b/drivers/staging/media/solo6x10/Kconfig @
[PATCH V2]NEXT:drivers:staging:media Fix comments and some typos in staging/media/*
From: "Justin P. Mattock" linux-next: I like to spend some time reading code, in doing so I have found some typos in some of the comments. The patch below fixes what I have found. Signed-off-by: Justin P. Mattock --- drivers/staging/media/Kconfig |2 +- drivers/staging/media/as102/as102_drv.c|2 +- drivers/staging/media/as102/as102_fe.c |4 ++-- drivers/staging/media/go7007/go7007-v4l2.c |8 drivers/staging/media/lirc/lirc_serial.c |2 +- drivers/staging/media/solo6x10/Kconfig |2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/Kconfig b/drivers/staging/media/Kconfig index 7e5caa3..4f4b7d6 100644 --- a/drivers/staging/media/Kconfig +++ b/drivers/staging/media/Kconfig @@ -6,7 +6,7 @@ menuconfig STAGING_MEDIA don't have the "normal" Linux kernel quality level. Most of them don't follow properly the V4L, DVB and/or RC API's, so, they won't likely work fine with the existing applications. - That also means that, one fixed, their API's will change to match + That also means that, once fixed, their API's will change to match the existing ones. If you wish to work on these drivers, to help improve them, or diff --git a/drivers/staging/media/as102/as102_drv.c b/drivers/staging/media/as102/as102_drv.c index aae0505..ea4f992 100644 --- a/drivers/staging/media/as102/as102_drv.c +++ b/drivers/staging/media/as102/as102_drv.c @@ -27,7 +27,7 @@ #include #include -/* header file for Usb device driver*/ +/* header file for usb device driver*/ #include "as102_drv.h" #include "as102_fw.h" #include "dvbdev.h" diff --git a/drivers/staging/media/as102/as102_fe.c b/drivers/staging/media/as102/as102_fe.c index bdc5a38..57daa8c 100644 --- a/drivers/staging/media/as102/as102_fe.c +++ b/drivers/staging/media/as102/as102_fe.c @@ -337,7 +337,7 @@ int as102_dvb_register_fe(struct as102_dev_t *as102_dev, strncpy(dvb_fe->ops.info.name, as102_dev->name, sizeof(dvb_fe->ops.info.name)); - /* register dbvb frontend */ + /* register dvb frontend */ errno = dvb_register_frontend(dvb_adap, dvb_fe); if (errno == 0) dvb_fe->tuner_priv = as102_dev; @@ -349,7 +349,7 @@ static void as10x_fe_copy_tps_parameters(struct dtv_frontend_properties *fe_tps, struct as10x_tps *as10x_tps) { - /* extract consteallation */ + /* extract constellation */ switch (as10x_tps->modulation) { case CONST_QPSK: fe_tps->modulation = QPSK; diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c index 2b27d8d..f916586 100644 --- a/drivers/staging/media/go7007/go7007-v4l2.c +++ b/drivers/staging/media/go7007/go7007-v4l2.c @@ -1050,15 +1050,15 @@ static int vidioc_s_parm(struct file *filp, void *priv, return 0; } -/* VIDIOC_ENUMSTD on go7007 were used for enumberating the supported fps and +/* VIDIOC_ENUMSTD on go7007 were used for enumerating the supported fps and its resolution, when the device is not connected to TV. - This were an API abuse, probably used by the lack of specific IOCTL's to - enumberate it, by the time the driver were written. + This is were an API abuse, probably used by the lack of specific IOCTL's to + enumerate it, by the time the driver was written. However, since kernel 2.6.19, two new ioctls (VIDIOC_ENUM_FRAMEINTERVALS and VIDIOC_ENUM_FRAMESIZES) were added for this purpose. - The two functions bellow implements the newer ioctls + The two functions below implement the newer ioctls */ static int vidioc_enum_framesizes(struct file *filp, void *priv, struct v4l2_frmsizeenum *fsize) diff --git a/drivers/staging/media/lirc/lirc_serial.c b/drivers/staging/media/lirc/lirc_serial.c index 8dd8897..97352cf 100644 --- a/drivers/staging/media/lirc/lirc_serial.c +++ b/drivers/staging/media/lirc/lirc_serial.c @@ -1282,7 +1282,7 @@ MODULE_PARM_DESC(iommap, "physical base for memory mapped I/O" /* * some architectures (e.g. intel xscale) align the 8bit serial registers * on 32bit word boundaries. - * See linux-kernel/serial/8250.c serial_in()/out() + * See linux-kernel/drivers/tty/serial/8250/8250.c serial_in()/out() */ module_param(ioshift, int, S_IRUGO); MODULE_PARM_DESC(ioshift, "shift I/O register offset (0 = no shift)"); diff --git a/drivers/staging/media/solo6x10/Kconfig b/drivers/staging/media/solo6x10/Kconfig index 03dcac4..63352de 100644 --- a/drivers/staging/media/solo6x10/Kconfig +++ b/drivers/staging/media/solo6x10/Kconfig @@ -5,4 +5,4 @@ config SOLO6X10 select SND_PCM ---help--- This driver supports the Softlogic based MPEG-4 a