[jira] [Commented] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087671#comment-17087671
]
Kazuaki Ishizaki commented on ARROW-8486:
-
I confirmed that this change works well. Thanks again. I struggled with this
for many weeks.
I would appreciate it if you could create a PR for this patch.
> [C++] arrow-utility-test causes failures on a big-endian platform
> -
>
> Key: ARROW-8486
> URL: https://issues.apache.org/jira/browse/ARROW-8486
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> The current master causes the following failures in arrow-util-test.
> {code}
> Start 17: arrow-utility-test
> ...
> 17: [ PASSED ] 253 tests.
> 17: [ FAILED ] 11 tests, listed below:
> 17: [ FAILED ] Bitmap.ShiftingWordsOptimization
> 17: [ FAILED ] Bitmap.VisitWordsAnd
> 17: [ FAILED ] BitArray.TestBool
> 17: [ FAILED ] BitArray.TestValues
> 17: [ FAILED ] Rle.SpecificSequences
> 17: [ FAILED ] Rle.TestValues
> 17: [ FAILED ] BitRle.Flush
> 17: [ FAILED ] BitRle.Random
> 17: [ FAILED ] BitRle.RepeatedPattern
> 17: [ FAILED ] BitRle.Overflow
> 17: [ FAILED ] RleDecoder.GetBatchSpaced
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087638#comment-17087638
]
Kazuaki Ishizaki commented on ARROW-8486:
-
Great, thank you very much. I will apply it.
> [C++] arrow-utility-test causes failures on a big-endian platform
> -
>
> Key: ARROW-8486
> URL: https://issues.apache.org/jira/browse/ARROW-8486
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> The current master causes the following failures in arrow-util-test.
> {code}
> Start 17: arrow-utility-test
> ...
> 17: [ PASSED ] 253 tests.
> 17: [ FAILED ] 11 tests, listed below:
> 17: [ FAILED ] Bitmap.ShiftingWordsOptimization
> 17: [ FAILED ] Bitmap.VisitWordsAnd
> 17: [ FAILED ] BitArray.TestBool
> 17: [ FAILED ] BitArray.TestValues
> 17: [ FAILED ] Rle.SpecificSequences
> 17: [ FAILED ] Rle.TestValues
> 17: [ FAILED ] BitRle.Flush
> 17: [ FAILED ] BitRle.Random
> 17: [ FAILED ] BitRle.RepeatedPattern
> 17: [ FAILED ] BitRle.Overflow
> 17: [ FAILED ] RleDecoder.GetBatchSpaced
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087587#comment-17087587
]
Kazuaki Ishizaki commented on ARROW-8486:
-
> I don't think parquet::FixedLenByteArray and parquet::ByteArray ever get
> passed to RleDecoder. I'm not sure about Int96.
In my understanding, unfortunately, it occurs at
https://github.com/apache/arrow/blob/master/cpp/src/parquet/encoding.cc#L2530-L2559.
They read to call the constructor of `RleDecoder` at
https://github.com/apache/arrow/blob/master/cpp/src/parquet/encoding.cc#L1484.
Then, `T` is passed to `NextCounts()` thru `GetBatchWithDictSpaced()` at
https://github.com/apache/arrow/blob/master/cpp/src/parquet/encoding.cc#L1502
While Int96 is depreciated, test cases are there. Of course, I can make it
low-priority.
> [C++] arrow-utility-test causes failures on a big-endian platform
> -
>
> Key: ARROW-8486
> URL: https://issues.apache.org/jira/browse/ARROW-8486
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> The current master causes the following failures in arrow-util-test.
> {code}
> Start 17: arrow-utility-test
> ...
> 17: [ PASSED ] 253 tests.
> 17: [ FAILED ] 11 tests, listed below:
> 17: [ FAILED ] Bitmap.ShiftingWordsOptimization
> 17: [ FAILED ] Bitmap.VisitWordsAnd
> 17: [ FAILED ] BitArray.TestBool
> 17: [ FAILED ] BitArray.TestValues
> 17: [ FAILED ] Rle.SpecificSequences
> 17: [ FAILED ] Rle.TestValues
> 17: [ FAILED ] BitRle.Flush
> 17: [ FAILED ] BitRle.Random
> 17: [ FAILED ] BitRle.RepeatedPattern
> 17: [ FAILED ] BitRle.Overflow
> 17: [ FAILED ] RleDecoder.GetBatchSpaced
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (PARQUET-1845) [C++] Int96 memory images in test cases assume only little-endian
Kazuaki Ishizaki created PARQUET-1845: - Summary: [C++] Int96 memory images in test cases assume only little-endian Key: PARQUET-1845 URL: https://issues.apache.org/jira/browse/PARQUET-1845 Project: Parquet Issue Type: Improvement Components: parquet-cpp Reporter: Kazuaki Ishizaki Int96 is used as a pair of uint_64 and uint_32. Both elements can be handled using a native endian for effectiveness. Int96 memory images in parquet-internal-tests assume only little-endian. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17086720#comment-17086720
]
Kazuaki Ishizaki commented on ARROW-8486:
-
[~apitrou] Could you give me your advice?
I am working for addressing an issue described in ARROW-4018. The below your
suggested code works well for primitive types.
On the other hand, I enable `-DARROW_PARQUET=ON` in cmake, non-primitive types
(parquet::FixedLenByteArray, parquet::ByteArray, and parquet::Int96) are passed
as T. In this case, this line `current_value_ = static_cast(value)`
causes the cast error.
IMHO, these cases use 32 as bit_width_ (just my guess, I did not confirm it).
Am I correct?
While I tried to create a patch by using std::enable_if or constexpr, I was not
successful to create it. Are there any advices to handle these three cases?
{code}
T value = T();
bool result =
bit_reader_.GetAligned(static_cast(BitUtil::CeilDiv(bit_width_,
8)), &value);
current_value_ = static_cast(value);
{code}
> [C++] arrow-utility-test causes failures on a big-endian platform
> -
>
> Key: ARROW-8486
> URL: https://issues.apache.org/jira/browse/ARROW-8486
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> The current master causes the following failures in arrow-util-test.
> {code}
> Start 17: arrow-utility-test
> ...
> 17: [ PASSED ] 253 tests.
> 17: [ FAILED ] 11 tests, listed below:
> 17: [ FAILED ] Bitmap.ShiftingWordsOptimization
> 17: [ FAILED ] Bitmap.VisitWordsAnd
> 17: [ FAILED ] BitArray.TestBool
> 17: [ FAILED ] BitArray.TestValues
> 17: [ FAILED ] Rle.SpecificSequences
> 17: [ FAILED ] Rle.TestValues
> 17: [ FAILED ] BitRle.Flush
> 17: [ FAILED ] BitRle.Random
> 17: [ FAILED ] BitRle.RepeatedPattern
> 17: [ FAILED ] BitRle.Overflow
> 17: [ FAILED ] RleDecoder.GetBatchSpaced
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-8506) [c++] Miss tests to verify expected_buffer with bit_width > 8 in RLE
Kazuaki Ishizaki created ARROW-8506: --- Summary: [c++] Miss tests to verify expected_buffer with bit_width > 8 in RLE Key: ARROW-8506 URL: https://issues.apache.org/jira/browse/ARROW-8506 Project: Apache Arrow Issue Type: Improvement Components: C++ Reporter: Kazuaki Ishizaki The current test cases only verify the encoded stream by RLE when bit_width <= 8. It is hard to verify whether the encoded stream by RLE keeps the data in a little-endian format -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-8506) [c++] Miss tests to verify expected_buffer with bit_width > 8 in RLE
Kazuaki Ishizaki created ARROW-8506: --- Summary: [c++] Miss tests to verify expected_buffer with bit_width > 8 in RLE Key: ARROW-8506 URL: https://issues.apache.org/jira/browse/ARROW-8506 Project: Apache Arrow Issue Type: Improvement Components: C++ Reporter: Kazuaki Ishizaki The current test cases only verify the encoded stream by RLE when bit_width <= 8. It is hard to verify whether the encoded stream by RLE keeps the data in a little-endian format -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (PARQUET-1843) [C++] Unnecessary assignment in DictDecoderImpl::Decode
Kazuaki Ishizaki created PARQUET-1843:
-
Summary: [C++] Unnecessary assignment in DictDecoderImpl::Decode
Key: PARQUET-1843
URL: https://issues.apache.org/jira/browse/PARQUET-1843
Project: Parquet
Issue Type: Improvement
Components: parquet-cpp
Reporter: Kazuaki Ishizaki
The following duplicated assignments are unnecessary.
{code}
int DecodeIndices(int num_values, arrow::ArrayBuilder* builder) override {
num_values = std::min(num_values, num_values_);
num_values = std::min(num_values, num_values_);
if (num_values > 0) {
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8457) [C++] bridge test does not take care of endianness
[ https://issues.apache.org/jira/browse/ARROW-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085189#comment-17085189 ] Kazuaki Ishizaki commented on ARROW-8457: - Thank you very much. When I run `cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_TESTS=ON . && make test`, ARROW-8486 is the last issue. Although I have a patch, it cannot be compiled with -DARROW_PARQUET=ON. It is related to ARROW-4018. I may ask your guidance at ARROW-8486 in the future. > [C++] bridge test does not take care of endianness > -- > > Key: ARROW-8457 > URL: https://issues.apache.org/jira/browse/ARROW-8457 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ >Reporter: Kazuaki Ishizaki >Assignee: Kazuaki Ishizaki >Priority: Minor > Labels: pull-request-available > Fix For: 0.17.0 > > Time Spent: 40m > Remaining Estimate: 0h > > According to the > [specification|https://github.com/apache/arrow/blob/master/docs/source/format/CDataInterface.rst] > of ArrowSchema, memory format uses the native endian of the CPU. However, > the test cases assume only little endian. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki updated ARROW-8486:
Description:
The current master causes the following failures in arrow-util-test.
{code}
Start 17: arrow-utility-test
...
17: [ PASSED ] 253 tests.
17: [ FAILED ] 11 tests, listed below:
17: [ FAILED ] Bitmap.ShiftingWordsOptimization
17: [ FAILED ] Bitmap.VisitWordsAnd
17: [ FAILED ] BitArray.TestBool
17: [ FAILED ] BitArray.TestValues
17: [ FAILED ] Rle.SpecificSequences
17: [ FAILED ] Rle.TestValues
17: [ FAILED ] BitRle.Flush
17: [ FAILED ] BitRle.Random
17: [ FAILED ] BitRle.RepeatedPattern
17: [ FAILED ] BitRle.Overflow
17: [ FAILED ] RleDecoder.GetBatchSpaced
{code}
was:
The current master causes the following failures in arrow-util-test.
{{code}}
Start 17: arrow-utility-test
...
17: [ PASSED ] 253 tests.
17: [ FAILED ] 11 tests, listed below:
17: [ FAILED ] Bitmap.ShiftingWordsOptimization
17: [ FAILED ] Bitmap.VisitWordsAnd
17: [ FAILED ] BitArray.TestBool
17: [ FAILED ] BitArray.TestValues
17: [ FAILED ] Rle.SpecificSequences
17: [ FAILED ] Rle.TestValues
17: [ FAILED ] BitRle.Flush
17: [ FAILED ] BitRle.Random
17: [ FAILED ] BitRle.RepeatedPattern
17: [ FAILED ] BitRle.Overflow
17: [ FAILED ] RleDecoder.GetBatchSpaced
{{code}}
> [C++] arrow-utility-test causes failures on a big-endian platform
> -
>
> Key: ARROW-8486
> URL: https://issues.apache.org/jira/browse/ARROW-8486
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> The current master causes the following failures in arrow-util-test.
> {code}
> Start 17: arrow-utility-test
> ...
> 17: [ PASSED ] 253 tests.
> 17: [ FAILED ] 11 tests, listed below:
> 17: [ FAILED ] Bitmap.ShiftingWordsOptimization
> 17: [ FAILED ] Bitmap.VisitWordsAnd
> 17: [ FAILED ] BitArray.TestBool
> 17: [ FAILED ] BitArray.TestValues
> 17: [ FAILED ] Rle.SpecificSequences
> 17: [ FAILED ] Rle.TestValues
> 17: [ FAILED ] BitRle.Flush
> 17: [ FAILED ] BitRle.Random
> 17: [ FAILED ] BitRle.RepeatedPattern
> 17: [ FAILED ] BitRle.Overflow
> 17: [ FAILED ] RleDecoder.GetBatchSpaced
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki updated ARROW-8486:
Description:
The current master causes the following failures in arrow-util-test.
{{code}}
Start 17: arrow-utility-test
...
17: [ PASSED ] 253 tests.
17: [ FAILED ] 11 tests, listed below:
17: [ FAILED ] Bitmap.ShiftingWordsOptimization
17: [ FAILED ] Bitmap.VisitWordsAnd
17: [ FAILED ] BitArray.TestBool
17: [ FAILED ] BitArray.TestValues
17: [ FAILED ] Rle.SpecificSequences
17: [ FAILED ] Rle.TestValues
17: [ FAILED ] BitRle.Flush
17: [ FAILED ] BitRle.Random
17: [ FAILED ] BitRle.RepeatedPattern
17: [ FAILED ] BitRle.Overflow
17: [ FAILED ] RleDecoder.GetBatchSpaced
{{code}}
was:
The current master causes the following failures in arrow-util-test.
```
Start 17: arrow-utility-test
...
17: [ PASSED ] 253 tests.
17: [ FAILED ] 11 tests, listed below:
17: [ FAILED ] Bitmap.ShiftingWordsOptimization
17: [ FAILED ] Bitmap.VisitWordsAnd
17: [ FAILED ] BitArray.TestBool
17: [ FAILED ] BitArray.TestValues
17: [ FAILED ] Rle.SpecificSequences
17: [ FAILED ] Rle.TestValues
17: [ FAILED ] BitRle.Flush
17: [ FAILED ] BitRle.Random
17: [ FAILED ] BitRle.RepeatedPattern
17: [ FAILED ] BitRle.Overflow
17: [ FAILED ] RleDecoder.GetBatchSpaced
```
> [C++] arrow-utility-test causes failures on a big-endian platform
> -
>
> Key: ARROW-8486
> URL: https://issues.apache.org/jira/browse/ARROW-8486
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> The current master causes the following failures in arrow-util-test.
> {{code}}
> Start 17: arrow-utility-test
> ...
> 17: [ PASSED ] 253 tests.
> 17: [ FAILED ] 11 tests, listed below:
> 17: [ FAILED ] Bitmap.ShiftingWordsOptimization
> 17: [ FAILED ] Bitmap.VisitWordsAnd
> 17: [ FAILED ] BitArray.TestBool
> 17: [ FAILED ] BitArray.TestValues
> 17: [ FAILED ] Rle.SpecificSequences
> 17: [ FAILED ] Rle.TestValues
> 17: [ FAILED ] BitRle.Flush
> 17: [ FAILED ] BitRle.Random
> 17: [ FAILED ] BitRle.RepeatedPattern
> 17: [ FAILED ] BitRle.Overflow
> 17: [ FAILED ] RleDecoder.GetBatchSpaced
> {{code}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
Kazuaki Ishizaki created ARROW-8486: --- Summary: [C++] arrow-utility-test causes failures on a big-endian platform Key: ARROW-8486 URL: https://issues.apache.org/jira/browse/ARROW-8486 Project: Apache Arrow Issue Type: Improvement Reporter: Kazuaki Ishizaki The current master causes the following failures in arrow-util-test. ``` Start 17: arrow-utility-test ... 17: [ PASSED ] 253 tests. 17: [ FAILED ] 11 tests, listed below: 17: [ FAILED ] Bitmap.ShiftingWordsOptimization 17: [ FAILED ] Bitmap.VisitWordsAnd 17: [ FAILED ] BitArray.TestBool 17: [ FAILED ] BitArray.TestValues 17: [ FAILED ] Rle.SpecificSequences 17: [ FAILED ] Rle.TestValues 17: [ FAILED ] BitRle.Flush 17: [ FAILED ] BitRle.Random 17: [ FAILED ] BitRle.RepeatedPattern 17: [ FAILED ] BitRle.Overflow 17: [ FAILED ] RleDecoder.GetBatchSpaced ``` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-8486) [C++] arrow-utility-test causes failures on a big-endian platform
Kazuaki Ishizaki created ARROW-8486: --- Summary: [C++] arrow-utility-test causes failures on a big-endian platform Key: ARROW-8486 URL: https://issues.apache.org/jira/browse/ARROW-8486 Project: Apache Arrow Issue Type: Improvement Reporter: Kazuaki Ishizaki The current master causes the following failures in arrow-util-test. ``` Start 17: arrow-utility-test ... 17: [ PASSED ] 253 tests. 17: [ FAILED ] 11 tests, listed below: 17: [ FAILED ] Bitmap.ShiftingWordsOptimization 17: [ FAILED ] Bitmap.VisitWordsAnd 17: [ FAILED ] BitArray.TestBool 17: [ FAILED ] BitArray.TestValues 17: [ FAILED ] Rle.SpecificSequences 17: [ FAILED ] Rle.TestValues 17: [ FAILED ] BitRle.Flush 17: [ FAILED ] BitRle.Random 17: [ FAILED ] BitRle.RepeatedPattern 17: [ FAILED ] BitRle.Overflow 17: [ FAILED ] RleDecoder.GetBatchSpaced ``` -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ARROW-8484) [C++] TestArrayImport tests cause failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki reassigned ARROW-8484:
---
Assignee: Kazuaki Ishizaki
> [C++] TestArrayImport tests cause failures on a big-endian platform
> ---
>
> Key: ARROW-8484
> URL: https://issues.apache.org/jira/browse/ARROW-8484
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
> Assignee: Kazuaki Ishizaki
>Priority: Minor
>
> The current code causes two types of failures of TestArrayImport on a a
> big-endian platform as follows:
> {code}
> 12: [ RUN ] TestSchemaImport.Struct
> 12: /home/ishizaki/Arrow/arrow/cpp/build-support/run-test.sh: line 92: 19528
> Segmentation fault (core dumped) $TEST_EXECUTABLE "$@" 2>&1
> 12: 19529 Done| $ROOT/build-support/asan_symbolize.py
> 12: 19530 Done| ${CXXFILT:-c++filt}
> 12: 19531 Done|
> $ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
> 12: 19532 Done| $pipe_cmd 2>&1
> 12: 19533 Done| tee $LOGFILE
> {code}
> {code}
> 12: [ RUN ] TestArrayImport.PrimitiveWithOffset
> 12: /home/ishizaki/Arrow/arrow/cpp/src/arrow/testing/gtest_util.cc:77: Failure
> 12: Failed
> 12:
> 12: @@ -0, +0 @@
> 12: -1027
> 12: -1541
> 12: -2055
> 12: +772
> 12: +1286
> 12: +1800
> 12: Expected:
> 12: [
> 12: 1027,
> 12: 1541,
> 12: 2055
> 12: ]
> 12: Actual:
> 12: [
> 12: 772,
> 12: 1286,
> 12: 1800
> 12: ]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8457) [C++] bridge test does not take care of endianness
[ https://issues.apache.org/jira/browse/ARROW-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085114#comment-17085114 ] Kazuaki Ishizaki commented on ARROW-8457: - Oh, I forgot mentioning the architecture. Yes, you are right. > [C++] bridge test does not take care of endianness > -- > > Key: ARROW-8457 > URL: https://issues.apache.org/jira/browse/ARROW-8457 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ > Reporter: Kazuaki Ishizaki >Assignee: Kazuaki Ishizaki >Priority: Minor > Labels: pull-request-available > Fix For: 0.17.0 > > Time Spent: 40m > Remaining Estimate: 0h > > According to the > [specification|https://github.com/apache/arrow/blob/master/docs/source/format/CDataInterface.rst] > of ArrowSchema, memory format uses the native endian of the CPU. However, > the test cases assume only little endian. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ARROW-8484) [C++] TestArrayImport tests cause failures on a big-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki updated ARROW-8484:
Description:
The current code causes two types of failures of TestArrayImport on a a
big-endian platform as follows:
{code}
12: [ RUN ] TestSchemaImport.Struct
12: /home/ishizaki/Arrow/arrow/cpp/build-support/run-test.sh: line 92: 19528
Segmentation fault (core dumped) $TEST_EXECUTABLE "$@" 2>&1
12: 19529 Done| $ROOT/build-support/asan_symbolize.py
12: 19530 Done| ${CXXFILT:-c++filt}
12: 19531 Done|
$ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
12: 19532 Done| $pipe_cmd 2>&1
12: 19533 Done| tee $LOGFILE
{code}
{code}
12: [ RUN ] TestArrayImport.PrimitiveWithOffset
12: /home/ishizaki/Arrow/arrow/cpp/src/arrow/testing/gtest_util.cc:77: Failure
12: Failed
12:
12: @@ -0, +0 @@
12: -1027
12: -1541
12: -2055
12: +772
12: +1286
12: +1800
12: Expected:
12: [
12: 1027,
12: 1541,
12: 2055
12: ]
12: Actual:
12: [
12: 772,
12: 1286,
12: 1800
12: ]
{code}
was:
The current code causes two types of failures of TestArrayImport on a a
big-endian platform as follows:
```
12: [ RUN ] TestSchemaImport.Struct
12: /home/ishizaki/Arrow/arrow/cpp/build-support/run-test.sh: line 92: 19528
Segmentation fault (core dumped) $TEST_EXECUTABLE "$@" 2>&1
12: 19529 Done| $ROOT/build-support/asan_symbolize.py
12: 19530 Done| ${CXXFILT:-c++filt}
12: 19531 Done|
$ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
12: 19532 Done| $pipe_cmd 2>&1
12: 19533 Done| tee $LOGFILE
```
```
12: [ RUN ] TestArrayImport.PrimitiveWithOffset
12: /home/ishizaki/Arrow/arrow/cpp/src/arrow/testing/gtest_util.cc:77: Failure
12: Failed
12:
12: @@ -0, +0 @@
12: -1027
12: -1541
12: -2055
12: +772
12: +1286
12: +1800
12: Expected:
12: [
12: 1027,
12: 1541,
12: 2055
12: ]
12: Actual:
12: [
12: 772,
12: 1286,
12: 1800
12: ]
```
> [C++] TestArrayImport tests cause failures on a big-endian platform
> ---
>
> Key: ARROW-8484
> URL: https://issues.apache.org/jira/browse/ARROW-8484
> Project: Apache Arrow
> Issue Type: Improvement
>Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> The current code causes two types of failures of TestArrayImport on a a
> big-endian platform as follows:
> {code}
> 12: [ RUN ] TestSchemaImport.Struct
> 12: /home/ishizaki/Arrow/arrow/cpp/build-support/run-test.sh: line 92: 19528
> Segmentation fault (core dumped) $TEST_EXECUTABLE "$@" 2>&1
> 12: 19529 Done| $ROOT/build-support/asan_symbolize.py
> 12: 19530 Done| ${CXXFILT:-c++filt}
> 12: 19531 Done|
> $ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
> 12: 19532 Done| $pipe_cmd 2>&1
> 12: 19533 Done| tee $LOGFILE
> {code}
> {code}
> 12: [ RUN ] TestArrayImport.PrimitiveWithOffset
> 12: /home/ishizaki/Arrow/arrow/cpp/src/arrow/testing/gtest_util.cc:77: Failure
> 12: Failed
> 12:
> 12: @@ -0, +0 @@
> 12: -1027
> 12: -1541
> 12: -2055
> 12: +772
> 12: +1286
> 12: +1800
> 12: Expected:
> 12: [
> 12: 1027,
> 12: 1541,
> 12: 2055
> 12: ]
> 12: Actual:
> 12: [
> 12: 772,
> 12: 1286,
> 12: 1800
> 12: ]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-8484) [C++] TestArrayImport tests cause failures on a big-endian platform
Kazuaki Ishizaki created ARROW-8484:
---
Summary: [C++] TestArrayImport tests cause failures on a
big-endian platform
Key: ARROW-8484
URL: https://issues.apache.org/jira/browse/ARROW-8484
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
The current code causes two types of failures of TestArrayImport on a a
big-endian platform as follows:
```
12: [ RUN ] TestSchemaImport.Struct
12: /home/ishizaki/Arrow/arrow/cpp/build-support/run-test.sh: line 92: 19528
Segmentation fault (core dumped) $TEST_EXECUTABLE "$@" 2>&1
12: 19529 Done| $ROOT/build-support/asan_symbolize.py
12: 19530 Done| ${CXXFILT:-c++filt}
12: 19531 Done|
$ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
12: 19532 Done| $pipe_cmd 2>&1
12: 19533 Done| tee $LOGFILE
```
```
12: [ RUN ] TestArrayImport.PrimitiveWithOffset
12: /home/ishizaki/Arrow/arrow/cpp/src/arrow/testing/gtest_util.cc:77: Failure
12: Failed
12:
12: @@ -0, +0 @@
12: -1027
12: -1541
12: -2055
12: +772
12: +1286
12: +1800
12: Expected:
12: [
12: 1027,
12: 1541,
12: 2055
12: ]
12: Actual:
12: [
12: 772,
12: 1286,
12: 1800
12: ]
```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-8484) [C++] TestArrayImport tests cause failures on a big-endian platform
Kazuaki Ishizaki created ARROW-8484:
---
Summary: [C++] TestArrayImport tests cause failures on a
big-endian platform
Key: ARROW-8484
URL: https://issues.apache.org/jira/browse/ARROW-8484
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
The current code causes two types of failures of TestArrayImport on a a
big-endian platform as follows:
```
12: [ RUN ] TestSchemaImport.Struct
12: /home/ishizaki/Arrow/arrow/cpp/build-support/run-test.sh: line 92: 19528
Segmentation fault (core dumped) $TEST_EXECUTABLE "$@" 2>&1
12: 19529 Done| $ROOT/build-support/asan_symbolize.py
12: 19530 Done| ${CXXFILT:-c++filt}
12: 19531 Done|
$ROOT/build-support/stacktrace_addr2line.pl $TEST_EXECUTABLE
12: 19532 Done| $pipe_cmd 2>&1
12: 19533 Done| tee $LOGFILE
```
```
12: [ RUN ] TestArrayImport.PrimitiveWithOffset
12: /home/ishizaki/Arrow/arrow/cpp/src/arrow/testing/gtest_util.cc:77: Failure
12: Failed
12:
12: @@ -0, +0 @@
12: -1027
12: -1541
12: -2055
12: +772
12: +1286
12: +1800
12: Expected:
12: [
12: 1027,
12: 1541,
12: 2055
12: ]
12: Actual:
12: [
12: 772,
12: 1286,
12: 1800
12: ]
```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ARROW-8457) [C++] bridge test does not take care of endianness
[ https://issues.apache.org/jira/browse/ARROW-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085082#comment-17085082 ] Kazuaki Ishizaki commented on ARROW-8457: - [~apitrou] I have a big-endian machine to test Arrow in my local environment. In addition, there are two options to publically test Arrow on a big-endian machine. 1. Use TravisCI at https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z 2. Use Jenkins at https://osuosl.org/services/ibm-z/. I created an account for Arrow one year ago, but have not set up yet. > [C++] bridge test does not take care of endianness > -- > > Key: ARROW-8457 > URL: https://issues.apache.org/jira/browse/ARROW-8457 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ > Reporter: Kazuaki Ishizaki >Assignee: Kazuaki Ishizaki >Priority: Minor > Labels: pull-request-available > Fix For: 0.17.0 > > Time Spent: 40m > Remaining Estimate: 0h > > According to the > [specification|https://github.com/apache/arrow/blob/master/docs/source/format/CDataInterface.rst] > of ArrowSchema, memory format uses the native endian of the CPU. However, > the test cases assume only little endian. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ARROW-8467) [C++] Test cases using ArrayFromJSON assume only a little-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki reassigned ARROW-8467:
---
Assignee: Kazuaki Ishizaki
> [C++] Test cases using ArrayFromJSON assume only a little-endian platform
> -
>
> Key: ARROW-8467
> URL: https://issues.apache.org/jira/browse/ARROW-8467
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Kazuaki Ishizaki
>Assignee: Kazuaki Ishizaki
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Test cases using ArrayFromJSON assumes little endian platform
> The following test cases seem to assume little-endian platform.
> TEST_F(TestChunkedArray, View) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/table_test.cc#L175
> TEST(TestArrayView, PrimitiveAsFixedSizeBinary) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L105
> TEST(TestArrayView, StructAsStructSimple) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L126
> TEST(TestArrayView, ExtensionType) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc
> One of examples is {{PrimitiveAsFixedSizeBinary}}.
> {code}
> TEST(TestArrayView, PrimitiveAsFixedSizeBinary) {
> auto arr = ArrayFromJSON(int32(), "[2020568934, 2054316386, null]");
> auto expected = ArrayFromJSON(fixed_size_binary(4), R"(["foox", "barz",
> null])");
> CheckView(arr, expected);
> CheckView(expected, arr);
> }
> {code}
> The expected strings are represented in binary as follows:
> {code}
> "foox" = [0x66 0x6f 0x6f 0x78]
> "barz" = [0x62 0x61 0x72 0x7a]
> {code}
> This test gives a value as raw int32. The current values assume only a
> little-endian platform as follows to generate the expected binary sequence.
> {code}
> 2020568934 = 0x786f6f66
> 2054316386 = 0x7a726162
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ARROW-8467) [C++] Test cases using ArrayFromJSON assume only a little-endian platform
[
https://issues.apache.org/jira/browse/ARROW-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki updated ARROW-8467:
Description:
Test cases using ArrayFromJSON assumes little endian platform
The following test cases seem to assume little-endian platform.
TEST_F(TestChunkedArray, View) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/table_test.cc#L175
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L105
TEST(TestArrayView, StructAsStructSimple) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L126
TEST(TestArrayView, ExtensionType) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc
One of examples is {{PrimitiveAsFixedSizeBinary}}.
{code}
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) {
auto arr = ArrayFromJSON(int32(), "[2020568934, 2054316386, null]");
auto expected = ArrayFromJSON(fixed_size_binary(4), R"(["foox", "barz",
null])");
CheckView(arr, expected);
CheckView(expected, arr);
}
{code}
The expected strings are represented in binary as follows:
{code}
"foox" = [0x66 0x6f 0x6f 0x78]
"barz" = [0x62 0x61 0x72 0x7a]
{code}
This test gives a value as raw int32. The current values assume only a
little-endian platform as follows to generate the expected binary sequence.
{code}
2020568934 = 0x786f6f66
2054316386 = 0x7a726162
{code}
was:
Test cases using ArrayFromJSON assumes little endian platform
The following test cases seem to assume little-endian platform.
TEST_F(TestChunkedArray, View) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/table_test.cc#L175
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L105
TEST(TestArrayView, StructAsStructSimple) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L126
One of examples is {{PrimitiveAsFixedSizeBinary}}.
{code}
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) {
auto arr = ArrayFromJSON(int32(), "[2020568934, 2054316386, null]");
auto expected = ArrayFromJSON(fixed_size_binary(4), R"(["foox", "barz",
null])");
CheckView(arr, expected);
CheckView(expected, arr);
}
{code}
The expected strings are represented in binary as follows:
{code}
"foox" = [0x66 0x6f 0x6f 0x78]
"barz" = [0x62 0x61 0x72 0x7a]
{code}
This test gives a value as raw int32. The current values assume only a
little-endian platform as follows to generate the expected binary sequence.
{code}
2020568934 = 0x786f6f66
2054316386 = 0x7a726162
{code}
> [C++] Test cases using ArrayFromJSON assume only a little-endian platform
> -
>
> Key: ARROW-8467
> URL: https://issues.apache.org/jira/browse/ARROW-8467
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
>Reporter: Kazuaki Ishizaki
>Priority: Minor
>
> Test cases using ArrayFromJSON assumes little endian platform
> The following test cases seem to assume little-endian platform.
> TEST_F(TestChunkedArray, View) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/table_test.cc#L175
> TEST(TestArrayView, PrimitiveAsFixedSizeBinary) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L105
> TEST(TestArrayView, StructAsStructSimple) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L126
> TEST(TestArrayView, ExtensionType) at
> https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc
> One of examples is {{PrimitiveAsFixedSizeBinary}}.
> {code}
> TEST(TestArrayView, PrimitiveAsFixedSizeBinary) {
> auto arr = ArrayFromJSON(int32(), "[2020568934, 2054316386, null]");
> auto expected = ArrayFromJSON(fixed_size_binary(4), R"(["foox", "barz",
> null])");
> CheckView(arr, expected);
> CheckView(expected, arr);
> }
> {code}
> The expected strings are represented in binary as follows:
> {code}
> "foox" = [0x66 0x6f 0x6f 0x78]
> "barz" = [0x62 0x61 0x72 0x7a]
> {code}
> This test gives a value as raw int32. The current values assume only a
> little-endian platform as follows to generate the expected binary sequence.
> {code}
> 2020568934 = 0x786f6f66
> 2054316386 = 0x7a726162
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-8467) [C++] Test cases using ArrayFromJSON assume only a little-endian platform
Kazuaki Ishizaki created ARROW-8467:
---
Summary: [C++] Test cases using ArrayFromJSON assume only a
little-endian platform
Key: ARROW-8467
URL: https://issues.apache.org/jira/browse/ARROW-8467
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Reporter: Kazuaki Ishizaki
Test cases using ArrayFromJSON assumes little endian platform
The following test cases seem to assume little-endian platform.
TEST_F(TestChunkedArray, View) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/table_test.cc#L175
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L105
TEST(TestArrayView, StructAsStructSimple) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L126
One of examples is {{PrimitiveAsFixedSizeBinary}}.
{code}
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) {
auto arr = ArrayFromJSON(int32(), "[2020568934, 2054316386, null]");
auto expected = ArrayFromJSON(fixed_size_binary(4), R"(["foox", "barz",
null])");
CheckView(arr, expected);
CheckView(expected, arr);
}
{code}
The expected strings are represented in binary as follows:
{code}
"foox" = [0x66 0x6f 0x6f 0x78]
"barz" = [0x62 0x61 0x72 0x7a]
{code}
This test gives a value as raw int32. The current values assume only a
little-endian platform as follows to generate the expected binary sequence.
{code}
2020568934 = 0x786f6f66
2054316386 = 0x7a726162
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-8467) [C++] Test cases using ArrayFromJSON assume only a little-endian platform
Kazuaki Ishizaki created ARROW-8467:
---
Summary: [C++] Test cases using ArrayFromJSON assume only a
little-endian platform
Key: ARROW-8467
URL: https://issues.apache.org/jira/browse/ARROW-8467
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Reporter: Kazuaki Ishizaki
Test cases using ArrayFromJSON assumes little endian platform
The following test cases seem to assume little-endian platform.
TEST_F(TestChunkedArray, View) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/table_test.cc#L175
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L105
TEST(TestArrayView, StructAsStructSimple) at
https://github.com/apache/arrow/blob/master/cpp/src/arrow/array_view_test.cc#L126
One of examples is {{PrimitiveAsFixedSizeBinary}}.
{code}
TEST(TestArrayView, PrimitiveAsFixedSizeBinary) {
auto arr = ArrayFromJSON(int32(), "[2020568934, 2054316386, null]");
auto expected = ArrayFromJSON(fixed_size_binary(4), R"(["foox", "barz",
null])");
CheckView(arr, expected);
CheckView(expected, arr);
}
{code}
The expected strings are represented in binary as follows:
{code}
"foox" = [0x66 0x6f 0x6f 0x78]
"barz" = [0x62 0x61 0x72 0x7a]
{code}
This test gives a value as raw int32. The current values assume only a
little-endian platform as follows to generate the expected binary sequence.
{code}
2020568934 = 0x786f6f66
2054316386 = 0x7a726162
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (ARROW-8457) [C++] bridge test does not take care of endianness
[ https://issues.apache.org/jira/browse/ARROW-8457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kazuaki Ishizaki reassigned ARROW-8457: --- Assignee: Kazuaki Ishizaki > [C++] bridge test does not take care of endianness > -- > > Key: ARROW-8457 > URL: https://issues.apache.org/jira/browse/ARROW-8457 > Project: Apache Arrow > Issue Type: Improvement > Components: C++ > Reporter: Kazuaki Ishizaki >Assignee: Kazuaki Ishizaki >Priority: Minor > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > According to the > [specification|https://github.com/apache/arrow/blob/master/docs/source/format/CDataInterface.rst] > of ArrowSchema, memory format uses the native endian of the CPU. However, > the test cases assume only little endian. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-8457) [C++] bridge test does not take care of endianness
Kazuaki Ishizaki created ARROW-8457: --- Summary: [C++] bridge test does not take care of endianness Key: ARROW-8457 URL: https://issues.apache.org/jira/browse/ARROW-8457 Project: Apache Arrow Issue Type: Improvement Components: C++ Reporter: Kazuaki Ishizaki According to the [specification|https://github.com/apache/arrow/blob/master/docs/source/format/CDataInterface.rst] of ArrowSchema, memory format uses the native endian of the CPU. However, the test cases assume only little endian. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-8457) [C++] bridge test does not take care of endianness
Kazuaki Ishizaki created ARROW-8457: --- Summary: [C++] bridge test does not take care of endianness Key: ARROW-8457 URL: https://issues.apache.org/jira/browse/ARROW-8457 Project: Apache Arrow Issue Type: Improvement Components: C++ Reporter: Kazuaki Ishizaki According to the [specification|https://github.com/apache/arrow/blob/master/docs/source/format/CDataInterface.rst] of ArrowSchema, memory format uses the native endian of the CPU. However, the test cases assume only little endian. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[Lldb-commits] [PATCH] D77460: [lldb] NFC: Fix trivial typo in comments, documents, and messages
This revision was automatically updated to reflect the committed changes. Closed by commit rGe9264b746b81: [lldb] NFC: Fix trivial typo in comments, documents, and messages (authored by kiszk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77460/new/ https://reviews.llvm.org/D77460 Files: lldb/bindings/interface/SBBlock.i lldb/bindings/interface/SBExpressionOptions.i lldb/bindings/interface/SBFile.i lldb/docs/lldb-platform-packets.txt lldb/examples/interposing/darwin/fd_interposing/FDInterposing.cpp lldb/examples/python/mach_o.py lldb/include/lldb/Symbol/LineEntry.h lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/Target/Platform.h lldb/include/lldb/Target/Process.h lldb/include/lldb/Target/Target.h lldb/include/lldb/Target/ThreadPlan.h lldb/include/lldb/Utility/Connection.h lldb/include/lldb/Utility/Reproducer.h lldb/include/lldb/Utility/Status.h lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/packages/Python/lldbsuite/test/test_runner/README.txt lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py lldb/scripts/verify_api.py lldb/source/Commands/CommandObjectWatchpoint.cpp lldb/source/Core/FormatEntity.cpp lldb/source/Host/common/Editline.cpp lldb/source/Host/common/NativeProcessProtocol.cpp lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.h lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h lldb/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h lldb/source/Plugins/Process/Darwin/CFUtils.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lldb/source/Symbol/ArmUnwindInfo.cpp lldb/source/Target/RegisterContextUnwind.cpp lldb/source/Target/StackFrame.cpp lldb/source/Target/StopInfo.cpp lldb/test/API/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py lldb/test/API/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py lldb/test/API/functionalities/load_unload/TestLoadUnload.py lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py lldb/test/API/lang/cpp/namespace/ns3.cpp lldb/test/API/macosx/lc-note/kern-ver-str/TestKernVerStrLCNOTE.py lldb/test/API/macosx/lc-note/kern-ver-str/create-empty-corefile.cpp lldb/test/API/python_api/default-constructor/TestDefaultConstructorForAPIObjects.py lldb/test/API/python_api/frame/TestFrames.py lldb/test/API/python_api/function_symbol/main.c lldb/test/API/python_api/target/main.c lldb/test/API/python_api/thread/TestThreadAPI.py lldb/test/API/tools/lldb-server/main.cpp lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py lldb/test/API/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py lldb/test/API/tools/lldb-vscode/step/TestVSC
[Lldb-commits] [lldb] e9264b7 - [lldb] NFC: Fix trivial typo in comments, documents, and messages
Author: Kazuaki Ishizaki Date: 2020-04-07T01:06:16+09:00 New Revision: e9264b746b81a63323d884ea07b2ebfbb660d004 URL: https://github.com/llvm/llvm-project/commit/e9264b746b81a63323d884ea07b2ebfbb660d004 DIFF: https://github.com/llvm/llvm-project/commit/e9264b746b81a63323d884ea07b2ebfbb660d004.diff LOG: [lldb] NFC: Fix trivial typo in comments, documents, and messages Differential Revision: https://reviews.llvm.org/D77460 Added: Modified: lldb/bindings/interface/SBBlock.i lldb/bindings/interface/SBExpressionOptions.i lldb/bindings/interface/SBFile.i lldb/docs/lldb-platform-packets.txt lldb/examples/interposing/darwin/fd_interposing/FDInterposing.cpp lldb/examples/python/mach_o.py lldb/include/lldb/Symbol/LineEntry.h lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/Target/Platform.h lldb/include/lldb/Target/Process.h lldb/include/lldb/Target/Target.h lldb/include/lldb/Target/ThreadPlan.h lldb/include/lldb/Utility/Connection.h lldb/include/lldb/Utility/Reproducer.h lldb/include/lldb/Utility/Status.h lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/packages/Python/lldbsuite/test/test_runner/README.txt lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py lldb/scripts/verify_api.py lldb/source/Commands/CommandObjectWatchpoint.cpp lldb/source/Core/FormatEntity.cpp lldb/source/Host/common/Editline.cpp lldb/source/Host/common/NativeProcessProtocol.cpp lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.h lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h lldb/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h lldb/source/Plugins/Process/Darwin/CFUtils.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lldb/source/Symbol/ArmUnwindInfo.cpp lldb/source/Target/RegisterContextUnwind.cpp lldb/source/Target/StackFrame.cpp lldb/source/Target/StopInfo.cpp lldb/test/API/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py lldb/test/API/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py lldb/test/API/functionalities/load_unload/TestLoadUnload.py lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py lldb/test/API/lang/cpp/namespace/ns3.cpp lldb/test/API/macosx/lc-note/kern-ver-str/TestKernVerStrLCNOTE.py lldb/test/API/macosx/lc-note/kern-ver-str/create-empty-corefile.cpp lldb/test/API/python_api/default-constructor/TestDefaultConstructorForAPIObjects.py lldb/test/API/python_api/frame/TestFrames.py lldb/test/API/python_api/function_symbol/main.c lldb/test/API/python_api/target/main.c lldb/test/API/python_api/thread/TestThreadAPI.py lldb/test/API/tools/lldb-server/main.cpp lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py lldb/test/API/tools/lldb-vscode/breakpoint
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a comment. I have done in https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk updated this revision to Diff 255120. kiszk added a comment. This include the fix of the build failure at http://lab.llvm.org:8011/builders/clang-cmake-armv7-global-isel/builds/7450/steps/ninja%20check%201/logs/FAIL%3A%20Clang%20Tools%3A%3Afuchsia-multiple-inheritance.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang-tools-extra/docs/cl
[clang-tools-extra] dd5571d - [clang-tools-extra] NFC: Fix trivial typo in documents and comments
Author: Kazuaki Ishizaki Date: 2020-04-05T15:28:40+09:00 New Revision: dd5571d51a0f6164cb66d02c8cd0e7032e42abe4 URL: https://github.com/llvm/llvm-project/commit/dd5571d51a0f6164cb66d02c8cd0e7032e42abe4 DIFF: https://github.com/llvm/llvm-project/commit/dd5571d51a0f6164cb66d02c8cd0e7032e42abe4.diff LOG: [clang-tools-extra] NFC: Fix trivial typo in documents and comments Differential Revision: https://reviews.llvm.org/D77458 Added: Modified: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk updated this revision to Diff 255119. kiszk added a comment. This includes a fix to break the llvm build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang-tools-extra/docs/clang-tidy/checks/performance-inefficient-vector-operation.rst clang-tools-extra/docs/cla
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a comment. Thank you for letting me know. I will do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a subscriber: sammccall. kiszk added a comment. Herald added a subscriber: wuzish. @sammccall, I am very sorry that I led to the build break due to my misoperation in https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77482/new/ https://reviews.llvm.org/D77482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77482: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk created this revision. Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb, arphaman, jkorous, kbarton, nemanjai. Herald added a project: clang. This also includes the build failure due to https://reviews.llvm.org/D77458 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77482 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
This revision was automatically updated to reflect the committed changes.
Closed by commit rGabdd042bb7a5: [clang-tools-extra] NFC: Fix trivial typo in
documents and comments (authored by kiszk).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/new/
https://reviews.llvm.org/D77458
Files:
clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
===
--- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
+++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
@@ -116,7 +116,7 @@
}
if (NumConcrete > 1) {
- diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "
+ diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");
}
}
Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
===
--- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
+++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
@@ -116,7 +116,7 @@
}
if (NumConcrete > 1) {
- diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "
+ diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");
}
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[clang-tools-extra] abdd042 - [clang-tools-extra] NFC: Fix trivial typo in documents and comments
Author: Kazuaki Ishizaki
Date: 2020-04-05T11:26:19+09:00
New Revision: abdd042bb7a58bdb2511f0c776ced2c7cb71cac4
URL:
https://github.com/llvm/llvm-project/commit/abdd042bb7a58bdb2511f0c776ced2c7cb71cac4
DIFF:
https://github.com/llvm/llvm-project/commit/abdd042bb7a58bdb2511f0c776ced2c7cb71cac4.diff
LOG: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
Differential Revision: https://reviews.llvm.org/D77458
Added:
Modified:
clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
Removed:
diff --git a/clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
b/clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
index 357ecb016173..76b8ac02990e 100644
--- a/clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
+++ b/clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
@@ -116,7 +116,7 @@ void MultipleInheritanceCheck::check(const
MatchFinder::MatchResult &Result) {
}
if (NumConcrete > 1) {
- diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "
+ diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");
}
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk updated this revision to Diff 255071.
kiszk added a comment.
address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/new/
https://reviews.llvm.org/D77458
Files:
clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
===
--- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
+++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
@@ -116,7 +116,7 @@
}
if (NumConcrete > 1) {
- diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "
+ diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");
}
}
Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
===
--- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
+++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
@@ -116,7 +116,7 @@
}
if (NumConcrete > 1) {
- diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "
+ diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");
}
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/fuchsia-multiple-inheritance.cpp:48
// Inherits from multiple concrete classes.
-// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting mulitple classes that
aren't pure virtual is discouraged [fuchsia-multiple-inheritance]
+// CHECK-MESSAGES: [[@LINE+2]]:1: warning: inheriting multiple classes that
aren't pure virtual is discouraged [fuchsia-multiple-inheritance]
// CHECK-NEXT: class Bad_Child1 : public Base_A, Base_B {};
sammccall wrote:
> Did you update the actual generated diagnostic in
> clang-tidy/fuchsia/MultipleInheritanceCheck.cpp? I don't see it in this patch.
Good catch. I also updated clang-tidy/fuchsia/MultipleInheritanceCheck.cpp.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77458/new/
https://reviews.llvm.org/D77458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77471: address review comment
kiszk added a comment. Sorry, I made a mistake. This should not be reviewed. This should be deleted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77471/new/ https://reviews.llvm.org/D77471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77471: address review comment
kiszk created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
kiszk added a comment.
kiszk removed a project: clang.
kiszk removed a subscriber: cfe-commits.
Herald added a project: clang.
Sorry, I made a mistake. This should not be reviewed. This should be deleted.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77471
Files:
clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
===
--- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
+++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
@@ -116,7 +116,7 @@
}
if (NumConcrete > 1) {
- diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "
+ diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");
}
}
Index: clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
===
--- clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
+++ clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
@@ -116,7 +116,7 @@
}
if (NumConcrete > 1) {
- diag(D->getBeginLoc(), "inheriting mulitple classes that aren't "
+ diag(D->getBeginLoc(), "inheriting multiple classes that aren't "
"pure virtual is discouraged");
}
}
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document
kiszk created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`the the` -> `the`
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D77470
Files:
clang/docs/LibASTMatchersReference.html
clang/include/clang/AST/ASTStructuralEquivalence.h
clang/include/clang/AST/ComparisonCategories.h
clang/include/clang/AST/OpenMPClause.h
clang/include/clang/ASTMatchers/ASTMatchers.h
clang/include/clang/DirectoryWatcher/DirectoryWatcher.h
clang/include/clang/Tooling/Transformer/RangeSelector.h
clang/lib/CodeGen/CGExprScalar.cpp
clang/lib/Lex/PPDirectives.cpp
clang/lib/Sema/SemaAvailability.cpp
Index: clang/lib/Sema/SemaAvailability.cpp
===
--- clang/lib/Sema/SemaAvailability.cpp
+++ clang/lib/Sema/SemaAvailability.cpp
@@ -57,7 +57,7 @@
/// \param D The declaration to check.
/// \param Message If non-null, this will be populated with the message from
/// the availability attribute that is selected.
-/// \param ClassReceiver If we're checking the the method of a class message
+/// \param ClassReceiver If we're checking the method of a class message
/// send, the class. Otherwise nullptr.
static std::pair
ShouldDiagnoseAvailabilityOfDecl(Sema &S, const NamedDecl *D,
Index: clang/lib/Lex/PPDirectives.cpp
===
--- clang/lib/Lex/PPDirectives.cpp
+++ clang/lib/Lex/PPDirectives.cpp
@@ -124,7 +124,7 @@
// the specified module, meaning clang won't build the specified module. This is
// useful in a number of situations, for instance, when building a library that
// vends a module map, one might want to avoid hitting intermediate build
-// products containimg the the module map or avoid finding the system installed
+// products containimg the module map or avoid finding the system installed
// modulemap for that library.
static bool isForModuleBuilding(Module *M, StringRef CurrentModule,
StringRef ModuleName) {
Index: clang/lib/CodeGen/CGExprScalar.cpp
===
--- clang/lib/CodeGen/CGExprScalar.cpp
+++ clang/lib/CodeGen/CGExprScalar.cpp
@@ -4708,7 +4708,7 @@
auto *GEP = cast(GEPVal);
assert(GEP->getPointerOperand() == BasePtr &&
- "BasePtr must be the the base of the GEP.");
+ "BasePtr must be the base of the GEP.");
assert(GEP->isInBounds() && "Expected inbounds GEP");
auto *IntPtrTy = DL.getIntPtrType(GEP->getPointerOperandType());
Index: clang/include/clang/Tooling/Transformer/RangeSelector.h
===
--- clang/include/clang/Tooling/Transformer/RangeSelector.h
+++ clang/include/clang/Tooling/Transformer/RangeSelector.h
@@ -40,7 +40,7 @@
/// Selects the (empty) range [B,B) when \p Selector selects the range [B,E).
RangeSelector before(RangeSelector Selector);
-/// Selects the the point immediately following \p Selector. That is, the
+/// Selects the point immediately following \p Selector. That is, the
/// (empty) range [E,E), when \p Selector selects either
/// * the CharRange [B,E) or
/// * the TokenRange [B,E'] where the token at E' spans the range [E,E').
Index: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h
===
--- clang/include/clang/DirectoryWatcher/DirectoryWatcher.h
+++ clang/include/clang/DirectoryWatcher/DirectoryWatcher.h
@@ -20,7 +20,7 @@
/// Provides notifications for file changes in a directory.
///
/// Invokes client-provided function on every filesystem event in the watched
-/// directory. Initially the the watched directory is scanned and for every file
+/// directory. Initially the watched directory is scanned and for every file
/// found, an event is synthesized as if the file was added.
///
/// This is not a general purpose directory monitoring tool - list of
Index: clang/include/clang/ASTMatchers/ASTMatchers.h
===
--- clang/include/clang/ASTMatchers/ASTMatchers.h
+++ clang/include/clang/ASTMatchers/ASTMatchers.h
@@ -303,7 +303,7 @@
/// Matches statements that are (transitively) expanded from the named macro.
/// Does not match if only part of the statement is expanded from that macro or
-/// if different parts of the the statement are expanded from different
+/// if different parts of the statement are expanded from different
/// appearances of the macro.
///
/// FIXME: Change to be a polymorphic matcher that works on any syntactic
Index: clang/include/clang/AST/OpenMPClause.h
===
--- clang/include/clang/AST/OpenMPClause.h
+++ clang/include/clang/AST/OpenMPClause.h
@@ -1788,13 +1788,13 @@
return IsExtended ? 2 : 0;
}
- /// Sets the the location of '(' in clause for 'depobj' directive.
+ /// Se
[Lldb-commits] [PATCH] D77460: [lldb] NFC: Fix trivial typo in comments, documents, and messages
kiszk created this revision. Herald added subscribers: lldb-commits, atanasyan, MaskRay, jrtc27, kbarton, mgorny, nemanjai, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77460 Files: lldb/bindings/interface/SBBlock.i lldb/bindings/interface/SBExpressionOptions.i lldb/bindings/interface/SBFile.i lldb/docs/lldb-platform-packets.txt lldb/examples/interposing/darwin/fd_interposing/FDInterposing.cpp lldb/examples/python/mach_o.py lldb/include/lldb/Symbol/LineEntry.h lldb/include/lldb/Symbol/SymbolFile.h lldb/include/lldb/Target/Platform.h lldb/include/lldb/Target/Process.h lldb/include/lldb/Target/Target.h lldb/include/lldb/Target/ThreadPlan.h lldb/include/lldb/Utility/Connection.h lldb/include/lldb/Utility/Reproducer.h lldb/include/lldb/Utility/Status.h lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/packages/Python/lldbsuite/test/test_runner/README.txt lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py lldb/scripts/verify_api.py lldb/source/Commands/CommandObjectWatchpoint.cpp lldb/source/Core/FormatEntity.cpp lldb/source/Host/common/Editline.cpp lldb/source/Host/common/NativeProcessProtocol.cpp lldb/source/Plugins/ABI/ARC/ABISysV_arc.cpp lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.h lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.h lldb/source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.h lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h lldb/source/Plugins/Process/Darwin/CFUtils.h lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp lldb/source/Plugins/Process/Utility/RegisterInfos_arm64.h lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.h lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp lldb/source/Symbol/ArmUnwindInfo.cpp lldb/source/Target/RegisterContextUnwind.cpp lldb/source/Target/StackFrame.cpp lldb/source/Target/StopInfo.cpp lldb/test/API/benchmarks/turnaround/TestCompileRunToBreakpointTurnaround.py lldb/test/API/functionalities/breakpoint/breakpoint_names/TestBreakpointNames.py lldb/test/API/functionalities/breakpoint/step_over_breakpoint/TestStepOverBreakpoint.py lldb/test/API/functionalities/load_unload/TestLoadUnload.py lldb/test/API/functionalities/plugins/python_os_plugin/TestPythonOSPlugin.py lldb/test/API/functionalities/process_crash_info/TestProcessCrashInfo.py lldb/test/API/functionalities/target-new-solib-notifications/TestModuleLoadedNotifys.py lldb/test/API/lang/cpp/namespace/ns3.cpp lldb/test/API/macosx/lc-note/kern-ver-str/TestKernVerStrLCNOTE.py lldb/test/API/macosx/lc-note/kern-ver-str/create-empty-corefile.cpp lldb/test/API/python_api/default-constructor/TestDefaultConstructorForAPIObjects.py lldb/test/API/python_api/frame/TestFrames.py lldb/test/API/python_api/function_symbol/main.c lldb/test/API/python_api/target/main.c lldb/test/API/python_api/thread/TestThreadAPI.py lldb/test/API/tools/lldb-server/main.cpp lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setExceptionBreakpoints.py lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setFunctionBreakpoints.py lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py lldb/test/API/tools/lldb-vscode/stackTrace/TestVSCode_stackTrace.py lldb/test/API/tools/lldb-vscode/step/TestVSCode_step.py lldb/test/Shell/SymbolFile/DWARF/anon_class_w_an
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk added a comment. I used aspell for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments
kiszk created this revision. Herald added subscribers: cfe-commits, phosek, usaxena95, kadircet, jfb, arphaman, jkorous, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77458 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-change-namespace/ChangeNamespace.h clang-tools-extra/clang-doc/Generators.cpp clang-tools-extra/clang-doc/Serialize.cpp clang-tools-extra/clang-include-fixer/IncludeFixer.h clang-tools-extra/clang-include-fixer/IncludeFixerContext.h clang-tools-extra/clang-include-fixer/SymbolIndexManager.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllSymbols.cpp clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py clang-tools-extra/clang-move/Move.cpp clang-tools-extra/clang-reorder-fields/ReorderFieldsAction.cpp clang-tools-extra/clang-tidy/abseil/DurationFactoryScaleCheck.cpp clang-tools-extra/clang-tidy/abseil/DurationRewriter.cpp clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/bugprone/FoldInitTypeCheck.cpp clang-tools-extra/clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousEnumUsageCheck.cpp clang-tools-extra/clang-tidy/bugprone/SuspiciousMissingCommaCheck.cpp clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.h clang-tools-extra/clang-tidy/fuchsia/MultipleInheritanceCheck.h clang-tools-extra/clang-tidy/hicpp/ExceptionBaseclassCheck.cpp clang-tools-extra/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp clang-tools-extra/clang-tidy/misc/NoRecursionCheck.cpp clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp clang-tools-extra/clang-tidy/readability/IsolateDeclarationCheck.cpp clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp clang-tools-extra/clang-tidy/readability/UppercaseLiteralSuffixCheck.cpp clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.h clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/clangd/FindTarget.h clang-tools-extra/clangd/FormattedString.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/PathMapping.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/index/Background.cpp clang-tools-extra/clangd/index/Serialization.cpp clang-tools-extra/clangd/index/SymbolOrigin.h clang-tools-extra/clangd/index/dex/Trigram.cpp clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/refactor/Rename.h clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp clang-tools-extra/clangd/tool/ClangdMain.cpp clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp clang-tools-extra/clangd/unittests/FindTargetTests.cpp clang-tools-extra/clangd/unittests/HeaderSourceSwitchTests.cpp clang-tools-extra/clangd/unittests/PathMappingTests.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp clang-tools-extra/clangd/unittests/TweakTests.cpp clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-pointer-arithmetic-in-alloc.rst clang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst clang-tools-extra/docs/clang-tidy/checks/performance-inefficient-vector-operation.r
[jira] [Commented] (SPARK-25728) SPIP: Structured Intermediate Representation (Tungsten IR) for generating Java code
[ https://issues.apache.org/jira/browse/SPARK-25728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061914#comment-17061914 ] Kazuaki Ishizaki commented on SPARK-25728: -- For now, no update on my side. I am happy if the community or PMCs want to revitalize it. Otherwise, should I close this? > SPIP: Structured Intermediate Representation (Tungsten IR) for generating > Java code > --- > > Key: SPARK-25728 > URL: https://issues.apache.org/jira/browse/SPARK-25728 > Project: Spark > Issue Type: New Feature > Components: SQL >Affects Versions: 3.1.0 > Reporter: Kazuaki Ishizaki >Priority: Major > > This JIRA entry is to start a discussion about adding structure intermediate > representation for generating Java code from a program using DataFrame or > Dataset API, in addition to the current String-based representation. > This addition is based on the discussions in [a > thread|https://github.com/apache/spark/pull/21537#issuecomment-413268196]. > Please feel free to comment on this JIRA entry or [Google > Doc|https://docs.google.com/document/d/1Jzf56bxpMpSwsGV_hSzl9wQG22hyI731McQcjognqxY/edit?usp=sharing], > too. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-25987) StackOverflowError when executing many operations on a table with many columns
[
https://issues.apache.org/jira/browse/SPARK-25987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058174#comment-17058174
]
Kazuaki Ishizaki commented on SPARK-25987:
--
Sorry for coming here late since I am busy these days (hopefully by tomorrow).
The analysis looks correct due to the recursive call at
https://github.com/janino-compiler/janino/blob/ccb4931fd605ed8081839f962b57ac3734db78ee/janino/src/main/java/org/codehaus/janino/CodeContext.java#L385.
As [~kabhwan] suggested, to add {{-Xss2m}} is conservative and safe workaround.
> StackOverflowError when executing many operations on a table with many columns
> --
>
> Key: SPARK-25987
> URL: https://issues.apache.org/jira/browse/SPARK-25987
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.2.1, 2.2.2, 2.3.0, 2.3.2, 2.4.0, 2.4.5
> Environment: Ubuntu 18.04.1 LTS, openjdk "1.8.0_181"
>Reporter: Ivan Tsukanov
>Priority: Major
>
> When I execute
> {code:java}
> import org.apache.spark.sql._
> import org.apache.spark.sql.types._
> val columnsCount = 100
> val columns = (1 to columnsCount).map(i => s"col$i")
> val initialData = (1 to columnsCount).map(i => s"val$i")
> val df = spark.createDataFrame(
> rowRDD = spark.sparkContext.makeRDD(Seq(Row.fromSeq(initialData))),
> schema = StructType(columns.map(StructField(_, StringType, true)))
> )
> val addSuffixUDF = udf(
> (str: String) => str + "_added"
> )
> implicit class DFOps(df: DataFrame) {
> def addSuffix() = {
> df.select(columns.map(col =>
> addSuffixUDF(df(col)).as(col)
> ): _*)
> }
> }
> df.addSuffix().addSuffix().addSuffix().show()
> {code}
> I get
> {code:java}
> An exception or error caused a run to abort.
> java.lang.StackOverflowError
> at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:385)
> at org.codehaus.janino.CodeContext.flowAnalysis(CodeContext.java:553)
> ...
> {code}
> If I reduce columns number (to 10 for example) or do `addSuffix` only once -
> it works fine.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
RE: [DISCUSS] naming policy of Spark configs
+1 if we add them to Alternative config.
Kazuaki Ishizaki
From: Takeshi Yamamuro
To: Wenchen Fan
Cc: Spark dev list
Date: 2020/02/13 16:02
Subject:[EXTERNAL] Re: [DISCUSS] naming policy of Spark configs
+1; the idea sounds reasonable.
Bests,
Takeshi
On Thu, Feb 13, 2020 at 12:39 PM Wenchen Fan wrote:
Hi Dongjoon,
It's too much work to revisit all the configs that added in 3.0, but I'll
revisit the recent commits that update config names and see if they follow
the new policy.
Hi Reynold,
There are a few interval configs:
spark.sql.streaming.fileSink.log.compactInterval
spark.sql.streaming.continuous.executorPollIntervalMs
I think it's better to put the interval unit in the config name, like
`executorPollIntervalMs`. Also the config should be created with
`.timeConf`, so that users can set values like "1 second", "2 minutes",
etc.
There is no config that uses date/timestamp as value AFAIK.
Thanks,
Wenchen
On Thu, Feb 13, 2020 at 11:29 AM Jungtaek Lim <
kabhwan.opensou...@gmail.com> wrote:
+1 Thanks for the proposal. Looks very reasonable to me.
On Thu, Feb 13, 2020 at 10:53 AM Hyukjin Kwon wrote:
+1.
2020년 2월 13일 (목) 오전 9:30, Gengliang Wang <
gengliang.w...@databricks.com>님이 작성:
+1, this is really helpful. We should make the SQL configurations
consistent and more readable.
On Wed, Feb 12, 2020 at 3:33 PM Rubén Berenguel
wrote:
I love it, it will make configs easier to read and write. Thanks Wenchen.
R
On 13 Feb 2020, at 00:15, Dongjoon Hyun wrote:
Thank you, Wenchen.
The new policy looks clear to me. +1 for the explicit policy.
So, are we going to revise the existing conf names before 3.0.0 release?
Or, is it applied to new up-coming configurations from now?
Bests,
Dongjoon.
On Wed, Feb 12, 2020 at 7:43 AM Wenchen Fan wrote:
Hi all,
I'd like to discuss the naming policy of Spark configs, as for now it
depends on personal preference which leads to inconsistent namings.
In general, the config name should be a noun that describes its meaning
clearly.
Good examples:
spark.sql.session.timeZone
spark.sql.streaming.continuous.executorQueueSize
spark.sql.statistics.histogram.numBins
Bad examples:
spark.sql.defaultSizeInBytes (default size for what?)
Also note that, config name has many parts, joined by dots. Each part is a
namespace. Don't create namespace unnecessarily.
Good example:
spark.sql.execution.rangeExchange.sampleSizePerPartition
spark.sql.execution.arrow.maxRecordsPerBatch
Bad examples:
spark.sql.windowExec.buffer.in.memory.threshold ("in" is not a useful
namespace, better to be .buffer.inMemoryThreshold)
For a big feature, usually we need to create an umbrella config to turn it
on/off, and other configs for fine-grained controls. These configs should
share the same namespace, and the umbrella config should be named like
featureName.enabled. For example:
spark.sql.cbo.enabled
spark.sql.cbo.starSchemaDetection
spark.sql.cbo.starJoinFTRatio
spark.sql.cbo.joinReorder.enabled
spark.sql.cbo.joinReorder.dp.threshold （BTW "dp" is not a good namespace
）
spark.sql.cbo.joinReorder.card.weight （BTW "card" is not a good namespace
）
For boolean configs, in general it should end with a verb, e.g.
spark.sql.join.preferSortMergeJoin. If the config is for a feature and you
can't find a good verb for the feature, featureName.enabled is also good.
I'll update https://spark.apache.org/contributing.html after we reach a
consensus here. Any comments are welcome!
Thanks,
Wenchen
--
---
Takeshi Yamamuro
[jira] [Commented] (SPARK-30711) 64KB JVM bytecode limit - janino.InternalCompilerException
[
https://issues.apache.org/jira/browse/SPARK-30711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035464#comment-17035464
]
Kazuaki Ishizaki commented on SPARK-30711:
--
The reason to show the exception as an error is whether the regular or the
error path is decided after this exception occurs. Let us think whether we can
show this exception will be shown later when the regular or the error path is
decided.
Of course, this change requires that agreement in the community.
The way to avoid the bytecode growth is to reduce the size of one SQL
statement. In this case, can you reduce # of when clause in one SQL?
> 64KB JVM bytecode limit - janino.InternalCompilerException
> --
>
> Key: SPARK-30711
> URL: https://issues.apache.org/jira/browse/SPARK-30711
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4
> Environment: Windows 10
> Spark 2.4.4
> scalaVersion 2.11.12
> JVM Oracle 1.8.0_221-b11
>Reporter: Frederik Schreiber
>Priority: Major
>
> Exception
> {code:java}
> ERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBorg.codehaus.janino.InternalCompilerException: Compiling
> "GeneratedClass": Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KB at
> org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:382) at
> org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:237) at
> org.codehaus.janino.SimpleCompiler.compileToClassLoader(SimpleCompiler.java:465)
> at
> org.codehaus.janino.ClassBodyEvaluator.compileToClass(ClassBodyEvaluator.java:313)
> at org.codehaus.janino.ClassBodyEvaluator.cook(ClassBodyEvaluator.java:235)
> at org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:207) at
> org.codehaus.commons.compiler.Cookable.cook(Cookable.java:80) at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.org$apache$spark$sql$catalyst$expressions$codegen$CodeGenerator$$doCompile(CodeGenerator.scala:1290)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1372)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1369)
> at
> org.spark_project.guava.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3599)
> at
> org.spark_project.guava.cache.LocalCache$Segment.loadSync(LocalCache.java:2379)
> at
> org.spark_project.guava.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2342)
> at
> org.spark_project.guava.cache.LocalCache$Segment.get(LocalCache.java:2257) at
> org.spark_project.guava.cache.LocalCache.get(LocalCache.java:4000) at
> org.spark_project.guava.cache.LocalCache.getOrLoad(LocalCache.java:4004) at
> org.spark_project.guava.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.compile(CodeGenerator.scala:1238)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.liftedTree1$1(WholeStageCodegenExec.scala:584)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.doExecute(WholeStageCodegenExec.scala:583)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
> at
> org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
> at
> org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152) at
> org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127) at
> org.apache.spark.sql.execution.SparkPlan.getByteArrayRdd(SparkPlan.scala:247)
> at
> org.apache.spark.sql.execution.SparkPlan.executeCollect(SparkPlan.scala:296)
[jira] [Commented] (ARROW-4018) [C++] RLE decoder may not big-endian compatible
[
https://issues.apache.org/jira/browse/ARROW-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034775#comment-17034775
]
Kazuaki Ishizaki commented on ARROW-4018:
-
Minor comment. This code should be
{code:c++}
T value = 0;
bool result =
bit_reader_.GetAligned(static_cast(BitUtil::CeilDiv(bit_width_,
8)), &value);
current_value_ = static_cast(value);
{code}
> [C++] RLE decoder may not big-endian compatible
> ---
>
> Key: ARROW-4018
> URL: https://issues.apache.org/jira/browse/ARROW-4018
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
>Affects Versions: 0.11.1
>Reporter: Antoine Pitrou
>Priority: Major
>
> This issue was found by Coverity. The {{RleDecoder::NextCounts}} method has
> the following code to fetch the repeated literal in repeated runs:
> {code:c++}
> bool result =
>
> bit_reader_.GetAligned(static_cast(BitUtil::CeilDiv(bit_width_, 8)),
> reinterpret_cast(¤t_value_));
> {code}
> Coverity says this:
> bq. Pointer "&this->current_value_" points to an object whose effective type
> is "unsigned long long" (64 bits, unsigned) but is dereferenced as a narrower
> "unsigned int" (32 bits, unsigned). This may lead to unexpected results
> depending on machine endianness.
> bq.
> In addition, it's not obvious whether {{current_value_}} also needs
> byte-swapping (presumably, at least in the Parquet file format, it's supposed
> to be stored in little-endian format in the RLE bitstream).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SPARK-30711) 64KB JVM bytecode limit - janino.InternalCompilerException
[
https://issues.apache.org/jira/browse/SPARK-30711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17033112#comment-17033112
]
Kazuaki Ishizaki commented on SPARK-30711:
--
[~schreiber] Sorry, I made a mistake. This test case can pass with master and
branch-2.4 in my end.
I have one question. Which value do you set into {{spark.sql.codegen.fallback}}
? The idea of the whole-stage codegen is stop using the whole-stage codegen if
the generated code is larger than 64KB. For it, [this
code|https://github.com/apache/spark/blob/branch-2.4/sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala#L600-L607]
catches the {{org.codehaus.janino.InternalCompilerException}} and tries to
recompile the code with smaller pieces.
> 64KB JVM bytecode limit - janino.InternalCompilerException
> --
>
> Key: SPARK-30711
> URL: https://issues.apache.org/jira/browse/SPARK-30711
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4
> Environment: Windows 10
> Spark 2.4.4
> scalaVersion 2.11.12
> JVM Oracle 1.8.0_221-b11
>Reporter: Frederik Schreiber
>Priority: Major
>
> Exception
> {code:java}
> ERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBorg.codehaus.janino.InternalCompilerException: Compiling
> "GeneratedClass": Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KB at
> org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:382) at
> org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:237) at
> org.codehaus.janino.SimpleCompiler.compileToClassLoader(SimpleCompiler.java:465)
> at
> org.codehaus.janino.ClassBodyEvaluator.compileToClass(ClassBodyEvaluator.java:313)
> at org.codehaus.janino.ClassBodyEvaluator.cook(ClassBodyEvaluator.java:235)
> at org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:207) at
> org.codehaus.commons.compiler.Cookable.cook(Cookable.java:80) at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.org$apache$spark$sql$catalyst$expressions$codegen$CodeGenerator$$doCompile(CodeGenerator.scala:1290)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1372)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1369)
> at
> org.spark_project.guava.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3599)
> at
> org.spark_project.guava.cache.LocalCache$Segment.loadSync(LocalCache.java:2379)
> at
> org.spark_project.guava.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2342)
> at
> org.spark_project.guava.cache.LocalCache$Segment.get(LocalCache.java:2257) at
> org.spark_project.guava.cache.LocalCache.get(LocalCache.java:4000) at
> org.spark_project.guava.cache.LocalCache.getOrLoad(LocalCache.java:4004) at
> org.spark_project.guava.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.compile(CodeGenerator.scala:1238)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.liftedTree1$1(WholeStageCodegenExec.scala:584)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.doExecute(WholeStageCodegenExec.scala:583)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
> at
> org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
> at
> org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152) at
> org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127) at
> org.apache.spark.sql.execution.SparkPlan.ge
[jira] [Commented] (SPARK-30711) 64KB JVM bytecode limit - janino.InternalCompilerException
[
https://issues.apache.org/jira/browse/SPARK-30711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17031276#comment-17031276
]
Kazuaki Ishizaki commented on SPARK-30711:
--
Now, I am looking at this with master branch at first.
> 64KB JVM bytecode limit - janino.InternalCompilerException
> --
>
> Key: SPARK-30711
> URL: https://issues.apache.org/jira/browse/SPARK-30711
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.4.0, 2.4.1, 2.4.2, 2.4.3, 2.4.4
> Environment: Windows 10
> Spark 2.4.4
> scalaVersion 2.11.12
> JVM Oracle 1.8.0_221-b11
>Reporter: Frederik Schreiber
>Priority: Major
>
> Exception
> {code:java}
> ERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBorg.codehaus.janino.InternalCompilerException: Compiling
> "GeneratedClass": Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KB at
> org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:382) at
> org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:237) at
> org.codehaus.janino.SimpleCompiler.compileToClassLoader(SimpleCompiler.java:465)
> at
> org.codehaus.janino.ClassBodyEvaluator.compileToClass(ClassBodyEvaluator.java:313)
> at org.codehaus.janino.ClassBodyEvaluator.cook(ClassBodyEvaluator.java:235)
> at org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:207) at
> org.codehaus.commons.compiler.Cookable.cook(Cookable.java:80) at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.org$apache$spark$sql$catalyst$expressions$codegen$CodeGenerator$$doCompile(CodeGenerator.scala:1290)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1372)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1369)
> at
> org.spark_project.guava.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3599)
> at
> org.spark_project.guava.cache.LocalCache$Segment.loadSync(LocalCache.java:2379)
> at
> org.spark_project.guava.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2342)
> at
> org.spark_project.guava.cache.LocalCache$Segment.get(LocalCache.java:2257) at
> org.spark_project.guava.cache.LocalCache.get(LocalCache.java:4000) at
> org.spark_project.guava.cache.LocalCache.getOrLoad(LocalCache.java:4004) at
> org.spark_project.guava.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.compile(CodeGenerator.scala:1238)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.liftedTree1$1(WholeStageCodegenExec.scala:584)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.doExecute(WholeStageCodegenExec.scala:583)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
> at
> org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
> at
> org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152) at
> org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127) at
> org.apache.spark.sql.execution.SparkPlan.getByteArrayRdd(SparkPlan.scala:247)
> at
> org.apache.spark.sql.execution.SparkPlan.executeCollect(SparkPlan.scala:296)
> at
> org.apache.spark.sql.Dataset.org$apache$spark$sql$Dataset$$collectFromPlan(Dataset.scala:3384)
> at org.apache.spark.sql.Dataset$$anonfun$collect$1.apply(Dataset.scala:2783)
> at org.apache.spark.sql.Dataset$$anonfun$collect$1.apply(Dataset.scala:2783)
> at org.apache.spark.sql.Dataset$$anonfun$53.apply(Dataset.scala:3365) at
> org.apache.spark.sql.execution.SQ
[jira] [Comment Edited] (SPARK-30711) 64KB JVM bytecode limit - janino.InternalCompilerException
[
https://issues.apache.org/jira/browse/SPARK-30711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029724#comment-17029724
]
Kazuaki Ishizaki edited comment on SPARK-30711 at 2/4/20 10:20 AM:
---
In my environment, both v3.0.0-preview `007c873a` and master `6097b343`
branches cause the exception.
was (Author: kiszk):
In my environment, both v3.0.0-preview and master branches cause the exception.
> 64KB JVM bytecode limit - janino.InternalCompilerException
> --
>
> Key: SPARK-30711
> URL: https://issues.apache.org/jira/browse/SPARK-30711
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.4.4
> Environment: Windows 10
> Spark 2.4.4
> scalaVersion 2.11.12
> JVM Oracle 1.8.0_221-b11
>Reporter: Frederik Schreiber
>Priority: Major
>
> Exception
> {code:java}
> ERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBorg.codehaus.janino.InternalCompilerException: Compiling
> "GeneratedClass": Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KB at
> org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:382) at
> org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:237) at
> org.codehaus.janino.SimpleCompiler.compileToClassLoader(SimpleCompiler.java:465)
> at
> org.codehaus.janino.ClassBodyEvaluator.compileToClass(ClassBodyEvaluator.java:313)
> at org.codehaus.janino.ClassBodyEvaluator.cook(ClassBodyEvaluator.java:235)
> at org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:207) at
> org.codehaus.commons.compiler.Cookable.cook(Cookable.java:80) at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.org$apache$spark$sql$catalyst$expressions$codegen$CodeGenerator$$doCompile(CodeGenerator.scala:1290)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1372)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1369)
> at
> org.spark_project.guava.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3599)
> at
> org.spark_project.guava.cache.LocalCache$Segment.loadSync(LocalCache.java:2379)
> at
> org.spark_project.guava.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2342)
> at
> org.spark_project.guava.cache.LocalCache$Segment.get(LocalCache.java:2257) at
> org.spark_project.guava.cache.LocalCache.get(LocalCache.java:4000) at
> org.spark_project.guava.cache.LocalCache.getOrLoad(LocalCache.java:4004) at
> org.spark_project.guava.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.compile(CodeGenerator.scala:1238)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.liftedTree1$1(WholeStageCodegenExec.scala:584)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.doExecute(WholeStageCodegenExec.scala:583)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
> at
> org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
> at
> org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152) at
> org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127) at
> org.apache.spark.sql.execution.SparkPlan.getByteArrayRdd(SparkPlan.scala:247)
> at
> org.apache.spark.sql.execution.SparkPlan.executeCollect(SparkPlan.scala:296)
> at
> org.apache.spark.sql.Dataset.org$apache$spark$sql$Dataset$$collectFromPlan(Dataset.scala:3384)
> at org.apache.spark.sql.Dataset$$anonfun$collect$1.apply(Dataset.scala:2783)
> at org.apache.spark.sql.Dataset$$ano
[jira] [Comment Edited] (SPARK-30711) 64KB JVM bytecode limit - janino.InternalCompilerException
[
https://issues.apache.org/jira/browse/SPARK-30711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029724#comment-17029724
]
Kazuaki Ishizaki edited comment on SPARK-30711 at 2/4/20 10:19 AM:
---
In my environment, both v3.0.0-preview and master branches cause the exception.
was (Author: kiszk):
In my environment, both v3.0.0-preview and master branches causes the exception.
> 64KB JVM bytecode limit - janino.InternalCompilerException
> --
>
> Key: SPARK-30711
> URL: https://issues.apache.org/jira/browse/SPARK-30711
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.4.4
> Environment: Windows 10
> Spark 2.4.4
> scalaVersion 2.11.12
> JVM Oracle 1.8.0_221-b11
>Reporter: Frederik Schreiber
>Priority: Major
>
> Exception
> {code:java}
> ERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBorg.codehaus.janino.InternalCompilerException: Compiling
> "GeneratedClass": Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KB at
> org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:382) at
> org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:237) at
> org.codehaus.janino.SimpleCompiler.compileToClassLoader(SimpleCompiler.java:465)
> at
> org.codehaus.janino.ClassBodyEvaluator.compileToClass(ClassBodyEvaluator.java:313)
> at org.codehaus.janino.ClassBodyEvaluator.cook(ClassBodyEvaluator.java:235)
> at org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:207) at
> org.codehaus.commons.compiler.Cookable.cook(Cookable.java:80) at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.org$apache$spark$sql$catalyst$expressions$codegen$CodeGenerator$$doCompile(CodeGenerator.scala:1290)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1372)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1369)
> at
> org.spark_project.guava.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3599)
> at
> org.spark_project.guava.cache.LocalCache$Segment.loadSync(LocalCache.java:2379)
> at
> org.spark_project.guava.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2342)
> at
> org.spark_project.guava.cache.LocalCache$Segment.get(LocalCache.java:2257) at
> org.spark_project.guava.cache.LocalCache.get(LocalCache.java:4000) at
> org.spark_project.guava.cache.LocalCache.getOrLoad(LocalCache.java:4004) at
> org.spark_project.guava.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.compile(CodeGenerator.scala:1238)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.liftedTree1$1(WholeStageCodegenExec.scala:584)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.doExecute(WholeStageCodegenExec.scala:583)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
> at
> org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
> at
> org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152) at
> org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127) at
> org.apache.spark.sql.execution.SparkPlan.getByteArrayRdd(SparkPlan.scala:247)
> at
> org.apache.spark.sql.execution.SparkPlan.executeCollect(SparkPlan.scala:296)
> at
> org.apache.spark.sql.Dataset.org$apache$spark$sql$Dataset$$collectFromPlan(Dataset.scala:3384)
> at org.apache.spark.sql.Dataset$$anonfun$collect$1.apply(Dataset.scala:2783)
> at org.apache.spark.sql.Dataset$$ano
[jira] [Commented] (SPARK-30711) 64KB JVM bytecode limit - janino.InternalCompilerException
[
https://issues.apache.org/jira/browse/SPARK-30711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17029724#comment-17029724
]
Kazuaki Ishizaki commented on SPARK-30711:
--
In my environment, both v3.0.0-preview and master branches causes the exception.
> 64KB JVM bytecode limit - janino.InternalCompilerException
> --
>
> Key: SPARK-30711
> URL: https://issues.apache.org/jira/browse/SPARK-30711
> Project: Spark
> Issue Type: Bug
> Components: SQL
>Affects Versions: 2.4.4
> Environment: Windows 10
> Spark 2.4.4
> scalaVersion 2.11.12
> JVM Oracle 1.8.0_221-b11
>Reporter: Frederik Schreiber
>Priority: Major
>
> Exception
> {code:java}
> ERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBERROR CodeGenerator: failed to compile:
> org.codehaus.janino.InternalCompilerException: Compiling "GeneratedClass":
> Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KBorg.codehaus.janino.InternalCompilerException: Compiling
> "GeneratedClass": Code of method "processNext()V" of class
> "org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage4"
> grows beyond 64 KB at
> org.codehaus.janino.UnitCompiler.compileUnit(UnitCompiler.java:382) at
> org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:237) at
> org.codehaus.janino.SimpleCompiler.compileToClassLoader(SimpleCompiler.java:465)
> at
> org.codehaus.janino.ClassBodyEvaluator.compileToClass(ClassBodyEvaluator.java:313)
> at org.codehaus.janino.ClassBodyEvaluator.cook(ClassBodyEvaluator.java:235)
> at org.codehaus.janino.SimpleCompiler.cook(SimpleCompiler.java:207) at
> org.codehaus.commons.compiler.Cookable.cook(Cookable.java:80) at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.org$apache$spark$sql$catalyst$expressions$codegen$CodeGenerator$$doCompile(CodeGenerator.scala:1290)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1372)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$$anon$1.load(CodeGenerator.scala:1369)
> at
> org.spark_project.guava.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3599)
> at
> org.spark_project.guava.cache.LocalCache$Segment.loadSync(LocalCache.java:2379)
> at
> org.spark_project.guava.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2342)
> at
> org.spark_project.guava.cache.LocalCache$Segment.get(LocalCache.java:2257) at
> org.spark_project.guava.cache.LocalCache.get(LocalCache.java:4000) at
> org.spark_project.guava.cache.LocalCache.getOrLoad(LocalCache.java:4004) at
> org.spark_project.guava.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4874)
> at
> org.apache.spark.sql.catalyst.expressions.codegen.CodeGenerator$.compile(CodeGenerator.scala:1238)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.liftedTree1$1(WholeStageCodegenExec.scala:584)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec.doExecute(WholeStageCodegenExec.scala:583)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:131)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:127)
> at
> org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:155)
> at
> org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
> at
> org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:152) at
> org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:127) at
> org.apache.spark.sql.execution.SparkPlan.getByteArrayRdd(SparkPlan.scala:247)
> at
> org.apache.spark.sql.execution.SparkPlan.executeCollect(SparkPlan.scala:296)
> at
> org.apache.spark.sql.Dataset.org$apache$spark$sql$Dataset$$collectFromPlan(Dataset.scala:3384)
> at org.apache.spark.sql.Dataset$$anonfun$collect$1.apply(Dataset.scala:2783)
> at org.apache.spark.sql.Dataset$$anonfun$collect$1.apply(Dataset.scala:2783)
> at org.apache.spark.sql.Dataset$$anonfun$53.apply(Dataset.scala:3365) at
> org.apache.spark.sql.execution.SQ
[jira] [Commented] (SPARK-22510) Exceptions caused by 64KB JVM bytecode or 64K constant pool entry limit
[ https://issues.apache.org/jira/browse/SPARK-22510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028784#comment-17028784 ] Kazuaki Ishizaki commented on SPARK-22510: -- [~schreiber] Thank you for reporting the problem. Could you please share a program that causes this problem? We want to know which operators cause this issue at first. > Exceptions caused by 64KB JVM bytecode or 64K constant pool entry limit > > > Key: SPARK-22510 > URL: https://issues.apache.org/jira/browse/SPARK-22510 > Project: Spark > Issue Type: Umbrella > Components: SQL >Affects Versions: 2.2.0 >Reporter: Xiao Li > Assignee: Kazuaki Ishizaki >Priority: Major > Labels: bulk-closed, releasenotes > > Codegen can throw an exception due to the 64KB JVM bytecode or 64K constant > pool entry limit. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk added a comment. I do not have commit rights to the repository. Could someone commit this change if it is OK? Kazuaki Ishizaki Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72140/new/ https://reviews.llvm.org/D72140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk updated this revision to Diff 236069.
kiszk added a comment.
Rebase with master
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72140/new/
https://reviews.llvm.org/D72140
Files:
clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp
clang-tools-extra/clang-doc/BitcodeReader.h
clang-tools-extra/clang-doc/Representation.h
clang-tools-extra/clang-doc/Serialize.cpp
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
clang-tools-extra/clang-include-fixer/IncludeFixerContext.cpp
clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el
clang-tools-extra/clang-move/tool/ClangMove.cpp
clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp
clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp
clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp
clang-tools-extra/clang-tidy/bugprone/StringLiteralWithEmbeddedNulCheck.cpp
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.cpp
clang-tools-extra/clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tools-extra/clang-tidy/google/IntegerTypesCheck.h
clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp
clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp
clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
clang-tools-extra/clang-tidy/performance/InefficientAlgorithmCheck.h
clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.h
clang-tools-extra/clang-tidy/utils/NamespaceAliaser.cpp
clang-tools-extra/clangd/AST.h
clang-tools-extra/clangd/ClangdLSPServer.h
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clangd/Context.h
clang-tools-extra/clangd/FindTarget.cpp
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/IncludeFixer.cpp
clang-tools-extra/clangd/ParsedAST.h
clang-tools-extra/clangd/Protocol.h
clang-tools-extra/clangd/SemanticHighlighting.h
clang-tools-extra/clangd/TUScheduler.h
clang-tools-extra/clangd/Trace.h
clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
clang-tools-extra/clangd/index/CanonicalIncludes.cpp
clang-tools-extra/clangd/index/Symbol.h
clang-tools-extra/clangd/refactor/Rename.cpp
clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp
clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
clang-tools-extra/clangd/unittests/HoverTests.cpp
clang-tools-extra/clangd/unittests/RenameTests.cpp
clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp
clang-tools-extra/clangd/unittests/SyncAPI.cpp
clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
clang-tools-extra/clangd/unittests/TweakTests.cpp
clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp
clang-tools-extra/clangd/unittests/XRefsTests.cpp
clang-tools-extra/docs/clang-tidy/checks/bugprone-branch-clone.rst
clang-tools-extra/docs/clang-tidy/checks/cert-mem57-cpp.rst
clang-tools-extra/docs/clang-tidy/checks/hicpp-undelegated-constructor.rst
clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst
clang-tools-extra/modularize/Modularize.cpp
clang-tools-extra/modularize/PreprocessorTracker.cpp
clang-tools-extra/pp-trace/PPCallbacksTracker.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc-custom.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-owning-memory-containers.cpp
clang-tools-extra/test/clang-tidy/checkers/modernize-make-unique.cpp
clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp
clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.m
clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.mm
clang-tools-extra/test/clang-tidy/checkers/readability-redundant-declaration.cpp
clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
Index: clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
===
--- clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
+++ clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
@@ -198,8 +198,8 @@
TEST_F(FindAllSymbolsTest, CXXRecordSymbols) {
static const char Header[] = R"(
struct Glob {};
- struct A; // Not a defintion, ignored.
- class NOP; // Not a defintion, ignored
+ struct A; // Not a definition, ignored.
+ class NOP; // Not a defini
[PATCH] D72140: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk created this revision.
Herald added subscribers: cfe-commits, usaxena95, jsji, kadircet, arphaman,
jkorous, javed.absar, kbarton, nemanjai.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D72140
Files:
clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp
clang-tools-extra/clang-doc/BitcodeReader.h
clang-tools-extra/clang-doc/Representation.h
clang-tools-extra/clang-doc/Serialize.cpp
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
clang-tools-extra/clang-include-fixer/IncludeFixerContext.cpp
clang-tools-extra/clang-include-fixer/tool/clang-include-fixer.el
clang-tools-extra/clang-move/tool/ClangMove.cpp
clang-tools-extra/clang-tidy/abseil/FasterStrsplitDelimiterCheck.cpp
clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp
clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp
clang-tools-extra/clang-tidy/bugprone/StringLiteralWithEmbeddedNulCheck.cpp
clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp
clang-tools-extra/clang-tidy/cppcoreguidelines/SlicingCheck.cpp
clang-tools-extra/clang-tidy/google/GlobalNamesInHeadersCheck.cpp
clang-tools-extra/clang-tidy/google/IntegerTypesCheck.h
clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp
clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp
clang-tools-extra/clang-tidy/modernize/UseNullptrCheck.cpp
clang-tools-extra/clang-tidy/performance/InefficientAlgorithmCheck.h
clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.h
clang-tools-extra/clang-tidy/readability/InconsistentDeclarationParameterNameCheck.cpp
clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.h
clang-tools-extra/clang-tidy/utils/NamespaceAliaser.cpp
clang-tools-extra/clangd/AST.h
clang-tools-extra/clangd/ClangdLSPServer.h
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clangd/Context.h
clang-tools-extra/clangd/FindTarget.cpp
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/IncludeFixer.cpp
clang-tools-extra/clangd/ParsedAST.h
clang-tools-extra/clangd/Protocol.h
clang-tools-extra/clangd/SemanticHighlighting.h
clang-tools-extra/clangd/TUScheduler.h
clang-tools-extra/clangd/Trace.h
clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
clang-tools-extra/clangd/index/CanonicalIncludes.cpp
clang-tools-extra/clangd/index/Symbol.h
clang-tools-extra/clangd/refactor/Rename.cpp
clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp
clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
clang-tools-extra/clangd/unittests/HoverTests.cpp
clang-tools-extra/clangd/unittests/RenameTests.cpp
clang-tools-extra/clangd/unittests/SymbolInfoTests.cpp
clang-tools-extra/clangd/unittests/SyncAPI.cpp
clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp
clang-tools-extra/clangd/unittests/TweakTests.cpp
clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp
clang-tools-extra/clangd/unittests/XRefsTests.cpp
clang-tools-extra/docs/clang-tidy/checks/bugprone-branch-clone.rst
clang-tools-extra/docs/clang-tidy/checks/cert-mem57-cpp.rst
clang-tools-extra/docs/clang-tidy/checks/hicpp-undelegated-constructor.rst
clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst
clang-tools-extra/modularize/Modularize.cpp
clang-tools-extra/modularize/PreprocessorTracker.cpp
clang-tools-extra/pp-trace/PPCallbacksTracker.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc-custom.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-no-malloc.cpp
clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-owning-memory-containers.cpp
clang-tools-extra/test/clang-tidy/checkers/modernize-make-unique.cpp
clang-tools-extra/test/clang-tidy/checkers/modernize-use-nullptr-basic.cpp
clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.m
clang-tools-extra/test/clang-tidy/checkers/performance-unnecessary-value-param-arc.mm
clang-tools-extra/test/clang-tidy/checkers/readability-redundant-declaration.cpp
clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
Index: clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
===
--- clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
+++ clang-tools-extra/unittests/clang-include-fixer/find-all-symbols/FindAllSymbolsTests.cpp
@@ -198,8 +198,8 @@
TEST_F(FindAllSymbolsTest, CXXRecordSymbols) {
static const char Header[] = R"(
struct Glob {};
- struct A; // Not a defintion, ignored.
- class NOP; // Not a defintion, ignored
+ struct A; // Not a definition, ignored.
+ cl
[PATCH] D72087: [clang-tools-extra] NFC: Fix trivial typos in comments
kiszk added a comment. I do not have commit rights to the repository. Could someone commit this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72087/new/ https://reviews.llvm.org/D72087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
[PATCH] D72087: NFC: Fix trivial typos in comments
kiszk created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous.
Herald added a project: clang.
"the the" -> "the"
"an" -> "a"
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D72087
Files:
clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h
clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
clang-tools-extra/clangd/CodeComplete.h
clang-tools-extra/clangd/unittests/TweakTests.cpp
clang-tools-extra/docs/doxygen.cfg.in
Index: clang-tools-extra/docs/doxygen.cfg.in
===
--- clang-tools-extra/docs/doxygen.cfg.in
+++ clang-tools-extra/docs/doxygen.cfg.in
@@ -46,7 +46,7 @@
PROJECT_BRIEF =
-# With the PROJECT_LOGO tag one can specify an logo or icon that is included in
+# With the PROJECT_LOGO tag one can specify a logo or icon that is included in
# the documentation. The maximum height of the logo should not exceed 55 pixels
# and the maximum width should not exceed 200 pixels. Doxygen will copy the
logo
# to the output directory.
Index: clang-tools-extra/clangd/unittests/TweakTests.cpp
===
--- clang-tools-extra/clangd/unittests/TweakTests.cpp
+++ clang-tools-extra/clangd/unittests/TweakTests.cpp
@@ -127,7 +127,7 @@
ExtraArgs.push_back("-x");
ExtraArgs.push_back("objective-c");
- // Ensure the the action can be initiated in the string literal.
+ // Ensure the action can be initiated in the string literal.
EXPECT_AVAILABLE(R"(id x = ^[[@[[^"^t^est^";)");
// Ensure that the action can't be initiated in other places.
Index: clang-tools-extra/clangd/CodeComplete.h
===
--- clang-tools-extra/clangd/CodeComplete.h
+++ clang-tools-extra/clangd/CodeComplete.h
@@ -61,7 +61,7 @@
bool IncludeIneligibleResults = false;
/// Combine overloads into a single completion item where possible.
- /// If none, the the implementation may choose an appropriate behavior.
+ /// If none, the implementation may choose an appropriate behavior.
/// (In practice, ClangdLSPServer enables bundling if the client claims
/// to supports signature help).
llvm::Optional BundleOverloads;
Index: clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
===
--- clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
+++ clang-tools-extra/clang-tidy/modernize/ReplaceAutoPtrCheck.cpp
@@ -114,7 +114,7 @@
this);
// Find ownership transfers via copy construction and assignment.
- // AutoPtrOwnershipTransferId is bound to the the part that has to be wrapped
+ // AutoPtrOwnershipTransferId is bound to the part that has to be wrapped
// into std::move().
// std::auto_ptr i, j;
// i = j;
Index: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h
===
--- clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h
+++ clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.h
@@ -145,7 +145,7 @@
///
/// In order to avoid this, this class looks at the container expression
/// `arr[k]` and decides whether or not it contains a sub-expression declared
- /// within the the loop body.
+ /// within the loop body.
bool dependsOnInsideVariable(const clang::Stmt *Body) {
DependsOnInsideVariable = false;
TraverseStmt(const_cast(Body));
Index: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
===
--- clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
+++ clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
@@ -867,7 +867,7 @@
return OldIndex->getName();
}
-/// Determines whether or not the the name \a Symbol conflicts with
+/// Determines whether or not the name \a Symbol conflicts with
/// language keywords or defined macros. Also checks if the name exists in
/// LoopContext, any of its parent contexts, or any of its child statements.
///
Index: clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
===
--- clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
+++ clang-tools-extra/clang-tidy/bugprone/NotNullTerminatedResultCheck.cpp
@@ -393,7 +393,7 @@
}
// If the destination array is the same length as the given length we have to
-// increase the capacity by one to create space for the the null terminator.
+// increase the capacity by one to create space for the null terminator.
static bool isDestCapacityFix(const MatchFinder::MatchResult &Result,
DiagnosticBuilder &Diag) {
[jira] [Created] (ARROW-7489) [CI] Fix typos
Kazuaki Ishizaki created ARROW-7489:
---
Summary: [CI] Fix typos
Key: ARROW-7489
URL: https://issues.apache.org/jira/browse/ARROW-7489
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{ci}} and other directories
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7489) [CI] Fix typos
Kazuaki Ishizaki created ARROW-7489:
---
Summary: [CI] Fix typos
Key: ARROW-7489
URL: https://issues.apache.org/jira/browse/ARROW-7489
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{ci}} and other directories
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ARROW-7488) [GLib] Fix typo and broken link
[
https://issues.apache.org/jira/browse/ARROW-7488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki updated ARROW-7488:
Summary: [GLib] Fix typo and broken link (was: [GLib] Fix typo)
> [GLib] Fix typo and broken link
> ---
>
> Key: ARROW-7488
> URL: https://issues.apache.org/jira/browse/ARROW-7488
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
> Assignee: Kazuaki Ishizaki
>Priority: Trivial
>
> Fix typo in files under {{c_glib}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ARROW-7488) [GLib] Fix typo and broken link
[
https://issues.apache.org/jira/browse/ARROW-7488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki updated ARROW-7488:
Description: Fix typo and broken link in files under {{c_glib}} directory
(was: Fix typo in files under {{c_glib}} directory)
> [GLib] Fix typo and broken link
> ---
>
> Key: ARROW-7488
> URL: https://issues.apache.org/jira/browse/ARROW-7488
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
> Assignee: Kazuaki Ishizaki
>Priority: Trivial
>
> Fix typo and broken link in files under {{c_glib}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7488) [GLib] Fix typo
Kazuaki Ishizaki created ARROW-7488:
---
Summary: [GLib] Fix typo
Key: ARROW-7488
URL: https://issues.apache.org/jira/browse/ARROW-7488
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{c_glib}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7488) [GLib] Fix typo
Kazuaki Ishizaki created ARROW-7488:
---
Summary: [GLib] Fix typo
Key: ARROW-7488
URL: https://issues.apache.org/jira/browse/ARROW-7488
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{c_glib}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7487) [Dev] fix typo
Kazuaki Ishizaki created ARROW-7487:
---
Summary: [Dev] fix typo
Key: ARROW-7487
URL: https://issues.apache.org/jira/browse/ARROW-7487
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{dev}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7487) [Dev] fix typo
Kazuaki Ishizaki created ARROW-7487:
---
Summary: [Dev] fix typo
Key: ARROW-7487
URL: https://issues.apache.org/jira/browse/ARROW-7487
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{dev}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (ARROW-7483) [C++][Parquet] Fix typos
[
https://issues.apache.org/jira/browse/ARROW-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki closed ARROW-7483.
---
Resolution: Fixed
> [C++][Parquet] Fix typos
>
>
> Key: ARROW-7483
> URL: https://issues.apache.org/jira/browse/ARROW-7483
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
> Assignee: Kazuaki Ishizaki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Fix typo in files under {{cpp/src/parquet}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (PARQUET-1734) [C++] Fix typo
Kazuaki Ishizaki created PARQUET-1734: - Summary: [C++] Fix typo Key: PARQUET-1734 URL: https://issues.apache.org/jira/browse/PARQUET-1734 Project: Parquet Issue Type: Improvement Reporter: Kazuaki Ishizaki Fix typos in files under `arrow/cpp/src/parquet` directory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-7483) [C++][Parquet] Fix typos
[
https://issues.apache.org/jira/browse/ARROW-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006295#comment-17006295
]
Kazuaki Ishizaki commented on ARROW-7483:
-
This is replaced with PARQUET-1734
> [C++][Parquet] Fix typos
>
>
> Key: ARROW-7483
> URL: https://issues.apache.org/jira/browse/ARROW-7483
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
> Assignee: Kazuaki Ishizaki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Fix typo in files under {{cpp/src/parquet}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ARROW-7483) [C++][Parquet] Fix typos
[
https://issues.apache.org/jira/browse/ARROW-7483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kazuaki Ishizaki updated ARROW-7483:
Summary: [C++][Parquet] Fix typos (was: [C++] Fix typos)
> [C++][Parquet] Fix typos
>
>
> Key: ARROW-7483
> URL: https://issues.apache.org/jira/browse/ARROW-7483
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Kazuaki Ishizaki
> Assignee: Kazuaki Ishizaki
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Fix typo in files under {{cpp/src/parquet}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7485) [c++][plasma] fix typo
Kazuaki Ishizaki created ARROW-7485:
---
Summary: [c++][plasma] fix typo
Key: ARROW-7485
URL: https://issues.apache.org/jira/browse/ARROW-7485
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{cpp/src/plasma}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7485) [c++][plasma] fix typo
Kazuaki Ishizaki created ARROW-7485:
---
Summary: [c++][plasma] fix typo
Key: ARROW-7485
URL: https://issues.apache.org/jira/browse/ARROW-7485
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{cpp/src/plasma}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7484) [c++][gandiva] fix typo
Kazuaki Ishizaki created ARROW-7484:
---
Summary: [c++][gandiva] fix typo
Key: ARROW-7484
URL: https://issues.apache.org/jira/browse/ARROW-7484
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{cpp/src/gandiva}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7484) [c++][gandiva] fix typo
Kazuaki Ishizaki created ARROW-7484:
---
Summary: [c++][gandiva] fix typo
Key: ARROW-7484
URL: https://issues.apache.org/jira/browse/ARROW-7484
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{cpp/src/gandiva}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7483) [c++][parquet] fix typo
Kazuaki Ishizaki created ARROW-7483:
---
Summary: [c++][parquet] fix typo
Key: ARROW-7483
URL: https://issues.apache.org/jira/browse/ARROW-7483
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{cpp/src/parquet}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7483) [c++][parquet] fix typo
Kazuaki Ishizaki created ARROW-7483:
---
Summary: [c++][parquet] fix typo
Key: ARROW-7483
URL: https://issues.apache.org/jira/browse/ARROW-7483
Project: Apache Arrow
Issue Type: Improvement
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{cpp/src/parquet}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7482) [c++][arrow] fix typo
Kazuaki Ishizaki created ARROW-7482:
---
Summary: [c++][arrow] fix typo
Key: ARROW-7482
URL: https://issues.apache.org/jira/browse/ARROW-7482
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{cpp/src/arrow}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7482) [c++][arrow] fix typo
Kazuaki Ishizaki created ARROW-7482:
---
Summary: [c++][arrow] fix typo
Key: ARROW-7482
URL: https://issues.apache.org/jira/browse/ARROW-7482
Project: Apache Arrow
Issue Type: Improvement
Components: C++
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{cpp/src/arrow}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7481) [c#] Fix typos
Kazuaki Ishizaki created ARROW-7481:
---
Summary: [c#] Fix typos
Key: ARROW-7481
URL: https://issues.apache.org/jira/browse/ARROW-7481
Project: Apache Arrow
Issue Type: Improvement
Components: C#
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{csharp}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7481) [c#] Fix typos
Kazuaki Ishizaki created ARROW-7481:
---
Summary: [c#] Fix typos
Key: ARROW-7481
URL: https://issues.apache.org/jira/browse/ARROW-7481
Project: Apache Arrow
Issue Type: Improvement
Components: C#
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typos in files under {{csharp}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7479) [rust][ruby][R] fix typos
Kazuaki Ishizaki created ARROW-7479:
---
Summary: [rust][ruby][R] fix typos
Key: ARROW-7479
URL: https://issues.apache.org/jira/browse/ARROW-7479
Project: Apache Arrow
Issue Type: Improvement
Components: R, Ruby, Rust
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{ruby}}, {{rust}}, and {r} directories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7479) [rust][ruby][R] fix typos
Kazuaki Ishizaki created ARROW-7479:
---
Summary: [rust][ruby][R] fix typos
Key: ARROW-7479
URL: https://issues.apache.org/jira/browse/ARROW-7479
Project: Apache Arrow
Issue Type: Improvement
Components: R, Ruby, Rust
Reporter: Kazuaki Ishizaki
Assignee: Kazuaki Ishizaki
Fix typo in files under {{ruby}}, {{rust}}, and {r} directories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7470) [JS] Fix typos
Kazuaki Ishizaki created ARROW-7470: --- Summary: [JS] Fix typos Key: ARROW-7470 URL: https://issues.apache.org/jira/browse/ARROW-7470 Project: Apache Arrow Issue Type: Improvement Components: JavaScript Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki Fix typos in files under js directory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7470) [JS] Fix typos
Kazuaki Ishizaki created ARROW-7470: --- Summary: [JS] Fix typos Key: ARROW-7470 URL: https://issues.apache.org/jira/browse/ARROW-7470 Project: Apache Arrow Issue Type: Improvement Components: JavaScript Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki Fix typos in files under js directory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7468) [Python] Fix typos
Kazuaki Ishizaki created ARROW-7468: --- Summary: [Python] Fix typos Key: ARROW-7468 URL: https://issues.apache.org/jira/browse/ARROW-7468 Project: Apache Arrow Issue Type: Improvement Components: Python Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki Fix typos in files under `python` directory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7468) [Python] Fix typos
Kazuaki Ishizaki created ARROW-7468: --- Summary: [Python] Fix typos Key: ARROW-7468 URL: https://issues.apache.org/jira/browse/ARROW-7468 Project: Apache Arrow Issue Type: Improvement Components: Python Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki Fix typos in files under `python` directory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7463) [Doc] Fix a broken link and typos
Kazuaki Ishizaki created ARROW-7463: --- Summary: [Doc] Fix a broken link and typos Key: ARROW-7463 URL: https://issues.apache.org/jira/browse/ARROW-7463 Project: Apache Arrow Issue Type: Improvement Components: Documentation Reporter: Kazuaki Ishizaki Fix For: 1.0.0 Fix a broken link and typos including missing periods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7463) [Doc] Fix a broken link and typos
Kazuaki Ishizaki created ARROW-7463: --- Summary: [Doc] Fix a broken link and typos Key: ARROW-7463 URL: https://issues.apache.org/jira/browse/ARROW-7463 Project: Apache Arrow Issue Type: Improvement Components: Documentation Reporter: Kazuaki Ishizaki Fix For: 1.0.0 Fix a broken link and typos including missing periods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7461) [Java] Fix typos and spelling
Kazuaki Ishizaki created ARROW-7461:
---
Summary: [Java] Fix typos and spelling
Key: ARROW-7461
URL: https://issues.apache.org/jira/browse/ARROW-7461
Project: Apache Arrow
Issue Type: Improvement
Components: Java
Affects Versions: 1.0.0
Reporter: Kazuaki Ishizaki
Fix typo under {{java}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7461) [Java] Fix typos and spelling
Kazuaki Ishizaki created ARROW-7461:
---
Summary: [Java] Fix typos and spelling
Key: ARROW-7461
URL: https://issues.apache.org/jira/browse/ARROW-7461
Project: Apache Arrow
Issue Type: Improvement
Components: Java
Affects Versions: 1.0.0
Reporter: Kazuaki Ishizaki
Fix typo under {{java}} directory
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ARROW-7458) [GLib] incorrect build dependency in Makefile
Kazuaki Ishizaki created ARROW-7458: --- Summary: [GLib] incorrect build dependency in Makefile Key: ARROW-7458 URL: https://issues.apache.org/jira/browse/ARROW-7458 Project: Apache Arrow Issue Type: Bug Components: GLib Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki The current makefile may ignore the dependency of files due to incorrect references of environment variables for BUILD_SOURCES. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7458) [GLib] incorrect build dependency in Makefile
Kazuaki Ishizaki created ARROW-7458: --- Summary: [GLib] incorrect build dependency in Makefile Key: ARROW-7458 URL: https://issues.apache.org/jira/browse/ARROW-7458 Project: Apache Arrow Issue Type: Bug Components: GLib Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki The current makefile may ignore the dependency of files due to incorrect references of environment variables for BUILD_SOURCES. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7457) [Doc] Fix typos
Kazuaki Ishizaki created ARROW-7457: --- Summary: [Doc] Fix typos Key: ARROW-7457 URL: https://issues.apache.org/jira/browse/ARROW-7457 Project: Apache Arrow Issue Type: Improvement Components: Documentation Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki Fix typos in files under `docs` directory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARROW-7457) [Doc] Fix typos
Kazuaki Ishizaki created ARROW-7457: --- Summary: [Doc] Fix typos Key: ARROW-7457 URL: https://issues.apache.org/jira/browse/ARROW-7457 Project: Apache Arrow Issue Type: Improvement Components: Documentation Affects Versions: 1.0.0 Reporter: Kazuaki Ishizaki Fix typos in files under `docs` directory -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARROW-6015) [Python] pyarrow wheel: `DLL load failed` when importing on windows
[ https://issues.apache.org/jira/browse/ARROW-6015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927606#comment-16927606 ] Kazuaki Ishizaki commented on ARROW-6015: - I see. I will investigate this beyond 0.15. > [Python] pyarrow wheel: `DLL load failed` when importing on windows > > > Key: ARROW-6015 > URL: https://issues.apache.org/jira/browse/ARROW-6015 > Project: Apache Arrow > Issue Type: Bug > Components: Packaging, Python >Affects Versions: 0.14.1 >Reporter: Ruslan Kuprieiev >Priority: Major > Labels: pull-request-available, wheel > Time Spent: 10m > Remaining Estimate: 0h > > When installing pyarrow 0.14.1 on windows 10 x64 with python 3.7, you get: > >>> import pyarrow > Traceback (most recent call last): > File "", line 1, in > File "C:\Python37\lib\site-packages\pyarrow\__init__.py", line 49, in > > from pyarrow.lib import cpu_count, set_cpu_count > ImportError: DLL load failed: The specified module could not be found. > On 0.14.0 everything works fine. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (ARROW-6015) [Python] pyarrow wheel: `DLL load failed` when importing on windows
[ https://issues.apache.org/jira/browse/ARROW-6015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927606#comment-16927606 ] Kazuaki Ishizaki edited comment on ARROW-6015 at 9/11/19 2:15 PM: -- I see. I will investigate how to bundle DLLs beyond 0.15. was (Author: kiszk): I see. I will investigate this beyond 0.15. > [Python] pyarrow wheel: `DLL load failed` when importing on windows > > > Key: ARROW-6015 > URL: https://issues.apache.org/jira/browse/ARROW-6015 > Project: Apache Arrow > Issue Type: Bug > Components: Packaging, Python >Affects Versions: 0.14.1 >Reporter: Ruslan Kuprieiev >Priority: Major > Labels: pull-request-available, wheel > Time Spent: 10m > Remaining Estimate: 0h > > When installing pyarrow 0.14.1 on windows 10 x64 with python 3.7, you get: > >>> import pyarrow > Traceback (most recent call last): > File "", line 1, in > File "C:\Python37\lib\site-packages\pyarrow\__init__.py", line 49, in > > from pyarrow.lib import cpu_count, set_cpu_count > ImportError: DLL load failed: The specified module could not be found. > On 0.14.0 everything works fine. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Comment Edited] (ARROW-6015) [Python] pyarrow wheel: `DLL load failed` when importing on windows
[
https://issues.apache.org/jira/browse/ARROW-6015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16927176#comment-16927176
]
Kazuaki Ishizaki edited comment on ARROW-6015 at 9/11/19 4:44 AM:
--
IIUC, there is already a paragraph to suggest installing Visual C++
Redistribute at
[here|https://arrow.apache.org/docs/python/install.html#using-pip]? Do we need
to update the link and add an example for a failure?
{code}
If you encounter any importing issues of the pip wheels on Windows, you may
need to install the Visual C++ Redistributable for Visual Studio 2015.
{code}
Finally (beyond 0.15?), is it the best solution to bundle the DLLs? Since I am
studying how to package whl in windows for the release, it takes a time for me
to find a way to bundle the DLLs. If there is a document, it helps me.
was (Author: kiszk):
IIUC, there is already a paragraph to suggest installing Visual C++
Redistribute at
[here|https://arrow.apache.org/docs/python/install.html#using-pip]? Do we need
to update the link and add an example for a failure?
{code}
If you encounter any importing issues of the pip wheels on Windows, you may
need to install the Visual C++ Redistributable for Visual Studio 2015.
{code}
Finally, is it the best solution to bundle the DLLs. Since I am studying how to
package whl in windows for the release, it takes a time for me to find a way to
bundle the DLLs. If there is a document, it helps me.
> [Python] pyarrow wheel: `DLL load failed` when importing on windows
>
>
> Key: ARROW-6015
> URL: https://issues.apache.org/jira/browse/ARROW-6015
> Project: Apache Arrow
> Issue Type: Bug
> Components: Packaging, Python
>Affects Versions: 0.14.1
>Reporter: Ruslan Kuprieiev
>Priority: Major
> Labels: wheel
> Fix For: 0.15.0
>
>
> When installing pyarrow 0.14.1 on windows 10 x64 with python 3.7, you get:
> >>> import pyarrow
> Traceback (most recent call last):
> File "", line 1, in
> File "C:\Python37\lib\site-packages\pyarrow\__init__.py", line 49, in
>
> from pyarrow.lib import cpu_count, set_cpu_count
> ImportError: DLL load failed: The specified module could not be found.
> On 0.14.0 everything works fine.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
