[jira] [Assigned] (OFBIZ-12653) Sanitizer fail

2024-07-09 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-12653:
-

Assignee: Michael Brohl

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (OFBIZ-12653) Sanitizer fail

2024-07-08 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reopened OFBIZ-12653:
---

I'm sorry [~jleroux] and [~iwolf] ,

but the newly introduced solution is bad in several ways and does make more 
problems than it solves.

First, it breaks the functionality to use a configured custom sanitizer by 
introducing a new sanitizer which is run before the custom sanitizer.

Second, the TagBalancingHtmlStreamEventReceiver does alter the content by 
escaping it for some characters. The hard coded replacement of those changes is 
bad practice and will need a code change for every other alteration this class 
will do.

I strongly recommend to revert this change and work on a non-breaking solution.

> Sanitizer  fail
> ---
>
> Key: OFBIZ-12653
> URL: https://issues.apache.org/jira/browse/OFBIZ-12653
> Project: OFBiz
>  Issue Type: Bug
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: CustomSafePolicy.patch, OFBIZ-12653.patch, 
> UtilCodec.patch
>
>
> I copied a text with multiple lines from a text editor into the Trumbowyg 
> Html field.The editor creates the Html structure using unclosed  elements.
> Unfortunately the sanitizer logic just takes . A security warning is 
> thrown and the content will not be stored.
> Issue also a request on Trumbowyg request list:
> [https://github.com/Alex-D/Trumbowyg/issues/1283]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11725) Have Order Entry Screen always show selection field for available agreement(s)

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11725.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Have Order Entry Screen always show selection field for available agreement(s)
> --
>
> Key: OFBIZ-11725
> URL: https://issues.apache.org/jira/browse/OFBIZ-11725
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: 17.12.03, Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: usability
> Attachments: Screen Shot 2020-05-23 at 08.49.01.png, Screen Shot 
> 2020-05-23 at 09.25.31.png
>
>
> See attached screenshot.
> Though the screenlet indicates that an agreement can be selected, there is no 
> selection field.
> addendum: 
> When one or more agreements are available for the counter party, then the 
> selection field is shown. When no agreements are available, the label should 
> still be shown plus an indication that no agreements are available.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11755) Cleanup Party profile menu

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11755.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Cleanup Party profile menu
> --
>
> Key: OFBIZ-11755
> URL: https://issues.apache.org/jira/browse/OFBIZ-11755
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: refactoring, usability
> Attachments: Screen Shot 2020-05-29 at 11.26.07.png
>
>
> See attached image.
> Over the years the party component has grown in a kind of catch all for 
> various overviews and links to other (dependent) webapp widgets and templates.
> The component and it functions should be used for user management functions, 
> not for enabling to create/edit/delete any other record where a partyId is 
> used that is part of another (dependent) component.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11726) Have PartyRole change effected in other entities

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11726.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Have PartyRole change effected in other entities
> 
>
> Key: OFBIZ-11726
> URL: https://issues.apache.org/jira/browse/OFBIZ-11726
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: refactoring, role, roles
>
> The (proposed) change in OFBIZ-5959 has an effect on other entities. This 
> ticket is intended to address that issue. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11713) Allow party selection only for appropriate request roles

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11713.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Allow party selection only for appropriate request roles
> 
>
> Key: OFBIZ-11713
> URL: https://issues.apache.org/jira/browse/OFBIZ-11713
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: request, role, roles, usability
>
> The party to be selected for a particular request role should be limited to 
> those parties having the appropriate PartyRole for requests set.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11718) Deleting a PartyRole from a party generates an error

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11718.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Deleting a PartyRole from a party generates an error
> 
>
> Key: OFBIZ-11718
> URL: https://issues.apache.org/jira/browse/OFBIZ-11718
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: 17.12.03, Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: role, roles, usability
> Attachments: Screen Shot 2020-05-20 at 09.10.15.png
>
>
> Deleting a role from a party generates an error when that PartyRole is used 
> in an other entity record.
> See attached screenshot
> Steps to reproduce:
>  # Go to 
> [https://demo-trunk.ofbiz.apache.org/partymgr/control/viewroles?partyId=DemoCustomer;|https://demo-trunk.ofbiz.apache.org/partymgr/control/viewroles?partyId=DemoCustomer]
>  # Remove the 'Contact' role from the party.
> See the error shown (attached screenshot).
> Such errors pop up due to referential integrity (used in other entities).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11710) Have widgets to show status and change over time in Agreements

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11710.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have widgets to show status and change over time in Agreements
> --
>
> Key: OFBIZ-11710
> URL: https://issues.apache.org/jira/browse/OFBIZ-11710
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: agreements, status, usability
>
> Currently there are no widgets to show the status of an agreement, and  the 
> status change(s) over time by the various parties on agreements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11682) ListAgreementItemSupplierProducts doesn't show products

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11682.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> ListAgreementItemSupplierProducts doesn't show products
> ---
>
> Key: OFBIZ-11682
> URL: https://issues.apache.org/jira/browse/OFBIZ-11682
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk, 
> Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>
> The products applied to a purchase agreement doesn't get shown in the 
> ListAgreementItemSupplierProducts overview.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11576) Make initialisation of the DWH more dynamic

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11576.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Make initialisation of the DWH more dynamic
> ---
>
> Key: OFBIZ-11576
> URL: https://issues.apache.org/jira/browse/OFBIZ-11576
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: dwh, initialisation, service
>
> Currently initialisation of the dwh is based on fixed parameters (fromDate, 
> thruDate). This should be improved UX-wise.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11712) Have a service that retrieves the parties with a particular roleTypeId

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11712.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service that retrieves the parties with a particular roleTypeId
> --
>
> Key: OFBIZ-11712
> URL: https://issues.apache.org/jira/browse/OFBIZ-11712
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: agreements, assignment, invoice, quote, role, roles
>
> Various create or edit forms involving assigning parties to a role for a 
> particular artefact (or object, like agreement, order, quote, invoice, etc) 
> allow to select from all parties and from all roles.
> See as an example of this: 
> https://demo-trunk.ofbiz.apache.org/ordermgr/control/EditQuoteRole?quoteId=CQ0001
> However, for many of those artefacts (or objects) there are specific roleType 
> records defined to cater to either permission related functions or to provide 
> flow functions regarding the objects.
> In order to help assigning a party for a given role associated to the object, 
> a generic service is required that retrieves the parties associated with the 
> role.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11635) Have entities, functions and services to support Procurement Analysis

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11635.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have entities, functions and services to support Procurement Analysis
> -
>
> Key: OFBIZ-11635
> URL: https://issues.apache.org/jira/browse/OFBIZ-11635
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, StarSchema, birt, dwh, service
>
> Have the following in place to support Procurement Analysis in the BI 
> components, including:
> * PurchaseInvoiceItemFact
> * PurchaseOrderItemFact
> * PurchaseInvoiceItemStarSchema
> * PurchaseOrderItemStarSchema
> * services and underlying functions to load/update the purchase item fact 
> tables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11575) Move dwh update services from ECA based to scheduled based

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11575.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Move dwh update services from ECA based to scheduled based
> --
>
> Key: OFBIZ-11575
> URL: https://issues.apache.org/jira/browse/OFBIZ-11575
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, dimension, dwh, service
>
> Currently several updates to the dimension and fact entities are ECA 
> triggered. In order to minimise system load during business hours, the dwh 
> update service(s) should be schedule based. This not only improves the 
> performance of the transaction engine, while at the same time it provides the 
> implementing organisation with the opportunity to put the service(s) on a 
> different spoke when having a clustered setup for OFBiz.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11570) Replace BI main page content in labels with content data

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11570.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Replace BI main page content in labels with content data
> 
>
> Key: OFBIZ-11570
> URL: https://issues.apache.org/jira/browse/OFBIZ-11570
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: bi, content, dwh
>
> Currently the content shown in the main page of the BI component is shown 
> through the application of a multitude of labels. 
> This should be done through content per the definitions in CONTENT component.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11473) Moving field type of dimensionId fields from 'id' to 'integer'

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11473.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Moving field type of dimensionId fields from 'id' to 'integer'
> --
>
> Key: OFBIZ-11473
> URL: https://issues.apache.org/jira/browse/OFBIZ-11473
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, birt, dimension, dwh
>
> Moving the field type of dimensioned fields in dimension and fact entities 
> from 'id' to 'integer'. 
> This will bring the application in line with conventions as defined in the 
> DWT. This applies to the 'OFBiz' tables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11464) Improve the ProductDimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11464.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve the ProductDimension
> 
>
> Key: OFBIZ-11464
> URL: https://issues.apache.org/jira/browse/OFBIZ-11464
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: ProductDimension, birt, dimension, dwh, product
>
> Improve the ProductDimension to have more attributes for filter and roll-up 
> purposes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11521) Improve SalesOrderItemStarSchema

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11521.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve SalesOrderItemStarSchema
> 
>
> Key: OFBIZ-11521
> URL: https://issues.apache.org/jira/browse/OFBIZ-11521
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: birt, dwh, starschema
>
> Improve the SalesOrderItemStarSchema to reflect changes in Dimension and Fact 
> tables.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11571) improve loadSalesOrderItemFact re dimension and fact entity changes

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11571.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> improve loadSalesOrderItemFact re dimension and fact entity changes
> ---
>
> Key: OFBIZ-11571
> URL: https://issues.apache.org/jira/browse/OFBIZ-11571
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, SalesOrderItemFact, birt, dimension, dwh, service
>
> Improve the loadSalesOrderItemFact function to include changes in dimension 
> and fact entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11518) Improve loadSalesOrderItemFact

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11518.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve loadSalesOrderItemFact
> --
>
> Key: OFBIZ-11518
> URL: https://issues.apache.org/jira/browse/OFBIZ-11518
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
> Environment: Improve
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, SalesOrderItemFact, birt, dwh, service
>
> Improve loadSalesOrderItemFact to reflect the changes in the entity model for 
> SalesOrderItemFact.
> e.g. add conversion for/of:
> * BILL_FROM_VENDOR
> * BILL_TO_CUSTOMER
> * productStoreID



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11460) Make ReportBuilder more dynamic

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11460.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Make ReportBuilder more dynamic
> ---
>
> Key: OFBIZ-11460
> URL: https://issues.apache.org/jira/browse/OFBIZ-11460
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: bi, birt, dwh, reporting, starschema
> Attachments: BI-ReportBuilder-DynamicReport.png, 
> BI-ReportBuilder-DynamicSelection-Resuult.png, 
> BI-ReportBuilder-StartScreen.png
>
>
> Currently the ReportBuilder requires that users must go back and forth when 
> they want to:
> * switch star schemas
> * select different fields
> This can be made more user friendly by having a one-page solution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11438) Improve InventoryItemStarSchema

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11438.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve InventoryItemStarSchema
> ---
>
> Key: OFBIZ-11438
> URL: https://issues.apache.org/jira/browse/OFBIZ-11438
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: birt, dwh, inventory, starschema
>
> Improve the InventoryItemStarSchema to include additional dimensions, such as:
> * OrganisationDimension
> * FacilityDimension
> and work with integer based dimensionIds of the DateDimension



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11459) Improve the InventoryItemFact regarding dimensions

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11459.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve the InventoryItemFact regarding dimensions
> --
>
> Key: OFBIZ-11459
> URL: https://issues.apache.org/jira/browse/OFBIZ-11459
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, InventoryItemFact, birt, dwh
>
> Improve the IIF to include various dimensions, e.g.
> FacilityDimension
> OrganisationDimension
> etc
> Have it working with DateDimension based on dimensionId as integer



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11430) getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record found

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11430.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record 
> found
> 
>
> Key: OFBIZ-11430
> URL: https://issues.apache.org/jira/browse/OFBIZ-11430
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: refactoring
>
> Currently the 'getDimensionIdFromNaturalKey' function in 
> DimensionServices.java returns the DimensionId when found with following code 
> excerpt
> {code:java}
> if (UtilValidate.isNotEmpty(lastDimensionValue)) {
> resultMap.put("dimensionId", 
> lastDimensionValue.getString("dimensionId"));
> }
> return resultMap;
> {code}
> And when not found it returns an empty result, leaving the using function 
> upstream to set the '_NF' value. 
> The 'getDimensionIdFromNaturalKey' function should return the 'NF' value when 
> no matching dimensionId is found. 
> This would simplify the upstream code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11053) Have a service to load records in the TimeEntryFact entity

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11053.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the TimeEntryFact entity
> --
>
> Key: OFBIZ-11053
> URL: https://issues.apache.org/jira/browse/OFBIZ-11053
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, TimeEntry, TimeEntryFact, birt, dwh, service, 
> timesheet
>
> Have a service that populates the TimeEntryFact entity.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11065) Have a service to load records in the facility dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11065.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the facility dimension
> 
>
> Key: OFBIZ-11065
> URL: https://issues.apache.org/jira/browse/OFBIZ-11065
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: FacilityDimension, birt, dimension, dwh, facility, 
> initialisation, service
>
> for dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11055) Have a Project Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11055.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a Project Dimension
> 
>
> Key: OFBIZ-11055
> URL: https://issues.apache.org/jira/browse/OFBIZ-11055
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: ProjectDimension, birt, dimension, dwh
>
> The component would benefit from a project dimension for future fact tables 
> and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11054) Have an Organisation Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11054.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have an Organisation Dimension
> --
>
> Key: OFBIZ-11054
> URL: https://issues.apache.org/jira/browse/OFBIZ-11054
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: OrganisationDimension, birt, dimension, dwh
>
> The component would benefit from an organisation dimension for future fact 
> tables and star schema view entities. This dimension captures the attributes 
> of the internal (accounting) parties.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11051) Have a TimeEntryFact entity

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11051.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a TimeEntryFact entity
> ---
>
> Key: OFBIZ-11051
> URL: https://issues.apache.org/jira/browse/OFBIZ-11051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, TimeEntry, TimeEntryFact, birt, dwh, timesheet
>
> Every organisation that has the requirement that its staff does time 
> registrations, will benefit from Business Intelligence on time registrations. 
> As OFBiz has such functionality (whether that is through the Project 
> component, the Scrum component, or otherwise) in play.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10998) Have a Time dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10998.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a Time dimension
> -
>
> Key: OFBIZ-10998
> URL: https://issues.apache.org/jira/browse/OFBIZ-10998
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: TimeDimension, birt, dimension, dwh, time
>
> The component would benefit from a time dimension for future fact tables and 
> star schema view entities.
> Per comments in OFBIZ-10990:
> As for time. yes we can add a static time dimension having are all time 
> increments between 00:00:00 and 23:59:59. If only using the minute 
> discriminator this would be a table consisting of 1440 records.
> Businesses are not that much interested in sales/purchases/etc. per second, 
> whereas  IT more often is (transactions per second), but at least the time 
> dimension will allow doing that in fact tables and star schemas. Businesses 
> are interested in stuff like: how do our sales in the morning compare to 
> sales in the afternoon, and how do our morning sales trend over time



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11031) Improve SalesOrderItemFact table

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11031.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve SalesOrderItemFact table
> 
>
> Key: OFBIZ-11031
> URL: https://issues.apache.org/jira/browse/OFBIZ-11031
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, SalesOrder, SalesOrderItemFact, birt, dwh
>
> Improve the SalesOrderFactTable to include additional dimensions, such as:
> * AccountDimension
> * CustomerDimension
> * OrganisationDimension
> * StoreDimension
> * SalesChannelDimension
> * SalesRepDimension
> Have the entity work with dateDimId as integer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11034) Have a Carrier dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11034.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a Carrier dimension
> 
>
> Key: OFBIZ-11034
> URL: https://issues.apache.org/jira/browse/OFBIZ-11034
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: CarrierDimension, birt, carrier, dimension, dwh
>
> The component would benefit from a Carrier dimension for future fact tables 
> and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10997) Have an Employee dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10997.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have an Employee dimension
> --
>
> Key: OFBIZ-10997
> URL: https://issues.apache.org/jira/browse/OFBIZ-10997
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: EmployeeDimension, birt, dimension, dwh, employee
>
> The component would benefit from an employee dimension (and appropriate 
> functions and services) for future fact tables and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10990) Improve the SalesInvoiceItemStarSchema

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10990.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve the SalesInvoiceItemStarSchema
> --
>
> Key: OFBIZ-10990
> URL: https://issues.apache.org/jira/browse/OFBIZ-10990
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: SalesInvoiceItemStarSchema, birt, dwh, star, starschema
>
> The star schema should be improved to include elements from:
>  * Customer dimension -for aggregations per customer
>  * Country dimension - for aggregations per country
>  * Date dimension - for aggregations per date
>  * Store dimension - for aggregations per store
>  * Channel dimension - for aggregations per sales channel
>  * Time dimensions - for aggregations per time slot



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10989) Have a Facility dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10989.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a Facility dimension
> -
>
> Key: OFBIZ-10989
> URL: https://issues.apache.org/jira/browse/OFBIZ-10989
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: FacilityDimension, birt, dimension, dwh, facility
>
> The component would benefit from a facility dimension for future fact tables 
> and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10991) Have a SalesChannel dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10991.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a SalesChannel dimension
> -
>
> Key: OFBIZ-10991
> URL: https://issues.apache.org/jira/browse/OFBIZ-10991
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh
>
> The component would benefit from a sales channel dimension for future fact 
> tables and star schema view entities



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10986) Have a Store Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10986.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a Store Dimension
> --
>
> Key: OFBIZ-10986
> URL: https://issues.apache.org/jira/browse/OFBIZ-10986
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: StoreDimension, birt, dimension, dwh, store
>
> The component would benefit from a store dimension for future fact tables and 
> star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10996) Have a Supplier dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10996.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a Supplier dimension
> -
>
> Key: OFBIZ-10996
> URL: https://issues.apache.org/jira/browse/OFBIZ-10996
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: SupplierDimension, birt, dimension, dww, supplier
>
> The component would benefit from a Supplier dimension for future fact tables 
> and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10956) Have a service to load records in the CountryDimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10956.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the CountryDimension
> --
>
> Key: OFBIZ-10956
> URL: https://issues.apache.org/jira/browse/OFBIZ-10956
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: CountryDimension, birt, country, dimension, dwh, service
> Attachments: OFBIZ-10956.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Depending on [OFBIZ-10954|https://issues.apache.org/jira/browse/OFBIZ-10954]
> The service should be invoked on initialisation of the data warehouse.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10947) Have DateDimension have a dimensionId that is based on the natural key

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10947.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have DateDimension have a dimensionId that is based on the natural key
> --
>
> Key: OFBIZ-10947
> URL: https://issues.apache.org/jira/browse/OFBIZ-10947
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Release Branch 16.11, Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: DateDimension, birt, dimension, dwh
>
> Currently the record sequencer (delegator.getNextSeqId) is used to determine 
> the dimensionId for the DateDimension. This is unnecessary as the date (when 
> correctly formatted) can be used. 
> When formatted as 'MMdd' a dimensionId could be 20190423, which is a 
> correctly 'sequenced' primary key. 
> It also makes it easier to set the foreign-key in fact tables by generating 
> it based on the date, than by retrieving the dimensionId based on a retrieval 
> through the getDimensionIdFromNaturalKey service.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10953) have CurrencyDimension have a dimensionId that is based on the natural key

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10953.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> have CurrencyDimension have a dimensionId that is based on the natural key
> --
>
> Key: OFBIZ-10953
> URL: https://issues.apache.org/jira/browse/OFBIZ-10953
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: CurrencyDimension, birt, currency, dimension, dwh
> Attachments: 20200208_094840.jpg
>
>
> Currently the record sequencer (delegator.getNextSeqId) is used to determine 
> the dimensionId for the CurrencyDimension. This is unnecessary as the uomId 
> from the UOM table can be used for currency.
> It also makes it easier to set the foreign-key in fact tables by generating 
> it based on the date provided, than by retrieving the dimensionId based on a 
> retrieval through the getDimensionIdFromNaturalKey service.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10944) Have a Customer Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10944.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a Customer Dimension
> -
>
> Key: OFBIZ-10944
> URL: https://issues.apache.org/jira/browse/OFBIZ-10944
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Release Branch 16.11, Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: CustomerDimension, birt, customer, dimension, dwh
>
> The component would benefit from a customer dimension for future fact tables 
> and star schema view entities



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10923) Simplify folder structure regarding report designs

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10923.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Simplify folder structure regarding report designs
> --
>
> Key: OFBIZ-10923
> URL: https://issues.apache.org/jira/browse/OFBIZ-10923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10923-birt.patch, 
> OFBIZ-10923-ofbiz-plugins-birt.patch, OFBIZ-10923-plugings-birth.diff
>
>
> Currently the report designs in the Birt component are nested within webapp 
> subfolders. The folder structure for the designs should follow the convention 
> for Freemarker templates and Groovy scripts.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10363) Improve Dutch translations

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10363.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Implemented

> Improve Dutch translations
> --
>
> Key: OFBIZ-10363
> URL: https://issues.apache.org/jira/browse/OFBIZ-10363
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: ofbiz-10363-AccountingUiLabels.xml.patch
>
>
> A more complete/improved translation of labels increases the appeal of OFBiz.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5996) Handling of Agreement Role(s)

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5996.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Handling of Agreement Role(s)
> -
>
> Key: OFBIZ-5996
> URL: https://issues.apache.org/jira/browse/OFBIZ-5996
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: agreement(s), role, roles
>
> The roles screen on an agreement enable the user to add any party into any 
> role on the agreement. 
> An example, user bizadmin can select party DemoEmployee for role PACKER and 
> try to persist this agreement role. This leads to an error, like below:
> {code:java}
> The Following Errors Occurred:Error doing entity-auto operation for entity 
> AgreementRole in service createAgreementRole: 
> org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:AgreementRole][agreementId,AGR_SALES(java.lang.String)][createdStamp,2021-11-04
>  11:14:26.779(java.sql.Timestamp)][createdTxStamp,2021-11-04 
> 11:14:26.779(java.sql.Timestamp)][lastUpdatedStamp,2021-11-04 
> 11:14:26.779(java.sql.Timestamp)][lastUpdatedTxStamp,2021-11-04 
> 11:14:26.779(java.sql.Timestamp)][partyId,DemoEmployee(java.lang.String)][roleTypeId,PACKER(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> OFBIZ.AGREEMENT_ROLE (AGREEMENT_ID, PARTY_ID, ROLE_TYPE_ID, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) 
> VALUES (?, ?, ?, ?, ?, ?, ?) (INSERT on table 'AGREEMENT_ROLE' caused a 
> violation of foreign key constraint 'AGRMNT_ROLE_PRLE' for key 
> (DemoEmployee,PACKER). The statement has been rolled back.)) (Error while 
> inserting: 
> [GenericEntity:AgreementRole][agreementId,AGR_SALES(java.lang.String)][createdStamp,2021-11-04
>  11:14:26.779(java.sql.Timestamp)][createdTxStamp,2021-11-04 
> 11:14:26.779(java.sql.Timestamp)][lastUpdatedStamp,2021-11-04 
> 11:14:26.779(java.sql.Timestamp)][lastUpdatedTxStamp,2021-11-04 
> 11:14:26.779(java.sql.Timestamp)][partyId,DemoEmployee(java.lang.String)][roleTypeId,PACKER(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> OFBIZ.AGREEMENT_ROLE (AGREEMENT_ID, PARTY_ID, ROLE_TYPE_ID, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP) 
> VALUES (?, ?, ?, ?, ?, ?, ?) (INSERT on table 'AGREEMENT_ROLE' caused a 
> violation of foreign key constraint 'AGRMNT_ROLE_PRLE' for key 
> (DemoEmployee,PACKER). The statement has been rolled back.)))
> {code}
> The error message is valid, as the selected party doesn't have the selected 
> role assigned to him. But undesirable.
> Even though it is questionable whether a party should be assigned to the role 
> of PACKER on an agreement (and lets for the sake of the argument accept that 
> it is a valid choice), the user then needs to ensure that the party gets the 
> role before the agreement role can be established.
> In order to mitigate this, the user should only be able to:
>  # select a role that is applicable to an agreement (e.g. editor, reviewer, 
> approver), and then
>  # select a party who has such role assiocated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-6231) Have a function to manage the configuration of the BI component

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-6231.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Have a function to manage the configuration of the BI component
> ---
>
> Key: OFBIZ-6231
> URL: https://issues.apache.org/jira/browse/OFBIZ-6231
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: configuration, multi-tenant
> Attachments: OFBIZ-6231-biConfigMgt.patch
>
>
> The admin of the BI component should be able to set and adjust the system 
> properties related to the BI component from within the BI component.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5989) Have Agreement screens/forms work with fromDate and truDate

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5989.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Have Agreement screens/forms work with fromDate and truDate
> ---
>
> Key: OFBIZ-5989
> URL: https://issues.apache.org/jira/browse/OFBIZ-5989
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: agreement(s), role, roles
>
> Parties involved in an agreement (in whatever role/capacity) can phase out, 
> and replacements can phase in thereafter. This is in essence a transfer of 
> power. 
> In order to trace who can do what when, the widgets related to AgreementRole 
> need to have the fields fromDate and thruDate added.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5991) Have AgreementRole entity have fromDate & thruDate

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5991.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Have AgreementRole entity have fromDate & thruDate
> --
>
> Key: OFBIZ-5991
> URL: https://issues.apache.org/jira/browse/OFBIZ-5991
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: agreement(s), role, roles
>
> Parties involved in an agreement (in whatever role/capacity) can phase out, 
> and replacements can phase in thereafter. This is in essence a transfer of 
> power. 
> In order to trace who can do what when, the entity AgreementRole needs to 
> have the fields fromDate and thruDate added. and the fromDate needs to be 
> part of the primary key of the entity.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5980) Have the ability to revoke (expire) roles of a party

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5980.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Have the ability to revoke (expire) roles of a party
> 
>
> Key: OFBIZ-5980
> URL: https://issues.apache.org/jira/browse/OFBIZ-5980
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: roles
>
> Currently it is only possible to delete a PartyRole record from a party.
> Which leads to error messages, when that particular Partyrole record is 
> associated with records in other entities where the PartyRole entity is set 
> as a relation (through  which is 
> applied as a foreign key relation in the underlying dbms ).
> Examples of such related entities that are:
> * entity-name="MarketingCampaignRole"
> * entity-name="BudgetRole"
> In order to avoid such, it is better to revoke the PartyRole record by 
> setting an expiration date (end date) on the record.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5966) Update SeedData re PartyRole lifespan fields

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5966.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Update SeedData re PartyRole lifespan fields
> 
>
> Key: OFBIZ-5966
> URL: https://issues.apache.org/jira/browse/OFBIZ-5966
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-5966-SecurityPermissionSeedData.xml.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5965) PartyRole Lifespan fields - Have PartyRole screens/forms work with the change

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5965.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> PartyRole Lifespan fields - Have PartyRole screens/forms work with the change
> -
>
> Key: OFBIZ-5965
> URL: https://issues.apache.org/jira/browse/OFBIZ-5965
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: role, roles, usability
>
> Screens/forms need to be adjusted to work with change in the entity model.
> Intention to have an 'expireLink' enabling the user to expire the role 
> assignment.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5959) Add lifespan fields to PartyRole

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5959.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Add lifespan fields to PartyRole
> 
>
> Key: OFBIZ-5959
> URL: https://issues.apache.org/jira/browse/OFBIZ-5959
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: role, roles, usability
> Attachments: Screen Shot 2020-05-20 at 09.10.15.png
>
>
> Currently the assignments of roles to parties are boolean (there or not 
> there).
> As stated in a comment below:
> ??Reopening, as removing a PartyRole from a party can lead to errors.??
> ?? Steps to reproduce:??
>  * ??Go to 
> [https://demo-trunk.ofbiz.apache.org/partymgr/control/viewroles?partyId=DemoCustomer];??
>  * ??Remove the 'Contact' role from the party.??
> ??See the error shown (attached screenshot).??
> ??Such errors pop up due to referential integrity (used in other entities).??
> However, these role assignments also have a lifespan, and PartyRole records 
> are used in specific object role entities (such as: AgreementRole, QuoteRole, 
> RequestRole, etc.)
> This can be achieved by adding fromDate and thruDate fields.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-5961) Update DemoData re PartyRole lifespan

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-5961.

  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Update DemoData re PartyRole lifespan
> -
>
> Key: OFBIZ-5961
> URL: https://issues.apache.org/jira/browse/OFBIZ-5961
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: role, roles
> Attachments: OFBIZ-5959-PartyDemoData.xml.patch, 
> OFBIZ-5959-ProjectMgrDemoData.patch, OFBIZ-5959-ScrumDemoData.patch, 
> OFBIZ-5959-SecurityExtUserDemoData.xml.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11092) Have a service to load records in the asset dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11092.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the asset dimension
> -
>
> Key: OFBIZ-11092
> URL: https://issues.apache.org/jira/browse/OFBIZ-11092
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: AssetDimension, asset, birt, dimension, dwh, service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11091) Have an AssetDimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11091.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have an AssetDimension
> --
>
> Key: OFBIZ-11091
> URL: https://issues.apache.org/jira/browse/OFBIZ-11091
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: AssetDimension, asset, birt, dimension, dwh
>
> The component would benefit from a brand dimension for future fact tables and 
> star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11089) Have a service to load records in the sales promo dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11089.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the sales promo dimension
> ---
>
> Key: OFBIZ-11089
> URL: https://issues.apache.org/jira/browse/OFBIZ-11089
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: SalesPromoDimension, birt, dimension, dwh, service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11087) Have a service to load records in the project task dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11087.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the project task dimension
> 
>
> Key: OFBIZ-11087
> URL: https://issues.apache.org/jira/browse/OFBIZ-11087
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: ProjectTaskDimension, birt, dimension, dwh, service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11086) Have a ProjectTask Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11086.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a ProjectTask Dimension
> 
>
> Key: OFBIZ-11086
> URL: https://issues.apache.org/jira/browse/OFBIZ-11086
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: ProjectTaskDimension, birt, dimension, dwh
>
> The component would benefit from a project task dimension for future fact 
> tables and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11093) Have an AssetUtilisationFact entity

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11093.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have an AssetUtilisationFact entity
> ---
>
> Key: OFBIZ-11093
> URL: https://issues.apache.org/jira/browse/OFBIZ-11093
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: AssetUtilisationFact, Fact, asset, birt, dwh
>
> Every organisation that has rents out equipment or uses such in 
> manufacturing, will benefit from Business Intelligence on asset utilisation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11088) Have a SalesPromo Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11088.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a SalesPromo Dimension
> ---
>
> Key: OFBIZ-11088
> URL: https://issues.apache.org/jira/browse/OFBIZ-11088
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: SalesPromoDimension, birt, dimension, dwh
>
> The component would benefit from a project task dimension for future fact 
> tables and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11082) Improve the SalesInvoiceItemFact regarding dimensions

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11082.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Improve the SalesInvoiceItemFact regarding dimensions
> -
>
> Key: OFBIZ-11082
> URL: https://issues.apache.org/jira/browse/OFBIZ-11082
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: Fact, SalesInvoiceItemFact, birt, dwh
>
> Improve the SIIF to include various dimensions, e.g.
>  * OrganisationDimension
>  * CustomerDimension
>  * etc
> Have it working with dateDimeId as integer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11081) Have a service to load records in the supplier dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11081.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the supplier dimension
> 
>
> Key: OFBIZ-11081
> URL: https://issues.apache.org/jira/browse/OFBIZ-11081
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: SupplierDimension, birt, dimension, dwh, initialisation, 
> service, supplier
>
> for dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11084) Have a service to load records in the account dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11084.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the account dimension
> ---
>
> Key: OFBIZ-11084
> URL: https://issues.apache.org/jira/browse/OFBIZ-11084
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: AccountDimension, account, birt, dimension, dwh, service
>
> for dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11085) Have a service to load records in the carrier dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11085.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the carrier dimension
> ---
>
> Key: OFBIZ-11085
> URL: https://issues.apache.org/jira/browse/OFBIZ-11085
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: CarrierDimension, birt, carrier, dimension, dwh, service
>
> for dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11083) Have an Account Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11083.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have an Account Dimension
> -
>
> Key: OFBIZ-11083
> URL: https://issues.apache.org/jira/browse/OFBIZ-11083
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: AccountDimension, account, birt, dimension, dwh
>
> The component would benefit from an account dimension for future fact tables 
> and star schema view entities.
> The AccountDimension captures all those parties with roleTypeId="ACCOUNT".
> Accounts are those parties identified by the Sales department, who haven't 
> placed an order yet (thus aren't parties with roleTypeId="CUSTOMER". These 
> parties can be associated with ForeCasts, Opportunities, Quotes and Requests



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11077) Have a service to load records in the pos terminal dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11077.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the pos terminal dimension
> 
>
> Key: OFBIZ-11077
> URL: https://issues.apache.org/jira/browse/OFBIZ-11077
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: PosTerminalDimension, birt, dwh, initialisation, pos, 
> service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11072) Have a service to load records in the customer dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11072.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the customer dimension
> 
>
> Key: OFBIZ-11072
> URL: https://issues.apache.org/jira/browse/OFBIZ-11072
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: CustomerDimension, birt, customer, dimension, dwh, 
> initialisation, service
>
> for dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11073) Have a PoSTerminal Dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11073.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a PoSTerminal Dimension
> 
>
> Key: OFBIZ-11073
> URL: https://issues.apache.org/jira/browse/OFBIZ-11073
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: PosTerminalDimension, birt, dimension, dwh
>
> The component would benefit from a PoS terminal dimension for future fact 
> tables and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11076) Have a service to load records in the project dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11076.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the project dimension
> ---
>
> Key: OFBIZ-11076
> URL: https://issues.apache.org/jira/browse/OFBIZ-11076
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: ProjectDimension, birt, dwh, initialisation, project, 
> service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11074) Have a service to load records in the sales channel dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11074.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the sales channel dimension
> -
>
> Key: OFBIZ-11074
> URL: https://issues.apache.org/jira/browse/OFBIZ-11074
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: SalesChannel, SalesChannelDimension, birt, dwh, 
> initialisation, service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11075) Have a service to load records in the store dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11075.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Abandoned

> Have a service to load records in the store dimension
> -
>
> Key: OFBIZ-11075
> URL: https://issues.apache.org/jira/browse/OFBIZ-11075
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: StoreDimension, birt, dwh, initialisation, service, store
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11066) Have a service to load records in the organisation dimension

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11066.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Have a service to load records in the organisation dimension
> 
>
> Key: OFBIZ-11066
> URL: https://issues.apache.org/jira/browse/OFBIZ-11066
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: OrganisationDimension, birt, dimension, dwh, 
> initialisation, service
>
> For dwh initialisation. Applicable to internal (accounting) organisations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12535) Requirement - VIEW permissions

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12535.
-
  Assignee: Michael Brohl  (was: Pierre Smits)
Resolution: Won't Do

> Requirement - VIEW permissions
> --
>
> Key: OFBIZ-12535
> URL: https://issues.apache.org/jira/browse/OFBIZ-12535
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
>  Labels: permissions, requirement, trust, usability, ux
>
> Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo 
> with userId = auditor, accessing the Requirement screen, sees editable fields 
> and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' 
> permissions.
>  
> To see/test: 
> https://localhost:8443/ordermgr/control/EditRequirement?requirementId=1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12538) Tracking Code - Forms Cleanup

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12538.
-
Resolution: Won't Do

> Tracking Code - Forms Cleanup
> -
>
> Key: OFBIZ-12538
> URL: https://issues.apache.org/jira/browse/OFBIZ-12538
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing/marketing
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: cleanup, consistency, ux
>
> Cleanup of file TrackingCodeForms.xml:
>  * remove commented out and blank lines
>  * apply generic labels over component specifics on fields, where possible 
> and available
>  * apply common display types on fields, where possible
> to get cleaner and more consistent code, to enhance user and contributor 
> experience
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12543) Use CommonProduct in forms having LookupProduct function

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12543.
-
Resolution: Won't Do

> Use CommonProduct in forms having LookupProduct function
> 
>
> Key: OFBIZ-12543
> URL: https://issues.apache.org/jira/browse/OFBIZ-12543
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: consistency, usability, user-experience, ux
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12553) Quote WorkEffort - move screens and form

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12553.
-
Resolution: Won't Do

> Quote WorkEffort - move screens and form
> 
>
> Key: OFBIZ-12553
> URL: https://issues.apache.org/jira/browse/OFBIZ-12553
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: cleanup, consistency
>
> Currently, the screen and associated form widgets to create, edit and view 
> work efforts relating to a quote are having their own screen.xml and form.xml.
> While the other screen and form widgets for the other quote objects (for 
> items, notes, roles, terms, etc. ) are all in rest. QuoteScreens.xml and 
> QuoteForms.xml.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11431) InvoiceItem: uomID is wrongly defined

2024-06-06 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11431.
-
  Assignee: Michael Brohl
Resolution: Won't Do

> InvoiceItem: uomID is wrongly defined
> -
>
> Key: OFBIZ-11431
> URL: https://issues.apache.org/jira/browse/OFBIZ-11431
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: datamodel
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Critical
>  Labels: refactoring
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the InvoiceItem entity has the field uomId, per:
> {code:java}
>   
> {code}
> per the demo data this field is used to capture the currency of the invoice 
> item. This is, however, wrong. The currency for invoice items is set in the 
> invoice entity record (with field currencyUomId. 
> The uomId in the invoice item is related to the quantity set, and must be 
> correctly named: 'quantityUomId.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-13114) Afterlogin events are called during logout

2024-06-04 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-13114:
-

Assignee: Michael Brohl  (was: Chenghu Shan)

> Afterlogin events are called during logout
> --
>
> Key: OFBIZ-13114
> URL: https://issues.apache.org/jira/browse/OFBIZ-13114
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/webapp
>Affects Versions: 22.01
>Reporter: Chenghu Shan
>Assignee: Michael Brohl
>Priority: Minor
>
> In OFBIZ-12630 code was added that would cause afterlogin events would be 
> called when logging out. Additionally this can cause NullPointerExceptions 
> because during the logout the delegator is removed from the request call.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13110) PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId

2024-05-28 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-13110.
-
Resolution: Won't Do

> PartyFinancialHistory shows parentTypeId of invoice, not invoiceTypeId
> --
>
> Key: OFBIZ-13110
> URL: https://issues.apache.org/jira/browse/OFBIZ-13110
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the PartyFinancialHistory shows the description of the parentTypeId 
> of the invoices shown in the overviews. This must be description of the 
> invoiceTypeId.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13048) createPlugin - improve templates

2024-05-28 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-13048.
-
Resolution: Won't Do

> createPlugin - improve templates
> 
>
> Key: OFBIZ-13048
> URL: https://issues.apache.org/jira/browse/OFBIZ-13048
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Pierre Smits
>Priority: Major
>  Labels: development
>
> With the parameterization of the menu location, improvements to the 
> createPlugin templates are warranted.
> Replacing minilang folder with script folder, to ensure developers have a 
> place to have their non-compiled script files (groovy and others).
> Removing non English labels, as in coding English is the internationally used 
> language (and more particarly within the ASF communities). 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-13100) LInk to supplier in Accounting Main does not show PartyFinancialHistory

2024-05-28 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-13100.
-
Resolution: Won't Do

> LInk to supplier in Accounting Main does not show PartyFinancialHistory
> ---
>
> Key: OFBIZ-13100
> URL: https://issues.apache.org/jira/browse/OFBIZ-13100
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pierre Smits
>Priority: Major
>
> When accessing the link to the PartyFinancialHistory screen of the supplier 
> in 
> [https://demo-trunk.ofbiz.apache.org/accounting/control/main|https://demo-trunk.ofbiz.apache.org/accounting/control/main,]
>  the resulting PartyFinancialHistory in partymgr shows no data.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-28 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850030#comment-17850030
 ] 

Michael Brohl edited comment on OFBIZ-13101 at 5/28/24 1:11 PM:


[~jleroux] instead of removing those actions, they should properly behandled in 
the UI to only be shown when the user has the right permission.

Removing them completely is a loss of functionality for users who have the 
permission.

In any case, this should be discussed first because it is existing 
functionality which is removed there.


was (Author: mbrohl):
[~jleroux] instead of removing those actions, they should properly behandled in 
the UI to only be shown when the user has the right permission.

Removing them completely is a loss of functionality for users who have the 
permission.

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-28 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reopened OFBIZ-13101:
---

[~jleroux] instead of removing those actions, they should properly behandled in 
the UI to only be shown when the user has the right permission.

Removing them completely is a loss of functionality for users who have the 
permission.

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (OFBIZ-13101) Duplicate action trigger in Manufacturing

2024-05-26 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reopened OFBIZ-13101:
---

[~jleroux] I think this needs discussion before we do those changes.

Having action buttons in context within the UI as well as a menu is a commonly 
used pattern. Additionally, screens are defined to be reused and can be used 
without a UI with menus.

I propose to revert the change and discuss this pattern first.

> Duplicate action trigger in Manufacturing
> -
>
> Key: OFBIZ-13101
> URL: https://issues.apache.org/jira/browse/OFBIZ-13101
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> On the 'FndProductionRun' an action trigger to create something is shown.
> This links to CreateProductionRun. This action trigger is already available 
> via the MainActionMenu.
> Removing this duplicate also improves the experience for users with only VIEW 
> permissions, like auditor in the demo site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12765) Improvement to createPartyRelationship service

2024-05-23 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849113#comment-17849113
 ] 

Michael Brohl commented on OFBIZ-12765:
---

[~thahn] sorry, I meant to address this to [~cshan] 

> Improvement to createPartyRelationship service 
> ---
>
> Key: OFBIZ-12765
> URL: https://issues.apache.org/jira/browse/OFBIZ-12765
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Chenghu Shan
>Assignee: Michael Brohl
>Priority: Minor
>
> Currently, createPartyRelationship service does not allow the creation of a 
> new PartyRelationship of the same parties until the thruDate has passed. This 
> also disallows the creation new PartyRelationships of the same parties beyond 
> that thruDate.
> This improvement checks for time interval conflicts and allows the creation 
> of a different PartyRelationship of the same parties before the thruDate has 
> passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12765) Improvement to createPartyRelationship service

2024-05-23 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849112#comment-17849112
 ] 

Michael Brohl commented on OFBIZ-12765:
---

[~thahn] can you please resolve the PR conflicts and provide an new PR, thanks!

> Improvement to createPartyRelationship service 
> ---
>
> Key: OFBIZ-12765
> URL: https://issues.apache.org/jira/browse/OFBIZ-12765
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Reporter: Chenghu Shan
>Assignee: Michael Brohl
>Priority: Minor
>
> Currently, createPartyRelationship service does not allow the creation of a 
> new PartyRelationship of the same parties until the thruDate has passed. This 
> also disallows the creation new PartyRelationships of the same parties beyond 
> that thruDate.
> This improvement checks for time interval conflicts and allows the creation 
> of a different PartyRelationship of the same parties before the thruDate has 
> passed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12815) EntityUtil getProperty Methods dont use entity

2024-05-23 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849110#comment-17849110
 ] 

Michael Brohl commented on OFBIZ-12815:
---

[~thahn] please check the comments in the pull requests, thanks!

> EntityUtil getProperty Methods dont use entity
> --
>
> Key: OFBIZ-12815
> URL: https://issues.apache.org/jira/browse/OFBIZ-12815
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/entity
>Affects Versions: 18.12.07
>Reporter: Tobias Hahn
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The getProperty methods in EntityUtilProperties don't use entity at all. All 
> of the getProperty methods simply lead to UtilProperties and therefore no 
> configure during runtime is possible. New methods have been written so the 
> entity usage is now functional.
> Due to a wrong commit description/title the PR #634 were closed. i opened a 
> new PR #635. 
> Also i will adjust the code with an upcoming commit, thanks to Gil who 
> commented on PR #634.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12829) Improvements for ContentWorker methods and view-entities

2024-05-23 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12829.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks [~cshan] !

> Improvements for ContentWorker methods and view-entities
> 
>
> Key: OFBIZ-12829
> URL: https://issues.apache.org/jira/browse/OFBIZ-12829
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Upcoming Branch
>Reporter: Chenghu Shan
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Adds additional methods to ContentWorker:
>  * New method findAlternateLocalContents to find all alternate locale 
> contents instead of just one specific.
>  * Overloaded methods of findAlternateLocalContents and 
> findAlternateLocalContent to enable/disable cache use.
>  * These methods are no longer case sensitive when comparing localeStrings
> Changes to view-entites ProductContentAndInfo and 
> ProductCategoryContentAndInfo:
>  * Both now use an outer join instead of inner join between DataResource and 
> Content, because there may be a Content object without a DataResource for its 
> locale but with alternate locale content objects associated to it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12843) Refactoring WebSiteProperties.java

2024-05-23 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12843.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

Thanks [~cshan] !

> Refactoring WebSiteProperties.java
> --
>
> Key: OFBIZ-12843
> URL: https://issues.apache.org/jira/browse/OFBIZ-12843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webapp
>Reporter: Chenghu Shan
>Assignee: Michael Brohl
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> Class WebSiteProperties.java contains some duplicate code and should be 
> refactored.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OFBIZ-12843) Refactoring WebSiteProperties.java

2024-05-23 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-12843:
-

Assignee: Michael Brohl  (was: Chenghu Shan)

> Refactoring WebSiteProperties.java
> --
>
> Key: OFBIZ-12843
> URL: https://issues.apache.org/jira/browse/OFBIZ-12843
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webapp
>Reporter: Chenghu Shan
>Assignee: Michael Brohl
>Priority: Trivial
>
> Class WebSiteProperties.java contains some duplicate code and should be 
> refactored.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12886) Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder

2024-05-23 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12886.
-
Fix Version/s: Upcoming Branch
   Resolution: Fixed

Thanks [~elolaki] !

> Apply orderItemAttributes when adding to Shoppingcart from addToCartFromOrder
> -
>
> Key: OFBIZ-12886
> URL: https://issues.apache.org/jira/browse/OFBIZ-12886
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Upcoming Branch
>Reporter: Elaheh Lolaki
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When adding products with an attribute, these are not transferred via the 
> addToCartFromOrder function



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-25 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840677#comment-17840677
 ] 

Michael Brohl commented on OFBIZ-13035:
---

Hi [~jleroux] what does that mean for the state of this in trunk, quality wise?

Do we now have incomplete/inconsistent functionality or is it complete?

> Fix cross-app menu location issues
> --
>
> Key: OFBIZ-13035
> URL: https://issues.apache.org/jira/browse/OFBIZ-13035
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> address cross application menu-location issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-24 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840348#comment-17840348
 ] 

Michael Brohl commented on OFBIZ-13049:
---

If there are solutions present which are problematic, we should not go this way 
further with new implementations.

We should stop merging those solutions until those issues are discussed and we 
agreed to go this way.

 

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-21 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839376#comment-17839376
 ] 

Michael Brohl commented on OFBIZ-13049:
---

It would be better to first describe what should be done and how in a single 
issue (this one), get approval from the community that it should be done and 
deliver a first implementation for review. If this is sucessful, more subtasks 
might be reasonable if there is a plan to deliver the solutions.

Creating a lot of tickets without substance or someone who intend to do the 
work just makes Jira confusing.

If this is a feature request without a plan to do the work, this issue is 
sufficient and does not need subtasks until there ist someone who picks up the 
work.

> Configurable Main page
> --
>
> Key: OFBIZ-13049
> URL: https://issues.apache.org/jira/browse/OFBIZ-13049
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Reporter: Pierre Smits
>Priority: Major
>
> Currently the OFBiz product has configurable Main pages in applications 
> Accounting, Order, SFA, and plugin MyPortal. Unfortunately, none in the 
> community felt the urge to implement the concept further in other 
> applications.
> Having a configurable Main page of an application improves both the appeal of 
> OFBiz to (potential) adopters and their users, and to developers.
> With a configurable Main page, developers have less screens to consider when 
> doing customisation, while at the same time trying to stay in sync with 
> changes from the project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-10507) LoginServices.userLogin: Respond "fail" instead of "error" to avoid the (automatic service engine) logging of a stack trace on missing/invalid credentials

2024-04-04 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-10507.
-
Fix Version/s: Upcoming Branch
   Resolution: Implemented

> LoginServices.userLogin: Respond "fail" instead of "error" to avoid the 
> (automatic service engine) logging of a stack trace on missing/invalid 
> credentials
> --
>
> Key: OFBIZ-10507
> URL: https://issues.apache.org/jira/browse/OFBIZ-10507
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-10507_org.apache.ofbiz.common.login.LoginServices.patch
>
>
> There are a lot of login-related entries in the logfile, that stem from user 
> related errors (like no or wrong password, user not found and so on). To 
> reduce this, the patch introduces a distinction between ERROR messages and 
> FAIL messages in the Service-Result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-10507) LoginServices.userLogin: Respond "fail" instead of "error" to avoid the (automatic service engine) logging of a stack trace on missing/invalid credentials

2024-04-04 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833844#comment-17833844
 ] 

Michael Brohl commented on OFBIZ-10507:
---

Thanks for the heads up Jacques, I've merged the PR.

> LoginServices.userLogin: Respond "fail" instead of "error" to avoid the 
> (automatic service engine) logging of a stack trace on missing/invalid 
> credentials
> --
>
> Key: OFBIZ-10507
> URL: https://issues.apache.org/jira/browse/OFBIZ-10507
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: 
> OFBIZ-10507_org.apache.ofbiz.common.login.LoginServices.patch
>
>
> There are a lot of login-related entries in the logfile, that stem from user 
> related errors (like no or wrong password, user not found and so on). To 
> reduce this, the patch introduces a distinction between ERROR messages and 
> FAIL messages in the Service-Result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-10507) LoginServices.userLogin: Respond "fail" instead of "error" to avoid the (automatic service engine) logging of a stack trace on missing/invalid credentials

2024-03-25 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17830435#comment-17830435
 ] 

Michael Brohl commented on OFBIZ-10507:
---

I was waiting for feedback to the provided PR. I will merge it soon.

> LoginServices.userLogin: Respond "fail" instead of "error" to avoid the 
> (automatic service engine) logging of a stack trace on missing/invalid 
> credentials
> --
>
> Key: OFBIZ-10507
> URL: https://issues.apache.org/jira/browse/OFBIZ-10507
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: 
> OFBIZ-10507_org.apache.ofbiz.common.login.LoginServices.patch
>
>
> There are a lot of login-related entries in the logfile, that stem from user 
> related errors (like no or wrong password, user not found and so on). To 
> reduce this, the patch introduces a distinction between ERROR messages and 
> FAIL messages in the Service-Result.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12890) Missing package and syntax error in FixedAssetServices.groovy

2024-02-05 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12890.
-
Resolution: Fixed

> Missing package and syntax error in FixedAssetServices.groovy
> -
>
> Key: OFBIZ-12890
> URL: https://issues.apache.org/jira/browse/OFBIZ-12890
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OFBIZ-12890) Missing package and syntax error in FixedAssetServices.groovy

2024-02-05 Thread Michael Brohl (Jira)
Michael Brohl created OFBIZ-12890:
-

 Summary: Missing package and syntax error in 
FixedAssetServices.groovy
 Key: OFBIZ-12890
 URL: https://issues.apache.org/jira/browse/OFBIZ-12890
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Upcoming Branch
Reporter: Michael Brohl
Assignee: Michael Brohl
 Fix For: Upcoming Branch






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath

2024-02-05 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12888.
-
Fix Version/s: Upcoming Branch
   Resolution: Fixed

> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the 
> codenarc checks in the pre-push hook:
>  
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set 
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>  
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as 
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to 
> duplicated classes.
> enabled = false
> }
> {code}
>  
> And change the git hooks to
>  
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>  
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push) 
> everything seems to work fine, tests are working and the codenarc Main and 
> Test reports are build.
> I provide a PR for it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OFBIZ-12888) Gradle eclipse target produces duplicate build path entries in .classpath

2024-02-05 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814288#comment-17814288
 ] 

Michael Brohl edited comment on OFBIZ-12888 at 2/5/24 9:10 AM:
---

[~jleroux] I appreciate you help but would also appreciate if you could take 
your time when doing changes/reverts etc. on the work of others.

You could simply let me commit my work which was based upon the latest trunk 
changes. Now it was incomplete/has errors (see my last commit) and I was not 
able to merge my PR due to conflicts based on your changes. Also the history 
now looks poor.


was (Author: mbrohl):
[~jleroux] I appreciate you help but would also appreciate if you could take 
your time when doing changes/reverts etc. on the work of others.

You could simply let me commit my work which was based upon the latest trunk 
changes. Now it was incomplete/has errors (see my last commit) and I was not 
able to merge my PR due to conflicts based on your changes.

> Gradle eclipse target produces duplicate build path entries in .classpath
> -
>
> Key: OFBIZ-12888
> URL: https://issues.apache.org/jira/browse/OFBIZ-12888
> Project: OFBiz
>  Issue Type: Bug
>  Components: Gradle
>Affects Versions: Upcoming Branch
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: Upcoming Branch
>
>
> I'm currently working on a solution for this.
> Maybe someone can explain why we use the GroovyScripts source set for the 
> codenarc checks in the pre-push hook:
>  
> {code:java}
> gitHooks {
>hooks = ['pre-push': 'checkstyleMain codenarcGroovyScripts']
> }
> {code}
> That target seems to be automatically defined through the source set 
> definition for groovyScripts.
> If I remove that source set and the following task configuration:
>  
> {code:java}
> tasks.named('compileGroovyScriptsGroovy') {
> // We don't want to build groovyScripts as they should be considered as 
> standalone elements executed in
> // isolation by ofbiz. Building them will result in numerous error due to 
> duplicated classes.
> enabled = false
> }
> {code}
>  
> And change the git hooks to
>  
> {code:java}
> }
> gitHooks {
> hooks = ['pre-push': 'checkstyleMain codenarcMain codenarcTest']
> }
> {code}
>  
> (which is accoring to the pre-push hook definition in .git/hooks/pre-push) 
> everything seems to work fine, tests are working and the codenarc Main and 
> Test reports are build.
> I provide a PR for it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


  1   2   3   4   5   6   7   8   9   10   >