[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-24 Thread via cfe-commits

github-actions[bot] wrote:



@dmcardle Congratulations on having your first Pull Request (PR) merged into 
the LLVM Project!

Your changes will be combined with recent changes from other authors, then 
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with 
a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail 
[here](https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your-pr).

If your change does cause a problem, it may be reverted, or you can revert it 
yourself.
This is a normal part of [LLVM 
development](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy).
 You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are 
working as expected, well done!


https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-24 Thread Aaron Ballman via cfe-commits

https://github.com/AaronBallman closed 
https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] c1bde0a - [clang][ThreadSafety] Check trylock function success and return types (#95290)

2024-06-24 Thread via cfe-commits
NCTION(1, 
muDoubleWrapper.muWrapper->mu);
 int etf_function_3() EXCLUSIVE_TRYLOCK_FUNCTION(1, muWrapper.getMu());
@@ -768,14 +844,13 @@ int etf_functetfn_8() EXCLUSIVE_TRYLOCK_FUNCTION(1, 
muPointer);
 int etf_function_9() EXCLUSIVE_TRYLOCK_FUNCTION(true); // \
   // expected-warning {{'exclusive_trylock_function' attribute without 
capability arguments can only be applied to non-static methods of a class}}
 
-
 // illegal attribute arguments
 int etf_function_bad_1() EXCLUSIVE_TRYLOCK_FUNCTION(mu1); // \
-  // expected-error {{'exclusive_trylock_function' attribute requires 
parameter 1 to be int or bool}}
+  // expected-error {{'exclusive_trylock_function' attribute requires 
parameter 1 to be nullptr or a bool, int, or enum literal}}
 int etf_function_bad_2() EXCLUSIVE_TRYLOCK_FUNCTION("mu"); // \
-  // expected-error {{'exclusive_trylock_function' attribute requires 
parameter 1 to be int or bool}}
+  // expected-error {{'exclusive_trylock_function' attribute requires 
parameter 1 to be nullptr or a bool, int, or enum literal}}
 int etf_function_bad_3() EXCLUSIVE_TRYLOCK_FUNCTION(muDoublePointer); // \
-  // expected-error {{'exclusive_trylock_function' attribute requires 
parameter 1 to be int or bool}}
+  // expected-error {{'exclusive_trylock_function' attribute requires 
parameter 1 to be nullptr or a bool, int, or enum literal}}
 
 int etf_function_bad_4() EXCLUSIVE_TRYLOCK_FUNCTION(1, "mu"); // \
   // expected-warning {{ignoring 'exclusive_trylock_function' attribute 
because its argument is invalid}}
@@ -799,9 +874,9 @@ int etf_function_bad_6() EXCLUSIVE_TRYLOCK_FUNCTION(1, 
umu); // \
 void stf_function() __attribute__((shared_trylock_function));  // \
   // expected-error {{'shared_trylock_function' attribute takes at least 1 
argument}}
 
-void stf_function_args() SHARED_TRYLOCK_FUNCTION(1, mu2);
+bool stf_function_args() SHARED_TRYLOCK_FUNCTION(1, mu2);
 
-void stf_function_arg() SHARED_TRYLOCK_FUNCTION(1); // \
+bool stf_function_arg() SHARED_TRYLOCK_FUNCTION(1); // \
   // expected-warning {{'shared_trylock_function' attribute without capability 
arguments can only be applied to non-static methods of a class}}
 
 int stf_testfn(int y) SHARED_TRYLOCK_FUNCTION(1); // \
@@ -824,7 +899,7 @@ class StfFoo {
  private:
   int test_field SHARED_TRYLOCK_FUNCTION(1); // \
 // expected-warning {{'shared_trylock_function' attribute only applies to 
functions}}
-  void test_method() SHARED_TRYLOCK_FUNCTION(1); // \
+  bool test_method() SHARED_TRYLOCK_FUNCTION(1); // \
 // expected-warning {{'shared_trylock_function' attribute without 
capability arguments refers to 'this', but 'StfFoo' isn't annotated with 
'capability' or 'scoped_lockable' attribute}}
 };
 
@@ -849,11 +924,11 @@ int stf_function_9() SHARED_TRYLOCK_FUNCTION(true); // \
 
 // illegal attribute arguments
 int stf_function_bad_1() SHARED_TRYLOCK_FUNCTION(mu1); // \
-  // expected-error {{'shared_trylock_function' attribute requires parameter 1 
to be int or bool}}
+  // expected-error {{'shared_trylock_function' attribute requires parameter 1 
to be nullptr or a bool, int, or enum literal}}
 int stf_function_bad_2() SHARED_TRYLOCK_FUNCTION("mu"); // \
-  // expected-error {{'shared_trylock_function' attribute requires parameter 1 
to be int or bool}}
+  // expected-error {{'shared_trylock_function' attribute requires parameter 1 
to be nullptr or a bool, int, or enum literal}}
 int stf_function_bad_3() SHARED_TRYLOCK_FUNCTION(muDoublePointer); // \
-  // expected-error {{'shared_trylock_function' attribute requires parameter 1 
to be int or bool}}
+  // expected-error {{'shared_trylock_function' attribute requires parameter 1 
to be nullptr or a bool, int, or enum literal}}
 
 int stf_function_bad_4() SHARED_TRYLOCK_FUNCTION(1, "mu"); // \
   // expected-warning {{ignoring 'shared_trylock_function' attribute because 
its argument is invalid}}

diff  --git a/clang/unittests/AST/ASTImporterTest.cpp 
b/clang/unittests/AST/ASTImporterTest.cpp
index 92f9bae6cb064..4c33546de6f92 100644
--- a/clang/unittests/AST/ASTImporterTest.cpp
+++ b/clang/unittests/AST/ASTImporterTest.cpp
@@ -7851,7 +7851,7 @@ TEST_P(ImportAttributes, ImportAcquireCapability) {
 TEST_P(ImportAttributes, ImportTryAcquireCapability) {
   TryAcquireCapabilityAttr *FromAttr, *ToAttr;
   importAttr(
-  "void test(int A1, int A2) __attribute__((try_acquire_capability(1, A1, "
+  "bool test(int A1, int A2) __attribute__((try_acquire_capability(1, A1, "
   "A2)));",
   FromAttr, ToAttr);
   checkImported(FromAttr->getSuccessValue(), ToAttr->getSuccessValue());
@@ -7948,7 +7948,7 @@ TEST_P(ImportAttributes, ImportAssertSharedLock) {
 TEST_P(ImportAttributes, ImportExclusiveTrylockFunction) {
   ExclusiveTrylockFunctionAttr *FromAttr, *ToAttr;
   importAttr(
-  "void test(int A1, int A2) __attribute__((exclusive_trylock_function(1, "
+  "bool test(int A1, int A2) __attribute__((exclusive_trylock_function(1, "
   "A1, A2)));",
   FromAttr, ToAttr);
   checkImported(FromAttr->getSuccessValue(), ToAttr->getSuccessValue());
@@ -7958,7 +7958,7 @@ TEST_P(ImportAttributes, ImportExclusiveTrylockFunction) {
 TEST_P(ImportAttributes, ImportSharedTrylockFunction) {
   SharedTrylockFunctionAttr *FromAttr, *ToAttr;
   importAttr(
-  "void test(int A1, int A2) __attribute__((shared_trylock_function(1, A1, 
"
+  "bool test(int A1, int A2) __attribute__((shared_trylock_function(1, A1, 
"
   "A2)));",
   FromAttr, ToAttr);
   checkImported(FromAttr->getSuccessValue(), ToAttr->getSuccessValue());



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang][ThreadSafety] Check trylock function success and return types (PR #95290)

2024-06-24 Thread Aaron Ballman via cfe-commits

https://github.com/AaronBallman approved this pull request.

LGTM still

https://github.com/llvm/llvm-project/pull/95290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-24 Thread Aaron Ballman via cfe-commits


@@ -4570,7 +4570,8 @@ ExprResult Sema::BuildAtomicExpr(SourceRange CallRange, 
SourceRange ExprRange,
   }
 
   // Pointer to object of size zero is not allowed.
-  if (Context.getTypeInfoInChars(AtomTy).Width.isZero()) {
+  if (!AtomTy->isIncompleteType() &&

AaronBallman wrote:

If you call `RequireCompleteType()` before this `if` instead of checking for an 
incomplete type, do you get better diagnostic behavior?

https://github.com/llvm/llvm-project/pull/96374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-24 Thread Aaron Ballman via cfe-commits

https://github.com/AaronBallman commented:

Thank you for the fix! The changes should also come with a release note in 
`clang/docs/ReleaseNotes.rst` so users know about the improvement.

https://github.com/llvm/llvm-project/pull/96374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-24 Thread Aaron Ballman via cfe-commits

https://github.com/AaronBallman edited 
https://github.com/llvm/llvm-project/pull/96374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-24 Thread via cfe-commits


@@ -2626,14 +2629,20 @@ void CodeGenFunction::EmitAsmStmt(const AsmStmt ) {
   SmallVector OutputConstraintInfos;
   SmallVector InputConstraintInfos;
 
+  const FunctionDecl *FD = dyn_cast_or_null(CurCodeDecl);

Sirraide wrote:

> Where do you get dyn_cast_or_null is deprecated?

Mainly from here (as well as other places in `Casting.h`):
https://github.com/llvm/llvm-project/blob/5cd0ba30f53d11835dbfd05ad4071d397387fb04/llvm/include/llvm/Support/Casting.h#L756-L769

https://github.com/llvm/llvm-project/pull/96363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-24 Thread Matt Arsenault via cfe-commits

https://github.com/arsenm commented:

It's really unfortunate to have to add all this asm handling to clang. Can't it 
rely on backend diagnostic remarks for this? 

https://github.com/llvm/llvm-project/pull/96363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-24 Thread Matt Arsenault via cfe-commits


@@ -2626,14 +2629,20 @@ void CodeGenFunction::EmitAsmStmt(const AsmStmt ) {
   SmallVector OutputConstraintInfos;
   SmallVector InputConstraintInfos;
 
+  const FunctionDecl *FD = dyn_cast_or_null(CurCodeDecl);

arsenm wrote:

Where do you get dyn_cast_or_null is deprecated? I only remember a rejected RFC 
to start using dyn_cast_if_present

https://github.com/llvm/llvm-project/pull/96363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[Lldb-commits] [lldb] Reapply [lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (PR #92328)

2024-06-24 Thread Pavel Labath via lldb-commits

labath wrote:

Hi there. Nice to see interest in this patch. Zequan has been OOO for the past 
couple of weeks, so I've sort of taken this up in the mean time.

The problem with the simplified template names is actually already fixed (by 
#95905), but in the mean time, I've discovered a very similar problem with type 
units (basically, just take the test case from #95905, but build it with 
-fdebug-types-section instead). While this could (and should) be fixed in 
similar way, this led me to believe that the overall approach in this patch was 
too fragile. When completing a type, it basically does something like:
- look up the (declaration) die for the type being completed (using the 
`ForwardDeclCompilerTypeToDIE` map)
- look up the definition die (using the dwarf index)
- look up the type for the definition die (using the UniqueDWARFASTTypeMap)

The last step, besides being completely unnecessary (we already know the type 
we're supposed to complete), is also a big liability, because here we are 
implicitly relying on the the map to return the same type that we started with. 
If it does not then we will end up creating a new type instead of completing 
the existing one, and things will quickly go sideways.

The meeting that David alluded to is tomorrow, and I hope we're going to try to 
figure out who's going to do what and in what order. In the mean time, I've 
added you as a reviewer to one of my pending patches.

https://github.com/llvm/llvm-project/pull/92328
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Implement TilingInterface for winograd operators (PR #96184)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -2638,4 +2638,41 @@ def WinogradConv2DOp : Op {
+  let description = [{
+Decompose winograd operators. It will convert filter, input and output
+transform operators into a combination of scf, tensor, and linalg

ftynse wrote:

Nit: operations

https://github.com/llvm/llvm-project/pull/96184
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Implement TilingInterface for winograd operators (PR #96184)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -2760,6 +2760,89 @@ LogicalResult WinogradFilterTransformOp::verify() {
   return success();
 }
 
+SmallVector
+WinogradFilterTransformOp::getIterationDomain(OpBuilder ) {
+  Location loc = getLoc();
+  Value zero = builder.create(loc, 0);
+  Value one = builder.create(loc, 1);
+  Value output = getOutput();
+  SmallVector loopBounds(6);
+  for (unsigned dim = 0; dim < 6; ++dim) {
+loopBounds[dim].offset = zero;
+loopBounds[dim].size = getDimValue(builder, loc, output, dim);
+loopBounds[dim].stride = one;
+  }
+  return loopBounds;
+}
+
+SmallVector
+WinogradFilterTransformOp::getLoopIteratorTypes() {
+  SmallVector iteratorTypes(6,
+ 
utils::IteratorType::parallel);
+  return iteratorTypes;
+}
+
+Value getValueFromOpFoldResult(OpFoldResult opFoldResult, OpBuilder ,
+   Location loc) {
+  if (auto val = opFoldResult.dyn_cast()) {
+return val;
+  } else if (auto attr = opFoldResult.dyn_cast()) {
+auto intAttr = cast(attr);
+return builder.create(loc, intAttr);
+  }
+  // This should never happen if OpFoldResult is correctly formed.

ftynse wrote:

Then this should be an assertion.

https://github.com/llvm/llvm-project/pull/96184
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Implement TilingInterface for winograd operators (PR #96184)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -2760,6 +2760,89 @@ LogicalResult WinogradFilterTransformOp::verify() {
   return success();
 }
 
+SmallVector
+WinogradFilterTransformOp::getIterationDomain(OpBuilder ) {
+  Location loc = getLoc();
+  Value zero = builder.create(loc, 0);
+  Value one = builder.create(loc, 1);

ftynse wrote:

IIRC, `Range` contains list of `OpFoldResult`, meaning we can put attributes 
there and not materialize operations for these constants.

https://github.com/llvm/llvm-project/pull/96184
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Implement TilingInterface for winograd operators (PR #96184)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -2760,6 +2760,89 @@ LogicalResult WinogradFilterTransformOp::verify() {
   return success();
 }
 
+SmallVector
+WinogradFilterTransformOp::getIterationDomain(OpBuilder ) {
+  Location loc = getLoc();
+  Value zero = builder.create(loc, 0);
+  Value one = builder.create(loc, 1);
+  Value output = getOutput();
+  SmallVector loopBounds(6);
+  for (unsigned dim = 0; dim < 6; ++dim) {
+loopBounds[dim].offset = zero;
+loopBounds[dim].size = getDimValue(builder, loc, output, dim);
+loopBounds[dim].stride = one;
+  }
+  return loopBounds;
+}
+
+SmallVector
+WinogradFilterTransformOp::getLoopIteratorTypes() {
+  SmallVector iteratorTypes(6,
+ 
utils::IteratorType::parallel);
+  return iteratorTypes;
+}
+
+Value getValueFromOpFoldResult(OpFoldResult opFoldResult, OpBuilder ,
+   Location loc) {
+  if (auto val = opFoldResult.dyn_cast()) {
+return val;
+  } else if (auto attr = opFoldResult.dyn_cast()) {
+auto intAttr = cast(attr);
+return builder.create(loc, intAttr);
+  }

ftynse wrote:

I suspect this might already exist somewhere in the arith dialect.

https://github.com/llvm/llvm-project/pull/96184
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Implement TilingInterface for winograd operators (PR #96184)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits

https://github.com/ftynse commented:

I think @MaheshRavishankar should take a look at the interface implementation 
details.

https://github.com/llvm/llvm-project/pull/96184
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Implement TilingInterface for winograd operators (PR #96184)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits

https://github.com/ftynse edited https://github.com/llvm/llvm-project/pull/96184
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-06-24 Thread Aaron Ballman via cfe-commits

AaronBallman wrote:

> Given that this is for a clang extension and not a conformance issue, I'm 
> inclined to revert.
> 
> It might make sense to do that, yeah. Either way, we should investigate 
> what’s going on here. @AaronBallman wdyt?

Definitely worth investigating, unsure whether this is sufficiently disruptive 
to warrant a revert as opposed to a fix forward. I don't oppose a revert if 
@nikic would like to see one, but I realize now that we have no wording in our 
revert policy regarding incremental compile time performance regressions (if it 
was a huge regression, I think it falls under correctness, but this is a 
relatively small change in performance and no bots are red as a result either). 
So if we think this warrants a revert, should we consider updating the policy 
to more clearly state when to revert for performance reasons?

https://github.com/llvm/llvm-project/pull/84983
_______
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-06-24 Thread via cfe-commits

Sirraide wrote:

> I was not expecting that. Hmm, I wonder what’s causing this.

I’m probably just stating the obvious here, but seeing as existing code 
obviously does not make use of effects, for compiling it to become slower, that 
means that we’re probably unconditionally executing code somewhere irrespective 
of whether effects are present or not, so what I’m saying is we should probably 
investigate any places where this pr checks for the presence of effects and 
does something based on that and move the checks for whether a function even 
has effects attached to it as far up as possible and try and also optimise that 
check (is the function that checks for that defined in a header? If not, we 
should maybe move the definition there so it can be inlined).

The only other option I can think of is that this adds some more data to 
`FunctionProtoType`s, which means we allocate more etc. but that alone 
shouldn’t have this big of an impact I’m assuming? 

https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -36,6 +189,92 @@ constexpr TransformMapKeyTy F_2_3{2, 3};
 constexpr TransformMapKeyTy F_4_3{4, 3};
 constexpr TransformMapKeyTy F_2_5{2, 5};
 
+struct TransformMatrix {
+  TransformMatrix(const float *table, int64_t rows, int64_t cols,
+  int64_t scalarFactor = 1)
+  : table(table), rows(rows), cols(cols), scalarFactor(scalarFactor) {}
+
+  const float *table;
+  int64_t rows;
+  int64_t cols;
+  int64_t scalarFactor;
+};
+
+Value create2DTransformMatrix(RewriterBase , Location loc,
+  TransformMatrix transform, Type type) {
+  ArrayRef const_vec(transform.table, transform.rows * transform.cols);

ftynse wrote:

Nit: camelBack
```suggestion
  ArrayRef constVec(transform.table, transform.rows * transform.cols);
```

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -100,6 +594,161 @@ Value matrixMultiply(RewriterBase , Location loc,
   return expandOutput;
 }
 
+// This function transforms the output. The data layout of the output is HWNF.
+// The transformation matrix is 2-dimension. We need to extract H x W from
+// HWNF first. We need to generate 2 levels of loops to iterate on N and F.
+// After the transformation, we get
+//
+// scf.for %n = lo_n to hi_n step 1
+//   scf.for %f = lo_f to hi_f step 1
+// %extracted = extract input from result
+// %ret = linalg.matmul AT, %extracted
+// %ret = linalg.matmul %ret, A
+// %inserted = insert %ret into ret
+//
+Value outputTransform(RewriterBase , Location loc, Value value,
+  Value output, int64_t m, int64_t r,
+  bool leftTransform = true, bool rightTransform = true) {
+  // Map from (m, r) to AT transform matrix.
+  static const llvm::SmallDenseMap
+  ATMatrices = {
+  {F_2_3, TransformMatrix(AT_2x2_3x3, 2, 4)},
+  {F_4_3, TransformMatrix(AT_4x4_3x3, 4, 6, 32)},
+  {F_2_5, TransformMatrix(AT_2x2_5x5, 2, 6, 16)},
+  };
+
+  // Map from (m, r) to A transform matrix.
+  static const llvm::SmallDenseMap
+  AMatrices = {
+  {F_2_3, TransformMatrix(A_2x2_3x3, 4, 2)},
+  {F_4_3, TransformMatrix(A_4x4_3x3, 6, 4, 32)},
+  {F_2_5, TransformMatrix(A_2x2_5x5, 6, 2, 16)},
+  };
+
+  auto valueType = cast(value.getType());
+  Type elementType = valueType.getElementType();
+  auto valueShape = valueType.getShape(); // TileH, TileW, H, W, N, F
+  int64_t valueH = valueShape[2];
+  int64_t valueW = valueShape[3];
+  int64_t valueN = valueShape[4];
+  int64_t valueF = valueShape[5];
+  int64_t alphaH = leftTransform ? m + r - 1 : 1;
+  int64_t alphaW = rightTransform ? m + r - 1 : 1;
+
+  if (valueH != alphaH && valueH != 1)
+return Value();
+  if (valueW != alphaW && valueW != 1)
+return Value();
+
+  auto zeroIdx = rewriter.create(loc, 0);
+  auto nUpperBound = rewriter.create(loc, valueN);
+  auto fUpperBound = rewriter.create(loc, valueF);
+  auto oneStep = rewriter.create(loc, 1);
+
+  auto outerForOp =
+  rewriter.create(loc, zeroIdx, nUpperBound, oneStep, output);
+  Block *outerForBody = outerForOp.getBody();
+  rewriter.setInsertionPointToStart(outerForBody);
+  Value NIter = outerForBody->getArgument(0);
+
+  auto innerForOp = rewriter.create(
+  loc, zeroIdx, fUpperBound, oneStep, outerForOp.getRegionIterArgs()[0]);
+  Block *innerForBody = innerForOp.getBody();
+  rewriter.setInsertionPointToStart(innerForBody);
+  Value FIter = innerForBody->getArgument(0);

ftynse wrote:

FYI, there's a `mlir::scf::buildLoopNest` somewhere that may space you the 
boilerplate.

https://github.com/llvm/llvm-project/pull/96183
_______
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -48,6 +287,261 @@ Value collapse2DData(RewriterBase , Location loc, 
Value data) {
   reassociation);
 }
 
+// This function transforms the filter. The data layout of the filter is FHWC.
+// The transformation matrix is 2-dimension. We need to extract H x W from
+// FHWC first. We need to generate 2 levels of loops to iterate on F and C.
+// After the transformation, we get
+//
+// scf.for %f = lo_f to hi_f step 1
+//   scf.for %c = lo_c to hi_c step 1
+// %extracted = extract filter from filter
+// %ret = linalg.matmul G, %extracted
+// %ret = linalg.matmul %ret, GT
+// %inserted = insert %ret into filter
+//

ftynse wrote:

```suggestion
/// This function transforms the filter. The data layout of the filter is FHWC.
/// The transformation matrix is 2-dimension. We need to extract H x W from
/// FHWC first. We need to generate 2 levels of loops to iterate on F and C.
/// After the transformation, we get
///
/// scf.for %f = lo_f to hi_f step 1
///   scf.for %c = lo_c to hi_c step 1
/// %extracted = extract filter from filter
/// %ret = linalg.matmul G, %extracted
/// %ret = linalg.matmul %ret, GT
/// %inserted = insert %ret into filter
///
```

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -289,6 +938,123 @@ FailureOr winogradConv2DHelper(RewriterBase 
,
   return transformedOutput.getDefiningOp();
 }
 
+FailureOr
+decomposeWinogradFilterTransformHelper(RewriterBase ,
+   linalg::WinogradFilterTransformOp op) {
+  Location loc = op.getLoc();
+  Value filter = op.getFilter();
+  auto filterType = cast(filter.getType());
+  auto filterShape = filterType.getShape();
+  int64_t filterH = filterShape[1];
+  int64_t filterW = filterShape[2];
+
+  // For F(m x 1, r x 1), we only need to do left side transform.
+  bool leftTransform = filterH != 1;
+  // For F(1 x m, 1 x r), we only need to do right side transform.
+  bool rightTransform = filterW != 1;
+  Value transformedFilter =
+  filterTransform(rewriter, loc, filter, op.getOutput(), op.getM(),
+  op.getR(), leftTransform, rightTransform);
+  if (!transformedFilter)
+return failure();
+
+  rewriter.replaceOp(op, transformedFilter);
+
+  return transformedFilter.getDefiningOp();
+}
+
+FailureOr
+decomposeWinogradInputTransformHelper(RewriterBase ,
+  linalg::WinogradInputTransformOp op) {
+  Location loc = op.getLoc();
+  Value input = op.getInput();
+  auto inputType = cast(input.getType());
+  auto inputShape = inputType.getShape();
+  int64_t inputH = inputShape[1];
+  int64_t inputW = inputShape[2];
+
+  // For F(m x 1, r x 1), we only need to do left side transform.
+  bool leftTransform = inputH != 1;
+  // For F(1 x m, 1 x r), we only need to do right side transform.
+  bool rightTransform = inputW != 1;
+  Value transformedInput =
+  inputTransform(rewriter, loc, op.getInput(), op.getOutput(), op.getM(),
+ op.getR(), leftTransform, rightTransform);
+  if (!transformedInput)
+return failure();
+
+  rewriter.replaceOp(op, transformedInput);
+
+  return transformedInput.getDefiningOp();
+}
+
+FailureOr
+decomposeWinogradOutputTransformHelper(RewriterBase ,
+   linalg::WinogradOutputTransformOp op) {
+  Location loc = op.getLoc();
+  Value value = op.getValue();
+  auto valueType = cast(value.getType());
+  auto valueShape = valueType.getShape();
+  int64_t valueH = valueShape[2];
+  int64_t valueW = valueShape[3];
+
+  // For F(m x 1, r x 1), we only need to do left side transform.
+  bool leftTransform = valueH != 1;
+  // For F(1 x m, 1 x r), we only need to do right side transform.
+  bool rightTransform = valueW != 1;
+  Value transformedOutput =
+  outputTransform(rewriter, loc, value, op.getOutput(), op.getM(),
+  op.getR(), leftTransform, rightTransform);
+  if (!transformedOutput)
+return failure();
+
+  rewriter.replaceOp(op, transformedOutput);
+
+  return transformedOutput.getDefiningOp();
+}
+
+class DecomposeWinogradFilterTransform final
+: public OpRewritePattern {
+public:
+  using OpRewritePattern::OpRewritePattern;
+
+  LogicalResult matchAndRewrite(linalg::WinogradFilterTransformOp op,
+PatternRewriter ) const override {
+if (failed(decomposeWinogradFilterTransformHelper(rewriter, op)))
+  return failure();
+
+return success();
+  }
+};
+
+class DecomposeWinogradInputTransform final
+: public OpRewritePattern {
+public:
+  using OpRewritePattern::OpRewritePattern;
+
+  LogicalResult matchAndRewrite(linalg::WinogradInputTransformOp op,
+PatternRewriter ) const override {
+if (failed(decomposeWinogradInputTransformHelper(rewriter, op)))
+  return failure();
+
+return success();

ftynse wrote:

```suggestion
return decomposeWinogradInputTransformHelper(rewriter, op);
```

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -48,6 +287,261 @@ Value collapse2DData(RewriterBase , Location loc, 
Value data) {
   reassociation);
 }
 
+// This function transforms the filter. The data layout of the filter is FHWC.
+// The transformation matrix is 2-dimension. We need to extract H x W from
+// FHWC first. We need to generate 2 levels of loops to iterate on F and C.
+// After the transformation, we get
+//
+// scf.for %f = lo_f to hi_f step 1
+//   scf.for %c = lo_c to hi_c step 1
+// %extracted = extract filter from filter
+// %ret = linalg.matmul G, %extracted
+// %ret = linalg.matmul %ret, GT
+// %inserted = insert %ret into filter
+//
+Value filterTransform(RewriterBase , Location loc, Value filter,
+  Value retValue, int64_t m, int64_t r,
+  bool leftTransform = true, bool rightTransform = true) {
+  // Map from (m, r) to G transform matrix.
+  static const llvm::SmallDenseMap
+  GMatrices = {
+  {F_2_3, TransformMatrix(G_2x2_3x3, 4, 3)},
+  {F_4_3, TransformMatrix(G_4x4_3x3, 6, 3)},
+  {F_2_5, TransformMatrix(G_2x2_5x5, 6, 5)},
+  };
+
+  // Map from (m, r) to GT transform matrix.
+  static const llvm::SmallDenseMap
+  GTMatrices = {
+  {F_2_3, TransformMatrix(GT_2x2_3x3, 3, 4)},
+  {F_4_3, TransformMatrix(GT_4x4_3x3, 3, 6)},
+  {F_2_5, TransformMatrix(GT_2x2_5x5, 5, 6)},
+  };
+
+  auto filterType = cast(filter.getType());
+  Type elementType = filterType.getElementType();
+  auto filterShape = filterType.getShape(); // F, H, W, C
+  int64_t filterF = filterShape[0];
+  int64_t filterH = filterShape[1];
+  int64_t filterW = filterShape[2];
+  int64_t filterC = filterShape[3];
+
+  if (filterH != r && filterH != 1)
+return Value();
+  if (filterW != r && filterW != 1)
+return Value();
+
+  // Return shape is 
+  auto zeroIdx = rewriter.create(loc, 0);
+  auto fUpperBound = rewriter.create(loc, filterF);
+  auto cUpperBound = rewriter.create(loc, filterC);
+  auto oneStep = rewriter.create(loc, 1);
+  auto outerForOp =
+  rewriter.create(loc, zeroIdx, fUpperBound, oneStep, 
retValue);
+  Block *outerForBody = outerForOp.getBody();
+  rewriter.setInsertionPointToStart(outerForBody);
+  Value FIter = outerForBody->getArgument(0);

ftynse wrote:

There must be a function on `scf::ForOp` that returns the induction variable 
and avoids magic constant zero here.

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -48,6 +287,261 @@ Value collapse2DData(RewriterBase , Location loc, 
Value data) {
   reassociation);
 }
 
+// This function transforms the filter. The data layout of the filter is FHWC.
+// The transformation matrix is 2-dimension. We need to extract H x W from
+// FHWC first. We need to generate 2 levels of loops to iterate on F and C.
+// After the transformation, we get
+//
+// scf.for %f = lo_f to hi_f step 1
+//   scf.for %c = lo_c to hi_c step 1
+// %extracted = extract filter from filter
+// %ret = linalg.matmul G, %extracted
+// %ret = linalg.matmul %ret, GT
+// %inserted = insert %ret into filter
+//
+Value filterTransform(RewriterBase , Location loc, Value filter,
+  Value retValue, int64_t m, int64_t r,
+  bool leftTransform = true, bool rightTransform = true) {
+  // Map from (m, r) to G transform matrix.
+  static const llvm::SmallDenseMap
+  GMatrices = {
+  {F_2_3, TransformMatrix(G_2x2_3x3, 4, 3)},
+  {F_4_3, TransformMatrix(G_4x4_3x3, 6, 3)},
+  {F_2_5, TransformMatrix(G_2x2_5x5, 6, 5)},
+  };
+
+  // Map from (m, r) to GT transform matrix.
+  static const llvm::SmallDenseMap
+  GTMatrices = {
+  {F_2_3, TransformMatrix(GT_2x2_3x3, 3, 4)},
+  {F_4_3, TransformMatrix(GT_4x4_3x3, 3, 6)},
+  {F_2_5, TransformMatrix(GT_2x2_5x5, 5, 6)},
+  };
+
+  auto filterType = cast(filter.getType());
+  Type elementType = filterType.getElementType();
+  auto filterShape = filterType.getShape(); // F, H, W, C
+  int64_t filterF = filterShape[0];
+  int64_t filterH = filterShape[1];
+  int64_t filterW = filterShape[2];
+  int64_t filterC = filterShape[3];
+
+  if (filterH != r && filterH != 1)
+return Value();
+  if (filterW != r && filterW != 1)
+return Value();
+
+  // Return shape is 
+  auto zeroIdx = rewriter.create(loc, 0);
+  auto fUpperBound = rewriter.create(loc, filterF);
+  auto cUpperBound = rewriter.create(loc, filterC);
+  auto oneStep = rewriter.create(loc, 1);
+  auto outerForOp =
+  rewriter.create(loc, zeroIdx, fUpperBound, oneStep, 
retValue);
+  Block *outerForBody = outerForOp.getBody();
+  rewriter.setInsertionPointToStart(outerForBody);
+  Value FIter = outerForBody->getArgument(0);
+
+  auto innerForOp = rewriter.create(
+  loc, zeroIdx, cUpperBound, oneStep, outerForOp.getRegionIterArgs()[0]);
+  Block *innerForBody = innerForOp.getBody();
+  rewriter.setInsertionPointToStart(innerForBody);
+  Value CIter = innerForBody->getArgument(0);
+
+  // Extract (H, W) from (F, H, W, C)
+  auto extractFilter = extract2DData(
+  rewriter, loc, filter, FIter, CIter, /*outLoopIdx=*/0,
+  /*inLoopIdx=*/3, /*heightIdx=*/1, /*widthIdx=*/2, /*srcSize=*/4);
+
+  TransformMapKeyTy key = {m, r};
+  int64_t retRows = 1;
+  Value matmulRetValue = extractFilter;
+  if (leftTransform) {
+// Get constant transform matrix G
+auto it = GMatrices.find(key);
+if (it == GMatrices.end())
+  return Value();
+const TransformMatrix  = it->second;
+
+retRows = GMatrix.rows;
+auto matmulType = RankedTensorType::get({retRows, filterW}, elementType);
+auto init = rewriter.create(loc, matmulType.getShape(),
+ elementType);
+
+Value G = create2DTransformMatrix(rewriter, loc, GMatrix, elementType);

ftynse wrote:

I wonder if we rather want to provide these matrices as global memrefs instead 
of creating locally every time. Have you considered that?

https://github.com/llvm/llvm-project/pull/96183
_______
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -323,5 +1089,12 @@ void populateWinogradConv2DPatterns(RewritePatternSet 
, int64_t m,
   patterns.insert(context, m, r);
 }
 
+void populateDecomposeWinogradOpsPatterns(RewritePatternSet ) {
+  MLIRContext *context = patterns.getContext();
+  patterns.insert(context);
+  patterns.insert(context);
+  patterns.insert(context);

ftynse wrote:

```suggestion
  patterns.insert(context);
```

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits
ctor affineMaps = {AffineMap::get(2, 0, init.getContext()),
+   identityAffineMap, identityAffineMap};
+  auto scalarMatrixOp = rewriter.create(
+  loc, matmulType, ValueRange{scalarFactor, matmulRetValue},
+  ValueRange{init}, affineMaps, tosa::getNParallelLoopsAttrs(2),

ftynse wrote:

Let's not use TOSA from here. If this helper is needed, let's move it elsewhere.

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits
ctor affineMaps = {AffineMap::get(2, 0, init.getContext()),
+   identityAffineMap, identityAffineMap};
+  auto scalarMatrixOp = rewriter.create(
+  loc, matmulType, ValueRange{scalarFactor, matmulRetValue},
+  ValueRange{init}, affineMaps, tosa::getNParallelLoopsAttrs(2),
+  [&](OpBuilder , Location nestedLoc, ValueRange args) {
+Value scalarVal = args[0];
+Value matrixVal = args[1];
+Value result = nestedBuilder.create(nestedLoc, 
scalarVal,

ftynse wrote:

Can we just use `linalg.mul`?

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -48,6 +287,261 @@ Value collapse2DData(RewriterBase , Location loc, 
Value data) {
   reassociation);
 }
 
+// This function transforms the filter. The data layout of the filter is FHWC.
+// The transformation matrix is 2-dimension. We need to extract H x W from
+// FHWC first. We need to generate 2 levels of loops to iterate on F and C.
+// After the transformation, we get
+//
+// scf.for %f = lo_f to hi_f step 1
+//   scf.for %c = lo_c to hi_c step 1
+// %extracted = extract filter from filter
+// %ret = linalg.matmul G, %extracted
+// %ret = linalg.matmul %ret, GT
+// %inserted = insert %ret into filter
+//
+Value filterTransform(RewriterBase , Location loc, Value filter,
+  Value retValue, int64_t m, int64_t r,
+  bool leftTransform = true, bool rightTransform = true) {
+  // Map from (m, r) to G transform matrix.
+  static const llvm::SmallDenseMap
+  GMatrices = {
+  {F_2_3, TransformMatrix(G_2x2_3x3, 4, 3)},
+  {F_4_3, TransformMatrix(G_4x4_3x3, 6, 3)},
+  {F_2_5, TransformMatrix(G_2x2_5x5, 6, 5)},
+  };
+
+  // Map from (m, r) to GT transform matrix.
+  static const llvm::SmallDenseMap
+  GTMatrices = {
+  {F_2_3, TransformMatrix(GT_2x2_3x3, 3, 4)},
+  {F_4_3, TransformMatrix(GT_4x4_3x3, 3, 6)},
+  {F_2_5, TransformMatrix(GT_2x2_5x5, 5, 6)},
+  };
+
+  auto filterType = cast(filter.getType());
+  Type elementType = filterType.getElementType();
+  auto filterShape = filterType.getShape(); // F, H, W, C
+  int64_t filterF = filterShape[0];
+  int64_t filterH = filterShape[1];
+  int64_t filterW = filterShape[2];
+  int64_t filterC = filterShape[3];
+
+  if (filterH != r && filterH != 1)
+return Value();
+  if (filterW != r && filterW != 1)
+return Value();
+
+  // Return shape is 
+  auto zeroIdx = rewriter.create(loc, 0);
+  auto fUpperBound = rewriter.create(loc, filterF);
+  auto cUpperBound = rewriter.create(loc, filterC);
+  auto oneStep = rewriter.create(loc, 1);
+  auto outerForOp =
+  rewriter.create(loc, zeroIdx, fUpperBound, oneStep, 
retValue);
+  Block *outerForBody = outerForOp.getBody();
+  rewriter.setInsertionPointToStart(outerForBody);
+  Value FIter = outerForBody->getArgument(0);
+
+  auto innerForOp = rewriter.create(
+  loc, zeroIdx, cUpperBound, oneStep, outerForOp.getRegionIterArgs()[0]);

ftynse wrote:

Ditto. there must be a better-named function for this.

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -36,6 +189,92 @@ constexpr TransformMapKeyTy F_2_3{2, 3};
 constexpr TransformMapKeyTy F_4_3{4, 3};
 constexpr TransformMapKeyTy F_2_5{2, 5};
 
+struct TransformMatrix {

ftynse wrote:

Please document top-level entities.

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[llvm-branch-commits] [mlir] [mlir][linalg] Decompose winograd operators (PR #96183)

2024-06-24 Thread Oleksandr Alex Zinenko via llvm-branch-commits


@@ -23,6 +26,156 @@ namespace linalg {
 
 namespace {
 
+// clang-format off
+// Winograd Conv2D uses a minimal 2D filtering algorithm to calculate its
+// result. The formula of minimal 2D filtering algorithm F(m x m, r x r),
+// m is the output dimension and r is the filter dimension, is
+//
+// Y = A^T x [ (G x g x G^T) x (B^T x d x B) ] x A
+//
+// g is filter and d is input data. We need to prepare 6 constant
+// transformation matrices, G, G^T, B^T, B, A^T, and A for this formula.
+//
+// The following tables define these constant transformation matrices for
+// F(2 x 2, 3 x 3), F(4 x 4, 3 x 3), and F(2 x 2, 5 x 5)
+constexpr float G_2x2_3x3[] = {
+   -1, 0,   0,
+ 1./2, -1./2, 1./2,
+ 1./2,  1./2, 1./2,
+0, 0,1
+};
+
+constexpr float GT_2x2_3x3[] = {
+   -1,  1./2, 1./2, 0,
+0, -1./2, 1./2, 0,
+0,  1./2, 1./2, 1
+};

ftynse wrote:

Have you considered introducing a (potentially `constexpr`) transpose function 
or some sort of transposed access iterator instead of hardcoding transposed 
matrices?

https://github.com/llvm/llvm-project/pull/96183
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits


[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-24 Thread Congcong Cai via cfe-commits
run-clang-tidy.py 
b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
index 7063a18cf9f5d..c9379586682d9 100755
--- a/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
+++ b/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
@@ -235,6 +235,7 @@ def run_tidy(args, clang_tidy_binary, tmpdir, build_path, 
queue, lock, failed_fi
 args.plugins,
 args.warnings_as_errors,
 args.exclude_header_filter,
+args.allow_no_checks,
 )
 
 proc = subprocess.Popen(

>From fb7b211a50a81d17689831f56629fd6daf894920 Mon Sep 17 00:00:00 2001
From: Congcong Cai 
Date: Sun, 23 Jun 2024 15:05:28 +0800
Subject: [PATCH 6/8] Update clang-tools-extra/docs/ReleaseNotes.rst
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Danny Mösch 
---
 clang-tools-extra/docs/ReleaseNotes.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/clang-tools-extra/docs/ReleaseNotes.rst 
b/clang-tools-extra/docs/ReleaseNotes.rst
index 2a2eabe575b0b..39c78e66c6cab 100644
--- a/clang-tools-extra/docs/ReleaseNotes.rst
+++ b/clang-tools-extra/docs/ReleaseNotes.rst
@@ -126,7 +126,7 @@ Improvements to clang-tidy
   to exclude headers from analysis via a RegEx.
 
 - Added argument `--allow-no-checks` to suppress "no checks enabled" error
-  when disabling all of the checks.
+  when disabling all of the checks by `--checks='-*'`.
 
 New checks
 ^^

>From cd9077aa3dc4617832ce0435bd2e7f5da59f0f16 Mon Sep 17 00:00:00 2001
From: Congcong Cai 
Date: Mon, 24 Jun 2024 20:59:11 +0800
Subject: [PATCH 7/8] new line

---
 .../test/clang-tidy/infrastructure/allow-no-checks.cpp | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/clang-tools-extra/test/clang-tidy/infrastructure/allow-no-checks.cpp 
b/clang-tools-extra/test/clang-tidy/infrastructure/allow-no-checks.cpp
index 61776ae17044e..a1f059b92384d 100644
--- a/clang-tools-extra/test/clang-tidy/infrastructure/allow-no-checks.cpp
+++ b/clang-tools-extra/test/clang-tidy/infrastructure/allow-no-checks.cpp
@@ -1,5 +1,4 @@
 // RUN: not clang-tidy %s -checks='-*'
 // RUN: clang-tidy %s -checks='-*' --allow-no-checks | FileCheck 
--match-full-lines %s
 
-
-// CHECK: No checks enabled.
\ No newline at end of file
+// CHECK: No checks enabled.

>From d70e54daa6612ca5c49eb0163f2edf4e56d73089 Mon Sep 17 00:00:00 2001
From: Congcong Cai 
Date: Mon, 24 Jun 2024 21:02:25 +0800
Subject: [PATCH 8/8] add option in clang-tidy-diff.py

---
 clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py 
b/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py
index b048460abf2fc..62cb4297c50f7 100755
--- a/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py
+++ b/clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py
@@ -229,6 +229,11 @@ def main():
 default=[],
 help="Load the specified plugin in clang-tidy.",
 )
+parser.add_argument(
+"-allow-no-checks",
+action="store_true",
+help="Allow empty enabled checks.",
+)
 
 clang_tidy_args = []
 argv = sys.argv[1:]
@@ -327,6 +332,8 @@ def main():
 common_clang_tidy_args.append("-p=%s" % args.build_path)
 if args.use_color:
 common_clang_tidy_args.append("--use-color")
+if args.allow_no_checks:
+common_clang_tidy_args.append("--allow-no-checks")
 for arg in args.extra_arg:
 common_clang_tidy_args.append("-extra-arg=%s" % arg)
 for arg in args.extra_arg_before:

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


36/49: gnu: rgbds: Update to 0.7.0.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 1724d0f169a2ee108e6e3e04a24b091ac626e7b2
Author: Felix Gruber 
AuthorDate: Sun May 19 16:01:47 2024 +

gnu: rgbds: Update to 0.7.0.

* gnu/packages/assembly.scm (rgbds): Update to 0.7.0.

Change-Id: I992e7081fdf5816cba4f0b7437e513734f554a73
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/assembly.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/assembly.scm b/gnu/packages/assembly.scm
index daeeafd603..b38a4512ff 100644
--- a/gnu/packages/assembly.scm
+++ b/gnu/packages/assembly.scm
@@ -357,7 +357,7 @@ runtime")
 (define-public rgbds
   (package
 (name "rgbds")
-(version "0.5.2")
+(version "0.7.0")
 (source (origin
   (method git-fetch)
   (uri (git-reference
@@ -366,7 +366,7 @@ runtime")
   (file-name (git-file-name name version))
   (sha256
(base32
-"13zy05xzh2yxyvzf78a5h59pabwrfr6qs5m453pfbdyd3msg2s7w"
+"1gy75q0ikx0ki1wsrq97hxj9dw9436fcys2w91ipm90pbhk4ljva"
 (build-system gnu-build-system)
 (arguments
  `(#:phases



08/49: gnu: fio: Update to 3.37.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit e92259e56f3230ccb5e9bae3419f5071f6e6c40a
Author: Vincent Legoll 
AuthorDate: Sat Jun 15 23:54:16 2024 +0200

gnu: fio: Update to 3.37.

* gnu/packages/benchmark.scm (fio): Update to 3.37.

Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/benchmark.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/benchmark.scm b/gnu/packages/benchmark.scm
index 24d7c0843d..bfc70c5d3d 100644
--- a/gnu/packages/benchmark.scm
+++ b/gnu/packages/benchmark.scm
@@ -79,14 +79,14 @@
 (define-public fio
   (package
 (name "fio")
-(version "3.36")
+(version "3.37")
 (source (origin
   (method url-fetch)
   (uri (string-append "https://brick.kernel.dk/snaps/;
   "fio-" version ".tar.bz2"))
   (sha256
(base32
-"0ppg2rn57diz2mvbbps4cjxd903zn380hdkdsrbzal4l513w32h0"
+"09w35mpkrlxjy506bhifq7akc7mid9q92jkqgqwgf1ya95jzvw48"
 (build-system gnu-build-system)
 (arguments
  (list #:modules



14/49: gnu: mold: Update to 2.32.0

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 7be6cb8acaa7ea8fba7f89e27adb01ad7485856e
Author: Ashish SHUKLA 
AuthorDate: Sun Jun 9 19:45:03 2024 +0200

gnu: mold: Update to 2.32.0

* gnu/packages/mold.scm (mold): Update to 2.32.0.

Change-Id: Ia99d57c92e9e9d75d80880376687b8a0b5fde184
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/mold.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mold.scm b/gnu/packages/mold.scm
index 8625efff27..7188f533e7 100644
--- a/gnu/packages/mold.scm
+++ b/gnu/packages/mold.scm
@@ -35,7 +35,7 @@
 (define-public mold
   (package
 (name "mold")
-(version "2.4.0")
+(version "2.32.0")
 (source
  (origin
(method git-fetch)
@@ -44,7 +44,7 @@
  (commit (string-append "v" version
(file-name (git-file-name name version))
(sha256
-(base32 "0rqw7p61qijxhbfm887xbh8idbp5w30axvwgmm68s03xirnr7ymr"))
+(base32 "1wl7mp7r5hxmvfpmrq32ffjpgn8z8pk775y423nr56gvrb39vj6i"))
(modules '((guix build utils)))
(snippet
 #~(begin



22/49: gnu: grub: Update to 2.12.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit e6facbe069ba536a6bb9dffc582a78f982596be6
Author: Ludovic Courtès 
AuthorDate: Mon Jun 3 22:01:22 2024 +0200

gnu: grub: Update to 2.12.

* gnu/packages/bootloaders.scm (grub): Update to 2.12.
[source](patches): Remove ‘grub-ignore-metadata-csum-seed.patch’.
(snippet): Create ‘grub-core/extra_deps.lst’.  Replace “exit 99”
by “exit 77”.
(grub-coreboot): Update value of ‘XFAIL_TESTS’.
* doc/guix.texi (Keyboard Layout and Networking and Partitioning): Update
accordingly (it should now be fine to use LUKS2).
* gnu/packages/patches/grub-ignore-metadata-csum-seed.patch: Remove.
* gnu/local.mk (dist_patch_DATA): Remove it.

Change-Id: Ia31b3b7e0a2e7de42d30229733e9c196fcd12fd9
Signed-off-by: Maxim Cournoyer 
Modified-by: Maxim Cournoyer 
---
 doc/guix.texi  | 13 +-
 gnu/local.mk   |  1 -
 gnu/packages/bootloaders.scm   | 27 ++-
 .../patches/grub-ignore-metadata-csum-seed.patch   | 54 --
 4 files changed, 18 insertions(+), 77 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 6257de7583..0ad0a23b6c 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -2403,21 +2403,12 @@ the Cryptsetup/LUKS utilities to do that (see 
@inlinefmtifelse{html,
 @uref{https://linux.die.net/man/8/cryptsetup, @code{man cryptsetup}},
 @code{man cryptsetup}} for more information).
 
-@quotation Warning
-While efforts are in progress to extend support to LUKS2, please note
-that Guix only supports devices of type LUKS1 at the moment. You can
-verify that your existing LUKS device is of the right type by running
-@command{cryptsetup luksDump @var{device}}. Alternatively, you can
-create a new LUKS1 device with @command{cryptsetup luksFormat --type
-luks1 @var{device}}.
-@end quotation
-
 Assuming you want to store the root partition on @file{/dev/sda2}, the
-command sequence to format it as a LUKS1 partition would be along these
+command sequence to format it as a LUKS partition would be along these
 lines:
 
 @example
-cryptsetup luksFormat --type luks1 /dev/sda2
+cryptsetup luksFormat /dev/sda2
 cryptsetup open /dev/sda2 my-partition
 mkfs.ext4 -L my-root /dev/mapper/my-partition
 @end example
diff --git a/gnu/local.mk b/gnu/local.mk
index 4a2c7f7bfa..6a436dd1b8 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1425,7 +1425,6 @@ dist_patch_DATA = 
\
   %D%/packages/patches/groovy-add-exceptionutilsgenerator.patch\
   %D%/packages/patches/grub-efi-fat-serial-number.patch\
   %D%/packages/patches/grub-setup-root.patch   \
-  %D%/packages/patches/grub-ignore-metadata-csum-seed.patch
\
   %D%/packages/patches/guile-1.8-cpp-4.5.patch \
   %D%/packages/patches/guile-2.2-skip-oom-test.patch\
   %D%/packages/patches/guile-2.2-skip-so-test.patch \
diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index f37344c25b..4e932ee328 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -1,5 +1,5 @@
 ;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2013-2019, 2021, 2023 Ludovic Courtès 
+;;; Copyright © 2013-2019, 2021, 2023-2024 Ludovic Courtès 
 ;;; Copyright © 2015, 2018 Mark H Weaver 
 ;;; Copyright © 2015 Leo Famulari 
 ;;; Copyright © 2016, 2020 Jan (janneke) Nieuwenhuizen 
@@ -104,25 +104,28 @@
 (define-public grub
   (package
 (name "grub")
-(version "2.06")
+(version "2.12")
 (source (origin
   (method url-fetch)
   (uri (string-append "mirror://gnu/grub/grub-" version ".tar.xz"))
   (sha256
(base32
-"1qbycnxkx07arj9f2nlsi9kp0dyldspbv07ysdyd34qvz55a97mp"))
+"1ahgzvvvwdxx7rl08pv5dyqlgp76jxz0q2cflxvsdsn4yy8p7jgk"))
   (patches (search-patches
 "grub-efi-fat-serial-number.patch"
-"grub-setup-root.patch"
-"grub-ignore-metadata-csum-seed.patch"))
+"grub-setup-root.patch"))
   (modules '((guix build utils)))
   (snippet
-   '(begin
-  ;; Adjust QEMU invocation to not use a deprecated device
-  ;; name that was removed in QEMU 6.0.  Remove for >2.06.
-  (substitute* "tests/ahci_test.in"
-(("ide-drive")
- "ide-hd"))
+   #~(begin
+   ;; Add file missing from the release tarball.
+   (call-with-output-file "grub-core/extra_deps.lst"
+ (lambda (port)
+   (display "depends bli part_gpt\n" port)))
+
+   ;; Use exit code 77, not 99, to tell Automake that a test
+  

37/49: gnu: sameboy: Update to 0.16.3.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit ef54287fef5346c96d39fa49966ad92f48117b62
Author: Felix Gruber 
AuthorDate: Sun May 19 16:01:48 2024 +

gnu: sameboy: Update to 0.16.3.

* gnu/packages/emulators.scm (sameboy): Update to 0.16.3.

Change-Id: I56a1bd092e1ce00733d8fea8ab372b2bd52c8b7b
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/emulators.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 84441181c7..4471de9040 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -792,7 +792,7 @@ and Game Boy Color games.")
 (define-public sameboy
   (package
 (name "sameboy")
-(version "0.16.2")
+(version "0.16.3")
 (source
  (origin
(method git-fetch)
@@ -801,7 +801,7 @@ and Game Boy Color games.")
  (commit (string-append "v" version
(file-name (git-file-name name version))
(sha256
-(base32 "1ckx5dm57h7ncvfqqqb2mdl5dcmhkardcn78zv965h6w1yxg0ii8"
+(base32 "1jdjg59vzzkbi3c3qaxpsxqx955sb86cd3kcypb0nhjxbnwac1di"
 (build-system gnu-build-system)
 (native-inputs
  (list rgbds pkg-config))



43/49: gnu: kakoune: Update to 2024.05.18.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 6e33f0d887feb6bb2898b00a8c1b7839f6b27e49
Author: Ashish SHUKLA 
AuthorDate: Sat May 18 06:32:52 2024 +

gnu: kakoune: Update to 2024.05.18.

* gnu/packages/text-editors.scm (kakoune): Update to 2024.05.18.

Change-Id: I4ca1f66e104a40f2d759c097c0548e6812ef6d16
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/text-editors.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/text-editors.scm b/gnu/packages/text-editors.scm
index c1956d3602..b6eb48785d 100644
--- a/gnu/packages/text-editors.scm
+++ b/gnu/packages/text-editors.scm
@@ -216,7 +216,7 @@ based command language.")
 (define-public kakoune
   (package
 (name "kakoune")
-(version "2024.05.09")
+(version "2024.05.18")
 (source
  (origin
(method url-fetch)
@@ -224,7 +224,7 @@ based command language.")
"releases/download/v" version "/"
"kakoune-" version ".tar.bz2"))
(sha256
-(base32 "0ad22syhsd921rnfpmkvyh37am3ni443g1f3jc2hqndgsggvv411"
+(base32 "1ymr1jpdnd5wj6npzi8bgfd30d0j885sfnhl236rn7fjc4pars6s"
 (build-system gnu-build-system)
 (arguments
  `(#:make-flags



49/49: gnu: patch: Update to latest commit [security fixes].

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 831001c581279ee981aea7433e4d6dbe30de7d31
Author: Maxim Cournoyer 
AuthorDate: Wed Jun 5 20:46:21 2024 -0400

gnu: patch: Update to latest commit [security fixes].

* gnu/packages/base.scm (patch): Rename to...
(patch/pinned): ... this.  Hide package.
(patch): New variable.
* gnu/packages/commencement.scm (patch-mesboot): Inherit from patch/pinned.
(patch-boot0): Likewise.
(%final-inputs): Replace patch with patch/pinned.
* gnu/packages/lisp.scm (cl-asdf): Likewise.
* guix/packages.scm (%standard-patch-inputs): Replace patch with 
patch/pinned.

Fixes: https://issues.guix.gnu.org/47144
Reported-by: Mark H Weaver 
Change-Id: I54ae41b735f5ba0ebad30ebdfaabe0ccdc3f9873
---
 gnu/packages/base.scm | 102 +++---
 gnu/packages/commencement.scm |   8 ++--
 gnu/packages/lisp.scm |   2 +-
 guix/packages.scm |   2 +-
 4 files changed, 82 insertions(+), 32 deletions(-)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index bbe5b8cf57..66c5b7d237 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -19,7 +19,7 @@
 ;;; Copyright © 2021 Leo Le Bouter 
 ;;; Copyright © 2021 Maxime Devos 
 ;;; Copyright © 2021 Guillaume Le Vaillant 
-;;; Copyright © 2021 Maxim Cournoyer 
+;;; Copyright © 2021, 2024 Maxim Cournoyer 
 ;;; Copyright © 2022 zamfofex 
 ;;; Copyright © 2022 John Kehayias 
 ;;; Copyright © 2023 Josselin Poiret 
@@ -46,8 +46,10 @@
   #:use-module (gnu packages acl)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages attr)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages bash)
   #:use-module (gnu packages bison)
+  #:use-module (gnu packages build-tools)
   #:use-module (gnu packages gcc)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages multiprecision)
@@ -261,35 +263,83 @@ standard utility.")
(license gpl3+)
(home-page "https://www.gnu.org/software/tar/;)))
 
-(define-public patch
-  (package
-(name "patch")
-(version "2.7.6")
-(source (origin
-  (method url-fetch)
-  (uri (string-append "mirror://gnu/patch/patch-"
-  version ".tar.xz"))
-  (sha256
-   (base32
-"1zfqy4rdcy279vwn2z1kbv19dcfw25d2aqy9nzvdkq5bjzd0nqdc"))
-  (patches (search-patches "patch-hurd-path-max.patch"
-(build-system gnu-build-system)
-(arguments
- ;; Work around a cross-compilation bug whereby libpatch.a would provide
- ;; '__mktime_internal', which conflicts with the one in libc.a.
- (if (%current-target-system)
- `(#:configure-flags '("gl_cv_func_working_mktime=yes"))
- '()))
-(native-inputs (list ed))
-(synopsis "Apply differences to originals, with optional backups")
-(description
- "Patch is a program that applies changes to files based on differences
+;;; TODO: Replace/merge with 'patch' on core-updates.
+(define-public patch/pinned
+  (hidden-package
+   (package
+ (name "patch")
+ (version "2.7.6")
+ (source (origin
+   (method url-fetch)
+   (uri (string-append "mirror://gnu/patch/patch-"
+   version ".tar.xz"))
+   (sha256
+(base32
+ "1zfqy4rdcy279vwn2z1kbv19dcfw25d2aqy9nzvdkq5bjzd0nqdc"))
+   (patches (search-patches "patch-hurd-path-max.patch"
+ (build-system gnu-build-system)
+ (arguments
+  ;; Work around a cross-compilation bug whereby libpatch.a would provide
+  ;; '__mktime_internal', which conflicts with the one in libc.a.
+  (if (%current-target-system)
+  `(#:configure-flags '("gl_cv_func_working_mktime=yes"))
+  '()))
+ (native-inputs (list ed))
+ (synopsis "Apply differences to originals, with optional backups")
+ (description
+  "Patch is a program that applies changes to files based on differences
 laid out as by the program \"diff\".  The changes may be applied to one or more
 files depending on the contents of the diff file.  It accepts several
 different diff formats.  It may also be used to revert previously applied
 differences.")
-(license gpl3+)
-(home-page "https://savannah.gnu.org/projects/patch/;)))
+ (license gpl3+)
+ (home-page "https://savannah.gnu.org/projects/patch/;
+
+(define-public patch
+  ;; The latest release is from 2018, and lacks multiple security related
+  ;; patches.  Since Fedora carries 23 patches, simply use the latest commit
+  ;; until a proper release is made.
+  (let ((revision "0")
+(commit "f144b35425d9d7732ea5485034c1a6b7a106ab92")
+(base patch/pinned))
+(package
+  (inherit base)
+  (name "patch")
+  (version (git-version "2.7.6" revision commit))
+  (source (origin
+(method git-fetch)
+ 

30/49: gnu: sddm: Update to 0.21.0.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 93b86f7362106ef84c0820e8c4d548cc816f7334
Author: Sughosha 
AuthorDate: Mon May 27 23:38:17 2024 +0530

gnu: sddm: Update to 0.21.0.

* gnu/packages/display-managers.scm (sddm): Update to 0.21.0.
[arguments]<#:configure-flags>: Add
"-DINSTALL_PAM_CONFIGURATION=OFF".

Change-Id: Iac61bcc14963c5c2f04659603158f4507fad5da4
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/display-managers.scm | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/display-managers.scm 
b/gnu/packages/display-managers.scm
index 3ff8fa5b65..6a6437ff0c 100644
--- a/gnu/packages/display-managers.scm
+++ b/gnu/packages/display-managers.scm
@@ -69,7 +69,7 @@
 (define-public sddm
   (package
 (name "sddm")
-(version "0.20.0")
+(version "0.21.0")
 (source (origin
   (method git-fetch)
   (uri (git-reference
@@ -78,7 +78,7 @@
   (file-name (git-file-name name version))
   (sha256
(base32
-"1450zv03d3mbid27986p4mdshw9qf3ar8crl4idybf7khxgan22y"
+"0mxrh0z9x4r4bli25g746n66adwnf3r42lzq0yssc50v9y7fc1a1"
 (build-system qt-build-system)
 (native-inputs
  (list extra-cmake-modules pkg-config qttools-5))
@@ -105,6 +105,8 @@
   #~(list
  "-DENABLE_WAYLAND=ON"
  "-DENABLE_PAM=ON"
+ ;; PAM is configured by pam service.
+ "-DINSTALL_PAM_CONFIGURATION=OFF"
  ;; Both flags are required for elogind support.
  "-DNO_SYSTEMD=ON"
  "-DUSE_ELOGIND=ON"



48/49: gnu: gnulib: Update to 2024-05-30-1.ac4b301.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 1a0509e7fa1caeb5c56e936849e3b574ef27aa53
Author: Maxim Cournoyer 
AuthorDate: Wed Jun 5 20:46:20 2024 -0400

gnu: gnulib: Update to 2024-05-30-1.ac4b301.

Also fix the commands, which would fail due to not finding their
implementation scripts.

* gnu/packages/patches/gnulib-bootstrap.patch: New patch.
* gnu/local.mk (dist_patch_DATA): Register it.
* gnu/packages/build-tools.scm (gnulib): Update to 2024-05-30-1.ac4b301.
[source]: Apply patch.
[phases] {patch-source-shebangs, patch-generated-file-shebangs}
{patch-usr-bin-file, restore-shebangs}: Delete phases.
{disable-failing-tests}: Disable sc_error_message_warn_fatal,
sc_prefer_angle_bracket_headers, sc_check_config_h_reminder,
sc_prohibit_sc_omitted_at, sc_readme_link_copying, sc_readme_link_install,
sc_unsigned_char, sc_unsigned_int,  sc_unsigned_long and sc_unsigned_short
checks.
{regenerate-unicode}: Register BidiMirroring.txt unicode data file.

Change-Id: I154b2c5980b671f1e73e7a1f74d926ea080a7aa0
---
 gnu/local.mk|  1 +
 gnu/packages/build-tools.scm| 55 -
 gnu/packages/patches/gnulib-bootstrap.patch | 75 +
 3 files changed, 107 insertions(+), 24 deletions(-)

diff --git a/gnu/local.mk b/gnu/local.mk
index 6a436dd1b8..282cf30f7f 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1394,6 +1394,7 @@ dist_patch_DATA = 
\
   %D%/packages/patches/gnome-settings-daemon-gc.patch  \
   %D%/packages/patches/gnome-session-support-elogind.patch \
   %D%/packages/patches/gnome-tweaks-search-paths.patch \
+  %D%/packages/patches/gnulib-bootstrap.patch  \
   %D%/packages/patches/gnumach-support-noide.patch \
   %D%/packages/patches/gnupg-default-pinentry.patch\
   %D%/packages/patches/gnupg-1-build-with-gcc10.patch  \
diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
index 35b16f0045..c0cba8076f 100644
--- a/gnu/packages/build-tools.scm
+++ b/gnu/packages/build-tools.scm
@@ -13,7 +13,7 @@
 ;;; Copyright © 2020 Jakub Kądziołka 
 ;;; Copyright © 2020, 2023 Efraim Flashner 
 ;;; Copyright © 2021 qblade 
-;;; Copyright © 2021, 2023 Maxim Cournoyer 
+;;; Copyright © 2021, 2023, 2024 Maxim Cournoyer 
 ;;; Copyright © 2022, 2023 Juliana Sims 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -853,12 +853,15 @@ Makefiles, JSON Compilation Database, and experimentally 
Ninja.")
   ;; FIXME: tests/uniname/HangulSyllableNames.txt
   ;; seems like a UCD file but it is not distributed
   ;; with UCD.
-  "tests/uniwbrk/WordBreakTest.txt")))
+  "tests/uniwbrk/WordBreakTest.txt")
+   (patches (search-patches "gnulib-bootstrap.patch"
 (build-system copy-build-system)
 (arguments
  (list
   #:install-plan
   #~'(("./gnulib-tool" "bin/")
+  ("./gnulib-tool.py" "bin/")
+  ("./gnulib-tool.sh" "bin/")
   ("." "src/gnulib" #:exclude-regexp ("\\.git.*")))
   #:modules '((ice-9 match)
   (guix build utils)
@@ -866,6 +869,13 @@ Makefiles, JSON Compilation Database, and experimentally 
Ninja.")
   ((guix build gnu-build-system) #:prefix gnu:))
   #:phases
   #~(modify-phases %standard-phases
+  ;; Since this package is intended to be used in source form, it
+  ;; should not retain references to tools (with the exception for the
+  ;; commands we install, which should be wrapper for proper
+  ;; execution).
+  (delete 'patch-source-shebangs)
+  (delete 'patch-generated-file-shebangs)
+  (delete 'patch-usr-bin-file)
   (add-before 'install 'check
 (assoc-ref gnu:%standard-phases 'check))
   (add-before 'check 'fix-tests
@@ -889,8 +899,10 @@ Makefiles, JSON Compilation Database, and experimentally 
Ninja.")
   sc_Wundef_boolean \\
   sc_copyright_check \\
   sc_file_system \\
+  sc_error_message_warn_fatal \\
   sc_indent \\
   sc_keep_gnulib_texi_files_mostly_ascii \\
+  sc_prefer_angle_bracket_headers \\
   sc_prohibit_assert_without_use \\
   sc_prohibit_close_stream_without_use \\
   sc_prohibit_defined_have_decl_tests \\
@@ -899,15 +911,22 @@ Makefiles, JSON Compilation Database, and experimentally 
Ninja.")
   sc_prohibit_intprops_without_use \\
   sc_prohibit_openat_without_use \\
   sc_prohibit_test_minus_ao \\
-  sc_unportable_grep_q"))
+  sc_readme_link_copying \\
+  sc_readme_link_install \\
+  sc_unportable_grep_q \\
+  sc_unsigned_char \\
+  sc_unsigned_int \\
+  sc_unsigned_long \\
+  sc_unsigned_short"))
   (substitute* "Makefile"
-(("sc_check_(sym_list|copyright)" rule)
+

39/49: gnu: godot-lts: Improve package style.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit c12a6e74192ca2d51386787ae7e939e03a09e17e
Author: Nicolas Graves 
AuthorDate: Sun May 19 18:16:06 2024 +0200

gnu: godot-lts: Improve package style.

* gnu/packages/game-development.scm (godot-lts): Re-indent and ensure
max column length to 79.
  [arguments]: Use gexp.

Change-Id: I0bedb66a4e7e0ebe6242df885f1e687ce3a43ce0
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/game-development.scm | 166 --
 1 file changed, 88 insertions(+), 78 deletions(-)

diff --git a/gnu/packages/game-development.scm 
b/gnu/packages/game-development.scm
index e64dcaac65..aff95d48a1 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2022 Jai Vetrivelan 
 ;;; Copyright © 2022 dan 
 ;;; Copyright © 2023 John Kehayias 
+;;; Copyright © 2024 Nicolas Graves 
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1972,86 +1973,95 @@ games.")
   "vhacd"
   "xatlas")))
   (for-each delete-file-recursively
-(lset-difference string=?
- (scandir ".")
- (cons* "." ".." 
preserved-files)
+(lset-difference
+ string=?
+ (scandir ".")
+ (cons* "." ".." preserved-files)
 (build-system scons-build-system)
 (arguments
- `(#:scons-flags (list "platform=x11" "target=release_debug"
-   ;; Avoid using many of the bundled libs.
-   ;; Note: These options can be found in the 
SConstruct file.
-   "builtin_bullet=no"
-   "builtin_freetype=no"
-   "builtin_glew=no"
-   "builtin_libmpdec=no"
-   "builtin_libogg=no"
-   "builtin_libpng=no"
-   "builtin_libtheora=no"
-   "builtin_libvorbis=no"
-   "builtin_libvpx=no"
-   "builtin_libwebp=no"
-   "builtin_mbedtls=no"
-   "builtin_opus=no"
-   "builtin_pcre2=no"
-   "builtin_wslay=no"
-   "builtin_zlib=no"
-   "builtin_zstd=no")
-   #:tests? #f  ; There are no tests
-   #:phases
-   (modify-phases %standard-phases
- (add-after 'unpack 'scons-use-env
-   (lambda _
- ;; Scons does not use the environment variables by default,
- ;; but this substitution makes it do so.
- (substitute* "SConstruct"
-   (("env_base = Environment\\(tools=custom_tools\\)")
-(string-append
- "env_base = Environment(tools=custom_tools)\n"
- "env_base = Environment(ENV=os.environ)")
- ;; Build headless tools, used for packaging games without depending 
on X.
- (add-after 'build 'build-headless
-   (lambda* (#:key scons-flags #:allow-other-keys)
- (apply invoke "scons"
-`(,(string-append "-j" (number->string 
(parallel-job-count)))
-  "platform=server" ,@(delete "platform=x11" 
scons-flags)
- (replace 'install
-   (lambda* (#:key inputs outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
-(headless (assoc-ref outputs "headless"))
-(zenity (assoc-ref inputs "zenity")))
-   ;; Strip build info from filenames.
-   (with-directory-excursion "bin"
- (for-each
-  (lambda (file)
-(let ((dest (car (string-split (basename file) #\.
-  (rename-file file dest)))
-  (find-files "." "godot.*\\.x11\\.opt\\.tools.*"))
- (install-file "godot" (string-append out "/bin"))
- (install-file "godot_server" (string-append headless "/bin")))
-   ;; Tell the editor where to find zenity for OS.alert().
-   (wrap-program (string-append out "/bin/godot")
- `("PATH" ":" prefix (,(string-append zenity "/bin")))
- (add-after 'install 'wrap-ld-path
-   (lambda* (#:key inputs outputs #:allow-other-keys)
- (let* ((out (assoc-ref outputs "out"))
-(pulseaudio_path (string-append (assoc-ref inputs 
"pulseaudio") "/lib"))
-(alas_lib_path (string-append (assoc-ref inputs 
"alsa-lib") "/lib")))
-   (wrap-program (string-append 

41/49: gnu: opensc: Update to 0.25.1.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 26f46cfd2a1442ebada5178dccb1cc5a5bf95feb
Author: Timotej Lazar 
AuthorDate: Sat May 18 13:39:37 2024 +0200

gnu: opensc: Update to 0.25.1.

* gnu/packages/security-token.scm (opensc): Update to 0.25.1.

Change-Id: I16dbf047671115274a25c3b1fba0285952f9f41d
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/security-token.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index 939febd4e3..e569d071b8 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -355,7 +355,7 @@ website for more information about Yubico and the YubiKey.")
 (define-public opensc
   (package
 (name "opensc")
-(version "0.25.0")
+(version "0.25.1")
 (source (origin
   (method url-fetch)
   (uri (string-append
@@ -363,7 +363,7 @@ website for more information about Yubico and the YubiKey.")
 version "/opensc-" version ".tar.gz"))
   (sha256
(base32
-"0bv2sq3k8bl712yi1gi7f8km8g2x09is8ynnr5x3g2jh59pbdmz6"
+"0yxk97aj29pybvya6r9ix9xh00hdzcfrc2lcns4vb3kwpplamjr3"
 (build-system gnu-build-system)
 (arguments
  `(#:phases



44/49: doc: Improve description of nginx's configuration.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit fc921acbef5a3864d525020afe524ccc8d66b4b5
Author: Tomas Volf <~@wolfsden.cz>
AuthorDate: Thu Jun 20 15:31:15 2024 +0200

doc: Improve description of nginx's configuration.

* doc/guix.texi (Web Services)[nginx-server-configuration]: Document 
semantics
of raw-content field.
[nginx-location-configuration]: Document semantics of body field.

Change-Id: I1e699d085a27f2615190de1e1973146da4ab193d
Signed-off-by: Maxim Cournoyer 
---
 doc/guix.texi | 16 ++--
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 0ad0a23b6c..fd19245539 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -32127,7 +32127,9 @@ you don't have a key or you don't want to use HTTPS.
 Whether the server should add its configuration to response.
 
 @item @code{raw-content} (default: @code{'()})
-A list of raw lines added to the server block.
+A list of strings or file-like objects to be appended to the server
+block.  Each item is prefixed with indentation and suffixed with a new
+line.  Nested lists are flattened.
 
 @end table
 @end deftp
@@ -32164,11 +32166,13 @@ URI which this location block matches.
 
 @anchor{nginx-location-configuration body}
 @item @code{body}
-Body of the location block, specified as a list of strings.  This can contain
-many
-configuration directives.  For example, to pass requests to a upstream
-server group defined using an @code{nginx-upstream-configuration} block,
-the following directive would be specified in the body @samp{(list "proxy_pass
+Body of the location block, specified as a list of strings or file-like
+objects.  Each item is prefixed with indentation and suffixed with a new
+line.  Nested lists are flattened.
+
+For example, to pass requests to a upstream server group defined using
+an @code{nginx-upstream-configuration} block, the following directive
+would be specified in the body @samp{(list "proxy_pass
 http://upstream-name;;)}.
 
 @end table



branch master updated (c5fc11488c -> 831001c581)

2024-06-24 Thread guix-commits
apteryx pushed a change to branch master
in repository guix.

from c5fc11488c gnu: cl-trivial-clipboard: Update to 0.0.0-8.50b3d3a.
 new 08149c02bc gnu: bcc: Update to 0.30.0, fixing build.
 new 77d949c812 gnu: bpftrace: Update to 0.21.0 and enable tests.
 new 603d523fc3 doc: Fix Reviewed-by format.
 new 2455c4ded9 services: mpd: Fix log to file.
 new a8547a0feb gnu: gauche: Update to 0.9.15.
 new 0dacf51553 gnu: gauche: Remove trailing #t.
 new 51aee1784d gnu: isc-bind: Update to 9.19.24.
 new e92259e56f gnu: fio: Update to 3.37.
 new b539e5ae39 services: networking: Allow dhcp-client to use a config 
file.
 new ff9942dcc1 doc: Prepend ISC to DHCP client references.
 new 0fe46e53bb gnu: astyle: Update to 3.5.
 new cd15d417e3 gnu: nginx: Update to 1.27.0.
 new 7d0a6d3e74 gnu: sane-backends: Update to 1.3.1.
 new 7be6cb8aca gnu: mold: Update to 2.32.0
 new 4965f9314a gnu: smartmontools: Update to 7.4.
 new e57eff3d29 gnu: subversion: Update to 1.14.3.
 new 7aab18bdf3 gnu: memcached: Update to 1.6.28.
 new 7ae5decaeb gnu: wxwidgets: Update to 3.2.5.
 new 250ab39c36 gnu: octave: Update to 9.2.0.
 new 8c80b22147 gnu: torbrowser: Update to 13.0.16 [security fixes].
 new d37614bed1 build-system: qt: Fix default parallel-tests? value to #t.
 new e6facbe069 gnu: grub: Update to 2.12.
 new b9c38f26f1 gnu: grub: Remove input labels and use gexps.
 new 81c2355d9c gnu: volctl: Update to 0.9.4.
 new 53861af06d gnu: python-pulsectl: Update to 24.4.0.
 new 26c0ff98cf gnu: git: Update to 2.45.2.
 new d19d5447cd doc: contributing: Mention 'guix git authenticate'.
 new b9bdcad448 gnu: mtools: Update to 4.0.44.
 new 2b78b0a253 gnu: exim: Update to 4.97.1.
 new 93b86f7362 gnu: sddm: Update to 0.21.0.
 new 0fda048652 gnu: guix: Add imagemagick, perl and use full graphviz.
 new 7f194852a4 manifest: Streamline; add packages useful for patch 
review/submission.
 new 7971da9e30 gnu: openresolv: Update to 3.13.2.
 new 6dfc83ca34 gnu: Update openjdk variable to openjdk21.
 new 633c0307ea gnu: wine, wine64, wine-staging, wine64-staging: Enable 
wayland support.
 new 1724d0f169 gnu: rgbds: Update to 0.7.0.
 new ef54287fef gnu: sameboy: Update to 0.16.3.
 new 7f1c40df92 gnu: godot-lts: Update to 3.5.3.
 new c12a6e7419 gnu: godot-lts: Improve package style.
 new 1f3aea435a gnu: readymedia: Update to 1.3.3.
 new 26f46cfd2a gnu: opensc: Update to 0.25.1.
 new e121ecccdc gnu: opensc: Switch to new package style.
 new 6e33f0d887 gnu: kakoune: Update to 2024.05.18.
 new fc921acbef doc: Improve description of nginx's configuration.
 new 5f88f71c2d doc: Add message for common error about make check-system.
 new 836cc6b3fc gnu: torbrowser: Add bash-minimal.
 new 8a610b82a9 gnu: ucd: Update to 15.1.0.
 new 1a0509e7fa gnu: gnulib: Update to 2024-05-30-1.ac4b301.
 new 831001c581 gnu: patch: Update to latest commit [security fixes].

The 49 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 doc/contributing.texi  |  28 +-
 doc/guix.texi  |  52 +-
 gnu/local.mk   |   3 +-
 gnu/packages/admin.scm |   4 +-
 gnu/packages/assembly.scm  |   4 +-
 gnu/packages/audio.scm |   4 +-
 gnu/packages/base.scm  | 102 +++-
 gnu/packages/benchmark.scm |   4 +-
 gnu/packages/bootloaders.scm   | 555 +++--
 gnu/packages/build-tools.scm   |  55 +-
 gnu/packages/code.scm  |  28 +-
 gnu/packages/commencement.scm  |   8 +-
 gnu/packages/databases.scm |   4 +-
 gnu/packages/display-managers.scm  |   6 +-
 gnu/packages/dns.scm   |  64 +--
 gnu/packages/emulators.scm |   4 +-
 gnu/packages/game-development.scm  | 182 +++
 gnu/packages/gtk.scm   |   4 +-
 gnu/packages/java.scm  |   2 +-
 gnu/packages/linux.scm | 141 +++---
 gnu/packages/lisp.scm  |   2 +-
 gnu/packages/mail.scm  |  11 +-
 gnu/packages/maths.scm |   4 +-
 gnu/packages/mold.scm  |   4 +-
 gnu/packages/mtools.scm|   4 +-
 gnu/packages/package-management.scm|   4 +-
 .../patches/bpftrace-disable-bfd-disasm.patch  |  15 -
 

40/49: gnu: readymedia: Update to 1.3.3.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 1f3aea435a54f405cdcc8504854c036af0993aae
Author: David Pflug 
AuthorDate: Sat May 18 11:41:06 2024 -0400

gnu: readymedia: Update to 1.3.3.

* gnu/packages/upnp.scm (readymedia): Update to 1.3.3.

Change-Id: I1e4a259a2279b9e836d4b1b5374af0dce092c12e
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/upnp.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/upnp.scm b/gnu/packages/upnp.scm
index 400e6656d1..6592f2fe7f 100644
--- a/gnu/packages/upnp.scm
+++ b/gnu/packages/upnp.scm
@@ -137,7 +137,7 @@ and others.")
 (define-public readymedia
   (package
 (name "readymedia")
-(version "1.3.1")
+(version "1.3.3")
 (source
  (origin
(method git-fetch)
@@ -147,7 +147,7 @@ and others.")
   "v" (string-replace-substring version "." "_")
(file-name (git-file-name name version))
(sha256
-(base32 "09fg3697wshg0j46mi3bp2i6ypiqm39vmzx52bci8r6j07yz7fwx"
+(base32 "1al04jx72bxwqch1nv9lx536mb6pvj7pgnqzy6lm32q6xa114yr2"
 (build-system gnu-build-system)
 (arguments
  `(#:configure-flags '("--with-os-name=Linux")  ; uname -s



34/49: gnu: Update openjdk variable to openjdk21.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 6dfc83ca34a5d96439ad2654b837a6031ad5b5e6
Author: Remco van 't Veer 
AuthorDate: Tue May 21 17:34:09 2024 +0200

gnu: Update openjdk variable to openjdk21.

* gnu/packages/java.scm (openjdk): Update to openjdk21.

Change-Id: I132dcb6722f604cfe42fdfbc81066d614d4519b9
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/java.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 49fc2761d6..a2414161da 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -1682,7 +1682,7 @@ blacklisted.certs.pem"
  (("^#!.*") "#! java BlockedCertsConverter SHA-256\n"))
 
 ;;; Convenience alias to point to the latest version of OpenJDK.
-(define-public openjdk openjdk19)
+(define-public openjdk openjdk21)
 
 
 ;; This version of JBR is here in order to be able to build custom



19/49: gnu: octave: Update to 9.2.0.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 250ab39c365960d048ca2d194f0f022023d1e1d0
Author: Andy Tai 
AuthorDate: Wed Jun 12 02:37:37 2024 -0700

gnu: octave: Update to 9.2.0.

* gnu/packages/maths.scm (octave-cli): Update to 9.2.0.

Change-Id: Ib00c0eb687a469ecca20d570f39b69d8027c0cb0
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/maths.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 02d8c704d8..3fa520dad3 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -3021,7 +3021,7 @@ can solve two kinds of problems:
 (define-public octave-cli
   (package
 (name "octave-cli")
-(version "9.1.0")
+(version "9.2.0")
 (source
  (origin
(method url-fetch)
@@ -3029,7 +3029,7 @@ can solve two kinds of problems:
version ".tar.xz"))
(sha256
 (base32
- "0jqk3amfkqzn1c5rzb9gm3v7r2y5xcgx6cgi4r5w8mpa9814nrgd"
+ "01sqfqrglzkjp20sg45fjd43hbjj069a1gn0r8sv01ciazxplh91"
 (build-system gnu-build-system)
 (inputs
  (list alsa-lib



28/49: gnu: mtools: Update to 4.0.44.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit b9bdcad448034a41c79f64e9e5a7f4fad74f5b7d
Author: Andy Tai 
AuthorDate: Tue Jun 4 07:58:50 2024 -0700

gnu: mtools: Update to 4.0.44.

* gnu/packages/mtools.scm (mtools): Update to 4.0.44.

Change-Id: I8b08e3e577521ea2c4506c613eb276d4847a3ba5
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/mtools.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mtools.scm b/gnu/packages/mtools.scm
index 3174e3852a..92706083b4 100644
--- a/gnu/packages/mtools.scm
+++ b/gnu/packages/mtools.scm
@@ -29,14 +29,14 @@
 (define-public mtools
   (package
 (name "mtools")
-(version "4.0.42")
+(version "4.0.44")
 (source (origin
   (method url-fetch)
   (uri (string-append "mirror://gnu/mtools/mtools-"
   version ".tar.bz2"))
   (sha256
(base32
-"05fg5i8da5jdym3cq2939j7n3fqw4cz2riy1yci6pbw29pgdzgv4"))
+"1f6x3srkssjcnrmd9hkladc8nzkwq9rqkiy15r5ksg2k4bq4vp1p"))
   (patches
(search-patches "mtools-mformat-uninitialized.patch"
 (build-system gnu-build-system)



16/49: gnu: subversion: Update to 1.14.3.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit e57eff3d299c8de654717bfcb56767d0b260d4ff
Author: Andy Tai 
AuthorDate: Wed Jun 12 03:48:48 2024 -0700

gnu: subversion: Update to 1.14.3.

* gnu/packages/version-control.scm (subversion): Update to 1.14.3.

Change-Id: I2d94d32065959d0bcf5b17922af2a62e3f743121
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/version-control.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 8c9b41384c..0e73854fb1 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -2369,14 +2369,14 @@ following features:
 (define-public subversion
   (package
 (name "subversion")
-(version "1.14.2")
+(version "1.14.3")
 (source (origin
   (method url-fetch)
   (uri (string-append "mirror://apache/subversion/"
   "subversion-" version ".tar.bz2"))
   (sha256
(base32
-"0a6csc84hfymm8b5cnvq1n1p3rjjf33qy0z7y1k8lwkm1f6hw4y9"
+"0h54l4p2dlk1rm4zm428hi6ij6xpqxqlqmvkhmz5yhq9392zv7ll"
 (build-system gnu-build-system)
 (arguments
  (list



46/49: gnu: torbrowser: Add bash-minimal.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 836cc6b3fc36e7fcedee296ae6bc995512b8cf2a
Author: Maxim Cournoyer 
AuthorDate: Mon Jun 24 00:36:56 2024 -0400

gnu: torbrowser: Add bash-minimal.

* gnu/packages/tor-browsers.scm (make-torbrowser) [inputs]: Add 
bash-minimal.

Change-Id: I15faf90a0f7d3e1a4032779640a8749fcd9e4dd7
---
 gnu/packages/tor-browsers.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/tor-browsers.scm b/gnu/packages/tor-browsers.scm
index 6be746725d..50f0e9c81f 100644
--- a/gnu/packages/tor-browsers.scm
+++ b/gnu/packages/tor-browsers.scm
@@ -243,6 +243,7 @@ Browser.")
  (list 
go-gitlab-torproject-org-tpo-anti-censorship-pluggable-transports-lyrebird
tor-client
alsa-lib
+   bash-minimal ;for wrap-program
bzip2
cups
dbus-glib



13/49: gnu: sane-backends: Update to 1.3.1.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 7d0a6d3e740b77b1fe58e71970eb0cea91afbc29
Author: Andy Tai 
AuthorDate: Wed Jun 12 04:41:23 2024 -0700

gnu: sane-backends: Update to 1.3.1.

* gnu/packages/scanner.scm (sane-backends-minimal): Update to 1.3.1.

Change-Id: I63a4e744b16b8bbfa18939bd7fbb0ee58a460181
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/scanner.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/scanner.scm b/gnu/packages/scanner.scm
index e26c8a5429..38d5cb7d50 100644
--- a/gnu/packages/scanner.scm
+++ b/gnu/packages/scanner.scm
@@ -106,7 +106,7 @@ WSD and eSCL.")
 (define-public sane-backends-minimal
   (package
 (name "sane-backends-minimal")
-(version "1.2.1")
+(version "1.3.1")
 (source (origin
  (method git-fetch)
  (uri (git-reference
@@ -114,7 +114,7 @@ WSD and eSCL.")
(commit version)))
  (file-name (git-file-name name version))
  (sha256
-  (base32 "1dyipgfn8b8g38iqipy9y1p32p8xyf5sllh4dzhpx54schc4j3hm"))
+  (base32 "1fb6shx9bz0svcyasmyqs93rbbwq7kzg6l0h1zh3kjvcwhchyv72"))
  (modules '((guix build utils)))
  (snippet
   ;; Generated HTML files and udev rules normally embed a



33/49: gnu: openresolv: Update to 3.13.2.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 7971da9e30fefc660dd433d640660da293a843a4
Author: Sergey Trofimov 
AuthorDate: Fri May 24 08:50:22 2024 +0200

gnu: openresolv: Update to 3.13.2.

* gnu/packages/dns.scm (openresolv): Update to 3.13.2.
* gnu/packages/patches/openresolv-restartcmd-guix.patch: Adjust.

Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/dns.scm   | 60 --
 .../patches/openresolv-restartcmd-guix.patch   | 12 ++---
 2 files changed, 39 insertions(+), 33 deletions(-)

diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index bfaeeafe3b..6d0c6a6dca 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -1228,35 +1228,41 @@ and TCP-capable recursive DNS server for finding 
domains on the internet.")
 (define-public openresolv
   (package
 (name "openresolv")
-(version "3.12.0")
-(source (origin
-  (method url-fetch)
-  (uri (string-append 
"https://roy.marples.name/downloads/openresolv/;
-  "openresolv-" version ".tar.xz"))
-  (sha256
-   (base32
-"15qvp5va2yrqpz0ba54clvn8cbc66v4sl7k3bi9ji8jpx040bcs2"))
-  (patches
-   (search-patches "openresolv-restartcmd-guix.patch"
+(version "3.13.2")
+(source
+ (origin
+   (method git-fetch)
+   (uri (git-reference
+ (url "https://github.com/NetworkConfiguration/openresolv;)
+ (commit (string-append "v" version
+   (file-name (git-file-name name version))
+   (sha256
+(base32
+ "03m8n0j0kxxm5kpl66gz4lxr1qqgrp8zlkaq9j8fz27fih0g75xf"))
+   (patches
+(search-patches "openresolv-restartcmd-guix.patch"
 (build-system gnu-build-system)
 (arguments
- `(#:tests? #f  ; No test suite
-   #:configure-flags
-   (list (string-append "--sysconfdir=/etc"))
-   #:make-flags
-   (list (string-append "SYSCONFDIR=/" (assoc-ref %outputs "out") "/etc"))
-   #:phases
-   (modify-phases %standard-phases
- (add-after 'install 'wrap-program
-   (lambda* (#:key inputs outputs #:allow-other-keys)
- (let ((out (assoc-ref outputs "out"))
-   (coreutils (assoc-ref inputs "coreutils-minimal")))
-   (substitute* (string-append out "/sbin/resolvconf")
- (("RESOLVCONF=\"\\$0\"")
-  (format #f "\
-RESOLVCONF=\"$0\"
-PATH=~a/bin:$PATH"
-  coreutils)
+ (list #:tests? #f  ; No test suite
+
+   #:configure-flags
+   #~(list (string-append "--prefix=" #$output:out)
+   "--sysconfdir=/etc"
+   "--rundir=/run")
+
+   #:phases
+   #~(modify-phases %standard-phases
+   (replace 'install
+ (lambda* (#:key make-flags #:allow-other-keys)
+   (apply invoke "make" "install"
+  (string-append "SYSCONFDIR=" #$output "/etc")
+  make-flags)))
+   (add-after 'install 'wrap-program
+ (lambda* (#:key inputs #:allow-other-keys)
+   (substitute* (string-append #$output "/sbin/resolvconf")
+ (("RESOLVCONF=\"\\$0\"")
+  (format #f "RESOLVCONF=\"$0\"\nPATH=~a/bin:$PATH"
+  (assoc-ref inputs "coreutils-minimal")
 (inputs
  (list coreutils-minimal))
 (home-page "https://roy.marples.name/projects/openresolv/;)
diff --git a/gnu/packages/patches/openresolv-restartcmd-guix.patch 
b/gnu/packages/patches/openresolv-restartcmd-guix.patch
index ad70ebd6f2..29a91fe595 100644
--- a/gnu/packages/patches/openresolv-restartcmd-guix.patch
+++ b/gnu/packages/patches/openresolv-restartcmd-guix.patch
@@ -1,4 +1,4 @@
-From 7f0ce36828ec1e130bee857b8236ca091e4d8a2c Mon Sep 17 00:00:00 2001
+From 439266671bbd790b3cb339c157c87db382e85c96 Mon Sep 17 00:00:00 2001
 From: Brice Waegeneire 
 Date: Sat, 9 May 2020 15:52:06 +0200
 Subject: [PATCH] Add RESTARTCMD for Guix System.
@@ -12,13 +12,13 @@ to do it on Guix System by using shepherd.
  1 file changed, 7 insertions(+)
 
 diff --git a/resolvconf.in b/resolvconf.in
-index 3cad04d..5ef5294 100644
+index aa77ffe..921882e 100644
 --- a/resolvconf.in
 +++ b/resolvconf.in
-@@ -369,6 +369,13 @@ detect_init()
-   then
-   /etc/rc.d/$1 restart
+@@ -375,6 +375,13 @@ detect_init()
fi'
+   elif [ -d /etc/dinit.d ] && command -v dinitctl >/dev/null 2>&1; then
+   RESTARTCMD='dinitctl --quiet restart --ignore-unstarted $1'
 +  elif [ -e /gnu/store ] && [ -e /run/current-system/profile ]; then
 +  # Guix System
 +  RESTARTCMD='
@@ -30,5 +30,5 @@ index 3cad04d..5ef5294 100644
 

35/49: gnu: wine, wine64, wine-staging, wine64-staging: Enable wayland support.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 633c0307ea6623f8ac98dd35fe5c8711ebe4343d
Author: Sughosha 
AuthorDate: Tue May 21 16:01:27 2024 +0530

gnu: wine, wine64, wine-staging, wine64-staging: Enable wayland support.

* gnu/packages/wine.scm (wine)[inputs]: Add libxkbcommon, mesa, wayland and
wayland-protocols.

Change-Id: I43bcca457abc9c38941df21db64e867b13260004
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/wine.scm | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/wine.scm b/gnu/packages/wine.scm
index a4a06c495a..35520ee03b 100644
--- a/gnu/packages/wine.scm
+++ b/gnu/packages/wine.scm
@@ -44,6 +44,7 @@
   #:use-module (gnu packages cups)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages fontutils)
+  #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages image)
   #:use-module (gnu packages gettext)
@@ -69,6 +70,7 @@
   #:use-module (gnu packages tls)
   #:use-module (gnu packages video)
   #:use-module (gnu packages vulkan)
+  #:use-module (gnu packages xdisorg)
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (ice-9 match)
@@ -191,11 +193,13 @@ integrate Windows applications into your desktop.")
libxi
libxext
libxcursor
+   libxkbcommon
libxrender
libxrandr
libxinerama
libxxf86vm
libxcomposite
+   mesa
mit-krb5
openal
pulseaudio
@@ -203,7 +207,9 @@ integrate Windows applications into your desktop.")
unixodbc
v4l-utils
vkd3d
-   vulkan-loader))
+   vulkan-loader
+   wayland
+   wayland-protocols))
 (arguments
  (substitute-keyword-arguments (package-arguments wine-minimal)
((#:phases phases)



27/49: doc: contributing: Mention 'guix git authenticate'.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit d19d5447cd28f698190984f6bdcab96af1e20c79
Author: Simon Tournier 
AuthorDate: Tue Jun 4 19:55:54 2024 +0200

doc: contributing: Mention 'guix git authenticate'.

Follow up of 73b3f941d7d911a1b2bb2bf77d37cb3a12ed4291.

* doc/contributing.texi (Applying for Commit Access): Update accordingly 
with
the removal of 'make authenticate'.

Change-Id: Id945c484f6265c76d4eb803369a7fbd9f797434f
Signed-off-by: Maxim Cournoyer 
---
 doc/contributing.texi | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 92bab5b694..880086506f 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -2769,9 +2769,12 @@ git config user.signingkey CABBA6EA1DC0FF33
 To check that commits are signed with correct key, use:
 
 @example
-make authenticate
+guix git authenticate
 @end example
 
+@xref{Building from Git} for running the first authentication of a Guix
+checkout.
+
 To avoid accidentally pushing unsigned or signed with the wrong key
 commits to Savannah, make sure to configure Git according to
 @xref{Configuring Git}.



26/49: gnu: git: Update to 2.45.2.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 26c0ff98cf4302fc69539272d646c0ef28991991
Author: Ashish SHUKLA 
AuthorDate: Wed Jun 5 14:30:18 2024 +

gnu: git: Update to 2.45.2.

* gnu/packages/version-control.scm (git): Update to 2.45.2.

Change-Id: I6bcbc5f0f12a50cbfc0fdc51c30b26e765005d28
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/linux.scm   | 3 ++-
 gnu/packages/version-control.scm | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 4c4bf2aa6b..9097dca085 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -10039,7 +10039,8 @@ headers.")
flex
(@ (gnu packages compression) zip)))
 (inputs
- (list clang-15
+ (list bash-minimal ;for wrap-program
+   clang-15
elfutils
luajit
libbpf
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 0e73854fb1..da02d0e4ea 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -242,14 +242,14 @@ Python 3.3 and later, rather than on Python 2.")
 (define-public git
   (package
(name "git")
-   (version "2.45.1")
+   (version "2.45.2")
(source (origin
 (method url-fetch)
 (uri (string-append "mirror://kernel.org/software/scm/git/git-"
 version ".tar.xz"))
 (sha256
  (base32
-  "1gqj5xrlmzs4amrj7xgxx7qpqj8br8f6bk4bzcnf4yk2iq538kg6"
+  "1nws1vjgj54sv32wxl1h3n1jkcpabqv7a605hhafsby0n5zfigsi"
(build-system gnu-build-system)
(native-inputs
 `(("native-perl" ,perl)
@@ -269,7 +269,7 @@ Python 3.3 and later, rather than on Python 2.")
 version ".tar.xz"))
   (sha256
(base32
-"1w6r2liifafsxydmc48p578z7z70ys0spm6qp5ygdd0l26mxf8p6"
+"1pqrp46kwbxycqld39027ph1cvkq9am156y3sswn6w2khsg30f09"
   ;; For subtree documentation.
   ("asciidoc" ,asciidoc)
   ("docbook2x" ,docbook2x)



47/49: gnu: ucd: Update to 15.1.0.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 8a610b82a9fe4835e846b3593d40118c17ad65e3
Author: Maxim Cournoyer 
AuthorDate: Wed Jun 5 20:46:19 2024 -0400

gnu: ucd: Update to 15.1.0.

* gnu/packages/unicode.scm (ucd): Update to 15.1.0.

Change-Id: I0828544c35eef90a8f76c2084362ee4594189244
---
 gnu/packages/unicode.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/unicode.scm b/gnu/packages/unicode.scm
index 23f08a2aab..fe188ed71d 100644
--- a/gnu/packages/unicode.scm
+++ b/gnu/packages/unicode.scm
@@ -77,14 +77,14 @@ renderer.")
 (define-public ucd
   (package
 (name "ucd")
-(version "15.0.0")
+(version "15.1.0")
 (source
  (origin
(method url-fetch/zipbomb)
(uri (string-append "https://www.unicode.org/Public/zipped/; version
"/UCD.zip"))
(sha256
-(base32 "133inqn33hcfvylmps63yjr6rrqrfq6x7a5hr5fd51z6yc0f9gaz"
+(base32 "0xv10nkvg6451415imvb0qx72ljp0hv9f8h1sl6509ir0lync76b"
 (build-system copy-build-system)
 (arguments
  '(#:install-plan



15/49: gnu: smartmontools: Update to 7.4.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 4965f9314a0574a46d9ed65b00ea7794a8da2a7b
Author: Andy Tai 
AuthorDate: Wed Jun 12 04:28:23 2024 -0700

gnu: smartmontools: Update to 7.4.

* gnu/packages/admin.scm (smartmontools): Update to 7.4.

Change-Id: I43848ea3e9c00827d05e1511b7fe01c491a61b23
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/admin.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 6b9a3d2476..0d484ca9f5 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2812,7 +2812,7 @@ various ways that may be running with too much 
privilege.")
 (define-public smartmontools
   (package
 (name "smartmontools")
-(version "7.3")
+(version "7.4")
 (source (origin
   (method url-fetch)
   (uri (string-append
@@ -2820,7 +2820,7 @@ various ways that may be running with too much 
privilege.")
 version "/smartmontools-" version ".tar.gz"))
   (sha256
(base32
-"0ax2wf5j8k2fbm85s0rbj9sajn5q3j2a2k22wyqcyn0cin0ghi55"
+"0gcrzcb4g7f994n6nws26g6x15yjija1gyzd359sjv7r3xj1z9p9"
 (build-system gnu-build-system)
 (arguments
  (list #:make-flags



05/49: gnu: gauche: Update to 0.9.15.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit a8547a0febbc0a987f02424295699b3506ce8f21
Author: Ashish SHUKLA 
AuthorDate: Sun Jun 23 20:14:27 2024 +0200

gnu: gauche: Update to 0.9.15.

* gnu/packages/scheme.scm (gauche): Update to 0.9.15.

Change-Id: I63da9600fc162c3f9ab02f35c509c7402b7406ca
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/scheme.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 47754800f9..8bf72deb23 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -1085,7 +1085,7 @@ The core is 12 builtin special forms and 33 builtin 
functions.")
 (define-public gauche
   (package
 (name "gauche")
-(version "0.9.12")
+(version "0.9.15")
 (home-page "https://practical-scheme.net/gauche/index.html;)
 (source
  (origin
@@ -1095,7 +1095,7 @@ The core is 12 builtin special forms and 33 builtin 
functions.")
  (string-replace-substring version "." "_")
  "/Gauche-" version ".tgz"))
(sha256
-(base32 "05xnym1phg8i14bacip5d0d3v0gc1nn5mgayd5hnda873f969bml"
+(base32 "10zpbbikkcpdzk6c52wkckiyhn7nhnqjv2djdzyjr0n8qxxy4hrn"
 (build-system gnu-build-system)
 (inputs
  (list libatomic-ops slib zlib))



21/49: build-system: qt: Fix default parallel-tests? value to #t.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit d37614bed19891d322a305d02be61da8aacc0492
Author: Maxim Cournoyer 
AuthorDate: Wed May 29 01:59:15 2024 -0400

build-system: qt: Fix default parallel-tests? value to #t.

There is no reason to have this diverge from the underlying cmake build
system.

* guix/build-system/qt.scm (qt-build) <#:parallel-tests?>: Default to #t.

Change-Id: I65db3d6c6727bd24549af4a44940e7362064aed6
---
 guix/build-system/qt.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/guix/build-system/qt.scm b/guix/build-system/qt.scm
index 978aed0fc1..dc5d65436e 100644
--- a/guix/build-system/qt.scm
+++ b/guix/build-system/qt.scm
@@ -130,7 +130,7 @@
(build-type "RelWithDebInfo")
(tests? #t)
(test-target "test")
-   (parallel-build? #t) (parallel-tests? #f)
+   (parallel-build? #t) (parallel-tests? #t)
(validate-runpath? #t)
(patch-shebangs? #t)
(strip-binaries? #t)



42/49: gnu: opensc: Switch to new package style.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit e121ecccdc5fe3b7422b85db9c3451e29cbac0d1
Author: Timotej Lazar 
AuthorDate: Sat May 18 13:39:38 2024 +0200

gnu: opensc: Switch to new package style.

* gnu/packages/security-token.scm (opensc)[arguments]: Use g-exps.

Change-Id: I3e59323deb804ba98669d51771ccfa05a92723e3
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/security-token.scm | 27 +--
 1 file changed, 13 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index e569d071b8..da2957fe7a 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -366,20 +366,19 @@ website for more information about Yubico and the 
YubiKey.")
 "0yxk97aj29pybvya6r9ix9xh00hdzcfrc2lcns4vb3kwpplamjr3"
 (build-system gnu-build-system)
 (arguments
- `(#:phases
-   (modify-phases %standard-phases
- ;; By setting an absolute path here, we arrange for OpenSC to
- ;; successfully dlopen libpcsclite.so.1 by default.  The user can
- ;; still override this if they want to, by specifying a custom OpenSC
- ;; configuration file at runtime.
- (add-after 'unpack 'set-default-libpcsclite.so.1-path
-   (lambda* (#:key inputs #:allow-other-keys)
- (let ((libpcsclite (search-input-file inputs
-   "/lib/libpcsclite.so.1")))
-   (substitute* "configure"
- (("DEFAULT_PCSC_PROVIDER=\"libpcsclite\\.so\\.1\"")
-  (string-append
-   "DEFAULT_PCSC_PROVIDER=\"" libpcsclite "\"")
+ (list
+  #:phases
+  #~(modify-phases %standard-phases
+  ;; By setting an absolute path here, we arrange for OpenSC to
+  ;; successfully dlopen libpcsclite.so.1 by default.  The user can
+  ;; still override this if they want to, by specifying a custom OpenSC
+  ;; configuration file at runtime.
+  (add-after 'unpack 'set-default-libpcsclite.so.1-path
+(lambda* (#:key inputs #:allow-other-keys)
+  (let ((libpcsclite (search-input-file inputs 
"/lib/libpcsclite.so.1")))
+(substitute* "configure"
+  (("DEFAULT_PCSC_PROVIDER=\"libpcsclite\\.so\\.1\"")
+   (string-append "DEFAULT_PCSC_PROVIDER=\"" libpcsclite 
"\"")
 (inputs
  (list readline openssl-1.1 pcsc-lite ccid))
 (native-inputs



31/49: gnu: guix: Add imagemagick, perl and use full graphviz.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 0fda0486523d67c2c464386c07a0c2800d8d8c20
Author: Maxim Cournoyer 
AuthorDate: Sun May 26 04:26:16 2024 +

gnu: guix: Add imagemagick, perl and use full graphviz.

This makes it possible to run 'make distcheck' in a 'guix shell -D guix'
environment.

* gnu/packages/package-management.scm (guix)
[native-inputs]: Replace graphviz-minimal with graphviz.  Add imagemagick 
and
perl.

Change-Id: Ie400c622d8fc77108df29c03e11f36159d6f6238
---
 gnu/packages/package-management.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/package-management.scm 
b/gnu/packages/package-management.scm
index c70c54bc5a..2b73b849b5 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -490,8 +490,10 @@ $(prefix)/etc/openrc\n")))
("automake" ,automake)
("gettext" ,gettext-minimal)
("texinfo" ,texinfo)
-   ("graphviz" ,graphviz-minimal)
+   ("graphviz" ,graphviz) ;non-minimal for PDF support
("font-ghostscript" ,font-ghostscript) ;fonts for 'dot'
+   ("imagemagick" ,imagemagick) ;for 'make dist'
+   ("perl" ,perl)   ;for 'make dist'
("help2man" ,help2man)
("po4a" ,po4a-minimal)))
   (inputs



17/49: gnu: memcached: Update to 1.6.28.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 7aab18bdf374d6af1a800390210730924e322479
Author: Andy Tai 
AuthorDate: Wed Jun 12 03:03:37 2024 -0700

gnu: memcached: Update to 1.6.28.

* gnu/packages/databases.scm (memcached): Update to 1.6.28.

Change-Id: I9a75ed2794631a8901c4107adb560986595ffb9c
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/databases.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 7854188eb0..624371ccf4 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -527,14 +527,14 @@ mapping from string keys to string values.")
 (define-public memcached
   (package
 (name "memcached")
-(version "1.6.21")
+(version "1.6.28")
 (source
  (origin
(method url-fetch)
(uri (string-append
  "https://memcached.org/files/memcached-; version ".tar.gz"))
(sha256
-(base32 "1vm27la2yanjhwwdwabci4c21yv9hy5iqas47kcxaza1zh79i267"
+(base32 "0ma8qn97hng8vp52s3906g9id75yicf96950hm40zn47k1z2vl5i"
 (build-system gnu-build-system)
 (inputs
  (list libevent cyrus-sasl))



29/49: gnu: exim: Update to 4.97.1.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 2b78b0a253370445a333663cd21e952dd69f2a68
Author: Wilko Meyer 
AuthorDate: Tue May 28 14:45:41 2024 +0200

gnu: exim: Update to 4.97.1.

* gnu/packages/mail.scm (exim): Update to 4.97.1.
  [inputs]: Add perl-file-fcntllock.
  [arguments]: Add fix-perl-file-names phase.

Change-Id: Ide1ba09368c2b23fd8ab6d6cdae8887ccb7edbeb
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/mail.scm | 11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index fe2135a22d..de6d21e7cc 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1975,7 +1975,7 @@ delivery.")
 (define-public exim
   (package
 (name "exim")
-(version "4.96.1")
+(version "4.97.1")
 (source
  (origin
(method url-fetch)
@@ -1989,7 +1989,7 @@ delivery.")
 (string-append "https://ftp.exim.org/pub/exim/exim4/old/;
file-name
(sha256
-(base32 "0g83cxkq3znh5b3r2a3990qxysw7d2l71jwcxaxzvq8pqdahgb4k"
+(base32 "1afzxyffjqm2xm5v6b731hbfm1fi4q35ja45a29kaycsa1bj0y5x"
 (build-system gnu-build-system)
 (arguments
  (list #:phases
@@ -2042,6 +2042,12 @@ delivery.")
(substitute* "scripts/Configure-config.h"
  (("\\| /bin/sh") "| sh"))
(patch-shebang "scripts/Configure-eximon")))
+   (add-before 'build 'fix-perl-file-names
+ (lambda _
+  (substitute* (list  "Local/Makefile"
+  "OS/Makefile-Default")
+(("PERL_COMMAND=/usr/bin/perl")
+ (string-append "PERL_COMMAND=" #$perl "/bin/perl")
(add-before 'build 'build-reproducibly
  (lambda _
;; The ‘compilation number’ increments on every build in the
@@ -2066,6 +2072,7 @@ delivery.")
libxaw
libxt
perl
+   perl-file-fcntllock
xz))
 (home-page "https://www.exim.org/;)
 (synopsis



45/49: doc: Add message for common error about make check-system.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 5f88f71c2d2a77f136747305c981e431a8601eaa
Author: Richard Sent 
AuthorDate: Mon Jun 17 21:02:29 2024 -0400

doc: Add message for common error about make check-system.

* doc/contributing.texi (Running the Test Suite): Mention that make clean-go
may need to be run before running make check-system when previous builds 
were
run with different work trees.

Change-Id: I4b68d3a05f1425505816db969284487d725840d6
Signed-off-by: Maxim Cournoyer 
Fixes: https://issues.guix.gnu.org/47573.
---
 doc/contributing.texi | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 880086506f..178659c26f 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -411,6 +411,20 @@ computationally intensive or rather cheap, depending on 
whether
 substitutes are available for their dependencies (@pxref{Substitutes}).
 Some of them require a lot of storage space to hold VM images.
 
+If you encounter an error like:
+
+@example
+Compiling Scheme modules...
+ice-9/eval.scm:142:16: In procedure compile-top-call:
+error: all-system-tests: unbound variable
+hint: Did you forget `(use-modules (gnu tests))'?
+@end example
+
+@noindent
+there may be inconsistencies in the work tree from previous builds.  To
+resolve this, try running @command{make clean-go} followed by
+@command{make}.
+
 Again in case of test failures, please send @email{bug-guix@@gnu.org}
 all the details.
 



32/49: manifest: Streamline; add packages useful for patch review/submission.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 7f194852a46edfe47537d11bc39fb1dd20e18b37
Author: Maxim Cournoyer 
AuthorDate: Sun May 26 07:53:35 2024 -0400

manifest: Streamline; add packages useful for patch review/submission.

* manifest.scm: Fix alternate command line invocation (which would not
consider 'manifest.scm').  Use specifications instead of packages.  Remove
perl (now in the guix package's native inputs).  Add b4, git, 
git:send-email,
mumi, nss-certs, openssl and patman to the manifest.

Change-Id: I49d92dda059856ce217cea9054a466a1754dcf94
Signed-off-by: Maxim Cournoyer 
---
 manifest.scm | 25 +
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/manifest.scm b/manifest.scm
index 2bc225ead7..7e4d82c3a5 100644
--- a/manifest.scm
+++ b/manifest.scm
@@ -22,18 +22,19 @@
 ;;
 ;; or something like
 ;;
-;; guix shell --pure git git:send-email openssh
-
-(use-modules (guix profiles)
- (gnu packages gnupg)
- (gnu packages perl)
- (gnu packages package-management))
+;; guix shell --pure -m manifest.scm hello ...
 
 (concatenate-manifests
- (list (package->development-manifest guix)
-
-   ;; Extra packages used by make dist.
-   (packages->manifest (list perl))
-
+ (list (package->development-manifest (specification->package "guix"))
;; Extra packages used by unit tests.
-   (packages->manifest (list gnupg
+   (specifications->manifest (list "gnupg"))
+
+   ;; Useful extras for patches submission.
+   (specifications->manifest
+(list "b4"
+  "git"
+  "git:send-email"
+  "mumi"
+  "nss-certs"
+  "openssl"  ;required if using 'smtpEncryption = tls'
+  "patman"



20/49: gnu: torbrowser: Update to 13.0.16 [security fixes].

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 8c80b221475631f31de5d7a73e77a79a44e435f1
Author: André Batista 
AuthorDate: Tue Jun 11 21:50:54 2024 -0300

gnu: torbrowser: Update to 13.0.16 [security fixes].

Fixes CVEs 2024-5702, 2024-5688, 2024-5690, 2024-5691, 2024-5692,
2024-5693, 2024-5696 and 2024-5700. See the Mozilla Foundation Security
advisory 
for details.

* gnu/packages/tor-browsers.scm (%torbrowser-build-date): Update to
2024051019. Change upstream reference to where this date is defined
as the previous URL reference can be missing.
(%torbrowser-version): Update to 13.0.16.
(%torbrowser-firefox-version): Update to 115.12.0esr-13.0-1-build1.
(torbrowser-translation-base): Update to
f28525699864f4e3d764c354130bd898ce5b20aa.
(torbrowser-translation-specific): Update to
b5d79336411e5a59c4861341ef9aa7353e0bcad9.

Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/tor-browsers.scm | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/tor-browsers.scm b/gnu/packages/tor-browsers.scm
index 3312a8398a..6be746725d 100644
--- a/gnu/packages/tor-browsers.scm
+++ b/gnu/packages/tor-browsers.scm
@@ -148,18 +148,18 @@
("02ifa94jfii5f166rwdvv8si3bazm4bcf4qhi59c8f1hxbavb52h" "081aeb1aa308" 
"zh-CN")
("0qx9sh56pqc2x5qrh386cp1fi1gidhcmxxpvqkg9nh2jbizahznr" "9015a180602e" 
"zh-TW")))
 
-;; We copy the official build id, which can be found there:
-;; https://aus1.torproject.org/torbrowser/update_3/release/.
-(define %torbrowser-build-date "2024051015")
+;; We copy the official build id, which is defined at
+;; tor-browser-build/rbm.conf (browser_release_date).
+(define %torbrowser-build-date "2024051019")
 
 ;; To find the last version, look at https://www.torproject.org/download/.
-(define %torbrowser-version "13.0.15")
+(define %torbrowser-version "13.0.16")
 
 ;; To find the last Firefox version, browse
 ;; 
https://archive.torproject.org/tor-package-archive/torbrowser/<%torbrowser-version>
 ;; There should be only one archive that starts with
 ;; "src-firefox-tor-browser-".
-(define %torbrowser-firefox-version "115.11.0esr-13.0-1-build2")
+(define %torbrowser-firefox-version "115.12.0esr-13.0-1-build1")
 
 ;; See tor-browser-build/projects/translation/config.
 (define torbrowser-translation-base
@@ -167,11 +167,11 @@
 (method git-fetch)
 (uri (git-reference
   (url "https://gitlab.torproject.org/tpo/translation.git;)
-  (commit "a28a8b2cb9e207d12fca11181818c0a0694b56af")))
+  (commit "f28525699864f4e3d764c354130bd898ce5b20aa")))
 (file-name "translation-base-browser")
 (sha256
  (base32
-  "159wza7mvz53bjvdj8nnipz9ya5150pymjz5x3jz2qpkz8ansxws"
+  "1vf6nl7fdmlmg2gskf3w1xlsgcm0pxi54z2daz5nwr6q9gyi0lkf"
 
 ;; See tor-browser-build/projects/translation/config.
 (define torbrowser-translation-specific
@@ -179,11 +179,11 @@
 (method git-fetch)
 (uri (git-reference
   (url "https://gitlab.torproject.org/tpo/translation.git;)
-  (commit "e03ffdea5b74ad280616dccd21744cba7b2d4565")))
+  (commit "b5d79336411e5a59c4861341ef9aa7353e0bcad9")))
 (file-name "translation-tor-browser")
 (sha256
  (base32
-  "0d8f9p36wfxbwhiprj6wrzjs4nz8mbaqnqz48rl57x5b82achjd0"
+  "0ahz69pxhgik7ynmdkbnx7v5l2v392i6dswjz057g4hwnd7d34fb"
 
 (define torbrowser-assets
   ;; This is a prebuilt Torbrowser from which we take the assets we need.
@@ -199,7 +199,7 @@
  version "/tor-browser-linux-x86_64-" version ".tar.xz"))
(sha256
 (base32
- "1rd4m8bg359yj2w5dfvmnnjgr79bx1cc9bkziwzxnyz5zjn0arkv"
+ "1kffam66bsaahzx212hw9lb03jwfr24hivzg067iyzilsldpc9c1"
 (arguments
  (list
   #:install-plan
@@ -237,7 +237,7 @@ Browser.")
  ".tar.xz"))
(sha256
 (base32
- "0z2sz42jjfcd99zmysvz9k03zk9nccygba53rvkhbskcvil5zgjd"
+ "1b70zyjyai6kk4y1kkl8jvrs56gg7z31kkad6bmdpd8jw4n71grx"
 (build-system mozilla-build-system)
 (inputs
  (list 
go-gitlab-torproject-org-tpo-anti-censorship-pluggable-transports-lyrebird



23/49: gnu: grub: Remove input labels and use gexps.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit b9c38f26f120e3e12b3bfbf29c6248a08fe1a62c
Author: Ludovic Courtès 
AuthorDate: Mon Jun 3 22:01:23 2024 +0200

gnu: grub: Remove input labels and use gexps.

* gnu/packages/bootloaders.scm (grub)[arguments]: Use gexps.
[inputs, native-inputs]: Remove labels.
(grub-minimal, grub-coreboot, grub-efi, grub-efi32)
(grub-hybrid): Likewise.

Change-Id: I2773e6d96d170fae991d9c5db9e10196ea603371
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/bootloaders.scm | 532 +--
 1 file changed, 264 insertions(+), 268 deletions(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 4e932ee328..503c7d4a19 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -128,140 +128,140 @@
  (("exit 99") "exit 77"))
 (build-system gnu-build-system)
 (arguments
- `(#:configure-flags
-   ;; Counterintuitively, this *disables* a spurious Python dependency by
-   ;; calling the ‘true’ binary instead.  Python is only needed during
-   ;; bootstrapping (for genptl.py), not when building from a release.
-   (list "PYTHON=true")
-   ;; Grub fails to load modules stripped with --strip-unneeded.
-   #:strip-flags '("--strip-debug" "--enable-deterministic-archives")
-   #:phases
-   (modify-phases %standard-phases
- (add-after 'unpack 'patch-stuff
-   (lambda* (#:key native-inputs inputs #:allow-other-keys)
- (substitute* "grub-core/Makefile.in"
-   (("/bin/sh") (which "sh")))
-
- ;; Give the absolute file name of 'mdadm', used to determine the
- ;; root file system when it's a RAID device.  Failing to do that,
- ;; 'grub-probe' silently fails if 'mdadm' is not in $PATH.
- (when (assoc-ref inputs "mdadm")
-   (substitute* "grub-core/osdep/linux/getroot.c"
- (("argv\\[0\\] = \"mdadm\"")
-  (string-append "argv[0] = \""
- (assoc-ref inputs "mdadm")
- "/sbin/mdadm\""
-
- ;; Make the font visible.
- (copy-file (assoc-ref (or native-inputs inputs)
-   "unifont")
-"unifont.bdf.gz")
- (system* "gunzip" "unifont.bdf.gz")
-
- ;; Give the absolute file name of 'ckbcomp'.
- (substitute* "util/grub-kbdcomp.in"
-   (("^ckbcomp ")
-(string-append
- (search-input-file inputs "/bin/ckbcomp")
- " ")
- (add-after 'unpack 'set-freetype-variables
-   ;; These variables need to be set to the native versions of the
-   ;; dependencies because they are used to build programs which are
-   ;; executed during build time.
-   (lambda* (#:key native-inputs #:allow-other-keys)
- (when (assoc-ref native-inputs "freetype")
-   (let ((freetype (assoc-ref native-inputs "freetype")))
- (setenv "BUILD_FREETYPE_LIBS"
- (string-append "-L" freetype
-"/lib -lfreetype"))
- (setenv "BUILD_FREETYPE_CFLAGS"
- (string-append "-I" freetype
-"/include/freetype2"))
- (add-before 'check 'disable-flaky-test
-   (lambda _
- ;; This test is unreliable. For more information, see:
- ;; .
- (substitute* "Makefile.in"
-   (("grub_cmd_date grub_cmd_set_date grub_cmd_sleep")
-"grub_cmd_date grub_cmd_sleep"
- (add-before 'check 'disable-pixel-perfect-test
-   (lambda _
- ;; This test compares many screenshots rendered with an older
- ;; Unifont (9.0.06) than that packaged in Guix.
- (substitute* "Makefile.in"
-   (("test_unset grub_func_test")
-"test_unset")
-   ;; Disable tests on ARM and AARCH64 platforms or when cross-compiling.
-   #:tests? ,(not (or (any (cute string-prefix? <> (or 
(%current-target-system)
-   (%current-system)))
-   '("arm" "aarch64"))
-  (%current-target-system)
+ (list #:configure-flags
+   ;; Counterintuitively, this *disables* a spurious Python dependency 
by
+   ;; calling the ‘true’ binary instead.  Python is only needed during
+   ;; bootstrapping (for genptl.py), not when building from a release.
+   #~(list "PYTHON=true")
+
+   ;; GRUB fails to load modules stripped with --strip-unneeded.
+   #:strip-flags
+   #~(list "--strip-debug" 

25/49: gnu: python-pulsectl: Update to 24.4.0.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 53861af06dc29c6d82b453755ad930c6507012ae
Author: Sergiu Ivanov 
AuthorDate: Wed May 29 19:23:07 2024 +0100

gnu: python-pulsectl: Update to 24.4.0.

* gnu/packages/audio.scm (python-pulsectl): Update to 24.4.0.

Change-Id: I63f43377432d511dea7ffa6b235f8bcc770f1d93
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/audio.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index fcb3ceed8a..ebc1af7b75 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2964,13 +2964,13 @@ cross-platform audio input/output stream library.")
 (define-public python-pulsectl
   (package
 (name "python-pulsectl")
-(version "22.3.2")
+(version "24.4.0")
 (source (origin
   (method url-fetch)
   (uri (pypi-uri "pulsectl" version))
   (sha256
(base32
-"115ha1cwpd2r84ssnxdbr59hgs0jbx0lz3xpqli64kmxxqf4w5yc"
+"0r9igs365cqgrn1m55a8qjz0hc446nwjm3p3i9kphbj5gl7dazk9"
 (build-system python-build-system)
 (inputs (list pulseaudio))
 (arguments



01/49: gnu: bcc: Update to 0.30.0, fixing build.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 08149c02bc3a0c55229d63a372e211d6e1d31a18
Author: Maxim Cournoyer 
AuthorDate: Sat Jun 22 22:18:26 2024 -0400

gnu: bcc: Update to 0.30.0, fixing build.

* gnu/packages/linux.scm (bcc): Update to 0.30.0.
[native-inputs]: Add zip.
[inputs] Remove labels.  Remove stale comment (our libelf package has a 
static
archive, but the build still fails using it).  Replace the libbpf source 
with
its binary package.  Replace clang-toolchain-9 with clang-15.  Add
bash-minimal.
[arguments]: Use gexps.
: Add -DCMAKE_USE_LIBBPF_PACKAGE=ON.
: Remove copy-libbpf.

Change-Id: Ife0bec7802e7faa54689c0199bc2618ce6a39428
---
 gnu/packages/linux.scm | 100 ++---
 1 file changed, 45 insertions(+), 55 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index fc2e5b15a6..d259d6fddc 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -10021,7 +10021,7 @@ headers.")
 (define-public bcc
   (package
 (name "bcc")
-(version "0.24.0")
+(version "0.30.0")
 (source
  (origin
(method git-fetch)
@@ -10031,63 +10031,53 @@ headers.")
(file-name (git-file-name name version))
(sha256
 (base32
- "1i6xikkxf2nasfkqa91hjzdq0a88mgyzrvia4fi2i2v1d8pbmnp4"
+ "0b5la0yn6x6ll73drnrm5v5yibbrzkvl86hqivkrmnpgy8cqn0cy"
 (build-system cmake-build-system)
 (native-inputs
- (list bison flex))
+ (list bison
+   flex
+   (@ (gnu packages compression) zip)))
 (inputs
- `(("clang-toolchain" ,clang-toolchain-9)
-   ("libbpf" ,(package-source libbpf))
-   ;; LibElf required but libelf does not contain
-   ;; archives, only object files.
-   ;; https://github.com/iovisor/bcc/issues/504
-   ("elfutils" ,elfutils)
-   ("luajit" ,luajit)
-   ("python-wrapper" ,python-wrapper)))
-(arguments
- `(;; Tests all require root permissions and a "standard" file hierarchy.
-   #:tests? #f
-   #:configure-flags
-   (let ((revision ,version))
- `(,(string-append "-DREVISION=" revision)))
-   #:phases
-   (modify-phases %standard-phases
- ;; FIXME: Use "-DCMAKE_USE_LIBBPF_PACKAGE=ON".
- (add-after 'unpack 'copy-libbpf
-   (lambda* (#:key inputs #:allow-other-keys)
- (delete-file-recursively "src/cc/libbpf")
- (copy-recursively
-  (assoc-ref inputs "libbpf") "src/cc/libbpf")))
- (add-after 'copy-libbpf 'substitute-libbc
-   (lambda* (#:key outputs #:allow-other-keys)
- (substitute* "src/python/bcc/libbcc.py"
-   (("(libbcc\\.so.*)\\b" _ libbcc)
-(string-append
- (assoc-ref outputs "out") "/lib/" libbcc)
- (add-after 'install 'wrap-tools
-   (lambda* (#:key outputs #:allow-other-keys)
- (use-modules (ice-9 textual-ports))
- (let* ((out (assoc-ref outputs "out"))
-(lib (string-append out "/lib"))
-(tools (string-append out "/share/bcc/tools"))
-(python-executable?
- (lambda (filename _)
-   (call-with-input-file filename
- (lambda (port)
-   (string-contains (get-line port)
-"/bin/python"))
-   (for-each
-(lambda (python-executable)
-  (format #t "Wrapping: ~A.~%" python-executable)
-  (wrap-program python-executable
-`("GUIX_PYTHONPATH" ":" prefix
-  (,(string-append lib
-   "/python"
-   ,(version-major+minor
- (package-version python))
-   "/site-packages")
-(find-files tools python-executable?))
-   #t))
+ (list clang-15
+   elfutils
+   luajit
+   libbpf
+   python-wrapper))
+(arguments
+ (list
+  ;; Tests all require root permissions and a "standard" file hierarchy.
+  #:tests? #f
+  #:configure-flags #~(list (string-append "-DREVISION=" #$version)
+"-DCMAKE_USE_LIBBPF_PACKAGE=ON")
+  #:phases
+  #~(modify-phases %standard-phases
+  (add-after 'unpack 'substitute-libbc
+(lambda _
+  (substitute* "src/python/bcc/libbcc.py"
+(("(libbcc\\.so.*)\\b" _ libbcc)
+ (string-append #$output "/lib/" libbcc)
+  (add-after 'install 'wrap-tools
+(lambda _
+  (use-modules (ice-9 textual-ports))
+  (let* ((out #$output)
+ (lib (string-append out "/lib"))
+ 

03/49: doc: Fix Reviewed-by format.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 603d523fc321514fa01d56fe4a96fbc2f9268343
Author: Tomas Volf <~@wolfsden.cz>
AuthorDate: Thu Jun 20 23:40:56 2024 +0200

doc: Fix Reviewed-by format.

The documentation does not have a space between `e' and `<', which is not 
how
people use it, as can be seen from git log.  So adjust the format to match 
the
reality.

* doc/contributing.texi (Reviewing the Work of Others): Fix format for
Reviewed-by.

Change-Id: Ib863536db72b885cf34927323cb4ebc52a8db2ed
Signed-off-by: Maxim Cournoyer 
---
 doc/contributing.texi | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 938c8bfdb1..92bab5b694 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -2946,7 +2946,7 @@ account the submitter's motivation for doing things in a 
certain way.
 @cindex Reviewed-by, git trailer
 When you deem the proposed change adequate and ready for inclusion
 within Guix, the following well understood/codified
-@samp{Reviewed-by:@tie{}Your@tie{}Name}
+@samp{Reviewed-by:@tie{}Your@tie{}Name@tie{}}
 @footnote{The @samp{Reviewed-by} Git trailer is used by other projects
 such as Linux, and is understood by third-party tools such as the
 @samp{b4 am} sub-command, which is able to retrieve the complete
@@ -2958,7 +2958,8 @@ looks good to you:
 @itemize
 @item
 If the @emph{whole} series (containing multiple commits) looks good to
-you, reply with 
@samp{Reviewed-by:@tie{}Your@tie{}Name}
+you, reply with
+@samp{Reviewed-by:@tie{}Your@tie{}Name@tie{}}
 to the cover page if it has one, or to the last patch of the series
 otherwise, adding another @samp{(for the whole series)} comment on the
 line below to explicit this fact.
@@ -2966,8 +2967,8 @@ line below to explicit this fact.
 @item
 If you instead want to mark a @emph{single commit} as reviewed (but not
 the whole series), simply reply with
-@samp{Reviewed-by:@tie{}Your@tie{}Name} to that
-commit message.
+@samp{Reviewed-by:@tie{}Your@tie{}Name@tie{}}
+to that commit message.
 @end itemize
 
 If you are not a committer, you can help others find a @emph{series} you



09/49: services: networking: Allow dhcp-client to use a config file.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit b539e5ae3995b554cd5557274a4d95ba0618a3fd
Author: Richard Sent 
AuthorDate: Mon Jun 17 20:49:12 2024 -0400

services: networking: Allow dhcp-client to use a config file.

* gnu/services/networking.scm (dhcp-client-configuration) [config-file]: New
field.
(dhcp-client-configuration-config-file): New accessor.
(dhcp-client-shepherd-service): Use the config file when invoking
dhclient if supplied.
* doc/guix.texi: Document it.

Change-Id: I286de4ddf59c5e606bf1fe0a7510570869e62b1a
Signed-off-by: Maxim Cournoyer 
---
 doc/guix.texi   |  3 +++
 gnu/services/networking.scm | 15 +--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 9bbf85e32b..c35e10d877 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -21035,6 +21035,9 @@ When set to @code{'all}, the DHCP client listens on all 
the available
 non-loopback interfaces that can be activated.  Otherwise the DHCP
 client listens only on the specified interfaces.
 
+@item @code{config-file} (default: @code{#f})
+The configuration file for the DHCP client.
+
 @item @code{shepherd-requirement} (default: @code{'()})
 @itemx @code{shepherd-provision} (default: @code{'(networking)})
 This option can be used to provide a list of symbols naming Shepherd services
diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 378e117a86..12d8934e43 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -91,6 +91,7 @@
 dhcp-client-configuration?
 dhcp-client-configuration-package
 dhcp-client-configuration-interfaces
+dhcp-client-configuration-config-file
 dhcp-client-configuration-shepherd-provision
 dhcp-client-configuration-shepherd-requirement
 
@@ -319,6 +320,8 @@
 (default '()))
   (shepherd-provision   dhcp-client-configuration-shepherd-provision
 (default '(networking)))
+  (config-file dhcp-client-configuration-config-file
+   (default #f))
   (interfaces   dhcp-client-configuration-interfaces
 (default 'all)))  ;'all | list of strings
 
@@ -329,6 +332,7 @@
(requirement (dhcp-client-configuration-shepherd-requirement 
config))
(provision (dhcp-client-configuration-shepherd-provision config))
(interfaces (dhcp-client-configuration-interfaces config))
+   (config-file (dhcp-client-configuration-config-file config))
(pid-file "/var/run/dhclient.pid"))
(list (shepherd-service
   (documentation "Set up networking via DHCP.")
@@ -364,6 +368,11 @@
(_
 #~'#$interfaces
 
+ (define config-file-args
+   (if #$config-file
+   (list "-cf" #$config-file)
+   '()))
+
  (false-if-exception (delete-file #$pid-file))
  (let ((pid (fork+exec-command
  ;; By default dhclient uses a
@@ -371,8 +380,10 @@
  ;; DDNS, which is incompatable with
  ;; non-ISC DHCP servers; thus, pass '-I'.
  ;; .
- (cons* dhclient "-nw" "-I"
-"-pf" #$pid-file ifaces
+ `(,dhclient "-nw" "-I"
+ "-pf" ,#$pid-file
+ ,@config-file-args
+ ,@ifaces
(and (zero? (cdr (waitpid pid)))
 (read-pid-file #$pid-file)
   (stop #~(make-kill-destructor))



24/49: gnu: volctl: Update to 0.9.4.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 81c2355d9c315fc2156b17673bc4d830d1e433e0
Author: Sergiu Ivanov 
AuthorDate: Wed May 29 19:29:42 2024 +0100

gnu: volctl: Update to 0.9.4.

* gnu/packages/gtk.scm (volctl): Update to 0.9.4.

Change-Id: I70e85592405d574b692398e6d71d235219fb6fe9
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/gtk.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 1c78a969f6..56763cd835 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -2904,7 +2904,7 @@ user interaction (e.g.  measuring distances).")
 (define-public volctl
   (package
 (name "volctl")
-(version "0.9.3")
+(version "0.9.4")
 (source (origin
   (method git-fetch)
   (uri (git-reference (url "https://github.com/buzz/volctl;)
@@ -2912,7 +2912,7 @@ user interaction (e.g.  measuring distances).")
   (file-name (git-file-name name version))
   (sha256
(base32
-"0fz80w3ywq54jn4v31frfdj01s5g9lz6v9cd7hpg3kirca0zisln"
+"0anrwz8rvbliskmcgpw2zabgjj5c72hpi7cf0jg05vvmlpnbsd4g"
 (build-system python-build-system)
 (arguments
  `(#:phases



04/49: services: mpd: Fix log to file.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 2455c4ded9ff7b44acfb3497963590792657dc2b
Author: Yarl Baudig 
AuthorDate: Sun Jun 23 16:15:58 2024 +0200

services: mpd: Fix log to file.

(match value (%unset-value ...)) is equivalent here to
(match value (_ ...)). Even if you set 'log-file to some path, it's always
"syslog" in the configuration file.

* gnu/services/audio.scm (mpd): Fix buggy 'match'.

Signed-off-by: Maxim Cournoyer 
Change-Id: If397919c2844d856c69fe00b8907b7b3fd86e564
---
 gnu/services/audio.scm | 18 --
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index ae991ced4d..5d2cd56a17 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -251,16 +251,14 @@ user-group instead~%"))
  (configuration-field-error #f 'group value
 
 (define (mpd-log-file-sanitizer value)
-  (match value
-(%unset-value
- ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is
- ;; supposed to cause logging to happen via systemd (elogind provides a
- ;; compatible interface), this doesn't work (nothing gets logged); use
- ;; syslog instead.
- "syslog")
-((? string?)
- value)
-(_ (configuration-field-error #f 'log-file value
+  ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is
+  ;; supposed to cause logging to happen via systemd (elogind provides a
+  ;; compatible interface), this doesn't work (nothing gets logged); use
+  ;; syslog instead.
+  (let ((value (maybe-value value "syslog")))
+(if (string? value)
+value
+(configuration-field-error #f 'log-file value
 
 ;;;
 



07/49: gnu: isc-bind: Update to 9.19.24.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 51aee1784dfa1c8a1885cb7fdc2c48db4b860256
Author: Wilko Meyer 
AuthorDate: Fri Jun 21 16:20:26 2024 +0200

gnu: isc-bind: Update to 9.19.24.

* gnu/packages/dns.scm (isc-bind): Update to 9.19.24.

Change-Id: I0fc1128191dbda349ac27a9d1b7bf67b59caac39
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/dns.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/dns.scm b/gnu/packages/dns.scm
index 68fc5b9d1d..bfaeeafe3b 100644
--- a/gnu/packages/dns.scm
+++ b/gnu/packages/dns.scm
@@ -337,14 +337,14 @@ and BOOTP/TFTP for network booting of diskless machines.")
 ;; When updating, check whether isc-dhcp's bundled copy should be as well.
 ;; The BIND release notes are available here:
 ;; https://www.isc.org/bind/
-(version "9.19.21")
+(version "9.19.24")
 (source
  (origin
(method url-fetch)
(uri (string-append "https://ftp.isc.org/isc/bind9/; version
"/bind-" version ".tar.xz"))
(sha256
-(base32 "133f1aq8acaz9z03cl0gcrj4pq0hqm6c3sm4hz67d37phndsjs1b"
+(base32 "171668qgjvf257m3r04lxmbsiz9lnn57djnlmn8plh1lj77fw3nh"
 (build-system gnu-build-system)
 (outputs `("out" "utils"))
 (inputs



38/49: gnu: godot-lts: Update to 3.5.3.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 7f1c40df92abcbe7a6e6da8592917b716db59c97
Author: Nicolas Graves 
AuthorDate: Sun May 19 18:16:05 2024 +0200

gnu: godot-lts: Update to 3.5.3.

* gnu/packages/game-development.scm (godot-lts): Update to 3.5.3.
  [arguments]<#:scons>: Update to scons-python. Remove argument.
  <#:phases>: Rename phase 'wrap to 'wrap-ld-path, remove mesa-related
  comment that seems to be fixed.
  [inputs]: Replace freetype by freetype-with-brotli.

Change-Id: Ia83bc33bd0b944342ba413b46f0963d3f2197bf5
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/game-development.scm | 22 --
 1 file changed, 8 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/game-development.scm 
b/gnu/packages/game-development.scm
index 184a0d8e65..e64dcaac65 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -1927,7 +1927,7 @@ games.")
 (define-public godot-lts
   (package
 (name "godot")
-(version "3.4.2")
+(version "3.5.3")
 (source (origin
   (method git-fetch)
   (uri (git-reference
@@ -1936,7 +1936,7 @@ games.")
   (file-name (git-file-name name version))
   (sha256
(base32
-"1bm9yl995chvx6jwkdia12yjrgwcpzb1r9bmj606q8z264aw2ma5"))
+"0zibc6am9axbbm8l57jf2d324a2m44pf6ncp2i4h1b219jjq89l6"))
   (modules '((guix build utils)
  (ice-9 ftw)
  (srfi srfi-1)))
@@ -1948,7 +1948,6 @@ games.")
   (with-directory-excursion "thirdparty"
 (let* ((preserved-files
 '("README.md"
-  "assimp"
   "certs"
   "cvtt"
   "embree"
@@ -1966,6 +1965,7 @@ games.")
   "oidn"
   "pvrtccompressor"
   "recastnavigation"
+  "rvo2"
   "squish"
   "stb_rect_pack"
   "tinyexr"
@@ -1977,8 +1977,7 @@ games.")
  (cons* "." ".." 
preserved-files)
 (build-system scons-build-system)
 (arguments
- `(#:scons ,scons-python2
-   #:scons-flags (list "platform=x11" "target=release_debug"
+ `(#:scons-flags (list "platform=x11" "target=release_debug"
;; Avoid using many of the bundled libs.
;; Note: These options can be found in the 
SConstruct file.
"builtin_bullet=no"
@@ -2032,18 +2031,13 @@ games.")
;; Tell the editor where to find zenity for OS.alert().
(wrap-program (string-append out "/bin/godot")
  `("PATH" ":" prefix (,(string-append zenity "/bin")))
- (add-after 'install 'wrap
+ (add-after 'install 'wrap-ld-path
(lambda* (#:key inputs outputs #:allow-other-keys)
- ;; FIXME: Mesa tries to dlopen libudev.so.0 and fails.  Pending a
- ;; fix of the mesa package we wrap the pcb executable such that
- ;; Mesa can find libudev.so.0 through LD_LIBRARY_PATH.
- ;; also append ld path for pulseaudio and alsa-lib
  (let* ((out (assoc-ref outputs "out"))
-(udev_path (string-append (assoc-ref inputs "eudev") 
"/lib"))
 (pulseaudio_path (string-append (assoc-ref inputs 
"pulseaudio") "/lib"))
 (alas_lib_path (string-append (assoc-ref inputs 
"alsa-lib") "/lib")))
(wrap-program (string-append out "/bin/godot")
- `("LD_LIBRARY_PATH" ":" prefix (,udev_path ,pulseaudio_path 
,alas_lib_path))
+ `("LD_LIBRARY_PATH" ":" prefix (,pulseaudio_path 
,alas_lib_path))
  (add-after 'install 'install-godot-desktop
(lambda* (#:key outputs #:allow-other-keys)
  (let* ((out (assoc-ref outputs "out"))
@@ -2064,7 +2058,7 @@ games.")
 (inputs
  (list alsa-lib
bullet
-   freetype
+   freetype-with-brotli
glew
glu
libtheora
@@ -2081,7 +2075,7 @@ games.")
opusfile
pcre2
pulseaudio
-   eudev; FIXME: required by mesa
+   eudev
wslay
zenity
`(,zstd "lib")))



10/49: doc: Prepend ISC to DHCP client references.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit ff9942dcc1d719b9acea4953e226659491306e27
Author: Richard Sent 
AuthorDate: Mon Jun 17 20:49:13 2024 -0400

doc: Prepend ISC to DHCP client references.

This makes it clearer that this service uses the ISC's dhclient 
implementation
and does not support DHCP clients that have different command line 
interfaces.

* doc/guix.texi (Networking Setup): Prepend ISC to all DHCP client 
references.

Change-Id: I750ef2ffb4b23445c4a2b97aaa44eba56458f430
Signed-off-by: Maxim Cournoyer 
---
 doc/guix.texi | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index c35e10d877..6257de7583 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -21016,27 +21016,27 @@ the user mode network stack,,, qemu, QEMU 
Documentation}).
 
 @cindex DHCP, networking service
 @defvar dhcp-client-service-type
-This is the type of services that run @var{dhcp}, a Dynamic Host Configuration
-Protocol (DHCP) client.
+This is the type of services that run @var{dhclient}, the ISC Dynamic
+Host Configuration Protocol (DHCP) client.
 @end defvar
 
 @deftp {Data Type} dhcp-client-configuration
-Data type representing the configuration of the DHCP client service.
+Data type representing the configuration of the ISC DHCP client service.
 
 @table @asis
 @item @code{package} (default: @code{isc-dhcp})
-DHCP client package to use.
+The ISC DHCP client package to use.
 
 @item @code{interfaces} (default: @code{'all})
-Either @code{'all} or the list of interface names that the DHCP client
-should listen on---e.g., @code{'("eno1")}.
+Either @code{'all} or the list of interface names that the ISC DHCP
+client should listen on---e.g., @code{'("eno1")}.
 
-When set to @code{'all}, the DHCP client listens on all the available
-non-loopback interfaces that can be activated.  Otherwise the DHCP
-client listens only on the specified interfaces.
+When set to @code{'all}, the ISC DHCP client listens on all the
+available non-loopback interfaces that can be activated.  Otherwise the
+ISC DHCP client listens only on the specified interfaces.
 
 @item @code{config-file} (default: @code{#f})
-The configuration file for the DHCP client.
+The configuration file for the ISC DHCP client.
 
 @item @code{shepherd-requirement} (default: @code{'()})
 @itemx @code{shepherd-provision} (default: @code{'(networking)})
@@ -21047,7 +21047,7 @@ networks.
 
 Likewise, @code{shepherd-provision} is a list of Shepherd service names
 (symbols) provided by this service.  You might want to change the
-default value if you intend to run several DHCP clients, only one of
+default value if you intend to run several ISC DHCP clients, only one of
 which provides the @code{networking} Shepherd service.
 @end table
 @end deftp



12/49: gnu: nginx: Update to 1.27.0.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit cd15d417e30597b131aa00cea0aaa78a36cc74a6
Author: Andy Tai 
AuthorDate: Mon Jun 17 22:52:32 2024 -0700

gnu: nginx: Update to 1.27.0.

* gnu/packages/web.scm (nginx): Update to 1.27.0.
  (nginx-documentation): Update to 1.27.0.
  (nginx-accept-language-module)[arguments]: Add configure flags
  to enable compatibility and fix build.

Change-Id: I447e0bb8677d3f3b14c3a8948c625bcad437ca73
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/web.scm | 15 ---
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 38f86c4d33..7f9c63ad18 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -510,14 +510,14 @@ the same, being completely separated from the Internet.")
 ;; Track the ‘mainline’ branch.  Upstream considers it more reliable than
 ;; ’stable’ and recommends that “in general you deploy the NGINX mainline
 ;; branch at all times” 
(https://www.nginx.com/blog/nginx-1-6-1-7-released/)
-(version "1.23.3")
+(version "1.27.0")
 (source (origin
   (method url-fetch)
   (uri (string-append "https://nginx.org/download/nginx-;
   version ".tar.gz"))
   (sha256
(base32
-"0m5s8a04jlpv6qhk09sfqbj4rxj38g6923w12j5y3ymrvf3mgjvm"
+"170ja338zh7wdyva34cr7f3wfq59434sssn51d5jvakyz0y0w8xp"
 (build-system gnu-build-system)
 (inputs (list libxml2 libxslt openssl pcre zlib))
 (arguments
@@ -607,9 +607,9 @@ and as a proxy to reduce the load on back-end HTTP or mail 
servers.")
 
 (define-public nginx-documentation
   ;; This documentation should be relevant for the current nginx package.
-  (let ((version "1.23.3")
-(revision 2916)
-(changeset "178f55cf631a"))
+  (let ((version "1.27.0")
+(revision 3081)
+(changeset "1b23e39a3b94"))
 (package
   (name "nginx-documentation")
   (version (simple-format #f "~A-~A-~A" version revision changeset))
@@ -621,7 +621,7 @@ and as a proxy to reduce the load on back-end HTTP or mail 
servers.")
(file-name (string-append name "-" version))
(sha256
 (base32
- "0b03dnniwm3p3gd76vqs6lj2z4blqmb7y4lhn9vg7xjz0yqgzvn2"
+ "0xnfda8xh8mv00fsycqbwicm8bb7rsvdqmmwv0h372kiwxnazjkh"
   (build-system gnu-build-system)
   (arguments
'(#:tests? #f; no test suite
@@ -631,7 +631,7 @@ and as a proxy to reduce the load on back-end HTTP or mail 
servers.")
(replace 'build
  (lambda* (#:key outputs #:allow-other-keys)
(let ((output (assoc-ref outputs "out")))
- (substitute* "umasked.sh"
+ (substitute* "tools/umasked.sh"
((" /bin/sh") (string-append " " (which "sh"
  ;; The documentation includes a banner, which makes sense on
  ;; the NGinx website, but doesn't make much sense when
@@ -733,6 +733,7 @@ ngx_http_accept_language_module~%")
"--with-http_v2_module"
"--with-pcre-jit"
"--with-debug"
+   "--with-compat"
;; Even when not cross-building, we pass the
;; --crossbuild option to avoid customizing for the
;; kernel version on the build machine.



11/49: gnu: astyle: Update to 3.5.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 0fe46e53bbd7e190c3e757fb842cd3e45e73f4e8
Author: Artyom V. Poptsov 
AuthorDate: Thu Jun 13 21:54:05 2024 +0300

gnu: astyle: Update to 3.5.

* gnu/packages/code.scm (astyle): Update to 3.5.
  [source]: Change source archive file name to match the upstream.
  [arguments]: Remove "modules".  Add "patch-makefile" phase to set
  the C++ compiler to version c++17 as it is required for the build.
  Simplify "install-more" file.

Change-Id: I810d723d22320c288c331645f8d61d5e640e
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/code.scm | 28 ++--
 1 file changed, 10 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/code.scm b/gnu/packages/code.scm
index d6ac8178f3..44edf43db5 100644
--- a/gnu/packages/code.scm
+++ b/gnu/packages/code.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2023 Fries 
 ;;; Copyright © 2023 Zheng Junjie <873216...@qq.com>
 ;;; Copyright © 2024 Sharlatan Hellseher 
+;;; Copyright © 2024 Artyom V. Poptsov 
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -823,14 +824,14 @@ Objective@tie{}C, D, Java, Pawn, and Vala).  Features:
 (define-public astyle
   (package
 (name "astyle")
-(version "3.4.8")
+(version "3.5")
 (source
  (origin
(method url-fetch)
(uri (string-append "mirror://sourceforge/astyle/astyle/astyle%20"
-   version "/astyle_"  version "_linux.tar.gz"))
+   version "/astyle-"  version ".tar.bz2"))
(sha256
-(base32 "1ms54wcs7hg1bsywqwf2lhdfizgbk7qxc9ghasxk8i99jvwlrk6b"
+(base32 "0g4jyp47iz97ld9ac4wb5k59j4cs8dbw4dp8f32bwqx8pyvirz6y"
 (build-system gnu-build-system)
 (arguments
  (list
@@ -839,11 +840,13 @@ Objective@tie{}C, D, Java, Pawn, and Vala).  Features:
   #~(list (string-append "prefix=" #$output)
   "INSTALL=install"
   "release" "shared")
-  #:modules '((guix build gnu-build-system) ;FIXME use %default-modules
-  (guix build utils)
-  (ice-9 regex))
   #:phases
   #~(modify-phases %standard-phases
+  (add-after 'unpack 'patch-makefile
+(lambda _
+  (substitute* "build/gcc/Makefile"
+(("CBASEFLAGS = -Wall -Wextra -fno-rtti -fno-exceptions 
-std=c\\+\\+11")
+ "CBASEFLAGS = -Wall -Wextra -fno-rtti -fno-exceptions 
-std=c++17"
   (replace 'configure
 (lambda _
   (chdir "build/gcc")))
@@ -852,12 +855,6 @@ Objective@tie{}C, D, Java, Pawn, and Vala).  Features:
   ;; Libraries and headers aren't installed by default.
   (let ((include (string-append #$output "/include"))
 (lib (string-append #$output "/lib")))
-(define (link.so file strip-pattern)
-  (symlink
-   (basename file)
-   (regexp-substitute #f
-  (string-match strip-pattern file)
-  'pre)))
 (mkdir-p include)
 (copy-file "../../src/astyle.h"
(string-append include "/astyle.h"))
@@ -865,12 +862,7 @@ Objective@tie{}C, D, Java, Pawn, and Vala).  Features:
 (for-each (lambda (l)
 (copy-file
  l (string-append lib "/" (basename l
-  (find-files "bin" "^lib.*\\.so"))
-(for-each
- (lambda (file)
-   (link.so file "(\\.[0-9]+){3}$")  ;.so
-   (link.so file "(\\.[0-9]+){2}$")) ;.so.3
- (find-files lib "lib.*\\.so\\..*"
+  (find-files "bin" "^lib.*\\.so"
 (home-page "https://astyle.sourceforge.net/;)
 (synopsis "Source code indenter, formatter, and beautifier")
 (description



18/49: gnu: wxwidgets: Update to 3.2.5.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 7ae5decaeb3b379cc6fffb60f53513ee55fda0fd
Author: Andy Tai 
AuthorDate: Wed Jun 12 02:44:09 2024 -0700

gnu: wxwidgets: Update to 3.2.5.

* gnu/packages/wxwidgets.scm (wxwidgets): Update to 3.2.5.

Change-Id: I61786e67c2b99ceea5124ee26f50b495fbaeb69f
Signed-off-by: Maxim Cournoyer 
---
 gnu/packages/wxwidgets.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/wxwidgets.scm b/gnu/packages/wxwidgets.scm
index 1e5bae27b5..973e962fb1 100644
--- a/gnu/packages/wxwidgets.scm
+++ b/gnu/packages/wxwidgets.scm
@@ -66,7 +66,7 @@
 (define-public wxwidgets
   (package
 (name "wxwidgets")
-(version "3.2.4")
+(version "3.2.5")
 (source
  (origin
(method url-fetch)
@@ -74,7 +74,7 @@
"releases/download/v" version
"/wxWidgets-" version ".tar.bz2"))
(sha256
-(base32 "0ghkr8wahnw44c6p7zzvc696gmrqc7pxp2bkrcpazdbdf6my2h06"))
+(base32 "0lbb3hnprkral29cdik9y2xhjfkf4b4qy905lyv1krg2scx6mn0a"))
(modules '((guix build utils)
   (ice-9 ftw)
   (srfi srfi-26)))



06/49: gnu: gauche: Remove trailing #t.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 0dacf51553405da41a9df1d7a0ebbf1f401267ae
Author: Maxim Cournoyer 
AuthorDate: Sun Jun 23 21:48:13 2024 -0400

gnu: gauche: Remove trailing #t.

* gnu/packages/scheme.scm (gauche) [phases]: Remove trailing #t.

Change-Id: I47b4f2a7475a41e6431bba0c3d6bd21b9f584fc5
---
 gnu/packages/scheme.scm | 12 
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/scheme.scm b/gnu/packages/scheme.scm
index 8bf72deb23..927e10bbfe 100644
--- a/gnu/packages/scheme.scm
+++ b/gnu/packages/scheme.scm
@@ -1116,24 +1116,20 @@ The core is 12 builtin special forms and 33 builtin 
functions.")
 "ext/tls/test.scm"
 "lib/gauche/package/util.scm"
 "libsrc/gauche/process.scm")
-   (("/bin/sh") (which "sh")))
- #t))
+   (("/bin/sh") (which "sh")
  (add-after 'build 'build-doc
(lambda _
  (with-directory-excursion "doc"
-   (invoke "make" "info"))
- #t))
+   (invoke "make" "info"
  (add-before 'check 'patch-network-tests
;; Remove net checks.
(lambda _
  (delete-file "test/net.scm")
- (invoke "touch" "test/net.scm")
- #t))
+ (invoke "touch" "test/net.scm")))
  (add-after 'install 'install-docs
(lambda _
  (with-directory-excursion "doc"
-   (invoke "make" "install"))
- #t)
+   (invoke "make" "install")))
 (synopsis "Scheme scripting engine")
 (description "Gauche is a R7RS Scheme scripting engine aiming at being a
 handy tool that helps programmers and system administrators to write small to



02/49: gnu: bpftrace: Update to 0.21.0 and enable tests.

2024-06-24 Thread guix-commits
apteryx pushed a commit to branch master
in repository guix.

commit 77d949c812a29577c12fe9b08c9bf5dddc6d0d2f
Author: Maxim Cournoyer 
AuthorDate: Sun Jun 23 11:37:10 2024 -0400

gnu: bpftrace: Update to 0.21.0 and enable tests.

* gnu/packages/linux.scm (bpftrace): Update to 0.21.0.
[source]: Update URL.  Remove patch.
[arguments] : Remove argument.
: New argument.
: Enable BUILD_TESTING CMake option.  Remove
-DHAVE_BFD_DISASM=OFF.
: New argument.
[native-inputs]: Add dwarves, googletest and xxd.
[inputs]: Replace clang-toolchain-9 with clang-15.  Add libiberty.
[home-page]: Update URL.
* gnu/packages/patches/bpftrace-disable-bfd-disasm.patch: Delete file.
* gnu/local.mk (dist_patch_DATA): De-register it.

Change-Id: I927f881594ff78c43b1713a19ee28c158e040ef3

Change-Id: I36bb022f21873fff7ad81ec8e80b9569f3d45417
---
 gnu/local.mk   |  1 -
 gnu/packages/linux.scm | 40 +-
 .../patches/bpftrace-disable-bfd-disasm.patch  | 15 
 3 files changed, 24 insertions(+), 32 deletions(-)

diff --git a/gnu/local.mk b/gnu/local.mk
index f96807616f..4a2c7f7bfa 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1013,7 +1013,6 @@ dist_patch_DATA = 
\
   %D%/packages/patches/bloomberg-bde-cmake-module-path.patch   \
   %D%/packages/patches/bloomberg-bde-tools-fix-install-path.patch  \
   %D%/packages/patches/boolector-find-googletest.patch \
-  %D%/packages/patches/bpftrace-disable-bfd-disasm.patch   \
   %D%/packages/patches/breezy-fix-gio.patch\
   %D%/packages/patches/byobu-writable-status.patch \
   %D%/packages/patches/bubblewrap-fix-locale-in-tests.patch\
diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index d259d6fddc..4c4bf2aa6b 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -190,6 +190,7 @@
   #:use-module (gnu packages tls)
   #:use-module (gnu packages valgrind)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages vim)
   #:use-module (gnu packages vulkan)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xiph)
@@ -10129,30 +10130,37 @@ modification of BPF objects on the system.")
 (define-public bpftrace
   (package
 (name "bpftrace")
-(version "0.18.1")
+(version "0.21.0")
 (source
  (origin
(method git-fetch)
(uri (git-reference
- (url "https://github.com/iovisor/bpftrace;)
+ (url "https://github.com/bpftrace/bpftrace;)
  (commit (string-append "v" version
(file-name (git-file-name name version))
(sha256
-(base32 "0j8ba2j98d3j8lilgx3z2n162r26ryg7zw5ldwd9m36xnjp40347"))
-   (patches (search-patches "bpftrace-disable-bfd-disasm.patch"
+(base32 "06yg3w80kdq0i003w2gvn0czbh8z9d3rfgmglp37dkir7g3dc6iz"
 (build-system cmake-build-system)
-(native-inputs
- (list bison flex))
-(inputs
- (list bcc clang-toolchain-9 elfutils libbpf cereal))
-(arguments
- `(#:tests? #f ;Tests require googletest sources.
-   #:configure-flags
-   '("-DBUILD_TESTING=OFF"
- ;; FIXME: libbfd misses some link dependencies, when fixed, remove
- ;; the associated patch.
- "-DHAVE_BFD_DISASM=OFF")))
-(home-page "https://github.com/iovisor/bpftrace;)
+(arguments (list #:configure-flags #~(list "-DBUILD_TESTING=ON")
+ ;; Only run the unit tests suite, as the other ones
+ ;; (runtime_tests, tools-parsing-test) require to run as
+ ;; 'root'.
+ #:test-target "bpftrace_test"
+ #:phases #~(modify-phases %standard-phases
+  (add-after 'unpack 'patch-paths
+(lambda _
+  (with-directory-excursion "tests"
+(substitute* (find-files ".")
+  (("/bin/sh")
+   (which "sh")))
+(substitute* '("child.cpp"
+   "runtime/call"
+   "procmon.cpp")
+  (("/bin/ls")
+   (which "ls")
+(native-inputs (list bison dwarves flex googletest xxd))
+(inputs (list bcc clang-15 elfutils libbpf libiberty cereal))
+(home-page "https://github.com/bpftrace/bpftrace;)
 (synopsis "High-level tracing language for Linux eBPF")
 (description
  "bpftrace is a high-level tracing language for Linux enhanced Berkeley
diff --git a/gnu/packages/patches/bpftrace-disable-bfd-disasm.patch 

[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

2024-06-24 Thread via cfe-commits

Sirraide wrote:

> This change has some compile-time impact

I was not expecting that. Hmm, I wonder what’s causing this.

> Given that this is for a clang extension and not a conformance issue, I'm 
> inclined to revert.

It might make sense to do that, yeah. Either way, we should investigate what’s 
going on here. @AaronBallman wdyt?

https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-24 Thread Congcong Cai via cfe-commits

https://github.com/HerrCai0907 edited 
https://github.com/llvm/llvm-project/pull/96122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-24 Thread Congcong Cai via cfe-commits




HerrCai0907 wrote:

I found it. It named `clang-tidy-diff.py`

https://github.com/llvm/llvm-project/pull/96122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[Lldb-commits] [lldb] [lldb/DWARF] Remove parsing recursion when searching for definition DIEs (PR #96484)

2024-06-24 Thread via lldb-commits
e(clang_type), die);
-  type_sp = dwarf->MakeType(
-  die.GetID(), attrs.name, attrs.byte_size, nullptr, LLDB_INVALID_UID,
+  clang::DeclContext *type_decl_ctx =
+  TypeSystemClang::GetDeclContextForType(clang_type);
+  LinkDeclContextToDIE(type_decl_ctx, def_die);
+  if (decl_die != def_die)
+LinkDeclContextToDIE(type_decl_ctx, decl_die);
+  TypeSP type_sp = dwarf->MakeType(
+  def_die.GetID(), attrs.name, attrs.byte_size, nullptr, LLDB_INVALID_UID,
   Type::eEncodingIsUID, , clang_type,
   Type::ResolveState::Forward,
   TypePayloadClang(OptionalClangModuleID(), attrs.is_complete_objc_class));
@@ -1875,7 +1880,7 @@ DWARFASTParserClang::ParseStructureLikeDIE(const 
SymbolContext ,
   // copies of the same type over and over in the ASTContext for our
   // module
   unique_ast_entry_up->m_type_sp = type_sp;
-  unique_ast_entry_up->m_die = die;
+  unique_ast_entry_up->m_die = def_die;
   unique_ast_entry_up->m_declaration = unique_decl;
   unique_ast_entry_up->m_byte_size = attrs.byte_size.value_or(0);
   dwarf->GetUniqueDWARFASTTypeMap().Insert(unique_typename,
@@ -1886,18 +1891,17 @@ DWARFASTParserClang::ParseStructureLikeDIE(const 
SymbolContext ,
 // has child classes or types that require the class to be created
 // for use as their decl contexts the class will be ready to accept
 // these child definitions.
-if (!die.HasChildren()) {
+if (!def_die.HasChildren()) {
   // No children for this struct/union/class, lets finish it
   if (TypeSystemClang::StartTagDeclarationDefinition(clang_type)) {
 TypeSystemClang::CompleteTagDeclarationDefinition(clang_type);
   } else {
 dwarf->GetObjectFile()->GetModule()->ReportError(
 
-"DWARF DIE at {0:x16} named \"{1}\" was not able to start "
-"its "
+"DWARF DIE {0:x16} named \"{1}\" was not able to start its "
 "definition.\nPlease file a bug and attach the file at the "
 "start of this error message",
-die.GetOffset(), attrs.name.GetCString());
+def_die.GetID(), attrs.name.GetCString());
   }
 
   // Setting authority byte size and alignment for empty structures.
@@ -1945,7 +1949,7 @@ DWARFASTParserClang::ParseStructureLikeDIE(const 
SymbolContext ,
   // binaries.
   dwarf->GetForwardDeclCompilerTypeToDIE().try_emplace(
   ClangUtil::RemoveFastQualifiers(clang_type).GetOpaqueQualType(),
-  *die.GetDIERef());
+  *def_die.GetDIERef());
   m_ast.SetHasExternalStorage(clang_type.GetOpaqueQualType(), true);
 }
   }
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
index 0f3eab0186c4e..117e02bb8c5de 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -3038,118 +3038,113 @@ TypeSP Sy...
[truncated]

``




https://github.com/llvm/llvm-project/pull/96484
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[Lldb-commits] [lldb] [lldb/DWARF] Remove parsing recursion when searching for definition DIEs (PR #96484)

2024-06-24 Thread Pavel Labath via lldb-commits
e/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
index de22dd676eef0..7d5516b92737b 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
@@ -277,7 +277,7 @@ class SymbolFileDWARFDebugMap : public SymbolFileCommon {
 
   CompileUnitInfo *GetCompileUnitInfo(SymbolFileDWARF *oso_dwarf);
 
-  lldb::TypeSP FindDefinitionTypeForDWARFDeclContext(const DWARFDIE );
+  DWARFDIE FindDefinitionDIE(const DWARFDIE );
 
   bool Supports_DW_AT_APPLE_objc_complete_type(SymbolFileDWARF 
*skip_dwarf_oso);
 
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp 
b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
index 71c9997e4c82c..c3652a8480a42 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
@@ -125,9 +125,8 @@ UniqueDWARFASTTypeMap 
::GetUniqueDWARFASTTypeMap() {
   return GetBaseSymbolFile().GetUniqueDWARFASTTypeMap();
 }
 
-lldb::TypeSP
-SymbolFileDWARFDwo::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE ) 
{
-  return GetBaseSymbolFile().FindDefinitionTypeForDWARFDeclContext(die);
+DWARFDIE SymbolFileDWARFDwo::FindDefinitionDIE(const DWARFDIE ) {
+  return GetBaseSymbolFile().FindDefinitionDIE(die);
 }
 
 lldb::TypeSP SymbolFileDWARFDwo::FindCompleteObjCDefinitionTypeForDIE(
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h 
b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h
index 1500540424b52..690fe62f68926 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.h
@@ -76,8 +76,7 @@ class SymbolFileDWARFDwo : public SymbolFileDWARF {
 
   UniqueDWARFASTTypeMap () override;
 
-  lldb::TypeSP
-  FindDefinitionTypeForDWARFDeclContext(const DWARFDIE ) override;
+  DWARFDIE FindDefinitionDIE(const DWARFDIE ) override;
 
   lldb::TypeSP
   FindCompleteObjCDefinitionTypeForDIE(const DWARFDIE ,

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-24 Thread Congcong Cai via cfe-commits




HerrCai0907 wrote:

Where is `diff-clang-tidy.py`?

https://github.com/llvm/llvm-project/pull/96122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[jenkinsci/gradle-plugin] e56828: Remove `autoInjectionSkippedWhenOldMavenPlugin` te...

2024-06-24 Thread 'Alexis Tual' via Jenkins Commits
  Branch: refs/heads/atual/bump-versions
  Home:   https://github.com/jenkinsci/gradle-plugin
  Commit: e56828bf5b9b81b48cc4393c87cdc9dac11f9e53
  
https://github.com/jenkinsci/gradle-plugin/commit/e56828bf5b9b81b48cc4393c87cdc9dac11f9e53
  Author: Alexis Tual 
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
M 
acceptance-tests/src/test/java/hudson/plugins/gradle/MavenInjectionTest.java

  Log Message:
  ---
  Remove `autoInjectionSkippedWhenOldMavenPlugin` test as it requires 
maven-plugin 3.14 which won't install on the current Jenkins version



To unsubscribe from these emails, change your notification settings at 
https://github.com/jenkinsci/gradle-plugin/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/gradle-plugin/push/refs/heads/atual/bump-versions/8a2668-e56828%40github.com.


[jenkinsci/pipeline-input-step-plugin] 9b0812: Bump io.jenkins.tools.bom:bom-2.440.x

2024-06-24 Thread 'dependabot[bot]' via Jenkins Commits
  Branch: 
refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.440.x-3143.v347db_7c6db_6e
  Home:   https://github.com/jenkinsci/pipeline-input-step-plugin
  Commit: 9b0812b42ee76d6f90d05aeae196dae03d90442b
  
https://github.com/jenkinsci/pipeline-input-step-plugin/commit/9b0812b42ee76d6f90d05aeae196dae03d90442b
  Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
M pom.xml

  Log Message:
  ---
  Bump io.jenkins.tools.bom:bom-2.440.x

Bumps [io.jenkins.tools.bom:bom-2.440.x](https://github.com/jenkinsci/bom) from 
3056.v53343b_a_b_a_850 to 3143.v347db_7c6db_6e.
- [Release notes](https://github.com/jenkinsci/bom/releases)
- [Commits](https://github.com/jenkinsci/bom/commits)

---
updated-dependencies:
- dependency-name: io.jenkins.tools.bom:bom-2.440.x
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] 



To unsubscribe from these emails, change your notification settings at 
https://github.com/jenkinsci/pipeline-input-step-plugin/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/pipeline-input-step-plugin/push/refs/heads/dependabot/maven/io.jenkins.tools.bom-bom-2.440.x-3143.v347db_7c6db_6e/00-9b0812%40github.com.


[clang] [Clang][SveEmitter] Split up TargetGuard into SVE and SME component. (PR #96482)

2024-06-24 Thread via cfe-commits
[_{d}]_vg1x4", "vm4di", "d", 
MergeNone, "aarch64_sme_fmls_lane_vg1x4", [IsStreaming, IsInOutZA], 
[ImmCheck<3, ImmCheck0_1>]>;
 }
 
-let TargetGuard = "sme-f16f16" in {
+let SMETargetGuard = "sme-f16f16" in {
   def SVMLA_MULTI_VG1x2_F16 : Inst<"svmla_za16[_f16]_vg1x2", "vm22", "h", 
MergeNone, "aarch64_sme_fmla_vg1x2", [IsStreaming, IsInOutZA], []>;
   def SVMLA_MULTI_VG1x4_F16 : Inst<"svmla_za16[_f16]_vg1x4", "vm44", "h", 
MergeNone, "aarch64_sme_fmla_vg1x4", [IsStreaming, IsInOutZA], []>;
   def SVMLS_MULTI_VG1x2_F16 : Inst<"svmls_za16[_f16]_vg1x2", "vm22", "h", 
MergeNone, "aarch64_sme_fmls_vg1x2", [IsStreaming, IsInOutZA], []>;
@@ -504,7 +506,7 @@ let TargetGuard = "sme-f16f16" in {
   def SVMLS_LANE_VG1x4_F16 : Inst<"svmls_lane_za16[_f16]_vg1x4", "vm4di", "h", 
MergeNone, "aarch64_sme_fmls_lane_vg1x4", [IsStreaming, IsInOutZA], 
[ImmCheck<3, ImmCheck0_7>]>;
 }
 
-let TargetGuard = "sme2,b16b16" in {
+let SMETargetGuard = "sme2,b16b16" in {
   def SVMLA_MULTI_VG1x2_BF16 : Inst<"svmla_za16[_bf16]_vg1x2", "vm22", "b", 
MergeNone, "aarch64_sme_fmla_vg1x2", [IsStreaming, IsInOutZA], []>;
   def SVMLA_MULTI_VG1x4_BF16 : Inst<"svmla_za16[_bf16]_vg1x4", "vm44", "b", 
MergeNone, "aarch64_sme_fmla_vg1x4", [IsStreaming, IsInOutZA], []>;
   def SVMLS_MULTI_VG1x2_BF16 : Inst<"svmls_za16[_bf16]_vg1x2", "vm22", "b", 
MergeNone, "aarch64_sme_fmls_vg1x2", [IsStreaming, IsInOutZA], []>;
@@ -523,7 +525,7 @@ let TargetGuard = "sme2,b16b16" in {
 
 // FMLAL/FMLSL/UMLAL/SMLAL
 // SMLALL/UMLALL/USMLALL/SUMLALL
-let TargetGuard = "sme2" in {
+let SMETargetGuard = "sme2" in {
   // MULTI MLAL
   def SVMLAL_MULTI_VG2x2_F16 : Inst<"svmla_za32[_{d}]_vg2x2", "vm22", "bh", 
MergeNone, "aarch64_sme_fmlal_vg2x2", [IsStreaming, IsInOutZA], []>;
   def SVMLAL_MULTI_VG2x4_F16 : Inst<"svmla_za32[_{d}]_vg2x4", "vm44", "bh", 
MergeNone, "aarch64_sme_fmlal_vg2x4", [IsStreaming, IsInOutZA], []>;
@@ -653,7 +655,7 @@ let TargetGuard = "sme2" in {
   def SVUSMLALL_LANE_VG4x4 : Inst<"svusmla_lane_za32[_{d}]_vg4x4", "vm4xi", 
"Uc", MergeNone, "aarch64_sme_usmla_za32_lane_vg4x4", [IsStreaming, IsInOutZA], 
[ImmCheck<3, ImmCheck0_15>]>;
 }
 
-let TargetGuard = "sme2,sme-i16i64" in {
+let SMETargetGuard = "sme2,sme-i16i64" in {
   // MULTI MLAL
   def SVMLAL_MULTI_VG4x2_S16 : Inst<"svmla_za64[_{d}]_vg4x2", "vm22", "s", 
MergeNone, "aarch64_sme_smla_za64_vg4x2", [IsStreaming, IsInOutZA], []>;
   def SVMLAL_MULTI_VG4x2_U16 : Inst<"svmla_za64[_{d}]_vg4x2", "vm22", "Us", 
MergeNone, "aarch64_sme_umla_za64_vg4x2", [IsStreaming, IsInOutZA], []>;
@@ -702,7 +704,7 @@ let TargetGuard = "sme2,sme-i16i64" in {
 //
 // Spill and fill of ZT0
 //
-let TargetGuard = "sme2" in {
+let SMETargetGuard = "sme2" in {
   def SVLDR_ZT : Inst<"svldr_zt", "viQ", "", MergeNone, "aarch64_sme_ldr_zt", 
[IsOverloadNone, IsStreamingCompatible, IsInOutZT0], [ImmCheck<0, 
ImmCheck0_0>]>;
   def SVSTR_ZT : Inst<"svstr_zt", "vi%", "", MergeNone, "aarch64_sme_str_zt", 
[IsOverloadNone, IsStreamingCompatible, IsInZT0], [ImmCheck<0, ImmCheck0_0>]>;
 }
@@ -710,14 +712,14 @@ let TargetGuard = "sme2" in {
 //
 // Zero ZT0
 //
-let TargetGuard = "sme2" in {
+let SMETargetGuard = "sme2" in {
   def SVZERO_ZT : Inst<"svzero_zt", "vi", "", MergeNone, 
"aarch64_sme_zero_zt", [IsOverloadNone, IsStreamingCompatible, IsOutZT0], 
[ImmCheck<0, ImmCheck0_0>]>;
 }
 
 //
 // lookup table expand four contiguous registers
 //
-let TargetGuard = "sme2" in {
+let SMETargetGuard = "sme2" in {
   def SVLUTI2_LANE_ZT_X4 : Inst<"svluti2_lane_zt_{d}_x4", "4.di[i", 
"cUcsUsiUibhf", MergeNone, "aarch64_sme_luti2_lane_zt_x4", [IsStreaming, 
IsInZT0], [ImmCheck<0, ImmCheck0_0>, ImmCheck<2, ImmCheck0_3>]>;
   def SVLUTI4_LANE_ZT_X4 : Inst<"svluti4_lane_zt_{d}_x4", "4.di[i", 
"sUsiUibhf", MergeNone, "aarch64_sme_luti4_lane_zt_x4", [IsStreaming, IsInZT0], 
[ImmCheck<0, ImmCheck0_0>, ImmCheck<2, ImmCheck0_1>]>;
 }
@@ -725,7 +727,7 @@ let TargetGuard = "sme2" in {
 //
 // lookup table expand one register
 //
-let TargetGuard = "sme2" in {
+let SMETargetGuard = "sme2" in {
   def SVLUTI2_LANE_ZT : Inst<"svluti2_lane_zt_{d}", "di[i", "cUcsUsiUibhf", 
MergeNone, "aarch64_sme_luti2_lane_zt", [IsStreaming, IsInZT0], [ImmCheck<0, 
ImmCheck0_0>, ImmCheck<2, ImmCheck0_15>]>;
   def SVLUTI4_LANE_ZT : Inst<"svluti4_lane_zt_{d}", "di[i", "cUcsUsiUibhf", 
MergeNone, "aarch64_sme_luti4_lane_zt", [IsStreaming, IsInZT0], [ImmCheck<0, 
ImmCheck0_0>, ImmCheck<2, ImmCheck0_7>]>;
 }
@@ -733,14 +735,14 @@ let TargetGuard = "sme2" in {
 //
 // lookup table expand two contiguous registers
 //
-let TargetGuard = "sme2" in {
+let SMETargetGuard = "sme2" in {
   def SVLUTI2_LANE_ZT_X2 : Inst<"svluti2_lane_zt_{d}_x2", "2.di[i", 
"cUcsUsiUibhf", MergeNone, "aarch64_sme_luti2_lane_zt_x2", [IsStreaming, 
IsInZT0], [ImmCheck<0, ImmCheck0_0>, ImmCheck<2, ImmCheck0_7>]>;
   def SVLUTI4_LANE_ZT_X2 : Inst<"svluti4_lane_zt_{d}_x2", "2.di[i", 
"cUcsUsiUibhf", MergeNone, "aarch64_sme_luti4_lane_zt_x2", [IsStreaming, 
IsInZT0], [ImmCheck<0, ImmCheck0_0>, ImmCheck<2, ImmCheck0_3>]>;
 }
 
 

 // SME2p1 - FMOPA, FMOPS (non-widening)
-let TargetGuard = "sme2,b16b16" in {
+let SMETargetGuard = "sme2,b16b16" in {
   def SVMOPA_BF16_NW : SInst<"svmopa_za16[_bf16]_m", "viPPdd", "b",
  MergeNone, "aarch64_sme_mopa",
  [IsStreaming, IsInOutZA],
@@ -751,7 +753,7 @@ let TargetGuard = "sme2,b16b16" in {
  [ImmCheck<0, ImmCheck0_1>]>;
 }
 
-let TargetGuard = "sme-f16f16" in {
+let SMETargetGuard = "sme-f16f16" in {
   def SVMOPA_F16...
[truncated]

``




https://github.com/llvm/llvm-project/pull/96482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [Clang][SveEmitter] Split up TargetGuard into SVE and SME component. (PR #96482)

2024-06-24 Thread Sander de Smalen via cfe-commits

https://github.com/sdesmalen-arm created 
https://github.com/llvm/llvm-project/pull/96482

One reason to want to split this up is to simplify the code added in #93802, 
where it checks the SME streaming-mode requirements for a builtin by checking 
for the absence of SVE. If the target guards are separate, we can generate a 
table and make the Sema code to verify the runtime mode simpler.

Another reason is to avoid an issue with a check in SveEmitter.cpp where it 
ensures that the 'VerifyRuntimeMode' is set correctly for functions that have 
both SVE and SME target guards:

  if (!Def->isFlagSet(VerifyRuntimeMode) && Def->getGuard().contains("sve") &&
  Def->getGuard().contains("sme"))
llvm_unreachable("Missing VerifyRuntimeMode flag");

However, if we ever add a new feature with "sme" in the name, even though it is 
unrelated to FEAT_SME, then this code no longer works.

Note that the arm_sve.td and arm_sme.td files could do with a bit of 
restructuring after this but it seems better to follow that up in an NFC patch.

>From 26b1e76002f3e1d99bff9c398c313b3cae0a31b6 Mon Sep 17 00:00:00 2001
From: Sander de Smalen 
Date: Fri, 21 Jun 2024 17:13:31 +0100
Subject: [PATCH] [Clang][SveEmitter] Split up TargetGuard into SVE and SME
 component.

One reason to want to split this up is to simplify the code added
in #93802, where it checks the SME streaming-mode requirements for a
builtin by checking for the absence of SVE. If the target guards are
separate, we can generate a table and make the Sema code to verify the
runtime mode simpler.

Another reason is to avoid an issue with a check in SveEmitter.cpp
where it ensures that the 'VerifyRuntimeMode' is set correctly for
functions that have both SVE and SME target guards:

  if (!Def->isFlagSet(VerifyRuntimeMode) && Def->getGuard().contains("sve") &&
  Def->getGuard().contains("sme"))
llvm_unreachable("Missing VerifyRuntimeMode flag");

However, if we ever add a new feature with "sme" in the name, even
though it is unrelated to FEAT_SME, then this code no longer works.

Note that the arm_sve.td and arm_sme.td files could do with a bit of
restructuring after this but it seems better to follow that up in an
NFC patch.
---
 clang/include/clang/Basic/arm_sme.td  |  82 ---
 clang/include/clang/Basic/arm_sve.td  | 231 +-
 clang/include/clang/Basic/arm_sve_sme_incl.td |   5 +-
 .../acle_sve_bfloat.cpp   |  58 ++---
 .../acle_sve2_bfloat.cpp  |  16 +-
 clang/utils/TableGen/SveEmitter.cpp   |  71 --
 6 files changed, 242 insertions(+), 221 deletions(-)

diff --git a/clang/include/clang/Basic/arm_sme.td 
b/clang/include/clang/Basic/arm_sme.td
index 564a58e4eb670..1580331ea603c 100644
--- a/clang/include/clang/Basic/arm_sme.td
+++ b/clang/include/clang/Basic/arm_sme.td
@@ -15,11 +15,13 @@
 
 include "arm_sve_sme_incl.td"
 
+let SVETargetGuard = InvalidMode in {
+
 

 // Loads
 
 multiclass ZALoad 
ch> {
-  let TargetGuard = "sme" in {
+  let SMETargetGuard = "sme" in {
 def NAME # _H : MInst<"svld1_hor_" # n_suffix, "vimPQ", t,
   [IsLoad, IsOverloadNone, IsStreaming, IsInOutZA],
   MemEltTyDefault, i_prefix # "_horiz", ch>;
@@ -44,7 +46,7 @@ defm SVLD1_ZA32 : ZALoad<"za32", "i", "aarch64_sme_ld1w", 
[ImmCheck<0, ImmCheck0
 defm SVLD1_ZA64 : ZALoad<"za64", "l", "aarch64_sme_ld1d", [ImmCheck<0, 
ImmCheck0_7>]>;
 defm SVLD1_ZA128 : ZALoad<"za128", "q", "aarch64_sme_ld1q", [ImmCheck<0, 
ImmCheck0_15>]>;
 
-let TargetGuard = "sme" in {
+let SMETargetGuard = "sme" in {
 def SVLDR_VNUM_ZA : MInst<"svldr_vnum_za", "vmQl", "",
   [IsOverloadNone, IsStreamingCompatible, IsInOutZA],
   MemEltTyDefault, "aarch64_sme_ldr">;
@@ -58,7 +60,7 @@ def SVLDR_ZA : MInst<"svldr_za", "vmQ", "",
 // Stores
 
 multiclass ZAStore 
ch> {
-  let TargetGuard = "sme" in {
+  let SMETargetGuard = "sme" in {
 def NAME # _H : MInst<"svst1_hor_" # n_suffix, "vimP%", t,
   [IsStore, IsOverloadNone, IsStreaming, IsInZA],
   MemEltTyDefault, i_prefix # "_horiz", ch>;
@@ -83,7 +85,7 @@ defm SVST1_ZA32 : ZAStore<"za32", "i", "aarch64_sme_st1w", 
[ImmCheck<0, ImmCheck
 defm SVST1_ZA64 : ZAStore<"za64", "l", "aarch64_sme_st1d", [ImmCheck<0, 
ImmCheck0_7>]>;
 defm SVST1_ZA128 : ZAStore<"za128", "q", "aarch64_sme_st1q", [ImmCheck<0, 
ImmCheck0_15>]>;
 
-let TargetGuard = "sme" in {
+let SMETargetGuard = "sme" in {
 def SVSTR_VNUM_ZA : MInst<"svstr_vnum_za", "vm%l", "",
   [IsOverloadNone, IsStreamingCompatible, IsInZA],
   MemEltTyDefault, "aarch64_sme_str">;
@@ -97,7 +99,7 @@ def SVSTR_ZA : MInst<"svstr_za", "vm%", "",
 // Read horizontal/vertical ZA slices
 
 multiclass ZARead 
ch> {
-  let TargetGuard = "sme" in {
+  let SMETargetGuard 

[clang] [Clang][Sema] Diagnose variable template explicit specializations with storage-class-specifiers (PR #93873)

2024-06-24 Thread via cfe-commits

alexfh wrote:

Specifically, the problem is that we can't fix code that corresponds to case # 
1 from the description, since it produces code corresponding to pattern # 2, 
which can't compile with current clang. Shipping fixes together with the 
compiler is not an option for us (and probably for many other users), so it 
should be possible to tell the new Clang to accept pattern # 1, i.e. it should 
be a warning (included into `-Wall`, probably) rather than a hard error for at 
least one compiler release.

https://github.com/llvm/llvm-project/pull/93873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [clang] Skip auto-init on scalar vars that have a non-constant Init and no self-ref (PR #94642)

2024-06-24 Thread Jan Voung via cfe-commits

https://github.com/jvoung closed https://github.com/llvm/llvm-project/pull/94642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] 0cf1e66 - [clang] Skip auto-init on scalar vars that have a non-constant Init and no self-ref (#94642)

2024-06-24 Thread via cfe-commits
sed(x);
+}
+
+// Scalar with a self-reference: does need auto-init.
+// UNINIT-LABEL:  test_selfinit_lambda_call(
+// ZERO-LABEL:test_selfinit_lambda_call(
+// ZERO: store i32 0, ptr %self, align 4, !annotation [[AUTO_INIT:!.+]]
+// PATTERN-LABEL: test_selfinit_lambda_call(
+// PATTERN: store i32 -1431655766, ptr %self, align 4, !annotation 
[[AUTO_INIT:!.+]]
+void test_selfinit_lambda_call() {
+  int self = [&](){ return self; }();
+  used(self);
+}
+
+// Scalar with a self-reference: does need auto-init.
+// UNINIT-LABEL:  test_selfinit_gnu_stmt_expression(
+// ZERO-LABEL:test_selfinit_gnu_stmt_expression(
+// ZERO: store i32 0, ptr %self, align 4, !annotation [[AUTO_INIT:!.+]]
+// PATTERN-LABEL: test_selfinit_gnu_stmt_expression(
+// PATTERN: store i32 -1431655766, ptr %self, align 4, !annotation 
[[AUTO_INIT:!.+]]
+void test_selfinit_gnu_stmt_expression() {
+  int self = ({int x = self; x + 1; });
+  used(self);
+}
+
+// Not a scalar: auto-init just in case
+// UNINIT-LABEL:  test_nonscalar_call(
+// ZERO-LABEL:test_nonscalar_call(
+// ZERO: call void @llvm.memset{{.*}}, i8 0, i64 8, {{.*}} !annotation 
[[AUTO_INIT:!.+]]
+// PATTERN-LABEL: test_nonscalar_call(
+// PATTERN: call void @llvm.memcpy{{.*}}, i64 8, {{.*}} !annotation 
[[AUTO_INIT:!.+]]
+void test_nonscalar_call() {
+  C c = make_c();
+  used(c);
+}
+
+// Scalar with a self-reference: does need auto-init.
+// UNINIT-LABEL:  test_self_ptr(
+// ZERO-LABEL:test_self_ptr(
+// ZERO: store ptr null, ptr %self, align 8, !annotation [[AUTO_INIT:!.+]]
+// PATTERN-LABEL: test_self_ptr(
+// PATTERN: store ptr inttoptr (i64 -6148914691236517206 to ptr), ptr %self, 
align 8, !annotation [[AUTO_INIT:!.+]]
+void test_self_ptr() {
+  void* self = self;
+  used(self);
+}
+
+// Scalar without a self-reference: no auto-init needed.
+// UNINIT-LABEL:  test_nonself_ptr(
+// ZERO-LABEL:test_nonself_ptr(
+// ZERO-NOT: !annotation [[AUTO_INIT:!.+]]
+// PATTERN-LABEL: test_nonself_ptr(
+// PATTERN-NOT: !annotation [[AUTO_INIT:!.+]]
+void test_nonself_ptr() {
+  int y = 0;
+  void* x = 
+  used(x);
+}
+
+// Scalar with a self-reference: does need auto-init.
+// UNINIT-LABEL:  test_self_complex(
+// ZERO-LABEL:test_self_complex(
+// ZERO: call void @llvm.memset{{.*}} !annotation [[AUTO_INIT:!.+]]
+// PATTERN-LABEL: test_self_complex(
+// PATTERN: call void @llvm.memcpy{{.*}} !annotation [[AUTO_INIT:!.+]]
+void test_self_complex() {
+  _Complex float self = 3.0 * 3.0 * self;
+  used(self);
+}
+
+// Scalar without a self-reference: no auto-init needed.
+// UNINIT-LABEL:  test_nonself_complex(
+// ZERO-LABEL:test_nonself_complex(
+// ZERO-NOT: !annotation [[AUTO_INIT:!.+]]
+// PATTERN-LABEL: test_nonself_complex(
+// PATTERN-NOT: !annotation [[AUTO_INIT:!.+]]
+void test_nonself_complex() {
+  _Complex float y = 0.0;
+  _Complex float x = 3.0 * 3.0 * y;
+  used(x);
+}
+
+} // extern "C"
+
+// ZERO: [[AUTO_INIT]] = !{!"auto-init"}
+// PATTERN: [[AUTO_INIT]] = !{!"auto-init"}
+



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[jenkinsci/gerrit-trigger-plugin] eedb27: Enable Jenkins Security Scan

2024-06-24 Thread 'Robert Sandell' via Jenkins Commits
  Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/gerrit-trigger-plugin
  Commit: eedb27cdcbcec500d75d9d4a0531ce076cc81ed0
  
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/eedb27cdcbcec500d75d9d4a0531ce076cc81ed0
  Author: strangelookingnerd 
<49242855+strangelookingn...@users.noreply.github.com>
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
A .github/workflows/jenkins-security-scan.yml

  Log Message:
  ---
  Enable Jenkins Security Scan


  Commit: 772062a9f76c7369bb42279ce40cb484a1209160
  
https://github.com/jenkinsci/gerrit-trigger-plugin/commit/772062a9f76c7369bb42279ce40cb484a1209160
  Author: Robert Sandell 
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
A .github/workflows/jenkins-security-scan.yml

  Log Message:
  ---
  Merge pull request #510 from strangelookingnerd/patch-1

Enable Jenkins Security Scan


Compare: 
https://github.com/jenkinsci/gerrit-trigger-plugin/compare/038e0869e992...772062a9f76c

To unsubscribe from these emails, change your notification settings at 
https://github.com/jenkinsci/gerrit-trigger-plugin/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/gerrit-trigger-plugin/push/refs/heads/master/038e08-772062%40github.com.


[clang] [PPC][InlineASM] Mark the 'a' constraint as unsupported (PR #96109)

2024-06-24 Thread Kamau Bridgeman via cfe-commits

https://github.com/kamaub closed https://github.com/llvm/llvm-project/pull/96109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] b8979c6 - [PPC][InlineASM] Mark the 'a' constraint as unsupported (#96109)

2024-06-24 Thread via cfe-commits

Author: Kamau Bridgeman
Date: 2024-06-24T08:33:25-04:00
New Revision: b8979c6b13e9d4cb5051dd6f8ca772a20b14b428

URL: 
https://github.com/llvm/llvm-project/commit/b8979c6b13e9d4cb5051dd6f8ca772a20b14b428
DIFF: 
https://github.com/llvm/llvm-project/commit/b8979c6b13e9d4cb5051dd6f8ca772a20b14b428.diff

LOG: [PPC][InlineASM] Mark the 'a' constraint as unsupported (#96109)

'a' is an input/output constraint for restraining assembly variables
to an indexed or indirect address operand. It previously was marked
as supported but would throw an assertion for unknown constraint type
in the back-end when this test case was compiled. This change marks it
as unsupported until we can add full support for address operands
constraining to the compiler code generation.

Added: 
clang/test/CodeGen/PowerPC/inline-asm-constraints-error.c

Modified: 
clang/lib/Basic/Targets/PPC.h

Removed: 




diff  --git a/clang/lib/Basic/Targets/PPC.h b/clang/lib/Basic/Targets/PPC.h
index fc23c30c68523..e4d6a02386da5 100644
--- a/clang/lib/Basic/Targets/PPC.h
+++ b/clang/lib/Basic/Targets/PPC.h
@@ -305,9 +305,11 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public 
TargetInfo {
   // asm statements)
   Info.setAllowsMemory();
   break;
-case 'R': // AIX TOC entry
 case 'a': // Address operand that is an indexed or indirect from a
   // register (`p' is preferable for asm statements)
+  // TODO: Add full support for this constraint
+  return false;
+case 'R': // AIX TOC entry
 case 'S': // Constant suitable as a 64-bit mask operand
 case 'T': // Constant suitable as a 32-bit mask operand
 case 'U': // System V Release 4 small data area reference

diff  --git a/clang/test/CodeGen/PowerPC/inline-asm-constraints-error.c 
b/clang/test/CodeGen/PowerPC/inline-asm-constraints-error.c
new file mode 100644
index 0..eb443eee40e55
--- /dev/null
+++ b/clang/test/CodeGen/PowerPC/inline-asm-constraints-error.c
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -emit-llvm -triple powerpc64-ibm-aix-xcoff -verify %s
+// RUN: %clang_cc1 -emit-llvm -triple powerpc-ibm-aix-xcoff -verify %s
+// This test case exist to test marking the 'a' inline assembly constraint as
+// unsupported because powerpc previously marked it as supported.
+int foo(int arg){
+  asm goto ("bc 12,2,%l[TEST_LABEL]" : : "a"(&_LABEL) : : TEST_LABEL); 
//expected-error {{invalid input constraint 'a' in asm}}
+  return 0;
+TEST_LABEL: return arg + 1;
+}



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[clang] [PPC][InlineASM] Mark the 'a' constraint as unsupported (PR #96109)

2024-06-24 Thread Kamau Bridgeman via cfe-commits
C/inline-asm-constraints-error.c
@@ -1,4 +1,3 @@
-// RUN: %clang_cc1 -emit-llvm -triple powerpc64le-linux-gnu -verify %s
 // RUN: %clang_cc1 -emit-llvm -triple powerpc64-ibm-aix-xcoff -verify %s
 // RUN: %clang_cc1 -emit-llvm -triple powerpc-ibm-aix-xcoff -verify %s
 // This test case exist to test marking the 'a' inline assembly constraint as

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[jenkinsci/scriptler-plugin] 83394b: Enable Jenkins Security Scan

2024-06-24 Thread 'strangelookingnerd' via Jenkins Commits
  Branch: refs/heads/main
  Home:   https://github.com/jenkinsci/scriptler-plugin
  Commit: 83394b234bdb56b9442accbc91cbb9df9349ea3e
  
https://github.com/jenkinsci/scriptler-plugin/commit/83394b234bdb56b9442accbc91cbb9df9349ea3e
  Author: strangelookingnerd 
<49242855+strangelookingn...@users.noreply.github.com>
  Date:   2024-06-24 (Mon, 24 Jun 2024)

  Changed paths:
A .github/workflows/jenkins-security-scan.yml

  Log Message:
  ---
  Enable Jenkins Security Scan



To unsubscribe from these emails, change your notification settings at 
https://github.com/jenkinsci/scriptler-plugin/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/scriptler-plugin/push/refs/heads/main/0441b9-83394b%40github.com.


<    4   5   6   7   8   9   10   11   12   13   >