[GitHub] spark pull request #22593: [Streaming][DOC] Fix typo & format in DataStreamW...
Github user niofire commented on a diff in the pull request: https://github.com/apache/spark/pull/22593#discussion_r224539150 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala --- @@ -46,11 +46,13 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) { private val df = ds.toDF() /** + * * Specifies the behavior when data or table already exists. Options include: --- End diff -- Crap yeah, will move it down --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 Is this happening for other PRs as well? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 org.apache.spark.sql.hive.client.HiveClientSuites.(It is not a test it is a sbt.testing.SuiteSelector) -> Unable to instantiate org.apache.hadoop.hive.metastore.HiveMetaStoreClient --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 Seems like this wasn't able to build due to a transient error with CI --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 From https://spark.apache.org/docs/2.3.2/api/java/org/apache/spark/sql/streaming/DataStreamWriter.html ![image](https://user-images.githubusercontent.com/2295469/46749482-b3351400-cc6a-11e8-834d-7eb53b70ddc0.png) I see java in that URL, is that actually referring to the java API? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 @srowen Guessing you're referring to some other files? Could you link? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...
Github user niofire commented on the issue: https://github.com/apache/spark/pull/22593 Sorry, was out of town, will update --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #22593: Fix typo & format in DataStreamWriter.scala
GitHub user niofire opened a pull request: https://github.com/apache/spark/pull/22593 Fix typo & format in DataStreamWriter.scala ## What changes were proposed in this pull request? - Fixed typo for function outputMode - OutputMode.Complete(), changed `these is some updates` to `there are some updates` - Replaced hyphens by HTML unordered list tags in comments for - outputMode(String) - outputMode(OutputMode) - partitionBy(String*) Current render from most recent [Spark API Docs](https://spark.apache.org/docs/2.3.1/api/java/org/apache/spark/sql/streaming/DataStreamWriter.html): outputMode(OutputMode) - Typo + List formatted as a prose. ![image](https://user-images.githubusercontent.com/2295469/46250648-11086700-c3f4-11e8-8a5a-d88b079c165d.png) outputMode(String) - Typo + List formatted as a prose. ![image](https://user-images.githubusercontent.com/2295469/46250651-24b3cd80-c3f4-11e8-9dac-ae37599afbce.png) partitionBy(String*) - List formatted as a prose. ![image](https://user-images.githubusercontent.com/2295469/46250655-36957080-c3f4-11e8-990b-47bd612d3c51.png) ## How was this patch tested? This PR contains a document patch ergo no functional testing is required. You can merge this pull request into a Git repository by running: $ git pull https://github.com/niofire/spark fix-typo-datastreamwriter Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/22593.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22593 commit c1a89f0455995d9d20920a8b9b45d3b6a9dcd898 Author: Mathieu St-Louis Date: 2018-09-29T21:03:15Z Fix typo + replaced hyphens with html lists in DataStreamWriter --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org