[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 User tono changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from t...@openoffice.org Sun Aug 30 03:48:18 + 2009 --- Closing as the fix is already in the trunk. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 User mav changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from m...@openoffice.org Mon May 18 10:23:30 + 2009 --- There seems to be no way for QA to verify the issue. Setting to verified as development issue. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 User mav changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from m...@openoffice.org Tue May 5 09:18:19 + 2009 --- fixed in fwk103 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 User mav changed the following: What|Old value |New value Assigned to|tm|mav Issue type|PATCH |DEFECT Priority|P3|P4 Target milestone|--- |OOo 3.2 --- Additional comments from m...@openoffice.org Tue Apr 21 06:44:28 + 2009 --- mav-tono: Thank you for the patch. You are completely right that the source code is confusing, but the idea here is to return S_OK always. The implementation is currently designed in the way that the call should work always. If it does not work, that means that something goes really wrong. The experience says that letting OLE container know that something goes wrong is not always a good idea. Some well known containers might even crash in such cases. So the current approach is to report success in some noncritical calls always. This call is noncritical, since it is related to UI. If functionality does not work the UI would be not so nice, but the main functionality still can be used, and we get a new bug that the UI is looking bad and investigate the problem ( currently, there is no reason for the call to fail, except general problems with the object ). - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 --- Additional comments from m...@openoffice.org Tue Apr 21 06:46:29 + 2009 --- I will remove the duplicate variable and let S_OK be returned always explicitly. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 --- Additional comments from t...@openoffice.org Tue Apr 21 11:31:25 + 2009 --- @mav: Alles klar. I think it good to return S_OK explicitly and remove the variable definition outside if-block, if it is the intended coding. It will also remove useless warning for shadowing definition that MinGW gcc emits. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 Issue #|101222 Summary|return code handling in InprocEmbedDocument_Impl::SetH |ostNames Component|framework Version|DEV300m46 Platform|PC URL| OS/Version|Windows, all Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|tm Reported by|tono --- Additional comments from t...@openoffice.org Mon Apr 20 13:03:12 + 2009 --- In InprocEmbedDocument_Impl::SetHostNames() at line #862 in embedserv/source/inprocserv/inprocembobj.cxx, the variable hr is defined both inside and outside of an if-block. So outside definition is shadowed. As the variable is only initialized and used for return outside of the if- block, it does not make sense to use another variable inside of the if-block, I think. Most probably the definition inside the if-block is not intended. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[framework-issues] [Issue 101222] return code handling in I nprocEmbedDocument_Impl::SetHostNames
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=101222 User tono changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |61687) A patch to remove t | |he shadowing definition --- Additional comments from t...@openoffice.org Mon Apr 20 13:05:06 + 2009 --- Created an attachment (id=61687) A patch to remove the shadowing definition - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@framework.openoffice.org For additional commands, e-mail: issues-h...@framework.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
