[gsl-issues] [Issue 112815] vcl: ImplFontCharMap::Get DefaultMap can't possibly be right

2010-09-17 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112815


User hdu changed the following:

What|Old value |New value

  Status|RESOLVED  |CLOSED





--- Additional comments from h...@openoffice.org Fri Sep 17 11:52:38 + 
2010 ---
Got into DEV300_m86 with CWS vcl113. Closing.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 112815] vcl: ImplFontCharMap::Get DefaultMap can't possibly be right

2010-06-30 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112815
 Issue #|112815
 Summary|vcl: ImplFontCharMap::GetDefaultMap can't possibly be 
|right
   Component|gsl
 Version|DEV300m83
Platform|All
 URL|
  OS/Version|Linux
  Status|NEW
   Status whiteboard|
Keywords|
  Resolution|
  Issue type|DEFECT
Priority|P3
Subcomponent|code
 Assigned to|pl
 Reported by|cmc





--- Additional comments from c...@openoffice.org Wed Jun 30 11:58:35 + 
2010 ---
Looking at ImplFontCharMap::GetDefaultMap I see that it takes a bool bSymbols
argument that controls whether it operates on normal font or symbol fonts. 

But this returns a singleton so once one is created, whether its a normal one
or a symbol one, then that one will always be returned regardless of a future
different bSymbols argument.

The only place where bSymbols could be true is in the windows port in
win/source/gdi/salgdi3.cxx in a rare-looking case.

We may need *two* singletons, a symbol mapping and a non-symbol one. Or, maybe
throw out the possibility of returning a Symbol one at all.

I imagine a scenario where this would bite would be on windows to chance to
request, before anything else, the CMAP table for a symbol font which doesn't
have one, which would set the singleton permanently as a symbol one afterwards.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 112815] vcl: ImplFontCharMap::Get DefaultMap can't possibly be right

2010-06-30 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112815


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |70317)
one possibility






--- Additional comments from c...@openoffice.org Wed Jun 30 11:59:12 + 
2010 ---
Created an attachment (id=70317)
one possibility


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 112815] vcl: ImplFontCharMap::Get DefaultMap can't possibly be right

2010-06-30 Thread pl
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112815


User pl changed the following:

What|Old value |New value

 Assigned to|pl|hdu





--- Additional comments from p...@openoffice.org Wed Jun 30 12:07:36 + 
2010 ---
@hdu: please have a look

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 112815] vcl: ImplFontCharMap::Get DefaultMap can't possibly be right

2010-06-30 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112815





--- Additional comments from c...@openoffice.org Wed Jun 30 12:12:50 + 
2010 ---
No idea, I wasn't fixing anything concrete, just examine singletons in general

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 112815] vcl: ImplFontCharMap::Get DefaultMap can't possibly be right

2010-06-30 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112815


User hdu changed the following:

What|Old value |New value

  Status|NEW   |RESOLVED

  OS/Version|Linux |All

  Resolution|  |FIXED

Target milestone|---   |OOo 3.4





--- Additional comments from h...@openoffice.org Wed Jun 30 12:09:33 + 
2010 ---
Applied in CWS vcl113. Thanks for the patch!
Luckily fonts with non-unicode maps became quite rare, aren't they?


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 112815] vcl: ImplFontCharMap::Get DefaultMap can't possibly be right

2010-06-30 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112815





--- Additional comments from h...@openoffice.org Wed Jun 30 12:13:47 + 
2010 ---
And especially non-CMAP30 symbol fonts should be extremely rare.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org