[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 User pl changed the following: What|Old value |New value Assigned to|pl|hdu --- Additional comments from p...@openoffice.org Thu Nov 25 12:39:16 + 2010 --- @hdu: please verify in CWS vcl117 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 User hdu changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from h...@openoffice.org Thu Nov 25 12:57:52 + 2010 --- V. Good riddance! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from p...@openoffice.org Wed Nov 24 10:56:47 + 2010 --- I'd like to proceed with this removal now that I have the patch, if you want to keep some of that old code, please tell me. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from yda...@openoffice.org Wed Nov 24 16:27:32 + 2010 --- I looked at diffs, and I see it affects a lot of files; it seems more interesting to work on OS/2 Native control interface instead of resurrecting some redrawing code, which in effect will still not match current OS/2 lookfeel because of UI enhancers. Keeping only a part of such code does not make sense, so drop all of it. I don't think it will help in writing an os2 nwf. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from p...@openoffice.org Wed Nov 24 16:31:11 + 2010 --- Thanks for your input. I'll commit these changes then. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 User pl changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from p...@openoffice.org Wed Nov 24 17:58:32 + 2010 --- Committed in CWS vcl117. If you need any help with the independent part of vcl when implementing NWF for OS/2 please don't hesitate to ask. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from yda...@openoffice.org Wed Nov 24 18:01:52 + 2010 --- sure! thanks! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from p...@openoffice.org Mon Nov 22 10:19:28 + 2010 --- these remnants are scattered over the different controls - there is something in vcl/source/control/button.cxx for CheckBoxes and RadioButtons (which mostly is done by loading a different image for the control) - there is some code left (mostly commented out !) in vcl/source/control/tabctrl.cxx that was for single lined and differently colored tabs - floating windows could have had different decoration which is in vcl/source/window/decoview.cxx - scrollbars were drawn a little diferently (with a checkered thumb) in vcl/source/control/scrbar.cxx - sliders were drawn with a depressed thumb in vcl/source/control/slider.cxx All of this is either commented out or could not be activated since the integration of the original NWF CWS. As far as I can see removing this is safe, but I wanted you on CC nonetheless since I don't have a OS/2 box available. The other old platform stuff (drawing like Motif or MacOS/9) I can guarantee is useless. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from yda...@openoffice.org Mon Nov 22 10:28:53 + 2010 --- Great! This is the code used to enable the native OS/2 look and feel in StarOffice, I thought it has been removed a long ago. Instead of removing it, I could enable it only for the OS/2 platform, so I can get something closer to OS/2. Current code is closer to old windows look. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from p...@openoffice.org Mon Nov 22 10:46:19 + 2010 --- Well, effectively most of it has been removed, it compiles just as a lot of dead code. Aside form the single line TabControl, wouldn't it be better to move the drawing code to drawNativeControl ? And btw; is this stuff from 1996 still what the OS/2 platform should look like ? At least some of the screenshots I've seen (at http://www.ecomstation.org/screenshots/ ) show different theming - depending on what application is running apparently. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from p...@openoffice.org Mon Nov 22 17:26:23 + 2010 --- If you want to keep some of this old code I can of course let it be. Please just tell me what you want to keep. I'll attach a patch with the current cleanup in this regard for you to review. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 User pl changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |75094) patch to remove old | | control style remnants --- Additional comments from p...@openoffice.org Mon Nov 22 17:27:51 + 2010 --- Created an attachment (id=75094) patch to remove old control style remnants - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 --- Additional comments from yda...@openoffice.org Sat Nov 20 15:53:44 + 2010 --- OS/2 does not use native controls, it uses standard OOo drawn controls. Where is this code? I want to look at it. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[gsl-issues] [Issue 115686] Remove old vcl style co de for controls
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=115686 Issue #|115686 Summary|Remove old vcl style code for controls Component|gsl Version|DEV300m92 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|pl Reported by|pl --- Additional comments from p...@openoffice.org Fri Nov 19 18:08:44 + 2010 --- There exists very old code in vcl to draw mac (as in MacOS 9 and older), Unix (as in Motif) and OS/2 like checkboxes and radiobuttons. This code can not really be triggered anymore since NWF (native widget framework) came around; therfore this old remnant should be removed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
