[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-11-17 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|90439 |
  is|  |

  Status|VERIFIED  |CLOSED





--- Additional comments from c...@openoffice.org Tue Nov 17 21:24:07 + 
2009 ---
integrated m65, closing

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-10-26 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671





--- Additional comments from h...@openoffice.org Mon Oct 26 11:09:46 + 
2009 ---
@cmc: please verify the changeset in CWS vcl106
http://hg.services.openoffice.org/cws/vcl106/rev/77abcd684c5b

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-10-26 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User cmc changed the following:

What|Old value |New value

  Status|RESOLVED  |VERIFIED





--- Additional comments from c...@openoffice.org Mon Oct 26 11:48:36 + 
2009 ---
that's the way I think it works anyway, and if not then the asserts will trigger
if the assumptions are wrong.

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-10-13 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User hdu changed the following:

What|Old value |New value

  Status|STARTED   |RESOLVED

  Resolution|  |FIXED





--- Additional comments from h...@openoffice.org Tue Oct 13 14:00:28 + 
2009 ---
Applied in CWS vcl106. Thanks again!

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-10-12 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User hdu changed the following:

What|Old value |New value

  Status|REOPENED  |STARTED





--- Additional comments from h...@openoffice.org Mon Oct 12 14:34:50 + 
2009 ---
@cmc: thanks for the patch! AFAIK the related change for 
vcl/source/fontsubset/gsub.cxx is still missing 
for proper PSprinting and PDF export. Yes this file should be merged with the 
other one now that psprint 
is merged into vcl... its on my todo list

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-10-12 Thread hdu
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User hdu changed the following:

What|Old value |New value

  OS/Version|Linux |Unix, X11

Target milestone|---   |OOo 3.3





--- Additional comments from h...@openoffice.org Mon Oct 12 14:36:21 + 
2009 ---
@cmc: forget the comment above after the thanks for the patch! :-)

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-10-01 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User cmc changed the following:

What|Old value |New value

OtherIssuesDependingOnTh|  |90439
  is|  |





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-09-30 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User cmc changed the following:

What|Old value |New value

 Summary|With Fedora's Sazanami fon|GSUB Coverage Format 2 han
|ts vertical writing looks |dling (Fedora Sazanami Fon
|bad   |t)





--- Additional comments from c...@openoffice.org Wed Sep 30 13:53:28 + 
2009 ---
So I finally got around to having a look at what got broken in the Fedora
Sazanami font and 

a) loading the original unmodified font with fontforge and saving it gives a
font which shows as broken
b) loading the original unmodified font with ttx from fonttools and saving it
gives a font which shows as broken

Digging into the diffs from original to re-saved I see that the difference is in
the CoverageFormats. The original has Coverage Format 1 while the ones saved by
the two different tools have Coverage Format 2 in use (it produces slightly
smaller .ttf files for this font, which is presumably why both tools favour it
for Sazanami)

So reading http://www.microsoft.com/typography/otspec/CHAPTER2.htm I'm not sure
that we're handling this coverage format right in OOo.

It says that for the simpler format 1 When a glyph is found in the Coverage
table, its position in the GlyphArray determines the Coverage Index that is
returned-the first glyph has a Coverage Index = 0, i.e. in our implementation
the first glyph is placed as the first element in aSubstVector and so on. 

While for format 2 it says that Coverage Index (GlyphID) = StartCoverageIndex +
GlyphID - Start GlyphID. for each range. Our implementation is doing... 


for( USHORT j = nGlyph0; j = nGlyph1; ++j )
aSubstVector.push_back( GlyphSubst( j + nCovIdx, 0 ) );

I suspect that it should basically be...

for( USHORT j = nGlyph0; j = nGlyph1; ++j )
aSubstVector[nStartCoverageIndex + j - nGlyph0] = j

i.e. the coverageindex is the index into out aSubstVector.

This would only be noticeable where a font has more than one range as the first
range always has a coverageindex of 0

-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-09-30 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User cmc changed the following:

What|Old value |New value

 Attachment is patch|  |Created an attachment (id=
|  |65062)
assuming that I'm r
|  |ight, this is closer to th
|  |e truth






--- Additional comments from c...@openoffice.org Wed Sep 30 13:54:13 + 
2009 ---
Created an attachment (id=65062)
assuming that I'm right, this is closer to the truth


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-09-30 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671


User cmc changed the following:

What|Old value |New value

  Issue type|DEFECT|PATCH





-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org



[gsl-issues] [Issue 92671] GSUB Coverage Format 2 han dling (Fedora Sazanami Font)

2009-09-30 Thread cmc
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=92671





--- Additional comments from c...@openoffice.org Wed Sep 30 13:58:16 + 
2009 ---
Created an attachment (id=65063)
example font


-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

-
To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org
For additional commands, e-mail: issues-h...@gsl.openoffice.org


-
To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org
For additional commands, e-mail: allbugs-h...@openoffice.org