[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User r0polach changed the following: What|Old value |New value CC|'er,jmills,kohei,maremv,ml|'er,jmills,kohei,maremv,ml |oiseleur,rpolach,sgauti,st|oiseleur,r0polach,rpolach, |' |sgauti,st' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sc.openoffice.org For additional commands, e-mail: issues-h...@sc.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Mon Apr 21 13:04:46 + 2008 --- @kingshome: this patch has been integrated into 2.4, so whatever problem you have is a new problem. Please file a separate issue (or try to find an existing issue if exists) describing the problem you're experiencing. Thanks! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Mon Apr 21 05:42:16 + 2008 --- Does the 'fixed' label on this issue refer to ooo 2.4 or the upcoming ooo 3? The reason I ask is because a problem I found in an xls file still hasn't been resolved in ooo 2.4. I thought it was caused by the problem with INDIRECT, but if this issue has now been resolved, I'll have to look for other reasons. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User fst changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from [EMAIL PROTECTED] Mon Feb 11 11:17:46 + 2008 --- found integrated on master OOHm5 using Linux, Solaris and Windows builds - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User fst changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from [EMAIL PROTECTED] Wed Jan 16 13:57:19 + 2008 --- found fixed on cws kohei01 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User kohei changed the following: What|Old value |New value Assigned to|kohei |fst --- Additional comments from [EMAIL PROTECTED] Fri Dec 21 14:48:06 + 2007 --- reassigning to fst for verification - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User er changed the following: What|Old value |New value CC|'jmills,kohei,maremv,mlois|'er,jmills,kohei,maremv,ml |eleur,rpolach,sgauti,st' |oiseleur,rpolach,sgauti,st | |' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User kohei changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from [EMAIL PROTECTED] Fri Dec 14 20:06:01 + 2007 --- fixed in SRC680/kohei01 cws. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User er changed the following: What|Old value |New value Issue type|FEATURE |PATCH Subcomponent|ui|code Target milestone|OOo Later |OOo 2.4 --- Additional comments from [EMAIL PROTECTED] Thu Nov 15 09:11:54 + 2007 --- Much appreciated, Kohei, thank you! - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User kohei changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |49656) patch built upon Mi | |chel's earlier patch (SRC6 | |80_m236) --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 18:24:55 + 2007 --- Created an attachment (id=49656) patch built upon Michel's earlier patch (SRC680_m236) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 18:27:56 + 2007 --- Hi *, I had to work on this issue per customer request. I basically applied Michel's patch, cleaned up a bit, and applied the same principle to INDIRECT_XL as well (INDIRECT_XL is disabled upstream at the moment). Jody mentioned to cover named expressions, but IMO that should be a separate issue to tackle as this patch alone solves many users' problems. Kohei - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 19:53:42 + 2007 --- I'm still working on handling the relative reference. So, the patch I just posted only works reliably. Expect an additional patch soon. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 20:01:16 + 2007 --- Fine patch, thanks. As discussed on IRC, the case when the defined name contains relative references needs to be handled though, else users will rely on a result of foo:=B3 being identical to foo:=$B$3. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 20:06:07 + 2007 --- bah! I meant to say the patch I just posted only works reliably _on named ranges containing absolute references_. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 20:23:18 + 2007 --- -kohei: It's a nice and pretty way to have one line for exit. I really like your improvement of your patch. Thanks a lot for showing me this cool approach. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 21:22:45 + 2007 --- I think I got it. All I did was follow Eike's fine instructions. It was pretty much painless. ;-) mloiseleur: yup, that is a well-known (and very useful) construct when you need to emulate a try-catch block where you can't really use exceptions. It also helps reduce indentations which helps readability. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User kohei changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |49659) revised patch to ha | |ndle relative references ( | |SRC680_m236) --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 21:17:54 + 2007 --- Created an attachment (id=49659) revised patch to handle relative references (SRC680_m236) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User kohei changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |49660) fixed memory leak - | | delete temporary ScTokenA | |rray instance when going o | |ut of scope. --- Additional comments from [EMAIL PROTECTED] Wed Nov 14 21:41:20 + 2007 --- Created an attachment (id=49660) fixed memory leak - delete temporary ScTokenArray instance when going out of scope. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Thu Nov 15 04:12:25 + 2007 --- @kohei,er: so the target should be moved from OOoLater to OOo 2.4 ? - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User kohei changed the following: What|Old value |New value CC|'jmills,maremv,mloiseleur,|'jmills,kohei,maremv,mlois |rpolach,sgauti,st'|eleur,rpolach,sgauti,st' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Mon Jul 9 10:12:04 + 2007 --- *** Issue 79354 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Fri Jun 1 11:57:39 + 2007 --- - jodygoldberg : Do you have any clues on how to do that easily ? So I can update my patch ? Regards, - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Fri May 25 18:26:31 + 2007 --- Although XL seems to limit the content of the names to be simple, I don't see why we want to continue that. In which case the same problem that arose with the validation lists comes up, how to interpret a general tokenarray in a context outside a cell. eg define FOO as IF(A1;A2;A3) =INDIRECT(FOO) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Fri May 25 21:04:04 + 2007 --- XL compat will also require support for parsing Sheet!name - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Thu Apr 19 13:26:44 + 2007 --- Hi Michel, Relative references are displayed without the dollar character, in the names dialog you may define them by editing the reference and removing the dollars, for example modify $Sheet1.$A$1 to $Sheet.A1 The relative reference generated then depends on the position of the cell cursor when you opened the name dialog, for example if the current cell is B2, a reference of A1 actually means one row up and one column to the left. If you reopen the dialog on a different cell the reference of that named range displayed is adjusted accordingly. Note that the requirement I copied above actually has an error stating (ScInterpreter::aPos member variable), for Excel compatibility this is exactly not the case, but named relative references for the INDIRECT function are based on A1 instead. Weird, and IMHO wrong, but that's how Excel does it. Excel doesn't know relative sheet references in named ranges, but Calc does, so the address to pass from within ScInterpreter::ScIndirect() probably should be ScAddress( aPos.Tab(), 0, 0) Heck, 3 lines for return, you're hard with me, I don't like code too long :). Well, the more common errors have convenience functions, such as SetIllegalArgument() that sets the error and pushes a value, so one line less to code, an errUnknownState just isn't that usual.. I will do the change to pData and for premature return in a patch. My CWS is not here, but it's coming nicely and surely, thanks Sophie ^_^. Huh? Does hat mean you want to create your own CWS for this? Do you already have CVS write access, which is needed to do so? Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User mloiseleur changed the following: What|Old value |New value Attachment data| |Created an attachment (id= | |44510) A patch which tries | | yo fix it --- Additional comments from [EMAIL PROTECTED] Wed Apr 18 12:11:34 + 2007 --- Created an attachment (id=44510) A patch which tries yo fix it - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Apr 18 12:13:18 + 2007 --- Hello there, Here is a patch which fix this issue. Hope this helps. Regards, - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User fst changed the following: What|Old value |New value Issue type|FEATURE |PATCH --- Additional comments from [EMAIL PROTECTED] Wed Apr 18 13:05:04 + 2007 --- changed Issue Type to PATCH - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User sgauti changed the following: What|Old value |New value CC|'jmills,maremv,rpolach,st'|'jmills,maremv,rpolach,sga | |uti,st' --- Additional comments from [EMAIL PROTECTED] Wed Apr 18 13:27:16 + 2007 --- adding me to cc - sophie - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=4695
User er changed the following:
What|Old value |New value
CC|'jmills,maremv,rpolach,sga|'jmills,maremv,mloiseleur,
|uti,st' |rpolach,sgauti,st'
Issue type|PATCH |FEATURE
--- Additional comments from [EMAIL PROTECTED] Wed Apr 18 15:01:16 +
2007 ---
Hi Michel,
Thanks for contributing. The patch generally takes the right approach,
but doesn't handle relative references. I'll restate the requirement
from #desc25 here:
- Relative reference parts need a special handling, and to be Excel
compatible the relative offsets have to be calculated with a basis of
A1 and wrapped around the sheet if negative. I suggest to create
another ScRangeData::IsReference() method that additionally takes
a ScAddress position (ScInterpreter::aPos member variable), same for
ScTokenArray::IsReference(), and enhance
ScTokenArray::ImplGetReference() to take account of an optional
position address passed in.
To accomplish that, the easiest and safest would be to clone the
ScTokenArray (pCode) in the newly to be implemented
ScRangeData::IsReference() method, stuff it into a compiler instance and
call MoveRelWrap(), similar to what is done in
ScRangeData::UpdateSymbol(), and then call the newly to be created
ScTokenArray::IsReference().
Btw, interpreter functions should never simply return without having set
an error value and/or pushed a result. The reason I mention this is the
line
+ if (rData == NULL) return;
of your patch. Btw2, in our naming conventions rData should be named
pData instead, since it is a pointer. If a premature return is needed,
the code instead should be something like
if (pData == NULL)
{
SetError(errUnknownState);
PushInt(0);
return;
}
Please note that to integrate code or data contributed we need a signed
Joint Copyright Assignment form (JCA) filled-out, see
http://contributing.openoffice.org/programming.html#jca
Thanks
Eike
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=4695
--- Additional comments from [EMAIL PROTECTED] Wed Apr 18 16:15:41 +
2007 ---
Thanks for your answer Eike. Here is mine :
- Relative reference parts need a special handling, and to be Excel
compatible [...]
Can you please explain to me what exactly is a relative reference ? My patch
works well on samples documents.
Btw, interpreter functions should never simply return without having set
an error value and/or pushed a result. The reason I mention this is the
line
+ if (rData == NULL) return;
Ok. I didn't really know what error should be returned. It was more for escaping
segv than anything else. It's not supposed to be an error in first place. But
you're right.
of your patch. Btw2, in our naming conventions rData should be named
pData instead, since it is a pointer. If a premature return is needed,
the code instead should be something like
if (pData == NULL)
{
SetError(errUnknownState);
PushInt(0);
return;
}
Heck, 3 lines for return, you're hard with me, I don't like code too long :).
I will do the change to pData and for premature return in a patch. My CWS is not
here, but it's coming nicely and surely, thanks Sophie ^_^.
Regards,
Michel
-
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Tue Apr 3 11:27:44 + 2007 --- Is there any chance of this issue being dealt with in 2.3? It's been around for 5 years without resolution. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Mar 21 12:46:28 + 2007 --- Is an solution in nearer future possible? Thanks. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Mar 21 13:03:00 + 2007 --- William (maremv) volunteered to work on this, don't know about progress. William, how are things proceeding? Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Mar 21 13:27:49 + 2007 --- Thanks er, this Issue is very important for our company. We want that all users use Open Office, but without this function it is not possible. Our customer calculation depends on it. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Mar 21 16:50:25 + 2007 --- Sorry I just haven't had enough time to work on this. It might be best if someone else tries to fix. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Tue Jan 30 10:23:15 -0800 2007 --- *** Issue 73962 has been marked as a duplicate of this issue. *** - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Fri Jan 5 08:53:25 -0800 2007 --- Please see http://wiki.services.openoffice.org/wiki/Building_OpenOffice.org http://wiki.services.openoffice.org/wiki/Windows http://tools.openoffice.org/dev_docs/build_windows_tcsh.html - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Thu Jan 4 15:22:37 -0800 2007 --- I have been looking for a resource page on openoffice.org on the best way to compile my OO changes, but not having much luck. Can someone point me to a web page? or tell me the best set of tools to use for Win-XP? -Thanks - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User rpolach changed the following: What|Old value |New value CC|'jmills,maremv,st'|'jmills,maremv,rpolach,st' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Thu Dec 14 02:36:52 -0800 2006 --- Hi William, Yes, confirming your name is listed, so we're fine to proceed once we receive your patch. Please go ahead :-) Btw, forget the ScInterpreter::aPos member variable I mentioned above, that's nonsense since we do not want the current formula's position but A1 instead, sorry. Thanks Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Dec 13 08:47:21 -0800 2006 --- Hi Maremv, Implementation is in sc/source/core/tool/interpr1.cxx method ScInterpreter::ScIndirect(). After the calls to ConvertDoubleRef() respectively ConvertSingleRef() the else path containing just SetIllegalArgument() right now must be extended: - check whether the string matches a defined name, similar to sc/source/core/tool/compiler.cxx ScCompiler::IsNamedRange(), but without creating a token, instead - check whether the range data consists of just one single cell or a range, other data like multiple ranges or formula fragments are not valid. You may use pRangeData-IsReference() for this. - Relative reference parts need a special handling, and to be Excel compatible the relative offsets have to be calculated with a basis of A1 and wrapped around the sheet if negative. I suggest to create another ScRangeData::IsReference() method that additionally takes a ScAddress position (ScInterpreter::aPos member variable), same for ScTokenArray::IsReference(), and enhance ScTokenArray::ImplGetReference() to take account of an optional position address passed in. I suggest to refrain from trying to handle the external reference case at this stage, which would unnecessarily complicate things, and let it be a separate issue instead. However, if you feel confident that could be accomplished by digging deep into the lcl_ScAddress_Parse_...() methods of sc/source/core/tool/address.cxx Please note that to integrate code or data contributed we need a signed Joint Copyright Assignment form (JCA) filled-out, see http://contributing.openoffice.org/programming.html#jca To be able to lookup your name in the list of approved assignments I'd appreciate if you stated your full name here in this issue. Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Wed Dec 13 15:22:38 -0800 2006 --- I Have already filled out one of thoes forms and emailed it to [EMAIL PROTECTED] My full name is William Neil Hall. Thanks for the point in the right direction, now let me dig in a little. -Thanks - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Tue Dec 12 21:02:15 -0800 2006 --- Sorry about the delay on this, I just got an email today that reminded me that I said I would fixthis... Ok I looked back at the source code I had downloaded when I originally was looking at this problem and remembered quickly that I could not really find any kind of structure to this program. To save me alot of time (because I'm guessing some of the people on this board know this program pretty well) I need to be pointed to the following: Where What is the source file/function name that has the function INDIRECT in it? Where What is the source file/function name that allows you to place =named field into a cell and it will do the look up of that cell name and place the value of that named cell into the cell? Where What is the source file/function name that allows cells values to be looked up out of external spread sheets so I can make the following work as requested in one of the messages below: =indirect( 'file://path-to-file.sxc#named_cell' ) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User er changed the following: What|Old value |New value CC|'jmills,st' |'jmills,maremv,st' --- Additional comments from [EMAIL PROTECTED] Thu Jul 13 06:35:11 -0700 2006 --- Maremv, Sure, working patches are welcome. Do you already have a fix in mind? Eike - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Thu Jul 13 19:40:42 -0700 2006 --- Nope, I have not even looked at the code yet. I just wanted to make sure I was not duplicating work. I will begin looking into the fix -Thanks - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 User st changed the following: What|Old value |New value CC|'jmills' |'jmills,st' - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[sc-issues] [Issue 4695] INDIRECT function fails wit h named cells
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=4695 --- Additional comments from [EMAIL PROTECTED] Thu Jul 6 16:19:54 -0700 2006 --- Is this going to be fixed soon? if not I can fix submit - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
