[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User cmc changed the following: What|Old value |New value Status|VERIFIED |CLOSED --- Additional comments from c...@openoffice.org Tue Dec 1 20:28:55 + 2009 --- closed, integrated m66 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User cmc changed the following: What|Old value |New value Status|RESOLVED |VERIFIED --- Additional comments from c...@openoffice.org Wed Nov 11 09:02:31 + 2009 --- I probably should have thought that through a bit better before throwing it over the wall. Anyway, goal achieved. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User mst changed the following: What|Old value |New value CC|''|'sb' --- Additional comments from m...@openoffice.org Tue Nov 10 15:21:26 + 2009 --- so, it turns out this crashes and burns in cwscheckapi: (dbx) where [1] __lwp_kill(0x1, 0x6), at 0xfef75687 [2] _thr_kill(0x1, 0x6), at 0xfef72dee [3] raise(0x6), at 0xfef211bb [4] abort(0xf7e267b4, 0xf7e267b4, 0xf748ffd9, 0x80458ec, 0xf748d3fa, 0x80458e0), at 0xfef01570 [5] __Crun::pure_error(0x80458e0, 0x8cd02f0), at 0xfee9656a =[6] ThreadListener::ListenToThread(this = 0x8dd9b70, nThreadID = 1, rThread = CLASS), line 52 in threadlistener.cxx [7] ThreadManager::AddThread(this = 0x8cd02f0, rThread = CLASS), line 98 in threadmanager.cxx [8] SwThreadManager::AddThread(this = 0xf80c292c, rThread = CLASS), line 74 in swthreadmanager.cxx [9] SwAsyncRetrieveInputStreamThreadConsumer::CreateThread(this = 0x8bddc60, rURL = CLASS), line 66 in retrieveinputstreamconsumer.cxx the reason seems to be that the SwThreadManager is returned by value in the operator(). so the dtor of the temporary is called, deletes the pImpl, but the copy still refers to it. unfortunately it turns out that simply using rtl::Static (as suggested by sb) does not work, because a) rtl::Static::StaticInstance cannot call SwThreadManager ctor because ctor is private b) rtl::Static::StaticInstance cannot be a friend of SwThreadManager because StaticInstance is private [of course the thing that one really wants here (SwThreadManager ctor not in header at all) is not possible in C++ anyway.] somehow this seems rather half-baked... so i'm making SwThreadManager ctor public, that will at least compile :) see here: http://hg.services.openoffice.org/hg/cws/sw33bf01/rev/800dfb17b8f4 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User mst changed the following: What|Old value |New value Assigned to|mst |cmc --- Additional comments from m...@openoffice.org Tue Nov 10 17:52:08 + 2009 --- please verify - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User od changed the following: What|Old value |New value Assigned to|od|mst Status|STARTED |NEW --- Additional comments from o...@openoffice.org Thu Oct 29 10:23:22 + 2009 --- OD-MST: take over as discussed. - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User mst changed the following: What|Old value |New value Status|NEW |RESOLVED Resolution| |FIXED --- Additional comments from m...@openoffice.org Thu Oct 29 17:56:42 + 2009 --- fixed in CWS sw33bf01. http://hg.services.openoffice.org/hg/cws/sw33bf01/rev/696274e44a02 - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User od changed the following: What|Old value |New value Status|NEW |STARTED Target milestone|--- |OOo 3.3 --- Additional comments from o...@openoffice.org Mon Oct 12 08:23:12 + 2009 --- Thx CMC. I will take care of this patch in order to get it integrated into the next release - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 Issue #|105643 Summary|sw: use rtl::Static pattern for SwThreadManager Component|Word processor Version|DEV300m60 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|od Reported by|cmc --- Additional comments from c...@openoffice.org Tue Oct 6 11:14:16 + 2009 --- We've got some templates and helpers in rtl for singletons. The attached patch moves SwThreadManager over to one of those patterns. (A handy side effect is that the currently impossible-to-call destructor becomes at least theoretically possible to be called, though not in practice at the moment, removing ~SwThreadManager from the lists of unused methods and leaked resources) - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
[sw-issues] [Issue 105643] sw: use rtl::Static patte rn for SwThreadManager
To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=105643 User cmc changed the following: What|Old value |New value Attachment is patch| |Created an attachment (id= | |65167) like so --- Additional comments from c...@openoffice.org Tue Oct 6 11:15:23 + 2009 --- Created an attachment (id=65167) like so - Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification - To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org - To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
