Re: [alto] Comments on draft-zhang-alto-oam-yang-01

2022-02-08 Thread Jensen Zhang
Hi Qiao,

Thanks for your review. See my quick response inline.

Thanks,
Jensen


On Tue, Feb 8, 2022 at 9:26 PM Qiao Xiang  wrote:

> Dear all,
>
> The following are some comments on draft-zhang-alto-oam-yang-01:
>
> 1. Title: Yang -> YANG
>

Good point.


>
> 2. Introduction: "The basic propose" -> "The basic purpose"
>
> 3. Section 4:  "Table 2: Support configuration for information resource
> generation algorithms"
> Later in 4.1: "This document does not define any data model related to
> specific implementation, including:
> *  Specific algorithms for ALTO information resource generation."
> And later in 5.3.1., an example of information resource creation
> algorithm is given.
>
>This is confusing. Does the ALTO OAM data model support or not support
> algorithm implementation?
>

The data model does not support algorithm implementation. But it allows
people to define API for specific algorithm implementation.


> What are the differences between "configuration for information resource
> generation algorithm", "information resource generation algorithm" and
> "information resource creation algorithm"?
>

We will make the text consistent.


>
>
>
> 4. Section 5.3 " For some resource-type, the parameter of the intent
> interface MUST also include the a dependency node containing the
> resource-id of the dependent ALTO information resources (See Section 9.1.5
> of [RFC7285])."
>
>This is vague. What is "some resource-type"? Is it an information
> source that has "uses" attribute? Need to make it clear.
>

Good point. Yes, we are talking about the information resource that has
"uses" attribute. Will make it clear.


>
> 5. Section 5.3   "One categories" -> "One category"
>  "The other categories" -> "The other category"
>  "altorithms" -> "algorithms"
>
> 6. Section 5.3 "Except for the ird resource, all the other types of
> resource entries have augmented algorithm node."
> -> "an augmented algorithm node"? or "may have an augmented algorithm
> node"?
>

That is a "MUST" statement. Will make it clear.


>
> 7. Section 5.4   "To use the reactive update, the reactive attribute MUST
> be set true. To use the proactive update, the poll-interval attribute MUST
> be greater than zero." ...
> "If reactive is false or poll-interval is zero, the ALTO server will
> not update the data source."
>
> What if reactive attribute is set to true, and the poll-interval
> attribute is also set to be greater than zero?
>

It will not append. The "(update-policy)" node is a "choice" node. It means
that either "(reactive)" case or "(proactive)" case can be present. If both
of them are present, the message violates the syntax.


>
> 8. Section 5.4.1 "Yang" -> "YANG"
>
> 9. Section 5.4.2: what is the purpose of defining a Prometheus data
> source? What about other time-series database, e.g., InfluxDB?
>

Thanks for the suggestion. This part is not complete. But this document
will not define data models for all the potential data sources. This
section will only cover examples for some popular data sources based on our
experience. But which one should be put on this section is an open topic so
far.


>
>
> Best
> Qiao
> --
> Qiao Xiang
> Professor, Xiamen University
> ___
> alto mailing list
> alto@ietf.org
> https://www.ietf.org/mailman/listinfo/alto
>
___
alto mailing list
alto@ietf.org
https://www.ietf.org/mailman/listinfo/alto


Re: [alto] Comments on draft-zhang-alto-oam-yang-01

2022-02-08 Thread Jensen Zhang
Hi Qiufang,

Many thanks for your comments and YANG code! We will use your YANG code as
a base to complete our next revision. Thanks for your contribution.

Your comments on the scope of this document are also very valuable.

Thanks,
Jensen

On Sat, Jan 29, 2022 at 5:13 PM maqiufang (A)  wrote:

> Hi, authors,
>
> Thanks for writing this draft.
> As Adrian mentioned, there is no YANG code in this document.
> I tried to work it out according to the given YANG tree diagram. Please
> refer to the attachment, which I hope can help to make this work more
> complete


> In general, I think the scope still needs to clean up, i.e., what is in
> the scope, what is not in the scope. The relation between objectives and
> requirements are not clear. I think requirements should completely align
> with section 16 of RFC7285.
> Requirements in Section 3.2 and Section 3.4 of RFC7971 should also be
> considered.


> Here are few detailed comments:
> 1.Section 4
> The requirements are only selected from section 16.1, section 16.2.2,
> section 16.2.4, section 16.2.5, section 16.2.6, what about other sections?
>

This is a very good point. Other reviewers also mentioned this. We will
align with considerations proposed by RFC7285.


> Do we need to configure granularity of the topology map and cost map?
> e.g., configure default two PIDs, default cost between source PID and dst
> PID?
> How filter service is modelled? How do we set filter input as empty?
> How do we model network information from other entities such as
> geo-location, or round trip time measurement?


> How do we model using other protocol such as IGP BGP to collect
> information and fed into ALTO server


> How do we provide monitoring information to service provider? E.g.,
> monitoring correctness, responsive of ALTO server
> How do we allow disable ALTO guidance for a portion of ALTO client by
> time, geographical region or other criteria?
>

Many thanks. Those are very good questions to help us complete the missing
parts of this document.


> 2.Section 4
> How logging and fault management is modelled in this draft?
> Should we configure ALTO server to provide logging service? E.g., using
> syslog
> Do we need to define control module to provide logging or fault management?
> You might reference rfc8194 for example
>

Yes, as Sec 16.1 and Sec 16.3 of RFC7285 suggest, logging and fault
management should be considered.
Thanks for the reference.


> 3.Section 4.1 said:
> "
> Data model for performance monitoring for operation purpose
> "
> OAM or FCAPS should comprise of not only performance monitoring, but also
> fault management, security management, configuration management?
> Do we leave fault management beyond scope of this document?
>

It should be on the scope. But we need more discussion about how to model
this part.


> 4.Section 4.1 said:
> "
>*  Data structures for how to store/deliver ALTO information
>   resources (e.g., network map, cost map, property map).
>*  Specific algorithms for ALTO information resource generation.
>*  Data structures for how to store information collected from data
> sources.


> "
> What is the relationship between bullet 1 and Bullet 3?
>

Bullet 1 is about the data structure for ALTO maps generated by the ALTO
server.
Bullet 2 is about the raw data from different data sources, e.g., i2rs
topology, routing tables, lsdb.


> 5.Section 4.2 title
> What is the relation between requirements and Objectives?
>

We will merge the two parts into a single section.


> 6.Section 5.1
> s/ adminstrated/administrated
> 7.Section 5.3
> s/resoruce/resource
> s/ altorithms/algorithm


>
> Best Regards,
> Qiufang Ma
___
alto mailing list
alto@ietf.org
https://www.ietf.org/mailman/listinfo/alto