Re: Patches used by Debian on amanda

[Jon LaBadie]

On Sun, Jan 08, 2017 at 06:35:39PM +, Jose M Calhariz wrote:
> I am reviewing the patches used by Debian to build amanda 3.3.9 and
> updating them for amanda 3.4.1.  I think some of them are not specific
> to Debian.  My plan is to present the patches here so they can be 
> reviewed for adoption or not.
> 
> The first batch are about small English mistakes in documentation that
> lintian complains.
> 
> In attach there is 3 patches.
> 
> Kind regards
> Jose M Calhariz
> 
> 
No comment on first, editorial suggestion on second,
and comment on third.
> 
> -- 
> --
> Erro de usuário: Troque o usuário e pressione qualquer tecla para continuar.

> Description: Fix miss spelling that are pointed by lintian.
> Author: Jose M Calhariz 
> 
> Index: amanda-3.4.1/man/amanda-auth.7
  [snip]
> ===
> --- amanda-3.4.1.orig/man/amanda-changers.7   2017-01-08 17:17:49.620890682 
> +
> +++ amanda-3.4.1/man/amanda-changers.72017-01-08 17:17:49.620890682 
> +
> @@ -132,7 +132,7 @@ define changer aggregate {
>  tpchanger "aggregate"
>  .fi
>  .PP
> -This changer driver allow to use two or more changers or standalone drive in 
> sequence\&.
> +This changer driver allow one to use two or more changers or standalone 
> drive in sequence\&.

This changer driver allows the use of two or more changers or standalone drives 
in sequence\&.
 ^^^
>  .SS "Properties"
>  .PP
>  LOCK\-TIMEOUT
> Index: amanda-3.4.1/man/amanda-devices.7
> ===
> --- amanda-3.4.1.orig/man/amanda-devices.72017-01-08 17:17:49.620890682 
> +
> +++ amanda-3.4.1/man/amanda-devices.7 2017-01-08 17:17:49.620890682 +

I have amanda 3.3.3 and 3.3.9 systems in use.  The text is very different
and conflicting (see below).  Assuming the newer is correct my editorial
suggestions are:
> @@ -778,7 +778,7 @@ INDIRECT
>  .RS 4
>  
>  (read\-write) The default in "yes"\&. You can set it to "no" if the ndmp 
> server
 is  Set INDIRECT   to "no" if the ndmp 
server

> -allow to set a window length to 0\&.
> +allow one to set a window length to 0\&.
   can be set toa window length of 0.

>  .RE
>  .PP
>  NDMP_AUTH

Here is the text of the two amanda versions:

3.3.3
  (read-write) Set to "yes" if the ndmp server doesn't allow
  to set a window length to 0.  The default is "no".

3.3.9
  (read-write) The default in "yes". You can set it to "no"
  if the ndmp server allow to set a window length to 0.

Obviously the defaults are opposite and should be confirmed.

But I wonder about the semantics of the INDIRECT parameter.
As described,

  YES means CAN NOT set to ZERO
  NO  means CAN set to ZERO

That may be correct, just seems unusual semantics.

Jon
-- 
Jon H. LaBadie j...@jgcomp.com
 11226 South Shore Rd.  (703) 787-0688 (H)
 Reston, VA  20190  (703) 935-6720 (C)

Re: Patches used by Debian on amanda

[Jose M Calhariz]

On Sun, Jan 08, 2017 at 12:51:45PM -0700, Charles Curley wrote:
> On Sun, 8 Jan 2017 18:35:39 +
> Jose M Calhariz  wrote:
> 
> > I am reviewing the patches used by Debian to build amanda 3.3.9 and
> > updating them for amanda 3.4.1.  I think some of them are not specific
> > to Debian.  My plan is to present the patches here so they can be 
> > reviewed for adoption or not.
> 
> Thank you, thank you.
> 
> May I request you end two irritants about the Debian version. It creates
> a user, "backup". That's fine, although "amanda", say, would avoid
> stepping on some other user named "backup".
> 
> The irritant is that debian makes the user's home
> directory /var/backups. Something else uses that directory, and I don't
> like co-mingling the two different functions.

??? Can you explain better?

> It also sets the user
> shell to "/usr/sbin/nologin" rather than to bash, which is an irritant
> on the way to using amanda over ssh.
>

I will try to search the archives for the reasoning of the decisions.

Kind regards
Jose M Calhariz


-- 
--
Erro de usuário: Troque o usuário e pressione qualquer tecla para continuar.


signature.asc
Description: Digital signature

Re: Patches used by Debian on amanda

[Charles Curley]

On Sun, 8 Jan 2017 18:35:39 +
Jose M Calhariz  wrote:

> I am reviewing the patches used by Debian to build amanda 3.3.9 and
> updating them for amanda 3.4.1.  I think some of them are not specific
> to Debian.  My plan is to present the patches here so they can be 
> reviewed for adoption or not.

Thank you, thank you.

May I request you end two irritants about the Debian version. It creates
a user, "backup". That's fine, although "amanda", say, would avoid
stepping on some other user named "backup".

The irritant is that debian makes the user's home
directory /var/backups. Something else uses that directory, and I don't
like co-mingling the two different functions. It also sets the user
shell to "/usr/sbin/nologin" rather than to bash, which is an irritant
on the way to using amanda over ssh.

-- 

The right of the people to be secure in their persons, houses, papers,
and effects, against unreasonable searches and seizures, shall not be
violated, and no Warrants shall issue, but upon probable cause,
supported by Oath or affirmation, and particularly describing the
place to be searched, and the persons or things to be seized.
-- U.S. Const. Amendment IV

Key fingerprint = CE5C 6645 A45A 64E4 94C0  809C FFF6 4C48 4ECD DFDB

Patches used by Debian on amanda

[Jose M Calhariz]

I am reviewing the patches used by Debian to build amanda 3.3.9 and
updating them for amanda 3.4.1.  I think some of them are not specific
to Debian.  My plan is to present the patches here so they can be 
reviewed for adoption or not.

The first batch are about small English mistakes in documentation that
lintian complains.

In attach there is 3 patches.

Kind regards
Jose M Calhariz



-- 
--
Erro de usuário: Troque o usuário e pressione qualquer tecla para continuar.
Description: Fix miss spelling that are pointed by lintian.
Author: Jose M Calhariz 

Index: amanda-3.4.1/man/amanda-auth.7
===
--- amanda-3.4.1.orig/man/amanda-auth.7 2017-01-08 17:17:49.620890682 +
+++ amanda-3.4.1/man/amanda-auth.7  2017-01-08 17:21:24.089181439 +
@@ -673,7 +673,7 @@ Besides user keys, SSH uses host keys to
 As Amanda will not answer this question itself, you must manually make every 
connection (server to client and client to server) that you expect Amanda to 
make\&. Note that you must use the same username that Amanda will use (that is, 
ssh client and ssh client\&.domain\&.com are distinct)\&.
 .SS "Authenticated Peer Hostnames with SSH Authentication"
 .PP
-When accepting an incoming conneciton, the SSH daemon gives Amanda information 
about the remote system in the $SSH_CONNECTION environment variable\&. Amanda 
parses this information to determine the remote address, and then performs a 
similar check to that done by the BSD authentications: the forward and reverse 
DNS entries for the remote host must match\&. As such, while SSH authentication 
can cryptographically ensure that the remote system is recognized (since it had 
a recognized secret key), its assurances about the remote host\*(Aqs identity 
are weaker and depend on the integrity of the DNS\&.
+When accepting an incoming connection, the SSH daemon gives Amanda information 
about the remote system in the $SSH_CONNECTION environment variable\&. Amanda 
parses this information to determine the remote address, and then performs a 
similar check to that done by the BSD authentications: the forward and reverse 
DNS entries for the remote host must match\&. As such, while SSH authentication 
can cryptographically ensure that the remote system is recognized (since it had 
a recognized secret key), its assurances about the remote host\*(Aqs identity 
are weaker and depend on the integrity of the DNS\&.
 .SH "SSL COMMUNICATION AND AUTHENTICATION"
 .PP
 See
Index: amanda-3.4.1/man/amanda-changers.7
===
--- amanda-3.4.1.orig/man/amanda-changers.7 2017-01-08 17:17:49.620890682 
+
+++ amanda-3.4.1/man/amanda-changers.7  2017-01-08 17:17:49.620890682 +
@@ -132,7 +132,7 @@ define changer aggregate {
 tpchanger "aggregate"
 .fi
 .PP
-This changer driver allow to use two or more changers or standalone drive in 
sequence\&.
+This changer driver allow one to use two or more changers or standalone drive 
in sequence\&.
 .SS "Properties"
 .PP
 LOCK\-TIMEOUT
Index: amanda-3.4.1/man/amanda-devices.7
===
--- amanda-3.4.1.orig/man/amanda-devices.7  2017-01-08 17:17:49.620890682 
+
+++ amanda-3.4.1/man/amanda-devices.7   2017-01-08 17:17:49.620890682 +
@@ -778,7 +778,7 @@ INDIRECT
 .RS 4
 
 (read\-write) The default in "yes"\&. You can set it to "no" if the ndmp server
-allow to set a window length to 0\&.
+allow one to set a window length to 0\&.
 .RE
 .PP
 NDMP_AUTH


fix-lintian-miss-spelling-amanda.conf.5.xml
Description: XML document


fix-lintian-miss-spelling-amanda-changers.7.xml
Description: XML document


signature.asc
Description: Digital signature